---
Thanks,
Zsombor Gegesy
/LdapDeltaUserGroupBuilder.java
(line 699)
<https://reviews.apache.org/r/56035/#comment234740>
You should use the LOG, it's not a good practice to call directly the
printStackTrace() which ends up in the consol
- Zsombor Gegesy
On Jan. 27, 2017, 7:35 p.m., Sailaja Polav
/ranger/service/XUserPermissionServiceBase.java
a5a1213
Diff: https://reviews.apache.org/r/56306/diff/
Testing
---
Thanks,
Zsombor Gegesy
/ranger/services/storm/client/StormResourceMgr.java
02f94f9
ugsync/src/main/java/org/apache/ranger/usergroupsync/AbstractMapper.java
86b621b
Diff: https://reviews.apache.org/r/56309/diff/
Testing
---
Thanks,
Zsombor Gegesy
: https://reviews.apache.org/r/56309/diff/
Testing
---
Thanks,
Zsombor Gegesy
/TestPropertiesUtil.java
7abed8e
Diff: https://reviews.apache.org/r/56496/diff/
Testing
---
Thanks,
Zsombor Gegesy
/resourcematcher/TestResourceMatcher.java
39bd056
Diff: https://reviews.apache.org/r/56497/diff/
Testing
---
Thanks,
Zsombor Gegesy
19caacdcac0ac58e39ef7204fb873672aa15
security-admin/pom.xml 5a63cb95a687bada3bf38065a7a05922c520c29e
Diff: https://reviews.apache.org/r/56578/diff/
Testing
---
Thanks,
Zsombor Gegesy
ed96773
agents-common/src/test/java/org/apache/ranger/plugin/model/validation/TestRangerValidator.java
1728c22
Diff: https://reviews.apache.org/r/56579/diff/
Testing
---
Thanks,
Zsombor Gegesy
/java/org/apache/ranger/biz/TestServiceDBStore.java
2b773dac7c7b9c3076d604f61c12ca3fd008877f
Diff: https://reviews.apache.org/r/56580/diff/
Testing
---
Thanks,
Zsombor Gegesy
iews.apache.org/r/56578/#review165317
---
On Feb. 12, 2017, 1:29 p.m., Zsombor Gegesy wrote:
>
> ---
> This is an automatically generated e-mail. To repl
/apache/ranger/biz/TestServiceDBStore.java
2b773da
Diff: https://reviews.apache.org/r/56580/diff/
Testing
---
Thanks,
Zsombor Gegesy
/TestRangerTagDefServiceBase.java
803191e23753b13277b78fba7051c18fd5eb
Diff: https://reviews.apache.org/r/56827/diff/
Testing
---
Thanks,
Zsombor Gegesy
in/src/main/java/org/apache/ranger/solr/SolrUtil.java a851c3e
security-admin/src/main/java/org/apache/ranger/util/RestUtil.java b50d161
Diff: https://reviews.apache.org/r/56887/diff/
Testing
---
Thanks,
Zsombor Gegesy
: https://reviews.apache.org/r/56888/diff/
Testing
---
Thanks,
Zsombor Gegesy
rg/r/56890/diff/
Testing
---
Thanks,
Zsombor Gegesy
://reviews.apache.org/r/56890/#review166286
-------
On Feb. 21, 2017, 3:49 p.m., Zsombor Gegesy wrote:
>
> ---
> This is an automatically generated e-mail. T
/TestRangerServiceDefServiceBase.java
b73a629
security-admin/src/test/java/org/apache/ranger/service/TestRangerTagDefServiceBase.java
803191c
Diff: https://reviews.apache.org/r/56827/diff/
Testing
---
Thanks,
Zsombor Gegesy
b7cbc59
Diff: https://reviews.apache.org/r/57372/diff/1/
Testing
---
Thanks,
Zsombor Gegesy
/57987/diff/1/
Testing
---
Thanks,
Zsombor Gegesy
d81f6b93a6847877a178c88086dea6ff8670f20e
Diff: https://reviews.apache.org/r/57988/diff/1/
Testing
---
Thanks,
Zsombor Gegesy
vices/io.druid.initialization.DruidModule
PRE-CREATION
druid/pom.xml PRE-CREATION
pom.xml 4fb62e25124bc8ddd67c349cbc440c7173ceb42f
Diff: https://reviews.apache.org/r/57990/diff/1/
Testing
---
Thanks,
Zsombor Gegesy
/src/main/java/org/apache/ranger/authorization/hadoop/config/RangerConfiguration.java
d81f6b9
Diff: https://reviews.apache.org/r/57988/diff/2/
Changes: https://reviews.apache.org/r/57988/diff/1-2/
Testing
---
Thanks,
Zsombor Gegesy
nch
- Zsombor
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57988/#review170412
---
On March 29, 2017, 3:34 p.m., Zsomb
)
-
agents-common/src/main/java/org/apache/ranger/authorization/hadoop/config/RangerConfiguration.java
d81f6b9
Diff: https://reviews.apache.org/r/57988/diff/3/
Changes: https://reviews.apache.org/r/57988/diff/2-3/
Testing
---
Thanks,
Zsombor Gegesy
-admin/src/main/java/org/apache/ranger/service/XResourceService.java
b7cbc59
Diff: https://reviews.apache.org/r/57372/diff/1/
Testing
---
Thanks,
Zsombor Gegesy
Diffs (updated)
-
agents-common/src/main/java/org/apache/ranger/authorization/hadoop/config/RangerConfiguration.java
d81f6b9
Diff: https://reviews.apache.org/r/57988/diff/4/
Changes: https://reviews.apache.org/r/57988/diff/3-4/
Testing
---
Thanks,
Zsombor Gegesy
ly generated e-mail. To reply, visit:
https://reviews.apache.org/r/57987/#review170410
---
On March 28, 2017, 9:18 a.m., Zsombor Gegesy wrote:
>
> ---
> This is an automatical
://reviews.apache.org/r/57987/diff/1-2/
Testing
---
Thanks,
Zsombor Gegesy
va/org/apache/ranger/util/RestUtil.java b50d161
Diff: https://reviews.apache.org/r/56887/diff/2/
Changes: https://reviews.apache.org/r/56887/diff/1-2/
Testing
---
Thanks,
Zsombor Gegesy
rated e-mail. To reply, visit:
https://reviews.apache.org/r/57987/#review170728
---
On March 31, 2017, 12:50 p.m., Zsombor Gegesy wrote:
>
> ---
> This is an automatical
use springs excellent Properties loading support?
- Zsombor Gegesy
On April 11, 2017, 7:34 a.m., pengjianhua wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
>
/ServiceREST.java b9f1832
Diff: https://reviews.apache.org/r/57987/diff/3/
Changes: https://reviews.apache.org/r/57987/diff/2-3/
Testing
---
Thanks,
Zsombor Gegesy
> On March 31, 2017, 3:31 p.m., Colm O hEigeartaigh wrote:
> > I'm wondering if it makes sense to make the default
> > getPolicyEngineOptions() configured via "configureDelegateAdmin"? Why not
> > just let ServiceREST do that part?
>
> Zsombor Gege
/
Changes: https://reviews.apache.org/r/57987/diff/3-4/
Testing
---
Thanks,
Zsombor Gegesy
/GrantRevokeRequest.java
Lines 81 (patched)
<https://reviews.apache.org/r/58608/#comment245725>
setClusterName is called twice.
- Zsombor Gegesy
On April 21, 2017, 3:04 p.m., bhavik patel wrote:
>
> ---
> This is an automatica
---
Thanks,
Zsombor Gegesy
/57990/diff/1-2/
Testing (updated)
---
Running a local druid cluster, creating policy, using autocomplete field for
finding datasources, etc
Thanks,
Zsombor Gegesy
e424f1c
agents-common/src/test/java/org/apache/ranger/plugin/util/PasswordUtilsTest.java
PRE-CREATION
Diff: https://reviews.apache.org/r/59606/diff/1/
Testing
---
Thanks,
Zsombor Gegesy
ptions, so the
user could solve it.
Diffs
-
agents-common/src/main/java/org/apache/ranger/plugin/util/RangerRESTClient.java
784023b
Diff: https://reviews.apache.org/r/60134/diff/1/
Testing
---
Thanks,
Zsombor Gegesy
apache.org/r/60134/diff/1-2/
Testing
---
Thanks,
Zsombor Gegesy
ges: https://reviews.apache.org/r/60134/diff/2-3/
Testing
---
Thanks,
Zsombor Gegesy
27;ve found & fixed all
- Zsombor
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60134/#review178208
---
On June 19,
,
Zsombor Gegesy
PRE-CREATION
pom.xml 3fcc4aa
Diff: https://reviews.apache.org/r/61035/diff/1/
Testing
---
Successful build on travis:
https://travis-ci.org/gzsombor/ranger/builds/255768716
Thanks,
Zsombor Gegesy
/RangerHdfsAuthorizerTest.java
PRE-CREATION
Diff: https://reviews.apache.org/r/61062/diff/1/
Testing
---
Tested locally
https://travis-ci.org/gzsombor/ranger/builds/256331500
Thanks,
Zsombor Gegesy
-CREATION
pom.xml 7ae0217
Diff: https://reviews.apache.org/r/61035/diff/2/
Changes: https://reviews.apache.org/r/61035/diff/1-2/
Testing
---
Successful build on travis:
https://travis-ci.org/gzsombor/ranger/builds/255768716
Thanks,
Zsombor Gegesy
is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61035/#review181216
-----------
On July 25, 2017, 9:10 p.m., Zsombor Gegesy wrote:
>
> ---
>
-mail. To reply, visit:
https://reviews.apache.org/r/61035/#review181450
---
On July 25, 2017, 9:10 p.m., Zsombor Gegesy wrote:
>
> ---
> This is an automatically generated e-mai
/RangerAuthorizationFilterTest.java
48b8a17
Diff: https://reviews.apache.org/r/61383/diff/1/
Testing
---
https://travis-ci.org/gzsombor/ranger/builds/260345062
Thanks,
Zsombor Gegesy
://reviews.apache.org/r/61384/diff/1/
Testing
---
https://travis-ci.org/gzsombor/ranger/builds/260348900
Thanks,
Zsombor Gegesy
/src/main/java/org/apache/ranger/plugin/client/BaseClient.java
e1f9796
Diff: https://reviews.apache.org/r/61384/diff/2/
Changes: https://reviews.apache.org/r/61384/diff/1-2/
Testing
---
https://travis-ci.org/gzsombor/ranger/builds/260348900
Thanks,
Zsombor Gegesy
- Zsombor
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61384/#review182399
---
On Aug. 4, 2017, 8:22 p.m., Zsombor Gegesy wrote:
>
>
/BaseClient.java
e1f9796
Diff: https://reviews.apache.org/r/61384/diff/3/
Changes: https://reviews.apache.org/r/61384/diff/2-3/
Testing
---
https://travis-ci.org/gzsombor/ranger/builds/260348900
Thanks,
Zsombor Gegesy
it unable to load the necessary jars, eg. guava 11.0 - which is not needed
in the end at all.
Diffs
-
security-admin/pom.xml cc39be8
Diff: https://reviews.apache.org/r/61594/diff/1/
Testing
---
https://travis-ci.org/gzsombor/ranger/builds/263479478
Thanks,
Zsombor Gegesy
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59604/#review182694
---
Ship it!
I'm not a commiter, but I like it :)
- Zs
or
example 'extra options' or some other structure. So next time, when a new
service would need a similar functionality, it could reuse the code - and not
in a 'copy-paste' sense :)
- Zsombor Gegesy
On Aug. 8, 201
/service/XUserService.java
294223b
Diff: https://reviews.apache.org/r/61624/diff/1/
Testing
---
Tested locally.
https://travis-ci.org/gzsombor/ranger/builds/264508518
Thanks,
Zsombor Gegesy
Diffs
-
agents-audit/src/main/java/org/apache/ranger/audit/provider/LocalFileLogBuffer.java
56a24ed
Diff: https://reviews.apache.org/r/62659/diff/1/
Testing
---
Tested locally, travis build:
https://travis-ci.org/gzsombor/ranger/builds/280822647
Thanks,
Zsombor Gegesy
f/1-2/
Testing
---
Tested locally, travis build:
https://travis-ci.org/gzsombor/ranger/builds/280822647
Thanks,
Zsombor Gegesy
g fix
- Zsombor Gegesy
On Oct. 2, 2017, 2:11 p.m., Colm O hEigeartaigh wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.a
/key/RangerKMSDB.java 649da30c5
Diff: https://reviews.apache.org/r/63575/diff/1/
Testing
---
https://travis-ci.org/gzsombor/ranger/builds/297898874
Thanks,
Zsombor Gegesy
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63575/#review190293
-----------
On Nov. 6, 2017, 10:22 a.m., Zsombor Gegesy wrote:
>
> --
-
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63575/#review190276
-------
On Nov. 6, 2017, 10:22 a.m., Zsombor Gegesy wrote:
>
> -
---
Run the command line tools.
Travis tests:
https://travis-ci.org/gzsombor/ranger/builds/299618293
Thanks,
Zsombor Gegesy
://rangerhost/service/users?sortBy=emailAddress
http://rangerhost/service/users?sortBy=firstName
http://rangerhost/service/users?sortBy=lastName
Thanks,
Zsombor Gegesy
.
- Zsombor Gegesy
On Nov. 17, 2017, 3:23 p.m., Colm O hEigeartaigh wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
mvn -DskipTests package assembly:assembly;
unzip -Z1 target/ranger-1.0.0-SNAPSHOT-admin.zip | sort > FILES.txt
And comparing the results with different versions. With the patch, the guava
jar appears correctly.
Thanks,
Zsombor Gegesy
/gzsombor/ranger/builds/256331500
Thanks,
Zsombor Gegesy
-
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61062/#review191583
---
On Nov. 21, 2017, 4:34 p.m., Zsombor Gegesy wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit
sort > FILES.txt
And comparing the results with different versions. With the patch, the guava
jar appears correctly.
Thanks,
Zsombor Gegesy
il. To reply, visit:
https://reviews.apache.org/r/63987/#review191693
-----------
On Nov. 22, 2017, 12:23 p.m., Zsombor Gegesy wrote:
>
> ---
> This is an automatically generated e-m
------
On Nov. 22, 2017, 12:23 p.m., Zsombor Gegesy wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63987/
> --
/256331500
Thanks,
Zsombor Gegesy
> > > for (FsAction action : Arrays.asList(FsAction.EXECUTE, FsAction.READ,
> > > FsAction.WRITE)) {
> >
> > I think the FsAction.EXECUTE is not necessary here, as we are checking
> > EXECUTE already in "traverseOnlyCheck".
>
> Zsombor Gegesy wrote:
y path could stay separated.
- Zsombor
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63987/#review191793
---
On Nov. 22, 2017, 12:23 p.m., Zsombor Gegesy wrote:
>
> ---
ting
---
Tested with executing:
mvn -DskipTests package assembly:assembly;
unzip -Z1 target/ranger-1.0.0-SNAPSHOT-admin.zip | sort > FILES.txt
And comparing the results with different versions. With the patch, the guava
jar appears correctly.
Thanks,
Zsombor Gegesy
as in the original test cases, the new code work in a compatible way, not
breaking the old tests.
- Zsombor Gegesy
On Nov. 30, 2017, 10:38 p.m., Abhay Kulkarni wrote:
>
> ---
> This is an automatically generated e-mail. To re
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64323/#review192825
---
Ship it!
Ship It!
- Zsombor Gegesy
On Dec. 5, 2017, 2:39
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64228/#review192857
---
Ship it!
Ship It!
- Zsombor Gegesy
On Dec. 2, 2017, 1:25
hdfs-agent/src/test/java/org/apache/ranger/services/hdfs/RangerHdfsAuthorizerTest.java
823cd9302
Diff: https://reviews.apache.org/r/64413/diff/1/
Testing
---
Tested locally, and with travis:
https://travis-ci.org/gzsombor/ranger/builds/312941762
Thanks,
Zsombor Gegesy
arget/ranger-1.0.0-SNAPSHOT-admin.zip | sort > FILES.txt
And comparing the results with different versions. With the patch, the guava
jar appears correctly.
Thanks,
Zsombor Gegesy
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64572/#review193693
---
Ship it!
Ship It!
- Zsombor Gegesy
On Dec. 13, 2017, 11:05
: https://reviews.apache.org/r/65079/diff/1/
Testing
---
Executed the build with python3 and python2, checked that hash is generated
from 1239 files.
Thanks,
Zsombor Gegesy
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65129/#review195343
---
Ship it!
Ship It!
- Zsombor Gegesy
On Jan. 12, 2018, 6:26
-
kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMS.java be3700ffa
Diff: https://reviews.apache.org/r/65135/diff/1/
Testing
---
Tested on a live cluster with 'hadoop key list' and playing around with various
KMS policies.
Thanks,
Zsombor Gegesy
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62532/#review196232
---
Ship it!
- Zsombor Gegesy
On Jan. 25, 2018, 5:16 a.m., Nitin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65288/#review196233
---
Ship it!
- Zsombor Gegesy
On Jan. 23, 2018, 3:49 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65418/#review196514
---
Ship it!
Ship It!
- Zsombor Gegesy
On Jan. 30, 2018, 5:33
ync/process/PolicyMgrUserGroupBuilder.java
Line 431 (original), 430 (patched)
<https://reviews.apache.org/r/65485/#comment276586>
Instead of
if (map.containsKey(x)) {
... map.get(x)
}
value = map.get(x);
if (value != null) {
... value
}
- Zsombor
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65484/#review196784
---
Ship it!
Ship It!
- Zsombor Gegesy
On febr. 2, 2018, 2:56
AuditFormatter = {
'hive' : function(model) { ... }
}
security-admin/src/main/webapp/scripts/views/reports/AuditLayout.js
Lines 1633 (patched)
<https://reviews.apache.org/r/65525/#comment277188>
The same trick could be applied.
- Zsombor Gegesy
icyService.java
Lines 331 (patched)
<https://reviews.apache.org/r/65567/#comment277189>
System.out
- Zsombor Gegesy
On Feb. 8, 2018, 12:08 p.m., bhavik patel wrote:
>
> ---
> This is an automatically generated e-ma
/authorizer/KafkaRangerAuthorizerTest.java
fb0a2c0f
plugin-kafka/src/test/resources/log4j.properties PRE-CREATION
pom.xml fa1d1c7b
ranger-kafka-plugin-shim/pom.xml f1aeee6f
Diff: https://reviews.apache.org/r/65777/diff/1/
Testing
---
Unit & local tests
Thanks,
Zsombor Gegesy
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65709/#review198209
---
Ship it!
Ship It!
- Zsombor Gegesy
On Feb. 19, 2018, 4:21
QueryStr and distinctQueryStr can be final static constant
value.
ugsync/src/main/java/org/apache/ranger/unixusersync/process/UnixUserGroupBuilder.java
Lines 184 (patched)
<https://reviews.apache.org/r/65739/#comment278322>
On error, why don't you set 'isUpdateSinkSucc = false'
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65752/#review198211
---
Ship it!
Ship It!
- Zsombor Gegesy
On Feb. 22, 2018, 10:31
+1 for Ranger 1.0 !
Regards,
Zsombor
On Sat, Feb 24, 2018 at 5:03 AM, Velmurugan Periasamy
wrote:
> +1 for Ranger 1.0 release.
>
> Thanks Sailaja for volunteering.
>
> From: pengjianhua <35573...@qq.com>
> Reply-To: "dev@ranger.apache.org"
> Date: Friday, February 23, 2018 at 4:55 AM
> To:
://reviews.apache.org/r/65777/diff/2/
Changes: https://reviews.apache.org/r/65777/diff/1-2/
Testing
---
Unit & local tests
Thanks,
Zsombor Gegesy
c/main/java/org/apache/ranger/rest/ServiceREST.java 9e4d799b
Diff: https://reviews.apache.org/r/65793/diff/1/
Testing
---
Tested locally
Thanks,
Zsombor Gegesy
1 - 100 of 406 matches
Mail list logo