Review Request 57584: RANGER-1449:There is logical inconsistency for RANGER_PID_DIR_PATH in security admin

ID_DIR_PATH parameter is empty. The setup.sh doesn't set default value and create default path. Diffs - security-admin/scripts/setup.sh 87be127 Diff: https://reviews.apache.org/r/57584/diff/1/ Testing --- Thanks, pengjianhua

Review Request 57587: The install program used SOLR_RANGER_COLLECTION attribute value in Install and Configure Solr for Ranger Audits. But there is no corresponding setting in install.properties. So t

/diff/1/ Testing --- Thanks, pengjianhua

Re: Review Request 57584: RANGER-1449:There is logical inconsistency for RANGER_PID_DIR_PATH in security admin

> On 三月 14, 2017, 12:56 p.m., Colm O hEigeartaigh wrote: > > Looks good in general, however I think it would be a good idea to preserve > > the "if [ ! $? = "0" ];then" statement, but move it after "mkdir -p > > ${RANGER_PID_DIR_PAT

Re: Review Request 57584: RANGER-1449:There is logical inconsistency for RANGER_PID_DIR_PATH in security admin

che.org/r/57584/diff/1-2/ Testing --- Thanks, pengjianhua

Re: Review Request 57584: RANGER-1449:There is logical inconsistency for RANGER_PID_DIR_PATH in security admin

> On March 14, 2017, 12:56 p.m., Colm O hEigeartaigh wrote: > > Looks good in general, however I think it would be a good idea to preserve > > the "if [ ! $? = "0" ];then" statement, but move it after "mkdir -p > > ${RANGER_PID_DIR_PATH}" on

Review Request 57725: RANGER-1465:Parse properties file error for kms

problems as follows: 1. There are invalid attribute values in globalDict variable. 2. Invalid parsing will degrade the performance of program. Diffs - kms/scripts/db_setup.py d8b4b63 kms/scripts/dba_script.py 1e264cc Diff: https://reviews.apache.org/r/57725/diff/1/ Testing --- Thanks, pengjianhua

Re: Review Request 57830: The logic of the solr_for_audit_setup installer parsing the properites file is inconsistent with the other installers. It treated these attributes as environment variable. Th

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57830/#review169696 --- Ship it! Ship It! - pengjianhua On 三月 22, 2017, 7:23 a.m

Review Request 57865: The password is not set after the user is created by install program during installing Ranger Policy Admin. We should set password like db user.

- security-admin/scripts/install.properties f323c95 security-admin/scripts/setup.sh 2e7752d Diff: https://reviews.apache.org/r/57865/diff/1/ Testing --- Thanks, pengjianhua

Re: Review Request 57865: The password is not set after the user is created by install program during installing Ranger Policy Admin. We should set password like db user.

like db user. Diffs (updated) - security-admin/scripts/install.properties f323c95 security-admin/scripts/setup.sh 2e7752d Diff: https://reviews.apache.org/r/57865/diff/2/ Changes: https://reviews.apache.org/r/57865/diff/1-2/ Testing --- Thanks, pengjianhua

Re: Review Request 57865: The password is not set after the user is created by install program during installing Ranger Policy Admin. We should set password like db user.

t; $ cat < > ${unix_user}:${unix_user_pwd} > > ! | chpasswd Ok. I fixed it and updated the patch. Thanks. - pengjianhua --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57865/

Re: Review Request 57865: The password is not set after the user is created by install program during installing Ranger Policy Admin. We should set password like db user.

like db user. Diffs (updated) - security-admin/scripts/install.properties f323c95 security-admin/scripts/setup.sh 2e7752d Diff: https://reviews.apache.org/r/57865/diff/3/ Changes: https://reviews.apache.org/r/57865/diff/2-3/ Testing --- Thanks, pengjianhua

Review Request 57873: There is invalid clause in the installer for Install and Configure Solr for Ranger Audits

/setup.sh 99a3086 Diff: https://reviews.apache.org/r/57873/diff/1/ Testing --- Thanks, pengjianhua

Re: Review Request 57873: There is invalid clause in the installer for Install and Configure Solr for Ranger Audits

- security-admin/contrib/solr_for_audit_setup/setup.sh 99a3086 Diff: https://reviews.apache.org/r/57873/diff/1/ Testing --- Thanks, pengjianhua

Review Request 58332: In the non English environment, the login fails, the browser returns garbled, we need to log in to support the internationalization of the function to solve this problem

Thanks, pengjianhua

Re: Review Request 58332: The browser returns garbled when we login ranger security admin in non-English environment. We need support the internationalization function to solve this problem

PRE-CREATION security-admin/src/main/resources/internationalization/messages_zh_CN.properties PRE-CREATION Diff: https://reviews.apache.org/r/58332/diff/1/ Testing --- tested it Thanks, pengjianhua

Review Request 58455: Run updatepolicymgrpassword.sh and updatepolicymgrpassword.py to update policy mgr password failed.

ync 2. Running updatepolicymgrpassword.sh. or updatepolicymgrpassword.py to update policy mgr password. Thanks, pengjianhua

Re: Review Request 58332: The browser returns garbled when we login ranger security admin in non-English environment. We need support the internationalization function to solve this problem

/internationalization/messages_zh_CN.properties PRE-CREATION security-admin/src/main/webapp/META-INF/applicationContext.xml 95d462b Diff: https://reviews.apache.org/r/58332/diff/2/ Changes: https://reviews.apache.org/r/58332/diff/1-2/ Testing --- tested it Thanks, pengjianhua

Review Request 58529: Some users hope that the execute programs and install configuration file of the Ranger Admin can be deployed separately when they integrate Ranger into the big data platform or b

-admin/scripts/db_setup.py 6e79151 security-admin/scripts/dba_script.py 83d6fe7 security-admin/scripts/setup.sh e77b2a9 Diff: https://reviews.apache.org/r/58529/diff/1/ Testing --- Thanks, pengjianhua

Re: Review Request 58529: Some users hope that the execute programs and install configuration file of the Ranger Admin can be deployed separately when they integrate Ranger into the big data platform

e trailing whitespace after the > > "RANGER_ADMIN_CONF" definition in both python files that could be fixed. Ok. I fixed it according to your review and rebuit the patch. Thanks. - pengjianhua --- This is an automatically generated e-mail

Re: Review Request 58529: Some users hope that the execute programs and install configuration file of the Ranger Admin can be deployed separately when they integrate Ranger into the big data platform

--- Thanks, pengjianhua

Re: Review Request 58529: Some users hope that the execute programs and install configuration file of the Ranger Admin can be deployed separately when they integrate Ranger into the big data platform

--- Thanks, pengjianhua

Re: Review Request 58529: Some users hope that the execute programs and install configuration file of the Ranger Admin can be deployed separately when they integrate Ranger into the big data platform

--- Thanks, pengjianhua

Review Request 58660: Log is very important for big data platform. The main purpose of log analysis is that we need to know who is running the service, in which machine running service, which service

name. Diffs - embeddedwebserver/scripts/ranger-admin-services.sh f2d2bf5 security-admin/src/main/webapp/WEB-INF/log4j.properties 211de86 Diff: https://reviews.apache.org/r/58660/diff/1/ Testing --- Thanks, pengjianhua

Re: Review Request 58529: Some users hope that the execute programs and install configuration file of the Ranger Admin can be deployed separately when they integrate Ranger into the big data platform

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58529/#review172879 --- Ship it! Ship It! - pengjianhua On 四月 24, 2017, 12:47 a.m

Re: Review Request 58660: Log is very important for big data platform. The main purpose of log analysis is that we need to know who is running the service, in which machine running service, which serv

log files. This will bring more work to users who use ranger and reduce collect system performance. So The new method should be more reasonable than the current method. do you think? - pengjianhua --- This is an automatically genera

Re: Review Request 58660: Log is very important for big data platform. The main purpose of log analysis is that we need to know who is running the service, in which machine running service, which serv

> On 五月 3, 2017, 1:31 a.m., Qiang Zhang wrote: > > Hi Colm, how do you see for Bosco's review? > > Colm O hEigeartaigh wrote: > Yes I'm happy with what Bosco has said, so please go ahead and update the > patch along those lines. Ok. I will up

Re: Review Request 58660: Log is very important for big data platform. The main purpose of log analysis is that we need to know who is running the service, in which machine running service, which serv

/ Testing --- Thanks, pengjianhua

Re: Review Request 58660: Log is very important for big data platform. The main purpose of log analysis is that we need to know who is running the service, in which machine running service, which serv

> On May 3, 2017, 1:31 a.m., Qiang Zhang wrote: > > Hi Colm, how do you see for Bosco's review? > > Colm O hEigeartaigh wrote: > Yes I'm happy with what Bosco has said, so please go ahead and update the > patch along those lines. > > pengjianhua wro

Review Request 59079: he SQL_CONNECTOR_JAR properity had been deleted in RANGER-1387. The invalid code should also be deleted to keep the code consistent.

. The invalid code should also be deleted to keep the code consistent in the /agents-common/scripts/enable-agent.sh. Diffs - agents-common/scripts/enable-agent.sh 14e9577 Diff: https://reviews.apache.org/r/59079/diff/1/ Testing --- Thanks, pengjianhua

Review Request 59121: Similar to RANGER-1540, the Ranger UserSync should also support the same new feature.

the same new feature. Diffs - unixauthservice/conf.dist/log4j.properties dbad541 unixauthservice/scripts/ranger-usersync-services.sh ade10ea Diff: https://reviews.apache.org/r/59121/diff/1/ Testing --- Thanks, pengjianhua

Re: Review Request 59079: he SQL_CONNECTOR_JAR properity had been deleted in RANGER-1387. The invalid code should also be deleted to keep the code consistent.

://reviews.apache.org/r/59079/diff/1-2/ Testing --- Thanks, pengjianhua

Re: Review Request 59079: he SQL_CONNECTOR_JAR properity had been deleted in RANGER-1387. The invalid code should also be deleted to keep the code consistent.

ify it using git apply --check and git am --signoff command before updated the patch. - pengjianhua --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59079/#review174321 --------

Review Request 59221: RANGER-1574:The XAAUDIT.DB.PASSWORD property had been deleted in RANGER-900. The related redundant code should be deleted for plugin installer.

able-agent.sh d13875c Diff: https://reviews.apache.org/r/59221/diff/1/ Testing --- Thanks, pengjianhua

Re: Review Request 59221: RANGER-1574:The XAAUDIT.DB.PASSWORD property had been deleted in RANGER-900. The related redundant code should be deleted for plugin installer.

s-agent/scripts/install.sh > > hive-agent/scripts/install.sh > > knox-agent/scripts/install.sh > > plugin-kms/scripts/enable-kms-plugin.sh > > storm-agent/scripts/install.sh Ok. I will carefully analyze these scripts and verify their functionality. I will remov

Re: Review Request 59221: RANGER-1574:The XAAUDIT.DB.PASSWORD property had been deleted in RANGER-900. The related redundant code should be deleted for plugin installer.

scripts/install.sh 955ceb5 Diff: https://reviews.apache.org/r/59221/diff/2/ Changes: https://reviews.apache.org/r/59221/diff/1-2/ Testing --- Thanks, pengjianhua

Re: Review Request 59221: RANGER-1574:The XAAUDIT.DB.PASSWORD property had been deleted in RANGER-900. The related redundant code should be deleted for plugin installer.

s-agent/scripts/install.sh > > hive-agent/scripts/install.sh > > knox-agent/scripts/install.sh > > plugin-kms/scripts/enable-kms-plugin.sh > > storm-agent/scripts/install.sh > > pengjianhua wrote: > Ok. I will carefully analyze these scripts and verify their >

Review Request 59255: Some users hope that the pid file of the Ranger Admin can be unified management when they integrate Ranger into the big data platform or business systems to uniform install and r

document this change in the next release. Diffs - embeddedwebserver/scripts/ranger-admin-services.sh a81219b Diff: https://reviews.apache.org/r/59255/diff/1/ Testing --- Thanks, pengjianhua

Re: Review Request 59255: Some users hope that the pid file of the Ranger Admin can be unified management when they integrate Ranger into the big data platform or business systems to uniform install a

to dynamically change the pid path at startup. We should meet this need by minor modifications without affecting the current function and logic. - pengjianhua --- This is an automatically generated e-mail. To reply, visit

Re: Review Request 59255: Some users hope that the pid file of the Ranger Admin can be unified management when they integrate Ranger into the big data platform or business systems to uniform install a

_PATH if they don't want to use default > > path. So what is the need for an additional variable? > > pengjianhua wrote: > This function is perfect if user independently use our ranger. > There is defect for ranger when they integrate Ranger into the big data &g

Review Request 59332: RANGER-1586:There is "cannot resolve symbol 'serviceName'" error in ServiceSolrClient class.

#x27;" error in ServiceSolrClient class. I deleted it to resolve the issue and keep the code consistent. Diffs - plugin-solr/src/main/java/org/apache/ranger/services/solr/client/ServiceSolrClient.java bc5fdd0 Diff: https://reviews.apache.org/r/59332/diff/1/ Testing --- Thanks, pengjianhua

Review Request 59388: modify code for the error logs in KnoxClient.java

tring); Diffs - knox-agent/src/main/java/org/apache/ranger/services/knox/client/KnoxClient.java ec08ae8 Diff: https://reviews.apache.org/r/59388/diff/1/ Testing --- tested it Thanks, pengjianhua

Re: Review Request 59388: Modify code for the error logs in KnoxClient.java

1/ Testing --- tested it Thanks, pengjianhua

Review Request 59433: RANGER-1597:The log is inconsistent with the code in RangerServiceDefHelper class, update it to ensure their consistency.

class,update it to ensure their consistency. Diffs - agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerServiceDefHelper.java 159ee1a Diff: https://reviews.apache.org/r/59433/diff/1/ Testing --- Thanks, pengjianhua

Re: Review Request 59255: Some users hope that the pid file of the Ranger Admin can be unified management when they integrate Ranger into the big data platform or business systems to uniform install a

_PATH if they don't want to use default > > path. So what is the need for an additional variable? > > pengjianhua wrote: > This function is perfect if user independently use our ranger. > There is defect for ranger when they integrate Ranger into the big data &g

Review Request 59435: Different developers use different log directories in the Ranger Admin installation script. Its processing logic is chaotic. We should optimize this logic.

s logic. Diffs - security-admin/scripts/setup.sh 3b259a02 Diff: https://reviews.apache.org/r/59435/diff/1/ Testing --- Thanks, pengjianhua

Review Request 59436: In install.properties, I configured the testusr user and the testgroup groups that not exist in system. The error “chown: invalid user: testusr:testgroup” occured during installe

/scripts/enable-agent.sh 76ba8f0 Diff: https://reviews.apache.org/r/59436/diff/1/ Testing --- Thanks, pengjianhua

Review Request 59447: RANGER-1601 The log name is incorrect in ValuePrinter.java

c/main/java/org/apache/ranger/plugin/geo/ValuePrinter.java 89bb0b40 Diff: https://reviews.apache.org/r/59447/diff/1/ Testing --- Thanks, pengjianhua

Re: Review Request 59436: In install.properties, I configured the testusr user and the testgroup groups that not exist in system. The error “chown: invalid user: testusr:testgroup” occured during inst

flawed. Diffs (updated) - agents-common/scripts/enable-agent.sh 76ba8f0 Diff: https://reviews.apache.org/r/59436/diff/2/ Changes: https://reviews.apache.org/r/59436/diff/1-2/ Testing --- Thanks, pengjianhua

Re: Review Request 59436: In install.properties, I configured the testusr user and the testgroup groups that not exist in system. The error “chown: invalid user: testusr:testgroup” occured during inst

e comment and updated the patch. - pengjianhua --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59436/#review175619 --- On 五月 22, 201

Re: Review Request 59255: Some users hope that the pid file of the Ranger Admin can be unified management when they integrate Ranger into the big data platform or business systems to uniform install a

, pengjianhua

Re: Review Request 59255: Some users hope that the pid file of the Ranger Admin can be unified management when they integrate Ranger into the big data platform or business systems to uniform install a

_PATH if they don't want to use default > > path. So what is the need for an additional variable? > > pengjianhua wrote: > This function is perfect if user independently use our ranger. > There is defect for ranger when they integrate Ranger into the big data &g

Review Request 59486: These invalid codes that were copied have not been deleted in db_setup.py for the Ranger admin

db_setup.py for the Ranger admin. We should remove them to keep the code valid. Diffs - security-admin/scripts/db_setup.py b5ab132 Diff: https://reviews.apache.org/r/59486/diff/1/ Testing --- Thanks, pengjianhua

Re: Review Request 59436: In install.properties, I configured the testusr user and the testgroup groups that not exist in system. The error “chown: invalid user: testusr:testgroup” occured during inst

r group doesn't exist, can the installer print an error message and abort? If you are also the point of view, I will submit this issue using this logic. - pengjianhua --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 59486: These invalid codes that were copied have not been deleted in db_setup.py for the Ranger admin

other places. These extra code has not been deleted. - pengjianhua --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59486/#review175773 ---

Review Request 59512: The init_logfiles function had been removed in RANGER-1599. The segment code that calls the init_logfiles function should also be removed in setup.sh for Ranger Admin.

segment code that calls the init_logfiles function should also be removed in setup.sh for Ranger Admin. Diffs - security-admin/scripts/setup.sh 098f857f Diff: https://reviews.apache.org/r/59512/diff/1/ Testing --- Thanks, pengjianhua

Re: Review Request 59512: The init_logfiles function had been removed in RANGER-1599. The segment code that calls the init_logfiles function should also be removed in setup.sh for Ranger Admin.

, pengjianhua

Review Request 59572: Similar to RANGER-1575, the Ranger UserSync should also support the same new feature.

ranger, users can set the pid file to meet their own needs. We will explicitly document this change in the next release. Diffs - unixauthservice/scripts/ranger-usersync-services.sh 97f5708 Diff: https://reviews.apache.org/r/59572/diff/1/ Testing --- Thanks, pengjianhua

Review Request 59602: The Ranger build failure in windows environment

o python2 program after installed the python. We should modify it to keep that the Ranger can be compiled successfully in the linux and window environment. Diffs - ranger-util/pom.xml 7d19d10 Diff: https://reviews.apache.org/r/59602/diff/1/ Testing --- Thanks, pengjianhua

Re: Review Request 59602: The Ranger build failure in windows environment

. I find that the python2 does not exist after installed the python3 in windows 7. For RANGER-1589 it should belong to Denes Bodo's environmental problems. Compared with python2, Python3 has lots of changes. The Ranger should not support python3. - pengjianhua --

Re: Review Request 59436: In install.properties, I configured the testusr user and the testgroup groups that not exist in system. The error “chown: invalid user: testusr:testgroup” occured during inst

> On 五月 23, 2017, 9:08 a.m., Colm O hEigeartaigh wrote: > > I'm not sure about the changed logic to be honest. If the user or group > > doesn't exist, wouldn't it be better to print an error message and abort? > > pengjianhua wrote: > Initiall

Review Request 60032: Remove the pmd check error

as 'i'. Diffs - agents-common/src/test/java/org/apache/ranger/plugin/errors/TestValidationErrorCode.java 1b00c64 kms/src/main/java/org/apache/hadoop/crypto/key/RangerKeyStore.java c4f7267 Diff: https://reviews.apache.org/r/60032/diff/1/ Testing --- Thanks, pengjianhua

Review Request 60193: Clean invalid code for kms installer to improve code clarity and execution efficiency.

--- Thanks, pengjianhua

Review Request 60260: Similar to RANGER-1599, Different developers use different log directories in the kms installation script. Its processing logic is chaotic. We should optimize this logic.

installation script. Its processing logic is chaotic. We should optimize this logic. Diffs - kms/scripts/setup.sh 77d8e80 Diff: https://reviews.apache.org/r/60260/diff/1/ Testing --- Thanks, pengjianhua

Review Request 60262: Similar to RANGER-1575, the kms should also support the same new feature. 1 of 49

/ranger-kms 11dc4ff Diff: https://reviews.apache.org/r/60262/diff/1/ Testing --- Thanks, pengjianhua

Re: Review Request 60262: Similar to RANGER-1575, the kms should also support the same new feature.

case of compatibility with existing logic. When running ranger, users can set the pid file to meet their own needs. Diffs - kms/scripts/ranger-kms 11dc4ff Diff: https://reviews.apache.org/r/60262/diff/1/ Testing --- Thanks, pengjianhua

Re: Review Request 60260: Similar to RANGER-1599, Different developers use different log directories in the kms installation script. Its processing logic is chaotic. We should optimize this logic.

ould not be needed in current context. I have been thinking, why the orignal developer added it? Do I think we should remove it, your opinion? - pengjianhua --- This is an automatically generated e-mail. To reply, visit: https://revie

Review Request 60359: The user is easy to configure the wrong format's data for 'YARN REST URL' property when adding a new yarn service. It will cause testconnection fail.

iff/1/ Testing --- test? Thanks, pengjianhua

Re: Review Request 60359: The user is easy to configure the wrong format's data for 'YARN REST URL' property when adding a new yarn service. It will cause testconnection fail.

Diff: https://reviews.apache.org/r/60359/diff/2/ Changes: https://reviews.apache.org/r/60359/diff/1-2/ Testing --- test? Thanks, pengjianhua

Re: Review Request 60359: The user is easy to configure the wrong format's data for 'YARN REST URL' property when adding a new yarn service. It will cause testconnection fail.

> On 六月 22, 2017, 9:04 a.m., Colm O hEigeartaigh wrote: > > Looks fine, but change it to "For multiple urls" Thanks, I have changed and updated the patch. - pengjianhua --- This is an automatically generated e-ma

Re: Review Request 60260: Similar to RANGER-1599, Different developers use different log directories in the kms installation script. Its processing logic is chaotic. We should optimize this logic.

> On 六月 21, 2017, 9:38 a.m., Colm O hEigeartaigh wrote: > > With the patch, the $LOGFILES property is not actually used at all. Do we > > know what $LOGFILES is meant to do, and why we have both $LOGFILE and > > $LOGFILES? > > pengjianhua wrote: > I also no

Review Request 60452: RANGER-1668:Do some code improvement in setup.sh of security-admin

echo "" > ${WEBAPP_ROOT}/WEB-INF/classes/conf/core-site.xml fi fi fi Diffs - security-admin/scripts/setup.sh f49bb13 Diff: https://reviews.apache.org/r/60452/diff/1/ Testing --- Thanks, pengjianhua

Re: Review Request 60452: RANGER-1668:Do some code improvement in setup.sh of security-admin

uot;" > ${WEBAPP_ROOT}/WEB-INF/classes/conf/core-site.xml fi fi fi Diffs - security-admin/scripts/setup.sh f49bb13 Diff: https://reviews.apache.org/r/60452/diff/1/ Testing --- Thanks, pengjianhua

Review Request 60454: We need to support the original functionality of hive?show grant user username

e/ranger/authorization/hive/authorizer/RangerHiveAuthorizerBase.java c313870 Diff: https://reviews.apache.org/r/60454/diff/1/ Testing --- tested it Thanks, pengjianhua

Re: Review Request 60454: RANGER-1669?We need to support the original functionality of hive?show grant user username

Testing --- tested it Thanks, pengjianhua

Re: Review Request 60454: RANGER-1669:We need to support the original functionality of hive.show grant user username

Testing --- tested it Thanks, pengjianhua

Re: Review Request 60260: Similar to RANGER-1599, Different developers use different log directories in the kms installation script. Its processing logic is chaotic. We should optimize this logic.

> On 六月 21, 2017, 9:38 a.m., Colm O hEigeartaigh wrote: > > With the patch, the $LOGFILES property is not actually used at all. Do we > > know what $LOGFILES is meant to do, and why we have both $LOGFILE and > > $LOGFILES? > > pengjianhua wrote: > I also no

Re: Review Request 60260: Similar to RANGER-1599, Different developers use different log directories in the kms installation script. Its processing logic is chaotic. We should optimize this logic.

://reviews.apache.org/r/60260/diff/1-2/ Testing --- Thanks, pengjianhua

Review Request 60680: Unable to login to Hadoop environment after opened Kerberos.

igHolder.java fd925aa Diff: https://reviews.apache.org/r/60680/diff/1/ Testing --- Thanks, pengjianhua

Review Request 60696: In different places to achieve the same function using repeat codes, new issue is perhaps generated when these functions are modified.

n/java/org/apache/ranger/audit/utils/SolrAppUtil.java PRE-CREATION Diff: https://reviews.apache.org/r/60696/diff/1/ Testing --- Thanks, pengjianhua

Re: Review Request 60733: RANGER-1681:Now ranger's kerberos configuration item relies directly on the configuration of the hadoop component. When the HDFS opens other functions such as HA, the test co

y-admin/scripts/setup.sh 1630684 security-admin/src/main/resources/conf.dist/core-site.xml PRE-CREATION Diff: https://reviews.apache.org/r/60733/diff/1/ Testing (updated) --- test it! Thanks, pengjianhua

Review Request 60733: RANGER-1681:Now ranger's kerberos configuration item relies directly on the configuration of the hadoop component. When the HDFS opens other functions such as HA, the test connec

ecurity-admin/src/main/resources/conf.dist/core-site.xml PRE-CREATION Diff: https://reviews.apache.org/r/60733/diff/1/ Testing --- Thanks, pengjianhua

Re: Review Request 60696: In different places to achieve the same function using repeat codes, new issue is perhaps generated when these functions are modified.

- Thanks, pengjianhua

Re: Review Request 60696: In different places to achieve the same function using repeat codes, new issue is perhaps generated when these functions are modified.

agents-audit/src/main/java/org/apache/ranger/audit/utils/SolrAppUtil.java PRE-CREATION Diff: https://reviews.apache.org/r/60696/diff/3/ Changes: https://reviews.apache.org/r/60696/diff/2-3/ Testing --- Thanks, pengjianhua

Re: Review Request 60454: RANGER-1669:We need to support the original functionality of hive.show grant user username

t; > > Falling back to Native SQLStdHiveAccessControler is not a ideal way to > > resolve this. HiveAuthorizer should provide the necessary implementation > > for showPrivileges(). This has to be discussed with Hive comitter also. Ok. I will rebuild the pat

Re: Review Request 60733: RANGER-1681:Now ranger's kerberos configuration item relies directly on the configuration of the hadoop component. When the HDFS opens other functions such as HA, the test co

g folder. > > > > My suggestion is to not include this patch. Ok. I will close the issue. Thanks. - pengjianhua --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60733/#revie

Review Request 60759: Log file name format of usersync and security admin should be consistent.

}-${user}.log Diffs - unixauthservice/src/main/resources/log4j.properties dbad541 Diff: https://reviews.apache.org/r/60759/diff/1/ Testing --- Thanks, pengjianhua

Review Request 60772: The version file did not exist in ranger-1.0.0-SNAPSHOT-kms.tar.gz. The result was that the VERSION variable can only get a fixed 0.5.0 value when installed ranger kms.

-kms.tar.gz. The result was that the VERSION variable can only get a fixed 0.5.0 value when installed ranger kms. Diffs - src/main/assembly/kms.xml e26dd33 Diff: https://reviews.apache.org/r/60772/diff/1/ Testing --- Thanks, pengjianhua

Review Request 60789: Ranger usersync created error users. Ranger usersync got System Virtual User Group Name instead of real group name when built the unix user list.

pts/install.properties 13ae1e5 unixauthservice/scripts/templates/installprop2xml.properties 1a9bf36 unixauthservice/scripts/templates/ranger-ugsync-template.xml 0025dc8 Diff: https://reviews.apache.org/r/60789/diff/1/ Testing --- Thanks, pengjianhua

Re: Review Request 60789: Ranger usersync created error users. Ranger usersync got System Virtual User Group Name instead of real group name when built the unix user list.

tps://reviews.apache.org/r/60789/diff/1/ Testing --- Thanks, pengjianhua

Review Request 60795: Ranger usersync created error users. Ranger usersync got System Virtual User Group Name instead of real group name when built the unix user list.

ing --- Thanks, pengjianhua

Re: Review Request 60789: Ranger usersync created error users. Ranger usersync got System Virtual User Group Name instead of real group name when built the unix user list.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60789/#review180288 --- Ship it! Ship It! - pengjianhua On 七月 12, 2017, 2:42 a.m

Review Request 60801: Similar to RANGER-1540, the Ranger kms should also support the same new feature.

479b5b4 kms/scripts/ranger-kms e902509 Diff: https://reviews.apache.org/r/60801/diff/1/ Testing --- Thanks, pengjianhua

Re: Review Request 60801: Similar to RANGER-1540, the Ranger kms should also support the same new feature.

- kms/config/kms-webapp/kms-log4j.properties 479b5b4 kms/scripts/ranger-kms e902509 Diff: https://reviews.apache.org/r/60801/diff/1/ Testing --- Thanks, pengjianhua

Review Request 60837: The pidf's assignment logic in ranger-kms-initd should be consistent with the pidf's assignment logic in ranger-kms

https://reviews.apache.org/r/60837/diff/1/ Testing --- Thanks, pengjianhua

Re: Review Request 60454: RANGER-1669:We need to support the original functionality of hive.show grant user username

t; > > Falling back to Native SQLStdHiveAccessControler is not a ideal way to > > resolve this. HiveAuthorizer should provide the necessary implementation > > for showPrivileges(). This has to be discussed with Hive comitter also. > > pengjianhua wrote: > Ok. I

Re: Review Request 60454: RANGER-1669:We need to support the original functionality of hive.show grant user username

s: https://reviews.apache.org/r/60454/diff/1-2/ Testing --- tested it Thanks, pengjianhua

Re: Review Request 60454: RANGER-1669:We need to support the original functionality of hive.show grant user username

s: https://reviews.apache.org/r/60454/diff/2-3/ Testing --- tested it Thanks, pengjianhua

Review Request 60997: Write audit log to solr failure.

--- Thanks, pengjianhua

Re: Review Request 60997: Write audit log to solr failure.

/2/ Changes: https://reviews.apache.org/r/60997/diff/1-2/ Testing --- Thanks, pengjianhua

Re: Review Request 60997: Write audit log to solr failure.

://reviews.apache.org/r/60997/diff/2-3/ Testing --- Thanks, pengjianhua

  1   2   3   4   >