Re: CDI support improvements

2019-06-17 Thread Romain Manni-Bucau
Le lun. 17 juin 2019 à 16:17, Rémy Maucherat a écrit : > On Mon, Jun 17, 2019 at 10:52 AM Romain Manni-Bucau > wrote: > >> Hi Rémy, >> >> Great progression! Congrats! >> >> I have a few (details) notes - guess i'm opening an open door but just to >> ensure: >> >> 1. Is it intended to bind cxf

Re: CDI support improvements

2019-06-17 Thread Rémy Maucherat
On Mon, Jun 17, 2019 at 10:52 AM Romain Manni-Bucau wrote: > Hi Rémy, > > Great progression! Congrats! > > I have a few (details) notes - guess i'm opening an open door but just to > ensure: > > 1. Is it intended to bind cxf to /rest/* in any case? I tend to see it > bound on on /api but

Re: CDI support improvements

2019-06-17 Thread Romain Manni-Bucau
PS/FYI: just noticed jetty did the same kind of work with weld 4 years ago: https://github.com/eclipse/jetty.project/blob/jetty-9.4.x/jetty-cdi/cdi-servlet/src/main/config/etc/jetty-cdi.xml, great Tomcat is catching up :). Romain Manni-Bucau @rmannibucau | Blog

Re: CDI support improvements

2019-06-17 Thread Romain Manni-Bucau
Hi Rémy, Great progression! Congrats! I have a few (details) notes - guess i'm opening an open door but just to ensure: 1. Is it intended to bind cxf to /rest/* in any case? I tend to see it bound on on /api but generally thanks to an Application (+ @ApplicationPath("api")) so cxf is bound on

Re: CDI support improvements

2019-06-17 Thread Rémy Maucherat
Hi Romain, On Thu, Jun 13, 2019 at 6:52 PM Romain Manni-Bucau wrote: > > https://github.com/apache/cxf/blob/master/rt/frontend/jaxrs/src/main/java/org/apache/cxf/jaxrs/utils/JAXRSUtils.java#L1412 > is likely the one but looks like johnzon was not scanned nor registered > programmatically > >

Re: CDI support improvements

2019-06-13 Thread Rémy Maucherat
On Thu, Jun 13, 2019 at 6:52 PM Romain Manni-Bucau wrote: > > https://github.com/apache/cxf/blob/master/rt/frontend/jaxrs/src/main/java/org/apache/cxf/jaxrs/utils/JAXRSUtils.java#L1412 > is likely the one but looks like johnzon was not scanned nor registered > programmatically > > Maybe code

Re: CDI support improvements

2019-06-13 Thread Romain Manni-Bucau
https://github.com/apache/cxf/blob/master/rt/frontend/jaxrs/src/main/java/org/apache/cxf/jaxrs/utils/JAXRSUtils.java#L1412 is likely the one but looks like johnzon was not scanned nor registered programmatically Maybe code this bean: @Produces("application/json") // jaxrs import @Provider

Re: CDI support improvements

2019-06-13 Thread Rémy Maucherat
On Thu, Jun 13, 2019 at 5:31 PM Romain Manni-Bucau wrote: > can you drop johnzon-jsonb (+-core + -mapper + jsonp and jsonb specs jars) > too? > Ok, thanks. Still not working though, and this part of the code doesn't have debug logs of any kind, so I'll now have to trace the whole thing. It

Re: CDI support improvements

2019-06-13 Thread Romain Manni-Bucau
can you drop johnzon-jsonb (+-core + -mapper + jsonp and jsonb specs jars) too? Romain Manni-Bucau @rmannibucau | Blog | Old Blog | Github | LinkedIn

Re: CDI support improvements

2019-06-13 Thread Rémy Maucherat
On Wed, Jun 12, 2019 at 8:32 AM Romain Manni-Bucau wrote: > Joke apart, and assuming you grabbed the spec yourself (geronimo, javax or > jakarta jars) you just need: > > org.apache.cxf:cxf-core:3.3.2 > org.apache.cxf:cxf-rt-security:3.3.2 > org.apache.cxf:cxf-rt-transports-http:3.3.2 >

Re: CDI support improvements

2019-06-12 Thread David Blevins
> On Jun 12, 2019, at 6:35 AM, Rémy Maucherat wrote: > > On Wed, Jun 12, 2019 at 11:11 AM Mark Struberg > wrote: > > Rémy's enhancements are great - the better and cleaner the integration, the > better for all those projects. > But Romain and David are also correct: it's very easy to become

Re: CDI support improvements

2019-06-12 Thread Romain Manni-Bucau
Current owb-tomcat module is stable and could be used if some people need it but it does not prevent us to make trunk 9.last based IMHO. Maybe give a shout to owb dev list when you have something you want to integrate and Ill be happy to review and support it. Le mer. 12 juin 2019 à 18:13, Mark

Re: CDI support improvements

2019-06-12 Thread Mark Struberg
> Am 12.06.2019 um 15:35 schrieb Rémy Maucherat : > > That did not seem very practical to me so the said code is quite Tomcat-like > right now and most importantly it needs the fixes made in 9.0.21, so it won't > work with any older Tomcat. If you really can take it over > (and

Re: CDI support improvements

2019-06-12 Thread Rémy Maucherat
On Wed, Jun 12, 2019 at 11:11 AM Mark Struberg wrote: > Hi folks! > > Really happy to see so much love and interest for all those awesome ASF > projects! > > Rémy's enhancements are great - the better and cleaner the integration, > the better for all those projects. > But Romain and David are

Re: CDI support improvements

2019-06-12 Thread Mark Struberg
Hi folks! Really happy to see so much love and interest for all those awesome ASF projects! Rémy's enhancements are great - the better and cleaner the integration, the better for all those projects. But Romain and David are also correct: it's very easy to become a committer on all the

Re: CDI support improvements

2019-06-12 Thread Rémy Maucherat
On Wed, Jun 12, 2019 at 8:32 AM Romain Manni-Bucau wrote: > Hell Rémy, > > I commented inline > > Le mar. 11 juin 2019 à 23:29, Rémy Maucherat a écrit : > >> On Tue, Jun 11, 2019 at 9:49 PM Romain Manni-Bucau >> wrote: >> >>> My 2cts would be that we have the luck to be fully ASF here so each

Re: CDI support improvements

2019-06-12 Thread Romain Manni-Bucau
Hell Rémy, I commented inline Le mar. 11 juin 2019 à 23:29, Rémy Maucherat a écrit : > On Tue, Jun 11, 2019 at 9:49 PM Romain Manni-Bucau > wrote: > >> My 2cts would be that we have the luck to be fully ASF here so each >> project can likely get back its missing piece(s) and we stay overall

Re: CDI support improvements

2019-06-11 Thread Rémy Maucherat
On Tue, Jun 11, 2019 at 9:49 PM Romain Manni-Bucau wrote: > My 2cts would be that we have the luck to be fully ASF here so each > project can likely get back its missing piece(s) and we stay overall > consistent instead of creating yet another fork in our beloved foundation > (we already have

Re: CDI support improvements

2019-06-11 Thread David Blevins
> On Jun 11, 2019, at 12:02 PM, Mark Thomas wrote: > > On 11/06/2019 19:37, David Blevins wrote: >> >> At a high level, is there a desire to start supporting more "EE" like specs >> such as CDI, JAX-RS, JPA, etc? > > Make it easier to integrate? Sure. > > Implement additional specs? No.

Re: CDI support improvements

2019-06-11 Thread Romain Manni-Bucau
My 2cts would be that we have the luck to be fully ASF here so each project can likely get back its missing piece(s) and we stay overall consistent instead of creating yet another fork in our beloved foundation (we already have some concurrent servers or even jdbc pools which does not help much

Re: CDI support improvements

2019-06-11 Thread Rémy Maucherat
Hi David, On Tue, Jun 11, 2019 at 8:37 PM David Blevins wrote: > Hi All, > > At a high level, is there a desire to start supporting more "EE" like > specs such as CDI, JAX-RS, JPA, etc? > > Completely understood if the answer is "depends." I suspect it would > depend on if the code is clean

Re: CDI support improvements

2019-06-11 Thread Mark Thomas
On 11/06/2019 19:37, David Blevins wrote: > Hi All, > > At a high level, is there a desire to start supporting more "EE" like specs > such as CDI, JAX-RS, JPA, etc? > > Completely understood if the answer is "depends." I suspect it would depend > on if the code is clean and light in Tomcat

Re: CDI support improvements

2019-06-11 Thread David Blevins
Hi All, At a high level, is there a desire to start supporting more "EE" like specs such as CDI, JAX-RS, JPA, etc? Completely understood if the answer is "depends." I suspect it would depend on if the code is clean and light in Tomcat spirit. I write this not from the perspective of "let's

Re: CDI support improvements

2019-06-11 Thread Romain Manni-Bucau
Le mar. 11 juin 2019 à 16:57, Rémy Maucherat a écrit : > On Thu, May 30, 2019 at 9:35 AM Romain Manni-Bucau > wrote: > > >> Once done it can be hosted on both side.Owb has the advantage to be know >> by users, tomcat to be a more natural home for an integration. At the end >> it is mainly

Re: CDI support improvements

2019-06-11 Thread Rémy Maucherat
On Thu, May 30, 2019 at 9:35 AM Romain Manni-Bucau wrote: > Once done it can be hosted on both side.Owb has the advantage to be know > by users, tomcat to be a more natural home for an integration. At the end > it is mainly synchronizing both projects for a consistent communication and > code

Re: CDI support improvements

2019-05-30 Thread Romain Manni-Bucau
Hello Rémy, Few precisions inline Le jeu. 30 mai 2019 à 00:34, Rémy Maucherat a écrit : > Hi, > > On Wed, May 29, 2019 at 11:35 PM Romain Manni-Bucau > wrote: > >> Hi Rémy, >> >> Openwebbeans has a tomcat integration module - mainly standalone case, >> and meecrowave subproject - embedded or

Re: CDI support improvements

2019-05-29 Thread Rémy Maucherat
Hi, On Wed, May 29, 2019 at 11:35 PM Romain Manni-Bucau wrote: > Hi Rémy, > > Openwebbeans has a tomcat integration module - mainly standalone case, and > meecrowave subproject - embedded or ready to run fatjar. It looks like it > covers what you target. Where I am loosing track is why not

Re: CDI support improvements

2019-05-29 Thread Romain Manni-Bucau
Hi Rémy, Openwebbeans has a tomcat integration module - mainly standalone case, and meecrowave subproject - embedded or ready to run fatjar. It looks like it covers what you target. Where I am loosing track is why not improving openwebbeans and forking the code in tomcat? At least i would expect