Re: [xwiki-devs] [Proposal] Having the docextra tabs in edit mode.

2016-10-17 Thread Marius Dumitru Florea
On Wed, Oct 12, 2016 at 5:26 PM, Guillaume Delhumeau < guillaume.delhum...@xwiki.com> wrote: > Hi. > > Currently a user have 2 ways to attach a file to a wiki page: > - in the attachment tab in VIEW mode only ; > > - if it's an image, using a WYSIWYG editor. > It doesn't have to be an image.

Re: [xwiki-devs] [Proposal] Having the docextra tabs in edit mode.

2016-10-14 Thread Denis Gervalle
+1 for your proposal until we have a better solution. I would avoid comment tab if ever possible, since it increase the inconveniences already explained. I agree with almost all other comments, but until we have time for something better, this proposal would be a first improvement. We should

Re: [xwiki-devs] [Proposal] Having the docextra tabs in edit mode.

2016-10-13 Thread Guillaume Delhumeau
2016-10-13 11:07 GMT+02:00 Ecaterina Moraru (Valica) : > Some notes about the comments: > - @GD: In CkEditor when drag it doesn't open a file explorer > (that's for the simple upload), instead you just drag the image from > Desktop and it inserts it. > I think I was not clear.

Re: [xwiki-devs] [Proposal] Having the docextra tabs in edit mode.

2016-10-13 Thread Vincent Massol
> On 13 Oct 2016, at 11:17, Vincent Massol wrote: > >> >> On 13 Oct 2016, at 11:07, Ecaterina Moraru (Valica) >> wrote: >> >> Some notes about the comments: >> - @GD: In CkEditor when drag it doesn't open a file explorer >> (that's for the simple

Re: [xwiki-devs] [Proposal] Having the docextra tabs in edit mode.

2016-10-13 Thread Vincent Massol
> On 13 Oct 2016, at 11:07, Ecaterina Moraru (Valica) wrote: > > Some notes about the comments: > - @GD: In CkEditor when drag it doesn't open a file explorer > (that's for the simple upload), instead you just drag the image from > Desktop and it inserts it. > - @Vincent: the

Re: [xwiki-devs] [Proposal] Having the docextra tabs in edit mode.

2016-10-13 Thread Paul Libbrecht
Guillaume, would you not rather be in favour of an attachments’ tab display (it could be iframed) as pop-up for the wiki editor? And the let JS modify the action on link-click to be a selection, and then make selection insert something useful depending on the type of the selected item and,

Re: [xwiki-devs] [Proposal] Having the docextra tabs in edit mode.

2016-10-13 Thread Ecaterina Moraru (Valica)
Some notes about the comments: - @GD: In CkEditor when drag it doesn't open a file explorer (that's for the simple upload), instead you just drag the image from Desktop and it inserts it. - @Vincent: the inline editing approach (with keeping the attachments tab in the same location) doesn't work

Re: [xwiki-devs] [Proposal] Having the docextra tabs in edit mode.

2016-10-13 Thread Thomas Mortagne
Something is not clear to me. What is exactly going to happen in edit mode when you select an attachment ? If the plan is to let the attachment tab behave exactly as it does in view mode (which is to actually upload the attachment and save the document) I'm really not a big fan of this. If we

Re: [xwiki-devs] [Proposal] Having the docextra tabs in edit mode.

2016-10-13 Thread Vincent Massol
> On 12 Oct 2016, at 18:47, Guillaume Delhumeau > wrote: > > Just some remarks before I go: > * As a developer, I always use the Wiki editor, and even for me it's a pain > to go to view mode to upload a file (for example, an image in the release > notes). > * I

Re: [xwiki-devs] [Proposal] Having the docextra tabs in edit mode.

2016-10-12 Thread Guillaume Delhumeau
Just some remarks before I go: * As a developer, I always use the Wiki editor, and even for me it's a pain to go to view mode to upload a file (for example, an image in the release notes). * I never use drag in whatever application I have. I have never liked it because it requires to open a file

Re: [xwiki-devs] [Proposal] Having the docextra tabs in edit mode.

2016-10-12 Thread Ecaterina Moraru (Valica)
There are some problems with docextra, because it contains comments, which are mostly needed in view mode, not in edit. So in edit mode, we would need just some tabs from docextra. But I'm not sure that adding docextra now will fix the underlying problem of the issue. The issue was trying to fix

[xwiki-devs] [Proposal] Having the docextra tabs in edit mode.

2016-10-12 Thread Guillaume Delhumeau
Hi. Currently a user have 2 ways to attach a file to a wiki page: - in the attachment tab in VIEW mode only ; - if it's an image, using a WYSIWYG editor. However, if it's not an image, you cannot add it while you're writing the content. It's a bit as if you were not able to attach a file while