Re: [xwiki-devs] [Proposal] Prevent users from renaming/move pages with XClass definition

2018-10-17 Thread Vincent Massol
> On 17 Oct 2018, at 11:37, Thomas Mortagne wrote: > > On Wed, Oct 17, 2018 at 11:29 AM Vincent Massol wrote: >> >> >> >>> On 17 Oct 2018, at 11:08, Simon Urli wrote: >> >> [snip] >> > I reused the existing UI which does not look so bad IMO (see the > screenshot in the

Re: [xwiki-devs] [Proposal] Prevent users from renaming/move pages with XClass definition

2018-10-17 Thread Thomas Mortagne
On Wed, Oct 17, 2018 at 11:29 AM Vincent Massol wrote: > > > > > On 17 Oct 2018, at 11:08, Simon Urli wrote: > > [snip] > > >>> I reused the existing UI which does not look so bad IMO (see the > >>> screenshot in the design page). > >> This is what happens in the AntiSpam app when

Re: [xwiki-devs] [Proposal] Prevent users from renaming/move pages with XClass definition

2018-10-17 Thread Vincent Massol
> On 17 Oct 2018, at 11:08, Simon Urli wrote: [snip] >>> I reused the existing UI which does not look so bad IMO (see the >>> screenshot in the design page). >> This is what happens in the AntiSpam app when the event is cancelled (ie >> when it finds some spam in the doc):

Re: [xwiki-devs] [Proposal] Prevent users from renaming/move pages with XClass definition

2018-10-17 Thread Simon Urli
On 10/17/18 10:43 AM, Vincent Massol wrote: On 17 Oct 2018, at 10:41, Simon Urli wrote: On 10/17/18 10:37 AM, Vincent Massol wrote: On 17 Oct 2018, at 10:31, Simon Urli wrote: On 10/17/18 10:22 AM, Vincent Massol wrote: Hi Simon, On 17 Oct 2018, at 10:12, Simon Urli wrote: Hi

Re: [xwiki-devs] [Proposal] Prevent users from renaming/move pages with XClass definition

2018-10-17 Thread Vincent Massol
> On 17 Oct 2018, at 10:41, Simon Urli wrote: > > > > On 10/17/18 10:37 AM, Vincent Massol wrote: >>> On 17 Oct 2018, at 10:31, Simon Urli wrote: >>> >>> >>> >>> On 10/17/18 10:22 AM, Vincent Massol wrote: Hi Simon, > On 17 Oct 2018, at 10:12, Simon Urli wrote: > > Hi

Re: [xwiki-devs] [Proposal] Prevent users from renaming/move pages with XClass definition

2018-10-17 Thread Simon Urli
On 10/17/18 10:37 AM, Vincent Massol wrote: On 17 Oct 2018, at 10:31, Simon Urli wrote: On 10/17/18 10:22 AM, Vincent Massol wrote: Hi Simon, On 17 Oct 2018, at 10:12, Simon Urli wrote: Hi Vincent and all, On 10/17/18 9:41 AM, Vincent Massol wrote: Hi Simon, On 16 Oct 2018, at

Re: [xwiki-devs] [Proposal] Prevent users from renaming/move pages with XClass definition

2018-10-17 Thread Vincent Massol
> On 17 Oct 2018, at 10:31, Simon Urli wrote: > > > > On 10/17/18 10:22 AM, Vincent Massol wrote: >> Hi Simon, >>> On 17 Oct 2018, at 10:12, Simon Urli wrote: >>> >>> Hi Vincent and all, >>> >>> On 10/17/18 9:41 AM, Vincent Massol wrote: Hi Simon, > On 16 Oct 2018, at 17:43,

Re: [xwiki-devs] [Proposal] Prevent users from renaming/move pages with XClass definition

2018-10-17 Thread Simon Urli
On 10/17/18 10:22 AM, Vincent Massol wrote: Hi Simon, On 17 Oct 2018, at 10:12, Simon Urli wrote: Hi Vincent and all, On 10/17/18 9:41 AM, Vincent Massol wrote: Hi Simon, On 16 Oct 2018, at 17:43, Simon Urli wrote: Hello everyone, I'm coming back on this proposal as the work is

Re: [xwiki-devs] [Proposal] Prevent users from renaming/move pages with XClass definition

2018-10-17 Thread Vincent Massol
Hi Simon, > On 17 Oct 2018, at 10:12, Simon Urli wrote: > > Hi Vincent and all, > > On 10/17/18 9:41 AM, Vincent Massol wrote: >> Hi Simon, >>> On 16 Oct 2018, at 17:43, Simon Urli wrote: >>> >>> Hello everyone, >>> >>> I'm coming back on this proposal as the work is going on, to basically

Re: [xwiki-devs] [Proposal] Prevent users from renaming/move pages with XClass definition

2018-10-17 Thread Simon Urli
Hi Vincent and all, On 10/17/18 9:41 AM, Vincent Massol wrote: Hi Simon, On 16 Oct 2018, at 17:43, Simon Urli wrote: Hello everyone, I'm coming back on this proposal as the work is going on, to basically propose to dropping the warning on copy action. I try to sum up why in the

Re: [xwiki-devs] [Proposal] Prevent users from renaming/move pages with XClass definition

2018-10-17 Thread Vincent Massol
Hi Simon, > On 16 Oct 2018, at 17:43, Simon Urli wrote: > > Hello everyone, > > I'm coming back on this proposal as the work is going on, to basically > propose to dropping the warning on copy action. > > I try to sum up why in the following. > > When implementing the proposal, I was

Re: [xwiki-devs] [Proposal] Prevent users from renaming/move pages with XClass definition

2018-10-17 Thread Thomas Mortagne
+1 to drop it. Never understood why it was a problem anyway On Tue, Oct 16, 2018 at 5:43 PM Simon Urli wrote: > > Hello everyone, > > I'm coming back on this proposal as the work is going on, to basically > propose to dropping the warning on copy action. > > I try to sum up why in the following.

Re: [xwiki-devs] [Proposal] Prevent users from renaming/move pages with XClass definition

2018-10-16 Thread Simon Urli
Hello everyone, I'm coming back on this proposal as the work is going on, to basically propose to dropping the warning on copy action. I try to sum up why in the following. When implementing the proposal, I was adviced to use an event listener, observing the deleting event for informing the

Re: [xwiki-devs] [Proposal] Prevent users from renaming/move pages with XClass definition

2018-09-26 Thread Adel Atallah
Hi, +1 for doing what you said :) On Wed, Sep 26, 2018 at 10:27 AM Simon Urli wrote: > > Hi everyone, > > ok trying to sum-up (I'm only talking about cases with XClass below, to > simplify): >- according to Vincent, we should completely prevent simple users to > copy/move/rename and only

Re: [xwiki-devs] [Proposal] Prevent users from renaming/move pages with XClass definition

2018-09-26 Thread Simon Urli
Hi everyone, ok trying to sum-up (I'm only talking about cases with XClass below, to simplify): - according to Vincent, we should completely prevent simple users to copy/move/rename and only allow advanced users to do it after a warning - according to Adel & Clément: preventing simple

Re: [xwiki-devs] [Proposal] Prevent users from renaming/move pages with XClass definition

2018-09-25 Thread Vincent Massol
Hi Marius, > On 25 Sep 2018, at 11:34, Marius Dumitru Florea > wrote: > > On Sun, Sep 23, 2018 at 11:12 AM Vincent Massol wrote: > >> Hi Simon, >> >>> On 21 Sep 2018, at 16:58, Simon Urli wrote: >>> >>> >>> >>> On 9/21/18 4:53 PM, Adel Atallah wrote: +1 for the warning, but I would

Re: [xwiki-devs] [Proposal] Prevent users from renaming/move pages with XClass definition

2018-09-25 Thread Marius Dumitru Florea
On Sun, Sep 23, 2018 at 11:12 AM Vincent Massol wrote: > Hi Simon, > > > On 21 Sep 2018, at 16:58, Simon Urli wrote: > > > > > > > > On 9/21/18 4:53 PM, Adel Atallah wrote: > >> +1 for the warning, but I would not forbid simple users from renaming > >> or moving pages but instead just hide the

Re: [xwiki-devs] [Proposal] Prevent users from renaming/move pages with XClass definition

2018-09-24 Thread Vincent Massol
> On 24 Sep 2018, at 15:50, Vincent Massol wrote: > > Hi, > >> On 24 Sep 2018, at 10:11, Adel Atallah wrote: >> >> Hi, >> >> AFAIK, anyone can switch from Simple User to Advanced User, so I don't >> think it's a good idea to completely prevent someone (by showing an >> error) from

Re: [xwiki-devs] [Proposal] Prevent users from renaming/move pages with XClass definition

2018-09-24 Thread Vincent Massol
Hi, > On 24 Sep 2018, at 10:11, Adel Atallah wrote: > > Hi, > > AFAIK, anyone can switch from Simple User to Advanced User, so I don't > think it's a good idea to completely prevent someone (by showing an > error) from performing an action just because its user type is not the > right one. >

Re: [xwiki-devs] [Proposal] Prevent users from renaming/move pages with XClass definition

2018-09-24 Thread Simon Urli
Hi again, On 9/24/18 10:11 AM, Adel Atallah wrote: Hi, AFAIK, anyone can switch from Simple User to Advanced User, so I don't think it's a good idea to completely prevent someone (by showing an error) from performing an action just because its user type is not the right one. For me, the best

Re: [xwiki-devs] [Proposal] Prevent users from renaming/move pages with XClass definition

2018-09-24 Thread Adel Atallah
Hi, AFAIK, anyone can switch from Simple User to Advanced User, so I don't think it's a good idea to completely prevent someone (by showing an error) from performing an action just because its user type is not the right one. For me, the best solution would be to show a warning to both simple and

Re: [xwiki-devs] [Proposal] Prevent users from renaming/move pages with XClass definition

2018-09-24 Thread Simon Urli
Hi all, On 9/24/18 9:00 AM, Clément Aubin wrote: Hi, On 09/23/2018 10:12 AM, Vincent Massol wrote: Hi Simon, On 21 Sep 2018, at 16:58, Simon Urli wrote: On 9/21/18 4:53 PM, Adel Atallah wrote: +1 for the warning, but I would not forbid simple users from renaming or moving pages but

Re: [xwiki-devs] [Proposal] Prevent users from renaming/move pages with XClass definition

2018-09-24 Thread Clément Aubin
Hi, On 09/23/2018 10:12 AM, Vincent Massol wrote: > Hi Simon, > >> On 21 Sep 2018, at 16:58, Simon Urli wrote: >> >> >> >> On 9/21/18 4:53 PM, Adel Atallah wrote: >>> +1 for the warning, but I would not forbid simple users from renaming >>> or moving pages but instead just hide the action (from

Re: [xwiki-devs] [Proposal] Prevent users from renaming/move pages with XClass definition

2018-09-23 Thread Vincent Massol
Hi Simon, > On 21 Sep 2018, at 16:58, Simon Urli wrote: > > > > On 9/21/18 4:53 PM, Adel Atallah wrote: >> +1 for the warning, but I would not forbid simple users from renaming >> or moving pages but instead just hide the action (from the page menu). > > OK I should have written it: by

Re: [xwiki-devs] [Proposal] Prevent users from renaming/move pages with XClass definition

2018-09-21 Thread Simon Urli
On 9/21/18 5:32 PM, Adel Atallah wrote: On Fri, Sep 21, 2018 at 4:56 PM Simon Urli wrote: On 9/21/18 4:53 PM, Adel Atallah wrote: +1 for the warning, but I would not forbid simple users from renaming or moving pages but instead just hide the action (from the page menu). OK I should

Re: [xwiki-devs] [Proposal] Prevent users from renaming/move pages with XClass definition

2018-09-21 Thread Adel Atallah
On Fri, Sep 21, 2018 at 4:56 PM Simon Urli wrote: > > > > On 9/21/18 4:53 PM, Adel Atallah wrote: > > +1 for the warning, but I would not forbid simple users from renaming > > or moving pages but instead just hide the action (from the page menu). > > OK I should have written it: by "forbid" I

Re: [xwiki-devs] [Proposal] Prevent users from renaming/move pages with XClass definition

2018-09-21 Thread Simon Urli
On 9/21/18 4:53 PM, Adel Atallah wrote: +1 for the warning, but I would not forbid simple users from renaming or moving pages but instead just hide the action (from the page menu). OK I should have written it: by "forbid" I meant: 1. Hide the action from the menu 2. Return an error

Re: [xwiki-devs] [Proposal] Prevent users from renaming/move pages with XClass definition

2018-09-21 Thread Adel Atallah
+1 for the warning, but I would not forbid simple users from renaming or moving pages but instead just hide the action (from the page menu). On Fri, Sep 21, 2018 at 4:44 PM Simon Urli wrote: > > Hi all, > > users might currently break their AWM application by renaming/moving > pages containing

[xwiki-devs] [Proposal] Prevent users from renaming/move pages with XClass definition

2018-09-21 Thread Simon Urli
Hi all, users might currently break their AWM application by renaming/moving pages containing XClass definition. We need a proper refactoring operation to be able to properly do such move/rename. But this feature might take a while to be completely available. In the meantime I propose