Re: change commit message format to present tense?

I've read all your comments and I understand the "readability matters" arguments, but I think we're looking at it from a wrong angle. Commit message *is not a history record.* Commit *is a diff*, and commit message should be a *human version* of that diff. Please keep in mind that commits can

Re: change commit message format to present tense?

As it seems there isn't consensus on this and the current message format works fine as far as I'm concerned, I'm dropping the proposal. I thought the question "if we adopt some new SCM tool that has a different commit message format, would we adopt that format?" is an interesting one. On

Re: change commit message format to present tense?

I agree with Reinout and on the use of the present tense, so a commit message would read: "Adds password validation to prevent the usage of ..." My mind finds this way easier to understand than: "Add password validation ..." Wim On Monday, 27 June 2016 13:55:54 UTC+2, Daniele Procida wrote: >

Re: change commit message format to present tense?

On Mon, Jun 27, 2016, Reinout van Rees wrote: >Op 26-06-16 om 05:31 schreef Kevin Christopher Henry: >> If anyone's put off by the hectoring tone of the imperative mood, it >> might be better to think of it as the indicative mood. That is: >> >> (This will) "add password

Re: change commit message format to present tense?

Hi, Le lundi 27 juin 2016, Reinout van Rees a écrit : > > (You must) "add password validation to prevent the usage of..."! > > "It might be better to think of it as...": it is exactly this extra > thinkwork that everyone reading the messages has to do. We write it once and > read it many times:

Re: change commit message format to present tense?

Il 27/06/2016 11:49, Reinout van Rees ha scritto: Op 26-06-16 om 05:31 schreef Kevin Christopher Henry: If anyone's put off by the hectoring tone of the imperative mood, it might be better to think of it as the indicative mood. That is: (This will) "add password validation to prevent the usage

Re: change commit message format to present tense?

Op 26-06-16 om 05:31 schreef Kevin Christopher Henry: If anyone's put off by the hectoring tone of the imperative mood, it might be better to think of it as the indicative mood. That is: (This will) "add password validation to prevent the usage of...". rather than (You must) "add password

Re: change commit message format to present tense?

If anyone's put off by the hectoring tone of the imperative mood, it might be better to think of it as the indicative mood. That is: (This will) "add password validation to prevent the usage of...". rather than (You must) "add password validation to prevent the usage of..."! In English

Re: change commit message format to present tense?

Reinout, I agree that the imperative mood seems awkward, especially when reading history, but of course I'm influenced by my experience with Django's history. No doubt others find it more natural. I guess if I had my way, we would keep using past tense, although I will say that it gets a bit

Re: change commit message format to present tense?

On Saturday 25 June 2016 00:04:30 Tim Graham wrote: > With the idea of saving characters in the first line, would "Fix #XXX: > Message" be better than ""Fix #XXX -- Message" also? This saves two > characters without any loss of readability as far as I see. > Is there a real reason for caring

Re: change commit message format to present tense?

Op 24-06-16 om 19:48 schreef Carl Meyer: To be clear, the recommended git style is not present tense, it is imperative mood. So it should _not_ be "Fixes #12345 -- Regulates the frobnicator", it should be "Fix #12345 -- Regulate the frobnicator." Everybody seems to be in favour. I'll allow

Re: change commit message format to present tense?

> On 24 Jun 2016, at 23:27, Carl Meyer wrote: > > On 06/24/2016 03:04 PM, Tim Graham wrote: >> With the idea of saving characters in the first line, would "Fix #XXX: >> Message" be better than ""Fix #XXX -- Message" also? This saves two >> characters without any loss of

Re: change commit message format to present tense?

On 06/24/2016 03:04 PM, Tim Graham wrote: > With the idea of saving characters in the first line, would "Fix #XXX: > Message" be better than ""Fix #XXX -- Message" also? This saves two > characters without any loss of readability as far as I see. Seems reasonable to me. Carl -- You received

Re: change commit message format to present tense?

With the idea of saving characters in the first line, would "Fix #XXX: Message" be better than ""Fix #XXX -- Message" also? This saves two characters without any loss of readability as far as I see. On Friday, June 24, 2016 at 4:44:10 PM UTC-4, Aymeric Augustin wrote: > > > On 24 Jun 2016, at

Re: change commit message format to present tense?

> On 24 Jun 2016, at 20:23, Carl Meyer wrote: > > The style that is most commonly recommended is described in the most > detail (with reasoning) in these blog posts: > > http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html >

Re: change commit message format to present tense?

This post by Tim Pope is considered the "definitive guide to commit messages" as far as I'm aware. http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html +1 to adopting this style. On 24 June 2016 at 19:15, Jon Dufresne wrote: > On Fri, Jun 24, 2016 at

Re: change commit message format to present tense?

On 06/24/2016 12:15 PM, Jon Dufresne wrote: > On Fri, Jun 24, 2016 at 10:48 AM, Carl Meyer > wrote: > > To be clear, the recommended git style is not present tense, it is > imperative mood. So it should _not_ be "Fixes #12345 -- Regulates the >

Re: change commit message format to present tense?

On Fri, Jun 24, 2016, Jon Dufresne wrote: >On Fri, Jun 24, 2016 at 10:48 AM, Carl Meyer wrote: > >> To be clear, the recommended git style is not present tense, it is >> imperative mood. So it should _not_ be "Fixes #12345 -- Regulates the >>

Re: change commit message format to present tense?

On Fri, Jun 24, 2016 at 10:48 AM, Carl Meyer wrote: > To be clear, the recommended git style is not present tense, it is > imperative mood. So it should _not_ be "Fixes #12345 -- Regulates the > frobnicator", it should be "Fix #12345 -- Regulate the frobnicator." > Do you have

Re: change commit message format to present tense?

To be clear, the recommended git style is not present tense, it is imperative mood. So it should _not_ be "Fixes #12345 -- Regulates the frobnicator", it should be "Fix #12345 -- Regulate the frobnicator." Carl On 06/24/2016 11:45 AM, Tobias McNulty wrote: > I'm in support of this as well. Is

Re: change commit message format to present tense?

I'm in support of this as well. Is the suggestion to change the format to: A) Fixes #12345 -- Add support for ... / Validate that / etc. OR B) Fixes #12345 -- Adds support for ... / Validates that ... / etc. OR C) Something else? I assume (A) but others may interpret this differently?

Re: change commit message format to present tense?

I don't mind either way. If everybody seems to use present tense these days, yeah, let's do that as well. As long as the general style of the commit messages stays: Fixes|Refs #12345 -- Make it work My 2¢ /Markus On Fri, Jun 24, 2016 at 11:04:39AM -0600, Jacob Kaplan-Moss wrote: I'm not

Re: change commit message format to present tense?

I'm not entirely sure because my memory sucks, but odds are that I started the current standard of using past-tense. FWIW I no longer care even at all, I think as long as commit messages are clear we I don't care what tense they are. Following the standard git way seems totally OK to me. Jacob

Re: change commit message format to present tense?

On 06/24/2016 10:55 AM, Tim Graham wrote: > A few contributors indicated in #django-dev that it could be beneficial > to change our commit message format to match git's guidelines of present > tense (instead of our current past tense convention) as it would be one > less thing to remember when