Re: [Linaro-mm-sig] [PATCH 04/18] dma-fence: prime lockdep annotations

2020-06-11 Thread Daniel Vetter
On Fri, Jun 12, 2020 at 1:35 AM Felix Kuehling wrote: > > Am 2020-06-11 um 10:15 a.m. schrieb Jason Gunthorpe: > > On Thu, Jun 11, 2020 at 10:34:30AM +0200, Daniel Vetter wrote: > >>> I still have my doubts about allowing fence waiting from within shrinkers. > >>> IMO ideally they should use a

Re: [PATCH v8 6/7] drm/msm: Set the global virtual address range from the IOMMU domain

2020-06-11 Thread kernel test robot
Hi Jordan, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on linus/master] [also build test WARNING on next-20200611] [cannot apply to iommu/next robh/for-next arm/for-next keystone/next rockchip/for-next arm64/for-next/core shawnguo/for-next soc/for-next v5.7

Re: [PATCH] drm/msm: call drm_mode_config_reset before drm_dev_register

2020-06-11 Thread abhinavk
Hi Rob Thanks for the review. Yes, this was a cleanup we noticed. Abhinav On 2020-06-11 20:35, Rob Clark wrote: On Tue, Jun 9, 2020 at 5:47 PM Abhinav Kumar wrote: As per the documentation of drm_dev_register, all drivers should call drm_dev_register after all the initialization is

Re: [PATCH] drm/msm: call drm_mode_config_reset before drm_dev_register

2020-06-11 Thread Rob Clark
On Tue, Jun 9, 2020 at 5:47 PM Abhinav Kumar wrote: > > As per the documentation of drm_dev_register, all drivers should > call drm_dev_register after all the initialization is completed. > This also means that drm_mode_config_reset should be done before > drm_dev_register. > > Change the

Re: [PATCH 6/6] drm/msm/a6xx: Add support for per-instance pagetables

2020-06-11 Thread Rob Clark
On Thu, Jun 11, 2020 at 3:29 PM Jordan Crouse wrote: > > Add support for using per-instance pagetables if all the dependencies are > available. > > Signed-off-by: Jordan Crouse > --- > > drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 69 ++- >

[PATCH v6 2/5] drm: add constant N value in helper file

2020-06-11 Thread Tanmay Shah
From: Chandan Uddaraju The constant N value (0x8000) is used by i915 DP driver. Define this value in dp helper header file to use in multiple Display Port drivers. Change i915 driver accordingly. Change in v6: Change commit message Signed-off-by: Chandan Uddaraju Signed-off-by: Vara Reddy

[PATCH v6 5/5] drm/msm/dpu: add display port support in DPU

2020-06-11 Thread Tanmay Shah
From: Jeykumar Sankaran Add display port support in DPU by creating hooks for DP encoder enumeration and encoder mode initialization. This change is based on the Snapdragon Display port driver changes[1]. changes in v2: - rebase on [2] (Sean Paul) - remove unwanted error checks

[PATCH v6 4/5] drm/msm/dp: add support for DP PLL driver

2020-06-11 Thread Tanmay Shah
From: Chandan Uddaraju Add the needed DP PLL specific files to support display port interface on msm targets. The DP driver calls the DP PLL driver registration. The DP driver sets the link and pixel clock sources. Changes in v2: -- Update copyright markings on all relevant files. -- Use

[PATCH v6 1/5] dt-bindings: msm/dp: add bindings of DP/DP-PLL driver for Snapdragon

2020-06-11 Thread Tanmay Shah
From: Chandan Uddaraju Add bindings for Snapdragon DisplayPort controller driver. Changes in V2: Provide details about sel-gpio Changes in V4: Provide details about max dp lanes Change the commit text Changes in V5: moved dp.txt to yaml file Changes in v6: - Squash all AUX LUT properties

[PATCH v6 0/5] Add support for DisplayPort driver on

2020-06-11 Thread Tanmay Shah
These patches add support for Display-Port driver on SnapDragon hardware. It adds DP driver and DP PLL driver files along with the needed device-tree bindings. The block diagram of DP driver is shown below: +-+ |DRM FRAMEWORK|

[PATCH 1/2] drm/shmem: add support for per object dma api operations

2020-06-11 Thread Gurchetan Singh
This is useful for the next patch. Also, should we only unmap the amount entries that we mapped with the dma-api? Signed-off-by: Gurchetan Singh --- drivers/gpu/drm/drm_gem_shmem_helper.c | 16 +++- include/drm/drm_gem_shmem_helper.h | 10 ++ 2 files changed, 21

[PATCH 2/2] drm/virtio: rely on drm shmem helpers to take care of dma_map/dma_unmap

2020-06-11 Thread Gurchetan Singh
Fixes a double-free regression: [4.357928] drm_gem_shmem_free_object+0xb4/0x100 [4.358983] virtio_gpu_dequeue_ctrl_func+0xd9/0x290 [4.360343] process_one_work+0x1d2/0x3a0 [4.361581] worker_thread+0x45/0x3c0 [4.362645] kthread+0xf6/0x130 [4.363543] ?

Re: [Linaro-mm-sig] [PATCH 04/18] dma-fence: prime lockdep annotations

2020-06-11 Thread Felix Kuehling
Am 2020-06-11 um 10:15 a.m. schrieb Jason Gunthorpe: > On Thu, Jun 11, 2020 at 10:34:30AM +0200, Daniel Vetter wrote: >>> I still have my doubts about allowing fence waiting from within shrinkers. >>> IMO ideally they should use a trywait approach, in order to allow memory >>> allocation during

[PATCH 4/6] drm/msm: Add support to create a local pagetable

2020-06-11 Thread Jordan Crouse
Add support to create a io-pgtable for use by targets that support per-instance pagetables. In order to support per-instance pagetables the GPU SMMU device needs to have the qcom,adreno-smmu compatible string and split pagetables and auxiliary domains need to be supported and enabled.

[PATCH 0/6] iommu-arm-smmu: Add auxiliary domains and per-instance pagetables

2020-06-11 Thread Jordan Crouse
This is a new refresh of support for auxiliary domains for arm-smmu-v2 and per-instance pagetables for drm/msm. The big change here from past efforts is that outside of creating a single aux-domain to enable TTBR0 all of the per-instance pagetables are created and managed exclusively in drm/msm

[PATCH 6/6] drm/msm/a6xx: Add support for per-instance pagetables

2020-06-11 Thread Jordan Crouse
Add support for using per-instance pagetables if all the dependencies are available. Signed-off-by: Jordan Crouse --- drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 69 ++- drivers/gpu/drm/msm/msm_ringbuffer.h | 1 + 2 files changed, 69 insertions(+), 1 deletion(-) diff

[PATCH 5/6] drm/msm: Add support for address space instances

2020-06-11 Thread Jordan Crouse
Add support for allocating an address space instance. Targets that support per-instance pagetables should implement their own function to allocate a new instance. The default will return the existing generic address space. Signed-off-by: Jordan Crouse --- drivers/gpu/drm/msm/msm_drv.c | 15

[PATCH v8 0/7] iommu/arm-smmu: Enable split pagetable support

2020-06-11 Thread Jordan Crouse
Another iteration of the split-pagetable support for arm-smmu and the Adreno GPU SMMU. After email discussions [1] we opted to make a arm-smmu implementation for specifically for the Adreno GPU and use that to enable split pagetable support and later other implementation specific bits that we

[PATCH v8 6/7] drm/msm: Set the global virtual address range from the IOMMU domain

2020-06-11 Thread Jordan Crouse
Use the aperture settings from the IOMMU domain to set up the virtual address range for the GPU. This allows us to transparently deal with IOMMU side features (like split pagetables). Signed-off-by: Jordan Crouse --- drivers/gpu/drm/msm/adreno/adreno_gpu.c | 13 +++--

Re: [PATCH v2 09/15] pwm: crc: Enable/disable PWM output on enable/disable

2020-06-11 Thread Uwe Kleine-König
On Sun, Jun 07, 2020 at 08:18:34PM +0200, Hans de Goede wrote: > The pwm-crc code is using 2 different enable bits: > 1. bit 7 of the PWM0_CLK_DIV (PWM_OUTPUT_ENABLE) > 2. bit 0 of the BACKLIGHT_EN register > > So far we've kept the PWM_OUTPUT_ENABLE bit set when disabling the PWM, > this commit

Re: [PATCH v2 03/15] pwm: lpss: Add range limit check for the base_unit register value

2020-06-11 Thread Uwe Kleine-König
On Mon, Jun 08, 2020 at 01:07:12PM +0200, Hans de Goede wrote: > Hi, > > On 6/8/20 5:50 AM, Andy Shevchenko wrote: > > On Sun, Jun 07, 2020 at 08:18:28PM +0200, Hans de Goede wrote: > > > When the user requests a high enough period ns value, then the > > > calculations in pwm_lpss_prepare() might

Re: [PATCH v2 11/15] pwm: crc: Implement get_state() method

2020-06-11 Thread Uwe Kleine-König
Hello, On Sun, Jun 07, 2020 at 08:18:36PM +0200, Hans de Goede wrote: > Implement the pwm_ops.get_state() method to complete the support for the > new atomic PWM API. > > Signed-off-by: Hans de Goede > --- > drivers/pwm/pwm-crc.c | 29 + > 1 file changed, 29

Re: pwm/i915: Convert pwm-crc and i915 driver's PWM code to use the atomic PWM API

2020-06-11 Thread Uwe Kleine-König
Hello, On Mon, Jun 08, 2020 at 04:35:00PM +0200, Daniel Vetter wrote: > On Sat, Jun 06, 2020 at 10:25:45PM +0200, Hans de Goede wrote: > > Hi All, > > > > This patch series converts the i915 driver's cpde for controlling the > > panel's backlight with an external PWM controller to use the atomic

Re: [PATCH v6 4/5] drm/msm/dp: add support for DP PLL driver

2020-06-11 Thread tanmay
Hi Stephen, Thanks for reviews. Please ignore previous response to this patch. Here, I have re-organized it. Thanks, On 2020-06-11 13:07, tan...@codeaurora.org wrote: On 2020-06-09 19:06, Stephen Boyd wrote: Quoting Tanmay Shah (2020-06-08 20:46:23) diff --git

Re: [PATCH v6 2/5] drm: add constant N value in helper file

2020-06-11 Thread tanmay
On 2020-06-09 19:20, Stephen Boyd wrote: Quoting Tanmay Shah (2020-06-08 20:40:47) From: Chandan Uddaraju The constant N value (0x8000) is used by i915 DP driver. Define this value in dp helper header file to use in multiple Display Port drivers. Change i915 driver accordingly. Change in v6:

Re: [PATCH v6 4/5] drm/msm/dp: add support for DP PLL driver

2020-06-11 Thread tanmay
On 2020-06-09 19:06, Stephen Boyd wrote: Quoting Tanmay Shah (2020-06-08 20:46:23) diff --git a/drivers/gpu/drm/msm/dp/dp_catalog.c b/drivers/gpu/drm/msm/dp/dp_catalog.c index d02f4eb..2b982f0 100644 --- a/drivers/gpu/drm/msm/dp/dp_catalog.c +++ b/drivers/gpu/drm/msm/dp/dp_catalog.c @@ -5,6

Re: [PATCH v6 1/5] dt-bindings: msm/dp: add bindings of DP/DP-PLL driver for Snapdragon

2020-06-11 Thread tanmay
On 2020-06-09 19:15, Stephen Boyd wrote: Quoting Tanmay Shah (2020-06-08 20:38:18) diff --git a/Documentation/devicetree/bindings/display/msm/dp-sc7180.yaml b/Documentation/devicetree/bindings/display/msm/dp-sc7180.yaml new file mode 100644 index 000..5fdb915 --- /dev/null +++

Re: [git pull] drm i915 fixes for rc1

2020-06-11 Thread pr-tracker-bot
The pull request you sent on Thu, 11 Jun 2020 13:56:23 +1000: > git://anongit.freedesktop.org/drm/drm tags/drm-next-2020-06-11 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/66057dd1d1cf2149e0f5fdaee58d6ea69bc98048 Thank you! -- Deet-doot-dot, I am a bot.

Re: [git pull] drm fixes for 5.7-rc1 (updated pull)

2020-06-11 Thread pr-tracker-bot
The pull request you sent on Thu, 11 Jun 2020 18:38:54 +1000: > git://anongit.freedesktop.org/drm/drm tags/drm-next-2020-06-11-1 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/d4e181f204dd0491da6c1d09b7208a0b990ec887 Thank you! -- Deet-doot-dot, I am a bot.

Re: [PATCH v2 1/4] dt-bindings: display: simple: add CDTech S070PWS19HP-FC21 and S070SWV29HG-DC44

2020-06-11 Thread Sam Ravnborg
Hi Matthias. On Thu, Jun 11, 2020 at 02:46:22PM +0200, Matthias Schiffer wrote: > On Thu, 2020-06-11 at 14:42 +0200, Matthias Schiffer wrote: > > Add the CDTech Electronics displays S070PWS19HP-FC21 (7.0" WSVGA) and > > S070SWV29HG-DC44 (7.0" WVGA) to the panel-simple compatible list. > > > >

Re: [PATCH v2 11/22] drm: mxsfb: Stop using DRM simple display pipeline helper

2020-06-11 Thread Stefan Agner
On 2020-05-30 05:10, Laurent Pinchart wrote: > The DRM simple display pipeline helper only supports a single plane. In > order to prepare for support of the alpha plane on i.MX6SX and i.MX7, > move away from the helper. No new feature is added. > > Signed-off-by: Laurent Pinchart > --- > Changes

Re: [PATCH 2/3] drm/ast: Upcast from DRM device to ast structure via to_ast_private()

2020-06-11 Thread Sam Ravnborg
Hi Thomas. On Thu, Jun 11, 2020 at 10:28:08AM +0200, Thomas Zimmermann wrote: > All upcasting from struct drm_device to struct ast_private is now > performed via to_ast_private(). Using struct drm_device.dev_private is > deprecated. This is a simple 1:1 conversion. But some cases - I checked

Re: [PATCH 3/3] drm/ast: Use per-device logging macros

2020-06-11 Thread Sam Ravnborg
Hi Thomas. On Thu, Jun 11, 2020 at 10:28:09AM +0200, Thomas Zimmermann wrote: > Converts the ast driver to drm_info() and drm_err(). No functional > changes are made. > > Signed-off-by: Thomas Zimmermann Acked-by: Sam Ravnborg I hope you will later follow-up with a patch that introduces

Re: [PATCH v2 21/22] drm: mxsfb: Remove unnecessary spaces after tab

2020-06-11 Thread Stefan Agner
On 2020-05-30 05:10, Laurent Pinchart wrote: > This is a cosmetic change only, no code change is included. > > Signed-off-by: Laurent Pinchart Reviewed-by: Stefan Agner > --- > drivers/gpu/drm/mxsfb/mxsfb_drv.h | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff

Re: [PATCH v2 16/22] drm: mxsfb: Add i.MX7 and i.MX8M to the list of supported SoCs in Kconfig

2020-06-11 Thread Stefan Agner
On 2020-05-30 05:10, Laurent Pinchart wrote: > Extend the Kconfig option description by listing the i.MX7 and i.MX8M > SoCs, as they are supported by the same driver. Replace the list of SoCs > in the short description with just "(e)LCDIF LCD controller" to avoid > expanding it further in the

Re: [PATCH v2 14/22] drm: mxsfb: Enable vblank handling

2020-06-11 Thread Stefan Agner
On 2020-05-30 05:10, Laurent Pinchart wrote: > Enable vblank handling when the CRTC is turned on and disable it when it > is turned off. This requires moving vblank init after the KMS pipeline > initialisation, otherwise drm_vblank_init() gets called with 0 CRTCs. > > Signed-off-by: Laurent

Re: [PATCH] drm/bridge: make array frs_limits static, makes object smaller

2020-06-11 Thread Joe Perches
On Thu, 2020-06-11 at 14:39 +0100, Colin King wrote: > From: Colin Ian King > > Don't populate the array frs_limits on the stack but instead make it > static. Makes the object code smaller by 123 bytes > > Before: >text data bss dec hex filename > 23456 5712

Re: [v1] drm/msm/dpu: request for display color blocks based on hw catalog entry

2020-06-11 Thread John Stultz
On Thu, Jun 11, 2020 at 5:55 AM Krishna Manikandan wrote: > > From: Kalyan Thota > > Request for color processing blocks only if they are > available in the display hw catalog and they are > sufficient in number for the selection. > > Signed-off-by: Kalyan Thota Tested-by: John Stultz Thanks

Re: [PATCH 3/3] drm/ast: Use per-device logging macros

2020-06-11 Thread Daniel Vetter
On Thu, Jun 11, 2020 at 10:28:09AM +0200, Thomas Zimmermann wrote: > Converts the ast driver to drm_info() and drm_err(). No functional > changes are made. > > Signed-off-by: Thomas Zimmermann I didn't check whether it compiles, but looks all good to me. Reviewed-by: Daniel Vetter > --- >

Re: [PATCH 2/3] drm/ast: Upcast from DRM device to ast structure via to_ast_private()

2020-06-11 Thread Daniel Vetter
On Thu, Jun 11, 2020 at 10:28:08AM +0200, Thomas Zimmermann wrote: > All upcasting from struct drm_device to struct ast_private is now > performed via to_ast_private(). Using struct drm_device.dev_private is > deprecated. The ast variable in ast_crtc_helperatomic_check() is unused, > so removed

[Bug 207901] Nouveau: In a 4 monitor setup, 1-2 displays remains black after boot

2020-06-11 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=207901 --- Comment #16 from Lyude Paul (ly...@redhat.com) --- (In reply to Maurice Gale from comment #15) > Hi! I have installed the closed source nvidia driver(nvidia-driver-440), and > I am able to successfully get every display on every single boot.

Re: [PATCH 1/3] drm/ast: Remove unused code paths for AST 1180

2020-06-11 Thread Daniel Vetter
On Thu, Jun 11, 2020 at 10:28:07AM +0200, Thomas Zimmermann wrote: > The ast driver contains code paths for AST 1180 chips. The chip is not > supported and the rsp code has never been tested. Simplify the driver by > removing the AST 1180 code. > > Signed-off-by: Thomas Zimmermann Reviewed-by:

Re: [PATCH v3 5/5] dt-bindings: display: ti,tfp410.yaml: make the ports node optional

2020-06-11 Thread Laurent Pinchart
Hi Ricardo, Thank you for the patch. On Thu, Jun 11, 2020 at 12:23:56PM +0200, Ricardo Cañuelo wrote: > Make the ports node optional, since there are some DTs that don't define > any ports for ti,tfp410. > > Signed-off-by: Ricardo Cañuelo Shouldn't we fix those DTs instead ? What's the point

Re: [PATCH v2 3/4] drm: bridge: add it66121 driver

2020-06-11 Thread Drew Fustini
On Wed, Mar 11, 2020 at 01:51:34PM +0100, Phong LE wrote: > This commit is a simple driver for bridge HMDI it66121. > The input format is RBG and there is no color conversion. > Audio, HDCP and CEC are not supported yet. > > Signed-off-by: Phong LE > --- > drivers/gpu/drm/bridge/Kconfig |

Re: [PATCH 1/6] drm/ttm: Add unampping of the entire device address space

2020-06-11 Thread Andrey Grodzovsky
On 6/10/20 5:16 PM, Daniel Vetter wrote: On Wed, Jun 10, 2020 at 10:30 PM Thomas Hellström (Intel) wrote: On 6/10/20 5:30 PM, Daniel Vetter wrote: On Wed, Jun 10, 2020 at 04:05:04PM +0200, Christian König wrote: Am 10.06.20 um 15:54 schrieb Andrey Grodzovsky: On 6/10/20 6:15 AM, Thomas

Re: [v1] drm/msm/dpu: request for display color blocks based on hw catalog entry

2020-06-11 Thread Rob Clark
On Thu, Jun 11, 2020 at 5:55 AM Krishna Manikandan wrote: > > From: Kalyan Thota > > Request for color processing blocks only if they are > available in the display hw catalog and they are > sufficient in number for the selection. > I believe this should have: Fixes: e47616df008b

Re: [PATCH 1/6] drm/ttm: Add unampping of the entire device address space

2020-06-11 Thread Andrey Grodzovsky
On 6/11/20 2:35 AM, Thomas Hellström (Intel) wrote: On 6/10/20 11:19 PM, Andrey Grodzovsky wrote: On 6/10/20 4:30 PM, Thomas Hellström (Intel) wrote: On 6/10/20 5:30 PM, Daniel Vetter wrote: On Wed, Jun 10, 2020 at 04:05:04PM +0200, Christian König wrote: Am 10.06.20 um 15:54 schrieb

Re: [Intel-gfx] [PATCH 03/18] dma-fence: basic lockdep annotations

2020-06-11 Thread Daniel Vetter
On Thu, Jun 11, 2020 at 4:29 PM Tvrtko Ursulin wrote: > > > On 11/06/2020 12:29, Daniel Vetter wrote: > > On Thu, Jun 11, 2020 at 12:36 PM Tvrtko Ursulin > > wrote: > >> On 10/06/2020 16:17, Daniel Vetter wrote: > >>> On Wed, Jun 10, 2020 at 4:22 PM Tvrtko Ursulin > >>> wrote: > > >

Re: [PATCH 1/2] drm/imx: fix use after free

2020-06-11 Thread Philipp Zabel
Hi Russell, On Thu, 2020-06-11 at 14:01 +0100, Russell King - ARM Linux admin wrote: > On Thu, Jun 11, 2020 at 02:43:31PM +0200, Marco Felsch wrote: > > From: Philipp Zabel > > > > Component driver structures allocated with devm_kmalloc() in bind() are > > freed automatically after unbind().

Re: [PATCH 4/4] drm/bridge: ti-sn65dsi86: Check the regmap return value when setting a GPIO

2020-06-11 Thread Doug Anderson
Hi, On Thu, Jun 11, 2020 at 2:58 AM Stephen Boyd wrote: > > Quoting Douglas Anderson (2020-06-08 10:48:35) > > The ti_sn_bridge_gpio_set() got the return value of > > regmap_update_bits() but didn't check it. The function can't return > > an error value, but we should at least print a warning

Re: [Intel-gfx] [PATCH 03/18] dma-fence: basic lockdep annotations

2020-06-11 Thread Tvrtko Ursulin
On 11/06/2020 12:29, Daniel Vetter wrote: > On Thu, Jun 11, 2020 at 12:36 PM Tvrtko Ursulin > wrote: >> On 10/06/2020 16:17, Daniel Vetter wrote: >>> On Wed, Jun 10, 2020 at 4:22 PM Tvrtko Ursulin >>> wrote: On 04/06/2020 09:12, Daniel Vetter wrote: > Design is similar to the

[PATCH] drm/bridge: make array frs_limits static, makes object smaller

2020-06-11 Thread Colin King
From: Colin Ian King Don't populate the array frs_limits on the stack but instead make it static. Makes the object code smaller by 123 bytes Before: textdata bss dec hex filename 234565712 64 292327230 drivers/gpu/drm/bridge/tc358768.o After: textdata

Re: [PATCH 1/2] drm/imx: fix use after free

2020-06-11 Thread Russell King - ARM Linux admin
On Thu, Jun 11, 2020 at 02:43:31PM +0200, Marco Felsch wrote: > From: Philipp Zabel > > Component driver structures allocated with devm_kmalloc() in bind() are > freed automatically after unbind(). Since the contained drm structures > are accessed afterwards in drm_mode_config_cleanup(), move

Re: ✓ Fi.CI.IGT: success for series starting with [1/3] drm/dp_mst: Fix the DDC I2C device unregistration of an MST port (rev2)

2020-06-11 Thread Imre Deak
On Thu, Jun 11, 2020 at 08:46:16AM +, Patchwork wrote: > == Series Details == > > Series: series starting with [1/3] drm/dp_mst: Fix the DDC I2C device > unregistration of an MST port (rev2) > URL : https://patchwork.freedesktop.org/series/78100/ > State : success Thanks for the review,

Re: ✓ Fi.CI.IGT: success for series starting with [RESEND,v3,1/3] drm/i915/dp_mst: Fix disabling MST on a port (rev6)

2020-06-11 Thread Imre Deak
On Fri, Jun 05, 2020 at 01:53:52PM +, Patchwork wrote: > == Series Details == > > Series: series starting with [RESEND,v3,1/3] drm/i915/dp_mst: Fix disabling > MST on a port (rev6) > URL : https://patchwork.freedesktop.org/series/77969/ > State : success Thanks for the reviews, pushed

[PATCH 2/2] drm/imx: tve: fix regulator_disable error path

2020-06-11 Thread Marco Felsch
Add missing regulator_disable() as devm_action to avoid dedicated unbind() callback and fix the missing error handling. Fixes: fcbc51e54d2a ("staging: drm/imx: Add support for Television Encoder (TVEv2)") Signed-off-by: Marco Felsch --- Note: This patch depends on: 14422f14da81 ("component:

[PATCH 1/2] drm/imx: fix use after free

2020-06-11 Thread Marco Felsch
From: Philipp Zabel Component driver structures allocated with devm_kmalloc() in bind() are freed automatically after unbind(). Since the contained drm structures are accessed afterwards in drm_mode_config_cleanup(), move the allocation into probe() to extend the driver structure's lifetime to

Re: [PATCH 57/59] drm/ast: Use managed pci functions

2020-06-11 Thread Thomas Zimmermann
Hi Am 15.04.20 um 09:40 schrieb Daniel Vetter: > Allows us to remove a bit of cleanup code. > > Signed-off-by: Daniel Vetter > Cc: Dave Airlie > Cc: Thomas Zimmermann > Cc: Gerd Hoffmann > Cc: Daniel Vetter > Cc: Emil Velikov > Cc: "Noralf Trønnes" > Cc: Sam Ravnborg > Cc: "Christian

[PATCH v2] dma-buf: Move dma_buf_release() from fops to dentry_ops

2020-06-11 Thread Sumit Semwal
Charan Teja reported a 'use-after-free' in dmabuffs_dname [1], which happens if the dma_buf_release() is called while the userspace is accessing the dma_buf pseudo fs's dmabuffs_dname() in another process, and dma_buf_release() releases the dmabuf object when the last reference to the struct file

Re: [Intel-gfx] [PATCH 03/18] dma-fence: basic lockdep annotations

2020-06-11 Thread Daniel Vetter
On Thu, Jun 11, 2020 at 12:36 PM Tvrtko Ursulin wrote: > > > On 10/06/2020 16:17, Daniel Vetter wrote: > > On Wed, Jun 10, 2020 at 4:22 PM Tvrtko Ursulin > > wrote: > >> > >> > >> On 04/06/2020 09:12, Daniel Vetter wrote: > >>> Design is similar to the lockdep annotations for workers, but with >

Re: [Intel-gfx] [PATCH 03/18] dma-fence: basic lockdep annotations

2020-06-11 Thread Tvrtko Ursulin
On 10/06/2020 16:17, Daniel Vetter wrote: > On Wed, Jun 10, 2020 at 4:22 PM Tvrtko Ursulin > wrote: >> >> >> On 04/06/2020 09:12, Daniel Vetter wrote: >>> Design is similar to the lockdep annotations for workers, but with >>> some twists: >>> >>> - We use a read-lock for the

[PATCH v3 1/5] dt-bindings: display: ti,tfp410.txt: convert to yaml

2020-06-11 Thread Ricardo Cañuelo
Convert the DT binding documentation for the TI TFP410 DPI-to-DVI encoder to json-schema. Signed-off-by: Ricardo Cañuelo Reviewed-by: Laurent Pinchart --- .../bindings/display/bridge/ti,tfp410.txt | 66 - .../bindings/display/bridge/ti,tfp410.yaml| 130 ++ 2

[PATCH v3 5/5] dt-bindings: display: ti, tfp410.yaml: make the ports node optional

2020-06-11 Thread Ricardo Cañuelo
Make the ports node optional, since there are some DTs that don't define any ports for ti,tfp410. Signed-off-by: Ricardo Cañuelo --- Documentation/devicetree/bindings/display/bridge/ti,tfp410.yaml | 1 - 1 file changed, 1 deletion(-) diff --git

[PATCH v3 2/5] dt-bindings: display: ti, tfp410.yaml: Redefine ti, deskew property

2020-06-11 Thread Ricardo Cañuelo
This changes how the 'ti,deskew' property is defined. It's now an unsigned value from 0 to 7 instead of a signed value from -4 to 3. Until the dtc carries the integer sign through to the yaml output it's easier to define signed types as unsigned. Signed-off-by: Ricardo Cañuelo Reviewed-by:

[PATCH v3 4/5] drm/bridge: tfp410: Fix setup and hold time calculation

2020-06-11 Thread Ricardo Cañuelo
This fixes a bug in the calculation of the setup and hold times based on the deskew configuration. Signed-off-by: Ricardo Cañuelo Reviewed-by: Laurent Pinchart --- drivers/gpu/drm/bridge/ti-tfp410.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH v3 0/5] dt-bindings: display: ti,tfp410.txt: convert to yaml

2020-06-11 Thread Ricardo Cañuelo
This series converts the DT binding for the TI TFP410 DPI-to-DVI encoder to json-schema. This also fixes a minor bug in the ti-tfp410 driver that would cause a wrong calculation of the setup and hold times when the de-skew feature is enabled. The retrieval of the de-skew value from the DT has

[PATCH v3 3/5] drm/bridge: tfp410: fix de-skew value retrieval from DT

2020-06-11 Thread Ricardo Cañuelo
The tfp410 has a data de-skew feature that allows the user to compensate the skew between IDCK and the pixel data and control signals. In the driver, the setup and hold times are calculated from the de-skew value. This retrieves the deskew value from the DT using the proper datatype and range

[Bug 208129] amdgpu: polaris10 sudden crash, garbled graphics.

2020-06-11 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=208129 --- Comment #7 from Martin Jørgensen (m...@gotu.dk) --- I try upgrade to latest available kernel, Mesa, Xorg in Debian testing/bullseye and see if it makes a difference. -- You are receiving this mail because: You are watching the assignee of

Re: [PATCH] dma-fence: basic lockdep annotations

2020-06-11 Thread Maarten Lankhorst
Op 05-06-2020 om 15:29 schreef Daniel Vetter: > Design is similar to the lockdep annotations for workers, but with > some twists: > > - We use a read-lock for the execution/worker/completion side, so that > this explicit annotation can be more liberally sprinkled around. > With read locks

Re: [v3] drm/bridge: ti-sn65dsi86: ensure bridge suspend happens during PM sleep

2020-06-11 Thread Stephen Boyd
Quoting Harigovindan P (2020-06-09 05:04:55) > ti-sn65dsi86 bridge is enumerated as a runtime device. When > suspend is triggered, PM core adds a refcount on all the > devices and calls device suspend, since usage count is > already incremented, runtime suspend will not be called > and it kept the

Re: [PATCH v2] drm/panfrost: Use kvfree() to free bo->sgts

2020-06-11 Thread Steven Price
On 08/06/2020 16:17, Denis Efremov wrote: Use kvfree() to free bo->sgts, because the memory is allocated with kvmalloc_array() in panfrost_mmu_map_fault_addr(). Fixes: 187d2929206e ("drm/panfrost: Add support for GPU heap allocations") Cc: sta...@vger.kernel.org Signed-off-by: Denis Efremov

Re: [PATCH v6 2/5] drm: add constant N value in helper file

2020-06-11 Thread Jani Nikula
On Mon, 08 Jun 2020, Tanmay Shah wrote: > From: Chandan Uddaraju > > The constant N value (0x8000) is used by i915 DP > driver. Define this value in dp helper header file > to use in multiple Display Port drivers. Change > i915 driver accordingly. > > Change in v6: Change commit message > >

Re: [PATCH 2/2] panfrost: Add compatible string for bifrost

2020-06-11 Thread Heiko Stuebner
Am Donnerstag, 11. Juni 2020, 10:58:44 CEST schrieb Tomeu Vizoso: > Mesa now supports some Bifrost devices, so enable it. > > Signed-off-by: Tomeu Vizoso > --- > drivers/gpu/drm/panfrost/panfrost_drv.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git

Re: [PATCH 1/2] panfrost: Make sure GPU is powered on when reading GPU_LATEST_FLUSH_ID

2020-06-11 Thread Heiko Stuebner
Am Donnerstag, 11. Juni 2020, 10:58:43 CEST schrieb Tomeu Vizoso: > Bifrost devices do support the flush reduction feature, so on first job > submit we were trying to read the register while still powered off. > > If the GPU is powered off, the feature doesn't bring any benefit, so > don't try to

Re: [Intel-gfx] [PATCH 03/18] dma-fence: basic lockdep annotations

2020-06-11 Thread Daniel Stone
Hi, On Thu, 11 Jun 2020 at 09:44, Dave Airlie wrote: > On Thu, 11 Jun 2020 at 18:01, Chris Wilson wrote: > > Introducing a global lockmap that cannot capture the rules correctly, > > Can you document the rules all drivers should be following then, > because from here it looks to get refactored

[PATCH 2/2] panfrost: Add compatible string for bifrost

2020-06-11 Thread Tomeu Vizoso
Mesa now supports some Bifrost devices, so enable it. Signed-off-by: Tomeu Vizoso --- drivers/gpu/drm/panfrost/panfrost_drv.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/panfrost/panfrost_drv.c b/drivers/gpu/drm/panfrost/panfrost_drv.c index 882fecc33fdb..8ff8e140f91e

[PATCH 1/2] panfrost: Make sure GPU is powered on when reading GPU_LATEST_FLUSH_ID

2020-06-11 Thread Tomeu Vizoso
Bifrost devices do support the flush reduction feature, so on first job submit we were trying to read the register while still powered off. If the GPU is powered off, the feature doesn't bring any benefit, so don't try to read. Signed-off-by: Tomeu Vizoso ---

Re: [git pull] drm fixes for 5.8-rc1 (updated pull)

2020-06-11 Thread Dave Airlie
(now with a subject you might see). On Thu, 11 Jun 2020 at 18:38, Dave Airlie wrote: > > Hi Linus, > > This is the update of the pull I sent earlier today, it's got a couple > of more fixes along with the i915 fixes. One sun4i fix and a connector > hotplug race The ast fix is for a regression in

Re: [PATCH 03/18] dma-fence: basic lockdep annotations

2020-06-11 Thread Dave Airlie
On Thu, 11 Jun 2020 at 18:01, Chris Wilson wrote: > > Quoting Daniel Vetter (2020-06-04 09:12:09) > > Design is similar to the lockdep annotations for workers, but with > > some twists: > > > > - We use a read-lock for the execution/worker/completion side, so that > > this explicit annotation

[git pull] drm fixes for 5.7-rc1 (updated pull)

2020-06-11 Thread Dave Airlie
Hi Linus, This is the update of the pull I sent earlier today, it's got a couple of more fixes along with the i915 fixes. One sun4i fix and a connector hotplug race The ast fix is for a regression in 5.6, and as mentioned previously one of the i915 ones fixes an oops reported by dhowells.

Re: [Linaro-mm-sig] [PATCH 04/18] dma-fence: prime lockdep annotations

2020-06-11 Thread Daniel Vetter
On Thu, Jun 11, 2020 at 09:30:12AM +0200, Thomas Hellström (Intel) wrote: > > On 6/4/20 10:12 AM, Daniel Vetter wrote: > > Two in one go: > > - it is allowed to call dma_fence_wait() while holding a > >dma_resv_lock(). This is fundamental to how eviction works with ttm, > >so required. >

[PATCH 2/3] drm/ast: Upcast from DRM device to ast structure via to_ast_private()

2020-06-11 Thread Thomas Zimmermann
All upcasting from struct drm_device to struct ast_private is now performed via to_ast_private(). Using struct drm_device.dev_private is deprecated. The ast variable in ast_crtc_helperatomic_check() is unused, so removed it. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/ast/ast_dp501.c |

[PATCH 3/3] drm/ast: Use per-device logging macros

2020-06-11 Thread Thomas Zimmermann
Converts the ast driver to drm_info() and drm_err(). No functional changes are made. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/ast/ast_main.c | 34 +- drivers/gpu/drm/ast/ast_mode.c | 8 drivers/gpu/drm/ast/ast_post.c | 2 +-

[PATCH 0/3] ast cleanups

2020-06-11 Thread Thomas Zimmermann
Ast still has to be converted to managed initialization, and embed the DRM device in the ast structure. In preparation of these changes, add some cleanups to the driver. Tested on ast HW. Thomas Zimmermann (3): drm/ast: Remove unused code paths for AST 1180 drm/ast: Upcast from DRM device to

[PATCH 1/3] drm/ast: Remove unused code paths for AST 1180

2020-06-11 Thread Thomas Zimmermann
The ast driver contains code paths for AST 1180 chips. The chip is not supported and the rsp code has never been tested. Simplify the driver by removing the AST 1180 code. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/ast/ast_drv.c | 1 - drivers/gpu/drm/ast/ast_drv.h | 2 -

Re: [PATCH] drm/tegra: Add zpos property for cursor planes

2020-06-11 Thread Daniel Stone
Hi Dmitry, On Thu, 11 Jun 2020 at 08:54, Dmitry Osipenko wrote: > 10.06.2020 14:30, Thierry Reding пишет: > > From: Thierry Reding > > As of commit 4dc55525b095 ("drm: plane: Verify that no or all planes > > have a zpos property") a warning is emitted if there's a mix of planes > > with and

Re: [PATCH 1/6] drm/ttm: Add unampping of the entire device address space

2020-06-11 Thread Daniel Vetter
On Thu, Jun 11, 2020 at 08:12:37AM +0200, Thomas Hellström (Intel) wrote: > > On 6/10/20 11:16 PM, Daniel Vetter wrote: > > On Wed, Jun 10, 2020 at 10:30 PM Thomas Hellström (Intel) > > wrote: > > > > > > On 6/10/20 5:30 PM, Daniel Vetter wrote: > > > > On Wed, Jun 10, 2020 at 04:05:04PM +0200,

Re: [PATCH 03/18] dma-fence: basic lockdep annotations

2020-06-11 Thread Chris Wilson
Quoting Daniel Vetter (2020-06-04 09:12:09) > Design is similar to the lockdep annotations for workers, but with > some twists: > > - We use a read-lock for the execution/worker/completion side, so that > this explicit annotation can be more liberally sprinkled around. > With read locks

[PATCH 4/4] drm/panel: simple: add Tianma TM070JVHG33

2020-06-11 Thread Matthias Schiffer
From: Max Merchel Add support for the Tianma Micro-electronics TM070JVHG33 7.0" WXGA display to panel-simple. Signed-off-by: Max Merchel Signed-off-by: Matthias Schiffer --- drivers/gpu/drm/panel/panel-simple.c | 14 ++ 1 file changed, 14 insertions(+) diff --git

Re: [PATCH 1/5] drm/omap: Fix suspend resume regression after platform data removal

2020-06-11 Thread Tony Lindgren
* Tomi Valkeinen [200610 11:48]: > On 09/06/2020 20:10, Tony Lindgren wrote: > > > > On beagle-x15 I see these errors after modprobe: > > > > > > DSS: OMAP DSS rev 6.1 > > > omapdss_dss 5800.dss: bound 58001000.dispc (ops dispc_component_ops > > > [omapdss]) > > > omapdss_dss 5800.dss:

[RESEND][PATCH v8 4/8] PM / EM: add support for other devices than CPUs in Energy Model

2020-06-11 Thread Lukasz Luba
Add support for other devices than CPUs. The registration function does not require a valid cpumask pointer and is ready to handle new devices. Some of the internal structures has been reorganized in order to keep consistent view (like removing per_cpu pd pointers). Signed-off-by: Lukasz Luba

[PATCH v6] drm/i915: Init lspcon after HPD in intel_dp_detect()

2020-06-11 Thread Kai-Heng Feng
On HP 800 G4 DM, if HDMI cable isn't plugged before boot, the HDMI port becomes useless and never responds to cable hotplugging: [3.031904] [drm:lspcon_init [i915]] *ERROR* Failed to probe lspcon [3.031945] [drm:intel_ddi_init [i915]] *ERROR* LSPCON init failed on port D Seems like the

Re: [PATCH 01/11] tty/sysrq: alpha: export and use __sysrq_get_key_op()

2020-06-11 Thread Guenter Roeck
On Wed, May 13, 2020 at 10:43:41PM +0100, Emil Velikov wrote: > Export a pointer to the sysrq_get_key_op(). This way we can cleanly > unregister it, instead of the current solutions of modifuing it inplace. > > Since __sysrq_get_key_op() is no longer used externally, let's make it > a static

[PATCH 3/4] drm/panel: simple: add CDTech S070PWS19HP-FC21 and S070SWV29HG-DC44

2020-06-11 Thread Matthias Schiffer
From: Michael Krummsdorf Add support for the CDTech Electronics displays S070PWS19HP-FC21 (7.0" WSVGA) and S070SWV29HG-DC44 (7.0" WVGA) to panel-simple. Signed-off-by: Michael Krummsdorf Signed-off-by: Matthias Schiffer --- drivers/gpu/drm/panel/panel-simple.c | 60

[PATCH 2/4] dt-bindings: display: simple: add Tianma TM070JVHG33

2020-06-11 Thread Matthias Schiffer
Add the Tianma Micro-electronics TM070JVHG33 7.0" WXGA display to the panel-simple compatible list. Signed-off-by: Matthias Schiffer --- .../devicetree/bindings/display/panel/panel-simple.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git

Re: [PATCH] drm/sun4i: hdmi ddc clk: Fix size of m divider

2020-06-11 Thread Maxime Ripard
On Thu, Jun 04, 2020 at 01:19:32PM +0800, Chen-Yu Tsai wrote: > On Wed, Apr 22, 2020 at 5:23 PM Maxime Ripard wrote: > > > > Hi, > > > > On Wed, Apr 15, 2020 at 07:52:28PM +0200, Jernej Škrabec wrote: > > > Dne sreda, 15. april 2020 ob 12:42:14 CEST je Maxime Ripard napisal(a): > > > > On Mon,

[PATCH 0/4] panel-simple: CDTech S070PWS19HP-FC21 and S070SWV29HG-DC44, Tianma TM070JVHG33

2020-06-11 Thread Matthias Schiffer
From: Matthias Schiffer This adds a few panels TQ-Systems uses with various starterkit mainboards. Device trees actually using these panels will be added with a later submission. Matthias Schiffer (2): dt-bindings: display: simple: add CDTech S070PWS19HP-FC21 and S070SWV29HG-DC44

Re: [PATCH] drm/tegra: Add zpos property for cursor planes

2020-06-11 Thread Dmitry Osipenko
10.06.2020 14:30, Thierry Reding пишет: > From: Thierry Reding > > As of commit 4dc55525b095 ("drm: plane: Verify that no or all planes > have a zpos property") a warning is emitted if there's a mix of planes > with and without a zpos property. > > On Tegra, cursor planes are always composited

Re: [PATCH v3 066/105] drm/vc4: txp: Turn the TXP into a CRTC of its own

2020-06-11 Thread Maxime Ripard
Hi Emil, On Thu, May 28, 2020 at 04:51:31PM +0100, Emil Velikov wrote: > Have you considered splitting the series into several parts and > focusing on merging one at a time? > IIRC this the longest series _ever_ submitted to dri-devel, plus it > seems to be growing with each revision. > > Due to

Re: (EXT) Re: [PATCH 3/4] drm/panel: simple: add CDTech S070PWS19HP-FC21 and S070SWV29HG-DC44

2020-06-11 Thread Matthias Schiffer
On Wed, 2020-06-10 at 16:59 +0200, Sam Ravnborg wrote: > Hi Matthias. > > Thanks, a few details you need to fix. See below. > > Sam > > On Wed, Jun 10, 2020 at 02:01:30PM +0200, Matthias Schiffer wrote: > > From: Michael Krummsdorf > > > > Add support for the CDTech Electronics displays

  1   2   >