Re: [PATCH v3 2/5] dt-bindings: adv7511: Add support for i2c_new_secondary_device

2018-02-13 Thread Laurent Pinchart
Hi Kieran, Thank you for the patch. On Tuesday, 13 February 2018 00:07:50 EET Kieran Bingham wrote: > From: Kieran Bingham > > The ADV7511 has four 256-byte maps that can be accessed via the main I²C > ports. Each map has it own I²C address and acts as

Re: [PATCH v7 3/6] iommu/arm-smmu: Invoke pm_runtime during probe, add/remove device

2018-02-13 Thread Robin Murphy
On 13/02/18 08:24, Tomasz Figa wrote: Hi Vivek, Thanks for the patch. Please see my comments inline. On Wed, Feb 7, 2018 at 7:31 PM, Vivek Gautam wrote: From: Sricharan R The smmu device probe/remove and add/remove master device

Re: Thinkpad X1 Carbon 3rd - Reducing the compressed framebuffer size

2018-02-13 Thread Pali Rohár
On Tuesday 13 February 2018 15:27:26 Ville Syrjälä wrote: > On Tue, Feb 13, 2018 at 09:50:30AM +0100, Pali Rohár wrote: > > On Tuesday 06 February 2018 16:21:43 Pali Rohár wrote: > > > Hi! I'm periodically getting following message in dmesg on Lenovo > > > Thinkpad X1 Carbon 3rd generation: > > >

[Bug 105076] [CI] results file indicate incomplete run.log says pass

2018-02-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105076 Marta Löfstedt changed: What|Removed |Added Whiteboard||ReadyForDev

Re: [PATCH 3/4] drm/tve200: Do not use deprecated drm_driver.{enable|disable)_vblank

2018-02-13 Thread Oleksandr Andrushchenko
On 02/13/2018 03:51 PM, Linus Walleij wrote: On Mon, Feb 12, 2018 at 9:52 AM, Oleksandr Andrushchenko wrote: From: Oleksandr Andrushchenko Do not use deprecated drm_driver.{enable|disable)_vblank callbacks, but use drm_simple_kms_helpe's

Re: [PATCH 0/5] Fix deadlock on runtime suspend in DRM drivers

2018-02-13 Thread Lukas Wunner
On Tue, Feb 13, 2018 at 10:55:06AM +, Liviu Dudau wrote: > On Sun, Feb 11, 2018 at 10:38:28AM +0100, Lukas Wunner wrote: > > DRM drivers poll connectors in 10 sec intervals. The poll worker is > > stopped on ->runtime_suspend with cancel_delayed_work_sync(). However > > the poll worker

[PATCH v2 28/30] drm: omapdrm: hdmi5: Allocate the omap_hdmi data structure dynamically

2018-02-13 Thread Laurent Pinchart
The omap_hdmi private data structure is currently stored as a global variable. While no platform with multiple HDMI5 encoders currently exists nor is planned, this doesn't comply with the kernel device model and should thus be fixed. Signed-off-by: Laurent Pinchart

[PATCH v2 15/30] drm: omapdrm: dsi: Pass the dsi_data pointer to internal functions

2018-02-13 Thread Laurent Pinchart
Internal dsi functions take a pointer to the DSI platform_device and then cast it to a dsi_data pointer. That's pointless as the caller already has the dsi_data pointer. Pass it directly instead of the platform_device pointer. Signed-off-by: Laurent Pinchart

[PATCH v2 24/30] drm: omapdrm: dispc: Pass DISPC pointer to dispc_ops operations

2018-02-13 Thread Laurent Pinchart
This removes the need to access the global DISPC private data in those functions (both for the current accesses and the future ones that will be introduced when allocating the DISPC private data dynamically). In order to allow the omapdrm side to call the dispc_ops with a DISPC pointer, we also

[PATCH v2 22/30] drm: omapdrm: dss: Store DSS device pointer in the omapdrm private data

2018-02-13 Thread Laurent Pinchart
The dss_device is the top-level component in the omapdss driver. Give the omapdrm driver access to the dss_device pointer in order to obtain pointers to all other components from it. This requires a new global variable in the omapdss driver that will be removed when merging the omapdrm and omapdss

[PATCH v2 14/30] drm: omapdrm: dss: Don't unnecessarily cast to dev to pdev and back

2018-02-13 Thread Laurent Pinchart
The dss_unbind() function casts the struct device pointer to a struct platform_device, only to later use the struct device pointer from platform_device. Don't cast at all. Signed-off-by: Laurent Pinchart --- drivers/gpu/drm/omapdrm/dss/dss.c | 4 +--- 1 file

[PATCH v2 23/30] drm: omapdrm: dss: Store dispc ops in dss_device structure

2018-02-13 Thread Laurent Pinchart
Remove the global dispc ops variable by storing it in the dss_device structure. Signed-off-by: Laurent Pinchart --- drivers/gpu/drm/omapdrm/dss/base.c| 13 - drivers/gpu/drm/omapdrm/dss/dispc.c | 6 -- drivers/gpu/drm/omapdrm/dss/dss.h

Re: [PATCH v7 1/6] base: power: runtime: Export pm_runtime_get/put_suppliers

2018-02-13 Thread Robin Murphy
On 13/02/18 07:44, Tomasz Figa wrote: Hi Vivek, On Wed, Feb 7, 2018 at 7:31 PM, Vivek Gautam wrote: The device link allows the pm framework to tie the supplier and consumer. So, whenever the consumer is powered-on the supplier is powered-on first. There are

[PATCH v2 30/30] drm: omapdrm: venc: Allocate the venc private data structure dynamically

2018-02-13 Thread Laurent Pinchart
The venc private data structure is currently stored as a global variable. While no platform with multiple VENC encoders currently exists nor is planned, this doesn't comply with the kernel device model and should thus be fixed. Signed-off-by: Laurent Pinchart

[PATCH v2 25/30] drm: omapdrm: dispc: Pass DISPC pointer to remaining dispc API functions

2018-02-13 Thread Laurent Pinchart
This removes the need to access the global DISPC private data in those functions (both for the current accesses and the future ones that will be introduced when allocating the DISPC private data dynamically). Signed-off-by: Laurent Pinchart Reviewed-by:

[PATCH v2 16/30] drm: omapdrm: dsi: Combine two commonly used inline functions

2018-02-13 Thread Laurent Pinchart
The dsi_get_dsidrv_data() and dsi_get_dsidev_from_dssdev() inline functions convert a struct omap_dss_device pointer to the corresponding struct platform_device, and a struct platform_device pointer to the corresponding struct dsi_data. They are nearly always called together without any use of the

[PATCH v2 08/30] drm: omapdrm: dss: Pass DSS pointer to dss clock functions

2018-02-13 Thread Laurent Pinchart
This removes the need to access the global DSS private data in those functions (both for the current accesses and the future ones that will be introduced when allocating the DSS device dynamically). Signed-off-by: Laurent Pinchart Reviewed-by: Sebastian Reichel

[PATCH v2 29/30] drm: omapdrm: sdi: Allocate the sdi private data structure dynamically

2018-02-13 Thread Laurent Pinchart
The sdi private data structure is currently stored as a global variable. While no platform with multiple SDI encoders currently exists nor is planned, this doesn't comply with the kernel device model and should thus be fixed. Signed-off-by: Laurent Pinchart

[PATCH v2 18/30] drm: omapdrm: dsi: Store the struct device pointer in struct dsi_data

2018-02-13 Thread Laurent Pinchart
The dsi_data structure stores a pointer to a struct platform_device. The driver only uses the dev member of the platform device structure. Store the struct device pointer instead and use it directly. Signed-off-by: Laurent Pinchart Reviewed-by: Sebastian

[PATCH v2 27/30] drm: omapdrm: hdmi4: Allocate the omap_hdmi data structure dynamically

2018-02-13 Thread Laurent Pinchart
The omap_hdmi private data structure is currently stored as a global variable. While no platform with multiple HDMI4 encoders currently exists nor is planned, this doesn't comply with the kernel device model and should thus be fixed. Signed-off-by: Laurent Pinchart

[PATCH v2 21/30] drm: omapdrm: dss: Pass omap_drm_private pointer to dss_mgr_ops

2018-02-13 Thread Laurent Pinchart
The dss_mgr_ops operations implemented by the omapdrm side have to look up the omap_crtc objects from global variables as they are only passed a channel number. In order to remove global variables in the omapdrm driver pass the omap_drm_private pointer to the dss_mgr_ops. This requires storing a

Re: [PATCH v7 1/6] base: power: runtime: Export pm_runtime_get/put_suppliers

2018-02-13 Thread Tomasz Figa
On Tue, Feb 13, 2018 at 9:00 PM, Robin Murphy wrote: > On 13/02/18 07:44, Tomasz Figa wrote: >> >> Hi Vivek, >> >> On Wed, Feb 7, 2018 at 7:31 PM, Vivek Gautam >> wrote: >>> >>> The device link allows the pm framework to tie the supplier and >>>

Re: [PATCH] drm: Use idr_init_base(1) when using id==0 for invalid

2018-02-13 Thread Christian König
Am 12.02.2018 um 18:14 schrieb Ville Syrjälä: On Mon, Feb 12, 2018 at 02:55:33PM +, Chris Wilson wrote: Use the new idr_init_base() function to create an IDR that knows id==0 is never allocated as it maps to an invalid identifier. By knowing that id==0 is invalid, the IDR can start from

[PATCH v2 07/30] drm: omapdrm: dss: Pass DSS pointer to dss_get_*_clk_source()

2018-02-13 Thread Laurent Pinchart
This removes the need to access the global DSS private data in those functions (both for the current accesses and the future ones that will be introduced when allocating the DSS device dynamically). Signed-off-by: Laurent Pinchart Reviewed-by: Sebastian Reichel

[PATCH v2 11/30] drm: omapdrm: dss: Support passing private data to debugfs show handlers

2018-02-13 Thread Laurent Pinchart
To simplify implementation of debugfs seq_file show handlers, the driver passes the pointer to the show function through the debugfs_create_file data pointer. This prevents using the pointer to pass driver private data to the show handler, and requires all handlers to use global variables to

[PATCH v2 10/30] drm: omapdrm: dss: Allocate the DSS private data structure dynamically

2018-02-13 Thread Laurent Pinchart
The DSS private data structure is currently stored as a global variable. While no platform with multiple DSS devices currently exists nor is planned, this doesn't comply with the kernel device model and should thus be fixed. Allocate the DSS private data structure dynamically for each DSS

[PATCH v2 12/30] drm: omapdrm: dss: Store the registered plls array in struct dss_device

2018-02-13 Thread Laurent Pinchart
As part of an effort to remove the usage of global variables in the driver, store the registered plls array in the dss_device structure instead of a global variable. Signed-off-by: Laurent Pinchart Reviewed-by: Sebastian Reichel

[PATCH v2 20/30] drm: omapdrm: dss: Pass omap_dss_device pointer to dss_mgr_*() functions

2018-02-13 Thread Laurent Pinchart
The dss_mgr_*() functions take a channel argument to identify the channel they operate on. This prevents the functions from accessing driver data structures without resorting to global variables. In an effort to remove global variables, pass the omap_dss_device pointer associated with the channel

[PATCH v2 13/30] drm: omapdrm: dss: Store the debugfs root directory in struct dss_device

2018-02-13 Thread Laurent Pinchart
As part of an effort to remove the usage of global variables in the driver, store the debugfs root directory in the dss_device structure instead of a global variable. Signed-off-by: Laurent Pinchart Reviewed-by: Sebastian Reichel

[PATCH v2 19/30] drm: omapdrm: dsi: Don't pass channel to dispc init/uninit functions

2018-02-13 Thread Laurent Pinchart
The dsi_display_init_dispc() and dsi_display_uninit_dispc() functions take a channel argument that is reduntant as it is always identical to the dsi->output.dispc_channel. Remove the argument and use the field directly in the functions to avoid misuse. Signed-off-by: Laurent Pinchart

[PATCH v2 09/30] drm: omapdrm: dss: Pass DSS pointer to remaining dss functions

2018-02-13 Thread Laurent Pinchart
This removes the need to access the global DSS private data in those functions (both for the current accesses and the future ones that will be introduced when allocating the DSS device dynamically). Signed-off-by: Laurent Pinchart Reviewed-by: Sebastian Reichel

[PATCH v2 17/30] drm: omapdrm: dsi: Use dev pointer directly in dsi_bind() function

2018-02-13 Thread Laurent Pinchart
The dsi_bind() function receives a pointer to a struct device that it casts to a struct platform_device, only to use the platform device's dev field through the code. Use the dev pointer directly. While at it rename the struct platform_device pointer dsidev to pdev to make it more explicit.

[PATCH v2 06/30] drm: omapdrm: dss: Pass DSS pointer to dss_ops operations

2018-02-13 Thread Laurent Pinchart
This removes the need to access the global DSS private data in those functions (both for the current accesses and the future ones that will be introduced when allocating the DSS device dynamically). Signed-off-by: Laurent Pinchart Reviewed-by: Sebastian Reichel

[PATCH v2 05/30] drm: omapdrm: dss: Pass DSS pointer to dss_sdi_*() functions

2018-02-13 Thread Laurent Pinchart
This removes the need to access the global DSS private data in those functions (both for the current accesses and the future ones that will be introduced when allocating the DSS device dynamically). Signed-off-by: Laurent Pinchart Reviewed-by: Sebastian Reichel

[PATCH v2 02/30] drm: omapdrm: dss: Expose DSS data in a dss_device structure

2018-02-13 Thread Laurent Pinchart
The anoonymous dss structure in dss.c is the top-level component in the omapdss driver. As such it should store all internal instance-specific data that is currently stored in global variables. This however requires both naming the structure to pass it around functions, and accessing it from

[Bug 99353] Kaveri 7400K shows random colored noise instead of GUI in X or Wayland

2018-02-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99353 --- Comment #27 from Bong Cosca --- Created attachment 137313 --> https://bugs.freedesktop.org/attachment.cgi?id=137313=edit drm.debug=0x1e Output generated by: dmesg | grep drm Additional trace log to aid perhaps in

Re: [PATCH v7 1/6] base: power: runtime: Export pm_runtime_get/put_suppliers

2018-02-13 Thread Robin Murphy
On 13/02/18 12:54, Tomasz Figa wrote: On Tue, Feb 13, 2018 at 9:00 PM, Robin Murphy wrote: On 13/02/18 07:44, Tomasz Figa wrote: Hi Vivek, On Wed, Feb 7, 2018 at 7:31 PM, Vivek Gautam wrote: The device link allows the pm framework to tie

Re: [Mesa-dev] [PATCH 6/7] vulkan: Add new VK_MESA_query_timestamp extension

2018-02-13 Thread Lionel Landwerlin
On 13/02/18 00:20, Dylan Baker wrote: Quoting Keith Packard (2018-02-09 20:45:15) This extension adds a single function to query the current GPU timestamp, just like glGetInteger64v(GL_TIMESTAMP, ). This function is needed to complete the implementation of GOOGLE_display_timing, which needs to

[PATCH v2 04/30] drm: omapdrm: dss: Pass PLL pointer to dss_ctrl_pll_enable()

2018-02-13 Thread Laurent Pinchart
This will allow accessing the PLL data to get the DSS device pointer, removing the need to access the global DSS private data. Signed-off-by: Laurent Pinchart Reviewed-by: Sebastian Reichel ---

[PATCH v2 03/30] drm: omapdrm: dss: Pass DSS private structure to runtime PM functions

2018-02-13 Thread Laurent Pinchart
To prepare for the removal of the global variable storing DSS private data, pass its pointer to the dss_runtime_{get,put}() functions. As this requires getting hold of the dss_device structure in the callers, we add a new dss_get_device() function to retrieve it. The function currently returns a

[PATCH v2 01/30] drm: omapdrm: Split init and cleanup from probe and remove functions

2018-02-13 Thread Laurent Pinchart
When merging the omapdrm and omapdss drivers there will be not omapdrm platform device anymore, and thus no associated probe and remove functions. To prepare for that, split all the initialization code from the probe function to make it usable without a platform device. Similarly, split the

[PATCH v2 00/30] omapdrm: Allocate objects dynamically

2018-02-13 Thread Laurent Pinchart
Hello, Most of this series has previously been posted as part of "[PATCH 00/48] omapdrm: Merge omapdrm and omapdss". With "[PATCH v2 00/15] omapdrm: Miscellaneous fixes and cleanups" posted and merged a few days ago, it completes the rework of the omapdrm and omapdss drivers to replace most

[Bug 117591] amdgpu: Black screens on A10-8700P (Carrizo) + R7 M260/M265 (Topaz) Combo

2018-02-13 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=117591 Jani Väinölä (jani.vain...@gmail.com) changed: What|Removed |Added Resolution|CODE_FIX|UNREPRODUCIBLE

[Bug 117591] amdgpu: Black screens on A10-8700P (Carrizo) + R7 M260/M265 (Topaz) Combo

2018-02-13 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=117591 Jani Väinölä (jani.vain...@gmail.com) changed: What|Removed |Added Status|NEW |RESOLVED

Re: [PATCH v3 1/5] dt-bindings: media: adv7604: Add support for i2c_new_secondary_device

2018-02-13 Thread Kieran Bingham
Hi Laurent, On 13/02/18 12:06, Laurent Pinchart wrote: > Hi Kieran, > > Thank you for the patch. Thank you for your review, > On Tuesday, 13 February 2018 00:07:49 EET Kieran Bingham wrote: >> From: Jean-Michel Hautbois >> >> The ADV7604 has thirteen 256-byte

[Bug 105072] Texture corruption covering screen

2018-02-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105072 Bug ID: 105072 Summary: Texture corruption covering screen Product: Mesa Version: 17.3 Hardware: x86-64 (AMD64) OS: Linux (All) Status: NEW Severity:

Re: [PATCH v2 5/5] drm: adv7511: Add support for i2c_new_secondary_device

2018-02-13 Thread Kieran Bingham
Hi Dan Thank you for the review, On 13/02/18 07:23, Dan Carpenter wrote: > On Mon, Feb 12, 2018 at 06:11:57PM +, Kieran Bingham wrote: >> +adv7511->i2c_packet = i2c_new_secondary_device(i2c, "packet", >> +ADV7511_PACKET_I2C_ADDR_DEFAULT); >> +if

Re: Thinkpad X1 Carbon 3rd - Reducing the compressed framebuffer size

2018-02-13 Thread Ville Syrjälä
On Tue, Feb 13, 2018 at 09:50:30AM +0100, Pali Rohár wrote: > On Tuesday 06 February 2018 16:21:43 Pali Rohár wrote: > > Hi! I'm periodically getting following message in dmesg on Lenovo > > Thinkpad X1 Carbon 3rd generation: > > > > [drm] Reducing the compressed framebuffer size. This may lead

Re: [PATCH v3 4/5] media: adv7604: Add support for i2c_new_secondary_device

2018-02-13 Thread Laurent Pinchart
Hi Kieran, Thank you for the patch. On Tuesday, 13 February 2018 00:07:52 EET Kieran Bingham wrote: > From: Jean-Michel Hautbois > > The ADV7604 has thirteen 256-byte maps that can be accessed via the main > I²C ports. Each map has it own I²C address and acts

Re: [PATCH v3 1/5] dt-bindings: media: adv7604: Add support for i2c_new_secondary_device

2018-02-13 Thread Laurent Pinchart
Hi Kieran, On Tuesday, 13 February 2018 15:14:43 EET Kieran Bingham wrote: > On 13/02/18 12:06, Laurent Pinchart wrote: > > On Tuesday, 13 February 2018 00:07:49 EET Kieran Bingham wrote: > >> From: Jean-Michel Hautbois > >> > >> The ADV7604 has thirteen

Re: [RFC] drm/atomic: Abuse legacy cursor update flag for legacy gamma update too

2018-02-13 Thread Ville Syrjälä
On Tue, Feb 13, 2018 at 10:33:28AM +0100, Maarten Lankhorst wrote: > Hey, > > Op 13-02-18 om 10:16 schreef Chris Wilson: > > Quoting Maarten Lankhorst (2018-02-13 09:12:01) > >> Programs like redshift set the legacy gamma for X.org every 5 seconds. > >> Because atomic commits wait for vblank

Re: [PATCH 3/4] drm/tve200: Do not use deprecated drm_driver.{enable|disable)_vblank

2018-02-13 Thread Linus Walleij
On Mon, Feb 12, 2018 at 9:52 AM, Oleksandr Andrushchenko wrote: > From: Oleksandr Andrushchenko > > Do not use deprecated drm_driver.{enable|disable)_vblank callbacks, > but use drm_simple_kms_helpe's pipe callbacks instead. > >

[Bug 105076] [CI] results file indicate incomplete run.log say pass

2018-02-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105076 Marta Löfstedt changed: What|Removed |Added Summary|[CI] results file indicate |[CI] results

Re: [PATCH v3] Fix loading of module radeonfb on PowerMac

2018-02-13 Thread Bartlomiej Zolnierkiewicz
On Saturday, February 10, 2018 01:48:55 PM Mathieu Malaterre wrote: > Hi, > > On Thu, Feb 8, 2018 at 2:28 PM, Bartlomiej Zolnierkiewicz > wrote: > > On Wednesday, January 31, 2018 08:51:23 PM Mathieu Malaterre wrote: > >> Bartlomiej, > >> > >> On Wed, Jan 31, 2018 at

Re: [PATCH v3 1/5] dt-bindings: media: adv7604: Add support for i2c_new_secondary_device

2018-02-13 Thread Laurent Pinchart
Hi Kieran, Thank you for the patch. On Tuesday, 13 February 2018 00:07:49 EET Kieran Bingham wrote: > From: Jean-Michel Hautbois > > The ADV7604 has thirteen 256-byte maps that can be accessed via the main > I²C ports. Each map has it own I²C address and acts

Re: [PATCH v3 3/5] [RFT] ARM: dts: wheat: Fix ADV7513 address usage

2018-02-13 Thread Laurent Pinchart
Hi Kieran, Thank you for the patch. On Tuesday, 13 February 2018 00:07:51 EET Kieran Bingham wrote: > From: Kieran Bingham > > The r8a7792 Wheat board has two ADV7513 devices sharing a single i2c > bus, however in low power mode the ADV7513 will reset

Re: [PATCH v3 5/5] drm: adv7511: Add support for i2c_new_secondary_device

2018-02-13 Thread Laurent Pinchart
Hi Kieran, Thank you for the patch. On Tuesday, 13 February 2018 00:07:53 EET Kieran Bingham wrote: > From: Kieran Bingham > > The ADV7511 has four 256-byte maps that can be accessed via the main I²C > ports. Each map has it own I²C address and acts as

Re: [PATCH 02/11] video: fbdev: kconfig: Remove blank help text

2018-02-13 Thread Bartlomiej Zolnierkiewicz
On Thursday, February 01, 2018 05:56:18 PM Ulf Magnusson wrote: > On Thu, Feb 1, 2018 at 4:52 PM, Bartlomiej Zolnierkiewicz > wrote: > > > > Hi, > > > > On Wednesday, January 31, 2018 10:34:21 AM Ulf Magnusson wrote: > >> Blank help texts are probably either a typo, a

Re: [PATCH v3 5/8] drm: Handle aspect ratio info in atomic and legacy modeset paths

2018-02-13 Thread Ville Syrjälä
On Tue, Feb 13, 2018 at 10:21:15AM +0530, Nautiyal, Ankit K wrote: > Hi Ville, > > As per our last discussion, following points were discussed: > > 1. To suppress the aspect-ratio info from getblob ioctl to a user that > does not support it: > > i. A new flag must be added to

Re: [PATCH v7 3/6] iommu/arm-smmu: Invoke pm_runtime during probe, add/remove device

2018-02-13 Thread Tomasz Figa
On Tue, Feb 13, 2018 at 9:57 PM, Robin Murphy wrote: > On 13/02/18 08:24, Tomasz Figa wrote: >> >> Hi Vivek, >> >> Thanks for the patch. Please see my comments inline. >> >> On Wed, Feb 7, 2018 at 7:31 PM, Vivek Gautam >> wrote: >>> >>> From:

Re: [PATCH v7 6/6] drm/msm: iommu: Replace runtime calls with runtime suppliers

2018-02-13 Thread Tomasz Figa
Hi Vivek, Thanks for the patch. Please see my comments inline. On Wed, Feb 7, 2018 at 7:31 PM, Vivek Gautam wrote: > While handling the concerned iommu, there should not be a > need to power control the drm devices from iommu interface. > If these drm devices need

[RFC] drm/atomic: Abuse legacy cursor update flag for legacy gamma update too

2018-02-13 Thread Maarten Lankhorst
Programs like redshift set the legacy gamma for X.org every 5 seconds. Because atomic commits wait for vblank completion, we get a frame drop every 5 seconds because of the legacy gamma update. Work around this by setting the legacy_cursor_update flag, to force legacy gamma updates not to be

Re: [PATCH 0/5] Fix deadlock on runtime suspend in DRM drivers

2018-02-13 Thread Liviu Dudau
Hi Lukas, On Sun, Feb 11, 2018 at 10:38:28AM +0100, Lukas Wunner wrote: > Fix a deadlock on hybrid graphics laptops that's been present since 2013: > > DRM drivers poll connectors in 10 sec intervals. The poll worker is > stopped on ->runtime_suspend with cancel_delayed_work_sync(). However >

Re: [PATCH v7 3/6] iommu/arm-smmu: Invoke pm_runtime during probe, add/remove device

2018-02-13 Thread Tomasz Figa
Hi Vivek, Thanks for the patch. Please see my comments inline. On Wed, Feb 7, 2018 at 7:31 PM, Vivek Gautam wrote: > From: Sricharan R > > The smmu device probe/remove and add/remove master device callbacks > gets called when the smmu is

Re: Thinkpad X1 Carbon 3rd - Reducing the compressed framebuffer size

2018-02-13 Thread Pali Rohár
On Tuesday 06 February 2018 16:21:43 Pali Rohár wrote: > Hi! I'm periodically getting following message in dmesg on Lenovo > Thinkpad X1 Carbon 3rd generation: > > [drm] Reducing the compressed framebuffer size. This may lead to less power > savings than a non-reduced-size. Try to increase

[Bug 105021] suspend / rx550 / extremely slow after 2nd thaw

2018-02-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105021 --- Comment #8 from Michel Dänzer --- (In reply to arne_woerner from comment #4) > in the first few seconds yes, but then no... So the slowness is probably due to the GPU's IRQ no longer working, the question is why that

Re: [RFC] drm/atomic: Abuse legacy cursor update flag for legacy gamma update too

2018-02-13 Thread Maarten Lankhorst
Hey, Op 13-02-18 om 10:16 schreef Chris Wilson: > Quoting Maarten Lankhorst (2018-02-13 09:12:01) >> Programs like redshift set the legacy gamma for X.org every 5 seconds. >> Because atomic commits wait for vblank completion, we get a frame drop >> every 5 seconds because of the legacy gamma

Re: [PATCH v7 4/6] iommu/arm-smmu: Add the device_link between masters and smmu

2018-02-13 Thread Tomasz Figa
Hi Vivek, Thanks for the patch. Please see my comments inline. On Wed, Feb 7, 2018 at 7:31 PM, Vivek Gautam wrote: > From: Sricharan R > > Finally add the device link between the master device and > smmu, so that the smmu gets runtime

Re: WARNING in drm_modeset_lock_all

2018-02-13 Thread Dmitry Vyukov
On Tue, Oct 31, 2017 at 2:03 PM, Dmitry Vyukov wrote: > On Tue, Oct 31, 2017 at 3:45 PM, Chris Wilson > wrote: >> Quoting syzbot (2017-10-27 09:09:50) >>> This bug is generated by a dumb bot. It may contain errors. >>> See https://goo.gl/tpsmEJ for

Re: [PATCH 2/4] drm/mxsfb: Do not use deprecated drm_driver.{enable|disable)_vblank

2018-02-13 Thread Marek Vasut
On 02/12/2018 09:52 AM, Oleksandr Andrushchenko wrote: > From: Oleksandr Andrushchenko > > Do not use deprecated drm_driver.{enable|disable)_vblank callbacks, > but use drm_simple_kms_helpe's pipe callbacks instead. > > Signed-off-by: Oleksandr Andrushchenko

Re: [RFC][PATCH 4/4 v2] drm_hwcomposer: Try to fallback if GLCompisition fails

2018-02-13 Thread Alexandru-Cosmin Gheorghe
On Mon, Feb 12, 2018 at 08:43:10PM -0800, John Stultz wrote: > On Wed, Jan 31, 2018 at 11:03 AM, John Stultz wrote: > > On Wed, Jan 31, 2018 at 10:51 AM, Alexandru-Cosmin Gheorghe > > wrote: > >> It seems that we don't pass any explicit

[PATCH] drm/simple_kms_helper: Fix NULL pointer dereference with no active CRTC

2018-02-13 Thread Oleksandr Andrushchenko
From: Oleksandr Andrushchenko It is possible that drm_simple_kms_plane_atomic_check called with no CRTC set, e.g. when user-space application sets CRTC_ID/FB_ID to 0 before doing any actual drawing. This leads to NULL pointer dereference because in this case new

Re: [PATCH] drm/rockchip: Don't use spin_lock_irqsave in interrupt context

2018-02-13 Thread Marc Zyngier
Hi Heiko, On 10/02/18 16:23, Heiko Stuebner wrote: > Hi Marc, > > Am Samstag, 10. Februar 2018, 15:35:01 CET schrieb Marc Zyngier: >> The rockchip DRM driver is quite careful to disable interrupts >> when taking a lock that is also taken in interrupt context, >> which is a good thing. >> >> What

Re: [PATCH v7 2/6] iommu/arm-smmu: Add pm_runtime/sleep ops

2018-02-13 Thread Tomasz Figa
Hi Vivek, Thanks for the patch. Please see some comments inline. On Wed, Feb 7, 2018 at 7:31 PM, Vivek Gautam wrote: > From: Sricharan R > > The smmu needs to be functional only when the respective > master's using it are active. The

Re: [RFC] drm/atomic: Abuse legacy cursor update flag for legacy gamma update too

2018-02-13 Thread Chris Wilson
Quoting Maarten Lankhorst (2018-02-13 09:12:01) > Programs like redshift set the legacy gamma for X.org every 5 seconds. > Because atomic commits wait for vblank completion, we get a frame drop > every 5 seconds because of the legacy gamma update. > > Work around this by setting the

Re: [PATCH 0/5] Fix deadlock on runtime suspend in DRM drivers

2018-02-13 Thread Lukas Wunner
On Mon, Feb 12, 2018 at 01:58:32PM -0500, Alex Deucher wrote: > On Mon, Feb 12, 2018 at 4:45 AM, Lukas Wunner wrote: > > On Mon, Feb 12, 2018 at 09:03:26AM +, Mike Lothian wrote: > >> On 12 February 2018 at 03:39, Lukas Wunner wrote: > >> > On Mon, Feb 12,

Re: [PATCH v8 5/6] iommu/arm-smmu: Add support for qcom, smmu-v2 variant

2018-02-13 Thread Tomasz Figa
Hi Vivek, Thanks for the patch. Please see my comments inline. On Fri, Feb 9, 2018 at 7:57 PM, Vivek Gautam wrote: > qcom,smmu-v2 is an arm,smmu-v2 implementation with specific > clock and power requirements. This smmu core is used with > multiple masters on

Re: Thinkpad X1 Carbon 3rd - Reducing the compressed framebuffer size

2018-02-13 Thread Pali Rohár
On Tuesday 13 February 2018 17:36:54 Ville Syrjälä wrote: > On Tue, Feb 13, 2018 at 02:38:42PM +0100, Pali Rohár wrote: > > On Tuesday 13 February 2018 15:27:26 Ville Syrjälä wrote: > > > On Tue, Feb 13, 2018 at 09:50:30AM +0100, Pali Rohár wrote: > > > > On Tuesday 06 February 2018 16:21:43 Pali

[Bug 105018] Kernel panic when waking up after screen goes blank.

2018-02-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105018 --- Comment #12 from Harry Wentland --- Are you able to rebuild the kernel with the attached patches and see if that fixes things? -- You are receiving this mail because: You are the assignee for the

Re: [PATCH v3 5/8] drm: Handle aspect ratio info in atomic and legacy modeset paths

2018-02-13 Thread Nautiyal, Ankit K
Hi Ville, Thanks yet again to look into this. I am still skeptical about rejecting the mode, if aspect ratio cap is not set. Perhaps I am not aware with the userspace expectations. Please find my response inline: On 2/13/2018 6:48 PM, Ville Syrjälä wrote: On Tue, Feb 13, 2018 at 10:21:15AM

Re: [PATCH 0/5] Fix deadlock on runtime suspend in DRM drivers

2018-02-13 Thread Liviu Dudau
On Tue, Feb 13, 2018 at 12:52:06PM +0100, Lukas Wunner wrote: > On Tue, Feb 13, 2018 at 10:55:06AM +, Liviu Dudau wrote: > > On Sun, Feb 11, 2018 at 10:38:28AM +0100, Lukas Wunner wrote: > > > DRM drivers poll connectors in 10 sec intervals. The poll worker is > > > stopped on

[Bug 105018] Kernel panic when waking up after screen goes blank.

2018-02-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105018 --- Comment #10 from Harry Wentland --- Created attachment 137324 --> https://bugs.freedesktop.org/attachment.cgi?id=137324=edit Patch 3 Clean up formatting in irq_service_dce110.c -- You are receiving this mail

[Bug 105018] Kernel panic when waking up after screen goes blank.

2018-02-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105018 --- Comment #11 from Harry Wentland --- Created attachment 137325 --> https://bugs.freedesktop.org/attachment.cgi?id=137325=edit Patch 4 Don't blow up if TG is NULL in dce110_vblank_set -- You are receiving this mail

Re: [PATCH v3 1/2] drm/virtio: Add window server support

2018-02-13 Thread Tomeu Vizoso
On 02/12/2018 12:45 PM, Gerd Hoffmann wrote: Hi, (a) software rendering: client allocates shared memory buffer, renders into it, then passes a file handle for that shmem block together with some meta data (size, format, ...) to the wayland server. (b) gpu rendering:

Re: [PATCH 0/5] Fix deadlock on runtime suspend in DRM drivers

2018-02-13 Thread Alex Deucher
On Tue, Feb 13, 2018 at 3:17 AM, Lukas Wunner wrote: > On Mon, Feb 12, 2018 at 01:58:32PM -0500, Alex Deucher wrote: >> On Mon, Feb 12, 2018 at 4:45 AM, Lukas Wunner wrote: >> > On Mon, Feb 12, 2018 at 09:03:26AM +, Mike Lothian wrote: >> >> On 12 February

[Bug 99353] Kaveri 7400K shows random colored noise instead of GUI in X or Wayland

2018-02-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99353 --- Comment #29 from Michel Dänzer --- (In reply to Bong Cosca from comment #28) > [drm:radeon_crtc_handle_flip [radeon]] radeon_crtc->flip_status = 0 != > RADEON_FLIP_SUBMITTED(2) This is harmless and not related to the

Re: Thinkpad X1 Carbon 3rd - Reducing the compressed framebuffer size

2018-02-13 Thread Ville Syrjälä
On Tue, Feb 13, 2018 at 05:04:37PM +0100, Pali Rohár wrote: > On Tuesday 13 February 2018 17:36:54 Ville Syrjälä wrote: > > On Tue, Feb 13, 2018 at 02:38:42PM +0100, Pali Rohár wrote: > > > On Tuesday 13 February 2018 15:27:26 Ville Syrjälä wrote: > > > > On Tue, Feb 13, 2018 at 09:50:30AM +0100,

[Bug 105018] Kernel panic when waking up after screen goes blank.

2018-02-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105018 --- Comment #8 from Harry Wentland --- Created attachment 137322 --> https://bugs.freedesktop.org/attachment.cgi?id=137322=edit Patch 1 Use crtc enable/disable_vblank hooks -- You are receiving this mail because: You

[Bug 105018] Kernel panic when waking up after screen goes blank.

2018-02-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105018 --- Comment #9 from Harry Wentland --- Created attachment 137323 --> https://bugs.freedesktop.org/attachment.cgi?id=137323=edit Patch 2 Return success when enabling interrupt -- You are receiving this mail because:

[Bug 99353] Kaveri 7400K shows random colored noise instead of GUI in X or Wayland

2018-02-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99353 --- Comment #28 from Bong Cosca --- I find this message particularly interesting because it occurs several times in the dmesg log: [drm:radeon_crtc_handle_flip [radeon]] radeon_crtc->flip_status = 0 !=

Re: Thinkpad X1 Carbon 3rd - Reducing the compressed framebuffer size

2018-02-13 Thread Ville Syrjälä
On Tue, Feb 13, 2018 at 02:38:42PM +0100, Pali Rohár wrote: > On Tuesday 13 February 2018 15:27:26 Ville Syrjälä wrote: > > On Tue, Feb 13, 2018 at 09:50:30AM +0100, Pali Rohár wrote: > > > On Tuesday 06 February 2018 16:21:43 Pali Rohár wrote: > > > > Hi! I'm periodically getting following

Re: [PATCH v3 5/5] drm: adv7511: Add support for i2c_new_secondary_device

2018-02-13 Thread Kieran Bingham
Hi Laurent, Thanks for the review, On 13/02/18 12:23, Laurent Pinchart wrote: > Hi Kieran, > > Thank you for the patch. > > On Tuesday, 13 February 2018 00:07:53 EET Kieran Bingham wrote: >> From: Kieran Bingham >> >> The ADV7511 has four 256-byte maps

Re: [PATCH v7 6/6] drm/msm: iommu: Replace runtime calls with runtime suppliers

2018-02-13 Thread Jordan Crouse
On Tue, Feb 13, 2018 at 06:10:38PM +0900, Tomasz Figa wrote: > Hi Vivek, > > Thanks for the patch. Please see my comments inline. > > On Wed, Feb 7, 2018 at 7:31 PM, Vivek Gautam > wrote: > > While handling the concerned iommu, there should not be a > > need to

[PATCH v4 2/5] dt-bindings: adv7511: Extend bindings to allow specifying slave map addresses

2018-02-13 Thread Kieran Bingham
From: Kieran Bingham The ADV7511 has four 256-byte maps that can be accessed via the main I2C ports. Each map has it own I2C address and acts as a standard slave device on the I2C bus. Extend the device tree node bindings to be able to override the

[PATCH v4 3/5] [RFT] ARM: dts: wheat: Fix ADV7513 address usage

2018-02-13 Thread Kieran Bingham
From: Kieran Bingham The r8a7792 Wheat board has two ADV7513 devices sharing a single I2C bus, however in low power mode the ADV7513 will reset it's slave maps to use the hardware defined default addresses. The ADV7511 driver was adapted to allow the two

[PATCH v4 5/5] drm: adv7511: Add support for i2c_new_secondary_device

2018-02-13 Thread Kieran Bingham
From: Kieran Bingham The ADV7511 has four 256-byte maps that can be accessed via the main I2C ports. Each map has it own I2C address and acts as a standard slave device on the I2C bus. Allow a device tree node to override the default addresses so that

[PATCH v4 4/5] media: adv7604: Add support for i2c_new_secondary_device

2018-02-13 Thread Kieran Bingham
From: Jean-Michel Hautbois The ADV7604 has thirteen 256-byte maps that can be accessed via the main I2C ports. Each map has it own I2C address and acts as a standard slave device on the I2C bus. Allow a device tree node to override the default addresses so that

[PATCH v4 1/5] dt-bindings: media: adv7604: Extend bindings to allow specifying slave map addresses

2018-02-13 Thread Kieran Bingham
From: Jean-Michel Hautbois The ADV7604 has thirteen 256-byte maps that can be accessed via the main I2C ports. Each map has it own I2C address and acts as a standard slave device on the I2C bus. Extend the device tree node bindings to be able to override the

Re: [RFC][PATCH v3] drm_hwcomposer: Add platformhisi buffer importer for hikey and hikey960

2018-02-13 Thread Alexandru-Cosmin Gheorghe
Hi John, Some comments bellow, On Thu, Feb 08, 2018 at 04:40:05PM -0800, John Stultz wrote: > This allows for importing buffers allocated from the > hikey and hikey960 gralloc implelementations. > > Feedback or comments would be greatly appreciated! > > Cc: Marissa Wall >

[PATCH v4 0/5] Add support for i2c_new_secondary_device

2018-02-13 Thread Kieran Bingham
From: Kieran Bingham Back in 2014, Jean-Michel provided patches [0] to implement a means of describing software defined I2C addresses for devices through the DT nodes. The patch to implement the function "i2c_new_secondary_device()" was integrated, but

  1   2   >