Re: [edk2] [PATCH v2 3/3] ArmPlatformPkg/FVP: unify support for Foundation and Base models

2015-08-27 Thread Ryan Harkin
On 18 August 2015 at 15:10, Ard Biesheuvel ard.biesheu...@linaro.org wrote: Now that the PL180 and PL111 drivers know how to behave when executed on the Foundation model that does not emulate the hardware, we can remove the ARM_FOUNDATION_FVP ifdefs and produce a single build that runs on

Re: [edk2] Question about memory reservation from PrePi to DXE

2015-08-27 Thread Gao, Liming
Ben: DxeCore Memory Allocation service is to allocate memory space from high address to low address. CoreInitializeMemoryServices() tries to find the highest memory resource. If so, all allocated memory could be in the continuous high address space and avoid the hole in the whole memory

Re: [edk2] [PATCH v2 2/3] ArmPlatformPkg/LcdGraphicsOutputDxe: check PrimeCell ID before initializing

2015-08-27 Thread Ryan Harkin
On 18 August 2015 at 15:10, Ard Biesheuvel ard.biesheu...@linaro.org wrote: To deal gracefully with the absence of the PL111 hardware on the Foundation model, check the PrimeCell ID before proceeding with the installation. Contributed-under: TianoCore Contribution Agreement 1.0

Re: [edk2] [PATCH v2 0/3] unify FVP Base and Foundation model support

2015-08-27 Thread Ryan Harkin
On 27 August 2015 at 14:44, Ryan Harkin ryan.har...@linaro.org wrote: On 24 August 2015 at 12:22, Ard Biesheuvel ard.biesheu...@linaro.org wrote: On 18 August 2015 at 16:10, Ard Biesheuvel ard.biesheu...@linaro.org wrote: Instead of omitting some drivers that are known to break the

Re: [edk2] USB hot swap support

2015-08-27 Thread Robinson, Keith
Hi Jaben, Thanks for this tip. I'll give it a go and post the results back in case anyone else is interested. Keith -Original Message- From: Carsey, Jaben [mailto:jaben.car...@intel.com] Sent: 27 August 2015 18:10 To: Robinson, Keith; edk2-devel@lists.01.org Cc: Carsey, Jaben

Re: [edk2] USB hot swap support

2015-08-27 Thread Robinson, Keith
Hi Andrew, Many, many thanks for this information. I’ve been searching for ages! Keith. From: Andrew Fish [mailto:af...@apple.com] Sent: 27 August 2015 18:10 To: Robinson, Keith Cc: edk2-devel@lists.01.org Subject: Re: [edk2] USB hot swap support On Aug 27, 2015, at 9:02 AM, Robinson, Keith

Re: [edk2] USB hot swap support

2015-08-27 Thread Andrew Fish
On Aug 27, 2015, at 9:02 AM, Robinson, Keith keith.robin...@viasat.uk.com wrote: Hello, I am trying to determine if it is possible to write a UEFI application that allows the user to swap USB mass storage devices and re-enumerate the new device inserted. The USB stack is hot

[edk2] USB hot swap support

2015-08-27 Thread Robinson, Keith
Hello, I am trying to determine if it is possible to write a UEFI application that allows the user to swap USB mass storage devices and re-enumerate the new device inserted. Thanks, Keith Robinson This email and any files transmitted with it may be confidential, legally privileged and

Re: [edk2] [PATCH v2 0/5] secure boot support for ARM FVP Base and Foundation models

2015-08-27 Thread Ryan Harkin
Hi Ard, I didn't send a Reviewed-by for the first 3 patches because they aren't in my area. But I read through them and they look good to me. If you feel a Reviewed-by is needed from me, I can give them a closer look. Cheers, Ryan. On 26 August 2015 at 10:59, Ard Biesheuvel

[edk2] Duplicate GUID

2015-08-27 Thread Anbazhagan, Baraneedharan
BlockIoPpi GUID is identical to SimpleFileSystem protocol GUID. Can we change BlokcIoPpi GUID value to avoid confusion, though one is PPI and other one is DXE protocol? IntelFrameworkPkg\IntelFrameworkPkg.dec ## Include/Guid/BlockIo.h gEfiPeiIdeBlockIoPpiGuid = { 0x964e5b22, 0x6459,

Re: [edk2] Question about memory reservation from PrePi to DXE

2015-08-27 Thread Benjamin Herrenschmidt
On Thu, 2015-08-27 at 14:40 +, Gao, Liming wrote: Ben: DxeCore Memory Allocation service is to allocate memory space from high address to low address. CoreInitializeMemoryServices() tries to find the highest memory resource. If so, all allocated memory could be in the continuous high

Re: [edk2] Duplicate GUID

2015-08-27 Thread Andrew Fish
On Aug 27, 2015, at 1:11 PM, Anbazhagan, Baraneedharan anbazha...@hp.com wrote: BlockIoPpi GUID is identical to SimpleFileSystem protocol GUID. Can we change BlokcIoPpi GUID value to avoid confusion, though one is PPI and other one is DXE protocol?

Re: [edk2] Measured boot in OVMF with QEMU TPM passthrough?

2015-08-27 Thread David Van Arnem
On 08/25/2015 06:55 PM, Yao, Jiewen wrote: Do you mean TcgPei is added in FDF, but not dispatched by PEI core? If so, please make sure you have below dependency satisfied. I guess you have 1st and 2nd. For 3rd, you can consider adding Tcg2Config driver, or produce gEfiTpmDeviceSelectedGuid in

Re: [edk2] install a PPI with a NULL Ppi value?

2015-08-27 Thread Tim Lewis
That looks like it is setting up for a dependency expression. Check your .infs to see if anyone uses it in their [depex] section. Tim -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Hamel, Lee M Sent: Friday, August 28, 2015 6:24 AM To:

Re: [edk2] install a PPI with a NULL Ppi value?

2015-08-27 Thread Andrew Fish
On Aug 27, 2015, at 3:30 PM, Tim Lewis tim.le...@insyde.com wrote: That looks like it is setting up for a dependency expression. Check your .infs to see if anyone uses it in their [depex] section. Or a PeiServicesNotifyPpi() callback. Thanks, Andrew Fish Tim -Original

Re: [edk2] install a PPI with a NULL Ppi value?

2015-08-27 Thread Hamel, Lee M
gEfiPlatformInfoGuid is only used in BuildGuidDataHob() and GetFirstGuidHob(). -Original Message- From: Andrew Fish [mailto:af...@apple.com] Sent: Thursday, August 27, 2015 3:34 PM To: Hamel, Lee M Cc: edk2-devel@lists.01.org Subject: Re: [edk2] install a PPI with a NULL Ppi value?

[edk2] install a PPI with a NULL Ppi value?

2015-08-27 Thread Hamel, Lee M
Is there a reason why platform code would install a PPI with a NULL Ppi value for the EFI_PEI_PPI_DESCRIPTOR structure? static EFI_PEI_PPI_DESCRIPTOR mPlatformInfoPpi = { EFI_PEI_PPI_DESCRIPTOR_PPI | EFI_PEI_PPI_DESCRIPTOR_TERMINATE_LIST, gEfiPlatformInfoGuid, NULL }; The

Re: [edk2] install a PPI with a NULL Ppi value?

2015-08-27 Thread Hamel, Lee M
I forgot to search *.inf. I find gEfiPlatformInfoGuid in 3, but they are all under [Guids] section. It seems like the PPI isn't needed. -Original Message- From: Tim Lewis [mailto:tim.le...@insyde.com] Sent: Thursday, August 27, 2015 3:31 PM To: Hamel, Lee M; edk2-devel@lists.01.org

[edk2] [PATCH] MdePkg: Refine the device path text format for Bluetooth to follow spec.

2015-08-27 Thread Qiu Shumin
Cc: Liming Gao liming@intel.com Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Qiu Shumin shumin@intel.com --- MdePkg/Library/UefiDevicePathLib/DevicePathFromText.c | 9 + MdePkg/Library/UefiDevicePathLib/DevicePathToText.c | 2 +- 2 files changed, 6

[edk2] [Patch] NetworkPkg: Fix IpSec run into infinite loop issue

2015-08-27 Thread Jiaxin Wu
When use -e to edit SPD database, the corresponding SA entry will be updated to the sas list of the new SPD entry. But before that, all of them should be removed from the original sas list. If not, the list will be broken into infinite loop. Cc: Ye Ting ting...@intel.com Cc: Fu Siyuan

Re: [edk2] [PATCH] MdeModulePkg: Remove unused variables from both UefiBootManagerLib and BdsDxe to fix GCC build.

2015-08-27 Thread Dong, Eric
Checked in code at r18350 -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Dong, Eric Sent: Friday, August 28, 2015 12:54 PM To: Wang, Sunny (HPS SW); edk2-devel@lists.01.org Cc: El-Haj-Mahmoud, Samer; Shifflett, Joseph Subject: Re: [edk2] [PATCH]

Re: [edk2] [Patch 1/3] MdePkg: Add the missing module UNI files

2015-08-27 Thread Qiu, Shumin
Reviewed-by: Qiu Shumin shumin@intel.com -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Liming Gao Sent: Thursday, August 27, 2015 3:53 PM To: edk2-devel@lists.01.org Subject: [edk2] [Patch 1/3] MdePkg: Add the missing module UNI files

Re: [edk2] [Patch] DisplayEngineDxe: Fixed calculate help string page count error.

2015-08-27 Thread Gao, Liming
Reviewed-by: Liming Gao liming@intel.com -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Eric Dong Sent: Friday, August 28, 2015 10:45 AM To: edk2-devel@lists.01.org Cc: Gao, Liming Subject: [edk2] [Patch] DisplayEngineDxe: Fixed calculate

[edk2] [PATCH v3 1/2] MdePkg: Modify string expression of Wi-Fi device path to follow UEFI spec

2015-08-27 Thread Hao Wu
According to UEFI 2.5 spec, the string expression of a Wi-Fi device node should be displayed as: Wi-Fi(SSID). However, current code displays it as: WiFi(SSID). Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Hao Wu hao.a...@intel.com ---

[edk2] [PATCH v3 0/2] Wi-Fi device path node/text conversion

2015-08-27 Thread Hao Wu
Changes between v2: 1. Fix incorrect data length to copy for CopyMem() function. 2. If the length of the string passed into DevPathFromTextWiFi() is greater than 32, the string will be cut to fit into the size of the SSID field of a Wi-Fi device path node. Hao Wu (2): MdePkg: Modify

[edk2] [PATCH v3 2/2] MdePkg UefiDevicePathLib: Fix possible memory read/write cross boundary

2015-08-27 Thread Hao Wu
The SSID field of a Wi-Fi device path node may not contain a NULL termination. Additonal handle is added to make sure no cross-boundary memory read/write will occur. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Hao Wu hao.a...@intel.com ---

Re: [edk2] [Patch 2/3] MdeModulePkg: Add the missing module UNI files.

2015-08-27 Thread Tian, Feng
Reviewed-by: Feng Tian feng.t...@intel.com -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Liming Gao Sent: Thursday, August 27, 2015 3:53 PM To: edk2-devel@lists.01.org Subject: [edk2] [Patch 2/3] MdeModulePkg: Add the missing module UNI files.

Re: [edk2] [Patch] NetworkPkg: Add Dns and HttpUtilities driver UNI files

2015-08-27 Thread Fu, Siyuan
Reviewed-by: Fu Siyuan siyuan...@intel.com From: Wu, Jiaxin Sent: Thursday, August 27, 2015 11:49 AM To: Fu, Siyuan siyuan...@intel.com; edk2-devel@lists.01.org Cc: Ye, Ting ting...@intel.com Subject: RE: [edk2] [Patch] NetworkPkg: Add Dns and HttpUtilities driver UNI files Thanks, I will

Re: [edk2] [PATCH] OvmfPkg: Build HTTP utilities driver

2015-08-27 Thread Gary Ching-Pang Lin
On Thu, Aug 27, 2015 at 12:54:13PM +0200, Laszlo Ersek wrote: Gary, On 08/27/15 05:41, Gary Ching-Pang Lin wrote: The HTTP driver now needs the HTTP utilities driver to parse the headers of HTTP requests. Can you point out the SVN rev / git commit that makes this necessary? I'd like to

Re: [edk2] [PATCH 11/15] OvmfPkg: Link separated VarCheckUefiLib NULL class library instance

2015-08-27 Thread Zeng, Star
On 2015/8/26 18:57, Laszlo Ersek wrote: On 08/26/15 12:27, Laszlo Ersek wrote: Star, On 08/17/15 10:24, Star Zeng wrote: Cc: Jordan Justen jordan.l.jus...@intel.com Cc: Laszlo Ersek ler...@redhat.com Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Star Zeng

Re: [edk2] [PATCH] MdePkg: Refine the device path text format for Bluetooth to follow spec.

2015-08-27 Thread Gao, Liming
Reviewed-by: Liming Gao liming@intel.com -Original Message- From: Qiu, Shumin Sent: Friday, August 28, 2015 10:35 AM To: edk2-devel@lists.01.org Cc: Qiu, Shumin; Gao, Liming Subject: [PATCH] MdePkg: Refine the device path text format for Bluetooth to follow spec. Cc: Liming Gao

[edk2] [Patch] DisplayEngineDxe: Fixed calculate help string page count error.

2015-08-27 Thread Eric Dong
Current logic has a corner case when a string has extra 1 line for the pages of help string. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Eric Dong eric.d...@intel.com Cc: Liming Gao liming@intel.com --- MdeModulePkg/Universal/DisplayEngineDxe/FormDisplay.c | 2 +-

Re: [edk2] [Patch] MdePkg: Change the EFI_ACPI_PNP_HID_END to EFI_PNP_ID (0x0000)

2015-08-27 Thread Gao, Liming
Reviewed-by: Liming Gao liming@intel.com -Original Message- From: Ni, Ruiyu Sent: Thursday, August 27, 2015 4:54 PM To: edk2-devel@lists.01.org Cc: Ni, Ruiyu; Gao, Liming Subject: [Patch] MdePkg: Change the EFI_ACPI_PNP_HID_END to EFI_PNP_ID (0x) The current value doesn't follow

Re: [edk2] [PATCH v3 0/2] Wi-Fi device path node/text conversion

2015-08-27 Thread Tian, Feng
Series Reviewed-By: Feng Tian feng.t...@intel.com -Original Message- From: Wu, Hao A Sent: Friday, August 28, 2015 11:49 AM To: edk2-devel@lists.01.org; Tian, Feng; Gao, Liming Cc: Wu, Hao A Subject: [PATCH v3 0/2] Wi-Fi device path node/text conversion Changes between v2: 1. Fix

Re: [edk2] Question about memory reservation from PrePi to DXE

2015-08-27 Thread Laszlo Ersek
On 08/26/15 22:49, Benjamin Herrenschmidt wrote: On Wed, 2015-08-26 at 15:31 +, Gao, Liming wrote: Ben: CoreInitializeMemoryServices() API tries to find the highest free memory range to initialize the DXE core. MINIMUM_INITIAL_MEMORY_SIZE specifies the minimum memory size. It first

[edk2] [PATCH] MdePkg: Modify string expression of Wi-Fi device path to follow UEFI spec

2015-08-27 Thread Hao Wu
According to UEFI 2.5 spec, the string expression of a Wi-Fi device node should be displayed as: Wi-Fi(SSID). However, current code displays it as: WiFi(SSID). Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Hao Wu hao.a...@intel.com ---

Re: [edk2] [PATCH] MdePkg: Modify string expression of Wi-Fi device path to follow UEFI spec

2015-08-27 Thread Tian, Feng
Reviewed-by: Feng Tian feng.t...@intel.com -Original Message- From: Wu, Hao A Sent: Thursday, August 27, 2015 14:13 To: edk2-devel@lists.01.org; Tian, Feng; Gao, Liming Cc: Wu, Hao A Subject: [PATCH] MdePkg: Modify string expression of Wi-Fi device path to follow UEFI spec According to

Re: [edk2] [PATCH] OvmfPkg: Build HTTP utilities driver

2015-08-27 Thread Laszlo Ersek
Gary, On 08/27/15 05:41, Gary Ching-Pang Lin wrote: The HTTP driver now needs the HTTP utilities driver to parse the headers of HTTP requests. Can you point out the SVN rev / git commit that makes this necessary? I'd like to reference that patch in this commit message. You don't need to

[edk2] [Patch 0/3] Add the missing module UNI files

2015-08-27 Thread Liming Gao
Liming Gao (3): MdePkg: Add the missing module UNI files MdeModulePkg: Add the missing module UNI files. IntelFrameworkModulePkg: Ad the missing module UNI files. .../LegacyBootMaintUiLib/LegacyBootMaintUiLib.inf| 1 + .../LegacyBootMaintUiLib/LegacyBootMaintUiLib.uni|

[edk2] [Patch] UefiCpuPkg/CpuMpPei: Save the new BSP number in SwitchBsp()

2015-08-27 Thread Jeff Fan
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jeff Fan jeff@intel.com CC: Feng Tian feng.t...@intel.com --- UefiCpuPkg/CpuMpPei/PeiMpServices.c | 4 1 file changed, 4 insertions(+) diff --git a/UefiCpuPkg/CpuMpPei/PeiMpServices.c

[edk2] [PATCH] SecurityPkg: Use safe string function.

2015-08-27 Thread Qiu Shumin
Cc: Yao Jiewen jiewen@intel.com Cc: Chao Zhang chao.b.zh...@intel.com Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Qiu Shumin shumin@intel.com --- SecurityPkg/Tcg/Tcg2Config/Tcg2ConfigImpl.c | 52 ++--- 1 file changed, 26 insertions(+), 26

[edk2] [Patch 3/3] IntelFrameworkModulePkg: Ad the missing module UNI files.

2015-08-27 Thread Liming Gao
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Liming Gao liming@intel.com --- .../LegacyBootMaintUiLib/LegacyBootMaintUiLib.inf| 1 + .../LegacyBootMaintUiLib/LegacyBootMaintUiLib.uni| Bin 0 - 1800 bytes

[edk2] [Patch 2/3] MdeModulePkg: Add the missing module UNI files.

2015-08-27 Thread Liming Gao
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Liming Gao liming@intel.com --- MdeModulePkg/Application/UiApp/UiApp.inf | 6 +- MdeModulePkg/Application/UiApp/UiApp.uni | Bin 0 - 1616 bytes MdeModulePkg/Application/UiApp/UiAppExtra.uni |

[edk2] [Patch 1/3] MdePkg: Add the missing module UNI files

2015-08-27 Thread Liming Gao
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Liming Gao liming@intel.com --- MdePkg/Library/UefiFileHandleLib/UefiFileHandleLib.inf | 1 + MdePkg/Library/UefiFileHandleLib/UefiFileHandleLib.uni | Bin 0 - 1942 bytes 2 files changed, 1 insertion(+) create mode

[edk2] [Patch] MdePkg: Change the EFI_ACPI_PNP_HID_END to EFI_PNP_ID (0x0000)

2015-08-27 Thread Ruiyu Ni
The current value doesn't follow the PI 1.4 spec. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ruiyu Ni ruiyu...@intel.com Cc: Liming Gao liming@intel.com --- MdePkg/Include/Ppi/SuperIo.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[edk2] [PATCH v2] MdePkg: Modify string expression of BMC device path to follow UEFI spec

2015-08-27 Thread Hao Wu
Version 1 of the patch misses to make change in DevicePathFromText.c. Hao Wu (1): MdePkg: Modify string expression of BMC device path to follow UEFI spec MdePkg/Library/UefiDevicePathLib/DevicePathFromText.c | 2 +- MdePkg/Library/UefiDevicePathLib/DevicePathToText.c | 2 +- 2 files

[edk2] [PATCH v2] MdePkg: Modify string expression of BMC device path to follow UEFI spec

2015-08-27 Thread Hao Wu
According to UEFI 2.5 spec, the string expression of a BMC device node should be displayed as: BMC(Type,Address). However, current code displays it as: Bmc(Type,Address). Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Hao Wu hao.a...@intel.com ---

[edk2] [PATCH v2 2/2] MdePkg UefiDevicePathLib: Fix possible memory read/write cross boundary

2015-08-27 Thread Hao Wu
The SSID field of a Wi-Fi device path node may not contain a NULL termination. Additonal handle is added to make sure no cross-boundary memory read/write will occur. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Hao Wu hao.a...@intel.com ---

[edk2] [PATCH v2 1/2] MdePkg: Modify string expression of Wi-Fi device path to follow UEFI spec

2015-08-27 Thread Hao Wu
According to UEFI 2.5 spec, the string expression of a Wi-Fi device node should be displayed as: Wi-Fi(SSID). However, current code displays it as: WiFi(SSID). Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Hao Wu hao.a...@intel.com ---

Re: [edk2] [PATCH v2] MdePkg: Modify string expression of BMC device path to follow UEFI spec

2015-08-27 Thread Tian, Feng
Reviewed-by: Feng Tian feng.t...@intel.com -Original Message- From: Wu, Hao A Sent: Thursday, August 27, 2015 8:15 PM To: edk2-devel@lists.01.org; Tian, Feng; Gao, Liming Cc: Wu, Hao A Subject: [PATCH v2] MdePkg: Modify string expression of BMC device path to follow UEFI spec According