Re: [edk2] [Patch 1/2] MdeModulePkg: Add PciSioSerialDxe driver

Mike, Please check the updated PciSioSerialDxe driver and verify whether it can replace the Quark version UART driver. Several changes were made: 1. Change the PCD structure layout 2. Change the SerialPortReadRegister function name to avoid linking error when using DebugLibSerialPort 3. Support

[edk2] [Patch] MdePkg: Add Ipmi2.0 definitions head file.

Add Ipmi2.0 definitions head file based on Ipmi category: App, Storage and etc. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Daocheng Bu CC: Jiewen Yao --- MdePkg/Include/IndustryStandard/Ipmi.h | 29 +

Re: [edk2] [PATCH v2 0/4] Add BlockIO2 support for UFS

Looks good to me Reviewed-by: Feng Tian -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Hao Wu Sent: Thursday, December 3, 2015 3:41 PM To: edk2-devel@lists.01.org; Tian, Feng Cc: Wu, Hao A Subject: [edk2] [PATCH v2 0/4] Add

Re: [edk2] [PATCH V2 1/2] SecurityPkg: AuthVariableLib: Customized SecureBoot Mode transition. Implement Customized SecureBoot Mode transition logic according to Mantis 1263, including AuditMode/Deplo

Based on this V2 patch about AuthVariableLib update. Seemingly, you have forgotten partial of previous 2) and 5) comments. 2. Remove IsPkExist fields from SECURE_BOOT_MODE structure since only any place to use them. 5. Suggest to update EFI_SECURE_MODE_NAME and gEfiSecureBootModeGuid to like

[edk2] [PATCH] CryptoPkg: remove global variable 'timeval' from OpenSslSupport.h

The header file OpenSslSupport.h not only defines a type 'struct timeval' but also defines a global variable 'timeval' of that type. The RVCT compiler does not merge this definition into a common symbol, resulting in duplicate definition errors in the final link. So remove the variable definition.

Re: [edk2] [PATCH 3/4] CryptoPkg/OpensslLib: comment out unused code

On 3 December 2015 at 12:44, David Woodhouse wrote: > On Thu, 2015-12-03 at 12:32 +0100, Ard Biesheuvel wrote: >> >> >> ... or maybe not (I hit send too soon) >> >> It does not appear that there are any tests for those #defines >> anywhere, and the pqueue and ts_* source

[edk2] [PATCH] BaseTools GCC: avoid the use of COMMON symbols

The default behavior of the GCC compiler is to emit uninitialized globals into a COMMON section, where duplicate definitions are merged. This may result in unexpected behavior, since global variables appearing by the same name in different C files typically do not refer to the same conceptual data

Re: [edk2] [PATCH 3/4] CryptoPkg/OpensslLib: comment out unused code

On 3 December 2015 at 12:19, David Woodhouse wrote: > On Thu, 2015-12-03 at 11:50 +0100, Ard Biesheuvel wrote: >> This comments out the pqueue and ts_* source files from the >> OpensslLib build, since they have no users. > > These are going to be auto-generated from the

Re: [edk2] [PATCH] MdeModulePkg: allow DxeIpl to load without permanent memory to enable S3 resume from temporary memory

On 12/03/15 02:01, Zeng, Star wrote: > On 2015/12/3 2:58, Cohen, Eugene wrote: >> Star, >> >>> Do you have the patch tested on your real platforms (with and without >>> InstallPeiMemory()? >> >> Yes, we've been running this way for a couple years. I had it on my >> list of changes to upstream and

Re: [edk2] [PATCH 3/4] CryptoPkg/OpensslLib: comment out unused code

On Thu, 2015-12-03 at 12:32 +0100, Ard Biesheuvel wrote: > > > ... or maybe not (I hit send too soon) > > It does not appear that there are any tests for those #defines > anywhere, and the pqueue and ts_* source files are built > unconditionally by the standard Makefiles. That might be OK. I

Re: [edk2] [PATCH 2/2] ArmVirtPkg: Add memory space for the memory nodes except the lowest one

On 3 December 2015 at 12:52, Laszlo Ersek wrote: > Ard, > > On 11/30/15 18:48, Laszlo Ersek wrote: >> On 11/30/15 12:48, Ard Biesheuvel wrote: >>> On 30 November 2015 at 12:09, Laszlo Ersek wrote: On 11/30/15 11:03, Ard Biesheuvel wrote: >>> [...] >

Re: [edk2] [PATCH 3/4] CryptoPkg/OpensslLib: comment out unused code

On 3 December 2015 at 13:46, David Woodhouse wrote: > On Thu, 2015-12-03 at 13:13 +0100, Ard Biesheuvel wrote: >> >> OK, then I think we're good. I can still build my secure boot enabled >> platform with those files removed from OpensslLib, so they are not >> used. And in

Re: [edk2] [PATCH 3/4] CryptoPkg/OpensslLib: comment out unused code

On Thu, 2015-12-03 at 11:50 +0100, Ard Biesheuvel wrote: > This comments out the pqueue and ts_* source files from the > OpensslLib build, since they have no users. These are going to be auto-generated from the OpenSSL build system (see the process_files.sh script in the patches I've been

Re: [edk2] [PATCH 4/4] CryptoPkg/OpensslLib: ignore more false positive warnings for RVCT

On Thu, 2015-12-03 at 11:50 +0100, Ard Biesheuvel wrote: > The RVCT compiler chokes on a couple of issues in upstream OpenSSL > that > can be confirmed to be non-issues by inspection. So just ignore these > warnings entirely. I still maintain this needs a reference to bug reports — either

Re: [edk2] [PATCH 2/4] CryptoPkg/BaseCryptLib: make mVirtualAddressChangeEvent STATIC

On 3 December 2015 at 11:50, Ard Biesheuvel wrote: > Make mVirtualAddressChangeEvent STATIC to prevent it from conflicting > with other variables of the same name that may be defined in other > libraries (e.g., MdeModulePkg/Universal/Variable/RuntimeDxe) > >

Re: [edk2] [Patch 6/6] OvmfPkg: Fix VS2015 warning C4459 in XenBusDxe

On 12/03/15 06:26, Liming Gao wrote: > warning C4459: declaration of 'xs' hides global declaration. > Update code to rename local variable xs to xsp to be different. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Liming Gao > Cc: Justen Jordan

Re: [edk2] [PATCH 4/4] CryptoPkg/OpensslLib: ignore more false positive warnings for RVCT

On 3 December 2015 at 12:17, David Woodhouse wrote: > On Thu, 2015-12-03 at 11:50 +0100, Ard Biesheuvel wrote: >> The RVCT compiler chokes on a couple of issues in upstream OpenSSL >> that >> can be confirmed to be non-issues by inspection. So just ignore these >> warnings

Re: [edk2] [PATCH 3/4] CryptoPkg/OpensslLib: comment out unused code

On 3 December 2015 at 12:29, Ard Biesheuvel wrote: > On 3 December 2015 at 12:19, David Woodhouse wrote: >> On Thu, 2015-12-03 at 11:50 +0100, Ard Biesheuvel wrote: >>> This comments out the pqueue and ts_* source files from the >>> OpensslLib

Re: [edk2] [PATCH 2/2] ArmVirtPkg: Add memory space for the memory nodes except the lowest one

Ard, On 11/30/15 18:48, Laszlo Ersek wrote: > On 11/30/15 12:48, Ard Biesheuvel wrote: >> On 30 November 2015 at 12:09, Laszlo Ersek wrote: >>> On 11/30/15 11:03, Ard Biesheuvel wrote: >> [...] Couldn't we simply add EFI_RESOURCE_SYSTEM_MEMORY resource descriptor

Re: [edk2] [PATCH 3/4] CryptoPkg/OpensslLib: comment out unused code

On Thu, 2015-12-03 at 13:13 +0100, Ard Biesheuvel wrote: > > OK, then I think we're good. I can still build my secure boot enabled > platform with those files removed from OpensslLib, so they are not > used. And in fact, the timestamp related functions are duplicated in > BaseCryptLib anyway,

Re: [edk2] [PATCH] ShellPkg: Refine the code to reduce time cost of 'map -r'

On 12/03/15 06:35, Qiu Shumin wrote: > In some platform 'map -r' may cost more than 1 min. This patch filter the > target handles by > BlockIO and SimpleFileSystem protocol to reduce the time cost. Hijacking this thread and asking a more general question -- I noticed recently that the "devices"

Re: [edk2] [PATCH 0/5] coding style/whitespace/cast fixes for RVCT

On 2 December 2015 at 18:02, Ard Biesheuvel wrote: > This fixes a couple of coding style and white space issues and missing casts > that > the RVCT warns about, which means they are breaking the build in > warnings-as-errors > mode. > I have dropped patch #4 (against

Re: [edk2] [PATCH 3/5] SecurityPkg: put missing empty lines at the end of some header files

On 2 December 2015 at 18:02, Ard Biesheuvel wrote: > Some compilers (like RVCT) reject input files that do not end in a > newline. So add missing newlines to some SecurityPkg header files. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Ard

[edk2] [Patch] Vlv2DeviceRefCodePkg/Vlv2TbltDevicePkg: Reset BIOS Setup when Jumper is present on Turbot.

Signed-off-by: lushifex --- .../SouthCluster/Include/Library/PchPlatformLib.h | 9 ++ Vlv2TbltDevicePkg/AcpiPlatform/AcpiPlatform.c | 19 ++-- .../MultiPlatformLib/BoardClkGens/BoardClkGens.c | 6 +- .../MultiPlatformLib/BoardClkGens/BoardClkGens.h | 2 +

Re: [edk2] [PATCH 4/5] ShellPkg: add missing SHELL_STATUS cast

On 3 December 2015 at 02:01, Qiu, Shumin wrote: > Hi Ard, > If Status is not EFI_SUCCESS we cannot do the explicit cast. Please help to > check the definition of SHELL_STATUS and EFI_STATUS. OK, i was not aware of that. I assumed it was similar to

Re: [edk2] [PATCH 3/5] SecurityPkg: put missing empty lines at the end of some header files

Ard: It is good to me. Reviewed-by: Chao Zhang Thanks & Best regards Chao Zhang -Original Message- From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] Sent: Thursday, December 03, 2015 4:38 PM To: edk2-devel@lists.01.org; Zhang, Chao B Cc: Gao, Liming

[edk2] [PATCH 3/4] CryptoPkg/OpensslLib: comment out unused code

This comments out the pqueue and ts_* source files from the OpensslLib build, since they have no users. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel --- CryptoPkg/Library/OpensslLib/OpensslLib.inf | 24 ++-- 1

[edk2] [PATCH 2/4] CryptoPkg/BaseCryptLib: make mVirtualAddressChangeEvent STATIC

Make mVirtualAddressChangeEvent STATIC to prevent it from conflicting with other variables of the same name that may be defined in other libraries (e.g., MdeModulePkg/Universal/Variable/RuntimeDxe) Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel

[edk2] [PATCH 0/4] CryptoPkg: fix ARM and RVCT issues

These fixes some minor issues in CryptoPkg that prevent CryptoPkg.dsc and OpensslLib from being built for ARM in general, and using RVCT in particular. Note that I sent out a separate single patch that touches CryptoPkg as well, before I realized that there were more issues to address. This

[edk2] [PATCH 1/4] CryptoPkg ARM: add ArmSoftFloatLib resolution to CryptoPkg.dsc

In order to build the ARM version of CryptoPkg from its own .DSC file, it needs a resolution for the ArmSoftFloatLib dependency of OpensslLib. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel --- CryptoPkg/CryptoPkg.dsc | 3 +++ 1

[edk2] [PATCH 4/4] CryptoPkg/OpensslLib: ignore more false positive warnings for RVCT

The RVCT compiler chokes on a couple of issues in upstream OpenSSL that can be confirmed to be non-issues by inspection. So just ignore these warnings entirely. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel ---

[edk2] HOB build/get and size changing

I have a strange issue with a block of code that is causing an ASSERT. I call BuildGuidDataHob() with a size of 4, and somehow it is changing to 8. When I add code after BuildGuidDataHob() to get the HOB and output the size, I see size of 8 as returned by GET_GUID_HOB_DATA_SIZE() macro. I have

Re: [edk2] HOB build/get and size changing

Lee: Per PI spec Volume 3 4.5.2 HOB Construction Rules, all HOBs must be multiples of 8 bytes in length. PEI CreateHob() service will adjust HOB length to meet this requirement. So, you find the hob data size becomes to 8 from 4. Thanks Liming -Original Message- From: edk2-devel

Re: [edk2] [PATCH 4/4] CryptoPkg/OpensslLib: ignore more false positive warnings for RVCT

On 3 December 2015 at 12:26, Ard Biesheuvel wrote: > On 3 December 2015 at 12:17, David Woodhouse wrote: >> On Thu, 2015-12-03 at 11:50 +0100, Ard Biesheuvel wrote: >>> The RVCT compiler chokes on a couple of issues in upstream OpenSSL >>> that >>>

[edk2] [Patch 3/3] UefiCpuPkg/MtrrLib: Add MtrrSetMemoryAttributeInMtrrSettings()

Add new API MtrrSetMemoryAttributeInMtrrSettings() in MtrrLib. Platform could use this API to set MTRR setting into local MTRR settings buffer instead of MTRRs. At last, platform could use MtrrSetAllMtrrs() to set the MTRR settings into MTRRs totally. It could improve MTRRs programming performance

[edk2] [Patch 8/8] UefiCpuPkg/MtrrLib: Print MTRR settings when set fixed/variable MTRRs

Cc: Feng Tian Cc: Michael Kinney Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jeff Fan --- UefiCpuPkg/Library/MtrrLib/MtrrLib.c | 6 ++ 1 file changed, 6 insertions(+) diff --git

[edk2] [Patch 5/8] UefiCpuPkg/MtrrLib: Add MtrrGetMemoryAttributeInVariableMtrrWorker ()

Add function to shadow the content of variable MTRRs into an internal array: VariableMtrr. And used MtrrGetMemoryAttributeInVariableMtrrWorker() in other functions. Cc: Feng Tian Cc: Michael Kinney Contributed-under: TianoCore Contribution

[edk2] [Patch 6/8] UefiCpuPkg/MtrrLib: Reduce hardware init when program fixed MTRRs

When MtrrSetMemoryAttribute() programs fixed MTRRs, it may disable/enable cache and disable/enable MTRRs several times. This updating tries to do operation in local variable and does the hardware initialization one time only. Cc: Feng Tian Cc: Michael Kinney

[edk2] [Patch 4/8] UefiCpuPkg/MtrrLib: Make use of worker functions to get MTRRs count

Try to make use of worker functions to get MTRRs count. It could avoid invoking IsMtrrSupported() for many times. Cc: Feng Tian Cc: Michael Kinney Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jeff Fan

[edk2] [Patch 2/3] UefiCpuPkg/MtrrLib: Add MtrrDebugPrintAllMtrrsWorker()

MtrrDebugPrintAllMtrrsWorker() provides the capability to dump the MTRR setting from MTRRs or the input MTRR settings buffer. Cc: Feng Tian Cc: Michael Kinney Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jeff Fan

[edk2] [Patch 0/8] Reduce hardware operations when program MTRR

Try to avoid access hardware when program MTRR. It could improve the performance of MTRR programming. Jeff Fan (8): UefiCpuPkg/MtrrLib: Fix some typo and clean up code format UefiCpuPkg/MtrrLib: Add worker functions not invoke IsMtrrSupported() UefiCpuPkg/MtrrLib: Adjust functions order

[edk2] [Patch 1/3] UefiCpuPkg/MtrrLib: Add worker functions to access MTRRs or variable

Add worker functions that could access MTRRs or MTRR settings in input buffer. Cc: Feng Tian Cc: Michael Kinney Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jeff Fan ---

[edk2] [Patch 0/3] Add MtrrSetMemoryAttributeInMtrrSettings()

Add new API MtrrSetMemoryAttributeInMtrrSettings() in MtrrLib. Platform could use this API to set MTRR setting into local MTRR settings buffer instead of MTRRs. At last, platform could use MtrrSetAllMtrrs() to set the MTRR settings into MTRRs totally. It could improve MTRRs programming performance

[edk2] [Patch 7/8] UefiCpuPkg/MtrrLib: Reduce hardware init when program variable MTRRs

When MtrrSetMemoryAttribute() programs variable MTRRs, it may disable/enable cache and disable/enable MTRRs several times. This updating tries to do operation in local variable and does the hardware initialization one time only. Cc: Feng Tian Cc: Michael Kinney

[edk2] [Patch 3/8] UefiCpuPkg/MtrrLib: Adjust functions order

Only adjust functions order and there is no any real functionality impact. Cc: Feng Tian Cc: Michael Kinney Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jeff Fan ---

Re: [edk2] GICv3 support

On 1 December 2015 at 19:39, Supreeth Venkatesh wrote: > Meenakshi, > > Are you using any EL3 firmware with GICv3 support in it? > Is "PcdArmGicV3WithV2Legacy" being used? > Is the ARM Architectural Timer working for you? (If this works, keyboard > input work fine.) >

[edk2] [PATCH 0/3] remove v2 override for GICv3

After I spotted Supreeth's message to edk2-devel regarding a bug in the GICv3 distributor enable code, I figured that /that/ was the reason we were running the GIC in v2 mode, and not that it is not correctly enabled by the ARM trusted firmware. So apply the fix, and remove the legacy v2 override

[edk2] [PATCH 3/3] ArmPkg/ArmGic: remove GICv3 legacy override

The need for a v2 legacy override to drive a GICv3 in v2 mode is no longer necessary, now that the code that enabled the GIC distributor no longer inadvertently kicks a v2 capable GICv3 into v2 mode. So remove the PCD and all references to it. Contributed-under: TianoCore Contribution Agreement

[edk2] [Patch 1/8] UefiCpuPkg/MtrrLib: Fix some typo and clean up code format

Fixed some typo. Removed some trailing spaces and TAB key. Clean up code format. Cc: Feng Tian Cc: Michael Kinney Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jeff Fan ---

[edk2] [Patch 2/8] UefiCpuPkg/MtrrLib: Add worker functions not invoke IsMtrrSupported()

Abstract some worker functions not to invoke IsMtrrSupported(). They could be used by other functions to reduce the number of invoking times on IsMtrrSupported(). Cc: Feng Tian Cc: Michael Kinney Contributed-under: TianoCore Contribution

[edk2] [Patch] UefiCpuPkg/MtrrLib: Add PCD PcdCpuNumberOfReservedVariableMtrrs

Current MtrrLib reserves 2 variable MTRRs for some legacy OS boot (CSM boots) may require some MTRRs to be reserved for OS use. But UEFI OS boot will not use MTRRs. Per Scott's suggestion in link: http://article.gmane.org/gmane.comp.bios.edk2.devel/4099 Add one PCD

Re: [edk2] [PATCH v2 2/2] ArmVirtPkg: Add memory space for the memory nodes except the lowest one

Shannon, On 12/01/15 03:02, Shannon Zhao wrote: > > On 2015/12/1 2:12, Laszlo Ersek wrote: >> Thank you -- this looks better. Unfortunately the >> SetMemorySpaceAttributes() question still has to be addressed, and we're >> still discussing with Ard which way to go about that. Once we have an >>

[edk2] [PATCH 1/3] ArmPkg/ArmGic: fix bug in GICv3 distributor configuration

In the function ArmGicEnableDistributor (), the Affinity Routing Enable (ARE) bit, which essentially defines whether the GIC runs in v2 or v3 mode, is inadvertently cleared when enabling the GIC distributor if it is running in v3 mode. So fix that. Reported-by: Supreeth Venkatesh

Re: [edk2] [PATCH] ShellPkg: Refine the code to reduce time cost of 'map -r'

> -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Thursday, December 03, 2015 3:26 AM > To: Qiu, Shumin ; edk2-de...@ml01.01.org > Cc: Carsey, Jaben > Subject: Re: [edk2] [PATCH] ShellPkg: Refine the code to reduce

Re: [edk2] [PATCH] ShellPkg: Refine the code to reduce time cost of 'map -r'

On 12/03/15 18:04, Carsey, Jaben wrote: > > >> -Original Message- >> From: Laszlo Ersek [mailto:ler...@redhat.com] >> Sent: Thursday, December 03, 2015 3:26 AM >> To: Qiu, Shumin ; edk2-de...@ml01.01.org >> Cc: Carsey, Jaben >> Subject: Re:

Re: [edk2] [PATCH 3/3] ArmPkg/ArmGic: remove GICv3 legacy override

Thanks Ard for getting this in. Supreeth -Original Message- From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] Sent: Thursday, December 03, 2015 7:59 AM To: edk2-devel@lists.01.org; leif.lindh...@linaro.org; Supreeth Venkatesh Cc: Ard Biesheuvel Subject: [PATCH 3/3] ArmPkg/ArmGic:

Re: [edk2] [PATCH] ShellPkg: Refine the code to reduce time cost of 'map -r'

On 12/03/15 18:03, Carsey, Jaben wrote: > Shumin, > > Could we loop over a list of handles made by > 1) LocateHandleBuffer on BlockIO > 2) LocateHandleBuffer on SimpleFileSystem > 3) Combine these lists (removing duplicates) So this is exactly the use case that I had in mind (regardless of

Re: [edk2] MdeModulePkg: DebugAssert enhancement

Updated code based on your suggestion to use copy mem and ModuleNameSize calculation. diff --git a/MdeModulePkg/Library/PeiDxeDebugLibReportStatusCode/DebugLib.c b/MdeModulePkg/Library/PeiDxeDebugLibReportStatusCode/DebugLib.c index f1d9827..c3010df 100644 ---

Re: [edk2] [PATCH] ShellPkg: Refine the code to reduce time cost of 'map -r'

> -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Thursday, December 03, 2015 9:16 AM > To: Carsey, Jaben ; Qiu, Shumin > ; edk2-de...@ml01.01.org > Subject: Re: [edk2] [PATCH] ShellPkg: Refine the code to reduce

Re: [edk2] [PATCH 0/4] CryptoPkg: fix ARM and RVCT issues

Eugene, As Ard's said, this patch series should cover / supersede your old fixes for RVCT build, which was pended by me. :-) Could you please help to validate them? Since I have no RVCT environment. Best Regards & Thanks, LONG, Qin > -Original Message- > From: Ard Biesheuvel

Re: [edk2] [PATCH] MdeModulePkg: allow DxeIpl to load without permanent memory to enable S3 resume from temporary memory

Eugene -- Personally, I don't see this as a positive change. The PEI flow from the earliest days has said: at the end of PEI there is memory and there is a boot mode (see 11.2.1). You can see this assumption in 2.5 and 9.1 of the PI specification, where the result of the PEI Foundation (not

Re: [edk2] [PATCH 4/4] CryptoPkg/OpensslLib: ignore more false positive warnings for RVCT

On Thu, 2015-12-03 at 15:26 +0100, Ard Biesheuvel wrote: > On 3 December 2015 at 12:26, Ard Biesheuvel wrote: > > On 3 December 2015 at 12:17, David Woodhouse wrote: > > > On Thu, 2015-12-03 at 11:50 +0100, Ard Biesheuvel wrote: > > > > The RVCT compiler chokes on a couple

Re: [edk2] [PATCH] MdeModulePkg: allow DxeIpl to load without permanent memory to enable S3 resume from temporary memory

> I'll admit that I don't fully understand the details and the expected > implications of this change, but: OVMF does install permanent PEI RAM on > the S3 resume path, and it would be nice if that wouldn't break. > > ... If this is a very intrusive change, can it be made dependent on a >

Re: [edk2] [PATCH 4/4] CryptoPkg/OpensslLib: ignore more false positive warnings for RVCT

On 3 December 2015 at 16:02, David Woodhouse wrote: > On Thu, 2015-12-03 at 15:26 +0100, Ard Biesheuvel wrote: >> On 3 December 2015 at 12:26, Ard Biesheuvel wrote: >> > On 3 December 2015 at 12:17, David Woodhouse wrote: >> > > On Thu, 2015-12-03 at

[edk2] [PATCH v2] ArmPkg: update RVCT assembly functions to use new RVCT_ASM_EXPORT macro

This has the effect of splitting assembly functions into their own sections so the linker can remove unused ones to save space. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Eugene Cohen --- .../ArmCpuLib/ArmCortexA9Lib/ArmCortexA9Helper.asm | 5 +-

[edk2] Git transition for EDK2

To: EDK2 Community This message is to notify you that near the end of January 2016 the active repository for EDK2 development will switch from using SourceForge to GitHub. The repository found at SourceForge will continue to be a read-only mirror of the master branch on GitHub. A number of

Re: [edk2] [PATCH 3/3] ArmPkg: update RVCT assembly functions to use new RVCT_ASM_EXPORT macro

Ard, To resume the conversation from before, there are a few files that my script was overly-aggressive in putting into their own section with the use of the macro. These need to be backed out of the patch (I'd appreciate it if you could do update this locally): These have code blocks that

Re: [edk2] [Patch 6/6] OvmfPkg: Fix VS2015 warning C4459 in XenBusDxe

Liming, The source changes look good to me and I have verified that all 3 OVMF DSC files build with VS2015. Acked-by: Michael Kinney Mike > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Liming > Gao >

Re: [edk2] InsertImageRecord and Section Alignment

Thanks for the solution. Any idea why my code was fine before and now it's not (the design change reason, not that tools_def.txt changed)? I'm trying to understand why a change was made that caused the problem. -Original Message- From: Kinney, Michael D Sent: Thursday, December 03,

[edk2] InsertImageRecord and Section Alignment

I recently synced to a newer UDK 2015 and now get this serial output many times for different images: InsertImageRecord - Section Alignment(0x20) is not 4K Image - \ReportStatusCodeRouterRuntimeDxe.pdb Has anyone seen this problem when syncing to UDK 2015? I am

Re: [edk2] [PATCH] MdeModulePkg: allow DxeIpl to load without permanent memory to enable S3 resume from temporary memory

Tim, > Personally, I don't see this as a positive change. The PEI flow from the > earliest days has said: at the end of PEI there is memory and there is a > boot mode (see 11.2.1). You can see this assumption in 2.5 and 9.1 of > the PI specification, where the result of the PEI Foundation (not

Re: [edk2] InsertImageRecord and Section Alignment

Lee, It is a feature from UEFI Specification 2.5 - Section 4.6 - EFI_PROPERTIES_TABLE In order to set the EFI_PROPERTIES_RUNTIME_MEMORY_PROTECTION_NON_EXECUTABLE_PE_DATA bit, runtime drivers need to be built so their PE/COFF code and data sections do not share the same 4KB page. The log

Re: [edk2] [Patch 4/6] MdeModulePkg: Fix VS2015 warning C4311 & C4312 in RegularExpressionDxe

Liming, The source changes look good to me and I have verified that RegularExpressionDxe builds with VS2015. I will let Samer do the review. Acked-by: Michael Kinney Mike > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org]

Re: [edk2] [PATCH v2] ArmPkg: update RVCT assembly functions to use new RVCT_ASM_EXPORT macro

On 3 December 2015 at 20:22, Cohen, Eugene wrote: > This has the effect of splitting assembly functions into their own sections > so the linker can remove unused ones to save space. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Eugene Cohen

Re: [edk2] Where do I find the system table address for an EFI app ?

Thank you Michael - that helped a lot. I will let you know what happens... Shubha Shubha D. ramanishubharam...@gmail.com shubharam...@yahoo.com On Wednesday, December 2, 2015 6:59 PM, "Kinney, Michael D" wrote: Shubha, You can run the dmem command from the

Re: [edk2] [Patch 5/6] CryptoPkg: Disable VS2015 warning C4311 in OpensslLib

Liming, Reviewed-by: Michael Kinney I have also verified that builds of the CryptoPkg complete with VS2015 for IA32 and X64. Thanks, Mike > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Liming > Gao > Sent:

Re: [edk2] [Patch 3/6] MdeModulePkg: Fix VS2015 warning C4456 in RegularExpressionDxe

Liming, The source changes look good to me and I have verified that RegularExpressionDxe builds with VS2015. I will let Samer do the review. Acked-by: Michael Kinney Mike > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On

Re: [edk2] InsertImageRecord and Section Alignment

Lee, You can fix this by adding the following to the DSC file to force modules of type DXE_RUNTIME_DRIVER to use 4KB alignment. [BuildOptions.common.EDKII.DXE_RUNTIME_DRIVER] MSFT:*_*_*_DLINK_FLAGS = /ALIGN:4096 Mike > -Original Message- > From: edk2-devel

Re: [edk2] InsertImageRecord and Section Alignment

On 12/03/15 21:16, Kinney, Michael D wrote: > Lee, > > It is a feature from UEFI Specification 2.5 - Section 4.6 - > EFI_PROPERTIES_TABLE > > In order to set the > EFI_PROPERTIES_RUNTIME_MEMORY_PROTECTION_NON_EXECUTABLE_PE_DATA bit, > runtime drivers need to be built so their PE/COFF code and

Re: [edk2] Git transition for EDK2

On 12/03/15 21:05, Jarlstrom, Laurie wrote: > To: EDK2 Community > > This message is to notify you that near the end of January 2016 the > active repository for EDK2 development will switch from using > SourceForge to GitHub. The repository found at SourceForge will > continue to be a read-only

Re: [edk2] InsertImageRecord and Section Alignment

Laszlo, That is a good question. If a platform requires EFI_PROPERTIES_RUNTIME_MEMORY_PROTECTION_NON_EXECUTABLE_PE_DATA to be set, then it is an error condition. That is why it is an error message and not a warning message. We could consider changing this specific message to a warning, and

Re: [edk2] [PATCH] MdeModulePkg: allow DxeIpl to load without permanent memory to enable S3 resume from temporary memory

You're probably right. I'm very used to catching problems with PEI at that ASSERT() so I hate to see it go. But it could move to some well-defined place in DxeIpl. I think that the language of the PEI spec needs some clean up in this regard. The PEI Core/PEI Foundation/PEI Dispatcher/PEI Phase

Re: [edk2] [Patch 1/2] MdeModulePkg: Add PciSioSerialDxe driver

Hi Ray, I agree a UINT64 Offset would be good for the Offset field. It would also be good to order the fields and pad the structure so they are naturally aligned. Maybe like the following with some comment changes: typedef struct { UINT16 VendorId; ///< Vendor ID to match the PCI

Re: [edk2] [Patch 1/2] MdeModulePkg: Add PciSioSerialDxe driver

Ray, I tried to build this module into a platform, and I am getting function name collisions with BaseSerialPortLib16550 for the symbols: SerialPortReadRegister SerialPortWriteRegister I recommend you change the names of these 2 functions. Mike > -Original Message- >

Re: [edk2] [Patch 4/6] MdeModulePkg: Fix VS2015 warning C4311 & C4312 in RegularExpressionDxe

Looks good: Reviewed-By: Samer El-Haj-Mahmoud -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Kinney, Michael D Sent: Thursday, December 3, 2015 1:07 PM To: Gao, Liming ;

Re: [edk2] Git transition for EDK2

On 2015-12-03 15:41:22, Laszlo Ersek wrote: > On 12/03/15 21:05, Jarlstrom, Laurie wrote: > > To: EDK2 Community > > > > This message is to notify you that near the end of January 2016 the > > active repository for EDK2 development will switch from using > > SourceForge to GitHub. The repository

Re: [edk2] [Patch 2/6] MdeModulePkg: Fix VS2015 warning C4459 in DriverSampleDxe

Liming, Reviewed-by: Michael Kinney I have also verified that builds of the MdeModulePkg/Universal/DriverSampleDxe complete with VS2015 for IA32 and X64. Thanks, Mike > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On

Re: [edk2] [Patch 6/6] OvmfPkg: Fix VS2015 warning C4459 in XenBusDxe

Reviewed-by: Jordan Justen On 2015-12-02 21:26:46, Liming Gao wrote: > warning C4459: declaration of 'xs' hides global declaration. > Update code to rename local variable xs to xsp to be different. > > Contributed-under: TianoCore Contribution Agreement 1.0 >

Re: [edk2] [Patch] Vlv2DeviceRefCodePkg/Vlv2TbltDevicePkg: Reset BIOS Setup when Jumper is present on Turbot.

Reviewed-by: Tim He -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of lushifex Sent: Thursday, December 03, 2015 6:15 PM To: edk2-devel@lists.01.org Subject: [edk2] [Patch] Vlv2DeviceRefCodePkg/Vlv2TbltDevicePkg: Reset BIOS

Re: [edk2] [PATCH v2 2/2] ArmVirtPkg: Add memory space for the memory nodes except the lowest one

On 2015/12/3 21:25, Laszlo Ersek wrote: > Shannon, > > On 12/01/15 03:02, Shannon Zhao wrote: >> > >> > On 2015/12/1 2:12, Laszlo Ersek wrote: >>> >> Thank you -- this looks better. Unfortunately the >>> >> SetMemorySpaceAttributes() question still has to be addressed, and we're >>> >> still

Re: [edk2] Git transition for EDK2

> -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jordan > Justen > Sent: Thursday, December 3, 2015 4:37 PM > To: Laszlo Ersek ; Jarlstrom, Laurie > > Cc: edk2-devel@lists.01.org > Subject: Re:

[edk2] [Patch] ShellPkg: Fix ifconfig hang issue with incomplete parameters

This patch is used to fix ifconfig hang issue with incomplete parameters. In addition, some error related output information is added to increase the interactivity. Cc: Leekha Shaveta Cc: Carsey Jaben Cc: Ye Ting

Re: [edk2] Git transition for EDK2

On 12/3/15 5:37 PM, Jordan Justen wrote: I think some people want to investigate gerrit at some point, and I don't know how that would be implemented. I hope it would not mean that patches will be posted in gerrit, and no notice will appear on the email list. I hope not too, since everyone

Re: [edk2] [Patch] MdePkg: Add Ipmi2.0 definitions head file.

Daocheng: I try including this header file and compile them, and find the following issues. Pease fix them. 1) IndustryStandard/IpmiNetFnSensorDefinitions.h can't be found 2) There are two IPMI_LAN_DEST_TYPE definitions in MdePkg\Include\IndustryStandard\IpmiNetFnTransportDefinitions.h.