[edk2] [PATCH v2] NetworkPkg: Add URI configuration form to HTTP boot driver.

V2: Convert the scheme to lower case before use it. This patch updates the HTTP boot driver to produce a setup page for the boot file URI configuration. A new boot option will be created for the manual configured URI address. This change is made to support the HTTP boot usage in home environment.

Re: [edk2] [PATCH] MdeModulePkg: Fix IPv4 double free

Reviewed-by: Ye Ting -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Samer El-Haj-Mahmoud Sent: Friday, March 04, 2016 11:14 AM To: edk2-devel@lists.01.org Cc: Samer El-Haj-Mahmoud ; Fu, Siyuan ; Tian, Feng ; Zeng, Star Subject: [edk2] [PATCH]

Re: [edk2] [PATCH] MdeModulePkg: Fix IPv4 double free

Reviewed-by: Fu Siyuan > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Samer El-Haj-Mahmoud > Sent: Friday, March 4, 2016 11:14 AM > To: edk2-devel@lists.01.org > Cc: Samer El-Haj-Mahmoud ; Fu, Siyuan > ; Tian, Feng ; Zeng, Star > > Subjec

Re: [edk2] [Patch] MdeModulePkg/PciHostBridge: Don't assert when setting UC to MMIO fails

Reviewed by: jiewen@intel.com -Original Message- From: Ni, Ruiyu Sent: Friday, March 04, 2016 1:04 PM To: edk2-devel@lists.01.org Cc: Ni, Ruiyu; Yao, Jiewen Subject: [Patch] MdeModulePkg/PciHostBridge: Don't assert when setting UC to MMIO fails Failing to set EFI_MEMORY_UC to MMIO a

[edk2] [Patch] MdeModulePkg/PciHostBridge: Don't assert when setting UC to MMIO fails

Failing to set EFI_MEMORY_UC to MMIO aperture is not a fatal error. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ruiyu Ni Cc: Jiewen Yao --- MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridge.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/Mde

Re: [edk2] EDK2 Setup & Configuration Issue

Jim: Yes. GitHub Edk2 project has not included BaseTools Binary. You need to download it from this link https://github.com/tianocore/edk2-BaseTools-win32.git. Or, you download full source code from UDK release http://www.tianocore.org/udk/udk2015/ Thanks Liming From: Jim Slaughter [mailto:

[edk2] [PATCH] ShellPkg: Fix smbiosview decode of PCIe Extended Capabilities

Fix SMBIOSVIEW decode of the HeaderLog fields of the PCIe AER structure . The PCIe 2.1 Base Specification, section 7.10, lists this as 16 bytes, or 4 DWORDs. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Samer El-Haj-Mahmoud --- ShellPkg/Library/UefiShellDebug1CommandsLi

Re: [edk2] EDK2 Setup & Configuration Issue

Hello, I downloaded edk2 again, and its the 2014 stable version.The directory is still not there: Z:\edk2\edk2-master>dir basetools\bin\win32  Volume in drive Z is vxbox  Volume Serial Number is 009A-9A03 Directory of Z:\edk2\edk2-master\basetools\binFile Not FoundZ:\edk2\edk2-master>dir basetoo

Re: [edk2] [PATCH v2] MdePkg: Fix ACPI NFIT GUID definitions

Reviewed by: jiewen@intel.com -Original Message- From: Samer El-Haj-Mahmoud [mailto:samer.el-haj-mahm...@hpe.com] Sent: Friday, March 04, 2016 10:56 AM To: edk2-devel@lists.01.org Cc: Yao, Jiewen; Kinney, Michael D; Gao, Liming; Samer El-Haj-Mahmoud; Samer El-Haj-Mahmoud Subject: [P

Re: [edk2] [PATCH] MdeModulePkg: Add DEBUG and ASSERT on failed BDS entry

Star, It has been a while since I have seen this, so I will need to go back to some old notes to get the details.. But I am pretty sure we didn't see the ASSERT below. The code ended up accessing gBds which was NULL and causing an exception. Let me know if you want me to dig through the details

[edk2] [PATCH] MdeModulePkg: Fix IPv4 double free

Fix a possible ASSERT after NBP finishes loading from a PXE boot. Ip4Dxe driver calls Ip4Config2SetPolicy which calls CloseEvent on the Dhcp4Event struct member. After NBP is downloaded, it then calls Ip4Config2CleanInstance which calls CloseEvent again on Dhcp4Event. This double free can cause a

Re: [edk2] [PATCH v3] MdeModulePkg: Make HII configuration settings available to OS runtime

Reviewed-by: Liming Gao > -Original Message- > From: Bi, Dandan > Sent: Thursday, March 03, 2016 10:18 AM > To: edk2-devel@lists.01.org > Cc: Gao, Liming; Dong, Eric; Brian J. Johnson; Andrew Fish; El-Haj-Mahmoud > Samer > Subject: [PATCH v3] MdeModulePkg: Make HII configuration settings

Re: [edk2] [PATCH v2] MdePkg: Fix CPER GUID definitions to match UEFI spec

Samer: The minor comment. Copyright line in header file has the trailing space. You can run BaseTools\Scripts\PatchCheck.py to check it first. Other part are good. Reviewed-by: Liming Gao Thanks Liming > -Original Message- > From: Samer El-Haj-Mahmoud [mailto:samer.el-haj-mahm...@

[edk2] [PATCH v2] MdePkg: Fix ACPI NFIT GUID definitions

Fix ACPI 6.0 and 6.1 NFIT GUID definitions to avoid GCC compiler error for missing braces. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Samer El-Haj-Mahmoud --- MdePkg/Include/IndustryStandard/Acpi60.h | 18 +- MdePkg/Include/IndustryStandard/Acpi61.h |

Re: [edk2] [PATCH] MdeModulePkg: Add DEBUG and ASSERT on failed BDS entry

Samer, Was your code not asserted at below if BDS ARCH PROTOCOL not installed? // // Assert if the Architectural Protocols are not present. // Status = CoreAllEfiServicesAvailable (); if (EFI_ERROR(Status)) { // // Report Status code that some Architectural Protocols are not p

Re: [edk2] [PATCH v2] SecurityPkg: SecureBootConfigDxe: Enhance the code logic

Reviewed-by: Chao Zhang < chao.b.zh...@intel.com> Thanks & Best regards Chao Zhang -Original Message- From: Bi, Dandan Sent: Wednesday, March 02, 2016 11:39 AM To: edk2-devel@lists.01.org Cc: Zhang, Chao B; Qiu, Shumin; Dong, Eric Subject: [PATCH v2] SecurityPkg: SecureBootConfigDxe

Re: [edk2] [PATCH] MdePkg: Fix ACPI 6.0 NFIT GUID definitions

HI Samer I found ACPI6.1 NFIT GUID has similar issue. Should we fix them altogether? Thank you Yao, Jiewen -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Yao, Jiewen Sent: Friday, March 04, 2016 9:45 AM To: Samer El-Haj-Mahmoud; edk2-devel@lists

Re: [edk2] [PATCH] MdePkg: Fix ACPI 6.0 NFIT GUID definitions

Reviewed-by: jiewen@intel.com -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Samer El-Haj-Mahmoud Sent: Friday, March 04, 2016 9:25 AM To: edk2-devel@lists.01.org Cc: Kinney, Michael D; Samer El-Haj-Mahmoud; Gao, Liming Subject: [edk2] [PATC

[edk2] [PATCH] MdeModulePkg: Add DEBUG and ASSERT on failed BDS entry

Add a DEBUG message and ASSERT if gBds is NULL before entering BDS. This helps in debugging issues with EFI_BDS_ARC_PROTOCOL not getting installed because of bad dependencies. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Samer El-Haj-Mahmoud --- MdeModulePkg/Core/Dxe/Dx

Re: [edk2] [PATCH] MdePkg: Fix GIC definitions to match ACPI 5.1 Errata B

Reviewed by: jiewen@intel.com -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Samer El-Haj-Mahmoud Sent: Friday, March 04, 2016 9:32 AM To: edk2-devel@lists.01.org Cc: Kinney, Michael D; Samer El-Haj-Mahmoud; Gao, Liming Subject: [edk2] [PATCH

[edk2] [PATCH v3] MdeModulePkg: Improved SetupBrowser handling to failed GOTO callback.

On a failed REF_OP callback, all changed fields in the Selection should be restored. Signed-off-by: Cecil Sheng --- MdeModulePkg/Universal/SetupBrowserDxe/Presentation.c | 16 ++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/MdeModulePkg/Universal/SetupBrowserDxe/

Re: [edk2] [PATCH] MdePkg: Add UEFI2.6 HII Image Ex and Image Decoder protocol definition.

Hi Dandan, I've corrected two places in the EFI_HII_IMAGE_DECODER_PROTOCOL. 1. NumberOfDecoderName in GetImageDecoderName() should be a pointer because it's an OUT parameter. 2. the typedef for Decode() are not consistent between the protocol definition and the function definitio

[edk2] [PATCH] MdePkg: Fix GIC definitions to match ACPI 5.1 Errata B

ACPI 5.1a had incorrect definitions for some GIC (ARM interrupt controller) ACPI fields. This has been fixed in ACPI 5.1 Errata B. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Samer El-Haj-Mahmoud Signed-off-by: Joe Shifflett --- MdePkg/Include/IndustryStandard/Acpi51

Re: [edk2] [PATCH] MdePkg: Add missing NFIT NVDIMM definition from ACPI 6.1

Looks good. Reviewed-by: jiewen@intel.com -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Samer El-Haj-Mahmoud Sent: Friday, March 04, 2016 9:21 AM To: edk2-devel@lists.01.org Cc: Kinney, Michael D; Samer El-Haj-Mahmoud; Gao, Liming Subject:

[edk2] [PATCH] MdePkg: Fix ACPI 6.0 NFIT GUID definitions

Fix ACPI 6.0 NFIT GUID definitions to avoid GCC compiler error for missing braces. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Samer El-Haj-Mahmoud --- MdePkg/Include/IndustryStandard/Acpi60.h | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) di

[edk2] [PATCH] MdePkg: Add missing NFIT NVDIMM definition from ACPI 6.1

Add NFIT NVDIMM Control Region definition for Manufacturing as defined in ACPI 6.1 table 5-133. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Samer El-Haj-Mahmoud --- MdePkg/Include/IndustryStandard/Acpi61.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/MdePkg/I

Re: [edk2] BOM in .dec, .dsc, .fdf

That's fine with me. Tim -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Kinney, Michael D Sent: Thursday, March 03, 2016 4:32 PM To: Tim Lewis ; Gao, Liming ; edk2-devel@lists.01.org; Kinney, Michael D Subject: Re: [edk2] BOM in .dec, .dsc, .

[edk2] [PATCH v2] MdePkg: Fix CPER GUID definitions to match UEFI spec

Add gEfiIa32X64ProcessorErrorSectionGuid and gEfiArmProcessorErrorSectionGuid to match the definition in the UEFI 2.6 specification Table 249. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Samer El-Haj-Mahmoud --- MdePkg/Include/Guid/Cper.h | 17 - MdePkg

Re: [edk2] [PATCH v2] NetworkPkg: Support print help information using -? command.

Reviewed-by: Jiaxin Wu > -Original Message- > From: Zhang, Lubo > Sent: Monday, February 29, 2016 2:26 PM > To: edk2-devel@lists.01.org > Cc: Fu, Siyuan ; Ye, Ting ; Wu, > Jiaxin > Subject: [PATCH v2] NetworkPkg: Support print help information using -? > command. > > v2: > *Modify the

Re: [edk2] BOM in .dec, .dsc, .fdf

Tim, I think I would prefer a build error with a good error message if BOM detected. Otherwise, build/boot tests can pass if rest of file is ASCII and we will get files checked in with the BOM. Mike > -Original Message- > From: Tim Lewis [mailto:tim.le...@insyde.com] > Sent: Thursday,

Re: [edk2] [patch] MdeModulePkg/DisplayEngineDxe: Refine the coding style

Reviewed-by: Eric Dong > -Original Message- > From: Bi, Dandan > Sent: Thursday, March 03, 2016 4:54 PM > To: edk2-devel@lists.01.org > Cc: Qiu, Shumin; Dong, Eric > Subject: [patch] MdeModulePkg/DisplayEngineDxe: Refine the coding style > > Remove the empty line to conform with current

Re: [edk2] BOM in .dec, .dsc, .fdf

Liming -- At a minimum, yes. The error message currently does not help the user to identify the problem correctly. Better would be to skip the UTF-8 BOM marker, but complain later if a non-ASCII character shows up. Tim -Original Message- From: Gao, Liming [mailto:liming@intel.com]

[edk2] [PATCH 3/3] ArmPkg: Update CpuDxe to use CpuExceptionHandlerLib

Use the new ARM/AArch64 implementation of the base CpuExceptionHandlerLib library from CpuDxe to centralize exception handling. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Eugene Cohen --- ArmPkg/Drivers/CpuDxe/AArch64/Exception.c| 154 - ArmPkg/Drivers

[edk2] [PATCH 1/3] ArmPkg: Add ArmReadHcr to enable read-modify-write of HCR

Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Eugene Cohen --- ArmPkg/Include/Chipset/AArch64.h | 5 + ArmPkg/Library/ArmLib/AArch64/AArch64Support.S | 6 ++ 2 files changed, 11 insertions(+) diff --git a/ArmPkg/Include/Chipset/AArch64.h b/ArmPkg/In

[edk2] [PATCH 0/3] Implement ARM/AArch64 instance of CpuExceptionHandlerLib

This patch series refactors the exception handling in ArmPkg CpuDxe to a base library implementing the existing CpuExceptionHandlerLib interface. This interface allows for exception handling in any phase of execution so we can get exception handlers in place early for effective debugging. The

[edk2] [PATCH 2/3] ArmPkg: ARM/AArch64 implementation of CpuExceptionHandlerLib

Introduce ARM and AArch64 instances of the CpuExceptionHandlerLib which provides exception handling and registration of handlers regardless of execution phase. Two variants of the ArmExceptionLib are provided: one where exception handlers reside within the module (meeting appropriate architectural

Re: [edk2] [PATCH] ArmPkg: Configure TTBCR register

On Wed, Mar 02, 2016 at 09:08:46PM +, evan.ll...@arm.com wrote: > From: Evan Lloyd > > Architecturally, the TTBCR register value is undefined at reset for > Non-Secure. > On some platforms the reset value for TTBCR is not zero and > this causes a data abort exception once the MMU is enabled.

Re: [edk2] [Patch] ShellPkg: Update 'ifconfig -r' implementation

Reviewed-by: Samer EL-Haj-Mahmoud -Original Message- From: Jiaxin Wu [mailto:jiaxin...@intel.com] Sent: Wednesday, March 2, 2016 2:03 AM To: edk2-devel@lists.01.org Cc: Ye Ting ; Fu Siyuan ; Carsey Jaben ; El-Haj-Mahmoud, Samer ; Subramanian, Sriram (EG Servers Platform SW) Subject:

Re: [edk2] [Patch] MdeModulePkg/PciHostBridgeLib: Correct the function header comments

On 03/03/16 10:47, Ruiyu Ni wrote: > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Ruiyu Ni > Cc: Shumin Qiu > --- > MdeModulePkg/Include/Library/PciHostBridgeLib.h | 4 ++-- > MdeModulePkg/Library/PciHostBridgeLibNull/PciHostBridgeLibNull.c | 7 +++---

Re: [edk2] [PATCH v2 00/15] Port OvmfPkg to MdeModulePkg/Bus/Pci/PciHostBridgeDxe

On 03/03/16 18:08, Jordan Justen wrote: > 3, 5 & 12 > > Reviewed-by: Jordan Justen Fantastic, thank you. Series committed as 014b472053ae..4014885ffdfa. Thanks! Laszlo > > On 2016-03-03 02:15:39, Laszlo Ersek wrote: >> This is version 2 of >>

Re: [edk2] [Patch] ShellPkg: Update 'ifconfig -r' implementation

Reviewed-by: Jaben Carsey > -Original Message- > From: Subramanian, Sriram (EG Servers Platform SW) [mailto:sriram- > s...@hpe.com] > Sent: Wednesday, March 02, 2016 7:13 PM > To: Wu, Jiaxin ; edk2-devel@lists.01.org > Cc: Ye, Ting ; Fu, Siyuan ; Carsey, > Jaben ; El-Haj-Mahmoud, Samer m

Re: [edk2] [PATCH v2 00/15] Port OvmfPkg to MdeModulePkg/Bus/Pci/PciHostBridgeDxe

3, 5 & 12 Reviewed-by: Jordan Justen On 2016-03-03 02:15:39, Laszlo Ersek wrote: > This is version 2 of > . > > In this version, I addressed Jordan's comments for: > > - OvmfPkg: factor the MMIO aperture shared by all PCI root bridges in

Re: [edk2] [PATCH 1/3] ArmPkg: Add GetTimeInNanoSecond() to ArmArchTimerLib

On 3 March 2016 at 15:28, wrote: > From: Sami Mujawar > > FirmwarePerformanceDxe.c utilizes the Timer Library function > GetTimeInNanoSecond() which was not implemented by the ArmArchTimerLib. > > This patch adds this missing functionality. > In the process some common preprocessor code was move

Re: [edk2] AllocatePool and AllocateBuffer

On 03/03/16 16:44, Andrew Fish wrote: > >> On Mar 3, 2016, at 7:25 AM, Ard Biesheuvel wrote: >> >> On 3 March 2016 at 16:16, Ravikanth MVR wrote: >>> Hi Ard, >>> >>> In x86 architectures,we are allocating memory via AllocatePool for DMA >>> transaction and it works fine.But in ARM-AARCH64 archit

Re: [edk2] AllocatePool and AllocateBuffer

> On Mar 3, 2016, at 7:25 AM, Ard Biesheuvel wrote: > > On 3 March 2016 at 16:16, Ravikanth MVR wrote: >> Hi Ard, >> >> In x86 architectures,we are allocating memory via AllocatePool for DMA >> transaction and it works fine.But in ARM-AARCH64 architecture,AllocatePool() >> is not working and w

Re: [edk2] [PATCH 1/3] ArmPkg: Add GetTimeInNanoSecond() to ArmArchTimerLib

From: Sami Mujawar FirmwarePerformanceDxe.c utilizes the Timer Library function GetTimeInNanoSecond() which was not implemented by the ArmArchTimerLib. This patch adds this missing functionality. In the process some common preprocessor code was moved out of MicroSecondDelay(). Code at: https:/

Re: [edk2] AllocatePool and AllocateBuffer

On 3 March 2016 at 16:16, Ravikanth MVR wrote: > Hi Ard, > > In x86 architectures,we are allocating memory via AllocatePool for DMA > transaction and it works fine.But in ARM-AARCH64 architecture,AllocatePool() > is not working and we had to use AllocateBuffer() as per system BIOS > guidelines. >

Re: [edk2] [PATCH 3/3] ArmPkg: Correct typos in ArmArchTimerLib.c.

On 3 March 2016 at 11:55, wrote: > From: Evan Lloyd > > SOme minor typographical problems were noticed during previous commits. Minor typographical problem in commit message :-) > This change corrects those, and contains no functional modifications. > The changes are in comments, and one diag

Re: [edk2] [PATCH 2/3] ArmPkg: Fix unused variable in ArmArchTimerLib

On 3 March 2016 at 11:55, wrote: > From: Sami Mujawar > > The TimerFreq variable in the TimerConstructor() is unused in RELEASE > builds since ASSERTs are then disabled. > The only use of the variable (in the ASSERT) is replaced by a direct > invocation of the function previously used to set it.

Re: [edk2] [PATCH 0/3] Updates to ArmArchTimerLib.c

Hi Evan, On 3 March 2016 at 11:55, wrote: > Code at: https://github.com/EvanLloyd/tianocore/commit/ > From: Sami Mujawar > Date: Fri, 5 Feb 2016 14:42:40 + > Subject: [PATCH 1/3] ArmPkg: Add GetTimeInNanoSecond() to ArmArchTimerLib > > FirmwarePerformanceDxe.c utilizes the Timer Library fun

[edk2] [PATCH 0/2] ArmPlatformPkg: Serial/Uart updates

A number of deficiencies were found in the UART handling when porting to partner platforms. In particular the assumption made in the code was that all UARTs present derived their baud rates from the same clock. These patches correct that for PL011. ___

[edk2] [PATCH 1/2] ArmPlatformPkg: Add support to configure PL011 UART clock

From: Sami Mujawar On some platforms the UART clock is not the same for all the serial ports. The PL011 driver should be reentrant and capable of handling serial ports with different clock rates. This patch allows the UART clock rate to be passed as a parameter to PL011UartInitializePort(), whic

[edk2] [PATCH 2/2] ArmPlatformPkg: Update Serial PCDs to Fixed PCDs

From: Sami Mujawar The PCDs used in the PL011 UART Driver and Serial Port Library are inherently "fixed at build". This change updates the source to use Fixed PCDs for these values. This improves clarity and efficiency. Code at: https://github.com/EvanLloyd/tianocore/commit/926181b32a74c8c02e

[edk2] [PATCH 0/3] Updates to ArmArchTimerLib.c

Code at: https://github.com/EvanLloyd/tianocore/commit/ From: Sami Mujawar Date: Fri, 5 Feb 2016 14:42:40 + Subject: [PATCH 1/3] ArmPkg: Add GetTimeInNanoSecond() to ArmArchTimerLib FirmwarePerformanceDxe.c utilizes the Timer Library function GetTimeInNanoSecond() which was not implemented by

[edk2] [PATCH 2/3] ArmPkg: Fix unused variable in ArmArchTimerLib

From: Sami Mujawar The TimerFreq variable in the TimerConstructor() is unused in RELEASE builds since ASSERTs are then disabled. The only use of the variable (in the ASSERT) is replaced by a direct invocation of the function previously used to set it. NOTE: The build tools suppress warnings of t

[edk2] [PATCH 3/3] ArmPkg: Correct typos in ArmArchTimerLib.c.

From: Evan Lloyd SOme minor typographical problems were noticed during previous commits. This change corrects those, and contains no functional modifications. The changes are in comments, and one diagnostic message. Code at: https://github.com/EvanLloyd/tianocore/commit/6de873f7e3fd63b045adf994

[edk2] [PATCH 0/3] Updates to ArmArchTimerLib.c

A set of changes to ArmPkg/Library/ArmArchTimerLib/ArmArchTimerLib.c These derive from work done for Juno. ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [PATCH] MdeModulePkg AcpiTableDxe: Don't uninstall Acpi Sdt Protocol at ReadyToLock

Reviewed by: jiewen@intel.com -Original Message- From: Zeng, Star Sent: Thursday, March 03, 2016 4:53 PM To: edk2-devel@lists.01.org Cc: Yao, Jiewen; Tian, Feng Subject: [PATCH] MdeModulePkg AcpiTableDxe: Don't uninstall Acpi Sdt Protocol at ReadyToLock 1. The consumer of Acpi Sdt P

Re: [edk2] [Patch] MdeModulePkg/PciHostBridgeLib: Correct the function header comments

Reviewed-by: Qiu Shumin -Original Message- From: Ni, Ruiyu Sent: Thursday, March 03, 2016 5:48 PM To: edk2-devel@lists.01.org Cc: Ni, Ruiyu; Qiu, Shumin Subject: [Patch] MdeModulePkg/PciHostBridgeLib: Correct the function header comments Contributed-under: TianoCore Contribution Agreem

Re: [edk2] [PATCH] EmbeddedPkg: Fix SBSA Generic Watchdog helper

On 03/03/16 11:50, evan.ll...@arm.com wrote: > From: Sami Mujawar This implies that the (primary or original) authorship belongs to Sami, according to git's metadata; but then: > The Reserved field in the SBSA Generic Watchdog Structure is 1 byte in > length. Refer Table 5-123 in the ACPI 5.1 Sp

[edk2] [PATCH] EmbeddedPkg: Fix SBSA Generic Watchdog helper

From: Sami Mujawar The Reserved field in the SBSA Generic Watchdog Structure is 1 byte in length. Refer Table 5-123 in the ACPI 5.1 Specification Errata A. The EFI_ACPI_5_1_SBSA_GENERIC_WATCHDOG_STRUCTURE_INIT() helper macro was initializing this field as EFI_ACPI_RESERVED_WORD instead of EFI_AC

Re: [edk2] [Patch] MdeModulePkg/PciHostBridgeLib: Correct the function header comments

On 03/03/16 10:47, Ruiyu Ni wrote: > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Ruiyu Ni > Cc: Shumin Qiu > --- > MdeModulePkg/Include/Library/PciHostBridgeLib.h | 4 ++-- > MdeModulePkg/Library/PciHostBridgeLibNull/PciHostBridgeLibNull.c | 7 +++---

[edk2] [PATCH v2 07/15] OvmfPkg: PciHostBridgeLib: set RootBus->Segment

This is the first of the patches that set the fields of PCI_ROOT_BRIDGE. The structure is zero-filled as a precaution for later field additions. Here we set the Segment member explicitly to zero (so that any later customization can be easier). Cc: Jordan Justen Cc: Ruiyu Ni Cc: Marcel Apfelbaum

[edk2] [PATCH v2 06/15] OvmfPkg: PciHostBridgeLib: implement PciHostBridgeFreeRootBridges()

This function has no counterpart in OvmfPkg/PciHostBridgeDxe/, but the PciHostBridgeLib class requires it. Cc: Jordan Justen Cc: Ruiyu Ni Cc: Marcel Apfelbaum Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek Reviewed-by: Jordan Justen --- OvmfPkg/Library/Pc

[edk2] [PATCH v2 14/15] OvmfPkg: resolve PciSegmentLib

In the next patch we'll build "MdeModulePkg/Bus/Pci/PciHostBridgeDxe". That driver depends on the PciSegmentLib class. Edk2 offers four instances: (1) MdePkg/Library/UefiPciSegmentLibPciRootBridgeIo/ Inappropriate here because it consumes EFI_PCI_ROOT_BRIDGE_IO_PROTOCOL, but "MdeModul

[edk2] [PATCH v2 12/15] OvmfPkg: PciHostBridgeLib: set RootBus->NoExtendedConfigSpace

In "OvmfPkg/PciHostBridgeDxe/PciRootBridgeIo.c", the RootBridgeIoCheckParameter() function hard-codes the maximum offset for the PCI config space as 0xFF (see the MAX_PCI_REG_ADDRESS macro), which matches OVMF's 0xCF8 / 0xCFC config access method. The "MdeModulePkg/Bus/Pci/PciHostBridgeDxe" driver

[edk2] [PATCH v2 09/15] OvmfPkg: PciHostBridgeLib: clear RootBus->DmaAbove4G

When this BOOLEAN member is FALSE, and the caller tries to set up a DMA transfer between a PCI device and a host buffer not entirely under 4GB, then "MdeModulePkg/Bus/Pci/PciHostBridgeDxe" sets up a bounce buffer under 4GB, in the implementation of EFI_PCI_ROOT_BRIDGE_IO_PROTOCOL.Map(). Since that

[edk2] [PATCH v2 13/15] OvmfPkg: PciHostBridgeLib: initialize RootBus->DevicePath

We copy the code from InitRootBridge() [OvmfPkg/PciHostBridgeDxe/PciHostBridge.c], with a slight change: the device path is allocated separately now. This is the final field to initialize in PCI_ROOT_BRIDGE. The type EFI_PCI_ROOT_BRIDGE_DEVICE_PATH is renamed to OVMF_PCI_ROOT_BRIDGE_DEVICE_PATH.

[edk2] [PATCH v2 11/15] OvmfPkg: PciHostBridgeLib: set bus, IO and 32-bit MMIO windows in RootBus

The bus aperture is copied verbatim from InitRootBridge() [OvmfPkg/PciHostBridgeDxe/PciHostBridge.c]. The IO and 32-bit MMIO apertures are matched to PlatformPei's settings. PciHostBridgeLibDxe expects PciHostBridgeLib instances to advertize the exact apertures. Cc: Jordan Justen Cc: Ruiyu Ni C

[edk2] [PATCH v2 10/15] OvmfPkg: PciHostBridgeLib: set RootBus->AllocationAttributes

InitRootBridge() in "OvmfPkg/PciHostBridgeDxe/PciHostBridge.c" passes the EFI_PCI_HOST_BRIDGE_COMBINE_MEM_PMEM allocation attribute to RootBridgeConstructor(); we should do the same here. >From "MdePkg/Include/Protocol/PciHostBridgeResourceAllocation.h": /// If this bit is set, then the PCI Root

[edk2] [PATCH v2 02/15] OvmfPkg: factor the IO aperture shared by all PCI root bridges into PCDs

At the moment we don't intend to customize this aperture at runtime, but going forward, two modules will need to know about it: PlatformPei (as before), and OVMF's upcoming PciHostBridgeLib instance (because the core PciHostBridgeDxe driver requires the library to state the exact apertures for all

[edk2] [PATCH v2 15/15] OvmfPkg: switch to MdeModulePkg/Bus/Pci/PciHostBridgeDxe

The old driver is retained for now; it remains available with "-D USE_OLD_PCI_HOST". This is because I'd like to involve end users and downstreams in testing the new drier, but also allow them to switch back to the old driver at the first sight of trouble, while we debug the new driver in parallel.

[edk2] [PATCH v2 08/15] OvmfPkg: PciHostBridgeLib: set supported and initial attributes in RootBus

These settings are copied from the RootBridgeConstructor() function, file "OvmfPkg/PciHostBridgeDxe/PciRootBridgeIo.c". Cc: Jordan Justen Cc: Ruiyu Ni Cc: Marcel Apfelbaum Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek Reviewed-by: Jordan Justen --- OvmfP

[edk2] [PATCH v2 00/15] Port OvmfPkg to MdeModulePkg/Bus/Pci/PciHostBridgeDxe

This is version 2 of . In this version, I addressed Jordan's comments for: - OvmfPkg: factor the MMIO aperture shared by all PCI root bridges into PCDs - OvmfPkg: PciHostBridgeLib: convert main loop from PciHostBridgeDxe and rebased the fo

[edk2] [PATCH v2 03/15] OvmfPkg: factor the MMIO aperture shared by all PCI root bridges into PCDs

Going forward, two modules will need to know about the aperture: PlatformPei (as before), and OVMF's upcoming PciHostBridgeLib instance (because the core PciHostBridgeDxe driver requires the library to state the exact apertures for all root bridges). On QEMU, all root bridges share the same MMIO a

[edk2] [PATCH v2 05/15] OvmfPkg: PciHostBridgeLib: convert main loop from PciHostBridgeDxe

In this patch we import the scan for extra root buses from the InitializePciHostBridge() function, in file "OvmfPkg/PciHostBridgeDxe/PciHostBridge.c". For the time being, the InitRootBridge() and UninitRootBridge() functions are just placeholders. The PciHostBridgeGetRootBridges() API expects us

[edk2] [PATCH v2 01/15] OvmfPkg: remove superfluous [PcdsFixedAtBuild] section header

At the location of this header an earlier [PcdsFixedAtBuild] section is in effect already. Cc: Jordan Justen Cc: Ruiyu Ni Cc: Marcel Apfelbaum Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek Reviewed-by: Ruiyu Ni Reviewed-by: Jordan Justen --- OvmfPkg/Ovm

[edk2] [PATCH v2 04/15] OvmfPkg: clone PciHostBridgeLib from MdeModulePkg's Null instance

In this patch we clone "MdeModulePkg/Library/PciHostBridgeLibNull" for customization under OvmfPkg. Differences relative to a verbatim copy: - the Null suffix is dropped from file names, - the UNI file is dropped, together with the corresponding MODULE_UNI_FILE reference in the INF file, - the I

[edk2] [Patch] MdeModulePkg/PciHostBridgeLib: Correct the function header comments

Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ruiyu Ni Cc: Shumin Qiu --- MdeModulePkg/Include/Library/PciHostBridgeLib.h | 4 ++-- MdeModulePkg/Library/PciHostBridgeLibNull/PciHostBridgeLibNull.c | 7 +++ 2 files changed, 5 insertions(+), 6 deletion

Re: [edk2] [PATCH v3 1/2] MdeModulePkg: PciHostBridgeDxe: insert horizontal whitespace

That's totally fine. I firstly thought my r-b is not necessary but later I thought maybe you were waiting for my additional R-b.:) Regards, Ray From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo Ersek Sent: Thursday, March 3, 2016 5:09 PM To: Ni, Ruiyu ; edk2-de...@ml

Re: [edk2] [PATCH v3 1/2] MdeModulePkg: PciHostBridgeDxe: insert horizontal whitespace

On 03/03/16 09:57, Ni, Ruiyu wrote: > > > Reviewed-by: Ruiyu Ni Apologies, your R-b for the 2nd patch came in much earlier -- I assumed you were going to ACK only that one (the important one), so I pushed this series just now, literally 1 minute before finding your ACK for the 1st patch in my M

Re: [edk2] [PATCH v3 2/2] MdeModulePkg: PciHostBridgeDxe: don't assume extended config space

On 03/03/16 06:35, Ni, Ruiyu wrote: > > > Reviewed-by: Ruiyu Ni Awesome. Thank you for working with me through this! Thanks all for the reviews; committed as b07c96658132..014b472053ae. Cheers Laszlo >> -Original Message- >> From: Laszlo Ersek [mailto:ler...@redhat.com] >> Sent: Tues

Re: [edk2] [PATCH v3 1/2] MdeModulePkg: PciHostBridgeDxe: insert horizontal whitespace

Reviewed-by: Ruiyu Ni >-Original Message- >From: Laszlo Ersek [mailto:ler...@redhat.com] >Sent: Tuesday, March 1, 2016 6:22 PM >To: edk2-de...@ml01.01.org >Cc: Ni, Ruiyu ; Kinney, Michael D > >Subject: [PATCH v3 1/2] MdeModulePkg: PciHostBridgeDxe: insert horizontal >whitespace > >..

[edk2] [patch] MdeModulePkg/DisplayEngineDxe: Refine the coding style

Remove the empty line to conform with current coding style. Cc: Qiu Shumin Cc: Eric Dong Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- MdeModulePkg/Universal/DisplayEngineDxe/FormDisplay.c | 1 - 1 file changed, 1 deletion(-) diff --git a/MdeModulePkg/Un

[edk2] [PATCH] MdeModulePkg AcpiTableDxe: Don't uninstall Acpi Sdt Protocol at ReadyToLock

1. The consumer of Acpi Sdt Protocol may want to use the API after ReadyToLock. 2. The ACPI system configuration table even could be overwritten, we see little issue in leaving Acpi Sdt Protocol installed. Cc: Jiewen Yao Cc: Feng Tian Contributed-under: TianoCore Contribution Agreement 1.0 Si