Re: [edk2] [PATCH 0/3] MdePkg, MdeModulePkg, Vlv2TbltDevicePkg: 64-bit LoopTimes in S3 MEM_POLL

On 2016/12/2 9:53, Yao, Jiewen wrote: HI Laszlo Thank you to raise this long time existing issue. :-) There is historic reason that we inherit this undocumented API from EDK-I to EDKII. I do not object your update. I am thinking if it is time to create a new API which can match PI

Re: [edk2] [PATCH 0/4] Fix runtime issue in XenBusDxe when compiled with GCC5

I agree to root cause this issue with GCC6. Could you help submit this issue in bugzilia? Then, we will investigate it further. Thanks Liming -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo Ersek Sent: Friday, December 02, 2016 2:43 AM

Re: [edk2] [PATCH] BaseTools/VolInfo: Fix printf issue using '%ls' in format string

Got it. I will move those 2 implementation before main() before code check-in. Best Regards, Hao Wu > -Original Message- > From: Gao, Liming > Sent: Friday, December 02, 2016 10:56 AM > To: Wu, Hao A; edk2-devel@lists.01.org > Cc: Zhu, Yonghong > Subject: RE: [PATCH] BaseTools/VolInfo:

Re: [edk2] [PATCH] BaseTools/VolInfo: Fix printf issue using '%ls' in format string

Hao: Place move UnicodeStrLen() and Unicode2AsciiString() implementation before main() function. If so, they are not required to be declared again. Other changes are good. Reviewed-by: Liming Gao Thanks Liming -Original Message- From: Wu, Hao A Sent:

Re: [edk2] [Patch] BaseTools: Support QuotedString for PREBUILD/POSTBUILD in DSC file

Reviewed-by: Liming Gao -Original Message- From: Zhu, Yonghong Sent: Wednesday, November 30, 2016 4:24 PM To: edk2-devel@lists.01.org Cc: Gao, Liming Subject: [Patch] BaseTools: Support QuotedString for PREBUILD/POSTBUILD in DSC file If the

Re: [edk2] [Patch] BaseTools: Fix the bug to parse the new map file format

Reviewed-by: Liming Gao -Original Message- From: Zhu, Yonghong Sent: Wednesday, November 30, 2016 4:23 PM To: edk2-devel@lists.01.org Cc: Gao, Liming Subject: [Patch] BaseTools: Fix the bug to parse the new map file format Current the

[edk2] Root Cause of Parse Failure With Redirected Input

if (StrStr (TempLine, L"ShellCommand,") == TempLine) { LoopVariable++; } This line fails because, with redirected input, the file has the UCS-2 byte order mark, so the string "ShellCommand," is not at the beginning of the line. With the file, the byte order mark is not

Re: [edk2] [PATCH] MdeModulePkg/PiSmmCore: AllocatePool should use MemoryType.

Thank you Laszlo. This time, I did not use number purposely. My thinking is that each patch resolves a specific problem. Although I fixed all of them at same time, they can be check in independently. Thank you Yao Jiewen From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Friday, December 2,

Re: [edk2] [PATCH 5/7] DuetPkg: Remove use of IntelFrameworkModulePkg legacy libs

Reviewed-by: Ruiyu Ni Regards, Ray >-Original Message- >From: Leif Lindholm [mailto:leif.lindh...@linaro.org] >Sent: Thursday, December 1, 2016 11:53 PM >To: edk2-devel@lists.01.org >Cc: Ni, Ruiyu ; Justen, Jordan L >;

Re: [edk2] [PATCH 0/3] MdePkg, MdeModulePkg, Vlv2TbltDevicePkg: 64-bit LoopTimes in S3 MEM_POLL

HI Laszlo Thank you to raise this long time existing issue. :-) There is historic reason that we inherit this undocumented API from EDK-I to EDKII. I do not object your update. I am thinking if it is time to create a new API which can match PI specification, and suggest all consumers use the

[edk2] Pipe causes pool failure in Shell.c

Using the latest Shell build, try: ls -sfo | parse FileInfo 2 This ends up with a breakpoint when FreePool is called on Shell.c, line 1756. I'm still debugging, but I wondered if anyone else has seen this? Also: ls -sfo > tmp parse FileInfo 2 < tmp prints nothing, but parse tmp FileInfo 2

Re: [edk2] [patch] MdeModulePkg/SdMmc: Fix build failure caused by last check-in

Reviewed-by: Star Zeng -Original Message- From: Tian, Feng Sent: Thursday, December 1, 2016 4:42 PM To: edk2-devel@lists.01.org Cc: Jan Dabros ; Marcin Wojtas ; Zeng, Star Subject: [patch]

[edk2] [shell] Redirection to environment variable used on command-line not working.

I have a command like this: X %_key% >v _key and X %_key% _key These two commands should do, essentially the same thing, since the command 'X' calls ShellSetEnvironmentVariable() if the 2nd parameter is present. Any thoughts? Tim ___ edk2-devel

Re: [edk2] [PATCH 3/5] OvmfPkg/IndustryStandard: add QemuFwCfgDma.h

On 2016-12-01 12:48:51, Laszlo Ersek wrote: > On 12/01/16 20:34, Jordan Justen wrote: > > On 2016-12-01 09:56:31, Laszlo Ersek wrote: > >> Add the type and macro definitions related to QEMU's DMA-like fw_cfg > >> access method in a dedicated header file. > >> > >> Cc: Ard Biesheuvel

Re: [edk2] [PATCH 0/4] Fix runtime issue in XenBusDxe when compiled with GCC5

On 2016-12-01 12:54:34, Laszlo Ersek wrote: > On 12/01/16 21:06, Jordan Justen wrote: > > On 2016-12-01 10:43:24, Laszlo Ersek wrote: > >> Hrpmf, wait a second, I do see something interesting: in this series you > >> *are* modifying APIs declared in a library class header (namely > >>

[edk2] [Patch v2 0/4] Fix SOURCE_DEBUG_ENABLE

Changes in V2 = * Fix build failure when SOURCE_DEBUG_ENABLE is FALSE Fix SOURCE_DEBUG_ENABLE feature that includes updates to library mappings, PCD settings, and adding DebugAgent UART Console as one of the possible console devices in the PlatformBdsLib. The series also cleans up a

[edk2] [Patch v2 4/4] Vlv2TbltDevicePkg: Update PlatformPkgGccX64.dsc

Update PlatformPkgGccX64.dsc to align with PlatformPkgX64.dsc on library mappings and PCD settings. Cc: Jiewen Yao Cc: David Wei Cc: Mang Guo Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Michael Kinney

[edk2] [Patch v2 3/4] Vlv2TbltDevicePkg/PlatformBdsLib: Add DebugAgent Console

https://bugzilla.tianocore.org/show_bug.cgi?id=276 Add the UART console produced by the DebugAgent when SOURCE_DEBUG_ENABLE is TRUE. Without this change, the debugger connects but the Boot Manager and the UEFI Shell do not have an active console because the Boot Manager does not know about the

[edk2] [Patch v2 2/4] Vlv2TbltDevicePkg: Fix SOURCE_DEBUG_ENABLE feature

https://bugzilla.tianocore.org/show_bug.cgi?id=276 Fix library mapping and PCD settings required to use the SOURCE_DEBUG_ENABLE feature in PEI, DXE, and SMM. Cc: Jiewen Yao Cc: David Wei Cc: Mang Guo Contributed-under: TianoCore

[edk2] [Patch v2 1/4] Vlv2TbltDevicePkg: Make !if statement usage consistent

Cc: Jiewen Yao Cc: David Wei Cc: Mang Guo Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Michael Kinney --- Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc | 2 +-

Re: [edk2] [PATCH V2] UefiCpuPkg/PiSmmCpu: Fixed #double fault on #page fault.

On 12/01/16 13:04, Jiewen Yao wrote: > This patch fixes https://bugzilla.tianocore.org/show_bug.cgi?id=246 > > Previously, when SMM exception happens after EndOfDxe, > with StackGuard enabled on IA32, the #double fault exception > is reported instead of #page fault. > > Root cause is below: > >

Re: [edk2] [PATCH] MdeModulePkg/PiSmmCore: AllocatePool should use MemoryType.

On 12/01/16 09:23, Jiewen Yao wrote: > PiSmmCore supports page level protection based upon the Memory Type > (EfiRuntimeServicesCode/EfiRuntimeServicesData) and PE image. > > However, the Memory Type information is ignored in AllocatePool(). > If a caller calls AllocatePool with

Re: [edk2] [PATCH 0/4] Fix runtime issue in XenBusDxe when compiled with GCC5

On 12/01/16 21:06, Jordan Justen wrote: > On 2016-12-01 10:43:24, Laszlo Ersek wrote: >> On 12/01/16 16:28, Anthony PERARD wrote: >>> Hi, >>> >>> That might be only with the Xen part of OVMF but now that the GCC5 >>> toolchains is used with my gcc (6.2.1 20160830, Arch Linux), OVMF fail >>> to

Re: [edk2] [PATCH 3/5] OvmfPkg/IndustryStandard: add QemuFwCfgDma.h

On 12/01/16 20:34, Jordan Justen wrote: > On 2016-12-01 09:56:31, Laszlo Ersek wrote: >> Add the type and macro definitions related to QEMU's DMA-like fw_cfg >> access method in a dedicated header file. >> >> Cc: Ard Biesheuvel >> Cc: Jordan Justen

Re: [edk2] [PATCH v2 4/4] OvmfPkg/SmmControl2Dxe: select broadcast SMI if available

On 11/23/16 16:44, Laszlo Ersek wrote: > On 11/23/16 04:44, Jordan Justen wrote: >> Series Reviewed-by: Jordan Justen > > Thank you! > > I'll delay pushing the patches until Michael Tsirkin reviews the > interface spec in the QEMU series on qemu-devel. This version

Re: [edk2] [PATCH 0/4] Fix runtime issue in XenBusDxe when compiled with GCC5

On 2016-12-01 10:43:24, Laszlo Ersek wrote: > On 12/01/16 16:28, Anthony PERARD wrote: > > Hi, > > > > That might be only with the Xen part of OVMF but now that the GCC5 > > toolchains is used with my gcc (6.2.1 20160830, Arch Linux), OVMF fail > > to boot in Xen guests. > > > > Here is the

Re: [edk2] [PATCH 0/7] Various: Remove EDK2 use of IntelFrameworkModulePkg legacy libs

For the future, I'd recommend adding Cc's for package owners to the associated patch commit message. Series Reviewed-by: Jordan Justen On 2016-12-01 07:53:19, Leif Lindholm wrote: > LzmaCustomDecompressLib and PeiDxeDebugLibReportStatusCode were copied > from

Re: [edk2] [PATCH 3/5] OvmfPkg/IndustryStandard: add QemuFwCfgDma.h

On 2016-12-01 09:56:31, Laszlo Ersek wrote: > Add the type and macro definitions related to QEMU's DMA-like fw_cfg > access method in a dedicated header file. > > Cc: Ard Biesheuvel > Cc: Jordan Justen > Contributed-under: TianoCore

Re: [edk2] [PATCH 0/4] Fix runtime issue in XenBusDxe when compiled with GCC5

On 12/01/16 16:28, Anthony PERARD wrote: > Hi, > > That might be only with the Xen part of OVMF but now that the GCC5 > toolchains is used with my gcc (6.2.1 20160830, Arch Linux), OVMF fail > to boot in Xen guests. > > Here is the result: > X64 Exception Type - 06(#UD - Invalid Opcode)

Re: [edk2] [PATCH 1/7] OvmfPkg: Remove use of IntelFrameworkModulePkg legacy libs

On 12/01/16 16:53, Leif Lindholm wrote: > LzmaCustomDecompressLib and PeiDxeDebugLibReportStatusCode were copied > from IntelFrameworkModulePkg to MdeModulePkg, but the originals were > kept for compatibility. > > Since the libraries are identical, move OvmfPkg to use the MdeModulePkg > versions

Re: [edk2] [PATCH 0/7] Various: Remove EDK2 use of IntelFrameworkModulePkg legacy libs

Leif, Yes. You can push QuarkSocPkg patch based on my previous rb. Thanks, Mike > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Leif > Lindholm > Sent: Thursday, December 1, 2016 7:53 AM > To: edk2-devel@lists.01.org > Cc: Ni, Ruiyu

[edk2] [PATCH 4/5] ArmVirtPkg/QemuFwCfgLib: rebase lib instance to OvmfPkg/IndustryStandard

where "QemuFwCfgDma.h" was added in the previous patch. Cc: Ard Biesheuvel Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek --- ArmVirtPkg/Library/QemuFwCfgLib/QemuFwCfgLib.c | 24 +++- 1 file

[edk2] [PATCH 1/5] ArmVirtPkg/QemuFwCfgLib: remove superfluous InternalQemuFwCfgIsAvailable()

InternalQemuFwCfgIsAvailable() is an API that is incorrectly exposed by the "OvmfPkg/Include/Library/QemuFwCfgLib.h" library class header; the API is meant to be used internally to library instances (if it's needed at all). ArmVirtPkg's instance has no use for it actually, so simplify the code and

[edk2] [PATCH 5/5] OvmfPkg/QemuFwCfgLib: support QEMU's DMA-like fw_cfg access method

The benefits of the DMA-like access method are (a) speed, (b) write support in QEMU 2.9+. (IOPort-based write support was discontinued in QEMU 2.4, and the DMA-based one is being added to QEMU 2.9. Write support needs no separate feature detection because writeability is governed on the level of

[edk2] [PATCH 0/5] OvmfPkg/QemuFwCfgLib: support the DMA-like interface

I plan to use the DMA interface of QEMU's fw_cfg in upcoming features (one short term, another long term). The first four patches in the series refactor the current library instances (and even the lib class) slightly, while the last patch adds the feature to OVMF. Repo:

[edk2] [PATCH 2/5] OvmfPkg/QemuFwCfgLib: move InternalQemuFwCfgIsAvailable() to lib instances

InternalQemuFwCfgIsAvailable() is an API that is incorrectly exposed by the "OvmfPkg/Include/Library/QemuFwCfgLib.h" library class header; the API is meant to be used internally to library instances (if it's needed at all). In OvmfPkg, we have two lib instances (for SEC and PEI/DXE); they provide

[edk2] [PATCH 3/5] OvmfPkg/IndustryStandard: add QemuFwCfgDma.h

Add the type and macro definitions related to QEMU's DMA-like fw_cfg access method in a dedicated header file. Cc: Ard Biesheuvel Cc: Jordan Justen Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek

[edk2] [PATCH 0/3] MdePkg, MdeModulePkg, Vlv2TbltDevicePkg: 64-bit LoopTimes in S3 MEM_POLL

While working on S3 boot script related stuff in OVMF, I wanted to see if infinite blocking was possible in the various POLL opcodes. While edk2's implementation of IO_POLL, PCI_CONFIG_POLL and PCI_CONFIG2_POLL follows the PI spec vol5 closely, even internally (using 100ns delay units), the

[edk2] [PATCH 3/3] Vlv2TbltDevicePkg/BootScriptSaveDxe: save 64-bit LoopTimes

The BootScriptMemPoll() helper function does the following: - pop LoopTimes from the variable argument list as UINT64, then truncate it to UINTN, - pass the truncated value to S3BootScriptSaveMemPoll() as last argument. The truncation to UINTN is now superfluous, thanks to the patch titled

[edk2] [PATCH 2/3] MdeModulePkg: S3SaveStateDxe, SmmS3SaveState: save 64-bit LoopTimes

The BootScriptWriteMemPoll() helper function in both drivers does the following: - pop Delay from the variable argument list as UINT64, then truncate it to UINTN, - divide Delay by 10, using DivU64x32Remainder(), then store the quotient in LoopTimes (also UINTN), - pass LoopTimes to

[edk2] [PATCH 1/3] MdePkg, MdeModulePkg: S3BootScriptSaveMemPoll(): accept 64-bit LoopTimes

The BaseNull instance of S3BootScriptLib obviously doesn't care about the type of the S3BootScriptSaveMemPoll() function's LoopTimes parameter; this lib instance doesn't do anything with the parameters received in S3BootScriptSaveMemPoll(). The PiDxe instance saves the LoopTimes parameter in

Re: [edk2] [PATCH] ArmPkg: fix compilation error in ArmDmaLib

On Thu, Dec 01, 2016 at 05:00:19PM +, Ard Biesheuvel wrote: > On 1 December 2016 at 16:45, Leif Lindholm wrote: > > Commit 0a99a65d2c8a ("fix incorrect device address of double buffer") > > retained an explicit cast on the variable "Buffer" which became > > incorrect

Re: [edk2] [PATCH] ArmPkg: fix compilation error in ArmDmaLib

On 1 December 2016 at 16:45, Leif Lindholm wrote: > Commit 0a99a65d2c8a ("fix incorrect device address of double buffer") > retained an explicit cast on the variable "Buffer" which became > incorrect with the other changes, leading to compilation failures > with some

Re: [edk2] [PATCH] ArmPkg: fix compilation error in ArmDmaLib

On 01/12/16 16:45, Leif Lindholm wrote: Commit 0a99a65d2c8a ("fix incorrect device address of double buffer") retained an explicit cast on the variable "Buffer" which became incorrect with the other changes, leading to compilation failures with some toolchains. Drop the cast.

[edk2] [PATCH] ArmPkg: fix compilation error in ArmDmaLib

Commit 0a99a65d2c8a ("fix incorrect device address of double buffer") retained an explicit cast on the variable "Buffer" which became incorrect with the other changes, leading to compilation failures with some toolchains. Drop the cast. Contributed-under: TianoCore Contribution Agreement 1.0

Re: [edk2] [PATCH] ShellPkg/MV: Fix MV to deny moving parent of current directory

Reviewed-by: Jaben Carsey > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Ruiyu Ni > Sent: Tuesday, November 22, 2016 6:58 PM > To: edk2-devel@lists.01.org > Cc: Carsey, Jaben ; Chen, Chen A

[edk2] [PATCH 7/7] Vlv2TbltDevicePkg: Remove use of IntelFrameworkModulePkg legacy libs

LzmaCustomDecompressLib and PeiDxeDebugLibReportStatusCode were copied from IntelFrameworkModulePkg to MdeModulePkg, but the originals were kept for compatibility. Since the libraries are identical, move Vlv2TbltDevicePkg to use the MdeModulePkg versions instead. Contributed-under: TianoCore

[edk2] [PATCH 1/7] OvmfPkg: Remove use of IntelFrameworkModulePkg legacy libs

LzmaCustomDecompressLib and PeiDxeDebugLibReportStatusCode were copied from IntelFrameworkModulePkg to MdeModulePkg, but the originals were kept for compatibility. Since the libraries are identical, move OvmfPkg to use the MdeModulePkg versions instead. Contributed-under: TianoCore Contribution

[edk2] [PATCH 3/7] BeagleBoardPkg: Remove use of IntelFrameworkModulePkg legacy libs

LzmaCustomDecompressLib and PeiDxeDebugLibReportStatusCode were copied from IntelFrameworkModulePkg to MdeModulePkg, but the originals were kept for compatibility. Since the libraries are identical, move BeagleBoardPkg to use the MdeModulePkg versions instead. Contributed-under: TianoCore

[edk2] [PATCH 2/7] QuarkSocPkg: Remove use of IntelFrameworkModulePkg legacy libs

LzmaCustomDecompressLib and PeiDxeDebugLibReportStatusCode were copied from IntelFrameworkModulePkg to MdeModulePkg, but the originals were kept for compatibility. Since the libraries are identical, move iQuarkSocPkg to use the MdeModulePkg versions instead. Contributed-under: TianoCore

[edk2] [PATCH 6/7] EmulatorPkg: Remove use of IntelFrameworkModulePkg legacy libs

LzmaCustomDecompressLib and PeiDxeDebugLibReportStatusCode were copied from IntelFrameworkModulePkg to MdeModulePkg, but the originals were kept for compatibility. Since the libraries are identical, move EmulatorPkg to use the MdeModulePkg versions instead. Contributed-under: TianoCore

[edk2] [PATCH 4/7] EmbeddedPkg: Remove use of IntelFrameworkModulePkg legacy libs

LzmaCustomDecompressLib and PeiDxeDebugLibReportStatusCode were copied from IntelFrameworkModulePkg to MdeModulePkg, but the originals were kept for compatibility. Since the libraries are identical, move EmbeddedPkg to use the MdeModulePkg versions instead. Contributed-under: TianoCore

[edk2] [PATCH 5/7] DuetPkg: Remove use of IntelFrameworkModulePkg legacy libs

LzmaCustomDecompressLib and PeiDxeDebugLibReportStatusCode were copied from IntelFrameworkModulePkg to MdeModulePkg, but the originals were kept for compatibility. Since the libraries are identical, move DuetPkg to use the MdeModulePkg versions instead. Contributed-under: TianoCore Contribution

[edk2] [PATCH 0/7] Various: Remove EDK2 use of IntelFrameworkModulePkg legacy libs

LzmaCustomDecompressLib and PeiDxeDebugLibReportStatusCode were copied from IntelFrameworkModulePkg to MdeModulePkg, but the originals were kept for compatibility. Nevertheless, new code should be using the MdeModulePkg versions, so change all references in in-tree platforms. Since the patches

[edk2] [PATCH 0/4] Fix runtime issue in XenBusDxe when compiled with GCC5

Hi, That might be only with the Xen part of OVMF but now that the GCC5 toolchains is used with my gcc (6.2.1 20160830, Arch Linux), OVMF fail to boot in Xen guests. Here is the result: X64 Exception Type - 06(#UD - Invalid Opcode) CPU Apic ID - RIP - 1F26AF6B, CS -

[edk2] [PATCH 3/4] OvmfPkg/XenBusDxe: Add EFIAPI to XenStore functions

Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Anthony PERARD --- OvmfPkg/XenBusDxe/XenStore.c | 13 + OvmfPkg/XenBusDxe/XenStore.h | 10 ++ 2 files changed, 23 insertions(+) diff --git a/OvmfPkg/XenBusDxe/XenStore.c

[edk2] [PATCH 2/4] OvmfPkg/XenBusDxe: Add EFIAPI to XenEventChannelNotify

Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Anthony PERARD --- OvmfPkg/XenBusDxe/EventChannel.c | 1 + OvmfPkg/XenBusDxe/EventChannel.h | 1 + 2 files changed, 2 insertions(+) diff --git a/OvmfPkg/XenBusDxe/EventChannel.c

Re: [edk2] [patch] MdeModulePkg/SdMmc: Fix build failure caused by last check-in

Hi Feng, You are right. Sorry for the mistake. Best regards, Marcin 2016-12-01 9:41 GMT+01:00 Feng Tian : > The commit e27cca has a typo on DEBUG level macro. And this debug > message should be DEBUG_INFO rather than DEBUG_ERROR. > > Cc: Jan Dabros > Cc:

[edk2] [PATCH] BaseTools/VolInfo: Fix printf issue using '%ls' in format string

https://bugzilla.tianocore.org/show_bug.cgi?id=257 For GCC compilers, when building with option '-fshort-wchar', wide char string format '%ls' does not work properly for printf() function. The string specified by '%ls' will not be printed. This commit avoids using '%ls' for printf() function and

[edk2] [PATCH V2] UefiCpuPkg/PiSmmCpu: Fixed #double fault on #page fault.

This patch fixes https://bugzilla.tianocore.org/show_bug.cgi?id=246 Previously, when SMM exception happens after EndOfDxe, with StackGuard enabled on IA32, the #double fault exception is reported instead of #page fault. Root cause is below: Current EDKII SMM page protection will lock GDT. If

Re: [edk2] [RFC] Various: Remove EDK2 use of IntelFrameworkModulePkg legacy libs

On Thu, Dec 01, 2016 at 09:52:15AM +0800, Zeng, Star wrote: > On 2016/12/1 1:20, Leif Lindholm wrote: > >LzmaCustomDecompressLib and PeiDxeDebugLibReportStatusCode were copied > >from IntelFrameworkModulePkg to MdeModulePkg, but the originals were > >kept for compatibility. > > > >Nevertheless,

Re: [edk2] [PATCH] MdeModulePkg/CapsuleApp: add Internal for function name.

Reviewed-by: Feng Tian Thanks Feng -Original Message- From: Yao, Jiewen Sent: Thursday, December 1, 2016 4:51 PM To: edk2-devel@lists.01.org Cc: Tian, Feng ; Fan, Jeff Subject: [PATCH] MdeModulePkg/CapsuleApp: add Internal

[edk2] [PATCH] MdeModulePkg/CapsuleApp: add Internal for function name.

To prevent potential build failure. Cc: Feng Tian Cc: Jeff Fan Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jiewen Yao --- MdeModulePkg/Application/CapsuleApp/AppSupport.c | 8

[edk2] [patch] MdeModulePkg/SdMmc: Fix build failure caused by last check-in

The commit e27cca has a typo on DEBUG level macro. And this debug message should be DEBUG_INFO rather than DEBUG_ERROR. Cc: Jan Dabros Cc: Marcin Wojtas Cc: Star Zeng Contributed-under: TianoCore Contribution Agreement 1.0

Re: [edk2] [Patch] MdeModulePkg PiSmmCore: Update comments in InitializeMemoryServices

Got it. I will keep comment "Need add Free memory at first, to let gSmmMemoryMap record data". -Original Message- From: Yao, Jiewen Sent: Thursday, December 01, 2016 3:41 PM To: Gao, Liming ; edk2-devel@lists.01.org Cc: Zeng, Star Subject: RE:

[edk2] [PATCH] MdeModulePkg/PiSmmCore; Use DEBUG_WARN for non 4k aligned image.

Cc: Jeff Fan Cc: Michael D Kinney Cc: Laszlo Ersek Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jiewen Yao --- MdeModulePkg/Core/PiSmmCore/MemoryAttributesTable.c | 4 ++-- 1

[edk2] [PATCH] MdeModulePkg/PiSmmCore: MemoryAttributeTable need keep non-PE record.

Current memory attribute table implementation will only mark PE code to be EfiRuntimeServicesCode, and mark rest to be EfiRuntimeServicesData. However, there might be a case that a SMM code wants to allocate EfiRuntimeServicesCode explicitly to let page table protect this region to be read only.

[edk2] [PATCH] MdeModulePkg/PiSmmCore: use EfiPagesToSize to prevent build error.

EFI_PAGES_TO_SIZE only handles UINTN, so we use EfiPagesToSize to handle UINT64. Cc: Jeff Fan Cc: Michael D Kinney Cc: Laszlo Ersek Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jiewen Yao

[edk2] [PATCH] MdeModulePkg/PiSmmCore: AllocatePool should use MemoryType.

PiSmmCore supports page level protection based upon the Memory Type (EfiRuntimeServicesCode/EfiRuntimeServicesData) and PE image. However, the Memory Type information is ignored in AllocatePool(). If a caller calls AllocatePool with EfiRuntimeServicesCode, the final memory is still allocated as