Re: [edk2] [PATCH v2] TFTP : tftp fix for full volume case

Reviewed-by: Ruiyu Ni Thanks/Ray > -Original Message- > From: Carsey, Jaben > Sent: Monday, October 9, 2017 10:13 PM > To: Meenakshi Aggarwal ; Fu, Siyuan > ; edk2-devel@lists.01.org; Ni, Ruiyu > ;

Re: [edk2] [PATCH 0/6] MdeModulePkg/VariableSmm: fix MOR / MorLock inconsistency

Thanks. Please use ASSERT() when you check in. Series Reviewed-by: jiewen@intel.com From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Wednesday, October 4, 2017 6:40 PM To: Yao, Jiewen ; edk2-devel-01 Cc: Dong,

Re: [edk2] [PATCH 6/6] MdeModulePkg/Variable/RuntimeDxe: delete and lock OS-created MOR variable

Yes, option a) looks good to me. A simple patch is good enough in this case. In addition, this original patch passed our validation with MOR and MORL. The series is reviewed-by: jiewen@intel.com We can treat a) in another patch. Thank you Yao Jiewen From:

Re: [edk2] Request to display Initiator IP in ISCSI Attempt Page

Hi Jiaxin, Thanks for your support. I've created a ticket in Bugzilla, and below are the details https://bugzilla.tianocore.org/show_bug.cgi?id=732 Yeah we should grayout the Initiator info to indicate it's un-configurable. In case of IPv6 1. Before trying for ISCSI connection(with

Re: [edk2] [PATCH] MdeModulePkg/PciHostBridgeDxe: Fixed PCI DMA Map/Umap bounce buffer

Hi Ard, Ray, Thanks for your comments. On 10/09/2017 07:23 AM, Ard Biesheuvel wrote: On 9 October 2017 at 11:40, Ard Biesheuvel wrote: On 9 October 2017 at 08:42, Ni, Ruiyu wrote: The "read"/"write" is from the Bus Master's point of view.

Re: [edk2] Different ISCSI behavior when 2 attempts are added

Will try with Updating to "Enabled for MPIO". Thanks for your great support, Karunakar From: Ye, Ting [mailto:ting...@intel.com] Sent: Tuesday, October 10, 2017 8:39 AM To: Wu, Jiaxin; Karunakar P; 'edk2-devel@lists.01.org' Cc: Fu, Siyuan Subject: RE: Different ISCSI behavior when 2 attempts are

Re: [edk2] Different ISCSI behavior when 2 attempts are added

Yes, I agree that it is the implementation's choice. If you need Attempt 1 in Case 2&4, try to update "Enabled" to "Enabled for MPIO". Thanks, Ting Ye From: Wu, Jiaxin Sent: Tuesday, October 10, 2017 11:01 AM To: Karunakar P ; 'edk2-devel@lists.01.org'

Re: [edk2] Different ISCSI behavior when 2 attempts are added

Hi Karunakar, I think it's not the bug according the current iSCSI implementation that the first login session will be selected while others are aborted directly. Here, IP4 is the first login session. I didn't find any state that the first attempt should be connected. Ting and Siyuan, If

Re: [edk2] [PATCH] SecurityPkg/SecureBootConfigImpl.c: Fix coding style issue.

Reviewed-by: Chao Zhang -Original Message- From: Chen, Chen A Sent: Tuesday, October 10, 2017 10:09 AM To: edk2-devel@lists.01.org Cc: Chen, Chen A ; Bi, Dandan ; Zhang, Chao B Subject: [PATCH]

Re: [edk2] [PATCH] SecurityPkg/SecureBootConfigImpl.c: Fix the potential NULL dereference.

Some comments below. Best Regards, Hao Wu > -Original Message- > From: Chen, Chen A > Sent: Tuesday, October 10, 2017 10:08 AM > To: edk2-devel@lists.01.org > Cc: Chen, Chen A; Zhang, Chao B; Wu, Hao A > Subject: [PATCH] SecurityPkg/SecureBootConfigImpl.c: Fix the potential NULL >

Re: [edk2] Request to display Initiator IP in ISCSI Attempt Page

Hi Karunakar, We agree to add this feature for the Initiator info of IPv4 when DHCP enabled. Can you report it on Bugzilla first? To achieve that, we can grayout the Initiator IP/Subnet/Gateway if Initiator DHCP enabled to indicate it's un-configurable. For IPv6, since iSCSI only request the

Re: [edk2] [PATCH] SecurityPkg/SecureBootConfigImpl.c: Fix coding style issue.

Reviewed-by: Bi Dandan Thanks, Dandan -Original Message- From: Chen, Chen A Sent: Tuesday, October 10, 2017 10:09 AM To: edk2-devel@lists.01.org Cc: Chen, Chen A ; Bi, Dandan ; Zhang, Chao B

Re: [edk2] [PATCH 0/2] Dynamic Tables

HI Evan Thanks for the contribution. This is a very big feature. It may talk us more time to review and evaluate. At same time, one of our key MdeModule package maintainer is in paternity leave. It may be longer than usual. I notice you only defined ARM namespace in this patch, and implemented

[edk2] [PATCH] SecurityPkg/SecureBootConfigImpl.c: Fix coding style issue.

Fix coding style issue. Cc: Bi Dandan Cc: Zhang Chao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: chenc2 --- .../SecureBootConfigDxe/SecureBootConfigImpl.c | 30 +++---

[edk2] [PATCH] SecurityPkg/SecureBootConfigImpl.c: Fix the potential NULL dereference.

Cc: Zhang Chao Cc: Wu Hao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Chen A Chen --- .../SecureBootConfigDxe/SecureBootConfigImpl.c | 80 +++--- 1 file changed, 57 insertions(+),

Re: [edk2] [PATCH v4 6/6] OvmfPkg/QemuVideoDxe: Bypass NULL pointer detection during VBE SHIM installing

I have summary in each patch email. I removed the CC of some patches because there's no update from v3 to v4. I thought this could remind you of this situation. What's the recommended way? Keep the CC as-was and just add summaries in cover letter? > -Original Message- > From: Laszlo

Re: [edk2] [Patch][edk2-platforms/devel-MinnowBoard3-UDK2017] Enable SueCreek

Reviewed-by: zwei4 Thanks, David Wei Intel SSG/STO/UEFI BIOS > -Original Message- > From: Guo, Mang > Sent: Tuesday, October 10, 2017 9:18 AM > To: edk2-devel@lists.01.org > Cc: Wei, David ; Rytkonen, Teemu S

[edk2] [Patch][edk2-platforms/devel-MinnowBoard3-UDK2017] Enable SueCreek

1. Change SPI mode and speed for SueCreek 2. Update SueCreek HOST_IRQ and HOST_RST GPIO configuration 3. Add a PCD to make sure that SueCreek only reported to OS when it is actually present on the board. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Yeon Sil Yoon

Re: [edk2] MTFTP file transfer timeout error

Hi, Vabhav Yes the IP layer should discard the whole packet if any frame is lost during the transmit. Large TFTP blksize will reduce the the number of TFTP data/ack packets, but add more overhead and risk of IP fragmentation and reassembly. BestRegards Fu Siyuan -Original Message-

Re: [edk2] [PATCH v2 1/2] ArmPkg/Include: Add standard SMC function IDs for MM interface.

On Mon, Oct 09, 2017 at 04:15:27PM +0100, Supreeth Venkatesh wrote: > I can do that. Thanks! > However, "-4" is missing in the specification. Is there a chance to rectify > specification to add "-4", so that I can do both the defines. To indicate what error? Anyways, lets take this offline.

Re: [edk2] SError Exception and HCR_EL2 Usage

On 9 October 2017 at 18:33, Vabhav Sharma wrote: > Dear Experts, > > I am facing SError exception during UEFI bring-up. > At boot , secure f/w starts in EL3 and loads UEFI image to DDR. After this > secure f/w passes control to UEFI in EL2. > > I debugged and manifest the

Re: [edk2] [PATCH] ArmPkg/ArmSmcPsciResetSystemLib: add support for warm reboot

On 9 October 2017 at 19:22, Leif Lindholm wrote: > On Fri, Oct 06, 2017 at 09:41:52PM +0100, Ard Biesheuvel wrote: >> PSCI SYSTEM_RESET is specified as a cold reboot, which does not >> preserve the contents of DRAM. In version 1.1, a new reset method >> was introduced

Re: [edk2] [PATCH] ArmPkg/ArmSmcPsciResetSystemLib: add support for warm reboot

On Fri, Oct 06, 2017 at 09:41:52PM +0100, Ard Biesheuvel wrote: > PSCI SYSTEM_RESET is specified as a cold reboot, which does not > preserve the contents of DRAM. In version 1.1, a new reset method > was introduced that allows a warm reboot to be requested. > > This is especially relevant for

[edk2] SError Exception and HCR_EL2 Usage

Dear Experts, I am facing SError exception during UEFI bring-up. At boot , secure f/w starts in EL3 and loads UEFI image to DDR. After this secure f/w passes control to UEFI in EL2. I debugged and manifest the problem by adding below lines in UEFI PrePi entry point(ModuleEntryPoint.S)

Re: [edk2] MTFTP file transfer timeout error

Hi Fu Siyuan, Thank you for explanation and hope you enjoyed vacation. I am using 32K block size for file transfer. IP layer divides the 32K block size into 23 number of fragments(with last fragment of less size indicating no more fragments) Using tcpdump and debug code the flow is: NIC

[edk2] [platforms: PATCH 12/13] Marvell/Armada: Add the UefiPxeBcDxe driver

From: Ard Biesheuvel This driver allows automatic booting via the network. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel Signed-off-by: Marcin Wojtas ---

[edk2] [platforms: PATCH 13/13] Marvell/Documentation: Follow EDK2 coding style in the PortingGuide

This patch removes tabs and wrong line endings in the file, maiking it acceptable to the PatchCheck.py script. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marcin Wojtas --- Silicon/Marvell/Documentation/PortingGuide.txt | 800 ++-- 1

[edk2] [platforms: PATCH 11/13] Marvell/Armada: Remove outdated SEC alignment override

From: Ard Biesheuvel The FDFs no longer require explicit alignment for sections containing aligned objects, so change it to 'Auto' and FIXED (which allows some padding to be removed), and remove some other cruft while at it. Contributed-under: TianoCore Contribution

[edk2] [platforms: PATCH 08/13] Marvell/Armada: Modify GICC alias

From: Ard Biesheuvel The GIC architecture mandates that the CPU interface, which consists of 2 consecutive 4 KB frames, can be mapped using separate mappings. Since this is problematic on 64 KB pages, the MMU-400 aliases each frame 16 times, and the two consecutive

[edk2] [platforms: PATCH 09/13] Marvell/Armada: Disable PerformanceLibrary

From: Ard Biesheuvel Remove the gEfiMdePkgTokenSpaceGuid.PcdPerformanceLibraryPropertyMask setting so it reverts to its default of 0, and disables performance profiling. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel

[edk2] [platforms: PATCH 10/13] Marvell/Armada: Switch to unicore PrePi

From: Ard Biesheuvel There is no point in using the MPCore PrePi, given that only the primary core will enter UEFI at EL2, and the secondaries will be held in EL3 until summoned by the OS. So use the unicore flavour instead. Contributed-under: TianoCore Contribution

[edk2] [platforms: PATCH 06/13] Marvell/Armada: Switch to generic BDS

From: Ard Biesheuvel Switch from the Intel BDS to the generic BDS, which is preferred for ARM platforms given that it is completely legacy free. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel

[edk2] [platforms: PATCH 07/13] Marvell/Armada: Re-enable driver model diagnostics PCDs

From: Ard Biesheuvel For some reason, one of the early ARM platforms disabled all the diagnostics related to the UEFI driver model, resulting in the output of UEFI shell utilities such as 'devices' or 'drivers' to become completely useless. Armada's shared .DSC include

[edk2] [platforms: PATCH 04/13] Marvell/Armada: Armada70x0Lib: Clean FV in the D-cache before boot

From: Ard Biesheuvel To prevent cache coherency issues when chainloading via U-Boot, clean and invalidate the FV image in the caches before re-enabling the MMU. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel

[edk2] [platforms: PATCH 00/13] Armada 7k/8k - misc improvements

Hi, This patchset is a first part of general platform support improvements. It consists of a series of short changes, maybe except for the initialization phase DXE driver. The patches are available in the github (from now on pushed as a branch):

[edk2] [platforms: PATCH 03/13] Marvell/Armada: Armada70x0Lib: Terminate call stack list at entry

From: Ard Biesheuvel To avoid dereferencing junk when walking the call stack in exception handlers (which may prevent us from getting a full backtrace), set the frame pointer to 0x0 when first entering UEFI. Contributed-under: TianoCore Contribution Agreement 1.1

[edk2] [platforms: PATCH 05/13] Marvell/Armada: Use 4k/64k aligned sections for DXE/DXE-rt modules

From: Ard Biesheuvel Enable strict memory protection at boot time and under the OS, by using 4 KB section alignment for DXE_DRIVER, UEFI_DRIVER and UEFI_APPLICATION modules, and 64 KB alignment for DXE_RUNTIME_DRIVER modules. Note that the latter is mandated by the

[edk2] [platforms: PATCH 02/13] Marvell/Armada: Switch to dynamic PCDs

From: Ard Biesheuvel For full functionality, including HII forms wired to non-volatile UEFI variables, we need dynamic PCDs as well. So let's enable those. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel

[edk2] [platforms: PATCH 01/13] Marvell/Armada: Introduce platform initialization driver

In order to enable modification of dynamic PCD's for the libraries and DXE drivers, this patch introduces new driver. It is executed prior to other drivers. Mpp, ComPhy and Utmi libraries initialization were moved from PrePi stage to DXE. To force the correct driver dispatch sequence, introduce a

Re: [edk2] [platforms: PATCH v2 3/5] Marvell/Library: UtmiLib: Move devices description to MvHwDescLib

On Mon, Oct 09, 2017 at 06:25:18PM +0200, Marcin Wojtas wrote: > 2017-10-09 18:23 GMT+02:00 Leif Lindholm : > > On Mon, Oct 09, 2017 at 06:06:53PM +0200, Marcin Wojtas wrote: > >> 2017-10-09 18:00 GMT+02:00 Leif Lindholm : > >> > On Sun, Oct 08,

Re: [edk2] [platforms: PATCH v2 3/5] Marvell/Library: UtmiLib: Move devices description to MvHwDescLib

2017-10-09 18:23 GMT+02:00 Leif Lindholm : > On Mon, Oct 09, 2017 at 06:06:53PM +0200, Marcin Wojtas wrote: >> 2017-10-09 18:00 GMT+02:00 Leif Lindholm : >> > On Sun, Oct 08, 2017 at 12:56:50PM +0200, Marcin Wojtas wrote: >> >> This patch

Re: [edk2] [platforms: PATCH v2 3/5] Marvell/Library: UtmiLib: Move devices description to MvHwDescLib

On Mon, Oct 09, 2017 at 06:06:53PM +0200, Marcin Wojtas wrote: > 2017-10-09 18:00 GMT+02:00 Leif Lindholm : > > On Sun, Oct 08, 2017 at 12:56:50PM +0200, Marcin Wojtas wrote: > >> This patch introduces UTMI description, using the new structures > >> and template in

[edk2] [platforms: PATCH v3 3/5] Marvell/Library: UtmiLib: Move devices description to MvHwDescLib

This patch introduces UTMI description, using the new structures and template in MvHwDescLib. This change enables more flexible addition of multiple CP with UTMI PHY's and also significantly reduces amount of used PCD's for that purpose. Update PortingGuide documentation accordingly. This patch

Re: [edk2] [platforms: PATCH v2 3/5] Marvell/Library: UtmiLib: Move devices description to MvHwDescLib

2017-10-09 18:00 GMT+02:00 Leif Lindholm : > On Sun, Oct 08, 2017 at 12:56:50PM +0200, Marcin Wojtas wrote: >> This patch introduces UTMI description, using the new structures >> and template in MvHwDescLib. This change enables more flexible >> addition of multiple CP

Re: [edk2] [platforms: PATCH v2 3/5] Marvell/Library: UtmiLib: Move devices description to MvHwDescLib

On Sun, Oct 08, 2017 at 12:56:50PM +0200, Marcin Wojtas wrote: > This patch introduces UTMI description, using the new structures > and template in MvHwDescLib. This change enables more flexible > addition of multiple CP with UTMI PHY's and also significantly > reduces amount of used PCD's for

Re: [edk2] [PATCH v4 6/6] OvmfPkg/QemuVideoDxe: Bypass NULL pointer detection during VBE SHIM installing

On 10/09/17 17:54, Laszlo Ersek wrote: > On 10/09/17 16:17, Jian J Wang wrote: >> QemuVideoDxe driver will link VBE SHIM into page 0. If NULL pointer >> detection is enabled, this driver will fail to load. NULL pointer detection >> bypassing code is added to prevent such problem during boot. >> >>

Re: [edk2] [PATCH v4 6/6] OvmfPkg/QemuVideoDxe: Bypass NULL pointer detection during VBE SHIM installing

On 10/09/17 16:17, Jian J Wang wrote: > QemuVideoDxe driver will link VBE SHIM into page 0. If NULL pointer > detection is enabled, this driver will fail to load. NULL pointer detection > bypassing code is added to prevent such problem during boot. > > Please note that Windows 7 will try to

Re: [edk2] [PATCH 6/6] MdeModulePkg/Variable/RuntimeDxe: delete and lock OS-created MOR variable

On 10/09/17 09:12, Zeng, Star wrote: > Laszlo, > > Do you think VariableRuntimeDxe(TcgMorLockDxe.c) also needs to delete and > lock OS-created MOR variable? Maybe -- I'm not sure. If an edk2 platform uses "VariableRuntimeDxe", then it cannot securely support MorLock, that's for sure. However,

Re: [edk2] [PATCH v2 1/2] ArmPkg/Include: Add standard SMC function IDs for MM interface.

I can do that. However, "-4" is missing in the specification. Is there a chance to rectify specification to add "-4", so that I can do both the defines. Thanks, Supreeth -Original Message- From: Achin Gupta Sent: Monday, October 9, 2017 3:52 AM To: Ard Biesheuvel

Re: [edk2] Different ISCSI behavior when 2 attempts are added

Hello All, Found the below behavior when I try for ISCSI connection with 2 Valid attempts. Case 1: Attempt 1---Enabled(ISCSI Mode)---IP4Enabled(Initiator DHCP)---Disabled(Target DHCP)--->Valid Attempt Attempt 2---Enabled(ISCSI Mode)---IP6Enabled(Initiator DHCP)---Disabled(Target

[edk2] [PATCH v4 6/6] OvmfPkg/QemuVideoDxe: Bypass NULL pointer detection during VBE SHIM installing

QemuVideoDxe driver will link VBE SHIM into page 0. If NULL pointer detection is enabled, this driver will fail to load. NULL pointer detection bypassing code is added to prevent such problem during boot. Please note that Windows 7 will try to access VBE SHIM during boot if it's installed, and

[edk2] [PATCH v4 5/6] IntelFrameworkModulePkg/Csm: Add code to bypass NULL pointer detection

Legacy has to access interrupt vector, BDA, etc. located in memory between 0-4095. To allow as much code as possible to be monitored by NULL pointer detection, we add code to temporarily disable this feature right before those memory access and enable it again afterwards. Cc: Star Zeng

[edk2] [PATCH v4 3/6] MdeModulePkg/Core/Dxe: Add EndOfDxe workaround for NULL pointer detection

> According to Star's feedback, use GCD service instead of CPU arch > protocol to change page attributes One of issue caused by enabling NULL pointer detection is that some PCI device OptionROM, binary drivers and binary OS boot loaders may have NULL pointer access bugs, which will prevent BIOS

[edk2] [PATCH v4 4/6] UefiCpuPkg/PiSmmCpuDxeSmm: Implement NULL pointer detection for SMM code

The mechanism behind is the same as NULL pointer detection enabled in EDK-II core. SMM has its own page table and we have to disable page 0 again in SMM mode. Cc: Star Zeng Cc: Eric Dong Cc: Jiewen Yao Cc: Michael Kinney

[edk2] [PATCH v4 2/6] MdeModulePkg/DxeIpl: Implement NULL pointer detection

> According to Start's feedback > a. Change function ClearLegacyMemory to ClearFirst4KPage > b. Call ClearFirst4KPage only when NULL detection is enabled > c. Move ClearFirst4KPage to X64/Ia32 related files NULL pointer detection is done by making use of paging mechanism of CPU. During page

[edk2] [PATCH v4 1/6] MdeModulePkg/MdeModulePkg.dec, .uni: Add NULL pointer detection PCD

From: "Wang, Jian J" PCD PcdNullPointerDetectionPropertyMask is a bitmask used to control the NULL address detection functionality in code for different phases. If enabled, accessing NULL address in UEFI or SMM code can be caught as a page fault exception. BIT0-

[edk2] [PATCH v4 0/6] Add NULL pointer detection feature

The mechanism behind is to trigger a page fault exception at address 0. This can be made by disabling page 0 (0-4095) during page table setup. So this feature can only be available on platform with paging enabled. Once this feature is enabled, any code, like CSM, which has to access memory in

Re: [edk2] [PATCH v2] TFTP : tftp fix for full volume case

I am fine. Ray? Reviewed-by: Jaben Carsey > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Meenakshi Aggarwal > Sent: Sunday, October 08, 2017 11:28 PM > To: Fu, Siyuan ; edk2-devel@lists.01.org;

[edk2] [Patch] BaseTools: Fix the bug 'DSC DEFAULT' in report wrongly use FDF value

current the PCD value in DSC file may be override by FDF file, then it cause the 'DSC DEFAULT' in build report wrongly display the FDF value but not the DSC file's value. This patch add a attribute DscDefaultValue for PcdClassObject to save the actual DSC file's PCD value and use this value to

[edk2] [Patch] BaseTools: Fix the bug 'DSC DEFAULT' in report wrongly use FDF value

current the PCD value in DSC file may be override by FDF file, then it cause the 'DSC DEFAULT' in build report wrongly display the FDF value but not the DSC file's value. This patch add a attribute DscDefaultValue for PcdClassObject to save the actual DSC file's PCD value and use this value to

[edk2] [Patch] BaseTools: Fix the Keyword error for in FDF File

current in FDF spec 3.6 [FV] section it use "FV_EXT_ENTRY_TYPE" as Keyword for , while in the code it use "FV_EXT_ENTRY". To keep compatibility, this patch support both keyword in the code first. Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.1

Re: [edk2] [PATCH 2/6] MdeModulePkg/Variable/RuntimeDxe: move MOR func. declarations to header

On 10/09/17 08:55, Zeng, Star wrote: > Minor comment: > > How about also to fix the comment for Attributes parameter of > SetVariableCheckHandlerMor() like below? > > @param[in] Attributes Attributes bitmask to set for the variable. Right, I can do that. Thanks! Laszlo >

Re: [edk2] [PATCH] MdeModulePkg/PciHostBridgeDxe: Fixed PCI DMA Map/Umap bounce buffer

On 9 October 2017 at 11:40, Ard Biesheuvel wrote: > On 9 October 2017 at 08:42, Ni, Ruiyu wrote: >> The "read"/"write" is from the Bus Master's point of view. >> >> >> Thanks/Ray >> >>> -Original Message- >>> From: edk2-devel

Re: [edk2] [PATCH 0/2] Add FPDT Acpi table

On Fri, Sep 22, 2017 at 05:18:05PM +0100, evan.ll...@arm.com wrote: > From: EvanLloyd > Paired patches for edk2 and edk2-platforms that add an FPDT > acpi table. > This is useful for monitoring firmware performance, etc. With Graeme's Reviewed-by, I'm happy with thise series.

Re: [edk2] [PATCH] MdeModulePkg/PciHostBridgeDxe: Fixed PCI DMA Map/Umap bounce buffer

On 9 October 2017 at 08:42, Ni, Ruiyu wrote: > The "read"/"write" is from the Bus Master's point of view. > > > Thanks/Ray > >> -Original Message- >> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Daniil >> Egranov >> Sent: Monday, October 9,

Re: [edk2] [PATCH 0/2] Add FPDT Acpi table

On 22 September 2017 at 17:18, wrote: > From: EvanLloyd > > > Paired patches for edk2 and edk2-platforms that add an FPDT > acpi table. > This is useful for monitoring firmware performance, etc. > >From ACPI on ARM point of view this looks fine to me.

Re: [edk2] [PATCH v2 1/2] ArmPkg/Include: Add standard SMC function IDs for MM interface.

Hi Ard/Supreeth, On Fri, Oct 06, 2017 at 10:05:46PM +0100, Ard Biesheuvel wrote: > On 27 September 2017 at 19:58, Supreeth Venkatesh > wrote: > > This patch adds a list of function IDs that fall under the standard > > SMC range as defined in > >

[edk2] [PATCH] SecurityPkg\Tcg2Pei: FV measure performance enhancement

1. Leverage Pre-Hashed FV PPI to reduce duplicated hash 2. Only measure BFV at the beginning. Other FVs are measured in FVinfo callback with nested FV check. https://bugzilla.tianocore.org/show_bug.cgi?id=662 Cc: Long Qin Cc: Yao Jiewen Cc: Sean

Re: [edk2] [Patch] BaseTools: Fix a bug to use module's Name attribute as compare

Reviewed-by: Liming Gao >-Original Message- >From: Zhu, Yonghong >Sent: Monday, October 09, 2017 4:14 PM >To: edk2-devel@lists.01.org >Cc: Gao, Liming >Subject: [Patch] BaseTools: Fix a bug to use module's Name attribute as >compare > >Fix a

[edk2] [Patch] BaseTools: Fix a bug to use module's Name attribute as compare

Fix a bug to use module's Name attribute as compare for single module build. ModuleFile.File can't be used to compare INF file, because it is the relative path. Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Yonghong Zhu

Re: [edk2] [PATCH] MdePkg: Add definitions for ACPI 6.2

Reviewed-by: Liming Gao >-Original Message- >From: Zeng, Star >Sent: Saturday, September 30, 2017 11:11 PM >To: edk2-devel@lists.01.org >Cc: Zeng, Star ; Yao, Jiewen ; >Gao, Liming >Subject: [PATCH]

Re: [edk2] [PATCH 0/5] Propagate PEI-phase FV authentication status to DXE

Reviewed-by: Liming Gao >-Original Message- >From: Zeng, Star >Sent: Wednesday, October 04, 2017 10:21 PM >To: edk2-devel@lists.01.org >Cc: Zeng, Star ; Gao, Liming >Subject: [PATCH 0/5] Propagate PEI-phase FV

Re: [edk2] [PATCH] MdeModulePkg/PciHostBridgeDxe: Fixed PCI DMA Map/Umap bounce buffer

The "read"/"write" is from the Bus Master's point of view. Thanks/Ray > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Daniil > Egranov > Sent: Monday, October 9, 2017 9:16 AM > To: edk2-devel@lists.01.org > Cc: leif.lindh...@linaro.org;

Re: [edk2] [PATCH] MdeModulePkg/S3SaveState: Extract arguments in correct order

Reviewed-by: Star Zeng -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ruiyu Ni Sent: Monday, October 9, 2017 3:13 PM To: edk2-devel@lists.01.org Cc: Zeng, Star Subject: [edk2] [PATCH]

Re: [edk2] [PATCH v1] MdePkg: Add definitions for the SPI protocols introduced in UEFI PI 1.6.

Hi Marvin, I have reviewed the remaining parts. Here are the comments: 1. There is a typo in LegacySpiFlash.h Typo: #ifndef __SPI_CONFIGURATION_PROTOCOL_H__ #define __SPI_CONFIGURATION_PROTOCOL_H__ The token __SPI_CONFIGURATION_PROTOCOL_H__ in LegacySpiFlash.h in duplicated with

[edk2] [PATCH] MdeModulePkg/S3SaveState: Extract arguments in correct order

EFI_BOOT_SCRIPT_WRITE() interface is a var-arg interface. Spec defines the order of parameters for EFI_BOOT_SCRIPT_PCI_CONFIG2_WRITE_OPCODE as below: typedef EFI_STATUS (EFIAPI *EFI_BOOT_SCRIPT_WRITE) ( IN CONST EFI_S3_SAVE_STATE_PROTOCOL *This, IN UINT16 OpCode, IN

Re: [edk2] [PATCH 6/6] MdeModulePkg/Variable/RuntimeDxe: delete and lock OS-created MOR variable

Laszlo, Do you think VariableRuntimeDxe(TcgMorLockDxe.c) also needs to delete and lock OS-created MOR variable? Thanks, Star -Original Message- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Wednesday, October 4, 2017 5:29 AM To: edk2-devel-01 Cc: Dong,

Re: [edk2] Fwd: StartImage with Secure Boot on Self-Signed App

David: PI Security2 Architectural Protocol can be used to verify PE image. It wraps Trusted Computing Group (TCG) measured boot and UEFI Secure boot. But, you can't base on it to know the wrong return status from TCG measurement or image verification. Thanks Liming >-Original

Re: [edk2] [PATCH 2/6] MdeModulePkg/Variable/RuntimeDxe: move MOR func. declarations to header

Minor comment: How about also to fix the comment for Attributes parameter of SetVariableCheckHandlerMor() like below? @param[in] Attributes Attributes bitmask to set for the variable. Thanks, Star -Original Message- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent:

Re: [edk2] [PATCH v2] TFTP : tftp fix for full volume case

Hi Team, Any further comments on this patch? Or is it ready to merge in edk2? Thanks, Meenakshi > -Original Message- > From: Meenakshi Aggarwal > Sent: Wednesday, September 27, 2017 9:01 AM > To: 'Fu, Siyuan' ; edk2-devel@lists.01.org; Ni, Ruiyu >