Re: [edk2] Patch to fix EFIAPI definition

> On Feb 8, 2018, at 11:12 PM, Ruslan Nikolaev wrote: > > Well, what I was implying is that if MdePkg (Ia32) headers are included in > some UEFI program which itself is compiled with some custom register-based > calling convention, current EFIAPI definition is

Re: [edk2] Patch to fix EFIAPI definition

Well, what I was implying is that if MdePkg (Ia32) headers are included in some UEFI program which itself is compiled with some custom register-based calling convention, current EFIAPI definition is insufficient. Current definition with cdecl attribute merely forces caller stack clean-up in

Re: [edk2] [Patch 0/2] NetworkPkg: Support the platform to configure TLS CipherList.

Sure, I will update the wiki once the patch is committed. Thanks Jiaxin > -Original Message- > From: Li, Ruth > Sent: Friday, February 9, 2018 3:08 PM > To: Fu, Siyuan ; Wu, Jiaxin ; > edk2-devel@lists.01.org > Cc: Kinney, Michael D

Re: [edk2] [Patch 0/2] NetworkPkg: Support the platform to configure TLS CipherList.

Jiaxin With this capability introduced, could you update Wiki page to notify platform to configure that if needed? https://github.com/tianocore/tianocore.github.io/wiki/HTTPS-Boot Thanks, Ruth -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of

Re: [edk2] Patch to fix EFIAPI definition

> On Feb 8, 2018, at 5:32 PM, Ruslan Nikolaev wrote: > > I submitted a bug report and a patch: > https://bugzilla.tianocore.org/show_bug.cgi?id=870 > It is very straight-forward. Can someone review it, and, hopefully, commit > the change? Ruslan, Was there an

Re: [edk2] [patch 1/2] ShellPkg/Dp: Add null pointer check

Reviewed-by: Liming Gao >-Original Message- >From: Bi, Dandan >Sent: Friday, February 09, 2018 11:10 AM >To: edk2-devel@lists.01.org >Cc: Gao, Liming ; Wu, Hao A >Subject: [patch 1/2] ShellPkg/Dp: Add null pointer check >

Re: [edk2] [patch 2/2] ShellPkg/DP: Update the error message info

Reviewed-by: Liming Gao >-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of >Dandan Bi >Sent: Friday, February 09, 2018 11:10 AM >To: edk2-devel@lists.01.org >Cc: Yao, Jiewen ; Gao, Liming

Re: [edk2] [patch] MdeModulePkg/DriverSampleDxe: Make bit fields aligned in C structure

Reviewed-by: Liming Gao >-Original Message- >From: Bi, Dandan >Sent: Thursday, February 08, 2018 10:29 PM >To: edk2-devel@lists.01.org >Cc: Dong, Eric ; Gao, Liming >Subject: [patch] MdeModulePkg/DriverSampleDxe: Make bit

Re: [edk2] [PATCH v4 1/1] MdePkg/Include: Add management mode FV file type and depex.

Reviewed-by: Liming Gao >-Original Message- >From: Supreeth Venkatesh [mailto:supreeth.venkat...@arm.com] >Sent: Friday, February 09, 2018 4:25 AM >To: edk2-devel@lists.01.org >Cc: Kinney, Michael D ; Gao, Liming >;

Re: [edk2] [Patch 0/2] NetworkPkg: Support the platform to configure TLS CipherList.

Thanks the comment, I will refine the series patch. > -Original Message- > From: Fu, Siyuan > Sent: Friday, February 9, 2018 1:23 PM > To: Wu, Jiaxin ; edk2-devel@lists.01.org > Cc: Laszlo Ersek ; Kinney, Michael D > ;

Re: [edk2] [Patch 0/2] NetworkPkg: Support the platform to configure TLS CipherList.

Hi, Jiaxin I think we can remove the "TlsCipherList.h" to another name like "HttpTlsCipherListVariable.h" to highlight that the variable is only used for HTTP configuration. And also the variable name and GUID name. Siyuan > -Original Message- > From: Wu, Jiaxin > Sent: Friday,

[edk2] [Patch] BaseTools: Improve build performance

Add cache for building PcdValueInit.c. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Bob Feng Cc: Liming Gao --- BaseTools/Source/Python/GenFds/GenFds.py | 1 + BaseTools/Source/Python/Workspace/DscBuildData.py |

Re: [edk2] [PATCH v2 00/10] Formalize the reset system core design

Thanks for the new version patch series. With minor comments (I provided to V1) handled, Reviewed-by: Star Zeng to the patch series. :) For patch 007: "@param[in] ResetType Base reset type as defined in UEFI spec." needs to be removed in ResetUtilityLib.h For patch

[edk2] [PATCH v2 03/10] MdeModulePkg/PeiMain: Cleanup whitespace in Reset.c

From: Michael D Kinney Cc: Liming Gao Reviewed-by: Ruiyu Ni Cc: Star Zeng Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Michael D Kinney

[edk2] [PATCH v2 00/10] Formalize the reset system core design

The patches add/update two core modules that perform the reset action ResetSystemPei and ResetSystemRuntimeDxe With the two core modules, every time a reset action is performed in either PEI phase or DXE phase, the accordingly registerred reset filter/notification/handler will be triggered.

[edk2] [PATCH v2 08/10] MdePkg/UefiRuntimeLib: Support more module types.

Because DxeResetSystemLib links to this library to provide reset system services, change UefiRuntimeLib to support the same set of module types as what DxeResetSystemLib does. Cc: Liming Gao Cc: Michael D Kinney Reviewed-by: Star Zeng

[edk2] [PATCH v2 01/10] MdePkg/PeiServicesLib: Add PeiServicesResetSystem2()

From: Michael D Kinney Add the PeiServicesResetSytstem2() function to the PeiServiesLib to call the ResetSystem2() services in the PEI Services Table. Cc: Liming Gao Cc: Ruiyu Ni Contributed-under: TianoCore Contribution

[edk2] [PATCH v2 06/10] MdeModulePkg: Add ResetSystemLib instances that call core services

From: Michael D Kinney Add a PEI instance of ResetSystemLib that calls the ResetSystem2() service in the PEI Services Table. Add a DXE instance of ResetSystemLib that calls the ResetSystem() service in the UEFI Runtime Services Table. These 2 library instances

[edk2] [PATCH v2 09/10] MdeModulePkg: Add ResetSystemPei PEIM

This driver implements Reset2, ResetFilter and ResetHandler PPIs. Cc: Liming Gao Cc: Michael D Kinney Cc: Star Zeng Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ruiyu Ni ---

[edk2] [PATCH v2 05/10] MdeModulePkg/ResetSystemRuntimeDxe: Add more debug message

The patch adds more debug message in ResetSystem(). It also removes unnecessary check of mResetNotifyDepth. Cc: Liming Gao Cc: Michael D Kinney Reviewed-by: Star Zeng Contributed-under: TianoCore Contribution Agreement 1.1

[edk2] [PATCH v2 04/10] MdeModulePkg/ResetSystemRuntimeDxe: Add platform filter and handler

From: Michael D Kinney Add support for platform specific reset filters and platform specific reset handlers to ResetSystem(). A filter may modify the reset type and reset data and call ResetSystem() with the modified parameters. A handler performs the reset action.

[edk2] [PATCH v2 07/10] MdeModulePkg: Add ResetUtility librray class and BASE instance

From: Michael D Kinney The library class that provides services to generate a GUID specific reset, parse the GUID from a GUID specific reset, and build the ResetData buffer for any type of reset that requires extra data. Cc: Liming Gao

[edk2] [PATCH v2 10/10] MdeModulePkg/ResetSystemPei: Add reset notifications in PEI

From: Bret Barkelew The Reset Notification protocol is added in UEFI spec to support reset notification mechanism in the DXE phase. This patch adds similar EDKII specific Reset Notification PPI to PEI phase to provide the same support. Cc: Liming Gao

[edk2] [Patch 2/2] NetworkPkg: Read TlsCipherList variable and configure it for HTTPS session.

This patch is to read the TlsCipherList variable and configure it for the later HTTPS session. If the variable is not set by any platform, EFI_NOT_FOUND will be returned from GetVariable service. In such a case, the default CipherList created in TlsDxe driver will be used. Cc: Laszlo Ersek

[edk2] [Patch 0/2] NetworkPkg: Support the platform to configure TLS CipherList.

Cc: Laszlo Ersek Cc: Kinney Michael D Cc: Zimmer Vincent Cc: Yao Jiewen Cc: Ye Ting Cc: Fu Siyuan Contributed-under: TianoCore Contribution Agreement 1.0

[edk2] [Patch 1/2] NetworkPkg: Define one private variable for TLS CipherList configuration.

This variable can be set by any platform that want to control its own preferred TlsCipherList for the later HTTPS session. The valid contents of variable must follow the TLS CipherList format defined in RFC 5246. The valid length of variable must be an integral multiple of 2. For example, if

Re: [edk2] [PATCH 09/10] MdeModulePkg: Add ResetSystemPei PEIM

On 2/7/2018 8:35 PM, Zeng, Star wrote: On 2018/2/2 14:45, Ruiyu Ni wrote: This driver implements Reset2, ResetFilter and ResetHandler PPIs. Cc: Liming Gao Cc: Michael D Kinney Cc: Star Zeng Contributed-under: TianoCore

[edk2] [patch 2/2] ShellPkg/DP: Update the error message info

Make the error message clearer if fail to get ACPI/FPDT table. Cc: Liming Gao Cc: Jiewen Yao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Dandan Bi --- ShellPkg/DynamicCommand/DpDynamicCommand/Dp.c |

[edk2] [patch 1/2] ShellPkg/Dp: Add null pointer check

Cc: Liming Gao Cc: Hao Wu Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Dandan Bi --- ShellPkg/DynamicCommand/DpDynamicCommand/Dp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [edk2] [PATCH 08/10] MdePkg/UefiRuntimeLib: Support more module types.

On 2/7/2018 8:24 PM, Zeng, Star wrote: On 2018/2/2 14:45, Ruiyu Ni wrote: Because DxeResetSystemLib links to this library to provide reset system services, change UefiRuntimeLib to support the same set of module types as what DxeResetSystemLib does. Cc: Liming Gao Cc:

Re: [edk2] [PATCH 05/10] MdeModulePkg/ResetSystemRuntimeDxe: Add more debug message

On 2/7/2018 8:04 PM, Zeng, Star wrote: On 2018/2/2 14:45, Ruiyu Ni wrote: The patch adds more debug message in ResetSystem(). It also removes unnecessary check of mResetNotifyDepth. Cc: Liming Gao Cc: Michael D Kinney Cc: Star Zeng

Re: [edk2] [PATCH] SourceLevelDebugPkg DebugUsb3: Check mUsb3Instance before dereferencing it

Reviewed-by: Hao Wu Best Regards, Hao Wu > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Star > Zeng > Sent: Friday, February 09, 2018 10:45 AM > To: edk2-devel@lists.01.org > Cc: Ni, Ruiyu; Wu, Hao A; Zeng, Star >

[edk2] [PATCH] SourceLevelDebugPkg DebugUsb3: Check mUsb3Instance before dereferencing it

Cc: Ruiyu Ni Cc: Hao Wu Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Star Zeng --- .../Library/DebugCommunicationLibUsb3/DebugCommunicationLibUsb3Dxe.c| 2 +- 1 file changed, 1 insertion(+), 1

Re: [edk2] [edk2-platforms][PATCH] Platform/Hisilicon/HiKey960: add skeleton of HiKey960

On Thu, Feb 08, 2018 at 04:02:39PM +, Ard Biesheuvel wrote: > On 8 February 2018 at 16:01, Haojian Zhuang wrote: > > On 7 February 2018 at 01:29, Leif Lindholm wrote: > >> On Mon, Feb 05, 2018 at 04:25:52PM +0800, Haojian Zhuang wrote: >

[edk2] Patch to fix EFIAPI definition

I submitted a bug report and a patch: https://bugzilla.tianocore.org/show_bug.cgi?id=870 It is very straight-forward. Can someone review it, and, hopefully, commit the change? - Ruslan ___ edk2-devel mailing list edk2-devel@lists.01.org

Re: [edk2] [PATCH] BaseTools: Update Expression.py for string comparison and MACRO replace issue

Reviewed-by: Yonghong Zhu Best Regards, Zhu Yonghong -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Yonghong Zhu Sent: Thursday, February 08, 2018 10:46 PM To: edk2-devel@lists.01.org Cc: Feng, YunhuaX

[edk2] [PATCH v4 1/1] MdePkg/Include: Add management mode FV file type and depex.

As per PI specification v1.6, As per section 2.1.4.1, The following file types exist: Table 3. Defined File Types Name Value EFI_FV_FILETYPE_RAW0x01 EFI_FV_FILETYPE_FREEFORM 0x02 EFI_FV_FILETYPE_SECURITY_CORE 0x03

Re: [edk2] [PATCH edk2-platforms 1/3] Platform/(AMD|LeMaker|SoftIron), Silicon/AMD: drop unused PcdCacheEnabled

On 8 February 2018 at 19:30, Leif Lindholm wrote: > PcdCacheEnabled was never useful for these platforms, but they copied it > over from other platforms used as templates. > Delete it here to keep the platforms building once the Pcd is removed > from EmbeddedPkg. > >

[edk2] [PATCH edk2-platforms 2/3] Platform/ARM: drop use of PcdCacheEnabled

PcdCacheEnabled does nothing useful for these platforms. Delete all uses of it here to keep the platforms building once the Pcd is removed from EmbeddedPkg. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Leif Lindholm ---

[edk2] [PATCH edk2-platforms 3/3] (Platform/Silicon)/Hisilicon: drop use of PcdCacheEnabled

PcdCacheEnabled was never useful for these platforms, but it was copied over from other platforms used as templates. Delete it here to keep the platforms building once the Pcd is removed from EmbeddedPkg. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Leif Lindholm

[edk2] [PATCH edk2-platforms 1/3] Platform/(AMD|LeMaker|SoftIron), Silicon/AMD: drop unused PcdCacheEnabled

PcdCacheEnabled was never useful for these platforms, but they copied it over from other platforms used as templates. Delete it here to keep the platforms building once the Pcd is removed from EmbeddedPkg. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Leif Lindholm

Re: [edk2] [PATCH 1/2] BeagleBoardPkg: drop unused PcdCacheEnabled dependency

On 8 February 2018 at 19:19, Leif Lindholm wrote: > Commit f72df138 got rid of the use of PcdCacheEnabled, but failed to > actually drop it as a dependency for BeagleBoardLib. > > Get rid of it, so the module will still build when the Pcd is _really_ > removed. > >

[edk2] [PATCH 2/2] EmbeddedPkg: _really_ delete PcdCacheEnable from .dec

Commit e537d878 meant to, but failed to, remove PcdCacheEnable. Address this, and get rid of this obsolete flag. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Leif Lindholm --- EmbeddedPkg/EmbeddedPkg.dec | 1 - 1 file changed, 1 deletion(-)

[edk2] [PATCH 1/2] BeagleBoardPkg: drop unused PcdCacheEnabled dependency

Commit f72df138 got rid of the use of PcdCacheEnabled, but failed to actually drop it as a dependency for BeagleBoardLib. Get rid of it, so the module will still build when the Pcd is _really_ removed. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Leif Lindholm

Re: [edk2] [PATCH] CorebootPayloadPkg: Use correct BytesPerScanLine

"You, Benjamin" writes: > Hi Arthur, > > I agree with your suggestion that Payload interpret BytesPerScanLine and > Horizontal Resolution properly such that a 1366 display can be handled well. > > The functioning will depend on Coreboot interpreting properly too. However

[edk2] Poll: When to use OVMF and Nt32?

EDK2 community, When developing/testing UEFI and you can easily choose between using OVMF and Nt32, which do you choose and why? When is OVMF better/easier to use than Nt32 and vice versa? I ask because I am giving an internal presentation to our newer

Re: [edk2] [PATCH edk2-platforms] Silicon/SynQuacer/DeviceTree: remove SCPI/MHU nodes

On 8 February 2018 at 16:17, Leif Lindholm wrote: > On Thu, Feb 08, 2018 at 02:57:51PM +, Ard Biesheuvel wrote: >> On our SynQuacer based platform, power state handling and other >> low-level duties are handled by the secure firmware, not by the >> OS, so remove the

Re: [edk2] [PATCH edk2-platforms 1/3] Platform/ARM: drop unused EmbeddedPkg Pcds

On 8 February 2018 at 17:45, Leif Lindholm wrote: > On Thu, Feb 08, 2018 at 03:08:19PM +, Alexei Fedorov wrote: >> This patch causes Juno and other ARM platforms to raise an assert during MMU >> initialisation in ArmConfigureMmu() > > Huh... > >>

Re: [edk2] [PATCH edk2-platforms 1/3] Platform/ARM: drop unused EmbeddedPkg Pcds

On Thu, Feb 08, 2018 at 03:08:19PM +, Alexei Fedorov wrote: > This patch causes Juno and other ARM platforms to raise an assert during MMU > initialisation in ArmConfigureMmu() Huh... > (edk2\ArmPkg\Library\ArmMmuLib\AArch64\ArmMmuLibCore.c): > > > ASSERT (TranslationTableAttribute ==

Re: [edk2] [PATCH v2 0/2] sync some function definitions with their declarations

On 02/08/18 16:14, Carsey, Jaben wrote: > Reviewed-by: Jaben Carsey Thank you all; series pushed as commit range de8373fa07f8..c0d221a34854. Laszlo >> -Original Message- >> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of >> Laszlo Ersek >>

Re: [edk2] [PATCH edk2-platforms] Silicon/SynQuacer/DeviceTree: remove SCPI/MHU nodes

On Thu, Feb 08, 2018 at 02:57:51PM +, Ard Biesheuvel wrote: > On our SynQuacer based platform, power state handling and other > low-level duties are handled by the secure firmware, not by the > OS, so remove the various MHU/SCPI related nodes from the device > tree. > > Contributed-under:

Re: [edk2] [edk2-platforms][PATCH] Platform/Hisilicon/HiKey960: add skeleton of HiKey960

On 8 February 2018 at 16:01, Haojian Zhuang wrote: > On 7 February 2018 at 01:29, Leif Lindholm wrote: >> On Mon, Feb 05, 2018 at 04:25:52PM +0800, Haojian Zhuang wrote: >>> Add skeleton of HiKey960 platform. >>> >>> Contributed-under:

Re: [edk2] [edk2-platforms][PATCH] Platform/Hisilicon/HiKey960: add skeleton of HiKey960

On 7 February 2018 at 01:29, Leif Lindholm wrote: > On Mon, Feb 05, 2018 at 04:25:52PM +0800, Haojian Zhuang wrote: >> Add skeleton of HiKey960 platform. >> >> Contributed-under: TianoCore Contribution Agreement 1.1 >> Signed-off-by: Haojian Zhuang

Re: [edk2] [PATCH] ShellPkg/hexedit: Fix a read-after-free bug

Reviewed-by: Jaben Carsey > -Original Message- > From: Ni, Ruiyu > Sent: Wednesday, February 07, 2018 8:45 PM > To: edk2-devel@lists.01.org > Cc: Carsey, Jaben > Subject: [PATCH] ShellPkg/hexedit: Fix a read-after-free bug > Importance:

Re: [edk2] [PATCH] ShellPkg/rm: fix hang when deleting an absolutely-empty directory An ordinary empty directory should contain "." and ".." entries. When an empty directory even doesn't contain "." o

Reviewed-by: Jaben Carsey > -Original Message- > From: Ni, Ruiyu > Sent: Wednesday, February 07, 2018 7:41 PM > To: edk2-devel@lists.01.org > Cc: Carsey, Jaben > Subject: [PATCH] ShellPkg/rm: fix hang when deleting an absolutely-empty >

Re: [edk2] [PATCH v2 0/2] sync some function definitions with their declarations

Reviewed-by: Jaben Carsey > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Laszlo Ersek > Sent: Wednesday, February 07, 2018 2:45 PM > To: edk2-devel@lists.01.org > Cc: Ni, Ruiyu ; Brijesh Singh

Re: [edk2] [PATCH edk2-platforms 1/3] Platform/ARM: drop unused EmbeddedPkg Pcds

This patch causes Juno and other ARM platforms to raise an assert during MMU initialisation in ArmConfigureMmu() (edk2\ArmPkg\Library\ArmMmuLib\AArch64\ArmMmuLibCore.c): ASSERT (TranslationTableAttribute == ARM_MEMORY_REGION_ATTRIBUTE_WRITE_BACK || TranslationTableAttribute ==

[edk2] [PATCH edk2-platforms] Silicon/SynQuacer/DeviceTree: remove SCPI/MHU nodes

On our SynQuacer based platform, power state handling and other low-level duties are handled by the secure firmware, not by the OS, so remove the various MHU/SCPI related nodes from the device tree. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel

[edk2] [PATCH] BaseTools: Update Expression.py for string comparison and MACRO replace issue

From: Yunhua Feng 1. Fix string comparison incorrect issue, we expected "ABC" is greater than "AAD" since the second char 'B' is greater than 'A'. 2. fix MACRO not replace issue. Cc: Liming Gao Cc: Yonghong Zhu

[edk2] [patch] MdeModulePkg/DriverSampleDxe: Make bit fields aligned in C structure

For a structure with a series of bit fields and used as a storage in vfr file, and if the bit fields do not add up to the size of the defined type.In the C code use sizeof() to get size of the structure, the results may vary form the compiler(VS,GCC...). But the size of the storage calculated by

[edk2] [Patch] BaseTools: Add the missing basic definition in C BaseType.h

Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Liming Gao --- BaseTools/Source/C/Include/Common/BaseTypes.h | 25 + 1 file changed, 25 insertions(+) diff --git a/BaseTools/Source/C/Include/Common/BaseTypes.h

Re: [edk2] [Patch] MdeModulePkg PeiCore: Add error message to describe PEIM load failure

They are reported in different phase. The first message is print before load image. The second message is print after load image successfully. If load image failure, only first message is print. So, I don't think we can combine them. >-Original Message- >From: Zeng, Star >Sent:

Re: [edk2] [Patch] MdeModulePkg PeiCore: Add error message to describe PEIM load failure

On 02/08/18 11:24, Gao, Liming wrote: > Laszlo: > 11p address is big to cover most real address. It can align and save the > message length. Good point, it can go up to 2^44 - 1, covering 16 TB of RAM. Thanks Laszlo > Thanks > Liming >> -Original Message- >> From: Laszlo Ersek

Re: [edk2] [Patch] MdeModulePkg PeiCore: Add error message to describe PEIM load failure

How about combining it to one for DXE? Either print FFS GUID or file name from PDB path, or both. Thanks, Star -Original Message- From: Gao, Liming Sent: Thursday, February 8, 2018 6:25 PM To: Zeng, Star ; edk2-devel@lists.01.org Subject: RE: [Patch] MdeModulePkg

Re: [edk2] [PATCH edk2-platforms] Silicon/SynQuacer/PlatformDxe: disable eMMC DDR50 support

On 8 February 2018 at 10:21, Leif Lindholm wrote: > On Thu, Feb 08, 2018 at 10:18:12AM +, Ard Biesheuvel wrote: >> We already disable SDR104 support on the SynQuacer eMMC controller to >> work around the need for a special tuning quirk that is difficult to >>

Re: [edk2] [Patch] MdeModulePkg PeiCore: Add error message to describe PEIM load failure

Star: This change is to align Loading Driver in DXE phase. You can find below message in DXE boot. Loading driver 80CF7257-87AB-47F9-A3FE-D50B76D89541 InstallProtocolInterface: 5B1B31A1-9562-11D2-8E3F-00A0C969723B 88014240 Loading driver at 0x00087FE6000 EntryPoint=0x00087FE70B4 PcdDxe.efi

Re: [edk2] [Patch] MdeModulePkg PeiCore: Add error message to describe PEIM load failure

Laszlo: 11p address is big to cover most real address. It can align and save the message length. Thanks Liming >-Original Message- >From: Laszlo Ersek [mailto:ler...@redhat.com] >Sent: Thursday, February 08, 2018 5:31 PM >To: Gao, Liming ; edk2-devel@lists.01.org

Re: [edk2] [PATCH edk2-platforms] Silicon/SynQuacer/PlatformDxe: disable eMMC DDR50 support

On Thu, Feb 08, 2018 at 10:18:12AM +, Ard Biesheuvel wrote: > We already disable SDR104 support on the SynQuacer eMMC controller to > work around the need for a special tuning quirk that is difficult to > implement without modifying the generic driver, even in the presence > of a SD/MMC

Re: [edk2] [Patch] MdeModulePkg PeiCore: Add error message to describe PEIM load failure

Hi Liming, Because of new added "+ DEBUG ((DEBUG_INFO, "Loading PEIM %g\n", FileHandle));", the debug message will have two "Loading PEIM XXX" for one PEIM, that is very confusing. Loading PEIM 9B3ADA4F-AE56-4C24-8DEA-F03B7558AE50 Loading PEIM at 0x2353000 EntryPoint=0x03C10C5

Re: [edk2] [Patch 05/10] OvmfPkg: Add SafeIntLib and BmpSupportLib to DSC files

On 02/08/18 10:32, Ard Biesheuvel wrote: > On 8 February 2018 at 09:25, Laszlo Ersek wrote: >> On 02/08/18 09:32, Jordan Justen wrote: >> >>> Given the wording from the contribution agreement, it appears that it >>> would also be fine to just use Mike's Signed-off-by if he is

Re: [edk2] [Patch] MdeModulePkg PeiCore: Add error message to describe PEIM load failure

On 02/08/18 09:18, Liming Gao wrote: > If PEIM image address doesn't meet with its section alignment, it will > load fail. PeiCore adds more debug message to report it. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Liming Gao > Cc: Star Zeng

Re: [edk2] [Patch 05/10] OvmfPkg: Add SafeIntLib and BmpSupportLib to DSC files

On 02/08/18 09:32, Jordan Justen wrote: > Given the wording from the contribution agreement, it appears that it > would also be fine to just use Mike's Signed-off-by if he is > authorized to contribute the code even though he didn't author it. So basically just """ Contributed-under:

Re: [edk2] [Patch 05/10] OvmfPkg: Add SafeIntLib and BmpSupportLib to DSC files

On 02/08/18 08:43, Ard Biesheuvel wrote: > On 8 February 2018 at 01:35, Laszlo Ersek wrote: >> On 02/08/18 00:48, Kinney, Michael D wrote: >>> Laszlo, >>> >>> The BmpSupportLib content was from contributions from >>> a capsule related branch. However, the BmpSupportLib >>> can

[edk2] [PATCH] SourceLevelDebugPkg DebugUsb3: Fix GCC build failures

Fix GCC build failures below. variable 'EvtTrb' set but not used [-Werror=unused-but-set-variable] variable 'Index' set but not used [-Werror=unused-but-set-variable] The build failure could only be caught with -D SOURCE_DEBUG_USE_USB3 build flag. Cc: Ruiyu Ni Cc: Hao Wu

Re: [edk2] [Patch 09/10] EmulatorPkg: Add SafeIntLib and BmpSupportLib to DSC files

Reviewed-by: Jordan Justen On 2018-02-07 14:58:21, Kinney, Michael D wrote: > From: Michael D Kinney > > https://bugzilla.tianocore.org/show_bug.cgi?id=800 > > Based on content from the following branch/commits: >

Re: [edk2] [Patch 05/10] OvmfPkg: Add SafeIntLib and BmpSupportLib to DSC files

On 2018-02-07 23:43:44, Ard Biesheuvel wrote: > On 8 February 2018 at 01:35, Laszlo Ersek wrote: > > On 02/08/18 00:48, Kinney, Michael D wrote: > >> Laszlo, > >> > >> The BmpSupportLib content was from contributions from > >> a capsule related branch. However, the

[edk2] [Patch] MdeModulePkg PeiCore: Add error message to describe PEIM load failure

If PEIM image address doesn't meet with its section alignment, it will load fail. PeiCore adds more debug message to report it. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Liming Gao Cc: Star Zeng ---

Re: [edk2] [PATCH v2] UefiCpuPkg/S3Resume: Add more perf entry for S3 phase

On 02/08/18 07:19, Dandan Bi wrote: > V2: Just update the commit message. > > Add more perf entry to hook BootScriptDonePpi/EndOfPeiPpi/ > EndOfS3Resume. > > Add the new perf entry with Identifier > PERF_INMODULE_START_ID/PERF_INMODULE_END_ID which are defined > in new performance infrastructure