v2:
1.Correct some typos.
2.Remove two library classse and a protocal in .c and .h files
Some redundant library classes, protocols and GUIDs
have been removed in inf, .c and .h files.
https://bugzilla.tianocore.org/show_bug.cgi?id=1017
https://bugzilla.tianocore.org/show_bug.cgi?id=1035
Laszlo:
I have no other comments. IntelFrameworkPkg has another UefiLib library
instance FrameworkUefiLib. Could you help update it also?
For MdePkg, you can add Reviewed-by: Liming Gao
Thanks
Liming
>-Original Message-
>From: Laszlo Ersek [mailto:ler...@redhat.com]
>Sent: Monday,
Yes, it seems to us that different IORT versions require different acpica
versions; acpica does not keep backward compatibility for IORT, i.e. newer
acpica is not able to compile older IORT. That's really awkward :(
Heyi
-邮件原件-
发件人: Ming [mailto:ming.hu...@linaro.org]
发送时间:
Hi Laszlo & Ricardo
The patch was intended to reduce the time to read TPM interface ID register.
The interface type should not change within boot cycle according to PTP spec.
I agree to add some ASSERT after PCDSetxxsS.
But It is a core solution without platform change as PCD has been configured
在 8/2/2018 5:56 AM, Leif Lindholm 写道:
> On Tue, Jul 24, 2018 at 03:08:44PM +0800, Ming Huang wrote:
>> The major features of this patchset include:
>> 1 D06 source code;
>> 2 Unify some D0x modules;
>>
>> This patch set is base on pcihostbridage-v2.
>> For compiling D06, add below hunk to
> -Original Message-
> From: Leif Lindholm
> Sent: Wednesday, August 1, 2018 2:39 AM
> To: Ard Biesheuvel
> Cc: Chris Co ; edk2-devel@lists.01.org;
> Michael D Kinney
> Subject: Re: [PATCH edk2-platforms 3/3] Platform/Microsoft: Add
> Lauterbach debug library
>
> On Tue, Jul 31,
Thanks Laszlo, I have refined the patch to v2 with your "Reviewed-by" tag.
> -Original Message-
> From: Laszlo Ersek [mailto:ler...@redhat.com]
> Sent: Wednesday, August 1, 2018 5:49 PM
> To: Wu, Jiaxin ; edk2-devel@lists.01.org
> Cc: Ye, Ting ; Fu, Siyuan
> Subject: Re: [Patch]
Reviewed-by: Hao Wu
Best Regards,
Hao Wu
> -Original Message-
> From: Zeng, Star
> Sent: Thursday, August 02, 2018 9:16 AM
> To: edk2-devel@lists.01.org
> Cc: Zeng, Star; Yao, Jiewen; Wu, Hao A
> Subject: [PATCH] MdeModulePkg DxeCapsuleLibFmp: Add NULL check to the
> return buffers
>
*v2: Optimize the patch by calculating AsciiStrSize() only once.
In URI, the colon (:) is used to terminate the HostName path before
a port number. However, if HostName is expressed as IPv6 format, colon
characters in IPv6 addresses will conflict with the colon before port
number. To alleviate
Add NULL check to the return buffers from GetFmpHandleBufferByType().
Cc: Jiewen Yao
Cc: Hao A Wu
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Star Zeng
---
MdeModulePkg/Library/DxeCapsuleLibFmp/DxeCapsuleLib.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
Hi Leif,
> -Original Message-
> From: Leif Lindholm
> Sent: Tuesday, July 31, 2018 1:33 PM
> To: Chris Co
> Cc: edk2-devel@lists.01.org; Ard Biesheuvel ;
> Michael D Kinney
> Subject: Re: [PATCH edk2-platforms 1/3] Platform/Microsoft: Add SdMmc
> Dxe Driver
>
> Hi Chris,
>
> On Tue,
Hi Leif,
Thank you for the initial feedback. I will address the items on all the
patches and resubmit as one set.
Chris
> -Original Message-
> From: Leif Lindholm
> Sent: Wednesday, August 1, 2018 9:15 AM
> To: Chris Co
> Cc: edk2-devel@lists.01.org; Ard Biesheuvel ;
> Michael D
Laszlo,
Thank you for the pointers to the dependent header files.
I agree that main API header files should include any headers that they depend
upon and not require the developer to search out the dependencies. Most modern
pre-processors and compilers have optimizations to mitigate reading
From: "Zeng, Star"
FmpDxe.c:517:18: error: equality comparison with extraneous
parentheses [-Werror,-Wparentheses-equality]
NOTE: This patch is based on thread
https://lists.01.org/pipermail/edk2-devel/2018-July/027810.html.
Cc: Michael D Kinney
Contributed-under: TianoCore Contribution
From: Star Zeng
Instead of EFI_ACCESS_DENIED which is not defined in retval by
UEFI spec, return UNSUPPORTED if device has been locked in
SetTheImage().
Cc: Michael D Kinney
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Star Zeng
Reviewed-by: Michael D Kinney
---
Cc: Ruiyu Ni
Cc: Star Zeng
Cc: Eric Dong
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Michael D Kinney
Reviewed-by: Star Zeng
---
MdeModulePkg/Universal/BdsDxe/BdsDxe.inf | 1 +
MdeModulePkg/Universal/BdsDxe/BdsEntry.c | 12
2 files changed, 13
From: "Zeng, Star"
NOTE: This patch is based on thread
https://lists.01.org/pipermail/edk2-devel/2018-July/027810.html.
Cc: Michael D Kinney
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Star Zeng
Reviewed-by: Michael D Kinney
---
FmpDevicePkg/FmpDevicePkg.dsc | 19
From: Star Zeng
FmpDxe does not consume DisplayUpdateProgressLib, so remove the
mapping in FmpDevicePkg.dsc.
Also rename the ESRT GUIDs.
Cc: Michael D Kinney
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Star Zeng
Reviewed-by: Michael D Kinney
---
From: Star Zeng
Some static tool reports "the condition in 'if' statement is constant".
This patch updates the code to use local variable to store test key
digest size. It can pass the static tool's check.
Cc: Michael D Kinney
Contributed-under: TianoCore Contribution Agreement 1.1
From: Star Zeng
Some static tool reports "DeviceLibLowestSupportedVersion" is used,
but is uninitialized. It is false positive reporting based because
DeviceLibLowestSupportedVersion will have assigned value after
FmpDeviceGetLowestSupportedVersion() returns SUCCESS.
This patch updates the code
From: Star Zeng
Cc: Michael D Kinney
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Star Zeng
Reviewed-by: Michael D Kinney
---
FmpDevicePkg/FmpDxe/FmpDxe.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/FmpDevicePkg/FmpDxe/FmpDxe.c b/FmpDevicePkg/FmpDxe/FmpDxe.c
From: Star Zeng
Cc: Michael D Kinney
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Star Zeng
Reviewed-by: Michael D Kinney
---
FmpDevicePkg/FmpDevicePkg.uni | 22 ++--
FmpDevicePkg/FmpDxe/DetectTestKey.c| 2 +-
From: Star Zeng
Add comment in mFmpDeviceLocked's declaration to make it more clear.
Cc: Michael D Kinney
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Star Zeng
Reviewed-by: Michael D Kinney
---
FmpDevicePkg/FmpDxe/FmpDxe.c | 7 +++
1 file changed, 7
From: Star Zeng
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1040
Use Attributes to know whether reset is required and remove
PcdFmpDeviceSystemResetRequired.
Cc: Michael D Kinney
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Star Zeng
Reviewed-by: Michael D
From: Star Zeng
Cc: Michael D Kinney
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Star Zeng
Reviewed-by: Michael D Kinney
---
FmpDevicePkg/FmpDxe/VariableSupport.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git
From: Star Zeng
It does not make sense to check the Image/ImageSize if ImageIndex
has been invalid.
Cc: Michael D Kinney
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Star Zeng
Reviewed-by: Michael D Kinney
---
FmpDevicePkg/FmpDxe/FmpDxe.c | 19 +--
From: Star Zeng
Fix typo "EFI_SECURITY_VIOLATIO" to "EFI_SECURITY_VIOLATION".
Cc: Michael D Kinney
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Star Zeng
Reviewed-by: Michael D Kinney
---
FmpDevicePkg/FmpDxe/FmpDxe.c | 8
1 file changed, 4 insertions(+), 4
From: Star Zeng
Cc: Michael D Kinney
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Star Zeng
Reviewed-by: Michael D Kinney
---
FmpDevicePkg/FmpDxe/FmpDxe.c | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/FmpDevicePkg/FmpDxe/FmpDxe.c
From: Star Zeng
Add DISABLE_NEW_DEPRECATED_INTERFACES build options to make sure
no deprecated interface used in this package.
Cc: Michael D Kinney
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Star Zeng
Reviewed-by: Michael D Kinney
---
From: Star Zeng
Cc: Michael D Kinney
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Star Zeng
Reviewed-by: Michael D Kinney
---
FmpDevicePkg/FmpDevicePkg.dsc | 2 +-
FmpDevicePkg/FmpDxe/FmpDxe.inf
From: Star Zeng
FmpDxeEntryPoint is used by both FmpDxe and FmpDxeLib.
Cc: Michael D Kinney
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Star Zeng
Reviewed-by: Michael D Kinney
---
FmpDevicePkg/FmpDxe/FmpDxe.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
From: Star Zeng
Current code return 1 when LSV check is not required,
but 1 LSV will make 0 Version capsule image update failed.
0 LSV is valid, this patch updates the code to return 0 when
LSV check is not required
We can see even the DEFAULT_LOWESTSUPPORTEDVERSION is 0.
Cc: Michael D Kinney
https://bugzilla.tianocore.org/show_bug.cgi?id=922
Based on content from the following branch:
https://github.com/Microsoft/MS_UEFI/tree/share/MsCapsuleSupport/MsCapsuleUpdatePkg
Adds a DSC file that is used to verify that all of the
FmpDevicePkg libraries and modules build without error.
Cc:
https://bugzilla.tianocore.org/show_bug.cgi?id=922
Based on content from the following branch:
https://github.com/Microsoft/MS_UEFI/tree/share/MsCapsuleSupport/MsCapsuleUpdatePkg
Add library instances for FmpDeviceLib, CapsuleUpdatePolicyLib,
and FmpPayloadHeaderLib.
Library Classes
Changes in V6
=
* Remove Bool PCD comparison against TRUE in BDS
* Remove useless lib mapping in FmpDevicePkg DSC file
* Fix XCODE build failure due to extra parenthesis
Changes in V4/V5
=
* Return 0 when LSV check is not required
* Remove IPF
* Add
https://bugzilla.tianocore.org/show_bug.cgi?id=922
Based on content from the following branch:
https://github.com/Microsoft/MS_UEFI/tree/share/MsCapsuleSupport/MsCapsuleUpdatePkg
The FmpDxe directory contains 2 INF files. FmpDxe.inf
is a DXE driver that is used in a platform to add a
Firmware
https://bugzilla.tianocore.org/show_bug.cgi?id=922
Based on content from the following branch:
https://github.com/Microsoft/MS_UEFI/tree/share/MsCapsuleSupport/MsCapsuleUpdatePkg
Create FmpDevicePkg with library classes and PCDs used to
customize the behavior of a Firmware Management Protocol
Star,
I have verified that removing the rest of the lib
mappings still builds, so those changes look good.
I have integrated these changes except the ARM/AARCH64
changes into a V6 version of the patch series.
Thanks,
Mike
> -Original Message-
> From: Kinney, Michael D
> Sent:
Star,
Reviewed-by: Michael D Kinney
I have integrated this patch into a V6 patch series.
Mike
> -Original Message-
> From: Zeng, Star
> Sent: Wednesday, August 1, 2018 3:31 AM
> To: edk2-devel@lists.01.org
> Cc: Zeng, Star ; Kinney, Michael D
>
> Subject: [PATCH] FmpDevicePkg FmpDxe:
Star,
I agree. I will integrate into a V6 patch series.
Thanks,
Mike
> -Original Message-
> From: Zeng, Star
> Sent: Wednesday, August 1, 2018 12:53 AM
> To: Kinney, Michael D ;
> edk2-devel@lists.01.org
> Cc: Ni, Ruiyu ; Dong, Eric
> ; Zeng, Star
> Subject: RE: [Patch v5 21/21]
On Tue, Jul 24, 2018 at 03:08:44PM +0800, Ming Huang wrote:
> The major features of this patchset include:
> 1 D06 source code;
> 2 Unify some D0x modules;
>
> This patch set is base on pcihostbridage-v2.
> For compiling D06, add below hunk to edk2-platforms.config
> [d06]
> LONGNAME=HiSilicon
On 08/01/18 19:49, edk2-li...@mc2research.org wrote:
> When including MdePkg/Include/Library/HobLib.h in my project I get errors
> indicating that the following types are undefined:
>
> * EFI_RESOURCE_TYPE, lines 206 and 231
> * EFI_RESOURCE_ATTRIBUTE_TYPE, lines 207 and 232
>
>
>
> A
On 08/01/18 19:50, Ricardo Araújo wrote:
> The commit I was referring to is:
> https://github.com/tianocore/edk2/commit/f15cb995bb3880b77e15afe6facd3da05e599a17
>
> Regards,
>
> Ricardo Araujo -
> www.lsd.ufcg.edu.br/~ricardo
>
> - Mensagem original -
> De: "Ricardo Araújo"
> Para:
The commit I was referring to is:
https://github.com/tianocore/edk2/commit/f15cb995bb3880b77e15afe6facd3da05e599a17
Regards,
Ricardo Araujo -
www.lsd.ufcg.edu.br/~ricardo
- Mensagem original -
De: "Ricardo Araújo"
Para: edk2-devel@lists.01.org
Enviadas: Quarta-feira, 1 de agosto de
When including MdePkg/Include/Library/HobLib.h in my project I get errors
indicating that the following types are undefined:
* EFI_RESOURCE_TYPE, lines 206 and 231
* EFI_RESOURCE_ATTRIBUTE_TYPE, lines 207 and 232
A similar thing is happening with
Hi everyone,
I'm using OVMF with a simulated TPM 2.0 (from
https://github.com/stefanberger/swtpm) and I noticed lately that PCRs 0-7 are
zeroed after booting the vm (ubuntu 18.04) and the only message related to this
in dmesg is:
[ 2.286690] tpm_tis 00:06: 2.0 TPM (device-id 0x1, rev-id 1)
On Thu, Jul 19, 2018 at 04:11:18AM +, Chris Co wrote:
> This adds support for using the SD host controller on
> NXP i.MX platforms.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Christopher Co
> Cc: Ard Biesheuvel
> Cc: Leif Lindholm
> Cc: Michael D Kinney
Star,
The ARM and AARCH64 specific lib mappings should not be removed.
That will break the FmpDevicePkg build for ARM and AARCH64.
Mike
> -Original Message-
> From: Zeng, Star
> Sent: Wednesday, August 1, 2018 3:30 AM
> To: edk2-devel@lists.01.org
> Cc: Zeng, Star ; Kinney, Michael D
>
FmpDxe.c:517:18: error: equality comparison with extraneous
parentheses [-Werror,-Wparentheses-equality]
Cc: Michael D Kinney
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Star Zeng
NOTE: This patch is based on thread
Cc: Michael D Kinney
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Star Zeng
NOTE: This patch is based on thread
https://lists.01.org/pipermail/edk2-devel/2018-July/027810.html.
---
FmpDevicePkg/FmpDevicePkg.dsc | 34 --
1 file changed,
On 08/01/18 03:54, Jiaxin Wu wrote:
> In URI, the colon (:) is used to terminate the HostName path before
> a port number. However, if HostName is expressed as IPv6 format, colon
> characters in IPv6 addresses will conflict with the colon before port
> number. To alleviate this conflict in URI,
On Tue, Jul 31, 2018 at 10:59:22PM +0200, Ard Biesheuvel wrote:
> On 31 July 2018 at 22:56, Leif Lindholm wrote:
> > On Tue, Jul 17, 2018 at 02:05:45AM +, Chris Co wrote:
> >> This debug library provides support for importing symbols to
> >> debug using Lauterbach.
> >>
> >> Derived from:
A very minor comment.
if (PcdGetBool (PcdTestKeyUsed))
can be used directly instead of
if (PcdGetBool (PcdTestKeyUsed) == TRUE)
With update, Reviewed-by: Star Zeng .
Thanks,
Star
-Original Message-
From: Kinney, Michael D
Sent: Wednesday, August 1, 2018 2:55 PM
To:
Reviewed-by: Star Zeng
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Kinney,
Michael D
Sent: Wednesday, August 1, 2018 2:55 PM
To: edk2-devel@lists.01.org
Cc: Kinney, Michael D ; Yao, Jiewen
Subject: [edk2] [Patch v5 04/21] FmpDevicePkg: Add
Reviewed-by: Star Zeng
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Kinney,
Michael D
Sent: Wednesday, August 1, 2018 2:55 PM
To: edk2-devel@lists.01.org
Cc: Kinney, Michael D ; Yao, Jiewen
Subject: [edk2] [Patch v5 02/21] FmpDevicePkg: Add
Reviewed-by: Star Zeng
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Kinney,
Michael D
Sent: Wednesday, August 1, 2018 2:55 PM
To: edk2-devel@lists.01.org
Cc: Kinney, Michael D ; Yao, Jiewen
Subject: [edk2] [Patch v5 01/21] FmpDevicePkg: Add
Reviewed-by: Star Zeng
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Kinney,
Michael D
Sent: Wednesday, August 1, 2018 2:55 PM
To: edk2-devel@lists.01.org
Cc: Kinney, Michael D ; Yao, Jiewen
Subject: [edk2] [Patch v5 03/21] FmpDevicePkg: Add
Reviewed-by: Yonghong Zhu
Best Regards,
Zhu Yonghong
-Original Message-
From: Kinney, Michael D
Sent: Wednesday, August 01, 2018 12:29 AM
To: edk2-devel@lists.01.org
Cc: Sun, Yanyan ; Zhu, Yonghong ;
Gao, Liming ; Kinney, Michael D
Subject: [Patch] BaseTools/BinToPcd: Fix Python
Cc: Ruiyu Ni
Cc: Star Zeng
Cc: Eric Dong
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Michael D Kinney
---
MdeModulePkg/Universal/BdsDxe/BdsDxe.inf | 1 +
MdeModulePkg/Universal/BdsDxe/BdsEntry.c | 12
2 files changed, 13 insertions(+)
diff --git
From: Star Zeng
Cc: Michael D Kinney
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Star Zeng
Reviewed-by: Michael D Kinney
---
FmpDevicePkg/FmpDxe/VariableSupport.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git
From: Star Zeng
Add comment in mFmpDeviceLocked's declaration to make it more clear.
Cc: Michael D Kinney
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Star Zeng
Reviewed-by: Michael D Kinney
---
FmpDevicePkg/FmpDxe/FmpDxe.c | 7 +++
1 file changed, 7
From: Star Zeng
Some static tool reports "DeviceLibLowestSupportedVersion" is used,
but is uninitialized. It is false positive reporting based because
DeviceLibLowestSupportedVersion will have assigned value after
FmpDeviceGetLowestSupportedVersion() returns SUCCESS.
This patch updates the code
From: Star Zeng
Cc: Michael D Kinney
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Star Zeng
Reviewed-by: Michael D Kinney
---
FmpDevicePkg/FmpDevicePkg.uni | 22 ++--
FmpDevicePkg/FmpDxe/DetectTestKey.c| 2 +-
https://bugzilla.tianocore.org/show_bug.cgi?id=922
Based on content from the following branch:
https://github.com/Microsoft/MS_UEFI/tree/share/MsCapsuleSupport/MsCapsuleUpdatePkg
Adds a DSC file that is used to verify that all of the
FmpDevicePkg libraries and modules build without error.
Cc:
From: Star Zeng
It does not make sense to check the Image/ImageSize if ImageIndex
has been invalid.
Cc: Michael D Kinney
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Star Zeng
Reviewed-by: Michael D Kinney
---
FmpDevicePkg/FmpDxe/FmpDxe.c | 19 +--
Changes in V4/V5
=
* Return 0 when LSV check is not required
* Remove IPF
* Add DISABLE_NEW_DEPRECATED_INTERFACES build options
* Check Progress!= NULL before calling Progress(100)
* Add EFI_ABORTED in retval of CheckTheImage()
* Fix typo "EFI_SECURITY_VIOLATIO"
* Add NULL check to
From: Star Zeng
Cc: Michael D Kinney
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Star Zeng
Reviewed-by: Michael D Kinney
---
FmpDevicePkg/FmpDxe/FmpDxe.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/FmpDevicePkg/FmpDxe/FmpDxe.c b/FmpDevicePkg/FmpDxe/FmpDxe.c
From: Star Zeng
Fix typo "EFI_SECURITY_VIOLATIO" to "EFI_SECURITY_VIOLATION".
Cc: Michael D Kinney
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Star Zeng
Reviewed-by: Michael D Kinney
---
FmpDevicePkg/FmpDxe/FmpDxe.c | 8
1 file changed, 4 insertions(+), 4
From: Star Zeng
Cc: Michael D Kinney
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Star Zeng
Reviewed-by: Michael D Kinney
---
FmpDevicePkg/FmpDevicePkg.dsc | 2 +-
FmpDevicePkg/FmpDxe/FmpDxe.inf
From: Star Zeng
FmpDxeEntryPoint is used by both FmpDxe and FmpDxeLib.
Cc: Michael D Kinney
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Star Zeng
Reviewed-by: Michael D Kinney
---
FmpDevicePkg/FmpDxe/FmpDxe.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
From: Star Zeng
Current code return 1 when LSV check is not required,
but 1 LSV will make 0 Version capsule image update failed.
0 LSV is valid, this patch updates the code to return 0 when
LSV check is not required
We can see even the DEFAULT_LOWESTSUPPORTEDVERSION is 0.
Cc: Michael D Kinney
From: Star Zeng
Instead of EFI_ACCESS_DENIED which is not defined in retval by
UEFI spec, return UNSUPPORTED if device has been locked in
SetTheImage().
Cc: Michael D Kinney
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Star Zeng
Reviewed-by: Michael D Kinney
---
From: Star Zeng
Cc: Michael D Kinney
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Star Zeng
Reviewed-by: Michael D Kinney
---
FmpDevicePkg/FmpDxe/FmpDxe.c | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/FmpDevicePkg/FmpDxe/FmpDxe.c
From: Star Zeng
Add DISABLE_NEW_DEPRECATED_INTERFACES build options to make sure
no deprecated interface used in this package.
Cc: Michael D Kinney
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Star Zeng
Reviewed-by: Michael D Kinney
---
From: Star Zeng
Some static tool reports "the condition in 'if' statement is constant".
This patch updates the code to use local variable to store test key
digest size. It can pass the static tool's check.
Cc: Michael D Kinney
Contributed-under: TianoCore Contribution Agreement 1.1
From: Star Zeng
FmpDxe does not consume DisplayUpdateProgressLib, so remove the
mapping in FmpDevicePkg.dsc.
Also rename the ESRT GUIDs.
Cc: Michael D Kinney
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Star Zeng
Reviewed-by: Michael D Kinney
---
https://bugzilla.tianocore.org/show_bug.cgi?id=922
Based on content from the following branch:
https://github.com/Microsoft/MS_UEFI/tree/share/MsCapsuleSupport/MsCapsuleUpdatePkg
The FmpDxe directory contains 2 INF files. FmpDxe.inf
is a DXE driver that is used in a platform to add a
Firmware
From: Star Zeng
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1040
Use Attributes to know whether reset is required and remove
PcdFmpDeviceSystemResetRequired.
Cc: Michael D Kinney
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Star Zeng
Reviewed-by: Michael D
https://bugzilla.tianocore.org/show_bug.cgi?id=922
Based on content from the following branch:
https://github.com/Microsoft/MS_UEFI/tree/share/MsCapsuleSupport/MsCapsuleUpdatePkg
Create FmpDevicePkg with library classes and PCDs used to
customize the behavior of a Firmware Management Protocol
https://bugzilla.tianocore.org/show_bug.cgi?id=922
Based on content from the following branch:
https://github.com/Microsoft/MS_UEFI/tree/share/MsCapsuleSupport/MsCapsuleUpdatePkg
Add library instances for FmpDeviceLib, CapsuleUpdatePolicyLib,
and FmpPayloadHeaderLib.
Library Classes
Update file header to state that the tool does not support:
* Multiple payloads
* Drivers
* Vendor code bytes
https://bugzilla.tianocore.org/show_bug.cgi?id=1031
Cc: Sean Brogan
Cc: Jiewen Yao
Cc: Yonghong Zhu
Cc: Liming Gao
Contributed-under: TianoCore Contribution Agreement 1.1
https://bugzilla.tianocore.org/show_bug.cgi?id=1030
Cc: Sean Brogan
Cc: Jiewen Yao
Cc: Yonghong Zhu
Cc: Liming Gao
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Michael D Kinney
Reviewed-by: Yonghong Zhu
---
BaseTools/Source/Python/Capsule/GenerateCapsule.py | 8
https://bugzilla.tianocore.org/show_bug.cgi?id=945
Based on content from the following branch
https://github.com/Microsoft/MS_UEFI/tree/share/beta/CapsuleTools
* Convert C tools to Python
* Add common python modules to:
BaseTools/Source/Python/Common/Uefi/Capsule
https://bugzilla.tianocore.org/show_bug.cgi?id=1025
Cc: Sean Brogan
Cc: Jiewen Yao
Cc: Yonghong Zhu
Cc: Liming Gao
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Michael D Kinney
Reviewed-by: Yonghong Zhu
---
BaseTools/Source/Python/Capsule/GenerateCapsule.py | 4
https://bugzilla.tianocore.org/show_bug.cgi?id=1046
https://bugzilla.tianocore.org/show_bug.cgi?id=1048
https://bugzilla.tianocore.org/show_bug.cgi?id=1050
Remove raise statements that generate Tracebacks that were only
intended for development/debug. With the raise statements removed
proper
From: Star Zeng
Cc: Michael D Kinney
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Star Zeng
Reviewed-by: Michael D Kinney
---
BaseTools/BinWrappers/PosixLike/GenerateCapsule | 0
1 file changed, 0 insertions(+), 0 deletions(-)
mode change 100644 => 100755
https://bugzilla.tianocore.org/show_bug.cgi?id=945
Based on content from the following branch
https://github.com/Microsoft/MS_UEFI/tree/share/beta/CapsuleTools
Command line unit tests for python modules available from following branch:
Update help to state that --fw-version and -=-lsv are required
for encode operations that sign a payload.
https://bugzilla.tianocore.org/show_bug.cgi?id=1029
Cc: Sean Brogan
Cc: Jiewen Yao
Cc: Yonghong Zhu
Cc: Liming Gao
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by:
https://bugzilla.tianocore.org/show_bug.cgi?id=1024
Cc: Sean Brogan
Cc: Jiewen Yao
Cc: Yonghong Zhu
Cc: Liming Gao
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Michael D Kinney
Reviewed-by: Yonghong Zhu
---
https://bugzilla.tianocore.org/show_bug.cgi?id=1021
https://bugzilla.tianocore.org/show_bug.cgi?id=1022
https://bugzilla.tianocore.org/show_bug.cgi?id=1026
Cc: Sean Brogan
Cc: Jiewen Yao
Cc: Yonghong Zhu
Cc: Liming Gao
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by:
https://bugzilla.tianocore.org/show_bug.cgi?id=1028
Update --dump-info and --decode to show auth header information
even if a payload header is not present. The --decode operation
still fails if a payload header is not present.
Cc: Sean Brogan
Cc: Jiewen Yao
Cc: Yonghong Zhu
Cc: Liming Gao
91 matches
Mail list logo
