Reviewed-by: Chasel Chiu
-Original Message-
From: Zhang, Shenglei
Sent: Thursday, August 16, 2018 1:32 PM
To: edk2-devel@lists.01.org
Cc: Yao, Jiewen ; Chiu, Chasel
Subject: [PATCH 2/5] IntelFsp2Pkg: Remove unused PCDs
The PCDs below are unused, so they have been removed from inf.
gE
The issue was found when heap guard is turned on.
PrintLib somehow receives a non-null terminated string in var-arg.
When the PrintLib implementation reads the string it keeps
reading because no null-terminator is met, which triggers the page
fault set by the heap guard.
The issue is caused by a b
Hi Shenglei,
BaseLib is not belong to MdeModulePkg, please spit it into separated patch.
Thanks,
Star
-Original Message-
From: Zhang, Shenglei
Sent: Thursday, August 16, 2018 1:32 PM
To: edk2-devel@lists.01.org
Cc: Zeng, Star ; Dong, Eric
Subject: [PATCH 1/5] MdeModulePkg: Remove unused
Thanks Ruiyu.
I have some inconsistencies with CMOS regions. Even EDKII uses some CMOS
regions.
I have attached the CMOS dump took using RW tool below:
Type:ISA Port 0070,0071
Width:01
00=56 01=17 02=45 03=17 04=11 05=15 06=04 07=16
08=08 09=18 0A=26 0B=02 0C=50 0D=80 0E=00 0F=00
10=00 11=00
Reviewed-by: Eric Dong
> -Original Message-
> From: Zhang, Shenglei
> Sent: Thursday, August 16, 2018 1:32 PM
> To: edk2-devel@lists.01.org
> Cc: Dong, Eric
> Subject: [PATCH 5/5] UefiCpuPkg: Remove an unused PCD
>
> The PCD below is unused, so it has been removed from inf.
> gUefiCpuPk
Younas,
Why are you still working on CMOS in now UEFI world?
Detailed answer is in below.
Thanks/Ray
> -Original Message-
> From: edk2-devel On Behalf Of
> mohammadyounaskha...@dell.com
> Sent: Thursday, August 16, 2018 12:44 PM
> To: edk2-devel@lists.01.org
> Subject: Re: [edk2] Questio
Reviewed-by: Ruiyu Ni
Thanks/Ray
> -Original Message-
> From: Zhang, Shenglei
> Sent: Thursday, August 16, 2018 1:32 PM
> To: edk2-devel@lists.01.org
> Cc: Carsey, Jaben ; Ni, Ruiyu
> Subject: [PATCH 4/5] ShellPkg: Remove unused PCDs
>
> The PCDs below are unused, so they have been rem
The PCD below is unused, so it has been removed from inf.
gUefiCpuPkgTokenSpaceGuid.PcdCpuFeaturesSupport
Cc: Eric Dong
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: shenglei
---
UefiCpuPkg/Library/CpuCommonFeaturesLib/CpuCommonFeaturesLib.inf | 1 -
1 file changed, 1 d
The PCDs below are unused, so they have been removed from inf.
gEfiSecurityPkgTokenSpaceGuid.PcdTpmBaseAddress
gEfiSecurityPkgTokenSpaceGuid.PcdTpmBaseAddress
gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiDefaultOemId
gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiDefaultOemTableId
gEfiMdeModulePkgTokenSpaceGuid.Pc
A lot of unused PCDs are removed from inf.
shenglei (5):
MdeModulePkg: Remove unused PCDs from inf
IntelFsp2Pkg: Remove unused PCDs
SecurityPkg: Remove unused PCDs
ShellPkg: Remove unused PCDs
UefiCpuPkg: Remove unused PCDs
IntelFsp2Pkg/FspSecCore/FspSecCoreM.inf | 6 ---
The PCDs below are unused, so they have been removed from inf.
gEfiShellPkgTokenSpaceGuid.PcdShellLibAutoInitialize
gEfiShellPkgTokenSpaceGuid.PcdShellMapNameLength
gEfiMdePkgTokenSpaceGuid.PcdUefiLibMaxPrintBufferSize
gEfiMdePkgTokenSpaceGuid.PcdUefiLibMaxPrintBufferSize
gEfiShellPkgTokenSpaceGuid
The PCDs below are unused, so they have been removed from inf.
gEfiMdePkgTokenSpaceGuid.PcdPciExpressBaseAddress
gIntelFsp2PkgTokenSpaceGuid.PcdGlobalDataPointerAddress
gIntelFsp2PkgTokenSpaceGuid.PcdFspMaxPatchEntry
gIntelFsp2PkgTokenSpaceGuid.PcdFspMaxPerfEntry
gEfiMdePkgTokenSpaceGuid.PcdPciExpr
The PCDs below are unused, so they have been removed from inf.
gEfiMdeModulePkgTokenSpaceGuid.PcdCapsuleMax
gEfiMdeModulePkgTokenSpaceGuid.PcdSystemRebootAfterCapsuleProcessFlag
gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeSubClassCapsule
gEfiMdeModulePkgTokenSpaceGuid.PcdCapsuleStatusCodeProcessCap
Hi Guys,
Please help to reply to my below queries.
Thank you,
Younas.
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Pathan,
MohammadYounasKhan
Sent: Tuesday, August 14, 2018 9:17 AM
To: edk2-devel@lists.01.org
Subject: [edk2] FW: Question rega
Return Stack Buffer (RSB) is used to predict the target of RET
instructions. When the RSB underflows, some processors may fall back to
using branch predictors. This might impact software using the retpoline
mitigation strategy on those processors.
This commit will add RSB stuffing logic before ret
V2 changes:
A. Refine commit log message to clarify the purpose of the series
B. Extract the RSB stuffing logic to INC files to avoid code duplication:
When compiling .NASM source files, the current build rule does not support
including files other than the .NASM file directory, this series will
d
Return Stack Buffer (RSB) is used to predict the target of RET
instructions. When the RSB underflows, some processors may fall back to
using branch predictors. This might impact software using the retpoline
mitigation strategy on those processors.
This commit will add RSB stuffing logic before ret
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo
> Ersek
> Sent: Friday, August 10, 2018 11:06 PM
> To: Wu, Hao A; edk2-devel@lists.01.org
> Cc: Yao, Jiewen; Dong, Eric
> Subject: Re: [edk2] [PATCH 0/2] UefiCpuPkg: Add RSB stuffing before
在 8/15/2018 11:27 PM, Leif Lindholm 写道:
> Thanks, this commit message is a lot better.
>
> My only concern with this patch is that the binaries are built with a
> truly ancient toolchain. Is there some particular reason for this?
In internally, we share build server with product project, so we
在 8/15/2018 11:22 PM, Leif Lindholm 写道:
> On Tue, Aug 14, 2018 at 04:04:51PM +0800, Ming Huang wrote:
>> Add Hisilicon Oem Shell libraries for some commands,such as
>> biosupdate, getmac, setmac, provision, acpistartos, brdinfo,
>> sfpinfo.
>>
>> biosupdate example:
>> ifconfig -s eth2 static 192
Replace DwEmmcDxe driver by DwMmcHcDxe driver on HiKey platform. Since
the new driver could work on both eMMC and SD controller.
Cc: Leif Lindholm
Cc: Ard Biesheuvel
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Haojian Zhuang
---
Platform/Hisilicon/HiKey/HiKey.dsc
Changelog:
v2:
* Add more comments in the patch of fixing LDO9_VSET.
v1:
* Enable eMMC/SD driver on HiKey.
* Enable SD driver on HiKey960.
Haojian Zhuang (3):
Silicon/Hi3660: fix LDO9_VSET register definition
Platform/HiKey960: enable SD controller
Platform/HiKey: enable SD/MMC control
Enable DwMmcHcDxe driver on HiKey960 platform.
Cc: Leif Lindholm
Cc: Ard Biesheuvel
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Haojian Zhuang
---
Platform/Hisilicon/HiKey960/HiKey960.dsc | 8 ++
Platform/Hisilicon/HiKey960/HiKey960.fdf
Fixed.
Best Regards
Haojian
From: Leif Lindholm
Sent: Wednesday, August 15, 2018 9:29:27 PM
To: Haojian Zhuang
Cc: edk2-devel@lists.01.org; Ard Biesheuvel
Subject: Re: [edk2][PATCH v1 edk-platforms 1/3] Silicon/Hi3660: fix LDO9_VSET
register definition
Hi
Fix the LDO9_VSET register definition in PMIC. LDO9 is used
by Designware SD controller. Without this fix, SD controller
fails to operate SD card since lack of right voltage setting.
Cc: Leif Lindholm
Cc: Ard Biesheuvel
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Haoji
The function PxeBcFreeBootFileOption that is never called
have been removed.
Cc: Jiaxin Wu
Cc: Siyuan Fu
Cc: Laszlo Ersek
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1064
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Songpeng Li
---
NetworkPkg/UefiPxeBcDxe/Pxe
The function TcpPawsOK that is never called have been removed.
Cc: Jiaxin Wu
Cc: Siyuan Fu
Cc: Laszlo Ersek
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1064
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Songpeng Li
---
NetworkPkg/TcpDxe/TcpOption.c | 32 +-
The definition NetLib has been removed.
Cc: Jiaxin Wu
Cc: Siyuan Fu
Cc: Laszlo Ersek
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1064
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Songpeng Li
---
NetworkPkg/TlsDxe/TlsDxe.inf | 3 +--
1 file changed, 1 insertio
The function IScsiFindTcbByITT that is never called have been removed.
The definition gEfiAcpi20TableGuid has been removed.
Cc: Jiaxin Wu
Cc: Siyuan Fu
Cc: Laszlo Ersek
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1064
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by
The functions that are never called have been removed.
They are Ikev2OnPacketAccepted, Ikev2SaSessionOnDeleting,
Ikev2ChildSaSessionLookupByMid, Ikev2ChildSaSessionOnDeleting
and Ikev2ChildExchangeRekeySpi.
Cc: Jiaxin Wu
Cc: Siyuan Fu
Cc: Laszlo Ersek
Ref: https://bugzilla.tianocore.org/show_bu
Some redundant functions and definitions which are never calld have been
removed. These fuctions are manually searched in source files to make
sure that they are not used elsewhere.
Songpeng Li (5):
NetworkPkg: IScsiDxe: Remove the redundant code and definition.
NetworkPkg: IpSecDxe: Remove t
Hi Marvin & Laszlo,
I'm not very clear about the risk to use this function name. I think it is just
used in a driver as an internal function, other drivers or libraries can't use
it. I think we don't need to add internal prefix to all internal functions in
drivers, maybe need for the libraries,
Reviewed-by: Liming Gao
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Yonghong Zhu
> Sent: Wednesday, August 8, 2018 12:57 AM
> To: edk2-devel@lists.01.org
> Cc: Chen, Hesheng
> Subject: [edk2] [PATCH] BaseTools/Ecc: Fix import issues
>
Thank you Laszlo, for your feedback.
The public document is at
https://software.intel.com/security-software-guidance/insights/host-firmware-speculative-execution-side-channel-mitigation
the "Branch target injection mitigation" section
I agree with you that we should add those info in the commit
Hello,
The tag edk2-stable201808 has been created.
https://github.com/tianocore/edk2/releases/tag/edk2-stable201808
git clone -b edk2-stable201808 https://github.com/tianocore/edk2.git
The main EDK II Wiki page has been updated with a section
for edk2 stable tags.
https://github.co
Laszlo:
Sorry to miss the patch. Thank you to update IntelFrameworkPkg UefiLib. The
change in MdePkg and IntelFrameworkPkg is good to me. Reviewed-by: Liming Gao
> -Original Message-
> From: Laszlo Ersek [mailto:ler...@redhat.com]
> Sent: Wednesday, August 15, 2018 10:21 AM
> To: Gao,
Laszlo:
The patch is good. Reviewed-by: Liming Gao
> -Original Message-
> From: Laszlo Ersek [mailto:ler...@redhat.com]
> Sent: Wednesday, August 15, 2018 10:19 AM
> To: Gao, Liming
> Cc: edk2-devel-01
> Subject: Re: [edk2] [PATCH v2 0/5] BaseTools/Source/C: take EXTRA_OPTFLAGS
> and
On 08/09/18 15:30, Laszlo Ersek wrote:
> On 08/03/18 14:15, Laszlo Ersek wrote:
>> Repo: https://github.com/lersek/edk2.git
>> Branch: open_file_by_devpath_tiano_1008_v2
>>
>> This is version 2 of the patch set that was originally posted at:
>>
>> https://lists.01.org/pipermail/edk2-devel/2018-
Hi Liming,
On 08/09/18 15:22, Laszlo Ersek wrote:
> Repo: https://github.com/lersek/edk2.git
> Branch: extra_flags_rhbz1540244_v2
>
> Version 1 of this set was posted at
>
> 20180726004415.13381-1-lersek@redhat.com">http://mid.mail-archive.com/20180726004415.13381-1-lersek@redhat.com
> htt
Hello,
I have committed the patch and closed the following
issue:
https://bugzilla.tianocore.org/show_bug.cgi?id=1087
I have not seen any additional requests for critical
bug fixes. If I do not see any additional requests
in the next few hours, then I will add the following
tag to edk2/master.
Reviewed-by: Liming Gao
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Zhu,
> Yonghong
> Sent: Wednesday, August 8, 2018 6:26 PM
> To: edk2-devel@lists.01.org
> Cc: Gao, Liming
> Subject: [edk2] [Patch] BaseTools: Update the rule to remove
Reviewed-by: Liming Gao
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Zhu,
> Yonghong
> Sent: Thursday, August 9, 2018 11:49 PM
> To: edk2-devel@lists.01.org
> Cc: Gao, Liming
> Subject: [edk2] [Patch] BaseTools: Remove the redundant if st
On 08/15/18 15:12, Marvin Häuser wrote:
> Hey Eric and anyone CC'd,
>
> Are you sure you want to name the function "AllocateZeroPages"? It's
> analogous to "AllocateZeroPool", so I could see it becoming an API
> function at some point, which will conflict with this definition and
> might silently b
Thanks, this commit message is a lot better.
My only concern with this patch is that the binaries are built with a
truly ancient toolchain. Is there some particular reason for this?
/
Leif
On Tue, Aug 14, 2018 at 04:04:50PM +0800, Ming Huang wrote:
> Description per Module:
> GetInfoFromBmc:
On Tue, Aug 14, 2018 at 04:04:51PM +0800, Ming Huang wrote:
> Add Hisilicon Oem Shell libraries for some commands,such as
> biosupdate, getmac, setmac, provision, acpistartos, brdinfo,
> sfpinfo.
>
> biosupdate example:
> ifconfig -s eth2 static 192.168.2.68 255.255.255.0 192.168.2.1
> biosupdate
On Wed, Jul 25, 2018 at 01:13:20PM +0200, Ard Biesheuvel wrote:
> On 4 July 2018 at 09:49, Ming Huang wrote:
> > Code can also be found in github:
> > https://github.com/hisilicon/OpenPlatformPkg.git
> > branch: edk2-non-osi-20180627-v1
> >
> > Ming Huang (1):
> > Hisilicon/D0x: Fix invoke SetM
在 8/15/2018 9:22 PM, Leif Lindholm 写道:
> On Wed, Aug 15, 2018 at 07:08:33PM +0800, Ming wrote:
> Yes please.
> It would be good if we could have some (common) code to handle the
> fluke situation where you end up without your own MAC address.
> (So that the node can boot up and re
On 08/15/18 15:14, Laszlo Ersek wrote:
> On 08/15/18 04:14, Eric Dong wrote:
>> Because CpuS3Data memory will be copy to smram at SmmReadToLock point by
>> PiSmmCpuDxeSmm driver, the memory type no need to be ACPI NVS type, also the
>> address not limit to below 4G.
>>
>> This change remove the l
For patches 6-7 of this set:
Reviewed-by: Leif Lindholm
Pushed as 478282ea28..28b685af6e.
On Tue, Aug 14, 2018 at 04:08:27PM +0800, Ming Huang wrote:
> The IpmiCmdLib is moved to Silicon/Hisilicon in edk2-non-osi,
> so update D0x dsc to reflect this.
>
> Contributed-under: TianoCore Contributio
For 1-2 of this set:
Reviewed-by: Leif Lindholm
Pushed as b9d09208..5bce5602.
On Tue, Aug 14, 2018 at 04:04:49PM +0800, Ming Huang wrote:
> IpmiCmdLib is used by D0x, so move it to common
> path of Hisilicon.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ming Huan
Hi Haojian,
On Fri, Aug 10, 2018 at 04:49:33PM +0800, Haojian Zhuang wrote:
> Fix the LDO9_VSET register definition in PMIC.
Could you add some more detail to the commit message, please?:
What register was accidentally read/written before?
Does this change resolve a user-visible issue or just a
On Wed, Aug 15, 2018 at 07:08:33PM +0800, Ming wrote:
> >>> Yes please.
> >>> It would be good if we could have some (common) code to handle the
> >>> fluke situation where you end up without your own MAC address.
> >>> (So that the node can boot up and report that it is broken.)
> >>> But it needs
On 08/15/18 04:14, Eric Dong wrote:
> Because CpuS3Data memory will be copy to smram at SmmReadToLock point by
> PiSmmCpuDxeSmm driver, the memory type no need to be ACPI NVS type, also the
> address not limit to below 4G.
>
> This change remove the limit of ACPI NVS memory type and below 4G.
>
On Wed, Aug 15, 2018 at 12:01:25PM +0800, Ming wrote:
>
>
> 在 8/14/2018 11:26 PM, Leif Lindholm 写道:
> > On Fri, Aug 10, 2018 at 09:44:29AM +0800, Ming wrote:
> >>> Which is exactly what an event is for.
> >>> At the point where the SAS controller driver is currently updating the
> >>> variable, i
Hey Eric and anyone CC'd,
Are you sure you want to name the function "AllocateZeroPages"? It's analogous
to "AllocateZeroPool", so I could see it becoming an API function at some
point, which will conflict with this definition and might silently break
UefiCpuPkg compilation if not tested before
On 08/15/18 04:14, Eric Dong wrote:
> Because CpuS3Data memory will be copy to smram at SmmReadyToLock point,
> the memory type no need to be ACPI NVS type, also the address not
> limit to below 4G.
>
> This change remove the limit of ACPI NVS memory type and below 4G.
>
> V4 Changes:
> 1. Create
On 08/15/18 04:14, Eric Dong wrote:
> Current implementation will copy GDT/IDT at SmmReadyToLock point
> from ACPI NVS memory to Smram. Later at S3 resume phase, it restore
> the memory saved in Smram to ACPI NVS. It can directly use GDT/IDT
> saved in Smram instead of restore the original ACPI NVS
On 08/15/18 05:10, Gary Lin wrote:
> Sha384 and Sha512 were added to HashInstanceLib recently. To make them
> available in Tcg2Pei and Tcg2Dxe, we have to link both libraries.
>
> Cc: Ard Biesheuvel
> Cc: Jordan Justen
> Cc: Laszlo Ersek
> Cc: Marc-André Lureau
> Contributed-under: TianoCore C
On 08/14/18 20:37, Kinney, Michael D wrote:
> Leif,
>
> I have no objections to this commit being made before
> the edk2 stable tag.
>
> I see a Bugzilla for this topic as well:
>
> https://bugzilla.tianocore.org/show_bug.cgi?id=1087
>
> I have updated the Bugzilla approving this change
> for e
On 08/15/18 04:05, Zhang, Chao B wrote:
> Hi Laszlo
>8 667abfaf8a16 UefiCpuPkg: Removing ipf which is no longer supported from
> edk2.
>9 df49a85dbcc6 CorebootModulePkg: Removing ipf from edk2.
> 10 04c7f9023ffe CorebootPayloadPkg: Removing ipf from edk2.
> 11 4fcb0d54584f NetworkP
在 8/14/2018 11:48 PM, Leif Lindholm 写道:
> On Tue, Aug 14, 2018 at 10:38:14AM +0800, Ming wrote:
>>
>>
>> 在 8/9/2018 6:19 PM, Leif Lindholm 写道:
>>> On Thu, Aug 09, 2018 at 02:16:49PM +0800, Ming wrote:
>> +UINT16 crc_tab[256] = {
>
> CrcTable.
Modify it in v2.
> Hmm.
On 08/15/18 02:38, Zeng, Star wrote:
> You may try report the FVMAIN_COMPACT with the way like below. Then PeiCore's
> FvInfo notification will decompress the FVMAIN_COMPACT and build FV HOB for
> decompressed FVMAIN for DXE phase. FvInfo is the standard way, FvHob is
> produce for DXE phase. Pe
在 8/14/2018 11:39 PM, Leif Lindholm 写道:
> On Fri, Aug 10, 2018 at 10:46:34AM +0800, Ming wrote:
--- /dev/null
+++ b/Silicon/Hisilicon/Hi1620/Drivers/Apei/Apei.inf
>
+[sources.common]
+ Apei.c
>>>
>>> Apei.h?
>>
>> As Apei.h is included by Apei.c, so I think Apei.h
>> is no n
Hi Leif,
Yes, this patch series could be ignored now.
Best Regards
Haojian
From: Leif Lindholm
Sent: Tuesday, August 14, 2018 4:16 PM
To: Haojian Zhuang
Cc: edk2-devel@lists.01.org; Ard Biesheuvel
Subject: Re: [edk2][PATCH v1 edk-platforms 0/2] Fix missin
Changelog:
v2:
*Split DwMmcHcDxe driver into two patches. One is for PlatformDwMmc protocol,
and the other is for DwMmcHcDxe driver.
v1:
*Add NonDiscoverableDeviceDxe for embedded platform. Make DwMmcHcDxe driver
to support both eMMC and SD controller.
Haojian Zhuang (3):
EmbeddedPkg:
It's used to create NonDiscoverableDevice in embedded platform. Since
there's no PCI bus.
Cc: Leif Lindholm
Cc: Ard Biesheuvel
Cc: Chris Co
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Haojian Zhuang
---
EmbeddedPkg/EmbeddedPkg.dec
Add PlatformDwMmc protocol. It's used to set properties of DwMmc
device in platform driver.
Cc: Leif Lindholm
Cc: Ard Biesheuvel
Cc: Chris Co
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Haojian Zhuang
---
EmbeddedPkg/Include/Protocol/PlatformDwMmc.h | 79 +++
67 matches
Mail list logo
