Re: [edk2] [Patch] SecurityPkg: Fix TPM device compatibility issue

2018-11-09 Thread Ni, Ruiyu
Does it mean the current master code is good enough? Sent from small device > 在 2018年11月10日,上午1:23,Kinney, Michael D 写道: > > Laszlo, > > Given that the compatibility issue has been present > for several months, I would prefer this change be > deferred until after the stable tag. > > We can do

Re: [edk2] [Patch 0/2] Separate semaphore container.

2018-11-09 Thread Dong, Eric
Hi Stewards: Since this is a bug fix, and the risk for this release is small. I plan to push this serial changes before edk2-stable201811 tag. If you have any concern, please raise here. Thanks, Eric > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On

Re: [edk2] [Patch] UefiCpuPkg/RegisterCpuFeaturesLib: Adjust Order.

2018-11-09 Thread Dong, Eric
Hi Stewards: Since this is a bug fix, and the risk for this release is small. I plan to push this change before edk2-stable201811 tag. If you have any concern, please raise here. Thanks, Eric > -Original Message- > From: Ni, Ruiyu > Sent: Friday, November 9, 2018 10:55 PM > To: Dong,

Re: [edk2] [RFC] TPM non-MMIO Access

2018-11-09 Thread Yao, Jiewen
Hi Eugene Complete agree. 1) please ignore TpmCommLib. It is deprecated. :) 2) we did notice there is non-MMIO TPM device before and abstract the device access via Tpm2DeviceLib and Tpm12DeviceLib library class. The Tpm2DeviceLibDTpm and Tpm12DeviceLibDTpm are the library instance f

Re: [edk2] [PATCH 0/4] OvmfPkg: revert some untimely pushed VMW SVGA reverts

2018-11-09 Thread yuchenlin via edk2-devel
On 2018-11-10 03:44, Laszlo Ersek wrote: Repo: https://github.com/lersek/edk2.git Branch: revert_revert_bz_1319 Not much to say here, I've written it up in . One way to verify this series quickly is: $ git diff 62ea70e31285..revert_revert

Re: [edk2] [RFC] TPM non-MMIO Access

2018-11-09 Thread Yao, Jiewen
Hi Eugene The TpmIoLib proposal is similar to the existing TpmDeviceLib. We have I2C TPM instance as example. You may create Tpm12DeviceLibXXXSpi. Please let us know if there is any gap to support your non-MMIO device. Thank you Yao Jiewen From: Yao, Jiewen Sent: Saturday, November 10, 2018 7:1

[edk2] [platforms: PATCH v4 6/7] Marvell/Drivers: MvBoardDesc: Extend information for SdMmc

2018-11-09 Thread Marcin Wojtas
From: Tomasz Michalec Extend MvBoardDescSdMmcGet function to fill MV_BOARD_SDMMC_DESC with Xenon specific info obtained from ArmadaBoardDescLib. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marcin Wojtas --- Silicon/Marvell/Drivers/BoardDesc/MvBoardDescDxe.inf | 1 +

[edk2] [platforms: PATCH v4 5/7] Marvell/Armada80x0Db: Introduce board description library

2018-11-09 Thread Marcin Wojtas
From: Tomasz Michalec This patch implements ArmadaBoarDescLib library for Armada8040 Development Board and add to it ArmadaBoardDescSdMmcGet function with description of connected Xenon host controllers. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marcin Wojtas --- P

[edk2] [platforms: PATCH v4 4/7] Marvell/Armada70x0Db: Introduce board description library

2018-11-09 Thread Marcin Wojtas
From: Tomasz Michalec This patch implements ArmadaBoarDescLib library for Armada7040 Development Board and add to it ArmadaBoardDescSdMmcGet function with description of connected Xenon host controllers. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marcin Wojtas --- P

[edk2] [platforms: PATCH v4 3/7] SolidRun/Armada80x0McBin: Introduce board description library

2018-11-09 Thread Marcin Wojtas
From: Tomasz Michalec This patch implements ArmadaBoarDescLib library for Armada80x0McBin comunity board and add to it ArmadaBoardDescSdMmcGet function with description of connected Xenon host controllers. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marcin Wojtas ---

[edk2] [platforms: PATCH v4 2/7] Marvell/Library: ArmadaBoardDescLib: Extend SDMMC information

2018-11-09 Thread Marcin Wojtas
From: Tomasz Michalec Added fields specific for Xenon host controller and declaration of ArmadaBoardDescSdMmcGet function. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marcin Wojtas --- Silicon/Marvell/Include/Library/ArmadaBoardDescLib.h | 22 +++- 1

[edk2] [platforms: PATCH v4 1/7] Silicon/SynQuacer/PlatformDxe: adjust to updated SdMmcOverride

2018-11-09 Thread Marcin Wojtas
The newest changes in the SdMmcOverride protocol added additional arguments to the NotifyPhase and Capability routines. Update according places in the Synquacer Emmc driver. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marcin Wojtas --- Silicon/Socionext/SynQuacer/Drive

[edk2] [platforms: PATCH v4 0/7] Armada7k8k Xenon driver rework

2018-11-09 Thread Marcin Wojtas
Hi, The fourth version of the patchset removes dependency on the internal MdeModulePkg header and reworks Capability callback handling. Details can be found in the changelog below. Patches are available in the github: https://github.com/MarvellEmbeddedProcessors/edk2-open-platform/commits/xenon-u

[edk2] [PATCH v4 4/4] MdeModulePkg/SdMmcPciHcDxe: Allow overriding base clock frequency

2018-11-09 Thread Marcin Wojtas
Some SdMmc host controllers are run by clocks with different frequency than it is reflected in Capabilities Register 1. It is allowed by SDHCI specification ver. 4.2 - if BaseClkFreq field value of the Capability Register 1 is zero, the clock frequency must be obtained via another method. Because

[edk2] [PATCH v4 3/4] MdeModulePkg/SdMmcPciHcDxe: Add SwitchClockFreqPost to SdMmcOverride

2018-11-09 Thread Marcin Wojtas
From: Tomasz Michalec Some SD Host Controlers need to do additional opperations after clock frequency switch. This patch add new callback type to NotifyPhase of the SdMmcOverride protocol. It is called after SdMmcHcClockSupply. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-

[edk2] [PATCH v4 2/4] MdeModulePkg/SdMmcPciHcDxe: Add UhsSignaling to SdMmcOverride protocol

2018-11-09 Thread Marcin Wojtas
From: Tomasz Michalec Some SD Host Controllers use different values in Host Control 2 Register to select UHS Mode. This patch adds a new UhsSignaling type routine to the NotifyPhase of the SdMmcOverride protocol. UHS signaling configuration is moved to a common, default routine (SdMmcHcUhsSignal

[edk2] [PATCH v4 1/4] MdeModulePkg/SdMmcPciHcDxe: Add an optional parameter in NotifyPhase

2018-11-09 Thread Marcin Wojtas
In order to ensure bigger flexibility in the NotifyPhase routine of the SdMmcOverride protocol, enable using an optional phase-specific data. This will allow to exchange more information between the protocol producer driver and SdMmcPciHcDxe in the newly added callbacks. Contributed-under: TianoCo

[edk2] [PATCH v4 0/4] SdMmcOverride extension

2018-11-09 Thread Marcin Wojtas
Hi, Although I could've waited for Hao's remarks, I think it may be better if he takes a look at much cleaner code, which addresses v3 review comments. The newest version of the patchset cleans-up significantly patches 2&3 by removing code duplication and other minor improvements. Patches are ava

[edk2] [RFC] TPM non-MMIO Access

2018-11-09 Thread Cohen, Eugene
Dear SecurityPkg maintainers, We are trying to use the SecurityPkg TPM support (Tcg2Config, Tpm2DeviceLibDTpm, etc) and see that access to the TPM are using the MMIO routines such as MmioRead8(). Not all platforms support memory-mapped access to the TPM so we would like to propose that we crea

Re: [edk2] [PATCH] ArmPkg/ArmScmiDxe: Add clock enable function

2018-11-09 Thread Sami Mujawar
-Original Message- From: Leif Lindholm Sent: 09 November 2018 06:49 PM To: Jeff Brasen Cc: edk2-devel@lists.01.org; Ard Biesheuvel ; Girish Pathak ; Sami Mujawar Subject: Re: [PATCH] ArmPkg/ArmScmiDxe: Add clock enable function On Fri, Nov 09, 2018 at 06:35:02PM +, Jeff Brasen wro

Re: [edk2] [PATCH 0/4] OvmfPkg: revert some untimely pushed VMW SVGA reverts

2018-11-09 Thread Ard Biesheuvel
> On 9 Nov 2018, at 20:44, Laszlo Ersek wrote: > > Repo: https://github.com/lersek/edk2.git > Branch: revert_revert_bz_1319 > > Not much to say here, I've written it up in > . > > One way to verify this series quickly is: > >> $ git diff

Re: [edk2] [patch] MdeModulePkg/DisplayEngine: Remove useless NULL ptr check for NewPos

2018-11-09 Thread Laszlo Ersek
On 11/09/18 18:49, Kinney, Michael D wrote: > Laszlo, > > I added EDK2|Documentation|Wiki Pages > > I also updated the sort order so Wiki Pages is > first, followed by maintained GitBook documents > sorted alphabetically, with "Other Document" last. Thanks, Mike! I've filed

Re: [edk2] [PATCH 0/4] OvmfPkg: revert some untimely pushed VMW SVGA reverts

2018-11-09 Thread Philippe Mathieu-Daudé
On 9/11/18 20:44, Laszlo Ersek wrote: Repo: https://github.com/lersek/edk2.git Branch: revert_revert_bz_1319 Not much to say here, I've written it up in . One way to verify this series quickly is: $ git diff 62ea70e31285..revert_revert_bz

[edk2] [PATCH 0/4] OvmfPkg: revert some untimely pushed VMW SVGA reverts

2018-11-09 Thread Laszlo Ersek
Repo: https://github.com/lersek/edk2.git Branch: revert_revert_bz_1319 Not much to say here, I've written it up in . One way to verify this series quickly is: > $ git diff 62ea70e31285..revert_revert_bz_1319 -- OvmfPkg/ > [nothing] Thanks,

[edk2] [PATCH 1/4] Reapply "OvmfPkg: VMWare SVGA display device register definitions"

2018-11-09 Thread Laszlo Ersek
This reverts commit 328409ce8de7f318ee9c929b64302bd361cd1dbd, reapplying 9bcca53fe466cdff397578328d9d87d257aba493. Note that the commit now being reverted is technically correct; the only reason we're reverting it is because it should not have been pushed past the Soft Feature Freeze for the edk2-

[edk2] [PATCH 3/4] Reapply "OvmfPkg/QemuVideoDxe: VMWare SVGA device support"

2018-11-09 Thread Laszlo Ersek
This reverts commit 98856a724c2acdc0094220d4de615a557dad0f88, reapplying c137d95081690d4877fbeb5f1856972e84ac32f2. Note that the commit now being reverted is technically correct; the only reason we're reverting it is because it should not have been pushed past the Soft Feature Freeze for the edk2-

[edk2] [PATCH 4/4] Reapply "OvmfPkg/QemuVideoDxe: list "UnalignedIoInternal.h" in the INF file"

2018-11-09 Thread Laszlo Ersek
This reverts commit e038bde2679bbd200086c25ab43090ad3b8b25a3, reapplying b2959e9f1a57279506ca46d56bc424fd7fa6b62a. Note that the commit now being reverted is technically correct; the only reason we're reverting it is because it should not have been pushed past the Soft Feature Freeze for the edk2-

[edk2] [PATCH 2/4] Reapply "OvmfPkg/QemuVideoDxe: Helper functions for unaligned port I/O."

2018-11-09 Thread Laszlo Ersek
This reverts commit 438ada5aa5a1174940795678c2dae07cde8f3869, reapplying 05a5379458725234de8a05780fcb5da2c12680e4. Note that the commit now being reverted is technically correct; the only reason we're reverting it is because it should not have been pushed past the Soft Feature Freeze for the edk2-

Re: [edk2] [urgent] Soft Feature Freeze has started since Nov.1 for dk2-stable201811

2018-11-09 Thread Laszlo Ersek
On 11/09/18 20:08, Phil Dennis-Jordan wrote: > Hi Laszlo, > > On Fri, Nov 9, 2018 at 5:47 PM Laszlo Ersek wrote: >> >> + Yuchenlin, + Gerd, + both Phils >> >> On 11/07/18 20:13, Laszlo Ersek wrote: >> > For example, I reviewed and pushed 4 patches yesterday (on 2018-Nov-06): > > 1

Re: [edk2] [urgent] Soft Feature Freeze has started since Nov.1 for dk2-stable201811

2018-11-09 Thread Phil Dennis-Jordan
Hi Laszlo, On Fri, Nov 9, 2018 at 5:47 PM Laszlo Ersek wrote: > > + Yuchenlin, + Gerd, + both Phils > > On 11/07/18 20:13, Laszlo Ersek wrote: > > >>> For example, I reviewed and pushed 4 patches yesterday (on 2018-Nov-06): > >>> > >>> 1 e038bde2679b Revert "OvmfPkg/QemuVideoDxe: list > >>> "

Re: [edk2] [PATCH] ArmPkg/ArmScmiDxe: Add clock enable function

2018-11-09 Thread Leif Lindholm
On Fri, Nov 09, 2018 at 06:35:02PM +, Jeff Brasen wrote: > > 1. Add new ArmScmiClock2Protocol.h + guid > > 2. Add new guid and document that you have to use that guid for the > > enable function > > 3. Add new guid under old name and have the old guid installed on > > the handle

Re: [edk2] [PATCH] ArmPkg/ArmScmiDxe: Add clock enable function

2018-11-09 Thread Jeff Brasen
From: Leif Lindholm Sent: Friday, November 9, 2018 11:30 AM To: Jeff Brasen Cc: edk2-devel@lists.01.org; Ard Biesheuvel; Grish Pathak; Sami Mujawar Subject: Re: [PATCH] ArmPkg/ArmScmiDxe: Add clock enable function On Fri, Nov 09, 2018 at 05:03:53PM +, Jeff

Re: [edk2] [PATCH] ArmPkg/ArmScmiDxe: Add clock enable function

2018-11-09 Thread Leif Lindholm
On Fri, Nov 09, 2018 at 05:03:53PM +, Jeff Brasen wrote: > > From: Leif Lindholm > Sent: Friday, November 9, 2018 7:09 AM > To: Jeff Brasen > Cc: edk2-devel@lists.01.org; Ard Biesheuvel; Grish Pathak; Sami Mujawar > Subject: Re: [PATCH] ArmPkg/ArmScmiDxe: Add c

Re: [edk2] [urgent] Soft Feature Freeze has started since Nov.1 for dk2-stable201811

2018-11-09 Thread Leif Lindholm
Hi Laszlo, On Fri, Nov 09, 2018 at 05:46:47PM +0100, Laszlo Ersek wrote: > + Yuchenlin, + Gerd, + both Phils > > On 11/07/18 20:13, Laszlo Ersek wrote: > > >>> For example, I reviewed and pushed 4 patches yesterday (on 2018-Nov-06): > >>> > >>> 1 e038bde2679b Revert "OvmfPkg/QemuVideoDxe: lis

Re: [edk2] [PATCH edk2-staging 00/19] IntelUndiPkg/GigUndiDxe: build fixes for AARCH64/ARM/GCC

2018-11-09 Thread Ard Biesheuvel
On 9 November 2018 at 18:54, Knop, Ryszard wrote: > Hey Ard, I'm from the Preboot team responsible for this component. We're too > busy to review and merge this at the moment, so this'll have to stay on the > list for now, but we'll come back to it in a few weeks once we've finished > some of o

Re: [edk2] [PATCH edk2-staging 00/19] IntelUndiPkg/GigUndiDxe: build fixes for AARCH64/ARM/GCC

2018-11-09 Thread Knop, Ryszard
Hey Ard, I'm from the Preboot team responsible for this component. We're too busy to review and merge this at the moment, so this'll have to stay on the list for now, but we'll come back to it in a few weeks once we've finished some of our current tasks. Thanks, Richard. -Original Message--

Re: [edk2] [patch] MdeModulePkg/DisplayEngine: Remove useless NULL ptr check for NewPos

2018-11-09 Thread Kinney, Michael D
Laszlo, I added EDK2|Documentation|Wiki Pages I also updated the sort order so Wiki Pages is first, followed by maintained GitBook documents sorted alphabetically, with "Other Document" last. Thanks, Mike > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Frid

Re: [edk2] [patch] MdeModulePkg/DisplayEngine: Remove useless NULL ptr check for NewPos

2018-11-09 Thread Laszlo Ersek
On 11/09/18 18:14, Kinney, Michael D wrote: > Hi Laszlo, > > There is already a "Documentation" component under > EDK2 in BZ. Can we use that and identify the target > of the documentation change is in a Wiki page? Absolutely. > When you select "Documentation" there is a drop down > for "Tianoc

Re: [edk2] [Patch] SecurityPkg: Fix TPM device compatibility issue

2018-11-09 Thread Kinney, Michael D
Laszlo, Given that the compatibility issue has been present for several months, I would prefer this change be deferred until after the stable tag. We can document this as a known issue in the release page for the stable tag and point to the commit after the stable tag that resolves the compatibil

Re: [edk2] [edk2-wiki PATCH] release planning: announce the soft and hard feature freezes

2018-11-09 Thread Laszlo Ersek
On 11/09/18 18:07, Kinney, Michael D wrote: > Perhaps we should update Maintainers.txt with some lines > that identify the developers that are currently assigned > to the release/release planning role. That way, the Wiki > can reference Maintainters.txt and we can update > Maintainers.txt as the a

[edk2] [PATCH] MdeModulePkg/SdDxe: Fix potential NULL pointer access

2018-11-09 Thread Jeff Brasen
SdReadWrite can be called with a NULL Token for synchronous operations. Add guard for DEBUG print to only print event pointer with Token is not NULL. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jeff Brasen --- MdeModulePkg/Bus/Sd/SdDxe/SdBlockIo.c | 7 +-- 1 file c

Re: [edk2] [patch] MdeModulePkg/DisplayEngine: Remove useless NULL ptr check for NewPos

2018-11-09 Thread Kinney, Michael D
Hi Laszlo, There is already a "Documentation" component under EDK2 in BZ. Can we use that and identify the target of the documentation change is in a Wiki page? When you select "Documentation" there is a drop down for "Tianocore documents" that lists the documents published through GitBook along

Re: [edk2] [edk2-wiki PATCH] release planning: announce the soft and hard feature freezes

2018-11-09 Thread Kinney, Michael D
Perhaps we should update Maintainers.txt with some lines that identify the developers that are currently assigned to the release/release planning role. That way, the Wiki can reference Maintainters.txt and we can update Maintainers.txt as the assignments change over time. Thanks, Mike > -Or

Re: [edk2] [PATCH] ArmPkg/ArmScmiDxe: Add clock enable function

2018-11-09 Thread Jeff Brasen
From: Leif Lindholm Sent: Friday, November 9, 2018 7:09 AM To: Jeff Brasen Cc: edk2-devel@lists.01.org; Ard Biesheuvel; Grish Pathak; Sami Mujawar Subject: Re: [PATCH] ArmPkg/ArmScmiDxe: Add clock enable function Hi Jeff, On Thu, Nov 08, 2018 at 10:50:44AM -0

Re: [edk2] [Patch] BaseTools: Optimize string concatenation

2018-11-09 Thread Kinney, Michael D
Liming, If we can support both Python2 and Python3 equally, then I agree that these types of performance enhancements can be added to edk2/master after the stable tag. Let's make sure we enter a BZ for each performance improvement and as Leif has asked, put evidence of the performance improvement

[edk2] [urgent] Soft Feature Freeze has started since Nov.1 for dk2-stable201811

2018-11-09 Thread Laszlo Ersek
+ Yuchenlin, + Gerd, + both Phils On 11/07/18 20:13, Laszlo Ersek wrote: >>> For example, I reviewed and pushed 4 patches yesterday (on 2018-Nov-06): >>> >>> 1 e038bde2679b Revert "OvmfPkg/QemuVideoDxe: list >>> "UnalignedIoInternal.h" in the INF file" >>> 2 98856a724c2a Revert "OvmfPkg/Qe

Re: [edk2] [patch] MdeModulePkg/DisplayEngine: Remove useless NULL ptr check for NewPos

2018-11-09 Thread Laszlo Ersek
On 11/09/18 17:01, Leif Lindholm wrote: > On Fri, Nov 09, 2018 at 03:32:03PM +, Gao, Liming wrote: >> Laszlo and Leif: >> I suggest to continue to update wiki page with more >> information. If so, we can avoid such case again. > > Agreed, we need to be able to interpret what the process sa

Re: [edk2] [PATCH v2 edk2-platforms 1/5] Platform/ARM/Sgi: Adapt to changes in system-id DT node.

2018-11-09 Thread Leif Lindholm
On Mon, Nov 05, 2018 at 02:56:55PM +0530, Chandni Cherukuri wrote: > The 'system-id' node of HW_CONFIG device tree has been updated to have > a new property 'config-id' to hold the platform configuration value. > Prior to this, configuration ID value was represented by the the upper > four bits of

Re: [edk2] [edk2-wiki PATCH] release planning: announce the soft and hard feature freezes

2018-11-09 Thread Laszlo Ersek
On 11/09/18 16:09, Gao, Liming wrote: > Laszlo: > Can ';' be removed from below sentence? > > an announcement email is sent to the edk2-devel mailing list; by default by > Liming Gao. > > ==> > > an announcement email is sent to the edk2-devel mailing list by default by > Liming Gao. Hmm I

Re: [edk2] [Patch] SecurityPkg: Fix TPM device compatibility issue

2018-11-09 Thread Laszlo Ersek
meta: On 11/09/18 16:55, Leif Lindholm wrote: > On Fri, Nov 09, 2018 at 02:46:40PM +, Zhang, Chao B wrote: >> Hi Leif: >>The NTC1310 can work well with previous EDK2 stable version >>(UDK2018). Interface Cache is a new feature introduced after >>UDK2018. >> So far as we see, it cau

Re: [edk2] [Patch] SecurityPkg: Fix TPM device compatibility issue

2018-11-09 Thread Laszlo Ersek
On 11/09/18 15:46, Zhang, Chao B wrote: > Hi Leif: >The NTC1310 can work well with previous EDK2 stable version (UDK2018). That's not correct. The last EDK2 stable version is not UDK2018. The last stable EDK2 version is "edk2-stable201808", and the regression (commit f15cb995bb38, according to

Re: [edk2] [patch] MdeModulePkg/DisplayEngine: Remove useless NULL ptr check for NewPos

2018-11-09 Thread Leif Lindholm
On Fri, Nov 09, 2018 at 03:32:03PM +, Gao, Liming wrote: > Laszlo and Leif: > I suggest to continue to update wiki page with more > information. If so, we can avoid such case again. Agreed, we need to be able to interpret what the process says identically. > For this change, it has no r

Re: [edk2] [Patch] SecurityPkg: Fix TPM device compatibility issue

2018-11-09 Thread Leif Lindholm
On Fri, Nov 09, 2018 at 02:46:40PM +, Zhang, Chao B wrote: > Hi Leif: >The NTC1310 can work well with previous EDK2 stable version >(UDK2018). Interface Cache is a new feature introduced after >UDK2018. > So far as we see, it causes NTC1310 fail to work. OK, in that case I am willi

Re: [edk2] [patch] MdeModulePkg/DisplayEngine: Remove useless NULL ptr check for NewPos

2018-11-09 Thread Gao, Liming
Laszlo and Leif: I suggest to continue to update wiki page with more information. If so, we can avoid such case again. For this change, it has no real functionality impact. If you think roll back is better than keep it, I am OK. Thanks Liming > -Original Message- > From: edk2-deve

Re: [edk2] [Patch V2] BaseTools: Replace the sqlite database with list

2018-11-09 Thread Carsey, Jaben
This is much easier to review! Thanks! I am good with the code change. I wonder: If we do not have the DB does it take longer if I do build, clean, build than it did before? > -Original Message- > From: Feng, Bob C > Sent: Friday, November 09, 2018 12:42 AM > To: edk2-devel@lists.01.org

Re: [edk2] [PATCH] BaseTools: Enable Pcd Array support.

2018-11-09 Thread Carsey, Jaben
How concerned with spaces in the DSC lines are we? The following looks very sensitive to spaces and could be replaced with a regular expression that would be more flexible. if "{CODE(" not in PcdValue: aprox: if re.match('[{]\w*CODE\w*[(]', PcdValue) > -Original Message- > From: edk2-

Re: [edk2] [edk2-wiki PATCH] release planning: announce the soft and hard feature freezes

2018-11-09 Thread Gao, Liming
Laszlo: Can ';' be removed from below sentence? an announcement email is sent to the edk2-devel mailing list; by default by Liming Gao. ==> an announcement email is sent to the edk2-devel mailing list by default by Liming Gao. Thanks Liming > -Original Message- > From: Leif Lindholm

Re: [edk2] [Patch] UefiCpuPkg/RegisterCpuFeaturesLib: Adjust Order.

2018-11-09 Thread Ni, Ruiyu
Eric, Thanks for fixing the new found issues. Reviewed-by: Ruiyu Ni > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Eric > Dong > Sent: Friday, November 9, 2018 1:21 PM > To: edk2-devel@lists.01.org > Cc: Ni, Ruiyu ; Laszlo Ersek > Subject:

Re: [edk2] [Patch] SecurityPkg: Fix TPM device compatibility issue

2018-11-09 Thread Zhang, Chao B
Hi Leif: The NTC1310 can work well with previous EDK2 stable version (UDK2018). Interface Cache is a new feature introduced after UDK2018. So far as we see, it causes NTC1310 fail to work. From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Leif Lindholm Sent: Friday, Novem

Re: [edk2] [Patch] SecurityPkg: Fix TPM device compatibility issue

2018-11-09 Thread Zhang, Chao B
Hi All: Let me introduce more background. We enabled Interface type Cache feature because it complies with TCG PTP 1.03 spec (also earlier PTP 00.43) and reduces traffic to communicate with TPM. It by chance addresses defect within some TPM2.0 device that frequent touching InterfaceID regis

[edk2] Edk2 2019 Q1 stable tag planning is added into EDK-II-Release-Planning wiki

2018-11-09 Thread Gao, Liming
Hi, all Next edk2 stable tag planning has been added into EDK-II-Release-Planning wiki https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Release-Planning. Please review the proposed schedule. The proposed features are not finalized. If you know any feature will be ready, please pro

Re: [edk2] [Patch] BaseTools: Optimize string concatenation

2018-11-09 Thread Gao, Liming
Mike: This patch bases on edk2 master with Python27. Seemly, most people are not aware that Python3 migration (https://bugzilla.tianocore.org/show_bug.cgi?id=55) is added for next edk2-stable201903 tag planning. In BZ 55, I propose to keep Python2 and Python3 both, and new feature and patches

Re: [edk2] [PATCH] ArmPkg/ArmScmiDxe: Add clock enable function

2018-11-09 Thread Leif Lindholm
Hi Jeff, On Thu, Nov 08, 2018 at 10:50:44AM -0700, Jeff Brasen wrote: > Add function to allow enabling and disabling of the clock using the SCMI > interface. Update the protocol GUID as the protocol interface has > changed. Changing a protocol GUID for an interface update feels a bit un-idiomatic

Re: [edk2] [PATCH v2 2/2] Edk2Platforms: Replace MdeModulePkg PXE/iSCSI/TCP with NetworkPkg drivers.

2018-11-09 Thread Thomas Abraham
On Wed, Nov 7, 2018 at 1:55 PM Leif Lindholm wrote: > > Hi Fu Siyan, > > On Wed, Nov 07, 2018 at 08:12:55AM +, Fu, Siyuan wrote: > > Hi, Leif and Ard > > > > I just realized that you may not be CCed in this email. I resent these > > patches a few minutes ago, my Git Bash send-email reports it

Re: [edk2] [PATCH v2 7/7] ArmPkg: Extra action to update permissions for S-ELO MM Image

2018-11-09 Thread Achin Gupta
Hi Ard, Just a polite poke that Sughosh had posted the patches as I had described below here [1] & here [2]. Please let us know what you think. cheers, Achin [1] https://lists.01.org/pipermail/edk2-devel/2018-October/031377.html [2] https://lists.01.org/pipermail/edk2-devel/2018-October/031384.h

Re: [edk2] [PATCH v2 edk2-platforms] Silicon/SynQuacerPciCpuIo2Dxe: fix PCIe I/O translation

2018-11-09 Thread Leif Lindholm
On Fri, Nov 09, 2018 at 08:58:48AM +0100, Ard Biesheuvel wrote: > Commit 9dd8190e4995 ("Silicon/SynQuacer: tweak PCI I/O windows for > ACPI/Linux support") updated the min/max/offset definitions for the > PCIe I/O resource windows on SynQuacer, and updated the read path of > the platform's EfiCpu

Re: [edk2] [Patch] BaseTools: Optimize string concatenation

2018-11-09 Thread Leif Lindholm
Hi Bob, On Fri, Nov 09, 2018 at 03:25:04AM +, Feng, Bob C wrote: > Yes. I should show the data. > > My unites scripts is as below. The parameter lines is a string list which > size is 43395. The test result is > > ''.join(String list) time: 0.042262 > String += String time : 3.822699 >

Re: [edk2] [Patch] SecurityPkg: Fix TPM device compatibility issue

2018-11-09 Thread Leif Lindholm
On Fri, Nov 09, 2018 at 09:04:46AM +0100, Laszlo Ersek wrote: > On 11/09/18 07:02, Zhang, Chao B wrote: > > Issue Statement: > > TPM InterfaceId cache feature is introduced by > > f15cb995bb3880b77e15afe6facd3da05e599a17. It follows TCG PTP spec 1.3 > > to improve TPM transmission performance and

Re: [edk2] [patch] MdeModulePkg/DisplayEngine: Remove useless NULL ptr check for NewPos

2018-11-09 Thread Laszlo Ersek
On 11/09/18 11:49, Leif Lindholm wrote: > On Fri, Nov 09, 2018 at 07:56:07AM +0100, Ard Biesheuvel wrote: >> On 9 November 2018 at 01:19, Gao, Liming wrote: >>> Ard: >>> This is a small fix. And, this patch is sent before the hard >>> freeze. It is the low risk for this release. So, I push it.

Re: [edk2] [patch] MdeModulePkg/DisplayEngine: Remove useless NULL ptr check for NewPos

2018-11-09 Thread Leif Lindholm
On Fri, Nov 09, 2018 at 07:56:07AM +0100, Ard Biesheuvel wrote: > On 9 November 2018 at 01:19, Gao, Liming wrote: > > Ard: > > This is a small fix. And, this patch is sent before the hard > > freeze. It is the low risk for this release. So, I push it. > > OK, fair enough. I don't agree actua

Re: [edk2] [edk2-wiki PATCH] release planning: announce the soft and hard feature freezes

2018-11-09 Thread Leif Lindholm
On Thu, Nov 08, 2018 at 06:28:07PM +0100, Laszlo Ersek wrote: > Add a paragraph to each of the SoftFeatureFreeze and HardFeatureFreeze > articles about the respective announcements on edk2-devel. > > Cc: Andrew Fish > Cc: Brian Richardson > Cc: Leif Lindholm > Cc: Liming Gao > Cc: Michael Kinn

[edk2] [Patch][edk2-platforms/devel-IntelAtomProcessorE3900] Change BIOS Version.

2018-11-09 Thread zwei4
From: Bright Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Sun, Zailiang CC: David Wei --- Vlv2TbltDevicePkg/BiosId.env | 2 +- Vlv2TbltDevicePkg/BiosIdD.env| 2 +- Vlv2TbltDevicePkg/BiosIdR.env| 2 +- Vlv2TbltDevicePkg/BiosIdx64D.env | 2 +- Vlv2TbltDevice

[edk2] [Patch V2] BaseTools: Replace the sqlite database with list

2018-11-09 Thread BobCF
https://bugzilla.tianocore.org/show_bug.cgi?id=1288 [V2] Optimize this patch so that it can be easy to review. This patch is just apply the change to original files while not create new similar files. [V1] This patch is one of build tool performance improvement series patches. This patch is goin

Re: [edk2] [Patch 2/2] UefiCpuPkg/PiSmmCpuDxeSmm: Separate semaphore container.

2018-11-09 Thread Ni, Ruiyu
Eric, Similar comments suggestion to this patch. Reviewed-by: Ruiyu Ni -- Thanks, Ray ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [Patch 1/2] UefiCpuPkg/RegisterCpuFeaturesLib: Separate semaphore container.

2018-11-09 Thread Ni, Ruiyu
Eric, Patch is good. Reviewed-by: Ruiyu Ni Some modification to commit message to help understanding the changes. Please rewording if you think some of them is not proper. You can push the changes if no concerns about the new commit message. - In current implementation, core and package l

Re: [edk2] [Patch] SecurityPkg: Fix TPM device compatibility issue

2018-11-09 Thread Laszlo Ersek
On 11/09/18 07:02, Zhang, Chao B wrote: > Issue Statement: > TPM InterfaceId cache feature is introduced by > f15cb995bb3880b77e15afe6facd3da05e599a17. It follows TCG PTP spec 1.3 > to improve TPM transmission performance and also addresses defects in some > TPM2.0 devices. But some other TPM dev

Re: [edk2] [patch] MdePkg: Fix incorrect check for DisplayOnly text format in AcpiEx

2018-11-09 Thread Laszlo Ersek
On 11/09/18 04:34, Bi, Dandan wrote: > Hi Stewards and package maintainers: > > Since this is a clear bug. And the risk for this release is small. > So I plan to push this patch before edk2-stable201811 tag is created. I agree, this is a bugfix, not a feature patch. Thanks, Laszlo > If you hav

Re: [edk2] [Patch] Maintainers.txt: Update EDK II Releases to EDK-II-Release-Planning wiki

2018-11-09 Thread Laszlo Ersek
On 11/09/18 01:26, Gao, Liming wrote: > Thanks for your review. I would like to push this change for this stable tag > edk2-stable201811. It has no impact for the release. Are you OK for it? Sure; it is not a feature patch set. Thanks! Laszlo >> -Original Message- >> From: edk2-devel [m