Re: [edk2] [PATCH 2/2] UefiCpuPkg/Microcode: Add verification logic before parsing payload

2019-02-27 Thread Ni, Ray
> -Original Message- > From: edk2-devel On Behalf Of Chen A > Chen > Sent: Thursday, February 28, 2019 2:03 PM > To: edk2-devel@lists.01.org > Cc: Dong, Eric > Subject: [edk2] [PATCH 2/2] UefiCpuPkg/Microcode: Add verification logic > before parsing payload > > REF:

Re: [edk2] [PATCH 1/2] UefiCpuPkg/Microcode: Fix InComplete CheckSum32 issue

2019-02-27 Thread Ni, Ray
Reviewed-by: Ray Ni > -Original Message- > From: edk2-devel On Behalf Of Chen A > Chen > Sent: Thursday, February 28, 2019 2:03 PM > To: edk2-devel@lists.01.org > Cc: Dong, Eric > Subject: [edk2] [PATCH 1/2] UefiCpuPkg/Microcode: Fix InComplete > CheckSum32 issue > > REF:

[edk2] [PATCH 2/2] UefiCpuPkg/Microcode: Add verification logic before parsing payload

2019-02-27 Thread Chen A Chen
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1020 The function MicrocodeDetect may receive untrusted input. Add verification logic to check Microcode Payload Header. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Chen A Chen Cc: Ray Ni Cc: Eric Dong ---

[edk2] [PATCH 1/2] UefiCpuPkg/Microcode: Fix InComplete CheckSum32 issue

2019-02-27 Thread Chen A Chen
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1020 The Microcode region indicated by MicrocodePatchAddress PCD may contain more than one Microcode entry. We should save InCompleteCheckSum32 value for each payload. Move the logic for calculate InCompleteCheckSum32 from the outsize of the

[edk2] [PATCH 0/2] Fix Microcode failure issue

2019-02-27 Thread Chen A Chen
The first patch is used to fix InComplete CheckSum32 issue. Add a verification logic to check Microcode header before parsing payload. Chen A Chen (2): UefiCpuPkg/Microcode: Fix InComplete CheckSum32 issue UefiCpuPkg/Microcode: Add verification logic before parsing payload

Re: [edk2] Self-replicating image

2019-02-27 Thread Kinney, Michael D
Hi Tomas, I have posted a branch in edk2-staging with the proposed design changes to support multiple controller and a functional example in OVMF using multiple E1000 adapters. https://github.com/tianocore/edk2-staging/tree/Bug_1525_FmpDevicePkg_MultipleControllers QEMU has a few limitations,

Re: [edk2] [PATCH] MdeModulePkg/SdMmcPciHcDxe: Fix DMA on SDHC v3 64-bit systems

2019-02-27 Thread Wu, Hao A
Loop Ashish in. Some comments below. > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Cohen, Eugene > Sent: Wednesday, February 27, 2019 6:59 PM > To: edk2-devel@lists.01.org; Wu, Hao A > Subject: [edk2] [PATCH] MdeModulePkg/SdMmcPciHcDxe:

[edk2] [staging/Bug_1525_FmpDevicePkg_MultipleControllers] Create new branch

2019-02-27 Thread Kinney, Michael D
# FmpDevicePkg Multiple Controllers This branch is used to evaluate methods to update the FmpDevicePkg to support drivers that manage multiple controllers and also provide a firmware update capability to each managed controller. The primary use case is the update of a PCI Option ROM when

Re: [edk2] [edk2-announce] Soft Feature Freeze starts today for edk2-stable201903

2019-02-27 Thread Gao, Liming
Laszlo: >-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of >Laszlo Ersek >Sent: Thursday, February 28, 2019 3:54 AM >To: Gao, Liming >Cc: edk2-devel@lists.01.org >Subject: Re: [edk2] [edk2-announce] Soft Feature Freeze starts today for

[edk2] [Patch] Document: Update the INF spec about [Depex] section

2019-02-27 Thread Feng, Bob C
::= {"BEFORE"} {"AFTER"} should be ::= [{"BEFORE"} {"AFTER"}] The "BEFORE" or "AFTER" is optional key words in current implementation. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Bob Feng Cc: Liming Gao --- 3_edk_ii_inf_file_format/314_[depex]_sections.md | 2 +-

[edk2] [Patch] Document: Update Dsc spec to all empty value for HIIPcd

2019-02-27 Thread Feng, Bob C
https://bugzilla.tianocore.org/show_bug.cgi?id=1466 Update Dsc spec to all empty value for HIIPcd. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Bob Feng Cc: Liming Gao --- 2_dsc_overview/29_pcd_sections.md| 4 ++--

Re: [edk2] [Patch] Revert "BaseTools:BaseTools supports to the driver combination."

2019-02-27 Thread Feng, Bob C
Reviewed-by: Bob Feng -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Liming Gao Sent: Monday, February 25, 2019 8:15 AM To: edk2-devel@lists.01.org Subject: [edk2] [Patch] Revert "BaseTools:BaseTools supports to the driver combination." This

[edk2] [Patch V2] BaseTools: Add python3-distutils Ubuntu package checking

2019-02-27 Thread Feng, Bob C
https://bugzilla.tianocore.org/show_bug.cgi?id=1509 V2: Remove OS/Package specific words. Print the error info which is from python error message. Add python3-distutils Ubuntu package checking. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Bob Feng Cc: Liming Gao ---

Re: [edk2] [PATCH v2 0/2] MdeModulePkg: Resolve buffer cross boundary access in Ramdisk

2019-02-27 Thread Gao, Liming
I update https://github.com/tianocore/tianocore.github.io/wiki/Commit-Message-Format with CVE example. Please check it. >-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of >Laszlo Ersek >Sent: Thursday, February 28, 2019 3:31 AM >To: Gao, Liming

Re: [edk2] [PATCH] Maintainers.txt: clarify Reviewer requirements and responsibilities

2019-02-27 Thread Andrew Fish via edk2-devel
Reviewed-by: Andrew Fish > On Feb 27, 2019, at 5:12 PM, Gao, Liming wrote: > > Reviewed-by: Liming Gao > >> -Original Message- >> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of >> Laszlo Ersek >> Sent: Thursday, February 28, 2019 5:22 AM >> To: edk2-devel-01

Re: [edk2] [PATCH] Maintainers.txt: clarify Reviewer requirements and responsibilities

2019-02-27 Thread Gao, Liming
Reviewed-by: Liming Gao >-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of >Laszlo Ersek >Sent: Thursday, February 28, 2019 5:22 AM >To: edk2-devel-01 >Cc: Gao, Liming ; Kinney, Michael D > >Subject: [edk2] [PATCH] Maintainers.txt: clarify

[edk2] [PATCH] Maintainers.txt: clarify Reviewer requirements and responsibilities

2019-02-27 Thread Laszlo Ersek
The current language for "Package Reviewer" only vaguely hints that Package Reviewers should be able to provide guidance and directions. Make this more obvious. Cc: Andrew Fish Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Liming Gao Cc: Michael D Kinney Cc: Philippe Mathieu-Daude

Re: [edk2] Hang when calling ExitBootServices on IA32 firmware v1.0 on MinnowBoard Turbot

2019-02-27 Thread Telemann Pioneer
Hi Rebecca, MinnowBoard Turbot Dual Ethernet runs with UDK2018 https://github.com/MinnowWare/UDK2018-MinnowBoard That BIOS starts a 64Bit Windows10, including S3 and resume… Phil From: edk2-devel on behalf of Rebecca Cran via edk2-devel Sent:

Re: [edk2] [PATCH v1 0/6] Revert DynamicTablesPkg: Framework updates and fixes

2019-02-27 Thread Laszlo Ersek
On 02/27/19 14:44, Sami Mujawar wrote: > Hi Laszlo, > > The DynamicTablesPkg won't be in use until the corresponding edk2-platform > patches for Dynamic Tables are merged (at which point it would be a major > feature addition). > I think for now, I will hold on until the stable release is

Re: [edk2] [edk2-announce] Soft Feature Freeze starts today for edk2-stable201903

2019-02-27 Thread Laszlo Ersek
On 02/27/19 14:16, Gao, Liming wrote: > Laszlo: > > Thanks > Liming >> -Original Message- >> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of >> Laszlo Ersek >> Sent: Tuesday, February 26, 2019 7:55 PM >> To: Gao, Liming >> Cc: edk2-devel@lists.01.org >> Subject:

Re: [edk2] [PATCH v2 0/2] MdeModulePkg: Resolve buffer cross boundary access in Ramdisk

2019-02-27 Thread Laszlo Ersek
On 02/27/19 13:49, Gao, Liming wrote: > Laszlo: > I add my comments. > > Thanks > Liming >> -Original Message- >> From: Laszlo Ersek [mailto:ler...@redhat.com] >> Sent: Wednesday, February 27, 2019 4:58 PM >> To: Wu, Hao A ; Gao, Liming ; >> edk2-devel@lists.01.org >> Cc: Zeng, Star

Re: [edk2] [PATCH v1 0/6] Revert DynamicTablesPkg: Framework updates and fixes

2019-02-27 Thread Sami Mujawar
Hi Laszlo, The DynamicTablesPkg won't be in use until the corresponding edk2-platform patches for Dynamic Tables are merged (at which point it would be a major feature addition). I think for now, I will hold on until the stable release is tagged. Regards, Sami Mujawar -Original

Re: [edk2] [edk2-announce] Soft Feature Freeze starts today for edk2-stable201903

2019-02-27 Thread Gao, Liming
Laszlo: Thanks Liming > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo > Ersek > Sent: Tuesday, February 26, 2019 7:55 PM > To: Gao, Liming > Cc: edk2-devel@lists.01.org > Subject: Re: [edk2] [edk2-announce] Soft Feature Freeze starts

Re: [edk2] [PATCH v2 0/2] MdeModulePkg: Resolve buffer cross boundary access in Ramdisk

2019-02-27 Thread Gao, Liming
Laszlo: I add my comments. Thanks Liming > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Wednesday, February 27, 2019 4:58 PM > To: Wu, Hao A ; Gao, Liming ; > edk2-devel@lists.01.org > Cc: Zeng, Star > Subject: Re: [edk2] [PATCH v2 0/2] MdeModulePkg:

Re: [edk2] [Patch] BaseTools: Add python3-distutils Ubuntu package checking

2019-02-27 Thread Laszlo Ersek
On 02/27/19 09:52, Feng, Bob C wrote: > Thanks for comments. I think the print message is not good. It's based on > Ubutun OS. It's not right. > > I think the import error need to be caught and then print some messages, > otherwise the build tool will break and print the call stack which is

Re: [edk2] [PATCH] Maintainers.txt: Register myself as OvmfPkg/ArmVirtPkg reviewer

2019-02-27 Thread Philippe Mathieu-Daudé
Hi, On 2/21/19 10:13 PM, Philippe Mathieu-Daude wrote: > Part of my assignment is to review OVMF and ArmVirt patches, > having my address listed will help me to catch the related > patches. I had a misunderstanding regarding how EDK2 treats a 'R:' tag, as I understood it as similar to

[edk2] [PATCH] MdeModulePkg/SdMmcPciHcDxe: Fix DMA on SDHC v3 64-bit systems

2019-02-27 Thread Cohen, Eugene
The SdMmcPciHcDriverBindingStart function was checking two different capability bits in determining whether 64-bit DMA modes were supported, one mode is defined in the SDHC version 3 specification (using 96-bit descriptors) and another is defined in the SDHC version 4 specification (using 128-bit

Re: [edk2] [Patch] BaseTools: Add python3-distutils Ubuntu package checking

2019-02-27 Thread Leif Lindholm
On Wed, Feb 27, 2019 at 08:52:08AM +, Feng, Bob C wrote: > Thanks for comments. I think the print message is not good. It's based on > Ubutun OS. It's not right. > > I think the import error need to be caught and then print some > messages, otherwise the build tool will break and print the

Re: [edk2] [PATCH v2 0/2] MdeModulePkg: Resolve buffer cross boundary access in Ramdisk

2019-02-27 Thread Laszlo Ersek
On 02/27/19 07:56, Wu, Hao A wrote: >> -Original Message- >> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of >> Laszlo Ersek >> Sent: Tuesday, February 26, 2019 7:45 PM >> To: Wu, Hao A; edk2-devel@lists.01.org >> Cc: Zeng, Star >> Subject: Re: [edk2] [PATCH v2 0/2]

Re: [edk2] [Patch] BaseTools: Add python3-distutils Ubuntu package checking

2019-02-27 Thread Feng, Bob C
Thanks for comments. I think the print message is not good. It's based on Ubutun OS. It's not right. I think the import error need to be caught and then print some messages, otherwise the build tool will break and print the call stack which is not friendly to user. Thanks, Bob

Re: [edk2] [Patch] BaseTools: Add python3-distutils Ubuntu package checking

2019-02-27 Thread Leif Lindholm
On Wed, Feb 27, 2019 at 09:07:49AM +0100, Ard Biesheuvel wrote: > On Tue, 26 Feb 2019 at 02:05, Feng, Bob C wrote: > > > > https://bugzilla.tianocore.org/show_bug.cgi?id=1509 > > > > Add python3-distutils Ubuntu package checking. > > > > Hi Bob, > > This assumes that all Linux systems are

Re: [edk2] [Patch] BaseTools: Add python3-distutils Ubuntu package checking

2019-02-27 Thread Ard Biesheuvel
On Tue, 26 Feb 2019 at 02:05, Feng, Bob C wrote: > > https://bugzilla.tianocore.org/show_bug.cgi?id=1509 > > Add python3-distutils Ubuntu package checking. > Hi Bob, This assumes that all Linux systems are Ubuntu based, which is not true. The apt tool is specific to Debian/Ubuntu, Fedora/Redhat