Re: [edk2] [Patch] ShellPkg: Enhance ping6 to select the interface automatically

Reviewed-by: Jaben Carsey <jaben.car...@intel.com> > -Original Message- > From: Wu, Jiaxin > Sent: Tuesday, April 26, 2016 6:21 PM > To: Bhupesh Sharma <bhupesh.sha...@nxp.com>; edk2-devel@lists.01.org > Cc: Carsey, Jaben <jaben.car...@intel.com>; Y

Re: [edk2] [PATCH] ShellPkg: Fix Shell treats every .EFI file as an executable application.

Reviewed-by: Jaben Carsey <jaben.car...@intel.com> > -Original Message- > From: Qiu, Shumin > Sent: Sunday, April 24, 2016 10:56 PM > To: edk2-devel@lists.01.org > Cc: Qiu, Shumin <shumin....@intel.com>; Carsey, Jaben > <jaben.car...@intel.com> &g

Re: [edk2] [PATCH] ShellPkg: Fix pci command for '_e' option

Looks good to me. I will let Shumin or Ray review also. Reviewed-by: Jaben Carsey <jaben.car...@intel.com> > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Abdul Lateef Attar > Sent: Thursday, April 21, 2016 4:24 AM &

Re: [edk2] [PATCH] ShellPkg: Support connect a device handle recursively with '-r'.

Reviewed-by: Jaben Carsey <jaben.car...@intel.com> From: Qiu, Shumin Sent: Tuesday, April 19, 2016 7:52 PM To: Carsey, Jaben <jaben.car...@intel.com> Cc: Qiu, Shumin <shumin@intel.com>; edk2-devel@lists.01.org Subject: RE: [edk2] [PATCH] ShellPkg: Support connect a device h

Re: [edk2] [PATCH] ShellPkg: Support connect a device handle recursively with '-r'.

> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Qiu > Shumin > Sent: Monday, April 18, 2016 1:18 AM > To: edk2-devel@lists.01.org > Cc: Carsey, Jaben <jaben.car...@intel.com>; Qiu, Shumin > <shumin@intel.com> > Subject: [edk2] [PATCH] ShellPkg: Su

Re: [edk2] [Patch] ShellPkg: Enhance ping to select the interface automatically

Reviewed-by: Jaben Carsey <jaben.car...@intel.com> > -Original Message- > From: Wu, Jiaxin > Sent: Monday, April 18, 2016 6:52 PM > To: edk2-devel@lists.01.org > Cc: David Van Arnem <dvanar...@cmlab.biz>; Bhupesh Sharma > <bhupesh.sha...@nxp.com>; C

Re: [edk2] [Patch] ShellPkg: Update ping command options to sync with Spec

That sounds like a good enhancement to me. -Jaben > -Original Message- > From: Wu, Jiaxin > Sent: Thursday, April 14, 2016 8:52 PM > To: Carsey, Jaben <jaben.car...@intel.com>; David Van Arnem > <dvanar...@cmlab.biz>; Bhupesh Sharma <bhupesh.sha...

Re: [edk2] [PATCH v2] PerformancePkg: Make Dp print help information with -? flag in Shell.

.org > Cc: Ni, Ruiyu <ruiyu...@intel.com>; Carsey, Jaben <jaben.car...@intel.com> > Subject: Re: [edk2] [PATCH v2] PerformancePkg: Make Dp print help > information with -? flag in Shell. > Importance: High > > On 2016/4/13 15:29, Qiu Shumin wrote: > > Sinc

Re: [edk2] [Patch] ShellPkg: Update ping command options to sync with Spec

.@intel.com>; Bhupesh Sharma > <bhupesh.sha...@nxp.com> > Cc: edk2-de...@ml01.01.org; Ye, Ting <ting...@intel.com>; Carsey, Jaben > <jaben.car...@intel.com>; Fu, Siyuan <siyuan...@intel.com>; David Van > Arnem <dvanar...@cmlab.biz> > Subject: Re: [ed

Re: [edk2] [PATCH v2] ShellPkg : Cache the environment variable into memory to enhance the performance.

Reviewed-by: Jaben Carsey > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ni, > Ruiyu > Sent: Wednesday, April 13, 2016 12:16 AM > To: Qiu, Shumin ; edk2-devel@lists.01.org > Subject: Re: [edk2]

Re: [edk2] [PATCH] ShellPkg : Cache the environment variable into memory to enhance the performance.

2 comments below. Reviewed-by: Jaben Carsey <jaben.car...@intel.com> > -Original Message- > From: Qiu, Shumin > Sent: Sunday, April 10, 2016 5:55 AM > To: edk2-devel@lists.01.org > Cc: Qiu, Shumin <shumin....@intel.com>; Carsey, Jaben > <jaben.ca

Re: [edk2] [PATCH] ShellPkg: Fix Shell ASSERT when mv file with cwd is NULL.

Reviewed-by: Jaben Carsey <jaben.car...@intel.com> > -Original Message- > From: Ni, Ruiyu > Sent: Friday, April 08, 2016 3:10 AM > To: Qiu, Shumin <shumin@intel.com>; edk2-devel@lists.01.org > Cc: Carsey, Jaben <jaben.car...@intel.com>; Qiu, Shumin &

Re: [edk2] [PATCH 03/12] FatBinPkg: Change to 2-clause BSD license

> -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Laszlo Ersek > Sent: Thursday, April 07, 2016 12:30 AM > To: Justen, Jordan L ; Ni, Ruiyu > ; edk2-devel@lists.01.org >

Re: [edk2] Using multiple SNP drivers on Shell

> -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo > Ersek > Sent: Monday, April 04, 2016 10:47 AM > To: Bhupesh Sharma > Cc: edk2-devel@lists.01.org ; David Van Arnem >

Re: [edk2] How to initiate a PXE boot from the UEFI shell

If your BDS supports PXE booting, you should be able to "exit" the shell and then use BDS to initiate a PXE boot.. I think you're right that there is no built in command to initiate a PXE boot. There is no command to initiate any boot type. -Jaben > -Original Message- > From:

Re: [edk2] [PATCH] ShellPkg: Refine the comparisons code in ShellPkg.

Reviewed-by: Jaben Carsey <jaben.car...@intel.com> > -Original Message- > From: Qiu, Shumin > Sent: Sunday, March 27, 2016 11:48 PM > To: edk2-devel@lists.01.org > Cc: Qiu, Shumin <shumin....@intel.com>; Carsey, Jaben > <jaben.car...@intel.com>

Re: [edk2] [PATCH] ShellPkg: Make the USB mouse behavior in 'edit' consistent with 'hexedit'.

Reviewed-by: Jaben Carsey <jaben.car...@intel.com> > -Original Message- > From: Qiu, Shumin > Sent: Tuesday, March 22, 2016 1:36 AM > To: edk2-devel@lists.01.org > Cc: Carsey, Jaben <jaben.car...@intel.com> > Subject: [PATCH] ShellPkg: Make the USB mouse

Re: [edk2] Shell Aliases and Case-Sensitivity

-Jaben > On Mar 22, 2016, at 10:32 AM, "jim_dai...@dell.com" > wrote: > > >> Jaben asked: > >> Why would we want to add something case sensitive when everything else >> is not case sensitive? Do we really want to have to add DIR, dIR, >> Dir, >> (etc...) to properly

Re: [edk2] Shell Aliases and Case-Sensitivity

Jim, Why would we want to add something case sensitive when everything else is not case sensitive? Do we really want to have to add DIR, dIR, Dir, (etc...) to properly handle the built in alias that is required in the shell spec? What if we requested to change the spec to say alias is case

Re: [edk2] [PATCH] ShellPkg: Modify the 'dh' Shell command to dump the Firmware Management Protocol Image Descriptor Information.

We need to split into 2 patches (a series), one for MdePkg and one for ShellPkg. Comments below inline. > -Original Message- > From: Tapan Shah [mailto:tapands...@hpe.com] > Sent: Wednesday, March 16, 2016 8:55 AM > To: edk2-devel@lists.01.org > Cc: samer.el-haj-mahm...@

Re: [edk2] [PATCH] ShellPkg: Modify 'dh' Shell command to dump the Firmware Management Protocol Image Descriptor Information.

One final question below. > -Original Message- > From: Tapan Shah [mailto:tapands...@hpe.com] > Sent: Wednesday, March 16, 2016 10:32 AM > To: edk2-devel@lists.01.org > Cc: samer.el-haj-mahm...@hpe.com; Carsey, Jaben > <jaben.car...@intel.com>; Tapan Shah <ta

Re: [edk2] [PATCH] ShellPkg: Modify 'dh' Shell command to dump the Firmware Management Protocol Image Descriptor Information.

Got it. makes sense. Reviewed-by: Jaben Carsey <jaben.car...@intel.com> > -Original Message- > From: Shah, Tapan [mailto:tapands...@hpe.com] > Sent: Wednesday, March 16, 2016 11:08 AM > To: Carsey, Jaben <jaben.car...@intel.com>; edk2-devel@lists.01.org >

Re: [edk2] [PATCH] ShellPkg: Modify the 'dh' Shell command to dump the Firmware Management Protocol Image Descriptor Information.

Looks good to me. I will let Shumin check also. Reviewed-by: Jaben Carsey <jaben.car...@intel.com> > -Original Message- > From: Tapan Shah [mailto:tapands...@hpe.com] > Sent: Friday, March 18, 2016 9:32 AM > To: edk2-devel@lists.01.org > Cc: samer.el-haj-mahm...@h

Re: [edk2] [PATCH] ShellPkg:

Reviewed-by: Jaben Carsey <jaben.car...@intel.com> > -Original Message- > From: jim_dai...@dell.com [mailto:jim_dai...@dell.com] > Sent: Tuesday, March 15, 2016 2:09 PM > To: edk2-devel@lists.01.org > Cc: Carsey, Jaben <jaben.car...@intel.com>; Qiu, Shu

Re: [edk2] [PATCH] ShellPkg: Fix Shell ASSERT when read 'TAB' key fail from 'ConIn'.

Reviewed-by: Jaben Carsey <jaben.car...@intel.com> > -Original Message- > From: Ni, Ruiyu > Sent: Sunday, March 13, 2016 7:14 PM > To: Qiu, Shumin <shumin@intel.com>; edk2-devel@lists.01.org > Cc: Carsey, Jaben <jaben.car...@intel.com> > Subject: RE

Re: [edk2] EDK2 Setup & Configuration Issue

BaseTools and Conf should be one directory up I think. From: Jim Slaughter [mailto:jwslau...@yahoo.com] Sent: Tuesday, March 08, 2016 4:19 PM To: Carsey, Jaben <jaben.car...@intel.com>; Gao, Liming <liming@intel.com>; Tian, Feng <feng.t...@intel.com>; edk2-devel@lists.

Re: [edk2] EDK2 Setup & Configuration Issue

Jim, You need to download or build the BaseTools that are used during the build. Have you done that? -Jaben > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jim > Slaughter > Sent: Tuesday, March 08, 2016 2:21 PM > To: Gao, Liming

Re: [edk2] [PATCH 3/3] BaseTools ConvertMasmToNasm: Support Python 3

> -Original Message- > From: Justen, Jordan L > Sent: Tuesday, March 08, 2016 11:37 AM > To: Carsey, Jaben <jaben.car...@intel.com> > Cc: edk2-devel@lists.01.org; Gao, Liming <liming@intel.com>; Bjorge, Erik > C <erik.c.bjo...@intel.com> > Su

Re: [edk2] [PATCH 3/3] BaseTools ConvertMasmToNasm: Support Python 3

> On Mar 7, 2016, at 7:16 PM, Jordan Justen wrote: > > The script is updated to support both python 2.7 and python 3. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Jordan Justen > Cc: Yonghong Zhu

Re: [edk2] [PATCH] ShellPkg: Use DOS format end of line.

Fix Intel's copyright years in the modified files. If you do that, then good. Reviewed-By: Jaben Carsey -Jaben Sent from my iPad. > On Mar 8, 2016, at 4:57 AM, Qiu, Shumin wrote: > > Use DOS format end of line(CR, LF). > > Cc: Jaben Carsey

Re: [edk2] [PATCH v2 1/2] PerformancePkg/Dp_App: Support execution break

Also for series. Reviewed-by: Jaben Carsey > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of El- > Haj-Mahmoud, Samer > Sent: Monday, March 07, 2016 4:57 AM > To: edk2-devel@lists.01.org; Shia, Cinnamon

Re: [edk2] [Patch] ShellPkg: Update 'ifconfig -r' implementation

.@linaro.org] >> Sent: Wednesday, March 2, 2016 5:57 PM >> To: Laszlo Ersek <ler...@redhat.com> >> Cc: Wu, Jiaxin <jiaxin...@intel.com>; edk2-devel@lists.01.org > de...@ml01.01.org>; Ye, Ting <ting...@intel.com>; Carsey, Jaben >> <jaben.car...@in

Re: [edk2] [PATCH] ShellPkg: Don't strip BOM when piping UCS2 data to a UEFI app

Reviewed-by: Jaben Carsey <jaben.car...@intel.com> This patch worked great! > -Original Message- > From: jim_dai...@dell.com [mailto:jim_dai...@dell.com] > Sent: Tuesday, March 01, 2016 1:02 PM > To: edk2-devel@lists.01.org > Cc: Carsey, Jaben <jaben.car...

Re: [edk2] [EDK2] [PATCH] ShellPkg: Ensure UEFI apps open the correct StdOut

; Sent: Tuesday, March 01, 2016 12:48 PM > To: edk2-devel@lists.01.org > Cc: Carsey, Jaben <jaben.car...@intel.com>; Qiu, Shumin > <shumin@intel.com> > Subject: [edk2] [EDK2] [PATCH] ShellPkg: Ensure UEFI apps open the correct > StdOut > Importance: High > >

Re: [edk2] [PATCH] ShellPkg: Fix unexpected behavior of mouse cursor in Editor.

Reviewed-by: Jaben Carsey <jaben.car...@intel.com> > -Original Message- > From: Qiu, Shumin > Sent: Thursday, February 25, 2016 10:54 PM > To: edk2-devel@lists.01.org > Cc: Qiu, Shumin <shumin....@intel.com>; Carsey, Jaben > <jaben.car...@intel.co

Re: [edk2] [PATCH v4 0/2] Enhance Shell to support finding help message embeded in resource section.

Reviewed-by: Jaben Carsey > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Qiu > Shumin > Sent: Monday, February 22, 2016 11:01 PM > To: edk2-devel@lists.01.org > Subject: [edk2] [PATCH v4 0/2] Enhance Shell to support

Re: [edk2] [PATCH] ShellPkg: Do NULL pointer check before the pointer is used.

Reviewed-by: Jaben Carsey -Jaben Sent from my iPad. > On Feb 21, 2016, at 6:49 PM, Qiu, Shumin wrote: > > Do NULL pointer check before the pointer is used to avoid dereferenced. > > Cc: Jaben Carsey > Cc: Ruiyu Ni

Re: [edk2] [PATCH] ShellPkg: Increase reallocation size for temp memory files

That sounds good to me. > -Original Message- > From: jim_dai...@dell.com [mailto:jim_dai...@dell.com] > Sent: Thursday, February 18, 2016 8:26 AM > To: Carsey, Jaben <jaben.car...@intel.com> > Cc: Qiu, Shumin <shumin@intel.com>; edk2-devel@lists.01.org &

Re: [edk2] [PATCH] ShellPkg: Increase reallocation size for temp memory files

> -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > jim_dai...@dell.com > Sent: Thursday, February 18, 2016 7:52 AM > To: edk2-devel@lists.01.org > Cc: Carsey, Jaben <jaben.car...@intel.com>; Qiu, Shumin > <s

Re: [edk2] [PATCH v1 1/1] StdLib/BsdSocketLib: Fix minor memory leak.

Reviewed-by: Jaben Carsey <jaben.car...@intel.com> > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Daryl McDaniel > Sent: Tuesday, February 16, 2016 12:09 PM > To: edk2-devel@lists.01.org > Cc: Carsey, Jaben <jab

Re: [edk2] [PATCH] ShellPkg: Do NULL pointer check before the pointer is used.

Reviewed-by: Jaben Carsey <jaben.car...@intel.com> > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Qiu > Shumin > Sent: Monday, February 15, 2016 6:07 PM > To: edk2-devel@lists.01.org > Cc: Carsey, Jaben <jaben.car

Re: [edk2] [PATCH] ShellPkg: ShellFileHandleReadLine must return UCS2 lines

Reviewed-by: Jaben Carsey <jaben.car...@intel.com> > -Original Message- > From: Ryan Harkin [mailto:ryan.har...@linaro.org] > Sent: Wednesday, February 10, 2016 6:16 AM > To: jim_dai...@dell.com > Cc: edk2-devel@lists.01.org; Carsey, Jaben <jaben.car...@intel.com

Re: [edk2] [PATCH] ShellBinPkg: Arm/AArch64 Shell binary update.

olm > Sent: Tuesday, February 09, 2016 8:54 AM > To: Carsey, Jaben <jaben.car...@intel.com> > Cc: edk2-devel@lists.01.org; Laszlo Ersek <ler...@redhat.com>; Qiu, Shumin > <shumin@intel.com>; Ard Biesheuvel <ard.biesheu...@linaro.org> > Subject: Re: [

Re: [edk2] [PATCH] ShellPkg Fix ASCII and UNICODE file pipes

in > Sent: Tuesday, February 09, 2016 10:15 AM > To: Carsey, Jaben <jaben.car...@intel.com> > Cc: jim_dai...@dell.com; edk2-devel@lists.01.org > Subject: Re: [edk2] [PATCH] ShellPkg Fix ASCII and UNICODE file pipes > Importance: High > > Hi Jaben, > > On 8 Februa

Re: [edk2] [PATCH] Maintainers.txt: Update maintainers for ShellBinPkg

> -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Leif > Lindholm > Sent: Tuesday, February 09, 2016 10:13 AM > To: Carsey, Jaben <jaben.car...@intel.com> > Cc: edk2-devel@lists.01.org; Qiu, Shumin <shumin@i

Re: [edk2] [PATCH] Maintainers.txt: Update maintainers for ShellBinPkg

To: Leif Lindholm <leif.lindh...@linaro.org> > Cc: edk2-devel@lists.01.org; Carsey, Jaben <jaben.car...@intel.com>; Qiu, > Shumin <shumin@intel.com> > Subject: Re: [PATCH] Maintainers.txt: Update maintainers for ShellBinPkg > Importance: High > > On 9 February

Re: [edk2] [PATCH] Maintainers.txt: Update maintainers for ShellBinPkg

> -Original Message- > From: Leif Lindholm [mailto:leif.lindh...@linaro.org] > Sent: Tuesday, February 09, 2016 9:19 AM > To: edk2-devel@lists.01.org > Cc: Carsey, Jaben <jaben.car...@intel.com>; Qiu, Shumin > <shumin@intel.com>; Ard Biesheuvel <ard

Re: [edk2] [PATCH] ShellPkg/UefiDpLib: Refine the code of locating all handles in DpTrace.c.

Reviewed-by: Jaben Carsey > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Cinnamon Shia > Sent: Monday, February 08, 2016 9:39 AM > To: edk2-devel@lists.01.org > Subject: [edk2] [PATCH] ShellPkg/UefiDpLib: Refine the

Re: [edk2] [PATCH] ShellPkg Fix ASCII and UNICODE file pipes

to:jim_dai...@dell.com] Sent: Monday, February 08, 2016 11:03 AM To: Carsey, Jaben <jaben.car...@intel.com> Cc: Qiu, Shumin <shumin@intel.com> Subject: RE: [edk2] [PATCH] ShellPkg Fix ASCII and UNICODE file pipes Importance: High Strange. I didn't see them on the mailing list posting,

Re: [edk2] [PATCH] Update Shell Library INF file version

Committed and done. Reviewed-by: Jaben Carsey <jaben.car...@intel.com> > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > jim_dai...@dell.com > Sent: Monday, February 08, 2016 1:53 PM > To: edk2-devel@lists.01.or

Re: [edk2] manually booting efi file

Since you asked here is a little more info: The file's EFI_FILE_PROTOCOL is insufficient information to find it as it just contains the path in file system for the file. That's the equivalent to saying "I want to open file directory/foo.txt". you need to give more context for success. To

Re: [edk2] [PATCH v2 6/6] Revert "ArmPlatformPkg: Create an ARM Platform DSC / FDF / ArmPlatformLib template"

sten, Jordan L > <jordan.l.jus...@intel.com>; edk2-de...@ml01.01.org; Leif Lindholm > <leif.lindh...@linaro.org>; linaro-u...@lists.linaro.org; Carsey, Jaben > <jaben.car...@intel.com> > Subject: Re: [edk2] [PATCH v2 6/6] Revert "ArmPlatformPkg: Create an ARM > Platform D

Re: [edk2] [PATCH v2 6/6] Revert "ArmPlatformPkg: Create an ARM Platform DSC / FDF / ArmPlatformLib template"

> -Original Message- > From: Ryan Harkin [mailto:ryan.har...@linaro.org] > Sent: Wednesday, February 03, 2016 9:25 AM > To: Carsey, Jaben <jaben.car...@intel.com> > Cc: edk2-de...@ml01.01.org; linaro-u...@lists.linaro.org; Leif Lindholm > <leif.lindh...@li

Re: [edk2] [PATCH v2 6/6] Revert "ArmPlatformPkg: Create an ARM Platform DSC / FDF / ArmPlatformLib template"

Change looks good. Question - Is there a way to optimize the patch/email for this type of change so that we do not see the "diff" for a file that is deleted? It seems redundant to show a whole file of "-" lines... -Jaben > -Original Message- > From: edk2-devel

Re: [edk2] [PATCH] Maintainers.txt: Update source repository urls

Looks like good info. Should we clarify that SVN is read only also? Reviewed-by: Jaben Carsey > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Jordan Justen > Sent: Tuesday, February 02, 2016 9:03 AM > To:

Re: [edk2] [PATCH] Maintainers.txt: Update source repository urls

I like that a lot. Reviewed-by: Jaben Carsey <jaben.car...@intel.com> > -Original Message- > From: Justen, Jordan L > Sent: Tuesday, February 02, 2016 9:35 AM > To: Carsey, Jaben <jaben.car...@intel.com>; edk2-devel@lists.01.org > Cc: Carsey, Jaben <jaben.c

Re: [edk2] [PATCH] ShellPkg: Refine the code to avoid use a constant number as offset.

Reviewed-by: Jaben Carsey <jaben.car...@intel.com> > -Original Message- > From: Qiu, Shumin > Sent: Monday, January 25, 2016 12:01 AM > To: edk2-devel@lists.01.org > Cc: Qiu, Shumin <shumin....@intel.com>; Carsey, Jaben > <jaben.car...@intel.com>

Re: [edk2] [PATCH] [ShellPkg] fix operator

> -Original Message- > From: Ryan Harkin [mailto:ryan.har...@linaro.org] > Sent: Thursday, January 21, 2016 12:47 AM > To: Laszlo Ersek <ler...@redhat.com> > Cc: Carsey, Jaben <jaben.car...@intel.com>; edk2-devel@lists.01.org de...@ml01.01.org> > Su

Re: [edk2] [PATCH] [ShellPkg] fix operator

> -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Laszlo Ersek > Sent: Thursday, January 21, 2016 8:13 AM > To: Carsey, Jaben <jaben.car...@intel.com>; Ryan Harkin > <ryan.har...@linaro.org> > Cc: edk2-devel

Re: [edk2] [PATCH v2 00/14] ShellPkg: BCFG dump improvements

For series. Reviewed-by: Jaben Carsey <jaben.car...@intel.com> > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Thursday, January 21, 2016 9:07 AM > To: edk2-devel-01 <edk2-de...@ml01.01.org> > Cc: Carsey, Jaben <jaben.car...@intel

Re: [edk2] [PATCH v2 01/14] ShellPkg: BcfgDisplayDump(): update whitespace & layout

Reviewed-by: Jaben Carsey <jaben.car...@intel.com> > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Thursday, January 21, 2016 9:07 AM > To: edk2-devel-01 <edk2-de...@ml01.01.org> > Cc: Carsey, Jaben <jaben.car...@intel

Re: [edk2] [PATCH 00/13] ShellPkg: BCFG dump improvements

l-boun...@lists.01.org] On Behalf Of Laszlo > Ersek > Sent: Wednesday, January 20, 2016 5:12 PM > To: edk2-de...@ml01.01.org > Cc: Carsey, Jaben <jaben.car...@intel.com>; Ryan Harkin > <ryan.har...@linaro.org> > Subject: [edk2] [PATCH 00/13] ShellPkg: BCFG dump improvements

Re: [edk2] Shell BCFG command - adding option data

Short help to long answer to long question. First you must enable verbose (use -v) output to see the optional data. Second - I agree something is wrong with that N saying there isn't any. The question is why that math thinks that there is no more data in the buffer. The output you're looking

Re: [edk2] [PATCH] [ShellPkg] fix operator

I will wait. -Jaben > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Wednesday, January 20, 2016 1:21 PM > To: Carsey, Jaben <jaben.car...@intel.com>; edk2-de...@ml01.01.org > Cc: ryan.har...@linaro.org > Subject: Re: [PATCH]

Re: [edk2] Shell BCFG command - adding option data

ER_OPT (x) (BCFG_VAR_BUFFER_DPATH(x)+BCFG_VAR_BUFFER_LEN(x)) -Jaben > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Wednesday, January 20, 2016 1:26 PM > To: Ryan Harkin <ryan.har...@linaro.org>; Carsey, Jaben > <jaben.car...@intel.com&

Re: [edk2] [PATCH] [ShellPkg] fix operator

Note that when you specify your 1 2 3 it’s interpreted as a keystroke code. If you want a string you should use “1 2 3”… From: Ryan Harkin [mailto:ryan.har...@linaro.org] Sent: Wednesday, January 20, 2016 2:18 PM To: Carsey, Jaben <jaben.car...@intel.com> Cc: edk2-devel@lists.01.org &l

Re: [edk2] [PATCH] CryptoPkg: Fix function qsort for non 32-bit machines

Shouldn't we also update the MdeModulePkg header and implementation where that is copied from if we are changing the way it works? Sidenote: why does CryptoPkg carry a separate quick sort implementation? Is it worth just using the MdeModulePkg BaseSortLib? That library used to be in

Re: [edk2] [PATCH 2/2] ShellPkg UefiDpLib: Use Image->FilePath to get name for SMM drivers

for the series. Reviewed-by: Jaben Carsey <jaben.car...@intel.com> > -Original Message- > From: Zeng, Star > Sent: Sunday, January 17, 2016 10:02 PM > To: edk2-devel@lists.01.org > Cc: Gao, Liming <liming....@intel.com>; Carsey, Jaben > <jaben.car..

Re: [edk2] [PATCH] ShellPkg: Update 'dh' command to reflect correct driver handle information

Thanks for the Contributed-under line update. Done 19648. > -Original Message- > From: Tapan Shah [mailto:tapands...@hpe.com] > Sent: Friday, January 15, 2016 9:04 AM > To: edk2-devel@lists.01.org; Carsey, Jaben <jaben.car...@intel.com> > Cc: samer.el-haj-mah

Re: [edk2] [PATCH] MdeModulePkg/SerialDxe: fix porting error from EmbeddedPkg

> -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Laszlo Ersek > Sent: Friday, January 15, 2016 9:22 AM > To: Ryan Harkin ; Ard Biesheuvel > > Cc: edk2-de...@ml01.01.org; Zeng, Star

Re: [edk2] [PATCH] ShellPkg: Make 'alias' can display a single alias name.

Reviewed-by: Jaben Carsey <jaben.car...@intel.com> > -Original Message- > From: Qiu, Shumin > Sent: Tuesday, January 5, 2016 12:33 AM > To: edk2-devel@lists.01.org > Cc: Qiu, Shumin <shumin....@intel.com>; Carsey, Jaben > <jaben.car...@intel.com> >

Re: [edk2] [PATCH] ShellPkg: Fix Shell assert when mv a file to a NULL target.

Reviewed-by: Jaben Carsey <jaben.car...@intel.com> > -Original Message- > From: Qiu, Shumin > Sent: Monday, January 4, 2016 8:03 PM > To: edk2-devel@lists.01.org > Cc: Qiu, Shumin <shumin....@intel.com>; Carsey, Jaben > <jaben.car...@intel.com> &g

Re: [edk2] [PATCH v2] ShellPkg : Add UEFI_APPLICATION module type to UefiShellInstall1CommandsLib.inf

Reviewed-by: Jaben Carsey <jaben.car...@intel.com> > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of El- > Haj-Mahmoud, Samer > Sent: Tuesday, January 05, 2016 10:55 AM > To: edk2-devel@lists.01.org > Cc: Carsey, Jaben

Re: [edk2] [PATCH] ShellPkg: Refine the code format.

I think we should change 0 to CHAR_NULL in the comparison. Otherwise: Reviewed-by: Jaben Carsey <jaben.car...@intel.com> > -Original Message- > From: Ni, Ruiyu > Sent: Sunday, December 20, 2015 9:07 PM > To: Qiu, Shumin <shumin@intel.com>; edk2-devel@lists.01

Re: [edk2] about UEFI Shell and NTFS filesystem

Is it possible that the NT32 file system driver is completely read only? I am not sure myself... > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > LiHongcheng > Sent: Monday, December 28, 2015 7:02 PM > To: edk2-devel@lists.01.org > Subject:

Re: [edk2] [Patch] AppPkg/.../Python-2.7.10: Update pyconfig for Python 2.7.10 compliance.

7, 2015 4:34 PM > To: edk2-devel@lists.01.org; Carsey, Jaben <jaben.car...@intel.com>; Bjorge, > Erik C <erik.c.bjo...@intel.com> > Subject: [Patch] AppPkg/.../Python-2.7.10: Update pyconfig for Python 2.7.10 > compliance. > Importance: High > > Jaben or Erik, could yo

Re: [edk2] [PATCH] ShellPkg : Change UefiShellInstall1CommandsLib.inf type to UEFI_APPLICATION

Shumin <shumin@intel.com>; Carsey, Jaben > <jaben.car...@intel.com>; Samer El-Haj-Mahmoud mahm...@hpe.com>; Samer El-Haj-Mahmoud <el...@hpe.com> > Subject: [PATCH] ShellPkg : Change UefiShellInstall1CommandsLib.inf type to > UEFI_APPLICATION > Importance: Hig

Re: [edk2] [PATCH v2 2/4] ShellPkg: Refine the code logic of 'command history'.

Can you make this into a PCD? That would be cleaner. I would like patchable be one option. > -Original Message- > From: Qiu, Shumin > Sent: Monday, December 21, 2015 7:19 AM > To: edk2-devel@lists.01.org > Cc: Qiu, Shumin <shumin@intel.com>; Carsey, Jaben >

Re: [edk2] [PATCH v2 3/4] ShellPkg: Fix memory leak in ShellProtocol.

Reviewed-by: Jaben Carsey <jaben.car...@intel.com> > -Original Message- > From: Qiu, Shumin > Sent: Monday, December 21, 2015 7:19 AM > To: edk2-devel@lists.01.org > Cc: Qiu, Shumin <shumin....@intel.com>; Carsey, Jaben > <jaben.car...@intel.com>; Ni,

Re: [edk2] [PATCH v2 1/4] ShellPkg: Fix memory leak in SimpleTextOutput on file.

Reviewed-by: Jaben Carsey <jaben.car...@intel.com> > -Original Message- > From: Qiu, Shumin > Sent: Monday, December 21, 2015 7:19 AM > To: edk2-devel@lists.01.org > Cc: Qiu, Shumin <shumin....@intel.com>; Carsey, Jaben > <jaben.car...@intel.com>; Ni,

Re: [edk2] [PATCH] ShellPkg: Add AIP IPv6 UNDI support to Shell dh

Reviewed-by: Jaben Carsey <jaben.car...@intel.com> > -Original Message- > From: Samer El-Haj-Mahmoud [mailto:samer.el-haj-mahm...@hpe.com] > Sent: Monday, December 21, 2015 4:22 PM > To: edk2-devel@lists.01.org > Cc: Carsey, Jaben <jaben.car...@intel.com

Re: [edk2] [PATCH] ShellPkg : Change UefiShellInstall1CommandsLib.inf type to UEFI_APPLICATION

pe.com] > Sent: Monday, December 21, 2015 5:30 PM > To: Carsey, Jaben <jaben.car...@intel.com>; edk2-devel@lists.01.org > Cc: Qiu, Shumin <shumin@intel.com>; El-Haj-Mahmoud, Samer haj-mahm...@hpe.com> > Subject: RE: [PATCH] ShellPkg : Change UefiShellInstall1CommandsLib.

Re: [edk2] Simple Textoutput is not working

ay, December 17, 2015 11:19 PM > To: edk2-de...@ml01.01.org > Subject: Re: [edk2] Simple Textoutput is not working > Importance: High > > Carsey, Jaben intel.com> writes: > > > > > For a really simple experiment. If you run the HelloWorld app that i

Re: [edk2] Help in testing PCIe driver from UEFI shell

I think that you need to debug your DriverBinding.Start() and DriverBinding.Supported() APIs. Those are what gets called in your driver when 'connect' shell command it used. -Jaben > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Mahan,

Re: [edk2] [PATCH] ShellPkg: Fix unhandled value in switch statement

Reviewed-by: Jaben Carsey <jaben.car...@intel.com> > -Original Message- > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > Sent: Wednesday, December 16, 2015 5:30 AM > To: Alcantara, Paulo <paulo.alc.cavalca...@hp.com> > Cc: edk2-devel@lists.01.or

Re: [edk2] [PATCH] ShellPkg: Fix a bug in smbiosview PowerSupply Characteristics

Reviewed-by: Jaben Carsey <jaben.car...@intel.com> > -Original Message- > From: Samer El-Haj-Mahmoud [mailto:samer.el-haj-mahm...@hpe.com] > Sent: Monday, December 14, 2015 4:24 PM > To: edk2-devel@lists.01.org > Cc: Ni, Ruiyu <ruiyu...@intel.com>; Carsey, Ja

Re: [edk2] [PATCH] ShellPkg: Use %p for smbiosview SMBIOS table addresses

Reviewed-by: Jaben Carsey <jaben.car...@intel.com> > -Original Message- > From: Samer El-Haj-Mahmoud [mailto:samer.el-haj-mahm...@hpe.com] > Sent: Monday, December 14, 2015 4:28 PM > To: edk2-devel@lists.01.org > Cc: Ni, Ruiyu <ruiyu...@intel.com>; Carsey, Ja

Re: [edk2] [Patch] ShellPkg/Mm: Fix build warnings

; Cc: Ni, Ruiyu <ruiyu...@intel.com>; Carsey, Jaben <jaben.car...@intel.com> > Subject: [Patch] ShellPkg/Mm: Fix build warnings > Importance: High > > Fix build warnings for potentially uninitialized local variables > in the functions ShellMmLocateIoProtocol() and ShellCo

Re: [edk2] [Patch] ShellPkg/Mm: Fix build warnings

Looks good. Thanks! > -Original Message- > From: Kinney, Michael D > Sent: Monday, December 14, 2015 10:14 AM > To: Carsey, Jaben <jaben.car...@intel.com>; edk2-devel@lists.01.org; Kinney, > Michael D <michael.d.kin...@intel.com> > Cc: Ni, Ruiyu <ruiyu...

Re: [edk2] [PATCH] ShellPkg Ease MAN file Title Header syntax requirements

14, 2015 11:44 AM > To: edk2-devel@lists.01.org > Cc: Carsey, Jaben <jaben.car...@intel.com> > Subject: [edk2] [PATCH] ShellPkg Ease MAN file Title Header syntax > requirements > Importance: High > > ShellPkg: Ease the shell's MAN file Title Header syntax requirements. >

Re: [edk2] [PATCH] ShellPkg/Shell - Fix ASSERT() when FvSimpleFileSystemDxe is used

Reviewed-by: Jaben Carsey <jaben.car...@intel.com> > -Original Message- > From: Kinney, Michael D > Sent: Friday, December 11, 2015 1:24 PM > To: edk2-devel@lists.01.org > Cc: Carsey, Jaben <jaben.car...@intel.com> > Subject: [PATCH] Shel

Re: [edk2] [PATCH v2 15/20] PerformancePkg: Convert all .uni files to utf-8

Reviewed-by: Jaben Carsey <jaben.car...@intel.com> > -Original Message- > From: Justen, Jordan L > Sent: Friday, December 04, 2015 12:14 PM > To: edk2-devel@lists.01.org > Cc: Justen, Jordan L <jordan.l.jus...@intel.com>; Daryl McDaniel li...@mc2research.org

Re: [edk2] [PATCH v2 17/20] ShellPkg: Convert all .uni files to utf-8

Agreed. that works fine too... > -Original Message- > From: Justen, Jordan L > Sent: Friday, December 04, 2015 2:14 PM > To: Carsey, Jaben <jaben.car...@intel.com>; edk2-devel@lists.01.org > Cc: Qiu, Shumin <shumin....@intel.com>; Carsey, Jaben > <jabe

Re: [edk2] [PATCH] ShellPkg: Make 'dh' support showing all spec defined protocols.

I am the author. Shumin did some final verification and fixed a bug and then sent out for review. > -Original Message- > From: Justen, Jordan L > Sent: Friday, December 04, 2015 4:11 PM > To: edk2-devel@lists.01.org > Cc: Carsey, Jaben <jaben.car...@intel.com>;

Re: [edk2] [Patch] ShellPkg: Fix ifconfig hang issue with incomplete parameters

7 PM > To: edk2-devel@lists.01.org > Cc: Leekha Shaveta <shav...@freescale.com>; Carsey, Jaben > <jaben.car...@intel.com>; Ye, Ting <ting...@intel.com> > Subject: [Patch] ShellPkg: Fix ifconfig hang issue with incomplete parameters > Importance: High > > This pa

Re: [edk2] [PATCH] ShellPkg: Refine the code to reduce time cost of 'map -r'

> -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Thursday, December 03, 2015 3:26 AM > To: Qiu, Shumin <shumin@intel.com>; edk2-de...@ml01.01.org > Cc: Carsey, Jaben <jaben.car...@intel.com> > Subject: Re: [edk2] [PATCH] Shell

Re: [edk2] [PATCH] ShellPkg: Refine the code to reduce time cost of 'map -r'

> -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Thursday, December 03, 2015 9:16 AM > To: Carsey, Jaben <jaben.car...@intel.com>; Qiu, Shumin > <shumin@intel.com>; edk2-de...@ml01.01.org > Subject: Re: [edk2] [PATCH] Shell

Re: [edk2] [PATCH 4/5] ShellPkg: add missing SHELL_STATUS cast

;; Zhang, Chao B <chao.b.zh...@intel.com>; Carsey, > Jaben <jaben.car...@intel.com>; Qiu, Shumin <shumin@intel.com>; Fan, > Jeff <jeff@intel.com>; Tian, Feng <feng.t...@intel.com> > Cc: Ard Biesheuvel <ard.biesheu...@linaro.org> > Subj

Re: [edk2] Where do I find the system table address for an EFI app ?

I am pretty sure it’s there in a shell app also. What entry point lib are you using to build your app? -Jaben From: Shubha Ramani [mailto:shubharam...@yahoo.com] Sent: Wednesday, December 02, 2015 9:11 AM To: Carsey, Jaben <jaben.car...@intel.com>; edk2-devel@lists.01.org Subject: Re:

Re: [edk2] [Patch] ShellPkg: Fix wrong return status for Ifconfig.c

Reviewed-by: Jaben Carsey <jaben.car...@intel.com> > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Jiaxin Wu > Sent: Wednesday, December 02, 2015 12:54 AM > To: edk2-devel@lists.01.org > Cc: Carsey, Jaben <jaben.

<    1   2   3   4   5   6   7   >