Re: [edk2] [PATCH 0/6] implement standalone MM versions of the variable runtime drivers

2019-01-09 Thread Gao, Liming
rther verify its functionality on SMM mode. Thanks Liming > -Original Message- > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > Sent: Monday, January 7, 2019 9:06 PM > To: Gao, Liming > Cc: edk2-devel@lists.01.org; Laszlo Ersek ; Leif Lindholm > ; Kinney, Mic

Re: [edk2] Conditional Compilation support in INF file

2019-01-09 Thread Gao, Liming
Laszlo: INF Spec: FixedAtBuild (VOID*) PCD use in the [DEPEX] section has been added into INF spec git book (g...@github.com:tianocore-docs/edk2-InfSpecification.git). BZ https://bugzilla.tianocore.org/show_bug.cgi?id=444 The change is in INF spec trunk. New version INF spec will include it.

Re: [edk2] [Patch 3/3] BaseTools: Remove unused logic from C tools

2019-01-08 Thread Gao, Liming
Could you separate this change to two patches for IPF and EBC? > -Original Message- > From: Feng, Bob C > Sent: Wednesday, January 9, 2019 2:45 PM > To: edk2-devel@lists.01.org > Cc: Feng, Bob C ; Gao, Liming ; > Carsey, Jaben > Subject: [Patch 3/3] BaseTools: Remov

Re: [edk2] [Patch 1/3] BaseTools: Remove unused logic for EDKI

2019-01-08 Thread Gao, Liming
This patch removes the logic from BaseTools python code, not C code. And, please also include BZ link in the commit message. Thanks Liming > -Original Message- > From: Feng, Bob C > Sent: Wednesday, January 9, 2019 2:44 PM > To: edk2-devel@lists.01.org > Cc: Feng, Bob

Re: [edk2] [RFC] Edk2 BaseTools Python3 Migration Update

2019-01-08 Thread Gao, Liming
high version python installed in OS. Thanks Liming >-Original Message- >From: Carsey, Jaben >Sent: Wednesday, January 09, 2019 2:06 AM >To: Laszlo Ersek ; Gao, Liming ; >Ni, Ray ; edk2-devel@lists.01.org; leif.lindh...@linaro.org; >af...@apple.com; Kinney, Michael D &

Re: [edk2] [RESEND PATCH v2 2/6] efi_loader: Initial HII database protocols

2019-01-08 Thread Gao, Liming
ts.denx.de; > edk2-devel@lists.01.org; Wang, Jian J ; Wu, > Hao A ; Ni, Ray ; Zeng, Star > ; Andrew Fish ; Kinney, > Michael D ; Ard Biesheuvel > ; Gao, Liming > Subject: Re: [RESEND PATCH v2 2/6] efi_loader: Initial HII database protocols > > On 01/08/19 10:51, Leif Li

Re: [edk2] [RFC] Edk2 BaseTools Python3 Migration Update

2019-01-08 Thread Gao, Liming
Does this policy meet with your usage? Thanks Liming > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Tuesday, January 8, 2019 3:04 AM > To: Gao, Liming ; Ni, Ray ; > edk2-devel@lists.01.org; leif.lindh...@linaro.org; > af...@apple.com; Kinne

Re: [edk2] [patch] BaseTools/VfrCompile: report error for Integer overflow

2019-01-07 Thread Gao, Liming
Reviewed-by: Liming Gao > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Dandan > Bi > Sent: Friday, December 28, 2018 4:54 PM > To: edk2-devel@lists.01.org > Cc: Gao, Liming > Subject: [edk2] [patch] BaseTools/VfrComp

Re: [edk2] [RFC] Edk2 BaseTools Python3 Migration Update

2019-01-07 Thread Gao, Liming
message to let user aware which version python tool is used in this build. Thanks Liming > -Original Message- > From: Ni, Ray > Sent: Monday, January 7, 2019 4:40 PM > To: Gao, Liming ; edk2-devel@lists.01.org > Cc: Kinney, Michael D ; Laszlo Ersek > (ler...@redhat.com) &g

Re: [edk2] [PATCH 0/6] implement standalone MM versions of the variable runtime drivers

2019-01-07 Thread Gao, Liming
: edk2-devel@lists.01.org > Cc: Ard Biesheuvel ; Laszlo Ersek > ; Leif Lindholm ; Kinney, > Michael D ; Gao, Liming ; > Wang, Jian J ; Wu, Hao A > ; Jagadeesh Ujja ; Achin Gupta > ; Thomas Panakamattam > Abraham ; Sami Mujawar > Subject: [PATCH 0/6] implement standalone

Re: [edk2] [PATCH 00/26] remove the GCC44 through GCC47 toolchains

2019-01-07 Thread Gao, Liming
definition. Thanks Liming > -Original Message- > From: Philippe Mathieu-Daudé [mailto:phi...@redhat.com] > Sent: Monday, January 7, 2019 5:44 PM > To: Laszlo Ersek ; edk2-devel-01 > Cc: Ni, Ray ; Ye, Ting ; Kinney, Michael > D ; Gao, Liming > ; Justen, Jordan L ; Anthony

Re: [edk2] [PATCH v2 3/4] MdePkg/UefiLib: Simplify protocol un/installation abstraction

2019-01-06 Thread Gao, Liming
Ashish: UefiLib implementation simplification doesn't require to change library APIs. UninstallApi() interfaces are not required to be updated. Below Install API can still be kept. I don't think we need to keep the same interfaces for Install and Uninstall APIs. EfiLibUninstallAllDriverProto

Re: [edk2] [RFC] Edk2 BaseTools Python3 Migration Update

2019-01-03 Thread Gao, Liming
2018 8:16 AM >To: Gao, Liming ; Gary Lin >Cc: edk2-devel@lists.01.org; Kinney, Michael D >Subject: Re: [edk2] [RFC] Edk2 BaseTools Python3 Migration Update > >On 12/29/18 07:07, Gao, Liming wrote: >> Lin: >>Thanks for your verification. This issue has been fixed

Re: [edk2] [Patch] BaseTools: Correct PcdArray value assigment statement

2019-01-03 Thread Gao, Liming
Reviewed-by: Liming Gao >-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of >BobCF >Sent: Saturday, December 29, 2018 4:43 PM >To: edk2-devel@lists.01.org >Cc: Gao, Liming >Subject: [edk2] [Patch] BaseTools: Correct Pcd

Re: [edk2] [PATCH 10/13] MdeModulePkg/VarCheckLib: allow MM_STANDALONE drivers to use this library

2019-01-02 Thread Gao, Liming
el > Sent: Wednesday, January 2, 2019 9:05 PM > To: Jagadeesh Ujja > Cc: edk2-devel@lists.01.org; Zhang, Chao B ; Gao, > Liming > Subject: Re: [edk2] [PATCH 10/13] MdeModulePkg/VarCheckLib: allow > MM_STANDALONE drivers to use this library > > On Fri, 14 Dec 201

Re: [edk2] [RFC] Edk2 BaseTools Python3 Migration Update

2019-01-01 Thread Gao, Liming
1, 2018 8:16 AM >To: Gao, Liming ; Gary Lin >Cc: edk2-devel@lists.01.org; Kinney, Michael D >Subject: Re: [edk2] [RFC] Edk2 BaseTools Python3 Migration Update > >On 12/29/18 07:07, Gao, Liming wrote: >> Lin: >>Thanks for your verification. This issue has been fixed

Re: [edk2] [Patch] BaseTools: Fixed build report issue.

2019-01-01 Thread Gao, Liming
Reviewed-by: Liming Gao -Original Message- >From: Feng, Bob C >Sent: Saturday, December 29, 2018 4:45 PM >To: edk2-devel@lists.01.org >Cc: Feng, Bob C ; Gao, Liming >Subject: [Patch] BaseTools: Fixed build report issue. > >From: "Feng, Bob C" > >This

Re: [edk2] Udk2018 windows GCC build errors with echo

2019-01-01 Thread Gao, Liming
Please copy echo.exe into C:\p4\stg\uefi\gnutools\GNUMake-3.81_win32 directory. It should in C:\soft\gcc-linaro-7.3.1\ directory. Thanks Liming From: Wang, Cloud [mailto:cloud.w...@amd.com] Sent: Friday, December 28, 2018 5:14 PM To: Ard Biesheuvel ; Gao, Liming ; Leif Lindholm Cc: edk2-devel

Re: [edk2] [Patch 3/5] BaseTools tools_def.template: Remove obsolete GCC44-GCC47 tool chain

2019-01-01 Thread Gao, Liming
. I am OK for the change in this patch. If you would like to contribute the patch, it will be good. Thanks Liming >-Original Message- >From: Laszlo Ersek [mailto:ler...@redhat.com] >Sent: Monday, December 31, 2018 8:57 AM >To: Gao, Liming >Cc: edk2-devel@lists.01.o

Re: [edk2] [RFC] Edk2 BaseTools Python3 Migration Update

2018-12-28 Thread Gao, Liming
Lin: Thanks for your verification. This issue has been fixed in the latest version of https://github.com/lgao4/edk2/tree/Python3. Could you try again? Thanks Liming >-Original Message- >From: Gary Lin [mailto:g...@suse.com] >Sent: Friday, December 28, 2018 6:40 PM >To:

[edk2] [RFC] Edk2 BaseTools Python3 Migration Update

2018-12-24 Thread Gao, Liming
Hi, all On Python3 migration https://bugzilla.tianocore.org/show_bug.cgi?id=55, we update Edk2 BaseTools python source code with the compatible syntax to support Python2 and Python3 both. Here is code https://github.com/lgao4/edk2/tree/Python3 for dry run. To enable Python3, you just need to

Re: [edk2] [Patch] BaseTools: Reset FdsGlobalVariable

2018-12-24 Thread Gao, Liming
Reviewed-by: Liming Gao > -Original Message- > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > Sent: Thursday, December 20, 2018 7:52 PM > To: Feng, Bob C > Cc: edk2-devel@lists.01.org; Gao, Liming > Subject: Re: [Patch] BaseTools: Reset FdsGlobalVariable &

Re: [edk2] [PATCH v1 1/5] MdePkg/BaseLib: Introduce new SpeculationBarrier API

2018-12-23 Thread Gao, Liming
Reviewed-by: Liming Gao > -Original Message- > From: Wu, Hao A > Sent: Friday, December 21, 2018 11:11 AM > To: edk2-devel@lists.01.org > Cc: Wu, Hao A ; Ard Biesheuvel > ; Leif Lindholm ; Gao, > Liming ; Kinney, Michael D > ; Yao, Jiewen ; Laszlo Ersek >

Re: [edk2] [PATCH v2] BaseTools/tools_def ARM: use softfloat target for CLANG3x

2018-12-21 Thread Gao, Liming
I have no other comments. Reviewed-by: Liming Gao > -Original Message- > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > Sent: Friday, December 21, 2018 7:02 PM > To: edk2-devel@lists.01.org > Cc: Leif Lindholm ; Gao, Liming > > Subject: Re: [PATCH v2] Ba

Re: [edk2] [PATCH 00/13] Extend secure variable service to be usable from Standalone MM

2018-12-20 Thread Gao, Liming
. Last, Platform DSC file will refer to the real StandaloneMmServicesTableLib library INF from StandaloneMmPkg. Thanks Liming > -Original Message- > From: Jagadeesh Ujja [mailto:jagadeesh.u...@arm.com] > Sent: Tuesday, December 18, 2018 7:19 PM > To: Gao, Liming > Cc: edk2

Re: [edk2] [PATCH] BaseTools/tools_def ARM: use softfloat target for CLANG3x

2018-12-19 Thread Gao, Liming
ber 19, 2018 10:50 PM >To: edk2-devel@lists.01.org >Cc: Gao, Liming >Subject: [edk2] [PATCH] BaseTools/tools_def ARM: use softfloat target for >CLANG3x > >The target triplet we use for CLANG35 and CLANG38 specifies a >hardfloat target, and so the binaries that are emitted are

Re: [edk2] [PATCH v2 1/6] MdePkg/Base: introduce MAX_ALLOC_ADDRESS

2018-12-19 Thread Gao, Liming
Reviewed-by: Liming Gao >-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ard >Biesheuvel >Sent: Thursday, December 20, 2018 4:57 AM >To: edk2-devel@lists.01.org >Cc: Andrew Jones ; Wu, Hao A ; >Gao, Liming ; Kinney, Mich

Re: [edk2] [PATCH 00/13] Extend secure variable service to be usable from Standalone MM

2018-12-17 Thread Gao, Liming
on to separate this library class. Thanks Liming >-Original Message- >From: Jagadeesh Ujja [mailto:jagadeesh.u...@arm.com] >Sent: Monday, December 17, 2018 7:47 PM >To: Gao, Liming >Cc: edk2-devel@lists.01.org; Zhang, Chao B ; >leif.lindh...@linaro.org; ard.biesheu...@

Re: [edk2] [PATCH 05/13] MdePkg/Library/BaseLib/AArch64: Add AsmLfence function

2018-12-17 Thread Gao, Liming
Liming >-Original Message- >From: Yao, Jiewen >Sent: Tuesday, December 18, 2018 10:08 AM >To: Ard Biesheuvel ; Wu, Hao A > >Cc: edk2-devel@lists.01.org; Gao, Liming ; Zhang, >Chao B >Subject: RE: [edk2] [PATCH 05/13] MdePkg/Library/BaseLib/AArch64: Add >AsmLfence

Re: [edk2] [Patch V2] BaseTools: Fix PcdArray issue

2018-12-17 Thread Gao, Liming
Reviewed-by: Liming Gao >-Original Message- >From: Philippe Mathieu-Daudé [mailto:phi...@redhat.com] >Sent: Monday, December 17, 2018 6:05 PM >To: Feng, Bob C ; edk2-devel@lists.01.org >Cc: Gao, Liming ; Ard Biesheuvel > >Subject: Re: [Patch V2] BaseTools: Fix PcdAr

Re: [edk2] [Patch V2] BaseTools: Fixed metafile parser issues

2018-12-17 Thread Gao, Liming
Bob: Please remove Change-Id: I62c00e9f439e5d632c4b3f58cc5c4181d8acc52d The patch is good to me. Reviewed-by: Liming Gao Thanks Liming >-Original Message- >From: Feng, Bob C >Sent: Monday, December 17, 2018 4:55 PM >To: edk2-devel@lists.01.org >Cc: Feng, Bob

Re: [edk2] [PATCH] ArmVirtPkg/ArmVirt.dsc.inc: define TcpIoLib resolution unconditionally

2018-12-16 Thread Gao, Liming
Siyuan: I know the windows GCC pre built binary can be downloaded from https://sourceforge.net/projects/edk2developertoolsforwindows/files/Tool%20Chain%20Binaries/. Although pre-built binary GCC is three years ago, they can still work. For example, after you download gcc492 arm, then you can s

Re: [edk2] [PATCH 05/13] MdePkg/Library/BaseLib/AArch64: Add AsmLfence function

2018-12-16 Thread Gao, Liming
t: Friday, December 14, 2018 9:54 PM >To: Jagadeesh Ujja ; Leif Lindholm > >Cc: edk2-devel@lists.01.org; Gao, Liming ; Zhang, >Chao B >Subject: Re: [PATCH 05/13] MdePkg/Library/BaseLib/AArch64: Add >AsmLfence function > >On Fri, 14 Dec 2018 at 13:13, Jagadeesh Ujja >wrote: &g

Re: [edk2] [PATCH 00/13] Extend secure variable service to be usable from Standalone MM

2018-12-16 Thread Gao, Liming
. StandaloneMmServicesTableLib is the library class. MdePkg\Library\StandaloneMmRuntimeDxe is its library instance. Thanks Liming >-Original Message- >From: Jagadeesh Ujja [mailto:jagadeesh.u...@arm.com] >Sent: Friday, December 14, 2018 8:13 PM >To: edk2-devel@lists.01.org;

Re: [edk2] [RFC PATCH v4 00/12] Extend secure variable service to be usable from Standalone MM

2018-12-13 Thread Gao, Liming
I add my comments. > -Original Message- > From: Jagadeesh Ujja [mailto:jagadeesh.u...@arm.com] > Sent: Thursday, December 13, 2018 8:00 PM > To: Gao, Liming > Cc: edk2-devel@lists.01.org; Zhang, Chao B ; Leif > Lindholm > Subject: Re: [edk2] [RFC PATCH v4 00/12] E

Re: [edk2] [Patch] BaseTools: Optimize string concatenation

2018-12-13 Thread Gao, Liming
Leif: Agree your point to prepare the data before the patch instead of after the patch. Thanks Liming > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Leif > Lindholm > Sent: Thursday, December 13, 2018 6:09 PM > To: Ga

Re: [edk2] [PATCH] Maintainers.txt: Change package maintainer and reviewer of CryptoPkg.

2018-12-13 Thread Gao, Liming
Laszlo: Yes. Long, Qin should send this patch. Because Long, Qin changes to another work group for a while, he doesn't work on edk2 project. Ting directly sends the patch to remove his name. I just include Long, Qin, and let him confirm this change. Thanks Liming > -Original Message-

Re: [edk2] [PATCH 0/3] fixes for CLANG35 on ARM

2018-12-13 Thread Gao, Liming
Yes. Reviewed-by: Liming Gao > -Original Message- > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > Sent: Thursday, December 13, 2018 6:49 PM > To: Gao, Liming > Cc: Kinney, Michael D ; edk2-devel@lists.01.org; > Laszlo Ersek > Subject: Re: [edk2]

Re: [edk2] [PATCH] ShellPkg/UefiShellDebug1CommandsLib: Remove an unused function

2018-12-12 Thread Gao, Liming
Shenglei: Please submit one BZ for this change. >-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of >Shenglei Zhang >Sent: Thursday, December 13, 2018 1:33 PM >To: edk2-devel@lists.01.org >Cc: Carsey, Jaben ; Ni, Ruiyu >Subject: [edk2] [PATCH] Sh

Re: [edk2] [Patch] BaseTools: Optimize string concatenation

2018-12-12 Thread Gao, Liming
nt: Thursday, December 13, 2018 2:37 AM >To: Feng, Bob C >Cc: Carsey, Jaben ; edk2-devel@lists.01.org; Gao, >Liming >Subject: Re: [edk2] [Patch] BaseTools: Optimize string concatenation > >On Tue, Dec 11, 2018 at 08:48:19AM +, Feng, Bob C wrote: >> Hi Leif, >> >&

Re: [edk2] [RFC PATCH v4 00/12] Extend secure variable service to be usable from Standalone MM

2018-12-12 Thread Gao, Liming
; Sent: Tuesday, December 11, 2018 2:22 PM > To: edk2-devel@lists.01.org; Gao, Liming ; Zhang, Chao > B ; leif.lindh...@linaro.org > Subject: [RFC PATCH v4 00/12] Extend secure variable service to be usable > from Standalone MM > > Changes since v3: > - Addressed all the comm

Re: [edk2] [PATCH 0/3] fixes for CLANG35 on ARM

2018-12-12 Thread Gao, Liming
Make sense. So, CLANG35 tool chain can also be used by CLANG 3.5 and above version compiler, like GCC49? > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ard > Biesheuvel > Sent: Wednesday, December 12, 2018 10:03 PM > To: Ga

Re: [edk2] [RFC] Remove unused tool chain configuration in BaseTools/Conf/tools_def.template

2018-12-12 Thread Gao, Liming
9:02 AM >To: Gao, Liming >Cc: Kinney, Michael D ; edk2- >de...@lists.01.org; Laszlo Ersek (ler...@redhat.com) >Subject: Re: [edk2] [RFC] Remove unused tool chain configuration in >BaseTools/Conf/tools_def.template > >Hello, > > >I think it's better to separate

Re: [edk2] [PATCH 0/3] fixes for CLANG35 on ARM

2018-12-12 Thread Gao, Liming
rg > Cc: Ard Biesheuvel ; Kinney, Michael D > ; Gao, Liming > ; Feng, Bob C ; Leif Lindholm > ; Laszlo Ersek > > Subject: [PATCH 0/3] fixes for CLANG35 on ARM > > Building with Clang 3.5 for ARM may result in build breakage, due to the > fact that it may emit non-adja

Re: [edk2] [Patch] edk2 Readme.md: Add edk2 release tag and edk2 release plan

2018-12-12 Thread Gao, Liming
12, 2018 6:22 PM > To: Gao, Liming ; edk2-devel@lists.01.org > Subject: Re: [edk2] [Patch] edk2 Readme.md: Add edk2 release tag and edk2 > release plan > > Hi Liming, > > On 12/12/18 01:41, Gao, Liming wrote: > > Hi, all > > I don't get any comments on thi

Re: [edk2] [Patch] edk2 Readme.md: Add edk2 release tag and edk2 release plan

2018-12-11 Thread Gao, Liming
Hi, all I don't get any comments on this change. So, I will push it this week. Thanks Liming >-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of >Liming Gao >Sent: Wednesday, December 05, 2018 10:49 PM >To: edk2-devel@lists.01.org >Subject: [edk2]

Re: [edk2] [PATCH] BaseTools/Conf/tools_def.template: drop ARM/AARCH support from GCC46/GCC47

2018-12-11 Thread Gao, Liming
Get it. I will keep it. Thanks Liming From: David F. [mailto:df7...@gmail.com] Sent: Wednesday, December 12, 2018 6:58 AM To: Gao, Liming Cc: Ard Biesheuvel ; Laszlo Ersek ; edk2 developers list Subject: Re: [edk2] [PATCH] BaseTools/Conf/tools_def.template: drop ARM/AARCH support from GCC46

Re: [edk2] [PATCH] BaseTools/GenFw ARM: don't permit R_ARM_GOT_PREL relocations

2018-12-11 Thread Gao, Liming
That's good. Reviewed-by: Liming Gao >-Original Message- >From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] >Sent: Tuesday, December 11, 2018 9:46 PM >To: Gao, Liming >Cc: Leif Lindholm ; edk2-devel@lists.01.org; Laszlo >Ersek ; Feng, Bob C >Subject: R

Re: [edk2] [Patch V3] BaseTools: Fixed bugs in CopyDict function

2018-12-11 Thread Gao, Liming
Reviewed-by: Liming Gao > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of BobCF > Sent: Tuesday, December 11, 2018 5:03 PM > To: edk2-devel@lists.01.org > Cc: Gao, Liming Reviewed-by: Liming Gao > > Subject: [edk2]

Re: [edk2] [Patch V3] BaseTools: Fixed the build fail issue for cases

2018-12-11 Thread Gao, Liming
Reviewed-by: Liming Gao > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of BobCF > Sent: Tuesday, December 11, 2018 5:04 PM > To: edk2-devel@lists.01.org > Cc: Gao, Liming > Subject: [edk2] [Patch V3] BaseTools: Fixed the bu

Re: [edk2] [Patch V3] BaseTools: Fix PcdNvStoreDefaultValueBuffer Value.

2018-12-11 Thread Gao, Liming
Reviewed-by: Liming Gao > -Original Message- > From: Feng, Bob C > Sent: Tuesday, December 11, 2018 5:04 PM > To: edk2-devel@lists.01.org > Cc: Feng, Bob C ; Gao, Liming ; > Leif Lindholm > Subject: [Patch V3] BaseTools: Fix PcdNvStoreDefaultValueBuffer Value. &g

Re: [edk2] [PATCH] BaseTools/GenFw ARM: don't permit R_ARM_GOT_PREL relocations

2018-12-11 Thread Gao, Liming
dk2-devel@lists.01.org; Laszlo Ersek ; Feng, Bob C > ; Gao, Liming > > Subject: Re: [PATCH] BaseTools/GenFw ARM: don't permit R_ARM_GOT_PREL > relocations > > On Tue, 11 Dec 2018 at 12:19, Ard Biesheuvel > wrote: > > > > On Tue, 11 Dec 2018 at 10:53, Leif L

Re: [edk2] [PATCH] BaseTools/tools_def AARCH64: move GCC49/GGC5 to 4 KB section alignment

2018-12-11 Thread Gao, Liming
I have no comments for this change. Reviewed-by: Liming Gao > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Tuesday, December 11, 2018 2:19 AM > To: Ard Biesheuvel > Cc: edk2-devel@lists.01.org; Gao, Liming > Subject: Re: [edk2] [PATCH] B

Re: [edk2] [PATCH] BaseTools/Conf/tools_def.template: drop ARM/AARCH support from GCC46/GCC47

2018-12-11 Thread Gao, Liming
age- > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > Sent: Tuesday, December 11, 2018 12:37 AM > To: Laszlo Ersek > Cc: edk2-devel@lists.01.org; Gao, Liming > Subject: Re: [edk2] [PATCH] BaseTools/Conf/tools_def.template: drop ARM/AARCH > support from GCC46/GCC47 >

Re: [edk2] [PATCH edk2-platforms] Platform/AMD/OverdriveBoard: fix byte order of default MAC addresses

2018-12-11 Thread Gao, Liming
BZ https://bugzilla.tianocore.org/show_bug.cgi?id=1390 is submit for it. Bob will fix it. > -Original Message- > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > Sent: Tuesday, December 11, 2018 3:54 PM > To: Gao, Liming > Cc: Andrew Fish ; Leif Lindholm

Re: [edk2] [PATCH 2/2] MdePkg/UefiDevicePathLib: Add a checking step

2018-12-11 Thread Gao, Liming
1 PM > To: edk2-devel@lists.01.org > Cc: Gao, Liming ; Kinney, Michael D > > Subject: [PATCH 2/2] MdePkg/UefiDevicePathLib: Add a checking step > > Add a checking step in DevicePathUtilities.c to verify DevicePath. > > Cc: Liming Gao > Cc: Michael D Kinney > Co

Re: [edk2] [PATCH edk2-platforms] Platform/AMD/OverdriveBoard: fix byte order of default MAC addresses

2018-12-10 Thread Gao, Liming
If PCD is related to one structure in DEC/DSC, it can be refer as structure pointer in C source code. Here is wiki for its usage: https://github.com/lgao4/edk2/wiki/StrucutrePcd-Usage Thanks Liming >-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf O

Re: [edk2] [Patch V2] BaseTools: Fixed the build fail issue for cases

2018-12-10 Thread Gao, Liming
Leif: OK. I understand your point. Thanks Liming > -Original Message- > From: Leif Lindholm [mailto:leif.lindh...@linaro.org] > Sent: Monday, December 10, 2018 10:45 PM > To: Gao, Liming > Cc: Feng, Bob C ; edk2-devel@lists.01.org > Subject: Re: [edk2] [Patch V2] Ba

Re: [edk2] [RFC PATCH 3/7] MdeModulePkg/Dxe/Page: take MAX_ALLOC_ADDRESS into account

2018-12-10 Thread Gao, Liming
Keep the same value of MAX_ADDRESS. There is no change now. Thanks Liming > -Original Message- > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > Sent: Monday, December 10, 2018 10:54 PM > To: Gao, Liming > Cc: Wang, Jian J ; Andrew Jones ; > Wu, Hao A ; >

Re: [edk2] [PATCH] MdeModulePkg/FileExplorerLib: avoid packed struct for program data

2018-12-10 Thread Gao, Liming
Ard: I agree this change. Leif: On the duplicated definition of HII_VENDOR_DEVICE_PATH, MdeModulePkg DriverSampleDxe first defines it and use it as the driver level definition. Other UEFI HII driver may refer to the driver sample driver and define the same structure. One centralized header

Re: [edk2] [RFC PATCH 3/7] MdeModulePkg/Dxe/Page: take MAX_ALLOC_ADDRESS into account

2018-12-10 Thread Gao, Liming
half Of Ard > Biesheuvel > Sent: Monday, December 10, 2018 3:23 PM > To: Wang, Jian J > Cc: Andrew Jones ; Wu, Hao A ; > edk2-devel@lists.01.org; Gao, Liming > ; Kinney, Michael D ; > Laszlo Ersek > Subject: Re: [edk2] [RFC PATCH 3/7] MdeModulePkg/Dxe/Page: take > MAX_ALLOC_AD

Re: [edk2] [Patch V2] BaseTools: Fixed the build fail issue for cases

2018-12-10 Thread Gao, Liming
ists.01.org] On Behalf Of Leif > Lindholm > Sent: Monday, December 10, 2018 8:30 PM > To: Feng, Bob C > Cc: edk2-devel@lists.01.org; Gao, Liming > Subject: Re: [edk2] [Patch V2] BaseTools: Fixed the build fail issue for cases > > Hi Bob, > > On Mon, Dec 10, 2018 at 0

Re: [edk2] [RFC] Remove unused tool chain configuration in BaseTools/Conf/tools_def.template

2018-12-10 Thread Gao, Liming
org] > Sent: Monday, December 10, 2018 7:57 PM > To: Gao, Liming > Cc: edk2-devel@lists.01.org; Laszlo Ersek (ler...@redhat.com) > ; af...@apple.com; Kinney, Michael D > ; Rebecca Cran > Subject: Re: [RFC] Remove unused tool chain configuration in > BaseTools/Conf/tools_def.templ

Re: [edk2] [Patch] ModuleWriteGuide: Add notes to define library instance module type

2018-12-09 Thread Gao, Liming
Thank you. I will update it and push the change. >-Original Message- >From: Bi, Dandan >Sent: Monday, December 10, 2018 9:10 AM >To: Gao, Liming ; edk2-devel@lists.01.org >Subject: RE: [Patch] ModuleWriteGuide: Add notes to define library instance >module type > >

Re: [edk2] [Patch] BaseTools: Fixed bugs in CopyDict function

2018-12-09 Thread Gao, Liming
Bob: This is a failure caused by the recent patch. Please list which commit cause this issue. Thanks Liming >-Original Message- >From: Feng, Bob C >Sent: Sunday, December 09, 2018 9:44 PM >To: edk2-devel@lists.01.org >Cc: Feng, Bob C ; Gao, Liming >Subject: [Patch

[edk2] Add wiki EDK-II-Release-Notes to record new added Wiki and update Notes in the release cycle

2018-12-06 Thread Gao, Liming
Hi, all EDK II Release Notes (https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Release-Notes) is created to record the release information when the code change is pushed in edk2 trunk. In this release cycle, if you implement new feature and add wiki page for this feature, please

Re: [edk2] [PATCH] Revert "MdePkg/ProcessorBind.h AARCH64: limit MAX_ADDRESS to 48 bits"

2018-12-06 Thread Gao, Liming
Ard Biesheuvel ; Leif Lindholm >; Gao, Liming ; Laszlo Ersek >; Eric Auger ; Andrew Jones >; Philippe Mathieu-Daude >Subject: [PATCH] Revert "MdePkg/ProcessorBind.h AARCH64: limit >MAX_ADDRESS to 48 bits" > >This reverts commit 82379bf6603274e81604d5a6f6bb14bdde616286.

Re: [edk2] Build fail using latest UDK2018

2018-12-06 Thread Gao, Liming
edksetup.bat Rebuild is to compile BaseTools C tools. It doesn’t build any thing. Thanks Liming From: Prem Kumar [mailto:perry.p...@gmail.com] Sent: Thursday, December 6, 2018 10:57 PM To: Gao, Liming Cc: edk2-devel@lists.01.org Subject: Re: [edk2] Build fail using latest UDK2018 Hi Liming

Re: [edk2] Build fail using latest UDK2018

2018-12-06 Thread Gao, Liming
[mailto:perry.p...@gmail.com] Sent: Thursday, December 6, 2018 10:42 PM To: Gao, Liming Cc: edk2-devel@lists.01.org Subject: Re: [edk2] Build fail using latest UDK2018 Recreating this issue is simple.. 1. Fresh build either NT32Pkg for x64 bit 2. Launch NT32 simulator 3. Close Nt32

[edk2] [RFC] Remove unused tool chain configuration in BaseTools/Conf/tools_def.template

2018-12-06 Thread Gao, Liming
Hi, all tools_def.template includes all tool chains. Some are not used any more. And, there is no verification for them. So, I propose to remove them. They are VS2003, VS2005, VS2008, VS2010, DDK3790, UNIXGCC, GCC44, GCC45, GCC46, GCC47, ELFGCC, CYGGCC, ICC, ICC11, MYTOOLS. If you still use so

Re: [edk2] [Patch] BaseTools: Correct CCFLAG for PcdValueInit

2018-12-06 Thread Gao, Liming
Reviewed-by: Liming Gao > -Original Message- > From: Feng, Bob C > Sent: Wednesday, November 28, 2018 5:01 PM > To: edk2-devel@lists.01.org > Cc: Gao, Liming > Subject: [Patch] BaseTools: Correct CCFLAG for PcdValueInit > > https://bugzilla.tianocore.org/sho

Re: [edk2] [PATCH v4 0/2] Remove DuetPkg and unused tools

2018-12-05 Thread Gao, Liming
Reviewed-by: Liming Gao for BaseTools part. Besides, please also update Maintainers.txt to remove DuetPkg. >-Original Message- >From: Ni, Ruiyu >Sent: Thursday, December 06, 2018 10:58 AM >To: Zhang, Shenglei ; edk2-devel@lists.01.org >Cc: Wu, Hao A ; Zhu, Yonghong

Re: [edk2] Build fail using latest UDK2018

2018-12-05 Thread Gao, Liming
How reproduce this issue? Could you list your step? >-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of >Prem Kumar >Sent: Thursday, December 06, 2018 2:37 AM >To: edk2-devel@lists.01.org >Subject: [edk2] Build fail using latest UDK2018 > >Hi All, >

Re: [edk2] [PATCH] BaseTools/CommonLib: drop the use of MAX_ADDRESS

2018-12-05 Thread Gao, Liming
Reviewed-by: Liming Gao > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ard > Biesheuvel > Sent: Wednesday, December 5, 2018 4:24 PM > To: edk2-devel@lists.01.org > Cc: ler...@redhat.com; Gao, Liming > Subject: [ed

Re: [edk2] [PATCH v2 4/6] BaseTools/DevicePath: use MAX_UINT16 as default device path max size

2018-12-04 Thread Gao, Liming
Yes. The change is necessary. > -Original Message- > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > Sent: Wednesday, December 5, 2018 3:42 PM > To: Gao, Liming > Cc: Laszlo Ersek ; edk2-devel@lists.01.org; Zhu, Yonghong > ; Feng, Bob C > ; Carsey,

Re: [edk2] Missing PI definitions?

2018-12-04 Thread Gao, Liming
Andrew: UEFI spec doesn't define them. They are the implement related definitions. They are not required to be exposed to OS. We can add one header file in MdeModulePkg to share them between DxeCore and MemoryTest driver. Besides, ECP package will be retired. There is no change for it. #defi

Re: [edk2] [PATCH v2 0/6] BaseTools: get rid of MAX_UINTN

2018-12-04 Thread Gao, Liming
Reviewed-by: Liming Gao for this serials. On patch 4, I have the same comments to Laszlo. >-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ard >Biesheuvel >Sent: Saturday, December 01, 2018 6:46 AM >To: edk2-devel@lists.

Re: [edk2] [PATCH v2 4/6] BaseTools/DevicePath: use MAX_UINT16 as default device path max size

2018-12-04 Thread Gao, Liming
Laszlo: I agree with you. MAX_UINT32 is more comfortable. Thanks Liming >-Original Message- >From: Laszlo Ersek [mailto:ler...@redhat.com] >Sent: Monday, December 03, 2018 9:06 PM >To: Ard Biesheuvel ; edk2-devel@lists.01.org >Cc: Zhu, Yonghong ; Gao, Liming >; Fe

Re: [edk2] Latest SVN Update Breaks Link

2018-12-02 Thread Gao, Liming
David: You can switch to git Edk2. Most people uses GitHub edk2. And, you are right. When you update the code from old version, please type edksetup.bat Reconfig to configure them. Thanks Liming >-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Beha

Re: [edk2] [PATCH 1/6] BaseTools/CommonLib: avoid using 'native' word size in IP address handling

2018-11-30 Thread Gao, Liming
Ard: OK. Will you send v2 patch to fix this issue? > -Original Message- > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > Sent: Thursday, November 29, 2018 11:18 PM > To: Gao, Liming > Cc: edk2-devel@lists.01.org; Laszlo Ersek ; Zhu, Yonghong > ; Feng,

Re: [edk2] [PATCH v3 0/2] Remove DuetPkg and unused tools

2018-11-30 Thread Gao, Liming
; edk2-devel@lists.01.org >Cc: Ni, Ruiyu ; Gao, Liming >Subject: RE: [edk2] [PATCH v3 0/2] Remove DuetPkg and unused tools > >For the DuetPkg change: >Reviewed-by: Hao Wu > > >For the BaseTools change: >I am not sure whether cleanup should also be done within directory: &g

Re: [edk2] [RFC PATCH v3 00/11] Extend secure variable service to be usable from Standalone MM

2018-11-29 Thread Gao, Liming
vember 28, 2018 5:35 PM > To: edk2-devel@lists.01.org; Gao, Liming ; Zhang, Chao > B ; leif.lindh...@linaro.org; > ard.biesheu...@linaro.org > Subject: [RFC PATCH v3 00/11] Extend secure variable service to be usable > from Standalone MM > > Changes since v2: > - Added &#x

Re: [edk2] [PATCH v3 05/16] MdePkg/ProcessorBind.h AARCH64: limit MAX_ADDRESS to 48 bits

2018-11-29 Thread Gao, Liming
> -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo > Ersek > Sent: Thursday, November 29, 2018 7:34 PM > To: Ard Biesheuvel > Cc: Andrew Jones ; edk2-devel@lists.01.org > Subject: Re: [edk2] [PATCH v3 05/16] MdePkg/ProcessorBind.h AARCH

Re: [edk2] [PATCH 1/6] BaseTools/CommonLib: avoid using 'native' word size in IP address handling

2018-11-29 Thread Gao, Liming
Do you verify which GCC arch? 32bit or 64bit or ARM? > -Original Message- > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > Sent: Thursday, November 29, 2018 11:14 PM > To: Gao, Liming > Cc: edk2-devel@lists.01.org; Laszlo Ersek ; Zhu, Yonghong > ; Feng, Bob

Re: [edk2] [PATCH 1/6] BaseTools/CommonLib: avoid using 'native' word size in IP address handling

2018-11-29 Thread Gao, Liming
d Biesheuvel [mailto:ard.biesheu...@linaro.org] > Sent: Thursday, November 29, 2018 8:31 PM > To: edk2-devel@lists.01.org > Cc: Ard Biesheuvel ; Laszlo Ersek > ; Zhu, Yonghong ; Gao, > Liming ; Feng, Bob C > Subject: [PATCH 1/6] BaseTools/CommonLib: avoid using 'native'

Re: [edk2] [PATCH] MdePkg/ProcessorBind.h AARCH64: limit MAX_ADDRESS to 48 bits

2018-11-29 Thread Gao, Liming
Laszlo: I add my comments. Thanks Liming > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Tuesday, November 27, 2018 10:52 PM > To: Ard Biesheuvel ; edk2-devel@lists.01.org > Cc: Gao, Liming ; Kinney, Michael D > ; leif.lindh...

Re: [edk2] [PATCH v3 0/2] SortLib for UEFI SEC

2018-11-28 Thread Gao, Liming
Push them at 864cba9598a934ae3f7ae744b75d60e07dbd9fe9.. ae960002fe7cb50bf5bd9741abc5a1aa92718fe6 >-Original Message- >From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] >Sent: Thursday, November 29, 2018 8:28 AM >To: Gao, Liming >Cc: Jeff Brasen ; Carsey, Jaben >

Re: [edk2] [PATCH v3 0/2] SortLib for UEFI SEC

2018-11-28 Thread Gao, Liming
Jeff: I have given R-B on MdeModulePkg change. If EmbeddedPkg maintainer has no comments on the change in EmbeddedPkg, I will help push your patches. Thanks Liming >-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jeff >Brasen >Sent: Thursday,

Re: [edk2] [Patch] BaseTool: Filter out unused structure pcds

2018-11-28 Thread Gao, Liming
Reviewed-by: Liming Gao >-Original Message- >From: Feng, Bob C >Sent: Thursday, November 01, 2018 10:57 PM >To: edk2-devel@lists.01.org >Cc: Feng, Bob C ; Gao, Liming >Subject: [Patch] BaseTool: Filter out unused structure pcds > >V2: >Fixed the issue that V1

Re: [edk2] [Patch v2] Maintainers.txt: Add the rule to hand over the package maintain role

2018-11-28 Thread Gao, Liming
Yes. I will update it based on your comments, then push the change. >-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of >Laszlo Ersek >Sent: Thursday, November 29, 2018 4:03 AM >To: Philippe Mathieu-Daudé ; Gao, Liming >; edk2-

Re: [edk2] [Patch] Vlv2TbltDevicePkg: ECP Cleanup.

2018-11-28 Thread Gao, Liming
Great work! After this update, there is no platform to consume EdkCompatibilityPkg. We can finally remove EdkCompatibilityPkg it from edk2 trunk. > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of zwei4 > Sent: Wednesday, November 28, 2018 9:38

Re: [edk2] [PATCH] Maintainers.txt: Update FmpDevicePkg maintainer

2018-11-27 Thread Gao, Liming
Ack-by: Liming Gao > -Original Message- > From: Zeng, Star > Sent: Wednesday, November 28, 2018 9:13 AM > To: edk2-devel@lists.01.org > Cc: Zeng, Star ; Gao, Liming ; > Kinney, Michael D > Subject: [PATCH] Maintainers.txt: Update FmpDevicePkg maintainer >

Re: [edk2] FmpDeviceLib

2018-11-27 Thread Gao, Liming
Tom: FmpDeviceLib can use UEFI driver model/driver binding protocol so it can install FMP on its device handle during the BDS/Device connection phase. It can implement RegisterFmpInstaller() to install FMP protocol in its device handle. In this way, FmpDeviceLib is like UEFI driver with UEFI d

Re: [edk2] [PATCH 1/1] MdePkg ACPI: fix the typos in Acpi61.h and Acpi62.h

2018-11-26 Thread Gao, Liming
Done at 385c0bf55a3e26dd1d3b5671f4ee69cd3f829baf. >-Original Message- >From: Gary Lin [mailto:g...@suse.com] >Sent: Tuesday, November 27, 2018 9:48 AM >To: Gao, Liming >Cc: Laszlo Ersek ; edk2-devel@lists.01.org; Kinney, >Michael D >Subject: Re: [edk2] [PATCH 1/1]

Re: [edk2] [PATCH 1/2] Readme.md: Update instructions to fetch source

2018-11-26 Thread Gao, Liming
Could you add [edk2-platform] in the title? So, I know this change is for edk2-platform repo. And, please add Contributed-under: TianoCore Contribution Agreement 1.1 before Signed-off-by. > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > N

Re: [edk2] Newbie: Getting Ovmf built

2018-11-26 Thread Gao, Liming
Do you type ". edksetup.bat BaseTools" in Edk2 directory? What output of this command? This script will add edk2 BaseTools path into system PATH, then build can be used. And, you can use GCC5 as the default tool chain. It supports GCC 5.0 or the above version. > -Original Message- >

Re: [edk2] [PATCH v2 0/6] Add DSC/FDF include segment files for network stack

2018-11-25 Thread Gao, Liming
Laszlo: Thanks Liming >-Original Message- >From: Laszlo Ersek [mailto:ler...@redhat.com] >Sent: Saturday, November 24, 2018 2:36 AM >To: Gao, Liming ; Fu, Siyuan ; >edk2-devel@lists.01.org >Cc: Ni, Ruiyu ; Ye, Ting ; Justen, >Jordan L ; Wu, Hao A ; Wu, >Jiaxin

Re: [edk2] [Patch] MdeModulePkg PCD: Add DynamicEx PcdVpdBaseAddress64 for non SPI platform

2018-11-25 Thread Gao, Liming
Good catch. I will update the patch. Thanks Liming > -Original Message- > From: Zeng, Star > Sent: Monday, November 26, 2018 9:28 AM > To: Gao, Liming ; edk2-devel@lists.01.org > Cc: Bi, Dandan ; Zeng, Star > Subject: Re: [edk2] [Patch] MdeModulePkg

Re: [edk2] [PATCH v2 0/6] Add DSC/FDF include segment files for network stack

2018-11-23 Thread Gao, Liming
Laszlo: I add my comments. > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Thursday, November 22, 2018 11:48 PM > To: Gao, Liming ; Fu, Siyuan ; > edk2-devel@lists.01.org > Cc: Ni, Ruiyu ; Ye, Ting ; Justen, > Jordan L ; Wu, Hao A >

Re: [edk2] [PATCH] BaseTools: Remove GenVtf

2018-11-23 Thread Gao, Liming
.01.org > Cc: Zhu, Yonghong ; Gao, Liming > Subject: [PATCH] BaseTools: Remove GenVtf > > GenVtf C tool is IPF specific. IPF support has been removed > from edk2 trunk. This tool can be removed. > https://bugzilla.tianocore.org/show_bug.cgi?id=1349 > > Cc: Yonghong Zhu &

<    1   2   3   4   5   6   7   8   9   10   >