remove COMPATIBLE_STRING_TOKEN as it is the same as STRING_TOKEN
remove if statement that used one or the other (identical) re
Cc: Yonghong Zhu <yonghong@intel.com>
Cc: Liming Gao <liming@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by:
Instead of recompiling it each time the API is called, just use
the global one that exists.
Cc: Yonghong Zhu <yonghong@intel.com>
Cc: Liming Gao <liming@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey <jaben.car...@intel.com&
change to the style we document as in use
Cc: Yonghong Zhu <yonghong@intel.com>
Cc: Liming Gao <liming@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey <jaben.car...@intel.com>
---
BaseTools/Source/Python/AutoGe
use __new__ and __init__ to create/manage/initialize objects in standard flow.
Cc: Yonghong Zhu <yonghong@intel.com>
Cc: Liming Gao <liming@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey <jaben.car...@intel.com>
---
BaseT
update the object factory and child classes to use standard functions
update the file to use is None instead of == None
Jaben Carsey (2):
BaseTools: Autogen - modify to use standard parent/child class
relationships
BaseTools: AutoGen should use is None not == None
BaseTools/Source
remove a never used variable.
Cc: Yonghong Zhu <yonghong@intel.com>
Cc: Liming Gao <liming@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey <jaben.car...@intel.com>
---
BaseTools/Source/Python/Common/RangeExpression.py | 9
The InArary variable serves no purpose. just do the work immediately.
Cc: Yonghong Zhu <yonghong@intel.com>
Cc: Liming Gao <liming@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey <jaben.car...@intel.com>
---
BaseTools/So
Str is created and not needed.
Cc: Yonghong Zhu <yonghong@intel.com>
Cc: Liming Gao <liming@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey <jaben.car...@intel.com>
---
BaseTools/Source/Python/Common/Expression.py | 10
The function is about C Names, not C Strings.
Move the re.compile outside the function call
Cc: Yonghong Zhu <yonghong@intel.com>
Cc: Liming Gao <liming@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey <jaben.car...@intel.com&
cleanup up some BaseTools code for simplicity.
Jaben Carsey (5):
BaseTools: Expression - remove redundant variable
BaseTools: Expression refactor function
BaseTools: Expression - change from series of if to elif
BaseTools: Expression - remove variable
BaseTools: RangeExpression - remove
Reviewed-by: Jaben Carsey <jaben.car...@intel.com>
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Ruiyu Ni
> Sent: Tuesday, March 13, 2018 12:41 AM
> To: edk2-devel@lists.01.org
> Cc: Carsey, Jaben <jaben.car...@
Reviewed-by: Jaben Carsey <jaben.car...@intel.com>
Looks good. Please clarify that this is an output flag, not a command line
flag in the commit log.
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> chenc2
> Sent: Tuesd
gINCLUDE_PATTERN is never used.
IncList is always empty.
Cc: Yonghong Zhu <yonghong@intel.com>
Cc: Liming Gao <liming@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey <jaben.car...@intel.com>
---
BaseTools/Source/
it right yourself.
If you look at the connect command you see the "-c" option to force EFI
variable consoles to be reconnected properly. That doesn't exist in reconnect,
but you can get around that with a script file. You probably want to do
something like:
Disconnect 20
Connect 20 -
Are you using this serial port? Are you connected to the device via this serial
port?
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Meenakshi Aggarwal
> Sent: Thursday, March 08, 2018 1:35 AM
> To: edk2-devel@lists.01.org
> Subject:
gWideStringPattern is not used.
Cc: Yonghong Zhu <yonghong@intel.com>
Cc: Liming Gao <liming@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey <jaben.car...@intel.com>
---
BaseTools/Source/Python/Common/GlobalData.py | 3 +--
delete a variable never uised and the comment
Cc: Yonghong Zhu <yonghong@intel.com>
Cc: Liming Gao <liming@intel.com>
Jaben Carsey (1):
BaseTools: GlobalData remove unused variable
BaseTools/Source/Python/Common/GlobalData.py | 3 +--
1 file changed, 1 insertion(+),
Reviewed-by: Jaben Carsey <jaben.car...@intel.com>
> -Original Message-
> From: Wu, Hao A
> Sent: Friday, March 02, 2018 7:05 PM
> To: edk2-devel@lists.01.org
> Cc: Wu, Hao A <hao.a...@intel.com>; Carsey, Jaben
> <jaben.car...@intel.com>; Ni, Ruiyu &l
Good catch. I wonder why that arbitrary restriction originated.
Reviewed-by: Jaben Carsey <jaben.car...@intel.com>
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Ard Biesheuvel
> Sent: Thursday, March 01, 2018 1:39 A
Thanks Laszlo!
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Laszlo Ersek
> Sent: Friday, February 23, 2018 4:02 AM
> To: Meenakshi Aggarwal <meenakshi.aggar...@nxp.com>
> Cc: Ni, Ruiyu <ruiyu...@intel.com&g
Seems good to me. I will let Ray review also.
Reviewed-by: Jaben Carsey <jaben.car...@intel.com>
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Meenakshi
> Sent: Friday, February 16, 2018 12:45 AM
> To: Ni, Ruiy
Reviewed-by: Jaben Carsey <jaben.car...@intel.com>
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Ruiyu Ni
> Sent: Tuesday, February 13, 2018 1:45 AM
> To: edk2-devel@lists.01.org
> Cc: Carsey, Jaben <jaben.
Reviewed-by: Jaben Carsey <jaben.car...@intel.com>
> -Original Message-
> From: Ni, Ruiyu
> Sent: Tuesday, February 13, 2018 12:54 AM
> To: edk2-devel@lists.01.org
> Cc: Vladimir Olovyannikov <vladimir.olovyanni...@broadcom.com>; Carsey,
> Jaben <jaben.ca
So I thought we are keeping the command, but I do agree with Leif that better
error path logic would be good. We can wait for Ray to confirm if he has
different plans.
-Jaben
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
>
Meenakshi,
The TFTP command is outside the UEFI Shell specification, therefore it is
included as a DynamicCommand, not a command built into the shell itself.
I a little confused by your last sentence. Do you want to send a new patch? or
do you have a branch to pick changes from ?
-Jaben
Reviewed-by: Jaben Carsey <jaben.car...@intel.com>
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Ruiyu Ni
> Sent: Monday, February 12, 2018 7:34 AM
> To: edk2-devel@lists.01.org
> Cc: Carsey, Jaben <jaben.car...@
Reviewed-by: Jaben Carsey <jaben.car...@intel.com>
> -Original Message-
> From: Ni, Ruiyu
> Sent: Monday, February 12, 2018 7:34 AM
> To: edk2-devel@lists.01.org
> Cc: Felix <fel...@mail.ru>; Carsey, Jaben <jaben.car...@intel.com>
> Subject: [PATCH] Sh
Reviewed-by: Jaben Carsey <jaben.car...@intel.com>
> -Original Message-
> From: Ni, Ruiyu
> Sent: Sunday, February 11, 2018 7:18 AM
> To: edk2-devel@lists.01.org
> Cc: Carsey, Jaben <jaben.car...@intel.com>
> Subject: [PATCH] ShellPkg/help: Fix "-?&quo
Reviewed-by: Jaben Carsey <jaben.car...@intel.com>
> -Original Message-
> From: Laszlo Ersek [mailto:ler...@redhat.com]
> Sent: Monday, February 12, 2018 5:45 AM
> To: edk2-devel-01 <edk2-devel@lists.01.org>
> Cc: Andrew Fish <af...@apple.com>; Ard Bieshe
I think that is fine. I don’t think that there is a difference except the
ShellCloseFile() is only available inside the shell, while the protocol API is
available to applications that open the ShellProtocol.
-Jaben
> -Original Message-
> From: Ni, Ruiyu
> Sent: Sunday, Fe
Reviewed-by: Jaben Carsey <jaben.car...@intel.com>
> -Original Message-
> From: Ni, Ruiyu
> Sent: Wednesday, February 07, 2018 8:45 PM
> To: edk2-devel@lists.01.org
> Cc: Carsey, Jaben <jaben.car...@intel.com>
> Subject: [PATCH] ShellPkg/hexedit: Fix a re
Reviewed-by: Jaben Carsey <jaben.car...@intel.com>
> -Original Message-
> From: Ni, Ruiyu
> Sent: Wednesday, February 07, 2018 7:41 PM
> To: edk2-devel@lists.01.org
> Cc: Carsey, Jaben <jaben.car...@intel.com>
> Subject: [PATCH] ShellPkg/rm: fix hang whe
Reviewed-by: Jaben Carsey <jaben.car...@intel.com>
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Laszlo Ersek
> Sent: Wednesday, February 07, 2018 2:45 PM
> To: edk2-devel@lists.01.org
> Cc: Ni, Ruiyu <ruiyu..
Reviewed-by Jaben Carsey <jaben.car...@intel.com>
> On Feb 6, 2018, at 2:01 PM, Laszlo Ersek <ler...@redhat.com> wrote:
>
> Repo: https://github.com/lersek/edk2.git
> Branch: sync_defs_to_decls
>
> The patches say it all, just a side remark up here:
>
>
Reviewed-by: Jaben Carsey <jaben.car...@intel.com>
> -Original Message-
> From: Ni, Ruiyu
> Sent: Sunday, February 04, 2018 9:50 PM
> To: edk2-devel@lists.01.org
> Cc: Carsey, Jaben <jaben.car...@intel.com>; Wang, Jian J
> <jian.j.w...@intel.com>
>
Reviewed-by: Jaben Carsey <jaben.car...@intel.com>
> -Original Message-
> From: Ni, Ruiyu
> Sent: Sunday, February 04, 2018 11:54 PM
> To: edk2-devel@lists.01.org
> Cc: Carsey, Jaben <jaben.car...@intel.com>
> Subject: [PATCH] ShellPkg/for: Fix po
for series.
Reviewed-by: Jaben Carsey <jaben.car...@intel.com>
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Ruiyu Ni
> Sent: Friday, January 26, 2018 1:51 AM
> To: edk2-devel@lists.01.org
> Subject:
Reviewed-by: Jaben Carsey <jaben.car...@intel.com>
> -Original Message-
> From: Gao, Liming
> Sent: Thursday, January 25, 2018 1:54 AM
> To: Ni, Ruiyu <ruiyu...@intel.com>; edk2-devel@lists.01.org
> Cc: Carsey, Jaben <jaben.car...@intel.com>
> Sub
Agree that the internal use is questionable.
Reviewed-by: Jaben Carsey <jaben.car...@intel.com>
> -Original Message-
> From: Palmer, Thomas [mailto:thomas.pal...@hpe.com]
> Sent: Monday, January 08, 2018 10:07 AM
> To: Laszlo Ersek <ler...@redhat.com>; edk2-deve
t in their basic info, while most just have protocol name.
-Jaben
From: af...@apple.com [mailto:af...@apple.com]
Sent: Wednesday, December 13, 2017 9:29 PM
To: Udit Kumar <udit.ku...@nxp.com>
Cc: Carsey, Jaben <jaben.car...@intel.com>; edk2-devel@lists.01.org
Subject: Re: [edk2] Documen
Udit,
There are some examples in the shell spec just before the table you found, but
no exact output requirement for dh. What handle information are you looking
for? Maybe we can add that to the dynamic help for the command (the stuff
users can see from "dh =?").
-Jaben
>
Reviewed-by: Jaben Carsey <jaben.car...@intel.com>
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Ruiyu Ni
> Sent: Tuesday, November 28, 2017 4:02 AM
> To: edk2-devel@lists.01.org
> Subject: [edk2] [PATCH 0/2] Fi
Reviewed-by: Jaben Carsey <jaben.car...@intel.com>
> -Original Message-
> From: Ni, Ruiyu
> Sent: Tuesday, November 28, 2017 1:07 AM
> To: edk2-devel@lists.01.org
> Cc: Carsey, Jaben <jaben.car...@intel.com>
> Subject: [PATCH] ShellPkg: Fix the bug t
Reviewed-by: Jaben Carsey <jaben.car...@intel.com>
> -Original Message-
> From: Ni, Ruiyu
> Sent: Tuesday, November 28, 2017 12:38 AM
> To: edk2-devel@lists.01.org
> Cc: Carsey, Jaben <jaben.car...@intel.com>
> Subject: [PATCH 1/6] ShellPkg/tftp: Correct fi
Reviewed-by: Jaben Carsey <jaben.car...@intel.com>
> -Original Message-
> From: Ni, Ruiyu
> Sent: Sunday, November 26, 2017 9:56 PM
> To: edk2-devel@lists.01.org
> Cc: Carsey, Jaben <jaben.car...@intel.com>; Kinney, Michael D
> <michael.d.kin...@in
This is not saying that patches were not missed in the past, but the
goal is to fix the situation going forwards.
-Jaben
>
> Thanks
> Michael
>
> On Mon, Nov 13, 2017 at 2:28 PM, Laszlo Ersek <ler...@redhat.com> wrote:
> > Hi,
> >
> > On 11/10/17
Reviewed-by: Jaben Carsey <jaben.car...@intel.com>
And pushed.
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Laszlo Ersek
> Sent: Monday, November 13, 2017 5:27 AM
> To: Thiebaud Weksteen <tw...@google.com&g
Why not use the StrCpy_s function to copy strings? CopyMem and StrSize feels
odd to me.
> -Original Message-
> From: Wang, Jian J
> Sent: Tuesday, November 07, 2017 6:12 PM
> To: edk2-devel@lists.01.org
> Cc: Carsey, Jaben <jaben.car...@intel.com>; Ni, Ruiyu
>
Reviewed-by: Jaben Carsey <jaben.car...@intel.com>
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Ruiyu Ni
> Sent: Monday, November 06, 2017 11:35 PM
> To: edk2-devel@lists.01.org
> Cc: Carsey, Jaben <jaben.
Reviewed-by: Jaben Carsey <jaben.car...@intel.com>
> -Original Message-
> From: Ni, Ruiyu
> Sent: Friday, November 03, 2017 1:59 AM
> To: edk2-devel@lists.01.org
> Cc: Carsey, Jaben <jaben.car...@intel.com>
> Subject: [PATCH] ShellPkg/HexEdit: Fix EBC bu
Reviewed-by: Jaben Carsey <jaben.car...@intel.com>
> -Original Message-
> From: Ni, Ruiyu
> Sent: Wednesday, November 01, 2017 3:13 AM
> To: edk2-devel@lists.01.org
> Cc: Carsey, Jaben <jaben.car...@intel.com>
> Subject: [PATCH] ShellPkg/hexeditor: Use CpuIo
Are we redefining a function from BaseLib? Why not remove the redundant
definition instead of making it match?
-Jaben
> -Original Message-
> From: Paulo Alcantara [mailto:pa...@hp.com]
> Sent: Friday, October 27, 2017 9:24 AM
> To: edk2-devel@lists.01.org
> Cc: Paul
Reviewed-by: Jaben Carsey <jaben.car...@intel.com>
> -Original Message-
> From: Ni, Ruiyu
> Sent: Tuesday, October 24, 2017 6:03 PM
> To: edk2-devel@lists.01.org
> Cc: Carsey, Jaben <jaben.car...@intel.com>; Wu, Hao A
> <hao.a...@intel.com>
> Subj
I don't remember. Is there a defect in the Bugzilla?
> -Original Message-
> From: Tim Lewis [mailto:tim.le...@insyde.com]
> Sent: Tuesday, October 24, 2017 12:14 PM
> To: Carsey, Jaben <jaben.car...@intel.com>; jim.dai...@dell.com; Ni, Ruiyu
> <ruiyu...@intel.com
Yes.
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> jim.dai...@dell.com
> Sent: Tuesday, October 24, 2017 11:20 AM
> To: Carsey, Jaben <jaben.car...@intel.com>; Ni, Ruiyu <ruiyu...@intel.com>
> Cc: edk2-devel
Reviewed-by: Jaben Carsey <jaben.car...@intel.com>
> -Original Message-
> From: Ni, Ruiyu
> Sent: Monday, October 23, 2017 10:38 PM
> To: edk2-devel@lists.01.org
> Cc: Carsey, Jaben <jaben.car...@intel.com>
> Subject: [PATCH] ShellPkg/HandleParsingLib: Remov
Reviewed-by: Jaben Carsey <jaben.car...@intel.com>
> -Original Message-
> From: Ni, Ruiyu
> Sent: Thursday, October 19, 2017 12:44 AM
> To: edk2-devel@lists.01.org
> Cc: Li, Huajing <huajing...@intel.com>; Carsey, Jaben
> <jaben.car...@intel.com>
&g
Reviewed-by: Jaben Carsey <jaben.car...@intel.com>
> -Original Message-
> From: Ni, Ruiyu
> Sent: Wednesday, October 18, 2017 11:15 PM
> To: edk2-devel@lists.01.org
> Cc: Carsey, Jaben <jaben.car...@intel.com>
> Subject: [PATCH] ShellPkg/editor: Fix syste
Reviewed-by: Jaben Carsey <jaben.car...@intel.com>
We could also use some PCDs if different people really want different colors in
the future...
> -Original Message-
> From: Ni, Ruiyu
> Sent: Monday, October 16, 2017 12:31 AM
> To: edk2-devel@lists.01.org
> Cc: Car
I am fine. Ray?
Reviewed-by: Jaben Carsey <jaben.car...@intel.com>
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Meenakshi Aggarwal
> Sent: Sunday, October 08, 2017 11:28 PM
> To: Fu, Siyuan <siyuan...@intel.com&g
Reviewed-by: Jaben Carsey <jaben.car...@intel.com>
Do you know under what conditions the API will fail? Is it worth saying
something like media stats unknown when the function fails?
Ray,
What do you think?
> -Original Message-
> From: Meenakshi Aggarwal [mailto:mee
017 10:10 AM
> To: Carsey, Jaben <jaben.car...@intel.com>; edk2-devel@lists.01.org; Wu,
> Jiaxin <jiaxin...@intel.com>; Ni, Ruiyu <ruiyu...@intel.com>
> Subject: RE: [PATCH] Ifconfig : Fixed False information about Media State.
> Importance: High
>
> Yes, its mo
Is there a reason to move the assignment in the function? I think our coding
guidelines specify initialize variables up top.
-Jaben
> -Original Message-
> From: Meenakshi Aggarwal [mailto:meenakshi.aggar...@nxp.com]
> Sent: Wednesday, October 04, 2017 11:37 PM
> To: edk2-de
Ray,
This text is taken directly from the shell spec. Do we need to fix that also?
> -Original Message-
> From: Ni, Ruiyu
> Sent: Thursday, September 28, 2017 10:21 AM
> To: edk2-devel@lists.01.org
> Cc: Carsey, Jaben <jaben.car...@intel.com>
> Subject: [PATCH 1
Reviewed-by: Jaben Carsey <jaben.car...@intel.com>
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Ruiyu Ni
> Sent: Thursday, September 28, 2017 10:21 AM
> To: edk2-devel@lists.01.org
> Subject: [edk2] [PATCH 0/2]
Reviewed-by: Jaben Carsey <jaben.car...@intel.com>
> -Original Message-
> From: Ni, Ruiyu
> Sent: Thursday, September 28, 2017 1:50 AM
> To: Wu, Hao A <hao.a...@intel.com>; edk2-devel@lists.01.org
> Cc: Carsey, Jaben <jaben.car...@intel.com>
> Subj
Reviewed-by: Jaben Carsey <jaben.car...@intel.com>
> -Original Message-
> From: Ni, Ruiyu
> Sent: Wednesday, September 27, 2017 11:37 PM
> To: edk2-devel@lists.01.org
> Cc: Li, Huajing <huajing...@intel.com>; Carsey, Jaben
> <jaben.car...@intel.com
Reviewed-by: Jaben Carsey <jaben.car...@intel.com>
> -Original Message-
> From: Ni, Ruiyu
> Sent: Wednesday, September 27, 2017 11:37 PM
> To: edk2-devel@lists.01.org
> Cc: Li, Huajing <huajing...@intel.com>; Carsey, Jaben
> <jaben.car...@intel.com>
>
Reviewed-by: Jaben Carsey <jaben.car...@intel.com>
> -Original Message-
> From: Ni, Ruiyu
> Sent: Wednesday, September 27, 2017 10:57 PM
> To: Bi, Dandan <dandan...@intel.com>; edk2-devel@lists.01.org
> Cc: Carsey, Jaben <jaben.car...@intel.com>
> Subj
> -Original Message-
> From: Wu, Hao A
> Sent: Wednesday, September 27, 2017 5:43 AM
> To: edk2-devel@lists.01.org
> Cc: Wu, Hao A <hao.a...@intel.com>; Ni, Ruiyu <ruiyu...@intel.com>;
> Carsey, Jaben <jaben.car...@intel.com>
> Subject: [PATCH]
Liming, I agree this works, but I think Laszlo's change to make the GuidName a
CONST CHAR makes more sense.
Jaben
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Liming Gao
> Sent: Thursday, September 21, 2017 11:36 PM
>
For series. Good changes all. DH is a lifesaver.
Reviewed-by: Jaben Carsey <jaben.car...@intel.com>
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Ruiyu Ni
> Sent: Thursday, September 21, 2017 10:50 PM
> To: ed
Reviewed-by: Jaben Carsey <jaben.car...@intel.com>
> -Original Message-
> From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org]
> Sent: Friday, September 22, 2017 6:44 AM
> To: Laszlo Ersek <ler...@redhat.com>
> Cc: edk2-devel@lists.01.org; Carsey, Jaben &
Reviewed-by: Jaben Carsey <jaben.car...@intel.com>
> -Original Message-
> From: Ni, Ruiyu
> Sent: Wednesday, September 20, 2017 10:30 PM
> To: Carsey, Jaben <jaben.car...@intel.com>; edk2-devel@lists.01.org
> Cc: Li, Huajing <huajing...@intel.com>
> Su
ntly uses PCI with file input as long
as current behavior still works it should be fine.
I would think that would be a great improvement for the PCI command.
-Jaben
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> jim.dai...@dell.co
Reviewed-by: Jaben Carsey <jaben.car...@intel.com>
> -Original Message-
> From: Wu, Hao A
> Sent: Tuesday, September 19, 2017 4:39 AM
> To: edk2-devel@lists.01.org
> Cc: Wu, Hao A <hao.a...@intel.com>; Ni, Ruiyu <ruiyu...@intel.com>;
> Carsey, Jaben &
Whats the difference between HEADER_LINE and HEADER_LINE2? They look the same
to me...
> -Original Message-
> From: Ni, Ruiyu
> Sent: Sunday, September 17, 2017 11:42 PM
> To: edk2-devel@lists.01.org
> Cc: Li, Huajing <huajing...@intel.com>; Carsey, Jaben
>
Reviewed-by: Jaben Carsey <jaben.car...@intel.com>
> -Original Message-
> From: Dong, Eric
> Sent: Wednesday, September 13, 2017 3:10 AM
> To: edk2-devel@lists.01.org
> Cc: Daryl McDaniel <edk2-li...@mc2research.org>; Carsey, Jaben
> <jaben.car...@intel.co
Can you explain what is different in this modified shell.efi that functions as
expected?
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Santhapur Naveen
> Sent: Thursday, August 31, 2017 1:35 AM
> To: edk2-devel@lists.01.org
> Subject:
Series.
Reviewed-by: Jaben Carsey <jaben.car...@intel.com>
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ruiyu
> Ni
> Sent: Tuesday, August 29, 2017 1:11 AM
> To: edk2-devel@lists.01.org
> Subject: [edk2] [PATCH 0/3
Looks good to me.
Daryl?
> -Original Message-
> From: Thomas Palmer [mailto:thomas.pal...@hpe.com]
> Sent: Thursday, August 10, 2017 3:35 PM
> To: edk2-devel@lists.01.org
> Cc: edk2-li...@mc2research.org; Carsey, Jaben <jaben.car...@intel.com>;
> joseph.shiffl..
Reviewed-by: Jaben Carsey <jaben.car...@intel.com>
> -Original Message-
> From: Tapan Shah [mailto:tapands...@hpe.com]
> Sent: Friday, June 09, 2017 10:11 AM
> To: edk2-devel@lists.01.org
> Cc: Carsey, Jaben <jaben.car...@intel.com>; Ni, Ruiyu
> <ruiyu..
Reviewed-by: Jaben Carsey <jaben.car...@intel.com>
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Ruiyu Ni
> Sent: Thursday, June 08, 2017 8:11 PM
> To: edk2-devel@lists.01.org
> Cc: Carsey, Jaben <jaben.car...@
Wonder if we should refactor FILE_NOT_FOUND, DIR_NOT_FOUND, and this into "%s
'%s' not found"?
> -Original Message-
> From: Shah, Tapan [mailto:tapands...@hpe.com]
> Sent: Thursday, June 08, 2017 9:14 AM
> To: Carsey, Jaben <jaben.car...@intel.com>; Ni, Rui
_DEVICE_ERROR;
}
}
Then add a STR_GEN_ERR_NOT_FOUND string?
> -Original Message-
> From: Shah, Tapan [mailto:tapands...@hpe.com]
> Sent: Thursday, June 08, 2017 9:01 AM
> To: Ni, Ruiyu <ruiyu...@intel.com>
> Cc: Carsey, Jaben <jaben.car...@intel.com>; edk2-devel@
Seems quite straight forward to me.
Reviewed-by: Jaben Carsey <jaben.car...@intel.com>
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Shah, Tapan
> Sent: Thursday, June 08, 2017 8:55 AM
> To: Hegde, Nagaraj P <nagara
Hi all,
I am going to be gone until early august without access to my email after this
week. Mike Kinney has graciously agreed to handle reviewing code patches in my
place until I return.
Thanks Mike!
Thanks,
-Jaben
___
edk2-devel mailing list
Reviewed-by: Jaben Carsey <jaben.car...@intel.com>
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Ruiyu Ni
> Sent: Tuesday, June 06, 2017 10:52 PM
> To: edk2-devel@lists.01.org
> Cc: Carsey, Jaben <jaben.car...@
I am good with more clear error information coming to the user.
Reviewed-by: Jaben Carsey <jaben.car...@intel.com>
> -Original Message-
> From: Ni, Ruiyu
> Sent: Tuesday, June 06, 2017 2:26 PM
> To: Ni, Ruiyu <ruiyu...@intel.com>; edk2-devel@lists.01.org
&
of the list has nothing to do with the shell’s version.
Sadly, the UEFI Shell spec doesn’t assume that shell applications will want
access to the handle index concept that I can think of.
I think that your current solution is the best one.
-Jaben
From: GN Keshava [mailto:keshava...@gmail.com
, then maybe we should
consider that missing information to be added to the shell protocol.
-Jaben
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> GN Keshava
> Sent: Tuesday, June 06, 2017 9:12 AM
> To: Carsey, Jaben <jabe
That library may require the module to be linked into the shell. Remember that
the sermode command is actually in the same binary as the shell and the shell
and the command are sharing information through libraries.
> -Original Message-
> From: edk2-devel
I like removing the special local version of the function.
Reviewed-by: Jaben Carsey <jaben.car...@intel.com>
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ni,
> Ruiyu
> Sent: Tuesday, June 06, 2017 1:44 AM
>
Ok. I see now. Thanks!
Reviewed-by: Jaben Carsey <jaben.car...@intel.com>
> -Original Message-
> From: Ni, Ruiyu
> Sent: Thursday, June 01, 2017 7:32 PM
> To: Carsey, Jaben <jaben.car...@intel.com>; edk2-devel@lists.01.org
> Cc: Kinney, Michael D <mic
I think we have to leave the behavior the same. The spec says this: " If the
environment variable does not exist and the Value is an empty string, there is
no action."
I do not think we can change that to an error return without a spec change.
-Jaben
> -Original Messag
I just think we may want to have the behavior act the same as it does today for
delete.
> -Original Message-
> From: Ni, Ruiyu
> Sent: Thursday, June 01, 2017 8:19 AM
> To: Carsey, Jaben <jaben.car...@intel.com>; edk2-devel@lists.01.org
> Cc: Kinney, Michael D <mi
before: "We
dont check the error return on purpose since the variable may not exist."
-Jaben
> -Original Message-
> From: Ni, Ruiyu
> Sent: Thursday, June 01, 2017 7:12 AM
> To: edk2-devel@lists.01.org
> Cc: Carsey, Jaben <jaben.car...@intel.com>; Kin
Keshava,
After you remove and replug it, I think you need to do "connect -r" to
recursively reconnect drivers, then do the "map -r" to generate a new mapping.
Reconnecting drivers is standard user behavior after plug in a USB device. It
is not expected to happen au
I think that you will always need to inform the UEFI Shell of the change. It
is not designed to automatically do detection of added/removed/changed devices.
I think that your solution to use the code from mount makes the most sense.
-Jaben
From: GN Keshava [mailto:keshava...@gmail.com]
Sent
You can "disconnect" the driver
You can do "map -d" to delete a mapping
I am unsure what your goals are for mount/unmount
-Jaben
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> GN Keshava
> Sent: Wednesday,
501 - 600 of 984 matches
Mail list logo
