Re: [edk2] [PATCH v3 02/16] EmbeddedPkg/PrePiHobLib: drop CreateHobList() from library

ORY, Attributes, > (UINTN)MemoryBegin, MemoryLength); > - > - BuildStackHob ((EFI_PHYSICAL_ADDRESS)(UINTN)StackBase, ((UINTN)MemoryBegin > + MemoryLength) - (UINTN)StackBase); > - > - if (FeaturePcdGet (PcdPrePiProduceMemoryTypeInformationHob)) { > -// Optional feature that helps

Re: [edk2] [PATCH v3 01/16] EmbeddedPkg/TemplateSec: remove unused module

/TemplateSec.inf | 65 - > EmbeddedPkg/TemplateSec/TemplateSec.c | 76 > 2 files changed, 141 deletions(-) Reviewed-by: Laszlo Ersek ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [PATCH v2 2/2] ArmVirtPkg/QemuVirtMemInfoLib: remove 1:1 mapping of top of PA range

On 11/27/18 22:18, Ard Biesheuvel wrote: > On Tue, 27 Nov 2018 at 21:25, Laszlo Ersek wrote: >> >> On 11/27/18 18:52, Ard Biesheuvel wrote: >>> On Tue, 27 Nov 2018 at 18:26, Laszlo Ersek wrote: >>>> >>>> On 11/27/18 15:54, Ard Biesheuvel wrote: &g

Re: [edk2] [Patch] Maintainers.txt: Add the rule to hand over the package maintain role

On 11/28/18 08:31, Liming Gao wrote: > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Liming Gao > --- > Maintainers.txt | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/Maintainers.txt b/Maintainers.txt > index 91a4657adc..d75bbe278d 100644 >

Re: [edk2] [edk2-announce] Research Request

On 11/27/18 22:55, Brian J. Johnson wrote: > On 11/27/18 6:53 AM, Laszlo Ersek wrote: >> On 11/26/18 22:43, Jeremiah Cox via edk2-devel wrote: >>> Feedback on GitHub as follows… >>> >>> >>>> 1. No Lock-In - What automated data export is available? &

Re: [edk2] [PATCH v2 2/2] ArmVirtPkg/QemuVirtMemInfoLib: remove 1:1 mapping of top of PA range

On 11/27/18 18:52, Ard Biesheuvel wrote: > On Tue, 27 Nov 2018 at 18:26, Laszlo Ersek wrote: >> >> On 11/27/18 15:54, Ard Biesheuvel wrote: >>> Currently, we map DRAM as EFI_MEMORY_WB, and the remainder of the >>> entire virtual address space is map

Re: [edk2] [PATCH v2 1/2] ArmVirtPkg/FdtPciHostBridgeLib: map ECAM and I/O spaces in GCD memory map

or the CPU view, (*IoBase + IoTranslation), as first argument. (I do agree that the DEBUG message right at the end of the function could be misleading; it prints Io[0x%Lx+0x%Lx)@0x%Lx from *IoBase, *IoSize, IoTranslation ) > + ASSERT_EFI_ERROR (Status); > + > + return Status; > } > > STATIC PCI_ROOT_BRIDGE mRootBridge; > With (2) fixed: Reviewed-by: Laszlo Ersek Thanks, Laszlo ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [PATCH v2 2/2] ArmVirtPkg/QemuVirtMemInfoLib: remove 1:1 mapping of top of PA range

00, 0x2eff }, but we need not do anything about that specifically, because we advertize it to PciHostBridgeDxe via our FdtPciHostBridgeLib instance, and PciHostBridgeDxe handles the GCD aspects for the range automatically. So, together with patch #1, I think this is safe. If we catch

Re: [edk2] [PATCH] MdePkg/ProcessorBind.h AARCH64: limit MAX_ADDRESS to 48 bits

On 11/27/18 13:27, Ard Biesheuvel wrote: > AArch64 support the use of more than 48 bits for physical and/or > virtual addressing, but only if the page size is set to 64 KB, > which is not supported by UEFI/EDK2. So redefine MAX_ADDRESS to > cover only 48 address bits. > > Contributed-under: TianoC

Re: [edk2] [PATCH v2 00/13] ArmPkg, ArmVirtPkg: lift 40-bit IPA space limit

On 11/27/18 13:13, Ard Biesheuvel wrote: > On Tue, 27 Nov 2018 at 13:11, Laszlo Ersek wrote: >> >> On 11/26/18 23:37, Ard Biesheuvel wrote: >>> The ArmVirtQemu targets currently limit the size of the IPA space to >>> 40 bits because that is all what KVM suppor

Re: [edk2] [edk2-announce] Research Request

On 11/26/18 22:43, Jeremiah Cox via edk2-devel wrote: > Feedback on GitHub as follows… > > >> 1. No Lock-In - What automated data export is available? >> We want to be able to leave and take all our data with us. "Data" here >> includes: review comments, pull requests / patches (including metada

Re: [edk2] [PATCH v2 00/13] ArmPkg, ArmVirtPkg: lift 40-bit IPA space limit

On 11/26/18 23:37, Ard Biesheuvel wrote: > The ArmVirtQemu targets currently limit the size of the IPA space to > 40 bits because that is all what KVM supports. However, this is about > to change, and so we need to update the code if we want to ensure that > our UEFI firmware builds can keep runnin

Re: [edk2] Edk2 2019 Q1 stable tag planning is added into EDK-II-Release-Planning wiki

On 11/12/18 11:57, Laszlo Ersek wrote: > On 11/09/18 15:25, Gao, Liming wrote: >> Hi, all >> Next edk2 stable tag planning has been added into EDK-II-Release-Planning >> wiki >> https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Release-Planning. >

Re: [edk2] [PATCH 0/4] OvmfPkg, ArmVirtPkg: add ACPI Test Support

On 11/26/18 18:21, Ard Biesheuvel wrote: > On Sun, 25 Nov 2018 at 11:02, Laszlo Ersek wrote: >> >> Repo: https://github.com/lersek/edk2.git >> Branch: acpi_test_support >> >> The feature is described in the first patch. Build OvmfPkg and >> ArmVirtPkg p

Re: [edk2] [PATCH 1/4] OvmfPkg: introduce ACPI Test Support data structure and GUID

On 11/26/18 22:43, Philippe Mathieu-Daudé wrote: > Hi Laszlo, > > On 25/11/18 11:01, Laszlo Ersek wrote: >> QEMU's test suite includes a set of cases called "BIOS tables test". Among >> other things, it locates the RSD PTR ACPI table in guest RAM, and the

Re: [edk2] [PATCH v2 0/6] Add DSC/FDF include segment files for network stack

Hi Liming, On 11/26/18 04:31, Gao, Liming wrote: > [...] Thanks, I think I understand your points better. That doesn't mean that I agree with all of your points. :) My suggestion/request is that this series please drop the OvmfPkg & ArmVirtPkg patches for now, as it's obvious that my preference

Re: [edk2] [PATCH 5/5] ArmVirtPkg: revert PcdPrePiCpuMemorySize to is default value of 48

(1) s/is/its/ in $SUBJECT, please. On 11/23/18 13:14, Ard Biesheuvel wrote: > Drop the PcdPrePiCpuMemorySize definitions that limit it to 40 > bits on AArch64 targets. Indeed, after this series is applied, we still have [PcdsFixedAtBuild.ARM] gEmbeddedTokenSpaceGuid.PcdPrePiCpuMemorySize|40 l

Re: [edk2] [PATCH 4/5] ArmVirtPkg: disregard PcdPrePiCpuMemorySize PCD when sizing the GCD space

On 11/23/18 13:14, Ard Biesheuvel wrote: > Move the call to BuildCpuHob () into ArmVirtMemoryInitPeiLib (which is > shared between all the ArmVirtPkg targets), and drop the inclusion of > CpuPei.inf [which calls it on ArmVirtQemu] and the BuildCpuHob () call > from ArmVirtPrePiUniCoreRelocatable [f

Re: [edk2] [PATCH 0/5] ArmPkg, ArmVirtPkg: lift 40-bit IPA space limit

find it helpful to handle ArmVirtMemInfoLib right after the introduction of the helper. The actual consumers (in need of functional updates) are the page tables and the GCD memory space map (two concepts, not three). If you think this would be an improvement, please consider the reordering. No nee

Re: [edk2] [PATCH 2/5] ArmPkg/ArmMmuLib: take the CPU supported maximum PA space into account

On 11/26/18 10:42, Laszlo Ersek wrote: > On 11/23/18 13:14, Ard Biesheuvel wrote: >> In preparation of permitting the virt code to define a larger PA space >> size via gEmbeddedTokenSpaceGuid.PcdPrePiCpuMemorySize than what the >> CPU actually supports, take the CPU's

Re: [edk2] [PATCH 3/5] ArmVirtPkg: refactor reading of the physical address space size

t; @@ -39,6 +34,7 @@ ArmGetPhysAddrTop ( > VOID > EFIAPI > ArmVirtGetMemoryMap ( > + IN EFI_PHYSICAL_ADDRESS TopOfAddressSpace, >OUT ARM_MEMORY_REGION_DESCRIPTOR **VirtualMemoryMap >) > { > @@ -51,7 +47,7 @@ ArmVirtGetMemoryMap ( >// &g

Re: [edk2] [PATCH 2/5] ArmPkg/ArmMmuLib: take the CPU supported maximum PA space into account

On 11/26/18 10:42, Laszlo Ersek wrote: > On 11/23/18 13:14, Ard Biesheuvel wrote: >> + MaxAddress = (1UL << MaxAddressBits) - 1; > not 1 U;, which Sorry, typo: s/;/L/, clearly. (They are adjacent in my keyboard layout.) Laszlo ___

Re: [edk2] [PATCH 2/5] ArmPkg/ArmMmuLib: take the CPU supported maximum PA space into account

On 11/23/18 13:14, Ard Biesheuvel wrote: > In preparation of permitting the virt code to define a larger PA space > size via gEmbeddedTokenSpaceGuid.PcdPrePiCpuMemorySize than what the > CPU actually supports, take the CPU's capabilities into account when > setting up the page tables. This is neces

Re: [edk2] [PATCH 0/5] ArmPkg, ArmVirtPkg: lift 40-bit IPA space limit

based on the CPU capabilities rather than the value of > PcdPrePiCpuMemorySize, to prevent any potential regressions in memory > utilization when we bump PcdPrePiCpuMemorySize back to 48. > > Patch #5 drops the definitions of PcdPrePiCpuMemorySize, reverting its > value back to the default 4

Re: [edk2] [PATCH 0/5] ArmPkg, ArmVirtPkg: lift 40-bit IPA space limit

based on the CPU capabilities rather than the value of > PcdPrePiCpuMemorySize, to prevent any potential regressions in memory > utilization when we bump PcdPrePiCpuMemorySize back to 48. > > Patch #5 drops the definitions of PcdPrePiCpuMemorySize, reverting its > value back to the default 48. >

Re: [edk2] [PATCH 1/5] ArmPkg/ArmLib: add support for reading the max physical address space size

meta: On 11/23/18 14:20, Ard Biesheuvel wrote: > On Fri, 23 Nov 2018 at 14:16, Andrew Jones wrote: >> >> [...] Drew, Eric, please subscribe to edk2-devel at https://lists.01.org/mailman/listinfo/edk2-devel otherwise, the list will drop your messages. This is a completely unacceptable requir

Re: [edk2] Structure of Tianocore?

On 11/24/18 17:41, Peter Wiehe wrote: > I have a question for understanding the Tianocore structure: > > Correct me, please, if something of the following assumptions is wrong. > > a) EmulatorPkg and the Unix and Win32 (Nt32Pkg) package run ontop of an OS. > > b) Ovmf runs ontop of Qemu. > > c)

[edk2] [PATCH 1/4] OvmfPkg: introduce ACPI Test Support data structure and GUID

. Cc: Anthony Perard Cc: Ard Biesheuvel Cc: Drew Jones Cc: Igor Mammedov Cc: Jordan Justen Cc: Julien Grall Cc: Philippe Mathieu-Daudé Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Laszlo Ersek --- OvmfPkg/OvmfPkg.dec| 1 + OvmfPkg/Include/

[edk2] [PATCH 4/4] OvmfPkg/AcpiPlatformDxe: fill in ACPI_TEST_SUPPORT at first Ready-To-Boot

. For the same reason, error messages are only logged at the DEBUG_WARN level. Cc: Anthony Perard Cc: Ard Biesheuvel Cc: Drew Jones Cc: Igor Mammedov Cc: Jordan Justen Cc: Julien Grall Cc: Philippe Mathieu-Daudé Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Laszlo

[edk2] [PATCH 3/4] OvmfPkg/AcpiPlatformDxe: add [Un]RegisterAcpiTestSupport() skeletons

point function so the registration can be rolled back on the failure path. Cc: Anthony Perard Cc: Ard Biesheuvel Cc: Drew Jones Cc: Igor Mammedov Cc: Jordan Justen Cc: Julien Grall Cc: Philippe Mathieu-Daudé Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Laszlo

[edk2] [PATCH 0/4] OvmfPkg, ArmVirtPkg: add ACPI Test Support

dan Justen Cc: Julien Grall Cc: Philippe Mathieu-Daudé Thanks, Laszlo Laszlo Ersek (4): OvmfPkg: introduce ACPI Test Support data structure and GUID OvmfPkg/AcpiPlatformDxe: list missing lib classes for QemuFwCfgAcpiPlatformDxe OvmfPkg/AcpiPlatformDxe: add [Un]RegisterAcpiT

[edk2] [PATCH 2/4] OvmfPkg/AcpiPlatformDxe: list missing lib classes for QemuFwCfgAcpiPlatformDxe

eMemoryLib class too. The other INF file, "AcpiPlatformDxe.inf", is fine already. Cc: Anthony Perard Cc: Ard Biesheuvel Cc: Drew Jones Cc: Igor Mammedov Cc: Jordan Justen Cc: Julien Grall Cc: Philippe Mathieu-Daudé Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-

Re: [edk2] [PATCH v2 0/6] Add DSC/FDF include segment files for network stack

On 11/23/18 17:02, Gao, Liming wrote: > Laszlo: > I add my comments. > >> -Original Message- >> From: Laszlo Ersek [mailto:ler...@redhat.com] >> Sent: Thursday, November 22, 2018 11:48 PM >> To: Gao, Liming ; Fu, Siyuan ; >> edk2-devel@lists.01.o

Re: [edk2] [PATCH v2 3/6] ArmVirtPkg: Update DSC/FDF to use NetworkPkg's include fragment file.

;s terms, and the value has been overridden with the original > default value on this platform. > > Cc: Laszlo Ersek > Cc: Ard Biesheuvel > Cc: Julien Grall > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Fu Siyuan > --- > ArmVirtPkg/ArmVir

Re: [edk2] [PATCH v2 edk2-platforms 3/3] Platform/ARM/BdsLib: maintain alignment for DevicePaths

Path, Handle, RemainingDevicePath, > Type, Image, FileSize); > + Status = FileLoader->LoadImage (DevicePath, Handle, > RemainingDevicePath, > + Type, Image, FileSize); > + break; > } >

Re: [edk2] [PATCH v2 edk2-platforms 2/3] Platform/ARM/BdsLib: drop unused functions

search. > - @retval EFI_INVALID_PARAMETER DevicePath or Handle is NULL > - > -**/ > -EFI_STATUS > -BdsConnectDevicePath ( > - IN EFI_DEVICE_PATH_PROTOCOL* DevicePath, > - OUT EFI_HANDLE*Handle, > - OUT EFI_DEVICE_PATH_PROTOCOL **RemainingDevicePath > - ) &

Re: [edk2] [PATCH v2 3/6] ArmVirtPkg: Update DSC/FDF to use NetworkPkg's include fragment file.

On 11/23/18 13:29, Laszlo Ersek wrote: > (2) This is good, and the end result that we want; however, it does two > things at once -- it eliminates the MdeModulePkg network drivers, and it > adopts the NetworkPkg includes. > > In OvmfPkg, we handled the first step separa

Re: [edk2] [PATCH v2 3/6] ArmVirtPkg: Update DSC/FDF to use NetworkPkg's include fragment file.

with the original > default value on this platform. > > Cc: Laszlo Ersek > Cc: Ard Biesheuvel > Cc: Julien Grall > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Fu Siyuan > --- > ArmVirtPkg/ArmVirt.dsc.inc | 11 +

Re: [edk2] [PATCH v2 5/6] OvmfPkg: Update DSC/FDF to use NetworkPkg's include fragment file.

he value has been overridden with the original > default value on this platform. > > This patch also rename the TLS_ENABLE flag to PLATFORM_TLS_ENABLE for the > platform specific configuration for TLS support. > > Cc: Jordan Justen > Cc: Laszlo Ersek > Cc: Ard Biesheuvel

Re: [edk2] [PATCH v2 5/6] OvmfPkg: Update DSC/FDF to use NetworkPkg's include fragment file.

and the value has been overridden with the original > default value on this platform. > > This patch also rename the TLS_ENABLE flag to PLATFORM_TLS_ENABLE for the > platform specific configuration for TLS support. > > Cc: Jordan Justen > Cc: Laszlo Ersek > Cc: Ard Biesh

Re: [edk2] [PATCH v2 5/6] OvmfPkg: Update DSC/FDF to use NetworkPkg's include fragment file.

with the original > default value on this platform. > > This patch also rename the TLS_ENABLE flag to PLATFORM_TLS_ENABLE for the > platform specific configuration for TLS support. > > Cc: Jordan Justen > Cc: Laszlo Ersek > Cc: Ard Biesheuvel > Cc: Anthony Perard > C

Re: [edk2] [PATCH v2 1/6] NetworkPkg: Add DSC/FDF include segment files to NetworkPkg.

+Ard, +Leif On 11/22/18 06:21, Fu Siyuan wrote: > This patch provides a set of include segment files for platform owner to > easily enable/disable network stack support on their platform. > > For DSC, there are: > - a "NetworkDefines.dsc.inc" for the [Defines] section(s), > - a "NetworkLibs.dsc.i

Re: [edk2] [PATCH edk2-platforms 4/4] Platform/ARM/BdsLib: maintain alignment for DevicePaths

On 11/23/18 09:35, Ard Biesheuvel wrote: > On Thu, 22 Nov 2018 at 19:35, Laszlo Ersek wrote: >> [...] > Indeed. I am updating the second patch to get rid of everything in > BdsLib we are not currently using. Thanks! > Looking at 56bed2f41022afcbadecc9f2d537bd31c3d44c

Re: [edk2] Display Architecture and Bring Up in UEFI

On 11/23/18 07:27, prabin ca wrote: > Hi Team, > > I’m new to UEFI and display interface in UEFI. I would like to have deep dive > into how display is working in UEFI (display architecture) and how display is > have been bring up (porting of display panel in a any platform in general ). > > Ple

Re: [edk2] [PATCH edk2-platforms 4/4] Platform/ARM/BdsLib: maintain alignment for DevicePaths

On 11/22/18 18:26, Ard Biesheuvel wrote: > DevicePath node types may have any size, and so it is up to the > code that manipulates them to ensure that dereferencing them only > occurs when the pointer is aligned explicitly. > > Since BdsConnectAndUpdateDevicePath() has only two callers, at d9e68a

Re: [edk2] [PATCH edk2-platforms 3/4] Platform/ARM/BdsLib: don't clobber BdsLoadImage() DevicePath IN param

On 11/22/18 19:14, Ard Biesheuvel wrote: > On Thu, 22 Nov 2018 at 19:09, Laszlo Ersek wrote: >> >> On 11/22/18 18:26, Ard Biesheuvel wrote: >>> BdsLoadImage () is part of the BdsLib library API and is not documented >>> as modifying its DevicePath argument, but d

Re: [edk2] [PATCH edk2-platforms 3/4] Platform/ARM/BdsLib: don't clobber BdsLoadImage() DevicePath IN param

On 11/22/18 18:26, Ard Biesheuvel wrote: > BdsLoadImage () is part of the BdsLib library API and is not documented > as modifying its DevicePath argument, but does so nonetheless. So take > a copy instead, and free it after use. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-

Re: [edk2] [PATCH edk2-platforms 2/4] Platform/ARM/BdsLid: drop unused BdsStartEfiApplication ()

atchdogTimer (5 * 60, 0x, 0x00, NULL); > - // Start the image > - Status = gBS->StartImage (ImageHandle, NULL, NULL); > - // Clear the Watchdog Timer after the image returns > - gBS->SetWatchdogTimer (0x, 0x, 0x, NULL); > - > - return Status; > -} > Makes sense; first we import BdsLib.h, then fix it up together with the (sole) lib instance. Reviewed-by: Laszlo Ersek ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [PATCH edk2-platforms 1/4] Platform/ARM: import ARM platform specific BdsLib header

**/ > +EFI_STATUS > +LocateEfiApplicationInFvByGuid ( > + IN CONST EFI_GUID*EfiAppGuid, > + OUT EFI_DEVICE_PATH **DevicePath > + ); > + > +#endif > diff --git a/Platform/ARM/Library/BdsLib/BdsInternal.h > b/Platform/ARM/Library/BdsLib/BdsInternal.h > index f70aae603d69..bb4566e3a6c4 100644 > --- a/Platform/ARM/Library/BdsLib/BdsInternal.h > +++ b/Platform/ARM/Library/BdsLib/BdsInternal.h > @@ -16,7 +16,6 @@ > #define __BDS_INTERNAL_H__ > > #include > -#include > #include > #include > #include > diff --git a/Platform/ARM/Library/BdsLib/BdsLib.inf > b/Platform/ARM/Library/BdsLib/BdsLib.inf > index 96c1d6e7e200..637ef5a08128 100644 > --- a/Platform/ARM/Library/BdsLib/BdsLib.inf > +++ b/Platform/ARM/Library/BdsLib/BdsLib.inf > @@ -27,10 +27,10 @@ >BdsLoadOption.c > > [Packages] > - ArmPkg/ArmPkg.dec >EmbeddedPkg/EmbeddedPkg.dec >MdeModulePkg/MdeModulePkg.dec >MdePkg/MdePkg.dec > + Platform/ARM/ARM.dec > > [LibraryClasses] >ArmLib > Seems OK to me. Acked-by: Laszlo Ersek ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] Hardcoded IDE Controller B/D/F (0/1/1) in BdsPlatform.c?

On 11/22/18 01:06, Bryan Rosario via edk2-devel wrote: > Hi all, > > I noticed that there is apparently a hardcoded B/D/F for an IDE Controller > in BdsPlatform.c, when setting bit 15 of a particular register: > https://github.com/tianocore/edk2/blob/14923c1a6bf9940b48feeaf47cb5d6c662b6528c/OvmfPk

Re: [edk2] [PATCH edk2-platforms 0/3] drop GUIDs from NOR flash bank descriptors

On 11/22/18 14:08, Ard Biesheuvel wrote: > On Thu, 22 Nov 2018 at 12:37, Ard Biesheuvel > wrote: >> >> On Thu, 22 Nov 2018 at 12:19, chandni cherukuri >> wrote: >>> >>> On Thu, Nov 22, 2018 at 1:20 PM Ard Biesheuvel >>> wrote: On Thu, 22 Nov 2018 at 05:01, Thomas Abraham wrote:

Re: [edk2] [PATCH v2 0/6] Add DSC/FDF include segment files for network stack

On 11/22/18 06:21, Fu Siyuan wrote: > There is a patch to remove the redudant IP4 only iSCSI/PXE/TCP drivers > from MdeModulePkg, which has been reviewed before edk2-stable201811 tag. > And we also have plan to move all network related libraries/modules to > NetworkPkg. In order to make these chang

Re: [edk2] [PATCH v2 0/6] Add DSC/FDF include segment files for network stack

he first command (in a shell script or similar), the same search would require an awkward, ad-hoc parser for matching the second command. Thanks Laszlo >> -Original Message- >> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Fu >> Siyuan >> Sent: Thu

Re: [edk2] [Patch] OvmfPkg: Don't include TftpDynamicCommand in XCODE5 tool chain

ude TftpDynamicCommand driver. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Liming Gao > Cc: Jordan Justen > Cc: Laszlo Ersek > --- > OvmfPkg/OvmfPkgIa32.dsc| 2 ++ > OvmfPkg/OvmfPkgIa32.fdf| 2 ++ > OvmfPkg/OvmfPkgIa3

Re: [edk2] [PATCH v2 5/5] ArmPlatformPkg/NorFlashPlatformLib: remove unused Guid member from struct

N RegionBaseAddress;// Start address of one single region >UINTN Size; >UINTN BlockSize; > - EFI_GUIDGuid; > } NOR_FLASH_DESCRIPTION; > > EFI_STATUS > Reviewed-by: Laszlo Ersek ___ edk2-deve

Re: [edk2] [PATCH v2 4/5] ArmVirtPkg/NorFlashQemuLib: discover NOR flash banks dynamically

Descriptions = mNorFlashDevices; > - *Count = ARRAY_SIZE (mNorFlashDevices); > + *Count = Num; > + >return EFI_SUCCESS; > } > diff --git a/ArmVirtPkg/Library/NorFlashQemuLib/NorFlashQemuLib.inf > b/ArmVirtPkg/Library/NorFlashQemuLib/NorFlashQemuLib.inf > index 126d1671f544..d86ff3

Re: [edk2] [PATCH v2 1/5] ArmPlatformPkg/NorFlashDxe: prepare for devicepath format change

). These are cosmetic > changes only, the resulting binaries should be identical. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ard Biesheuvel > Reviewed-by: Laszlo Ersek > --- > ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashDxe.c | 9 ++--- >

Re: [edk2] [PATCH v2 3/5] ArmVirtPkg/FdtClientDxe: take DT node 'status' properties into account

>INT32 Len; >EFI_STATUS Status; > > @@ -223,10 +253,8 @@ FindNextMemoryNodeReg ( >break; > } > > -NodeStatus = fdt_getprop (mDeviceTreeBase, Next, "status", &Len); > -if (NodeStatus != NULL && AsciiStrCmp

Re: [edk2] [PATCH v2 2/5] ArmPlatformPkg/NorFlashDxe: use one GUID plus index to identify flash banks

le GUID for all flash banks, > and update the driver's device path handling to include an index > to identify each bank uniquely. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ard Biesheuvel > Reviewed-by: Laszlo Ersek > Reviewed-by: Leif

Re: [edk2] [PATCH 1/6] NetworkPkg: Add DSC/FDF include segment files to NetworkPkg.

On 11/21/18 12:53, Fu, Siyuan wrote: >> -Original Message- >> From: Laszlo Ersek [mailto:ler...@redhat.com] >> Sent: Wednesday, November 21, 2018 6:47 PM >> To: Fu, Siyuan >> Cc: edk2-devel@lists.01.org; Ye, Ting ; Wu, Jiaxin >> >> Subject: Re:

Re: [edk2] [PATCH 3/6] ArmVirtPkg: Update DSC/FDF to use NetworkPkg's include fragment file.

he value has been overridden with the original > default value on this platform. > > Cc: Laszlo Ersek > Cc: Ard Biesheuvel > Cc: Julien Grall > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Fu Siyuan > --- > ArmVirtPkg/ArmVirt

Re: [edk2] [PATCH 5/6] OvmfPkg: Update DSC/FDF to use NetworkPkg's include fragment file.

] section have been updated to use > the NetworkPkg's terms, and the value has been overridden with the original > default value on this platform. > > Cc: Jordan Justen > Cc: Laszlo Ersek > Cc: Ard Biesheuvel > Cc: Anthony Perard > Cc: Julien Grall > Contribut

Re: [edk2] [PATCH 1/6] NetworkPkg: Add DSC/FDF include segment files to NetworkPkg.

On 11/21/18 11:46, Laszlo Ersek wrote: > On 11/21/18 06:28, Fu Siyuan wrote: >> The "Network.dsc.inc" and "Network.fdf.inc" are added for platform owner to >> easily enable/disable network stack support on their platform, by adding >> !include Networ

Re: [edk2] [PATCH 1/6] NetworkPkg: Add DSC/FDF include segment files to NetworkPkg.

On 11/21/18 06:28, Fu Siyuan wrote: > The "Network.dsc.inc" and "Network.fdf.inc" are added for platform owner to > easily enable/disable network stack support on their platform, by adding > !include NetworkPkg/Network.dsc.inc > and > !include NetworkPkg/Network.fdf.inc > to their platform DSC/

Re: [edk2] [PATCH v3] OvmfPkg: simply use the Bochs interface for vmsvga

On 11/07/18 18:06, Laszlo Ersek wrote: > On 11/07/18 04:47, yuchen...@synology.com wrote: >> From: yuchenlin >> >> BAR |std vga | vmsvga >> - >> 0| Framebuffer | I/O space >> 1| Reserved | Fram

Re: [edk2] [PATCH edk2-platforms v3 1/5] Hisilicon/D0x: Fix secure boot bug in FlashFvbDxe

On 11/20/18 16:00, Ming Huang wrote: > > > On 11/20/2018 10:39 PM, Leif Lindholm wrote: >> On Tue, Nov 20, 2018 at 10:29:57PM +0800, Ming Huang wrote: >> And all Hisilicon platforms still use >> AuthVariableLib|MdeModulePkg/Library/AuthVariableLibNull/AuthVariableLibNull.inf >> regard

Re: [edk2] [PATCH edk2-platforms v3 1/5] Hisilicon/D0x: Fix secure boot bug in FlashFvbDxe

On 11/20/18 15:40, Ard Biesheuvel wrote: > On Tue, 20 Nov 2018 at 15:30, Ming Huang wrote: >> >> >> >> On 11/20/2018 8:58 PM, Leif Lindholm wrote: >>> On Tue, Nov 20, 2018 at 08:40:28PM +0800, Ming Huang wrote: On 11/20/2018 8:13 PM, Leif Lindholm wrote: > On Tue, Nov 20, 2018 a

Re: [edk2] [PATCH] MdeModulePkg/Variable: add debug logs in VariableServiceSetVariable

On 11/20/18 11:38, Vijayenthiran Subramaniam wrote: > Print debug messages if size of the VariableName plus DataSize exceeds > Max(Auth|Voltaile)VariableSize bytes. The messages will be useful if any > platform specific value of Max(Auth|Voltaile)VariableSize PCDs have to > be changed. > > Cc: Sta

Re: [edk2] [PATCH] NetworkPkg/IScsiDxe: add debug logs for failed SetVariable attempts

On 11/20/18 11:39, Vijayenthiran Subramaniam wrote: > Add debug messages for failed attempts to write to a variable. > > Cc: Siyuan Fu > Cc: Jiaxin Wu > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Vijayenthiran Subramaniam > --- > NetworkPkg/IScsiDxe/IScsiMisc.c |

Re: [edk2] EmulatorPkg Unix Host Segmentation fault.

On 11/19/18 23:29, Jordan Justen wrote: > On 2018-11-19 13:22:27, Andrew Fish wrote: >> I seem to remember we hit an issue like this a long time ago? Do you >> remember the details? Maybe it was we needed to write the >> TempRamSupport code in assembly? > > It does also creep up there, which is w

Re: [edk2] [PATCH 1/1] MdePkg ACPI: fix the typos in Acpi61.h and Acpi62.h

t; --- > MdePkg/Include/IndustryStandard/Acpi61.h | 2 +- > MdePkg/Include/IndustryStandard/Acpi62.h | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) Good catch! Reviewed-by: Laszlo Ersek Thanks Laszlo > diff --git a/MdePkg/Include/IndustryStandard/Acpi61.h > b/MdePkg/In

Re: [edk2] [RFC] Proposal to remove DuetPkg

On 11/20/18 06:27, Ni, Ruiyu wrote: > All, > DuetPkg depends on Legacy BIOS to provide a UEFI environment. It was invented > in the era when UEFI environment is hard to find. Since now UEFI is very > popular in PC area, we could stop the official support of this package and > remove it from the

Re: [edk2] EmulatorPkg Unix Host Segmentation fault.

Jordan wrote: >>> So, is it safe to adjust rbp? Unknown. It may not be if rbp is not >>> used as a frame pointer. Is it safe to *not* adjust rbp and >>> potentially allow the old temp ram stack to be used? Unknown. Andrew wrote: > Looks like OvmfPkg uses SetJump()/LongJump() to change the stack.

Re: [edk2] [edk2-wiki PATCH v2] release planning: announce the soft and hard feature freezes

On 11/14/18 01:06, Gao, Liming wrote: > Reviewed-by: Liming Gao Thank you, pushed as commit 8e311ba71992. Laszlo >> -Original Message- >> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of >> Laszlo Ersek >> Sent: Tuesday, November 13

Re: [edk2] [edk2-announce] December Community Meeting

Hi Stephano, On 11/15/18 22:06, stephano wrote: > We will be holding monthly community meetings starting in December on > the first Thursday of the month. Details for the next meeting are here: > > https://github.com/tianocore/tianocore.github.io/wiki/Community-Virtual-Meetings the second ICS li

Re: [edk2] [PATCH 2/2] ArmVirtPkg/NorFlashQemuLib: discover NOR flash banks dynamically

On 11/17/18 01:45, Ard Biesheuvel wrote: > NorFlashQemuLib is one of the last remaining drivers in ArmVirtPkg > that are not based on the device tree received from QEMU. > > For ArmVirtQemu, this does not really matter, given that the NOR > flash banks are always the same: the PEI code is linked t

Re: [edk2] [PATCH 1/2] ArmPlatformPkg/NorFlashDxe: use one GUID plus index to identify flash banks

struct _NOR_FLASH_INSTANCE { >UINT32 Signature; > (6) Given that you introduce this field as UINT8, the "Instance->DevicePath.Index = Index" assignment in NorFlashCreateInstance() is liable to trigger UINT32-->UINT8 "truncation" warnings

Re: [edk2] [PATCH 0/2] Clear frame pointer in startup code on AARCH64 systems

3 +++ > ArmVirtPkg/PrePi/AArch64/ModuleEntryPoint.S | 3 +++ > 3 files changed, 9 insertions(+) > Acked-by: Laszlo Ersek ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [PATCH] ArmPkg/ArmGicDxe ARM: fix encoding for GICv3 interrupt acknowledge

On 11/15/18 13:37, Ard Biesheuvel wrote: > On Wed, 14 Nov 2018 at 14:11, Laszlo Ersek wrote: >> >> On 11/14/18 21:00, Leif Lindholm wrote: >>> On Wed, Nov 14, 2018 at 11:27:24AM -0800, Ard Biesheuvel wrote: >>>> Fix a typo in the 32-bit ARM version of the GIC

Re: [edk2] [PATCH v2 0/5] OvmfPkg: simply use the Bochs interface for vmsvga

On 11/12/18 16:40, Laszlo Ersek wrote: > On 11/12/18 15:16, Philippe Mathieu-Daudé wrote: >> On 2/11/18 4:23, yuchen...@synology.com wrote: >>> From: yuchenlin >>> >>> In this series, replace the original vmsvga driver to Bochs >>> interface. >&

Re: [edk2] [OVMF+VIFO+QEMU] Large VM RAM allocation = Long Boot Times

On 11/15/18 06:58, A Z wrote: > This is an issue that involves a combination of different software > packages, so my apologies in advance if this is the wrong list to post on. > > I'm experiencing terrible boot times when I assign a large amount of RAM to > a VM when used in combination with VIFO/

Re: [edk2] [PATCH] ArmPkg/ArmGicDxe ARM: fix encoding for GICv3 interrupt acknowledge

On 11/14/18 21:00, Leif Lindholm wrote: > On Wed, Nov 14, 2018 at 11:27:24AM -0800, Ard Biesheuvel wrote: >> Fix a typo in the 32-bit ARM version of the GICv3 driver, which uses >> the wrong system register encoding to access ICC_IAR1, and attempted >> to access ICC_IAR0 instead. This results in bo

Re: [edk2] [edk2-announce] EDK II Stable Tag edk2-stable201811 will be created based on commit 85588389222a3636baf0f9ed8227f2434af4c3f9

On 11/14/18 15:20, Gao, Liming wrote: > Hi, all Today, I review all patches in edk2 mail list. There is no > patches for EDK II Stable Tag edk2-stable201811. Based on > edk2-stable201811 tag planning, it will be released at 2018-11-15. > So, I plan to create edk2-stable201811 based on current edk2

Re: [edk2] [PATCH v1] Maintainers.txt: Change DynamicTablesPkg maintainer

https://github.com/tianocore/tianocore.github.io/wiki/DynamicTablesPkg > -M: Evan Lloyd > M: Sami Mujawar > +M: Alexei Fedorov > > EdkCompatibilityPkg > W: https://github.com/tianocore/tianocore.github.io/wiki/EdkCompatibilityPkg > Reviewed-by: Laszlo Ersek

[edk2] [edk2-wiki PATCH v2] release planning: announce the soft and hard feature freezes

1.1 Signed-off-by: Laszlo Ersek --- Notes: v2: - with Liming's edk2 commit da2c81ee96eb ("Maintainers.txt: Update EDK II Releases to EDK-II-Release-Planning wiki", 2018-11-12) up-stream, identify the announcer via "Maintainers.txt" [Mike]

Re: [edk2] [PATCH] Changed Maintainers.txt

On 11/13/18 02:41, Wei, David wrote: > Reviewed-by: David Wei (1) The original patch never reached the list. Is Zailiang Sun perhaps not subscribed? I think maintainership requires that the maintainer be subscribed. (2) The subject line is a wreck. Zailiang, please resubmit the patch with the fo

Re: [edk2] [PATCH] UefiCpuPkg/CommonFeature: Always set FEATURE_CONTROL.Lock

properly to make > sure feature CPU_FEATURE_LOCK_FEATURE_CONTROL_REGISTER is enabled. > > But it's better to guarantee this in the generic core code. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ruiyu Ni > Cc: Eric Dong > Cc: Laszlo Ersek &

Re: [edk2] [PATCH v2 0/5] OvmfPkg: simply use the Bochs interface for vmsvga

On 11/12/18 15:16, Philippe Mathieu-Daudé wrote: > On 2/11/18 4:23, yuchen...@synology.com wrote: >> From: yuchenlin >> >> In this series, replace the original vmsvga driver to Bochs >> interface. >> >> Simply revert vmsvga driver implementation. After it, use Bochs >> interface for initializing v

Re: [edk2] [PATCH v2 5/5] OvmfPkg: simply use the Bochs interface for vmsvga

On 11/12/18 12:28, Philippe Mathieu-Daudé wrote: > On Mon, Nov 12, 2018 at 12:20 PM Laszlo Ersek > wrote: >> On 11/06/18 14:44, Philippe Mathieu-Daudé wrote: >>> On 6/11/18 14:36, Laszlo Ersek wrote: >>>> On 11/06/18 12:47, Laszlo Ersek wrote: >>>> &

Re: [edk2] [PATCH 0/4] OvmfPkg: revert some untimely pushed VMW SVGA reverts

On 11/09/18 20:44, Laszlo Ersek wrote: > Repo: https://github.com/lersek/edk2.git > Branch: revert_revert_bz_1319 > > Not much to say here, I've written it up in > <https://bugzilla.tianocore.org/show_bug.cgi?id=1319>. > > One way to verify this series quickly i

Re: [edk2] [PATCH v2 5/5] OvmfPkg: simply use the Bochs interface for vmsvga

Hi Phil, On 11/06/18 14:44, Philippe Mathieu-Daudé wrote: > On 6/11/18 14:36, Laszlo Ersek wrote: >> On 11/06/18 12:47, Laszlo Ersek wrote: >> >>> ... While we discuss this, I'll go ahead and push the first four >>> patches. The code being reverted is dead

Re: [edk2] Edk2 2019 Q1 stable tag planning is added into EDK-II-Release-Planning wiki

On 11/09/18 15:25, Gao, Liming wrote: > Hi, all > Next edk2 stable tag planning has been added into EDK-II-Release-Planning > wiki > https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Release-Planning. > Please review the proposed schedule. The proposed features are not > finalized.

Re: [edk2] [Patch 0/2] Separate semaphore container.

iginal Message- >> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Eric >> Dong >> Sent: Thursday, November 8, 2018 10:58 AM >> To: edk2-devel@lists.01.org >> Cc: Ni, Ruiyu ; Laszlo Ersek >> Subject: [edk2] [Patch 0/2] Separate semaphor

Re: [edk2] [PATCH v1 1/1] MdeModulePkg/NvmExpressPei: Refine data buffer & len check in PassThru

hat this change qualifies as a bugfix for the hard feature freeze. From that perspective, without checking any technical details: Acked-by: Laszlo Ersek *However*, please clean up the description in the bugzilla (BZ#1142). In the bugzilla, both the title and the initial description say that the check is

Re: [edk2] [Patch] UefiCpuPkg/RegisterCpuFeaturesLib: Adjust Order.

On 11/11/18 03:01, Dong, Eric wrote: > Hi Leif, > > Thanks for your comments. Because I must check in the code today, I will > change the code when I push the change. Fine by me too. Laszlo ___ edk2-devel mailing list edk2-devel@lists.01.org https://l

Re: [edk2] [Patch V2] Maintainers.txt: Update EDK II Releases to EDK-II-Release-Planning wiki

On 11/10/18 15:05, Liming Gao wrote: > In V2, add Liming Gao as the maintainer of EDK II Releases. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Liming Gao > Cc: Laszlo Ersek > --- > Maintainers.txt | 5 ++--- > 1 file changed, 2 in

Re: [edk2] [patch] MdeModulePkg/DisplayEngine: Remove useless NULL ptr check for NewPos

On 11/09/18 18:49, Kinney, Michael D wrote: > Laszlo, > > I added EDK2|Documentation|Wiki Pages > > I also updated the sort order so Wiki Pages is > first, followed by maintained GitBook documents > sorted alphabetically, with "Other Document" last. Thanks, Mike! I've filed

[edk2] [PATCH 0/4] OvmfPkg: revert some untimely pushed VMW SVGA reverts

[nothing] Thanks, and sorry about the churn Laszlo Cc: Anthony Perard Cc: Ard Biesheuvel Cc: Jordan Justen Cc: Julien Grall Cc: Philippe Mathieu-Daudé Cc: yuchenlin Laszlo Ersek (4): Reapply "OvmfPkg: VMWare SVGA display device register definitions" Reapply "OvmfPkg/Qe

[edk2] [PATCH 1/4] Reapply "OvmfPkg: VMWare SVGA display device register definitions"

edk2-stable201811 tag. Cc: Anthony Perard Cc: Ard Biesheuvel Cc: Jordan Justen Cc: Julien Grall Cc: Philippe Mathieu-Daudé Cc: yuchenlin Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1319 Signed-off-by: Laszlo Ersek --- OvmfPkg/Include/IndustryStandard/VmwareSvga.h

[edk2] [PATCH 3/4] Reapply "OvmfPkg/QemuVideoDxe: VMWare SVGA device support"

edk2-stable201811 tag. Cc: Anthony Perard Cc: Ard Biesheuvel Cc: Jordan Justen Cc: Julien Grall Cc: Philippe Mathieu-Daudé Cc: yuchenlin Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1319 Signed-off-by: Laszlo Ersek --- OvmfPkg/QemuVideoDxe/Qemu.h | 29 OvmfPkg/QemuVid

<    1   2   3   4   5   6   7   8   9   10   >