Re: [edk2] [PATCH 0/9] enhance mmc

2016-03-01 Thread Ryan Harkin
On 29 February 2016 at 15:36, Leif Lindholm wrote: > On Mon, Feb 29, 2016 at 01:46:42PM +, Ryan Harkin wrote: >> >> This is a substantial contribution, and on inspection it looks fine. >> >> However, it does change bits of MmcDxe substantially - so I would >> >>

Re: [edk2] [PATCH 0/3] Fix PL180 for Versatile Express TC2

2016-03-01 Thread Ryan Harkin
t;> >> I've pushed them to my tree to make applying easier should Leif wish >> to cherry-pick: >> >> https://git.linaro.org/landing-teams/working/arm/edk2.git/shortlog/refs/tags/armlt-upstreaming-20160301-001 > > Many thanks. > Reviewed-by: Leif Lindholm <leif.

Re: [edk2] [PATCH 00/17] Port OvmfPkg to MdeModulePkg/Bus/Pci/PciHostBridgeDxe

2016-03-01 Thread Jordan Justen
Patches 3+ Reviewed-by: Jordan Justen I'm not sure where things stand on patch 1, but I guess you and Ray are still discussing it. -Jordan On 2016-02-26 16:23:19, Laszlo Ersek wrote: > This series ports OvmfPkg to the new core PCI host bridge / root bridge > driver.

Re: [edk2] [PATCH 14/17] OvmfPkg: PciHostBridgeLib: set PCI config space boundaries

2016-03-01 Thread Laszlo Ersek
On 03/01/16 20:23, Jordan Justen wrote: > On 2016-02-26 16:23:33, Laszlo Ersek wrote: >> In "OvmfPkg/PciHostBridgeDxe/PciRootBridgeIo.c", the >> RootBridgeIoCheckParameter() function hard-codes them as [0x00..0xFF] (see >> the MAX_PCI_REG_ADDRESS macro), which matches OVMF's 0xCF8 / 0xCFC config

Re: [edk2] [PATCH 0/9] enhance mmc

2016-03-01 Thread Ryan Harkin
On 1 March 2016 at 18:46, Ryan Harkin wrote: > On 29 February 2016 at 15:36, Leif Lindholm wrote: >> On Mon, Feb 29, 2016 at 01:46:42PM +, Ryan Harkin wrote: >>> >> This is a substantial contribution, and on inspection it looks fine. >>> >>

Re: [edk2] "echo" objcopy not needed doesn't actually work

2016-03-01 Thread Cohen, Eugene
Andrew, > Each line of the recipe in the makefile should invoke a unique instance > of the shell. Thus it seems you are invoking the wrong shell so take a > look at: > https://www.gnu.org/software/make/manual/html_node/Choosing- > the-Shell.html In this case we're basically trying to execute a

Re: [edk2] BOM in .dec, .dsc, .fdf

2016-03-01 Thread Kinney, Michael D
Tim, Those files types are all required to be ASCII files. If one of those files in EDK II repo has UTF-8 BOM, then that is a bug and needs to be fixed. I have seen text editors that auto convert ASCII to UTF-8 if a non-ASCII character is ever added to a file. The file then retains the UTF-8

[edk2] [PATCH v2] BaseTools: Update ARM/AArch64 GenFv vector processing for encapsulated FVs

2016-03-01 Thread Cohen, Eugene
(Second revision of patch which adds two missing #defines for ARM instructions) Instead of only handling SEC Core or PEI Core instances in the outer FV, the GenFv tool will now recurse into FV image FFS files to look for instances in encapsulated FVs so the vector area can be updated

[edk2] BOM in .dec, .dsc, .fdf

2016-03-01 Thread Tim Lewis
I thought I saw a thread talking about this. We are seeing an issue with a UTF-8 BOM appears at the beginning of a .dec file, even if there are no other non-ASCII characters. In our case, this causes the parser to bomb out with a stack trace. This happens to our users in Asia. I couldn't find

Re: [edk2] BOM in .dec, .dsc, .fdf

2016-03-01 Thread Tim Lewis
Mike -- Ok. It's not an EDK2 file, in this case. I suspected that this was what was happening, since we couldn't find another non-ASCII character. The error message (BC0DE) wasn't so helpful, coming back through the exception handler in build.py. Tim -Original Message- From: Kinney,

Re: [edk2] [patch] MdeModulePkg: Add ASSERT to make sure pointers are not NULL

2016-03-01 Thread Dong, Eric
Reviewed-by: Eric Dong > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Dandan > Bi > Sent: Tuesday, March 01, 2016 10:52 AM > To: edk2-devel@lists.01.org > Cc: Qiu, Shumin; Dong, Eric > Subject: [edk2] [patch]

Re: [edk2] [patch] MdeModulePkg: FileExplorerLib: Modify the EFI_FILE_EXPLORE_FORMSET_GUID

2016-03-01 Thread Dong, Eric
Reviewed-by: Eric Dong > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Dandan > Bi > Sent: Tuesday, March 01, 2016 2:58 PM > To: edk2-devel@lists.01.org > Cc: Dong, Eric; Gao, Liming > Subject: [edk2] [patch]

[edk2] [Patch] UefiCpuPkg/Application/Cpuid: Change DisplayFamily/DisplayModel type

2016-03-01 Thread Jeff Fan
Change DisplayFamily/DisplayModel type to UINT32 to avoid different size in bitwise operation. Cc: Qiu Shumin Cc: Michael Kinney Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jeff Fan ---

[edk2] [Patch] UefiCpuPkg/Application/Cpuid: Remove unnecessary code check

2016-03-01 Thread Jeff Fan
gMaximumBasicFunction is set to CPUID_SIGNATURE as below, so removed the compare code. UINT32 gMaximumBasicFunction = CPUID_SIGNATURE; Cc: Qiu Shumin Cc: Michael Kinney Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jeff

Re: [edk2] PL180MciDxe problem with TC2

2016-03-01 Thread Leif Lindholm
On Tue, Mar 01, 2016 at 09:39:18AM +0100, Ard Biesheuvel wrote: > >> As far as the Primecell ID is concerned, let's just whitelist whatever > >> TC2 exposes, even if in error. > > > > You mean rather than mask the "stuck bit", specifically check if the > > register is 0 or 2? (Where 2 is added as

[edk2] [PATCH 1/6] MdePkg: DebugLib: more cleanup for log level comments in lib class header

2016-03-01 Thread Laszlo Ersek
The DEBUG_POOL and DEBUG_PAGE clarifications were suggested by Leif Lindholm. Cc: Michael Kinney Cc: Liming Gao Cc: Leif Lindholm Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek

[edk2] [PATCH 6/6] OvmfPkg: copy log level comments from DebugLib.h

2016-03-01 Thread Laszlo Ersek
Cc: Jordan Justen Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek --- OvmfPkg/OvmfPkgIa32.dsc| 22 OvmfPkg/OvmfPkgIa32X64.dsc | 22 OvmfPkg/OvmfPkgX64.dsc | 22

[edk2] [PATCH 0/6] more cleanups for DebugLib.h, then sync DSCs with it

2016-03-01 Thread Laszlo Ersek
Public branch: . Cc: Ard Biesheuvel Cc: Jordan Justen Cc: Leif Lindholm Cc: Liming Gao Cc: Michael Kinney

[edk2] [PATCH 2/6] ArmPlatformPkg/ArmVExpressPkg: sync log level comments to DebugLib.h

2016-03-01 Thread Laszlo Ersek
Suggested-by: Leif Lindholm Cc: Leif Lindholm Cc: Ard Biesheuvel Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek --- Notes: not build tested

Re: [edk2] [PATCH 2/6] ArmPlatformPkg/ArmVExpressPkg: sync log level comments to DebugLib.h

2016-03-01 Thread Leif Lindholm
On Tue, Mar 01, 2016 at 10:58:28AM +0100, Laszlo Ersek wrote: > Suggested-by: Leif Lindholm > Cc: Leif Lindholm > Cc: Ard Biesheuvel > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Laszlo

Re: [edk2] PL180MciDxe problem with TC2

2016-03-01 Thread Ard Biesheuvel
On 1 March 2016 at 08:50, Ryan Harkin wrote: > Thanks for jumping in! > > On 29 February 2016 at 20:59, Ard Biesheuvel > wrote: >> On 29 February 2016 at 21:05, Laszlo Ersek wrote: >>> On 02/29/16 20:39, Ryan Harkin wrote:

Re: [edk2] [PATCH 07/17] OvmfPkg: PciHostBridgeLib: convert main loop from PciHostBridgeDxe

2016-03-01 Thread Laszlo Ersek
On 03/01/16 08:16, Jordan Justen wrote: > On 2016-02-26 16:23:26, Laszlo Ersek wrote: >> In this patch we import the scan for extra root buses from the >> InitializePciHostBridge() function, in file >> "OvmfPkg/PciHostBridgeDxe/PciHostBridge.c". >> >> For the time being, the InitRootBridge() and

Re: [edk2] [PATCH] Platforms/ARM: ArmVexpress.dsc.inc - update debug levels

2016-03-01 Thread Leif Lindholm
On Tue, Mar 01, 2016 at 10:05:10AM +0100, Laszlo Ersek wrote: > On 02/29/16 21:14, Laszlo Ersek wrote: > > On 02/29/16 20:34, Leif Lindholm wrote: > >> The comments on PcdDebugPrintErrorLevel are clearly based on a version > >> of MdePkg/Include/Library/DebugLib.h predating SVN r12933. > >> Bring

Re: [edk2] [PATCH] Platforms/ARM: ArmVexpress.dsc.inc - update debug levels

2016-03-01 Thread Laszlo Ersek
On 02/29/16 21:14, Laszlo Ersek wrote: > On 02/29/16 20:34, Leif Lindholm wrote: >> The comments on PcdDebugPrintErrorLevel are clearly based on a version >> of MdePkg/Include/Library/DebugLib.h predating SVN r12933. >> Bring up to date to reduce confusion (and fix a couple of mistakes). >> >>

Re: [edk2] [PATCH 0/6] more cleanups for DebugLib.h, then sync DSCs with it

2016-03-01 Thread Leif Lindholm
On Tue, Mar 01, 2016 at 11:00:45AM +0100, Ard Biesheuvel wrote: > On 1 March 2016 at 10:58, Laszlo Ersek wrote: > > Public branch: > > . > > > > Cc: Ard Biesheuvel > > Cc: Jordan Justen

Re: [edk2] PL180MciDxe problem with TC2

2016-03-01 Thread Leif Lindholm
On Tue, Mar 01, 2016 at 10:40:53AM +0100, Ard Biesheuvel wrote: > On 1 March 2016 at 10:36, Leif Lindholm wrote: > > On Tue, Mar 01, 2016 at 09:39:18AM +0100, Ard Biesheuvel wrote: > >> >> As far as the Primecell ID is concerned, let's just whitelist whatever > >> >> TC2

[edk2] [patch] SecurityPkg: SecureBootConfigDxe: Enhance the code logic

2016-03-01 Thread Dandan Bi
The function AllocateCopyPool may return NULL, so need to do check after calling it. This patch is to enhance the related logic. Cc: Chao Zhang Cc: Qiu Shumin Cc: Eric Dong Contributed-under: TianoCore Contribution Agreement

Re: [edk2] [Patch 1/4] MdeModulePkg: Change the default IPv4 config policy

2016-03-01 Thread Fu, Siyuan
Hi, Jiaxin The reconfig event should be created before start the tick timer, other parts are good to me. Reviewed-by: Fu Siyuan > -Original Message- > From: Wu, Jiaxin > Sent: Thursday, February 25, 2016 12:22 PM > To: edk2-devel@lists.01.org > Cc: Subramanian

Re: [edk2] [PATCH 0/6] more cleanups for DebugLib.h, then sync DSCs with it

2016-03-01 Thread Jordan Justen
Series Reviewed-by: Jordan Justen On 2016-03-01 01:58:26, Laszlo Ersek wrote: > Public branch: > . > > Cc: Ard Biesheuvel > Cc: Jordan Justen > Cc: Leif

[edk2] [EDK2] [PATCH] ShellPkg: Ensure UEFI apps open the correct StdOut

2016-03-01 Thread Jim_Dailey
Dell - Internal Use - Confidential ShellPkg: Ensure UEFI apps open the correct StdOut When an app opens StdOut for writing, ensure it opens the correct StdOut (whatever was set up for the app in the NewShellParametersProtocol). Contributed-under: TianoCore Contribution Agreement 1.0

Re: [edk2] [PATCH] ShellPkg: Don't strip BOM when piping UCS2 data to a UEFI app

2016-03-01 Thread Carsey, Jaben
Reviewed-by: Jaben Carsey This patch worked great! > -Original Message- > From: jim_dai...@dell.com [mailto:jim_dai...@dell.com] > Sent: Tuesday, March 01, 2016 1:02 PM > To: edk2-devel@lists.01.org > Cc: Carsey, Jaben ; Qiu, Shumin >

Re: [edk2] [PATCH] BaseTools: Update ARM/AArch64 GenFv vector processing for encapsulated FVs

2016-03-01 Thread Cohen, Eugene
> Is it necessary to add check in GetChildFvFromFfs()? I see FfsRebase() > has set mArm value. Liming, In my experiments the answer is 'yes' because when GenFv is called for the outer FV this is the only mechanism where we can find the embedded SEC or PEI cores. Perhaps you can help me

Re: [edk2] [EDK2] [PATCH] ShellPkg: Ensure UEFI apps open the correct StdOut

2016-03-01 Thread Carsey, Jaben
Jim, Given that the email says " Dell - Internal Use - Confidential", I feel odd applying it to the open source. Can you remove that line? -Jaben > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > jim_dai...@dell.com > Sent: Tuesday, March

[edk2] [patch] ShellPkg: Merge Ping6 and Ifconfig6 tools to Shell command.

2016-03-01 Thread Zhang Lubo
According to the new Shell spec, we add Network2 profile and merge Ping6 and Ifconfig6 tools to Shell command. Cc: Carsey Jaben Cc: Wu Jiaxin Cc: Ye Ting Cc: Fu Siyuan Contributed-under: TianoCore

[edk2] [PATCH v2] MdePkg: Add UEFI2.6 HII Image Ex and Image Decoder protocol definition.

2016-03-01 Thread Cecil Sheng
Add the definition for the new UEFI 2.6 EFI_HII_IMAGE_EX_PROTOCOL and EFI_IMAGE_DECODER_PROTOCOL. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Cecil Sheng Reviewed-by: Samer El-Haj-Mahmoud Reviewed-by: Abner Chang

Re: [edk2] [PATCH v2] SecurityPkg: SecureBootConfigDxe: Enhance the code logic

2016-03-01 Thread Bi, Dandan
Hi Laszlo, I agree with your proposal! I will update the subject when commit the patch. Thank you very much for giving comments! Thanks, Dandan -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo Ersek Sent: Wednesday, March 2, 2016 1:31

Re: [edk2] [Patch] UefiCpuPkg/CpuMpPei: APs needn't to search microcode

2016-03-01 Thread Fan, Jeff
Please skip this patch. I need to refine this solution. Thanks! Jeff -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jeff Fan Sent: Wednesday, March 02, 2016 10:10 AM To: edk2-devel@lists.01.org Cc: Kinney, Michael D; Tian, Feng Subject: [edk2]

Re: [edk2] [Patch] UefiCpuPkg/Application/Cpuid: Change DisplayFamily/DisplayModel type

2016-03-01 Thread Qiu, Shumin
Reviewed-by: Qiu Shumin -Original Message- From: Fan, Jeff Sent: Wednesday, March 02, 2016 10:08 AM To: edk2-devel@lists.01.org Cc: Qiu, Shumin; Kinney, Michael D Subject: [Patch] UefiCpuPkg/Application/Cpuid: Change DisplayFamily/DisplayModel type Change

Re: [edk2] [patch] ShellPkg: Merge Ping6 and Ifconfig6 tools to Shell command.

2016-03-01 Thread Laszlo Ersek
Gary, On 03/02/16 03:13, Zhang Lubo wrote: > According to the new Shell spec, we add Network2 profile and > merge Ping6 and Ifconfig6 tools to Shell command. > > Cc: Carsey Jaben > Cc: Wu Jiaxin > Cc: Ye Ting > Cc: Fu Siyuan

[edk2] [PATCH v2] MdeModulePkg: Make HII configuration settings available to OS runtime

2016-03-01 Thread Dandan Bi
This feature is aimed to allow OS make use of the HII database during runtime. In this case, the contents of the HII Database is exported to a buffer. The pointer to the buffer is placed in the EFI System Configuration Table, where it can be retrieved by an OS application. Notes: Difference with

Re: [edk2] [patch] MdeModulePkg/FvSimpleFs: don't open DevicePath with BY_DRIVER mode

2016-03-01 Thread Zhang, Chao B
Reviewed-by: Chao Zhang Thanks & Best regards Chao Zhang -Original Message- From: Tian, Feng Sent: Wednesday, March 02, 2016 9:55 AM To: edk2-devel@lists.01.org Cc: Zhang, Chao B Subject: [patch] MdeModulePkg/FvSimpleFs: don't open DevicePath with

[edk2] [Patch] UefiCpuPkg/CpuMpPei: Load microcode if found newer revision

2016-03-01 Thread Jeff Fan
Current implementation only loads the latest revision if there is no microcode loaded. Per IA32 User Manual, we should load the newer revision by comparing the existing microcode loaded with the updating revision. Cc: Feng Tian Cc: Michael Kinney

[edk2] [Patch] UefiCpuPkg/CpuMpPei: APs needn't to search microcode

2016-03-01 Thread Jeff Fan
To improve performance, BSP will save the latest microcode information during searching the update microcode from microcode region. Then, APs needn't to search microcode and just make use of the saved latest microcode information. Cc: Feng Tian Cc: Michael Kinney

Re: [edk2] [Patch] UefiCpuPkg/Application/Cpuid: Remove unnecessary code check

2016-03-01 Thread Qiu, Shumin
Reviewed-by: Qiu Shumin -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jeff Fan Sent: Wednesday, March 02, 2016 10:08 AM To: edk2-devel@lists.01.org Cc: Kinney, Michael D; Qiu, Shumin Subject: [edk2] [Patch]

Re: [edk2] [PATCH] MdePkg: Add UEFI2.6 HII Image Ex and Image Decoder protocol definition.

2016-03-01 Thread Sheng, Cecil (HPS SW)
Hi Dandan, Thanks for your reply. I've corrected those and sent a v2 patch for review. There are some errors in the EFI_HII_IMAGE_DECODER_PROTOCOL protocol definition in the spec which make the protocol un-usable and non-compil-able. So I had to correct them in the header file. Sincerely,

Re: [edk2] [PATCH 0/6] more cleanups for DebugLib.h, then sync DSCs with it

2016-03-01 Thread Laszlo Ersek
On 03/01/16 10:58, Laszlo Ersek wrote: > Public branch: > . > > Cc: Ard Biesheuvel > Cc: Jordan Justen > Cc: Leif Lindholm > Cc: Liming Gao

[edk2] [PATCH v4 6/6] Nt32Pkg: Enable Nt32Pkg platform HTTPS boot feature.

2016-03-01 Thread Jiaxin Wu
v4: *The size of private variable required in HTTPS boot may be large than the default limitation. So, Add HTTPS_BOOT_ENABLE value check for PcdMaxVariableSize. This path is used to enable HTTPS boot feature. Cc: Ye Ting Cc: Fu Siyuan Cc: Long Qin

[edk2] [PATCH v2] SecurityPkg: SecureBootConfigDxe: Enhance the code logic

2016-03-01 Thread Dandan Bi
The function AllocateCopyPool may return NULL, so need to do check after calling it. This patch is to enhance the related logic. Notes: Difference with V1: -Update the function description. -Remove the ASSERT in UpdatePage and enhance the logic. Cc: Chao Zhang Cc: Qiu

Re: [edk2] [PATCH v2] SecurityPkg: SecureBootConfigDxe: Enhance the code logic

2016-03-01 Thread Laszlo Ersek
On 03/02/16 04:39, Dandan Bi wrote: > The function AllocateCopyPool may return NULL, so need to do check > after calling it. This patch is to enhance the related logic. I propose to change the subject line like this: SecurityPkg: SecureBootConfigDxe: handle allocation failure gracefully No need

Re: [edk2] [PATCH v3 2/2] MdeModulePkg: PciHostBridgeDxe: don't assume extended config space

2016-03-01 Thread Kinney, Michael D
Reviewed-by: Michael Kinney Mike > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Tuesday, March 1, 2016 2:22 AM > To: edk2-de...@ml01.01.org > Cc: Ni, Ruiyu ; Justen, Jordan L > ; >

Re: [edk2] [PATCH v3 1/2] MdeModulePkg: PciHostBridgeDxe: insert horizontal whitespace

2016-03-01 Thread Kinney, Michael D
Reviewed-by: Michael Kinney Mike > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Tuesday, March 1, 2016 2:22 AM > To: edk2-de...@ml01.01.org > Cc: Ni, Ruiyu ; Kinney, Michael D > >

Re: [edk2] [Patch] NetworkPkg: Add URI configuration form to HTTP boot driver.

2016-03-01 Thread Wang, Sunny (HPS SW)
Hi Siyuan, I just have two suggestions and a question below. Others look good to me. 1. It looks like the code blocks in the HttpBootAddBootOption function can be replaced with the UefiBootManagerLib functions (like EfiBootManagerInitializeLoadOption and

[edk2] [PATCH v3 2/2] MdeModulePkg: PciHostBridgeDxe: don't assume extended config space

2016-03-01 Thread Laszlo Ersek
The "pc" ("pc-i440fx-*") machine types of QEMU don't support extended config space. Accordingly, OVMF will use the following library instances in connection with the core PciHostBridgeDxe driver: BasePciSegmentLibPci [class: PciSegmentLib] BasePciLibCf8 [class: PciLib]

[edk2] [PATCH] EmbeddedPkg/AndroidFastbootTransportTcpDxe: Resolved compiler and build warnings

2016-03-01 Thread Shivamurthy Shastri
Resolved below errors: 1. Variable 'gEfiHostnameVariableGuid' used, but not defined GUID. 2. File 'Hostname.h' is included, but it is not available in source. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Shivamurthy Shastri ---

[edk2] [PATCH v3 1/2] MdeModulePkg: PciHostBridgeDxe: insert horizontal whitespace

2016-03-01 Thread Laszlo Ersek
... in preparation for the next patch. Cc: Ruiyu Ni Cc: Michael Kinney Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek --- MdeModulePkg/Include/Library/PciHostBridgeLib.h | 40

Re: [edk2] [PATCH] ArmPlatformPkg: delete orphaned ArmVExpress.dsc.inc

2016-03-01 Thread Ard Biesheuvel
On 1 March 2016 at 11:17, Leif Lindholm wrote: > In the recent migration of the ARM Ltd. platforms to > https://git.linaro.org/uefi/OpenPlatformPkg.git, this file unfortunately > got left behind. Delete it to reduce confusion and (further) risk of > duplication of

Re: [edk2] PL180MciDxe problem with TC2

2016-03-01 Thread Ryan Harkin
On 1 March 2016 at 11:18, Leif Lindholm wrote: > On Tue, Mar 01, 2016 at 11:03:18AM +, Ryan Harkin wrote: >> > Yes, and the public documentation found in the obvious place is not >> > for the part actually used on the platform, or at least not for the >> > same

Re: [edk2] [PATCH] EmbeddedPkg/AndroidFastbootTransportTcpDxe: Resolved compiler and build warnings

2016-03-01 Thread Laszlo Ersek
On 03/01/16 12:54, Ard Biesheuvel wrote: > On 1 March 2016 at 12:51, Laszlo Ersek wrote: >> On 03/01/16 12:41, Ard Biesheuvel wrote: >>> On 1 March 2016 at 12:34, Shivamurthy Shastri >>> wrote: Resolved below errors: 1. Variable

Re: [edk2] [PATCH 2/6] ArmPlatformPkg/ArmVExpressPkg: sync log level comments to DebugLib.h

2016-03-01 Thread Jordan Justen
(Adding Mike) On 2016-03-01 02:10:14, Leif Lindholm wrote: > On Tue, Mar 01, 2016 at 10:58:28AM +0100, Laszlo Ersek wrote: > > Suggested-by: Leif Lindholm > > Cc: Leif Lindholm > > Cc: Ard Biesheuvel > >

Re: [edk2] [PATCH 0/3] Fix PL180 for Versatile Express TC2

2016-03-01 Thread Leif Lindholm
k ID_REG3 > >> > > > > Looks fine to me > > > > Reviewed-by: Ard Biesheuvel <ard.biesheu...@linaro.org> > > Thanks! > > I've pushed them to my tree to make applying easier should Leif wish > to cherry-pick: > > https://git.linaro.org/la

Re: [edk2] [PATCH] BaseTools: Update ARM/AArch64 GenFv vector processing for encapsulated FVs

2016-03-01 Thread Cohen, Eugene
Ard, > ‘ARMT_UNCONDITIONAL_JUMP_INSTRUCTION’ undeclared (first use in this > function) I missed one or more defines upstreaming this, let me fix this. > The idea is to wrap my top level FV in a CRC32 wrapper, and still be able to > boot it XIP Unfortunately, the reset vector and PEI pointer are

Re: [edk2] [PATCH 0/6] more cleanups for DebugLib.h, then sync DSCs with it

2016-03-01 Thread Ryan Harkin
On 1 March 2016 at 14:10, Ryan Harkin wrote: > On 1 March 2016 at 10:11, Leif Lindholm wrote: >> On Tue, Mar 01, 2016 at 11:00:45AM +0100, Ard Biesheuvel wrote: >>> On 1 March 2016 at 10:58, Laszlo Ersek wrote: >>> > Public

Re: [edk2] [Patch 2/4] NetworkPkg: Change the default IPv6 config policy

2016-03-01 Thread Fu, Siyuan
Reviewed-by: Fu Siyuan > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Jiaxin Wu > Sent: Thursday, February 25, 2016 12:22 PM > To: edk2-devel@lists.01.org > Cc: Ye, Ting ; Fu, Siyuan

Re: [edk2] Force shell device mapping

2016-03-01 Thread Laszlo Ersek
On 03/01/16 16:55, Foster, Matthew I wrote: > Is there an easy to way to force the shell to map certain partitions to FS0: > and FS1: respectively? For example, I have an EMMC device that has 2 EFI > partitions(GPT). When I setup the device with these 2 EFI partitions using > partition number 2

[edk2] [PATCH] ArmPkg: Configure TTBCR register

2016-03-01 Thread evan . lloyd
From: Evan Lloyd Architecturally, the TTBCR register value is undefined at reset for Non-Secure. On some platforms the reset value for TTBCR is not zero and this causes a data abort exception once the MMU is enabled. This patch configures the TTBCR register to enable

Re: [edk2] [PATCH 2/6] ArmPlatformPkg/ArmVExpressPkg: sync log level comments to DebugLib.h

2016-03-01 Thread Leif Lindholm
On Tue, Mar 01, 2016 at 02:07:42PM +, Ryan Harkin wrote: > On 1 March 2016 at 10:10, Leif Lindholm wrote: > > On Tue, Mar 01, 2016 at 10:58:28AM +0100, Laszlo Ersek wrote: > >> Suggested-by: Leif Lindholm > >> Cc: Leif Lindholm

[edk2] [PATCH 3/3] ArmPlatformPkg/PL180MciDxe: don't check ID_REG3

2016-03-01 Thread Ryan Harkin
TC2 reads 0x02 for the PL180 ID3 register instead of 0x00 as defined in the spec. However, the spec [1] states that the contents of ID3 register represent the "configuration option of the peripheral" and thus not part of the Prime Cell identification. For this patch, we drop checking the value