Re: [edk2] [PATCH] ArmPlatformPkg: Set Juno debug serial port defaults

On 1 July 2016 at 13:52, wrote: > From: Evan Lloyd > > Juno has several serial ports, one of which may be used for a remote > debug interface (e.g. gdb, WinDbg). The debug serial port needs to > be distinct from that used for UEFI trace to prevent

Re: [edk2] [PATCH 1/2] Revert "ShellPkg/UefiShellDebug1CommandsLib: remove unused but set variable"

Reviewed-by: Jaben Carsey > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Ruiyu Ni > Sent: Wednesday, July 06, 2016 9:37 PM > To: edk2-devel@lists.01.org > Cc: Ni, Ruiyu ; Gao, Liming

Re: [edk2] [PATCH] add top-level .gitattributes file, dealing with .depex

On 07/07/16 16:24, Leif Lindholm wrote: > Git tends to see .depex files as text, causing hideous patches being > generated (and breaking PatchCheck.py). > > Add a .gitattributes file instructing git to treat them as binary. > > Contributed-under: TianoCore Contribution Agreement 1.0 >

[edk2] [PATCH] add top-level .gitattributes file, dealing with .depex

Git tends to see .depex files as text, causing hideous patches being generated (and breaking PatchCheck.py). Add a .gitattributes file instructing git to treat them as binary. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Leif Lindholm ---

Re: [edk2] [PATCH 1/2] Revert "ShellPkg/UefiShellDebug1CommandsLib: remove unused but set variable"

On 7 July 2016 at 06:36, Ruiyu Ni wrote: > This reverts commit e36ed7a84b2768443de22371f0aad5cf502328b1. > The above commit fixed a build failure in > "ShellPkg: Make the USB mouse behavior in 'edit' consistent with > 'hexedit'.". > Since the next patch will revert the USB

Re: [edk2] [PATCH 16/16] ShellPkg: Series of patches to fix typos - apropriate to appropriate

Reviewed-by: Jaben Carsey > -Original Message- > From: Mudusuru, Giri P > Sent: Thursday, July 07, 2016 12:48 AM > To: edk2-devel@lists.01.org > Cc: Carsey, Jaben ; Qiu, Shumin > > Subject: [edk2] [PATCH 16/16]

Re: [edk2] [PATCH 06/16] StdLib: Series of patches to fix typos - availabe to available

Reviewed-by: Jaben Carsey > -Original Message- > From: Mudusuru, Giri P > Sent: Thursday, July 07, 2016 12:48 AM > To: edk2-devel@lists.01.org > Cc: Carsey, Jaben ; Daryl McDaniel li...@mc2research.org> > Subject: [edk2] [PATCH 06/16]

Re: [edk2] [PATCH 2/2] Revert "ShellPkg: Make the USB mouse behavior in 'edit' consistent with 'hexedit'."

Hehe... no problem. Reviewed-by: Jaben Carsey > -Original Message- > From: Ni, Ruiyu > Sent: Wednesday, July 06, 2016 9:52 PM > To: edk2-devel@lists.01.org > Cc: Carsey, Jaben > Subject: RE: [PATCH 2/2] Revert "ShellPkg: Make the USB

Re: [edk2] [PATCH 4/6] ShellPkg: don't call functions with side effects in ASSERT_EFI_ERROR()

We should see why If and Else are using this different API for sure. I don't remember why. I would be happy to remove it completely if there is no objection. -Jaben > -Original Message- > From: Ni, Ruiyu > Sent: Thursday, July 07, 2016 1:20 AM > To: Carsey, Jaben

Re: [edk2] [PATCH] ArmPlatformPkg: Set Juno debug serial port defaults

On Fri, Jul 01, 2016 at 12:52:06PM +0100, evan.ll...@arm.com wrote: > From: Evan Lloyd > > Juno has several serial ports, one of which may be used for a remote > debug interface (e.g. gdb, WinDbg). The debug serial port needs to > be distinct from that used for UEFI trace to

Re: [edk2] [PATCH] ArmPlatformPkg: Set Juno debug serial port defaults

On 7 July 2016 at 16:59, Leif Lindholm wrote: > On Fri, Jul 01, 2016 at 12:52:06PM +0100, evan.ll...@arm.com wrote: >> From: Evan Lloyd >> >> Juno has several serial ports, one of which may be used for a remote >> debug interface (e.g. gdb, WinDbg).

Re: [edk2] [PATCH] ArmPlatformPkg: Set Juno debug serial port defaults

On Thu, Jul 07, 2016 at 05:24:54PM +0100, Ryan Harkin wrote: > On 7 July 2016 at 17:01, Ryan Harkin wrote: > > On 7 July 2016 at 16:59, Leif Lindholm wrote: > >> On Fri, Jul 01, 2016 at 12:52:06PM +0100, evan.ll...@arm.com wrote: > >>> From: Evan

[edk2] [PATCH 0/7] Introduce three new toolchains in edk2

Please review my new commits in public branch: https://github.com/shijunjing/edk2/commits/review6 I did below enhancements according feedback: 1. Remove the Quark platform work around and code clean work from this serial patches. 2. Seperate three toolchains to three different patches. 3.

Re: [edk2] [PATCH 0/7] Introduce three new toolchains in edk2

On 7 July 2016 at 17:36, Shi, Steven wrote: > Please review my new commits in public branch: > https://github.com/shijunjing/edk2/commits/review6 > I'm sorry, but that is not how it works. You need to send them to the mailing list. Also, please put v2 (or v3 or whatever)

Re: [edk2] [PATCH] ArmPlatformPkg: Set Juno debug serial port defaults

On 7 July 2016 at 17:01, Ryan Harkin wrote: > On 7 July 2016 at 16:59, Leif Lindholm wrote: >> On Fri, Jul 01, 2016 at 12:52:06PM +0100, evan.ll...@arm.com wrote: >>> From: Evan Lloyd >>> >>> Juno has several serial ports,

Re: [edk2] [PATCH 0/4] PCI resource reservation changes for better hotpluggability

Ping -- do you guys (esp. package maintainers) have any further feedback for this series? Presently I have one R-b from Ray for patch #1. Two MdeModulePkg patches plus one OvmfPkg patch need reviews. I have two small changes queued already for v2 (noted in the thread) -- if you would like to see

Re: [edk2] [staging/HTTPS-TLS][PATCH 0/2] Live Certificate support and code refine.

Jiaxin, This is a nice feature but we need to add a setting to control whether to throw up a prompt in the first place. I can imagine our enterprise customers only ever wanting to trust the root certificates that they installed. In case of a UEFI script running, they would not want

Re: [edk2] [PATCH 4/4] OvmfPkg: add PciHotPlugInitDxe

On 2016-06-30 18:10:53, Laszlo Ersek wrote: > +EFI_STATUS > +EFIAPI > +DriverInitialize ( > + IN EFI_HANDLE ImageHandle, > + IN EFI_SYSTEM_TABLE *SystemTable > + ) > +{ > + EFI_STATUS Status; > + > + if (!FeaturePcdGet (PcdPciBusHotplugDeviceSupport)) { > +DEBUG ((EFI_D_WARN, > +

[edk2] [PATCH] ArmPkg/ArmGicLib: manage GICv3 SPI state at the distributor

Unlike SGIs and PPIs, which are private to the CPU and are managed at the redistributor level (which is also a per-CPU construct), shared interrupts (SPIs) are shared between all CPUs, and therefore managed at the distributor level. Reported-by: Narinder Dhillon

Re: [edk2] [PATCH 1/7] BaseTools: Enable three new toolchains

Hi Jordan, I've separated this patch to 3 commits and post a public branch for them: https://github.com/shijunjing/edk2/commits/review6 . Please take a look. Steven Shi Intel\SSG\STO\UEFI Firmware Tel: +86 021-61166522 iNet: 821-6522 > -Original Message- > From: Shi, Steven > Sent:

Re: [edk2] multiprocessing in PEI?

Laszlo, If all memory below 640K is allocated for use by other PEIMs, the "borrow" technique can still work for the CpuMpPeim. If we add the scanning code for 2B, we will just ignore the result anyways if all memory below 640K is already allocated. So we will add logic with no value. I

Re: [edk2] [PATCH 06/16] StdLib: Series of patches to fix typos - availabe to available

Thanks Daryl. These seem to be implementation typos. I just cross checked in spec and it looks good. Thanks, -Giri > -Original Message- > From: Daryl McDaniel [mailto:edk2-li...@mc2research.org] > Sent: Thursday, July 7, 2016 9:42 AM > To: Carsey, Jaben ;

Re: [edk2] UEFI driver for USB CDC ACM Serial device

Thanks Feng. Even I felt the same way. Just wanted to know if there is any other such, more nearer driver available in UEFI for USB to serial or USB CDC driver source code? Please confirm... If not, I will go with ftdi driver. Thanks. With regards, Keshava On 7 ಜು., 2016 ಗು. 12:48 PM Tian, Feng

Re: [edk2] multiprocessing in PEI?

On 07/07/16 20:02, Kinney, Michael D wrote: > Laszlo, > > Good feedback. As I mentioned earlier, we are cleaning up these modules. We > can make sure everything is consistent for the "borrow" case. > > I agree it would be better to "borrow" a page that is not being used by > any other PEIM.

[edk2] [PATCH 1/4] OvmfPkg/PlatformPei: create one memory HOB at S3 resume too, for CpuMpPei

CpuMpPei will have to place the AP startup vector in memory under 1MB. For this, CpuMpPei borrows memory under 1MB, but it needs a memory resource descriptor HOB to exist there even on the S3 resume path (see the GetWakeupBuffer() function). Produce such a HOB as an exception on the S3 resume

Re: [edk2] multiprocessing in PEI?

Laszlo, Good feedback. As I mentioned earlier, we are cleaning up these modules. We can make sure everything is consistent for the "borrow" case. I agree it would be better to "borrow" a page that is not being used by any other PEIM. We will consider ASSERT() if there is no free memory. Mike

[edk2] [PATCH 3/4] OvmfPkg: include UefiCpuPkg/CpuMpPei

In the next patch we're going to put EFI_PEI_MP_SERVICES_PPI to use. CpuMpPei uses the following PCDs from gUefiCpuPkgTokenSpaceGuid, beyond those already used by CpuDxe: - PcdCpuMicrocodePatchAddress and PcdCpuMicrocodePatchRegionSize: these control whether CpuMpPei performs microcode update.

[edk2] [PATCH 0/4] OvmfPkg: program MSR_IA32_FEATURE_CONTROL from fw_cfg on all processors

This series fixes : RFE: OvmfPkg: Set MSR_IA32_FEATURE_CONTROL by following QEMU fw_cfg file The Request for Enhancement is very detailed (thankfully), so I will not copy details here. I will describe the patch series in brief: Patches #1 and #2

[edk2] [PATCH 4/4] OvmfPkg/PlatformPei: program MSR_IA32_FEATURE_CONTROL from fw_cfg

Under certain circumstances, QEMU exposes the "etc/msr_feature_control" fw_cfg file, with a 64-bit little endian value. The firmware is supposed to write this value to MSR_IA32_FEATURE_CONTROL (0x3a), on all processors, on the normal and the S3 resume boot paths. Utilize EFI_PEI_MPSERVICES_PPI to

[edk2] [PATCH 2/4] OvmfPkg: increase the S3 permanent PEI RAM size by 8.5 MB

When setting PcdCpuMaxLogicalProcessorNumber to 255, then CpuMpPei seems to require a bit more than 8MB of permanent PEI RAM in the PrepareAPStartupVector() function. (With the default PCD value of 64, it needs one quarter of that: approximately 2MB.) On the S3 resume path, we install only 32 KB

[edk2] Firmware Management Protocol: CHAR16* fields in EFI_FIRMWARE_IMAGE_DESCRIPTOR

Before I go hassling the USWG, I thought I'd check here in case anyone knows. In the Firmware Management Protocol introduced in UEFI 2.3, there's a EFI_FIRMWARE_IMAGE_DESCRIPTOR structure that has two CHAR16* fields, 'ImageIdName' and 'VersionName'. The UEFI spec doesn't say anything about

Re: [edk2] [PATCH 4/4] OvmfPkg/PlatformPei: program MSR_IA32_FEATURE_CONTROL from fw_cfg

On 07/07/16 21:10, Laszlo Ersek wrote: > Under certain circumstances, QEMU exposes the "etc/msr_feature_control" > fw_cfg file, with a 64-bit little endian value. The firmware is supposed > to write this value to MSR_IA32_FEATURE_CONTROL (0x3a), on all processors, > on the normal and the S3 resume

Re: [edk2] StdLib usage for drivers?

> At that point, you will have all of the StdLIb functionality except for command-line, console I/O and file system support. all these could be added in later patches though. stdin/stdout/stderr are really just redirecting writes to fd's 0,1,2 to the default console device. The Shell Protocol

[edk2] [staging/HTTPS-TLS][PATCH 0/2] Live Certificate support and code refine.

The series patches are used to support "Live Certificate" case, we can also call it as "self-signed certificate in chain" case. Background for "self-signed certificate in chain": Currently, if server CA certificate is not configured in UEFI client, EFI ERROR will be returned directly.

[edk2] [staging/HTTPS-TLS][PATCH 2/2] NetworkPkg: Continue the session even no local cert found

This patch did following updates: * To support "Live Certificate" case, allow to continue the session even no local cert found. * Fix potential assert issue when connection failed. Cc: Palmer Thomas Cc: Samer El-Haj-Mahmoud Cc: Long Qin

[edk2] [staging/HTTPS-TLS][PATCH 1/2] CryptoPkg: Set X509_STORE Verify callback function

This patch did following updates: * Set X509_STORE Verify callback function to support "Live Certificate" with the capacity of user trusted/untrusted hint popup if server CA certificate received in handshake message. * Refine the coding style. Cc: Palmer Thomas Cc: Samer

[edk2] [PATCH 06/16] StdLib: Series of patches to fix typos - availabe to available

Cc: Jaben Carsey Cc: Daryl McDaniel Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Giri P Mudusuru --- StdLib/EfiSocketLib/DxeSupport.c | 2 +- StdLib/Include/Efi/EfiSocketLib.h | 2 +- 2

[edk2] [PATCH 07/16] SecurityPkg: Series of patches to fix typos - availabe to available

Cc: Chao Zhang Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Giri P Mudusuru --- SecurityPkg/Hash2DxeCrypto/Driver.c | 2 +- SecurityPkg/Hash2DxeCrypto/Driver.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)

[edk2] [PATCH 08/16] OptionRomPkg: Series of patches to fix typos - EFI_OUT_OF_RESORUCES to EFI_OUT_OF_RESOURCES

Cc: Ruiyu Ni Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Giri P Mudusuru --- OptionRomPkg/Bus/Usb/UsbNetworking/Ax88772/SimpleNetwork.c | 2 +- OptionRomPkg/Bus/Usb/UsbNetworking/Ax88772b/SimpleNetwork.c | 2 +- 2 files

[edk2] [PATCH 02/16] EdkCompatibilityPkg: Series of patches to fix typos - availabe to available - consummer to consumer - EFI_UNSUPPORTEDT to EFI_UNSUPPORTED - extensiable to extensible

Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Giri P Mudusuru --- .../Compatibility/PiSmbiosRecordOnDataHubSmbiosRecordThunk/Thunk.c| 2 +- EdkCompatibilityPkg/Foundation/Core/Dxe/ArchProtocol/Cpu/Cpu.h

[edk2] [PATCH 05/16] CryptoPkg: Series of patches to fix typos - availabe to available

Cc: Qin Long Cc: Ting Ye Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Giri P Mudusuru --- CryptoPkg/Library/BaseCryptLib/SysCall/RuntimeMemAllocation.c | 2 +- 1 file changed, 1 insertion(+), 1

[edk2] [PATCH 01/16] ArmPkg: Series of patches to fix typos

- EFI_UNSUPPORTEDT to EFI_UNSUPPORTED Cc: Leif Lindholm Cc: Ard Biesheuvel Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Giri P Mudusuru --- ArmPkg/Drivers/CpuDxe/CpuDxe.c | 2 +- 1 file

Re: [edk2] [PATCH 09/16] PcAtChipsetPkg: Series of patches to fix typos - EFI_UNSUPPORTEDT to EFI_UNSUPPORTED

Reviewed-by: Ruiyu Ni > -Original Message- > From: Mudusuru, Giri P > Sent: Thursday, July 7, 2016 3:48 PM > To: edk2-devel@lists.01.org > Cc: Ni, Ruiyu > Subject: [edk2] [PATCH 09/16] PcAtChipsetPkg: Series of patches to fix typos > -

Re: [edk2] [PATCH 08/16] OptionRomPkg: Series of patches to fix typos - EFI_OUT_OF_RESORUCES to EFI_OUT_OF_RESOURCES

Reviewed-by: Ruiyu Ni > -Original Message- > From: Mudusuru, Giri P > Sent: Thursday, July 7, 2016 3:48 PM > To: edk2-devel@lists.01.org > Cc: Ni, Ruiyu > Subject: [edk2] [PATCH 08/16] OptionRomPkg: Series of patches to fix typos - >

[edk2] [PATCH 11/16] MdeModulePkg: Series of patches to fix typos

- abstrated to abstracted - accessibla to accessible - addres to address - apropriate to appropriate - arry to array - availabe to available - avaliable to available - becasue to because - correponding to corresponding - etablished to established - exeuction to execution -

Re: [edk2] [PATCH 04/16] Nt32Pkg: Series of patches to fix typos - EFI_UNSUPPORTEDT to EFI_UNSUPPORTED

Reviewed-by: Ruiyu Ni > -Original Message- > From: Mudusuru, Giri P > Sent: Thursday, July 7, 2016 3:48 PM > To: edk2-devel@lists.01.org > Cc: Ni, Ruiyu > Subject: [edk2] [PATCH 04/16] Nt32Pkg: Series of patches to fix typos - >

Re: [edk2] [PATCH 15/16] UefiCpuPkg: Series of patches to fix typos

Reviewed-by: Jeff Fan -Original Message- From: Mudusuru, Giri P Sent: Thursday, July 07, 2016 3:48 PM To: edk2-devel@lists.01.org Cc: Fan, Jeff Subject: [edk2] [PATCH 15/16] UefiCpuPkg: Series of patches to fix typos - becasue to because Cc: Jeff Fan

[edk2] [PATCH v2] MdeModulePkg SdBlockIoPei: Initialize 'SwitchResp' elements before using

The commit makes sure that the elements in array 'SwitchResp' get initialized before being used. Cc: Feng Tian Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Hao Wu --- MdeModulePkg/Bus/Sd/SdBlockIoPei/SdHci.c | 1 + 1 file

Re: [edk2] Build fails due to missing NASM

Peter: I mention such information in my sent patch to edk2 community. Please see http://article.gmane.org/gmane.comp.bios.edk2.devel/13297 Thanks Liming > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > peter.kirme...@ts.fujitsu.com > Sent:

Re: [edk2] multiprocessing in PEI?

On 07/07/16 10:29, Fan, Jeff wrote: > Laszlo, > > Actually, CpuMpPei has no knowledge to know which memory range < 1MB is > available or not. That's why we cannot assume one hardcode address < 1MB for > borrowing. I agree that this makes sense. > > Platform has such knowledge and need one

Re: [edk2] multiprocessing in PEI?

Laszlo, Any PEI module cannot allocate the memory < 1MB range if using PEI memory allocation services only. If other PEI module wants to allocate the memory by scanning memory resource HOB, it has to follow the same rule with the CpuMpPei driver. If platform build allocation HOB for the whole

[edk2] [PATCH 13/16] NetworkPkg: Series of patches to fix typos

- abstrated to abstracted - apropriate to appropriate - availabe to available - ptototypes to prototypes - prococol protocol Cc: Siyuan Fu Cc: Jiaxin Wu Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Giri P Mudusuru

[edk2] [PATCH 16/16] ShellPkg: Series of patches to fix typos - apropriate to appropriate

Cc: Jaben Carsey Cc: Shumin Qiu Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Giri P Mudusuru --- ShellPkg/Include/Library/ShellLib.h| 2 +-

Re: [edk2] [PATCH 05/16] CryptoPkg: Series of patches to fix typos - availabe to available

Reviewed-by: Qin Long Best Regards & Thanks, LONG, Qin > -Original Message- > From: Mudusuru, Giri P > Sent: Thursday, July 07, 2016 3:48 PM > To: edk2-devel@lists.01.org > Cc: Long, Qin; Ye, Ting > Subject: [edk2] [PATCH 05/16] CryptoPkg: Series of patches to fix

[edk2] [PATCH] MdeModulePkg SdBlockIoPei: Initialize 'SwitchResp' elements before using

The commit makes sure that the elements in array 'SwitchResp' get initialized before being used. Cc: Feng Tian Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Hao Wu --- MdeModulePkg/Bus/Sd/SdBlockIoPei/SdHci.c | 1 + 1 file

[edk2] [PATCH 03/16] EmulatorPkg: Series of patches to fix typos - EFI_UNSUPPORTEDT to EFI_UNSUPPORTED

Cc: Andrew Fish Cc: Jordan Justen Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Giri P Mudusuru --- EmulatorPkg/TimerDxe/Timer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [edk2] multiprocessing in PEI?

Laszlo, Ovmf is just required to build resource HOB as blew on S3 path. AddMemoryRangeHob (0, BASE_512KB + BASE_128KB); And It is responsibility of consumer (like CpuMpPei or other PEI module) to build allocation HOB. Thanks! Jeff -Original Message- From: Laszlo Ersek

Re: [edk2] [PATCH 4/6] ShellPkg: don't call functions with side effects in ASSERT_EFI_ERROR()

Jaben, CommandInit() API initializes gUnicodeCollation pointer. But ShellCommandLibConstructor() also initializes the gUnicodeCollation pointer. Can we just remove CommandInit() from this library? And update all callers? Thanks/Ray > -Original Message- > From: edk2-devel

[edk2] [PATCH v1 1/1] ShellPkg:Ping: Ping command hangs with intermittent packet losses

When we have intermittent loss of packets, ping command doesnt return to Shell prompt. It keeps looping in the while (Status ==EFI_NOT_READY) since Private->RxCount will never reach Private->SendNum. Addresses the issue with the use of a new varibale in the PRIVATE structure. Contributed-under:

[edk2] [PATCH 15/16] UefiCpuPkg: Series of patches to fix typos

- becasue to because Cc: Jeff Fan Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Giri P Mudusuru --- UefiCpuPkg/CpuMpPei/Microcode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[edk2] [PATCH 14/16] OvmfPkg: Series of patches to fix typos - accessibla to accessible - exeuction to execution - iff to if

Cc: Jordan Justen Cc: Laszlo Ersek Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Giri P Mudusuru --- OvmfPkg/AcpiPlatformDxe/QemuFwCfgAcpi.c | 2 +-

Re: [edk2] multiprocessing in PEI?

On 07/07/16 04:52, Fan, Jeff wrote: > Laszlo, > > On PEI phase, whatever it is normal boot or S3 boot, PEI memory allocation > services should not allocate memory < 1 MB address. > > If any other PEIM module wants to allocate memory < 1 MB address, it has to > scan Memory resource HOB to find

Re: [edk2] UEFI driver for USB CDC ACM Serial device

You could refer to OptionRomPkg\Bus\Usb\FtdiUsbSerialDxe, which is a usb2serial driver. It will produce SerialIo based on UsbIo. Thanks Feng From: GN Keshava [mailto:keshava...@gmail.com] Sent: Thursday, July 7, 2016 11:34 AM To: Tian, Feng ; edk2-devel@lists.01.org

[edk2] [PATCH 12/16] MdePkg: Series of patches to fix typos - availabe to available - EFI_UNSUPPORTEDT to EFI_UNSUPPORTED

Cc: Liming Gao Cc: Michael D Kinney Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Giri P Mudusuru --- MdePkg/Include/Protocol/Cpu.h| 2 +- MdePkg/Include/Protocol/ServiceBinding.h

[edk2] [PATCH 00/16] Fix typos in comments and variable names

Giri P Mudusuru (16): ArmPkg: Series of patches to fix typos EdkCompatibilityPkg: Series of patches to fix typos - availabe to available - consummer to consumer - EFI_UNSUPPORTEDT to EFI_UNSUPPORTED - extensiable to extensible EmulatorPkg: Series of patches to fix typos -

[edk2] [PATCH 10/16] IntelFrameworkModulePkg: Series of patches to fix typos - requried to required

Cc: Jeff Fan Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Giri P Mudusuru --- IntelFrameworkModulePkg/Universal/BdsDxe/FrontPage.c| 6 +++--- .../Universal/SectionExtractionDxe/SectionExtraction.c

[edk2] [PATCH 09/16] PcAtChipsetPkg: Series of patches to fix typos - EFI_UNSUPPORTEDT to EFI_UNSUPPORTED

Cc: Ruiyu Ni Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Giri P Mudusuru --- PcAtChipsetPkg/8254TimerDxe/Timer.c | 2 +- PcAtChipsetPkg/8254TimerDxe/Timer.h | 2 +- PcAtChipsetPkg/HpetTimerDxe/HpetTimer.c | 4 ++--

Re: [edk2] [PATCH 10/16] IntelFrameworkModulePkg: Series of patches to fix typos - requried to required

Reviewed-by: Jeff Fan -Original Message- From: Mudusuru, Giri P Sent: Thursday, July 07, 2016 3:48 PM To: edk2-devel@lists.01.org Cc: Fan, Jeff Subject: [edk2] [PATCH 10/16] IntelFrameworkModulePkg: Series of patches to fix typos - requried to required Cc: Jeff Fan

Re: [edk2] [PATCH] MdeModulePkg SdBlockIoPei: Initialize 'SwitchResp' elements before using

Hao, Please use ZeroMem() directly. Thanks Feng -Original Message- From: Wu, Hao A Sent: Thursday, July 7, 2016 4:03 PM To: edk2-devel@lists.01.org Cc: Wu, Hao A ; Tian, Feng Subject: [PATCH] MdeModulePkg SdBlockIoPei: Initialize 'SwitchResp'

Re: [edk2] [PATCH v2] MdeModulePkg SdBlockIoPei: Initialize 'SwitchResp' elements before using

Reviewed-by: Feng Tian Thanks Feng -Original Message- From: Wu, Hao A Sent: Thursday, July 7, 2016 4:10 PM To: edk2-devel@lists.01.org Cc: Wu, Hao A ; Tian, Feng Subject: [PATCH v2] MdeModulePkg SdBlockIoPei: Initialize

Re: [edk2] [PATCH v1 1/1] ShellPkg:Ping: Ping command hangs with intermittent packet losses

Reviewed-by: Sriram Subramanian -Original Message- From: Hegde, Nagaraj P Sent: Thursday, July 7, 2016 12:59 PM To: edk2-devel@lists.01.org Cc: jiaxin...@intel.com; jaben.car...@intel.com; ruiyu...@intel.com; Subramanian, Sriram (EG Servers Platform SW)

[edk2] Build fails due to missing NASM

Hello, I just updated our local edk2 fork and there were a lot of new .nasm files added. Unfortunately this update was not compiling any more. The reason is that we don't have the tool NASM installed. I got it back working again by installing NASM but what I want to mention here: I was missing

Re: [edk2] multiprocessing in PEI?

Laszlo, Actually, CpuMpPei has no knowledge to know which memory range < 1MB is available or not. That's why we cannot assume one hardcode address < 1MB for borrowing. Platform has such knowledge and need one mechanism to tell CpuMpPei. We choose Memory Resource HOB here. Thanks! Jeff

Re: [edk2] [PATCH 07/16] SecurityPkg: Series of patches to fix typos - availabe to available

Giri: Please update copyright. Others are good to me. Thanks & Best regards Chao Zhang -Original Message- From: Mudusuru, Giri P Sent: Thursday, July 07, 2016 3:48 PM To: edk2-devel@lists.01.org Cc: Zhang, Chao B Subject: [edk2] [PATCH 07/16] SecurityPkg: Series of patches to

Re: [edk2] Build fails due to missing NASM

Hi Laszlo, I agree that being on this list helps a lot in different ways. In my opinion the main benefit of a mailing lists is the room for discussion. Results of discussions should then be placed into the documentation. So further on, no one have to read the discussion in the archive again

Re: [edk2] Build fails due to missing NASM

Hi Liming, yes I see, but there are lots of people not reading every single patch note of this email list or don't even are part of the list. However, also newcomers who don't know the past (or this email list at all) won't know anything about such changes happening in the background.

Re: [edk2] Build fails due to missing NASM

Peter: Thanks for your suggestion. I think we can add the dependency check in edksetup.bat/edksetup.sh. If nasm is not installed, setup script will report warning message to user. Meanwhile, we can update wiki

Re: [edk2] multiprocessing in PEI?

On 07/07/16 10:56, Fan, Jeff wrote: > Laszlo, > > Any PEI module cannot allocate the memory < 1MB range if using PEI memory > allocation services only. Okay. > If other PEI module wants to allocate the memory by scanning memory resource > HOB, it has to follow the same rule with the CpuMpPei

Re: [edk2] Firmware Management Protocol: CHAR16* fields in EFI_FIRMWARE_IMAGE_DESCRIPTOR

> On Jul 7, 2016, at 1:27 PM, Marvin H?user wrote: > > Hey Bruce, > > Sorry if I am wasting your time, but where exactly is the problem? > > I don't think these strings can ever be statically allocated. If pointers to > stack variables were used, the strings would

Re: [edk2] Firmware Management Protocol: CHAR16* fields in EFI_FIRMWARE_IMAGE_DESCRIPTOR

On 7/7/2016 2:27 PM, Marvin H?user wrote: I don't think these strings can ever be statically allocated. If pointers to stack variables were used, the strings would be theoretically invalid the moment the exposing function returns. Furthermore they can't be part oft he struct itself as that

Re: [edk2] Firmware Management Protocol: CHAR16* fields in EFI_FIRMWARE_IMAGE_DESCRIPTOR

> On Jul 7, 2016, at 12:35 PM, Bruce Cran wrote: > > Before I go hassling the USWG, I thought I'd check here in case anyone knows. > > In the Firmware Management Protocol introduced in UEFI 2.3, there's a > EFI_FIRMWARE_IMAGE_DESCRIPTOR structure that has two CHAR16*

Re: [edk2] Firmware Management Protocol: CHAR16* fields in EFI_FIRMWARE_IMAGE_DESCRIPTOR

Hey Bruce, Sorry if I am wasting your time, but where exactly is the problem? I don't think these strings can ever be statically allocated. If pointers to stack variables were used, the strings would be theoretically invalid the moment the exposing function returns. Furthermore they can't be

Re: [edk2] Firmware Management Protocol: CHAR16* fields in EFI_FIRMWARE_IMAGE_DESCRIPTOR

On 7/7/2016 2:06 PM, Andrew Fish wrote: Probably worth brining it up with the UEFI Forum. Thanks, I've just emailed them. -- Bruce ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] Firmware Management Protocol: CHAR16* fields in EFI_FIRMWARE_IMAGE_DESCRIPTOR

Hey Andrew, I have missed that it's not about the protocol directly, but about a returned data structure, so please excuse me! Thanks, Marvin. > -Original Message- > From: af...@apple.com [mailto:af...@apple.com] > Sent: Thursday, July 7, 2016 10:33 PM > To: Marvin H?user

Re: [edk2] [PATCH 4/4] OvmfPkg: add PciHotPlugInitDxe

I vote for separate driver:) it's more clean and easy to maintain. Thanks, Ray > 在 2016年7月8日，上午1:59，Laszlo Ersek 写道： > >> On 07/07/16 19:36, Jordan Justen wrote: >>> On 2016-06-30 18:10:53, Laszlo Ersek wrote: >>> +EFI_STATUS >>> +EFIAPI >>> +DriverInitialize ( >>> + IN

Re: [edk2] [PATCH 4/4] OvmfPkg: add PciHotPlugInitDxe

On 2016-07-07 15:55:34, Ni, Ruiyu wrote: > I vote for separate driver:) it's more clean and easy to maintain. > (sigh) I guess that is the nature of EDK II. Big, but modular! :) It's not like this decision is going to make OVMF compete with seabios on size or speed, so: Acked-by: Jordan Justen

Re: [edk2] [PATCH 4/4] OvmfPkg: add PciHotPlugInitDxe

On 07/08/16 01:38, Jordan Justen wrote: > On 2016-07-07 15:55:34, Ni, Ruiyu wrote: >> I vote for separate driver:) it's more clean and easy to maintain. >> > > (sigh) I guess that is the nature of EDK II. Big, but modular! :) It's > not like this decision is going to make OVMF compete with

Re: [edk2] [PATCH 13/16] NetworkPkg: Series of patches to fix typos

Reviewed-By: Wu Jiaxin Best Regards! Jiaxin > -Original Message- > From: Mudusuru, Giri P > Sent: Thursday, July 7, 2016 3:48 PM > To: edk2-devel@lists.01.org > Cc: Fu, Siyuan ; Wu, Jiaxin > Subject: [edk2] [PATCH 13/16]

Re: [edk2] [PATCH] MdePkg Base.h: Fix typo funcation to function

Reviewed-by: Liming Gao > -Original Message- > From: Zeng, Star > Sent: Friday, July 08, 2016 9:34 AM > To: edk2-devel@lists.01.org > Cc: Zeng, Star ; Gao, Liming ; > Kinney, Michael D ; Yao,

Re: [edk2] UEFI driver for USB CDC ACM Serial device

No other nearer drivers you can refer to except this one. Thanks Feng -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of GN Keshava Sent: Friday, July 8, 2016 1:51 AM To: Tian, Feng ; edk2-devel@lists.01.org Subject: Re: [edk2]

Re: [edk2] [PATCH 12/16] MdePkg: Series of patches to fix typos - availabe to available - EFI_UNSUPPORTEDT to EFI_UNSUPPORTED

Reviewed-by: Liming Gao > -Original Message- > From: Mudusuru, Giri P > Sent: Thursday, July 07, 2016 3:48 PM > To: edk2-devel@lists.01.org > Cc: Gao, Liming ; Kinney, Michael D > > Subject: [edk2] [PATCH 12/16]

Re: [edk2] [PATCH 02/16] EdkCompatibilityPkg: Series of patches to fix typos - availabe to available - consummer to consumer - EFI_UNSUPPORTEDT to EFI_UNSUPPORTED - extensiable to extensible

Reviewed-by: Liming Gao > -Original Message- > From: Mudusuru, Giri P > Sent: Thursday, July 07, 2016 3:48 PM > To: edk2-devel@lists.01.org > Cc: Gao, Liming > Subject: [edk2] [PATCH 02/16] EdkCompatibilityPkg: Series of patches to fix > typos

Re: [edk2] [Patch] Vlv2TbltDevicePkg:Fixed system can't save time when RTC power failure.

Reviewed-by: David Wei Thanks, David Wei Intel SSG BIOS Team -Original Message- From: Lu, ShifeiX A Sent: Thursday, July 07, 2016 5:49 PM To: edk2-devel@lists.01.org Cc: Wei; Wei, David Subject: [Patch]

Re: [edk2] [PATCH 14/16] OvmfPkg: Series of patches to fix typos - accessibla to accessible - exeuction to execution - iff to if

Thanks Laszlo for your comments. Will send updated patch addressing your comments. Thanks, -Giri > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Thursday, July 7, 2016 2:00 AM > To: Mudusuru, Giri P > Cc: edk2-de...@ml01.01.org;

Re: [edk2] [PATCH 11/16] MdeModulePkg: Series of patches to fix typos

Reviewed-by: Star Zeng -Original Message- From: Mudusuru, Giri P Sent: Thursday, July 7, 2016 3:48 PM To: edk2-devel@lists.01.org Cc: Zeng, Star ; Tian, Feng Subject: [edk2] [PATCH 11/16] MdeModulePkg: Series of patches to

[edk2] [PATCH] MdePkg Base.h: Fix typo funcation to function

Cc: Liming Gao Cc: Michael D Kinney Cc: Jiewen Yao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Star Zeng --- MdePkg/Include/Base.h | 10 +- 1 file changed, 5

Re: [edk2] [PATCH 11/16] MdeModulePkg: Series of patches to fix typos

Reviewed-by: Feng Tian Thanks Feng -Original Message- From: Mudusuru, Giri P Sent: Thursday, July 7, 2016 3:48 PM To: edk2-devel@lists.01.org Cc: Zeng, Star ; Tian, Feng Subject: [edk2] [PATCH 11/16] MdeModulePkg: Series

[edk2] [Patch] BaseTools: Fix report generation failure on case sensitive file system

Since in GenFds phase, the generate FV all use upper letter. In the build report, we should use the upper letter FV name to combine the file path. Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Yonghong Zhu ---

Re: [edk2] [PATCH V2 0/7] Introduce three new toolchains in edk2

Hi Ard, I've put v2 in the subject and change the branch name to https://github.com/shijunjing/edk2/commits/llvm_v2 . You can review all my serial patches in the branch link, and let me know if you need me send the patches in the mail list again. Steven Shi Intel\SSG\STO\UEFI Firmware Tel:

Re: [edk2] [PATCH] MdeModulePkg MemoryProfile.h:two bytes of Reserved[4] as ActionStringOffset

Reviewed-by: jiewen@intel.com > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Star Zeng > Sent: Friday, July 8, 2016 10:41 AM > To: edk2-devel@lists.01.org > Cc: Yao, Jiewen ; Zeng, Star >

  1   2   >