Re: [edk2] [PATCH v4 6/6] OvmfPkg/QemuVideoDxe: Bypass NULL pointer detection during VBE SHIM installing

On 10/10/17 03:50, Wang, Jian J wrote: > I have summary in each patch email. Sure, you have a commit message, but you didn't point out any v3->v4 changes. (If there are no v3->v4 changes, then please pick up the R-b's received for v3.) > I removed the CC of some patches because > there's no

Re: [edk2] [PATCH] SecurityPkg/SecureBootConfigImpl.c: Fix the potential NULL dereference.

On 10/10/17 04:46, Wu, Hao A wrote: > Some comments below. Given that a new version of this patch looks necessary, I'd like to request an improved subject line / commit message: (1) For the subject prefix, we should use: SecurityPkg/SecureBootConfigDxe: ... (2) It looks like the issue (=

[edk2] [Patch] SourceLevelDebugPkg: Update SmmDebugAgentLib to restore APIC timer

In enter SMI, APIC timer may be initialized. After exit SMI, APIC timer will be restore. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Liming Gao Cc: Ruiyu Ni --- .../DebugAgent/SmmDebugAgent/SmmDebugAgentLib.c | 21

Re: [edk2] [PATCH v2 1/2] SecurityPkg: make PcdOptionRomImageVerificationPolicy dynamic

Jiewen, Qin, can you guys perhaps help with reviewing this patch? (The second patch in the series is for OvmfPkg, and it depends on this one.) Thanks! Laszlo On 10/05/17 22:16, Brijesh Singh wrote: > By default the image verification policy for option ROM images is 0x4 >

Re: [edk2] [PATCH v4 6/6] OvmfPkg/QemuVideoDxe: Bypass NULL pointer detection during VBE SHIM installing

Got it. Thank you very much for the advice and information. > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Tuesday, October 10, 2017 4:13 PM > To: Wang, Jian J ; edk2-devel@lists.01.org > Cc: Kinney, Michael D

Re: [edk2] [PATCH] MdeModulePkg/PciHostBridgeDxe: Fixed PCI DMA Map/Umap bounce buffer

On 10 October 2017 at 04:41, Daniil Egranov wrote: > Hi Ard, Ray, > > Thanks for your comments. > > > On 10/09/2017 07:23 AM, Ard Biesheuvel wrote: >> >> On 9 October 2017 at 11:40, Ard Biesheuvel >> wrote: >>> >>> On 9 October 2017 at 08:42,

Re: [edk2] [PATCH] MdeModulePkg/Bds: Remove assertion in BmCharToUint

On 10 October 2017 at 09:39, Ruiyu Ni wrote: > BmCharToUint() could be called using external data and it > already contains logic to return -1 when data is invalid, > so removing unnecessary assertion to avoid system hang. > > Contributed-under: TianoCore Contribution

[edk2] [PATCH] MdeModulePkg/Bds: Check variable name even OptionNumber is NULL

Current implementation skips to check whether the last four characters are digits when the OptionNumber is NULL. Even worse, it may incorrectly return FALSE when OptionNumber is NULL. The patch fixes it to always check the variable name even OptionNumber is NULL. Contributed-under: TianoCore

Re: [edk2] [PATCH 0/6] MdeModulePkg/VariableSmm: fix MOR / MorLock inconsistency

On 10/10/17 06:17, Yao, Jiewen wrote: > Thanks. > Please use ASSERT() when you check in. > > Series Reviewed-by: jiewen@intel.com Thank you all for the (quick!) feedback; I've pushed the series: 35ac962b5473..fda8f631edbb. Here's the cumulative diff between the

Re: [edk2] [PATCH] MdeModulePkg/UefiBootManagerLib: don't ASSERT on 'BootNext' varname

All, I just sent out two patches. One to remove the assertion, the other to fix a bug in EfiBootManagerIsValidLoadOptionVariableName. Thanks/Ray > -Original Message- > From: Yao, Jiewen > Sent: Thursday, October 5, 2017 5:08 PM > To: Laszlo Ersek > Cc: Zeng, Star

Re: [edk2] [Patch 08/11] SecurityPkg: Update Guid usage in INF file to match source code logic

Reviewed-by: Chao Zhang -Original Message- From: Gao, Liming Sent: Monday, September 25, 2017 7:06 PM To: edk2-devel@lists.01.org Cc: Zhang, Chao B Subject: [Patch 08/11] SecurityPkg: Update Guid usage in INF file to match source code

[edk2] [PATCH] MdeModulePkg/Bds: Remove assertion in BmCharToUint

BmCharToUint() could be called using external data and it already contains logic to return -1 when data is invalid, so removing unnecessary assertion to avoid system hang. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ruiyu Ni Cc: Ard Biesheuvel

[edk2] [PATCH] MdeModulePkg/Variable/RuntimeDxe: delete & lock MOR in the absence of SMM

VariableRuntimeDxe deletes and locks the MorLock variable in MorLockInit(), with the argument that any protection provided by MorLock can be circumvented if MorLock can be overwritten by unprivileged code (i.e., outside of SMM). Extend the argument and the logic to the MOR variable, which is

Re: [edk2] [PATCH v2] TFTP : tftp fix for full volume case

Hi, Kindly apply this patch on edk2 if all reviews are done. Thanks & Regards, Meenakshi > -Original Message- > From: Ni, Ruiyu [mailto:ruiyu...@intel.com] > Sent: Tuesday, October 10, 2017 10:52 AM > To: Carsey, Jaben ; Meenakshi Aggarwal >

Re: [edk2] [PATCH 6/6] MdeModulePkg/Variable/RuntimeDxe: delete and lock OS-created MOR variable

I agree with this direction a) if we think MOR with non-SMM is useless. Thanks, Star From: Yao, Jiewen Sent: Tuesday, October 10, 2017 12:15 PM To: Laszlo Ersek ; Zeng, Star ; edk2-devel-01 Cc: Dong, Eric

Re: [edk2] [PATCH v2 1/2] SecurityPkg: make PcdOptionRomImageVerificationPolicy dynamic

I am OK on this patch. Reviewed-by: jiewen@intel.com BTW: Do you also need update PcdRemovableMediaImageVerificationPolicy and PcdFixedMediaImageVerificationPolicy? Thank you Yao Jiewen From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Tuesday, October 10,

Re: [edk2] [PATCH] MdeModulePkg/Variable/RuntimeDxe: delete & lock MOR in the absence of SMM

Could you help make the code consistent to call VariableServiceSetVariable() for the Attributes? One original for MorLock is using real attributes, the new you added for Mor will use 0 attributes. How about to both use 0 attributes. Another question, why empty MorLockInitAtEndOfDxe() needs to

[edk2] [PATCH v4] Ifconfig : Fixed False information about Media State.

Issue : We were setting MediaPresent as TRUE (default) and not checking return status of NetLibDetectMedia(). NetLibDetectMedia() sets MediaPresent FLAG in case of success only and dont change flag on error. So, Media State will display as 'Media Present', in case of error also. Fix : Check

Re: [edk2] [platforms: PATCH 01/13] Marvell/Armada: Introduce platform initialization driver

On Mon, Oct 09, 2017 at 07:00:50PM +0200, Marcin Wojtas wrote: > In order to enable modification of dynamic PCD's for the libraries > and DXE drivers, this patch introduces new driver. It is > executed prior to other drivers. Mpp, ComPhy and Utmi libraries > initialization were moved from PrePi

Re: [edk2] [platforms: PATCH 05/13] Marvell/Armada: Use 4k/64k aligned sections for DXE/DXE-rt modules

On Mon, Oct 09, 2017 at 07:00:54PM +0200, Marcin Wojtas wrote: > From: Ard Biesheuvel > > Enable strict memory protection at boot time and under the OS, by using > 4 KB section alignment for DXE_DRIVER, UEFI_DRIVER and UEFI_APPLICATION > modules, and 64 KB alignment

Re: [edk2] [platforms: PATCH 04/13] Marvell/Armada: Armada70x0Lib: Clean FV in the D-cache before boot

On Mon, Oct 09, 2017 at 07:00:53PM +0200, Marcin Wojtas wrote: > From: Ard Biesheuvel > > To prevent cache coherency issues when chainloading via U-Boot, clean > and invalidate the FV image in the caches before re-enabling the MMU. Is this only relevant for

Re: [edk2] [PATCH] MdeModulePkg/Bds: Remove assertion in BmCharToUint

Reviewed-by: Star Zeng -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ruiyu Ni Sent: Tuesday, October 10, 2017 4:40 PM To: edk2-devel@lists.01.org Cc: Laszlo Ersek ; Ard Biesheuvel

Re: [edk2] [PATCH 0/6] MdeModulePkg/VariableSmm: fix MOR / MorLock inconsistency

Good to see the series pushed. Thanks, Star -Original Message- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Tuesday, October 10, 2017 6:09 PM To: Yao, Jiewen ; Zeng, Star Cc: edk2-devel-01 ; Dong, Eric

Re: [edk2] [platforms: PATCH 03/13] Marvell/Armada: Armada70x0Lib: Terminate call stack list at entry

On Mon, Oct 09, 2017 at 07:00:52PM +0200, Marcin Wojtas wrote: > From: Ard Biesheuvel > > To avoid dereferencing junk when walking the call stack in exception > handlers (which may prevent us from getting a full backtrace), set > the frame pointer to 0x0 when first

Re: [edk2] [platforms: PATCH 02/13] Marvell/Armada: Switch to dynamic PCDs

On Mon, Oct 09, 2017 at 07:00:51PM +0200, Marcin Wojtas wrote: > From: Ard Biesheuvel > > For full functionality, including HII forms wired to non-volatile UEFI > variables, we need dynamic PCDs as well. So let's enable those. > > Contributed-under: TianoCore

Re: [edk2] [platforms: PATCH 06/13] Marvell/Armada: Switch to generic BDS

On Mon, Oct 09, 2017 at 07:00:55PM +0200, Marcin Wojtas wrote: > From: Ard Biesheuvel > > Switch from the Intel BDS to the generic BDS, which is preferred for > ARM platforms given that it is completely legacy free. > > Contributed-under: TianoCore Contribution

Re: [edk2] [PATCH] MdeModulePkg/Bds: Check variable name even OptionNumber is NULL

On 10/10/17 10:58, Ruiyu Ni wrote: > Current implementation skips to check whether the last four > characters are digits when the OptionNumber is NULL. > Even worse, it may incorrectly return FALSE when OptionNumber is > NULL. > > The patch fixes it to always check the variable name even >

Re: [edk2] [PATCH] MdeModulePkg/Variable/RuntimeDxe: delete & lock MOR in the absence of SMM

On 10/10/17 15:54, Zeng, Star wrote: > Could you help make the code consistent to call > VariableServiceSetVariable() for the Attributes? One original for > MorLock is using real attributes, the new you added for Mor will use 0 > attributes. How about to both use 0 attributes. Sure, I can do that

Re: [edk2] [PATCH v2 1/2] SecurityPkg: make PcdOptionRomImageVerificationPolicy dynamic

The patch looks good to me. Reviewed-by: Long Qin Best Regards & Thanks, LONG, Qin From: Yao, Jiewen Sent: Tuesday, October 10, 2017 9:47 PM To: Laszlo Ersek ; Long, Qin Cc: Brijesh Singh ;

Re: [edk2] [PATCH v2 1/2] SecurityPkg: make PcdOptionRomImageVerificationPolicy dynamic

On 10/10/17 15:46, Yao, Jiewen wrote: > I am OK on this patch. > > Reviewed-by: jiewen@intel.com Thanks! (Thanks to Qin as well!) > BTW: Do you also need update PcdRemovableMediaImageVerificationPolicy and > PcdFixedMediaImageVerificationPolicy? No, not at

Re: [edk2] [PATCH] MdeModulePkg/Bds: Remove assertion in BmCharToUint

On 10/10/17 10:39, Ruiyu Ni wrote: > BmCharToUint() could be called using external data and it > already contains logic to return -1 when data is invalid, > so removing unnecessary assertion to avoid system hang. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ruiyu

Re: [edk2] [platforms: PATCH 10/13] Marvell/Armada: Switch to unicore PrePi

On Mon, Oct 09, 2017 at 07:00:59PM +0200, Marcin Wojtas wrote: > From: Ard Biesheuvel > > There is no point in using the MPCore PrePi, given that only the primary > core will enter UEFI at EL2, and the secondaries will be held in EL3 > until summoned by the OS. So use

Re: [edk2] [platforms: PATCH 11/13] Marvell/Armada: Remove outdated SEC alignment override

On Mon, Oct 09, 2017 at 07:01:00PM +0200, Marcin Wojtas wrote: > From: Ard Biesheuvel > > The FDFs no longer require explicit alignment for sections containing > aligned objects, so change it to 'Auto' and FIXED (which allows some > padding to be removed), and remove

Re: [edk2] [platforms: PATCH 12/13] Marvell/Armada: Add the UefiPxeBcDxe driver

On Mon, Oct 09, 2017 at 07:01:01PM +0200, Marcin Wojtas wrote: > From: Ard Biesheuvel > > This driver allows automatic booting via the network. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ard Biesheuvel >

Re: [edk2] [platforms: PATCH 04/13] Marvell/Armada: Armada70x0Lib: Clean FV in the D-cache before boot

2017-10-10 16:43 GMT+02:00 Leif Lindholm : > On Mon, Oct 09, 2017 at 07:00:53PM +0200, Marcin Wojtas wrote: >> From: Ard Biesheuvel >> >> To prevent cache coherency issues when chainloading via U-Boot, clean >> and invalidate the FV image in

Re: [edk2] [platforms: PATCH 08/13] Marvell/Armada: Modify GICC alias

Hi Ard, 2017-10-10 16:53 GMT+02:00 Leif Lindholm : > On Mon, Oct 09, 2017 at 07:00:57PM +0200, Marcin Wojtas wrote: >> From: Ard Biesheuvel >> >> The GIC architecture mandates that the CPU interface, which consists >> of 2 consecutive 4 KB

Re: [edk2] [platforms: PATCH 01/13] Marvell/Armada: Introduce platform initialization driver

On Tue, Oct 10, 2017 at 04:45:10PM +0200, Marcin Wojtas wrote: > Hi Leif, > > 2017-10-10 16:37 GMT+02:00 Leif Lindholm : > > On Mon, Oct 09, 2017 at 07:00:50PM +0200, Marcin Wojtas wrote: > >> In order to enable modification of dynamic PCD's for the libraries > >> and

Re: [edk2] [platforms: PATCH 01/13] Marvell/Armada: Introduce platform initialization driver

Hi Leif, 2017-10-10 16:37 GMT+02:00 Leif Lindholm : > On Mon, Oct 09, 2017 at 07:00:50PM +0200, Marcin Wojtas wrote: >> In order to enable modification of dynamic PCD's for the libraries >> and DXE drivers, this patch introduces new driver. It is >> executed prior to

Re: [edk2] [PATCH 0/2] Add FPDT Acpi table

Hi Leif. Firstly - sorry I thought we had this sorted. > -Original Message- > From: Leif Lindholm [mailto:leif.lindh...@linaro.org] > Sent: 09 October 2017 12:22 > To: Evan Lloyd > Cc: edk2-devel@lists.01.org > Subject: Re: [PATCH 0/2] Add FPDT Acpi table > > On Fri,

Re: [edk2] [platforms: PATCH 07/13] Marvell/Armada: Re-enable driver model diagnostics PCDs

On Mon, Oct 09, 2017 at 07:00:56PM +0200, Marcin Wojtas wrote: > From: Ard Biesheuvel > > For some reason, one of the early ARM platforms disabled all the > diagnostics related to the UEFI driver model, resulting in the > output of UEFI shell utilities such as

Re: [edk2] [platforms: PATCH 09/13] Marvell/Armada: Disable PerformanceLibrary

On Mon, Oct 09, 2017 at 07:00:58PM +0200, Marcin Wojtas wrote: > From: Ard Biesheuvel > > Remove the gEfiMdePkgTokenSpaceGuid.PcdPerformanceLibraryPropertyMask > setting so it reverts to its default of 0, and disables performance > profiling. > > Contributed-under:

Re: [edk2] [platforms: PATCH 08/13] Marvell/Armada: Modify GICC alias

On Mon, Oct 09, 2017 at 07:00:57PM +0200, Marcin Wojtas wrote: > From: Ard Biesheuvel > > The GIC architecture mandates that the CPU interface, which consists > of 2 consecutive 4 KB frames, can be mapped using separate mappings. > Since this is problematic on 64 KB

Re: [edk2] [platforms: PATCH 01/13] Marvell/Armada: Introduce platform initialization driver

On Tue, Oct 10, 2017 at 05:06:42PM +0200, Marcin Wojtas wrote: > 2017-10-10 17:03 GMT+02:00 Leif Lindholm : > > On Tue, Oct 10, 2017 at 04:45:10PM +0200, Marcin Wojtas wrote: > >> Hi Leif, > >> > >> 2017-10-10 16:37 GMT+02:00 Leif Lindholm : > >>

Re: [edk2] [platforms: PATCH 04/13] Marvell/Armada: Armada70x0Lib: Clean FV in the D-cache before boot

On Tue, Oct 10, 2017 at 04:50:04PM +0200, Marcin Wojtas wrote: > 2017-10-10 16:43 GMT+02:00 Leif Lindholm : > > On Mon, Oct 09, 2017 at 07:00:53PM +0200, Marcin Wojtas wrote: > >> From: Ard Biesheuvel > >> > >> To prevent cache coherency issues

Re: [edk2] [PATCH 0/2] Add FPDT Acpi table

Thanks. Pushed as a63be426f8 (edk2) and 5d6506e4e9 (edk2-platforms). (I also deleted a stray "Change-id" tag from each commit message.) Regards, Leif On Tue, Oct 10, 2017 at 04:11:15PM +, Evan Lloyd wrote: > Hi Leif. > Firstly - sorry I thought we had this sorted. > > > -Original

Re: [edk2] [platforms: PATCH 13/13] Marvell/Documentation: Follow EDK2 coding style in the PortingGuide

On Mon, Oct 09, 2017 at 07:01:02PM +0200, Marcin Wojtas wrote: > This patch removes tabs and wrong line endings in the file, maiking > it acceptable to the PatchCheck.py script. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Marcin Wojtas Much

Re: [edk2] [platforms: PATCH 11/13] Marvell/Armada: Remove outdated SEC alignment override

2017-10-10 16:58 GMT+02:00 Leif Lindholm : > On Mon, Oct 09, 2017 at 07:01:00PM +0200, Marcin Wojtas wrote: >> From: Ard Biesheuvel >> >> The FDFs no longer require explicit alignment for sections containing >> aligned objects, so change it to

Re: [edk2] [platforms: PATCH 01/13] Marvell/Armada: Introduce platform initialization driver

2017-10-10 17:03 GMT+02:00 Leif Lindholm : > On Tue, Oct 10, 2017 at 04:45:10PM +0200, Marcin Wojtas wrote: >> Hi Leif, >> >> 2017-10-10 16:37 GMT+02:00 Leif Lindholm : >> > On Mon, Oct 09, 2017 at 07:00:50PM +0200, Marcin Wojtas wrote: >> >> In

Re: [edk2] [platforms: PATCH 04/13] Marvell/Armada: Armada70x0Lib: Clean FV in the D-cache before boot

On 10 October 2017 at 16:29, Leif Lindholm wrote: > On Tue, Oct 10, 2017 at 04:50:04PM +0200, Marcin Wojtas wrote: >> 2017-10-10 16:43 GMT+02:00 Leif Lindholm : >> > On Mon, Oct 09, 2017 at 07:00:53PM +0200, Marcin Wojtas wrote: >> >> From: Ard

Re: [edk2] [platforms: PATCH 08/13] Marvell/Armada: Modify GICC alias

On 10 October 2017 at 15:56, Marcin Wojtas wrote: > Hi Ard, > > 2017-10-10 16:53 GMT+02:00 Leif Lindholm : >> On Mon, Oct 09, 2017 at 07:00:57PM +0200, Marcin Wojtas wrote: >>> From: Ard Biesheuvel >>> >>> The GIC

Re: [edk2] [PATCH 0/2] Dynamic Tables

On 10/10/17 20:52, Evan Lloyd wrote: > Hi Jiewen > (I hope that is your personal name, not your surname - but it is a bit hard > for us barbarians to tell, sorry.) Meta: I've been shamelessly exploiting the (apparent) custom that @intel.com email addresses come in the following shapes:

Re: [edk2] [PATCH 0/2] Dynamic Tables

Hi Jiewen (I hope that is your personal name, not your surname - but it is a bit hard for us barbarians to tell, sorry.) Thank you for the very helpful feedback. Responses are inline below. > -Original Message- > From: Yao, Jiewen [mailto:jiewen@intel.com] > Sent: 10 October 2017

Re: [edk2] [platforms: PATCH 01/13] Marvell/Armada: Introduce platform initialization driver

On 10 October 2017 at 16:26, Leif Lindholm wrote: > On Tue, Oct 10, 2017 at 05:06:42PM +0200, Marcin Wojtas wrote: >> 2017-10-10 17:03 GMT+02:00 Leif Lindholm : >> > On Tue, Oct 10, 2017 at 04:45:10PM +0200, Marcin Wojtas wrote: >> >> Hi Leif,

Re: [edk2] [platforms: PATCH 08/13] Marvell/Armada: Modify GICC alias

On Tue, Oct 10, 2017 at 09:45:29PM +0100, Ard Biesheuvel wrote: > On 10 October 2017 at 15:56, Marcin Wojtas wrote: > > Hi Ard, > > > > 2017-10-10 16:53 GMT+02:00 Leif Lindholm : > >> On Mon, Oct 09, 2017 at 07:00:57PM +0200, Marcin Wojtas wrote: > >>>

Re: [edk2] [Patch 07/11] SignedCapsulePkg: Update Guid usage in INF file to match source code logic

Reviewed-by: jiewen@intel.com > -Original Message- > From: Gao, Liming > Sent: Monday, September 25, 2017 7:06 PM > To: edk2-devel@lists.01.org > Cc: Yao, Jiewen > Subject: [Patch 07/11] SignedCapsulePkg: Update Guid usage in INF file to > match > source code

Re: [edk2] [Patch 09/11] IntelFsp2Pkg: Update Section Name in INF files

Reviewed-by: jiewen@intel.com > -Original Message- > From: Gao, Liming > Sent: Monday, September 25, 2017 7:06 PM > To: edk2-devel@lists.01.org > Cc: Yao, Jiewen > Subject: [Patch 09/11] IntelFsp2Pkg: Update Section Name in INF files > > Contributed-under:

Re: [edk2] [Patch 10/11] IntelFsp2WrapperPkg: Update Protocol/Guid usage in INF files

Reviewed-by: jiewen@intel.com > -Original Message- > From: Gao, Liming > Sent: Monday, September 25, 2017 7:06 PM > To: edk2-devel@lists.01.org > Cc: Yao, Jiewen > Subject: [Patch 10/11] IntelFsp2WrapperPkg: Update Protocol/Guid usage in INF > files > >

Re: [edk2] Request to display Initiator IP in ISCSI Attempt Page

Hi Karunakar, Unlike IPv4, IPv6 address used for iSCSI session can always be retrieved manually. Since we expect the user configure the IPv6 address manually, I don't prefer adding the Initiator IP In IP6 attempt Page because the user should have known it as setting in step1. Thanks, Jiaxin

Re: [edk2] [Patch 06/11] NetworkPkg: Update Protocol/Guid usage in INF file to match source code logic

Reviewed-by: Wu Jiaxin > -Original Message- > From: Gao, Liming > Sent: Monday, September 25, 2017 7:06 PM > To: edk2-devel@lists.01.org > Cc: Fu, Siyuan ; Wu, Jiaxin > Subject: [Patch 06/11] NetworkPkg: Update

[edk2] [Patch 2/3] UefiCpuPkg/S3Resume2Pei: Send S3 resume finished event to SmmCore.

Driver will send S3 resume finished event to SmmCore through communicate buffer after it signals EndOfPei event. Cc: Ruiyu Ni Cc: Jiewen Yao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Eric Dong ---

[edk2] [Patch 3/3] MdeModulePkg/PiSmmCore: Install Protocol when S3 resume finished.

Install EdkiiSmmEndOfS3ResumeProtocol when S3 resume finished. S3ResumePei will send S3 resume finished event to SmmCore through communication buffer. Cc: Ruiyu Ni Cc: Jiewen Yao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by:

[edk2] [Patch 0/3] Add SmmEndOfS3Resume event.

This patch series add new SmmEndOfS3Resume event which required by some SMM drivers. It will implmented by SmmCore to install the gEdkiiSmmEndOfS3ResumeProtocolGuid Protocol. Smm drivers can install this protocol's notification functions to hoot this envet. It will be trigged right after the

[edk2] [Patch 1/3] MdeModulePkg/SmmEndOfS3Resume.h: Add new protocol definition.

Add gEdkiiSmmEndOfS3ResumeProtocolGuid which used by SmmCore to notify smm drives that S3 resume has finished. Cc: Ruiyu Ni Cc: Jiewen Yao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Eric Dong ---

Re: [edk2] [PATCH 0/2] Dynamic Tables

Thank you! Comment in line. From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Evan Lloyd Sent: Wednesday, October 11, 2017 2:52 AM To: Yao, Jiewen ; edk2-devel@lists.01.org Cc: "matteo.carl...@arm.com"@arm.com; "n...@arm.com"@arm.com;

Re: [edk2] [PATCH] SecurityPkg\Tcg2Pei: FV measure performance enhancement

Reviewed-by: Long Qin Best Regards & Thanks, LONG, Qin -Original Message- From: Zhang, Chao B Sent: Monday, October 9, 2017 4:50 PM To: edk2-devel@lists.01.org Cc: Long, Qin ; Yao, Jiewen ; sean.bro...@microsoft.com;

Re: [edk2] [platforms: PATCH 01/13] Marvell/Armada: Introduce platform initialization driver

2017-10-10 22:36 GMT+02:00 Ard Biesheuvel : > On 10 October 2017 at 16:26, Leif Lindholm wrote: >> On Tue, Oct 10, 2017 at 05:06:42PM +0200, Marcin Wojtas wrote: >>> 2017-10-10 17:03 GMT+02:00 Leif Lindholm : >>> > On

[edk2] [Patch v2 0/3] Add SmmEndOfS3Resume event.

This patch series add new SmmEndOfS3Resume event which required by some SMM drivers. It will implmented by SmmCore to install the gEdkiiSmmEndOfS3ResumeProtocolGuid Protocol. Smm drivers can install this protocol's notification functions to hoot this envet. It will be trigged right after the

[edk2] [Patch v2 2/3] UefiCpuPkg/S3Resume2Pei: Send S3 resume finished event to SmmCore.

Driver will send S3 resume finished event to SmmCore through communicate buffer after it signals EndOfPei event. V2 Changes: 1. Change structures name to avoid they start with EFI_. 2. Base on DXE phase bits to provide communication buffer, current implement check both PEI and DXE phase. Cc:

[edk2] [Patch v2 3/3] MdeModulePkg/PiSmmCore: Install Protocol when S3 resume finished.

Install EdkiiSmmEndOfS3ResumeProtocol when S3 resume finished. S3ResumePei will send S3 resume finished event to SmmCore through communication buffer. Cc: Ruiyu Ni Cc: Jiewen Yao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by:

[edk2] [PATCH 2/5] MdeModulePkg/PiSmmCore: Implement heap guard feature for SMM mode

This feature makes use of paging mechanism to add a hidden (not present) page just before and after the allocated memory block. If the code tries to access memory outside of the allocated part, page fault exception will be triggered. This feature is controlled by three PCDs:

[edk2] [PATCH 3/5] MdeModulePkg/MdeModulePkg.dec, .uni: Add heap guard related PCDs and string tokens

Cc: Star Zeng Cc: Eric Dong Cc: Jiewen Yao Cc: Michael Kinney Cc: Ayellet Wolman Suggested-by: Ayellet Wolman Contributed-under: TianoCore

[edk2] [PATCH 1/5] MdeModulePkg/DxeCore: Implement heap guard feature for UEFI

This feature makes use of paging mechanism to add a hidden (not present) page just before and after the allocated memory block. If the code tries to access memory outside of the allocated part, page fault exception will be triggered. This feature is controlled by three PCDs:

[edk2] [PATCH 0/5] Implement heap guard feature

This feature makes use of paging mechanism to add a hidden (not present) page just before and after the allocated memory block. If the code tries to access memory outside of the allocated part, page fault exception will be triggered. This feature is disabled by default and is not recommended to

[edk2] [PATCH 5/5] UefiCpuPkg/PiSmmCpuDxeSmm: Disable page table protection

Heap guard feature will update page attributes frequently. The page table should not set to be read-only if heap guard feature is enabled for SMM mode. Otherwise this feature cannot work. Cc: Eric Dong Cc: Jiewen Yao Cc: Michael Kinney

[edk2] [PATCH 4/5] UefiCpuPkg/CpuDxe: Reduce debug message

Heap guard feature will frequently update page attributes. The debug message in CpuDxe driver will slow down the boot performance noticeably. Changing the debug level to DEBUG_POOL and DEBUG_PAGE to reduce the message output for normal debug configuration. Cc: Eric Dong Cc:

Re: [edk2] [Patch 1/3] BaseTools: GenFfs support to get alignment value from SectionFile

PeFileBuffer should free in the end of the function. >-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of >Yonghong Zhu >Sent: Friday, September 29, 2017 9:23 AM >To: edk2-devel@lists.01.org >Cc: Gao, Liming >Subject: [edk2]

Re: [edk2] [PATCH v4 0/6] Add NULL pointer detection feature

Hi, Any more comments for this version of patch? If no, I'll check in it today. Thanks. Jian > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jian J > Wang > Sent: Monday, October 09, 2017 10:17 PM > To: edk2-devel@lists.01.org > Subject:

Re: [edk2] [PATCH v4] Ifconfig : Fixed False information about Media State.

Reviewed-by: Wu Jiaxin > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Meenakshi Aggarwal > Sent: Tuesday, October 10, 2017 10:08 PM > To: edk2-devel@lists.01.org; Wu, Jiaxin ; Carsey, > Jaben

[edk2] [Patch v2 1/3] MdeModulePkg/SmmEndOfS3Resume.h: Add new protocol definition.

Add gEdkiiSmmEndOfS3ResumeProtocolGuid which used by SmmCore to notify smm drives that S3 resume has finished. Cc: Ruiyu Ni Cc: Jiewen Yao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Eric Dong ---

[edk2] Plan to remove ifconfig6/ping6 in NetworkPkg

Hi, All Edk2 has duplicated ping6/ifconfig6 implementation in NetworkPkg and ShellPkg, we have plan to remove (delete) those applications in NetworkPkg. Please let me know if you have any concern about this. File to remove: NetworkPkg\Application\IfConfig6\*

Re: [edk2] [Patch 2/3] UefiCpuPkg/S3Resume2Pei: Send S3 resume finished event to SmmCore.

Eric, We may have 4 combinations for PEI DXE CPU architecture: 1. 32bit PEI + 32bit DXE: sizeof (UINTN) == sizeof (UINT32) && NOT PcdDxeIplSwitchToLongMode 2. 32bit PEI + 64bit DXE: sizeof (UINTN) == sizeof (UINT32) && PcdDxeIplSwitchToLongMode 3. 64bit PEI + 32bit DXE: NA!!! 4. 64bit PEI +

Re: [edk2] [Patch 2/3] UefiCpuPkg/S3Resume2Pei: Send S3 resume finished event to SmmCore.

Hi Ray, I think we can just base on DXE phase bits to prepare the communication buffer. I send new patches base on it. please check them. Thanks, Eric -Original Message- From: Ni, Ruiyu Sent: Wednesday, October 11, 2017 11:25 AM To: Dong, Eric ;

Re: [edk2] [Patch] BaseTools: Fix the bug 'DSC DEFAULT' in report wrongly use FDF value

Reviewed-by: Liming Gao >-Original Message- >From: Zhu, Yonghong >Sent: Monday, October 09, 2017 9:37 PM >To: edk2-devel@lists.01.org >Cc: Gao, Liming >Subject: [Patch] BaseTools: Fix the bug 'DSC DEFAULT' in report wrongly use >FDF value >

Re: [edk2] [Patch] BaseTools: Fix the Keyword error for in FDF File

Reviewed-by: Liming Gao >-Original Message- >From: Zhu, Yonghong >Sent: Monday, October 09, 2017 9:37 PM >To: edk2-devel@lists.01.org >Cc: Gao, Liming >Subject: [Patch] BaseTools: Fix the Keyword error for in >FDF File > >current in FDF spec