Hi Chasel
Good idea to reserve bootloader IDT.
I have a little concern on the code below. It unconditionally limits the boot
loader IDT to our IdtTableInStack.
#define SEC_IDT_ENTRY_COUNT34
typedef struct _SEC_IDT_TABLE {
EFI_PEI_SERVICES *PeiService;
UINT64
> -Original Message-
> From: Zeng, Star
> Sent: Tuesday, October 23, 2018 1:46 PM
> To: Paulo Alcantara; Wu, Hao A; edk2-devel@lists.01.org
> Cc: Ni, Ruiyu; Yao, Jiewen; Zeng, Star
> Subject: Re: [edk2] [PATCH v1 00/10] UDF: Bugfixes
>
> On 2018/10/22 22:39, Paulo Alcantara wrote:
> > Hao
On 10/23/18 11:36, Ni, Ruiyu wrote:
> On 10/23/2018 11:12 AM, Lohr, Paul A wrote:
>> Hello,
>>
>> Code to remove SMRAM = UC (line 650-ish) looks good. I would suggest
>> adding some debug comments in the area it was removed. Thanks.
>
> debug message or comments?
> I guess you'd like to have
Hi, Laszlo
On 2018-10-23 18:18, Laszlo Ersek wrote:
(1) Adding Gerd (because he maintains video in QEMU), and Phil
Dennis-Jordan (for authoring commit c137d9508169,
"OvmfPkg/QemuVideoDxe:
VMWare SVGA device support", 2017-04-07).
On 10/23/18 04:40, yuchen...@synology.com wrote:
From:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1265
FSP should not override IDT table when it is initialized
by boot loader. IDT should be re-initialized in FSP only
when it is invalid.
To mitigate temporary memory usage a PCD
PcdFspMaxInterruptSupported created for platform to decide
how
On 10/23/18 13:12, yuchenlin wrote:
> Hi, Laszlo
>
> On 2018-10-23 18:18, Laszlo Ersek wrote:
>> (1) Adding Gerd (because he maintains video in QEMU), and Phil
>> Dennis-Jordan (for authoring commit c137d9508169,
>> "OvmfPkg/QemuVideoDxe: VMWare SVGA device support", 2017-04-07).
>>
>>
>> On
On 10/18/2018 2:41 PM, Hao Wu wrote:
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1142
According to the the NVM Express spec Revision 1.1, for some commands
(like Get/Set Feature Command, Figure 89 & 90 of the spec), the Memory
Buffer maybe optional although the command opcode indicates
On 10/18/2018 2:41 PM, Hao Wu wrote:
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1259
According to the the NVM Express spec Revision 1.1, for some commands,
command-related information will be stored in the Dword 0 of the
completion queue entry.
One case is for the Get Features Command
On 10/18/2018 2:42 PM, Hao Wu wrote:
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1260
For the PassThru() service of NVM Express Pass Through Protocol, the
current implementation (function NvmExpressPassThru()) will only use the
IO Completion/Submission queues created internally by this
(1) Adding Gerd (because he maintains video in QEMU), and Phil
Dennis-Jordan (for authoring commit c137d9508169, "OvmfPkg/QemuVideoDxe:
VMWare SVGA device support", 2017-04-07).
On 10/23/18 04:40, yuchen...@synology.com wrote:
> From: yuchenlin
>
> When driver doesn't set fifo config, the
Paulo and Star,
Thanks a lot for the review.
Series pushed at 4df8f5bfa2.. 68099b52b0.
Best Regards,
Hao Wu
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Wu,
> Hao A
> Sent: Tuesday, October 23, 2018 2:10 PM
> To: Zeng, Star; Paulo
> On Oct 23, 2018, at 2:33 AM, Chasel, Chiu wrote:
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1265
>
> FSP should not override IDT table when it is initialized
> by boot loader. IDT should be re-initialized in FSP only
> when it is invalid.
> To mitigate temporary memory usage a
Reviewed-by: Yonghong Zhu
Best Regards,
Zhu Yonghong
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Yonghong
Zhu
Sent: Tuesday, October 16, 2018 4:25 PM
To: edk2-devel@lists.01.org
Cc: Chen, Hesheng
Subject: [edk2] [PATCH] BaseTools/Ecc:
Reviewed-by: Yonghong Zhu
Best Regards,
Zhu Yonghong
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Yonghong
Zhu
Sent: Tuesday, October 16, 2018 4:24 PM
To: edk2-devel@lists.01.org
Cc: Chen, Hesheng
Subject: [edk2] [PATCH] BaseTools/ECC: Fix
Reviewed-by: Yonghong Zhu
Best Regards,
Zhu Yonghong
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Yonghong
Zhu
Sent: Tuesday, October 16, 2018 4:29 PM
To: edk2-devel@lists.01.org
Cc: Chen, Hesheng
Subject: [edk2] [PATCH] BaseTools/UPT: Fix
Reviewed-by: Yonghong Zhu
Best Regards,
Zhu Yonghong
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Yonghong
Zhu
Sent: Thursday, October 18, 2018 9:20 AM
To: edk2-devel@lists.01.org
Cc: Chen, Hesheng
Subject: [edk2] [PATCH V2]
On 10/22/2018 10:30 PM, Laszlo Ersek wrote:
On 10/22/18 11:03, Ruiyu Ni wrote:
Today's PiSmmIpl implementation initially sets SMRAM to WB to speed
up the SMM core/modules loading before SMM CPU driver runs.
When SMM CPU driver runs, PiSmmIpl resets the SMRAM to UC. It's done
in
original we get the VPD PCD items from the VPDGuid.map file in the FV
output folder. but this logic doesn't work when 1) there only have
single non Default SKU, 2) there have multiple SKU with same value.
Now we change it to get the really VPD Pcd items that already display
in the PCD section of
On 10/23/2018 11:12 AM, Lohr, Paul A wrote:
Hello,
Code to remove SMRAM = UC (line 650-ish) looks good. I would suggest adding
some debug comments in the area it was removed. Thanks.
debug message or comments?
I guess you'd like to have some comments to say "SMRR is enabled by CPU
SMM
Hi Liming,
On 10/22/18 17:18, Liming Gao wrote:
> In V2, update commit message with fixed CVE number.
>
> Fix CVE-2017-5731,CVE-2017-5732,CVE-2017-5733,CVE-2017-5734,CVE-2017-5735
> https://bugzilla.tianocore.org/show_bug.cgi?id=686
>
> Liming Gao (3):
> MdePkg: Add more checker in
On 10/23/18 16:53, Jian J Wang wrote:
>> v2 changes:
>> a. Drop PCD PcdUseAfterFreeDetectionPropertyMask. Use BIT4 of
>>PcdHeapGuardPropertyMask instead. Update related descriptions in both
>>dec and uni files.
>
> Freed-memory guard is used to detect UAF (Use-After-Free) memory issue
>
Thank you. I will update title when push this change.
> -Original Message-
> From: Laszlo Ersek [mailto:ler...@redhat.com]
> Sent: Tuesday, October 23, 2018 6:32 PM
> To: Gao, Liming ; edk2-devel@lists.01.org
> Subject: Re: [edk2] [PATCH v2 0/3] Add more checker for Tianocompress and
>
On 10/23/18 15:42, Gerd Hoffmann wrote:
> Hi,
>
>> Please help me see the situation better. Here's my current
>> understanding.
>>
>> (1) QemuVideoDxe doesn't set up the VMW SVGA FIFO, and does not store 1
>> to the SVGA_REG_CONFIG_DONE register. And this is not a "small
>> missing
On 10/23/18 16:53, Jian J Wang wrote:
>> v2 changes:
>> a. Change the type of mPageTablePoolLock to be BOOLEAN. Related code
>>logic is also updated and refined.
>> b. Add non-stop mode for freed-memory guard feature
>
> The freed-memory guard feature will cause an infinite calling
> of
> v2 changes:
> a. Change prototype and implementation of IsHeapGuardEnabled()
>to allow it to check freed-memory guard feature.
> b. Drop IsUafEnabled() because of a.
> c. Move the sanity check of freed-memory guard and heap guard
>into HeapGuardCpuArchProtocolNotify()
> d. Add
> v2 changes:
> a. Update IsHeapGuardEnabled() calling because its prototype change
Two changes are fixed up:
a. Prototype change of function IsHeapGuardEnabled()
b. More memory map descriptors are introduced by new feature.
MergeMemoryMap() is updated to merge freed-pages into adjacent memory
> v2 changes:
> a. Update implementation of CoreGetMemorySpaceMap() and
>CoreGetIoSpaceMap() to avoid lock failure. Drop the code to
>detect debug print level used to achieve the same effect.
This issue is hidden in current code but exposed by introduction
of freed-memory guard feature
> v2 changes:
> a. Change the type of mPageTablePoolLock to be BOOLEAN. Related code
>logic is also updated and refined.
> b. Add non-stop mode for freed-memory guard feature
The freed-memory guard feature will cause an infinite calling
of InitializePageTablePool(). This is due to a fact that
> v2 changes:
> a. Drop PCD PcdUseAfterFreeDetectionPropertyMask. Use BIT4 of
>PcdHeapGuardPropertyMask instead. Update related descriptions in both
>dec and uni files.
Freed-memory guard is used to detect UAF (Use-After-Free) memory issue
which is illegal access to memory which has been
> v2 changes:
> a. Drop PCD PcdUseAfterFreeDetectionPropertyMask. Use BIT4 of
>PcdHeapGuardPropertyMask instead. Add more descriptions about
>the new usage in dec/uni file as well.
> b. Use global of BOOLEAN other than EFI_LOCK to avoid reentrance
>of calling InitializePageTablePool()
Hi,
> Please help me see the situation better. Here's my current
> understanding.
>
> (1) QemuVideoDxe doesn't set up the VMW SVGA FIFO, and does not store 1
> to the SVGA_REG_CONFIG_DONE register. And this is not a "small
> missing step" -- the FIFO setup can be considered a separate
On 10/23/18 16:53, Jian J Wang wrote:
>> v2 changes:
>> a. Update IsHeapGuardEnabled() calling because its prototype change
>
> Two changes are fixed up:
> a. Prototype change of function IsHeapGuardEnabled()
This kind of separation, between the patches, is wrong then. If someone
bisects the
On 10/23/18 16:53, Jian J Wang wrote:
>> v2 changes:
>> a. Change prototype and implementation of IsHeapGuardEnabled()
>>to allow it to check freed-memory guard feature.
>> b. Drop IsUafEnabled() because of a.
>> c. Move the sanity check of freed-memory guard and heap guard
>>into
Hi,
If the main purpose of the OpenProtocolInformation service is to provide
the complete list of agents currently using a specific protocol interface
then what is the need for providing the Handle argument too as an input?
Why does it matter what Handle was this queried protocol installed on?
The same protocol can be installed on many handles in
the handle database. For example, if there are multiple
mass storage devices in a platform, there will be
multiple Block I/O Protocols in the handle database.
Mike
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-
>
Hello,
Please see my reply below inline.
Thanks!
Chasel
-Original Message-
From: af...@apple.com [mailto:af...@apple.com]
Sent: Tuesday, October 23, 2018 6:29 PM
To: Chiu, Chasel
Cc: edk2-devel@lists.01.org; Yao, Jiewen
Subject: Re: [edk2] [PATCH v2] IntelFsp2Pkg: FSP should not
Laszlo,
Thank you very much for the comments. I went through all of them in other
patch emails and I think I have no objection. So to save all of us time I'm not
going to respond them separately. I'll send out v3 patch soon. Thanks again.
Regards,
Jian
> -Original Message-
> From:
> -Original Message-
> From: Ni, Ruiyu
> Sent: Tuesday, October 23, 2018 4:54 PM
> To: Wu, Hao A; edk2-devel@lists.01.org
> Cc: Yao, Jiewen; Zeng, Star
> Subject: Re: [PATCH v1 3/3] MdeModulePkg/NvmExpressDxe: Refine PassThru
> IO queue creation behavior
>
> On 10/18/2018 2:42 PM, Hao Wu
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1260
For the PassThru() service of NVM Express Pass Through Protocol, the
current implementation (function NvmExpressPassThru()) will only use the
IO Completion/Submission queues created internally by this driver during
the controller
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1259
According to the the NVM Express spec Revision 1.1, for some commands,
command-related information will be stored in the Dword 0 of the
completion queue entry.
One case is for the Get Features Command (Section 5.9.2 of the spec),
Dword 0 of
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1142
According to the the NVM Express spec Revision 1.1, for some commands
(like Get/Set Feature Command, Figure 89 & 90 of the spec), the Memory
Buffer maybe optional although the command opcode indicates there is a
data transfer between host &
V2 changes:
A. For patch 3/3, introduces a BOOLEAN flag in the controller private data
structure. The flag will indicate internal IO queues creation and it
will simplifies the check logic in the NvmExpressPassThru() function.
V1 history:
The series will address a couple of bugs within
On 2018-10-23 22:02, Laszlo Ersek wrote:
On 10/23/18 15:42, Gerd Hoffmann wrote:
Hi,
Please help me see the situation better. Here's my current
understanding.
(1) QemuVideoDxe doesn't set up the VMW SVGA FIFO, and does not store
1
to the SVGA_REG_CONFIG_DONE register. And this is not
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1272
To have high confidence in usage for platform, add option (BIT2 of
PcdVTdPolicyPropertyMask) to force no IOMMU access attribute request
recording before DMAR table is installed.
Check PcdVTdPolicyPropertyMask BIT2 before
On 10/12/2018 10:18 AM, Dandan Bi wrote:
https://bugzilla.tianocore.org/show_bug.cgi?id=1243
This pacth series is mainly to do the enahncement for
Sata/Usbxx/AcpiExp device path to handle the cases when some
optional paremeter is not specified in the text device path.
Cc: Ruiyu Ni
Cc: Michael
> v3 changes:
> a. Merge from #4 and #5 of v2 patch
> b. Coding style cleanup
Freed-memory guard is used to detect UAF (Use-After-Free) memory issue
which is illegal access to memory which has been freed. The principle
behind is similar to heap guard feature, that is we'll turn all pool
memory
> v3 changes:
> a. split from v2 #1 patch file.
> b. refine the commit message and title.
UAF (Use-After-Free) memory issue is kind of illegal access to memory
which has been freed. It can be detected by a new freed-memory guard
enforced onto freed memory.
BIT4 of following PCD is used to enable
> v3 changes:
> a. drop the changes to CoreGetIoSpaceMap() because it won't cause
>problem
> b. refine the logic in changes of CoreGetMemorySpaceMap()
>and add more comments
This issue is hidden in current code but exposed by introduction
of freed-memory guard feature due to the fact that
> v3 changes:
> Updated per comments from Laszlo. Please refer to individual patch
> file for details
Freed-memory guard is a new feauture used to detect UAF (Use-After-Free)
memory issue.
Tests:
a. Feature basic unit/functionality test
b. OVMF regression test
Jian J Wang (6):
MdeModulePkg:
> v3 changes:
> a. split from #2 patch of v2
> b. refine the commit message
> c. refine the title
Non-stop mode was introduced / explained in commit 8f2613628acf
("MdeModulePkg/MdeModulePkg.dec: add new settings for PCDs",
2018-08-30).
The macro HEAP_GUARD_NONSTOP_MODE was added to CpuDxe in
> v3 changes:
> a. split from #1 patch of v2
> b. update title
This cleanup is meant for avoiding misuse of newly introduced BIT4
(UAF detection) of PCD PcdHeapGuardPropertyMask, because it applies
to all types of physical memory. In another words,
PcdHeapGuardPoolType and PcdHeapGuardPageType
> v3 changes:
> a. split from #2 patch
> b. refine the commit message and title
> c. remove "else" branch
The freed-memory guard feature will cause an recursive calling
of InitializePageTablePool(). This is due to a fact that
AllocateAlignedPages() is used to allocate page table pool memory.
This
make functions for common error messages
refactor to use these functions
Cc: Yonghong Zhu
Cc: Liming Gao
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey
---
BaseTools/Source/Python/GenFds/FdfParser.py | 603 ++--
1 file changed, 303
1) initialize UiFvName via __init__ parameter. No change to default behavior.
2) initialize 3 empty lists in __init__. Curently not guarenteed initialized.
Cc: Yonghong Zhu
Cc: Liming Gao
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey
---
Cleanup to many files for GenFds. No command line visible changes are
included.
1) refactor imports to reduce namespace clutter.
2) refactor to use existing sharable objects (and create a few new)
3) eliminate shadowing of names
4) remove double underscored private methods for PEP8
5) eliminate
Change lists and tuples used solely for "in" testing to sets.
These operations are not order dependent.
fixed some line length for PEP8 compliance on some.
Cc: Liming Gao
Cc: Yonghong Zhu
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey
---
replace lots of '}' and "}" with a shared new consistent variable.
Cc: Bob Feng
Cc: Yonghong Zhu
Cc: Liming Gao
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey
---
BaseTools/Source/Python/GenFds/FdfParser.py | 45 ++--
1 file changed, 23
The MacroDict parameter goes around in circles through 4 functions without use.
1. GetSectionData calls into GetLeafSection, otherwise doesn’t use MacroDict
2. GetLeafSection calls into GetFileStatement, otherwise doesn’t use MacroDict
3. GetFileStatement calls into GetFilePart, otherwise doesn’t
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1273
Current code only uses DEBUG() for VTd error.
This patch updates to also report status code for VTd error.
Test done:
Created case that has VTd error and confirmed the error
status code could be reported as expected.
Cc: Jiewen Yao
Cc:
Reviewed-by: Liming Gao
>-Original Message-
>From: Ni, Ruiyu
>Sent: Wednesday, October 24, 2018 12:43 PM
>To: jim.dai...@dell.com; edk2-devel@lists.01.org
>Cc: Kinney, Michael D ; Gao, Liming
>
>Subject: RE: [edk2] [PATCH] MdePkg-BaseLib: Fix PathCleanUpDirectories()
>issue with
Reviewed-by: Ruiyu Ni
Thanks/Ray
> -Original Message-
> From: Wu, Hao A
> Sent: Wednesday, October 24, 2018 9:20 AM
> To: edk2-devel@lists.01.org
> Cc: Wu, Hao A ; Yao, Jiewen ;
> Ni, Ruiyu ; Zeng, Star
> Subject: [PATCH v2 3/3] MdeModulePkg/NvmExpressDxe: Refine PassThru
> IO queue
Reviewed-by: Ruiyu Ni
Thanks/Ray
> -Original Message-
> From: edk2-devel On Behalf Of
> jim.dai...@dell.com
> Sent: Saturday, October 6, 2018 3:15 AM
> To: edk2-devel@lists.01.org
> Cc: Kinney, Michael D ; Gao, Liming
>
> Subject: [edk2] [PATCH] MdePkg-BaseLib: Fix
Thank you all. Push at 8a2794f6f3a42bcc878a30565e1db9ac96fdc7cd
Thanks
Liming
>-Original Message-
>From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Leif
>Lindholm
>Sent: Thursday, October 18, 2018 10:15 AM
>To: Ard Biesheuvel
>Cc: Ni, Ruiyu ; Laszlo Ersek ; edk2-
63 matches
Mail list logo
