[edk2] [PATCH v1 2/7] EmulatorPkg: Replace obsoleted network drivers from platform DSC/FDF.

2018-10-30 Thread Fu Siyuan
This patch replaces the MdeModulePkg TCP, PXE and iSCSI driver with those ones in NetworkPkg. These 3 drivers in MdeModulePkg are not being actively maintained and will be removed from edk2 master soon. Cc: Jordan Justen Cc: Andrew Fish Cc: Ruiyu Ni Contributed-under: TianoCore Contribution

[edk2] [PATCH v1 4/7] Vlv2TbltDevicePkg: Replace obsoleted drivers from platform DSC/FDF.

2018-10-30 Thread Fu Siyuan
This patch replaces the MdeModulePkg TCP, PXE and iSCSI driver with those ones in NetworkPkg. These 3 drivers in MdeModulePkg are not being actively maintained and will be removed from edk2 master soon. Cc: David Wei Cc: Mang Guo Contributed-under: TianoCore Contribution Agreement 1.1

[edk2] [PATCH v1 3/7] OvmfPkg: Replace obsoleted network drivers from platform DSC/FDF.

2018-10-30 Thread Fu Siyuan
This patch replaces the MdeModulePkg TCP, PXE and iSCSI driver with those ones in NetworkPkg. These 3 drivers in MdeModulePkg are not being actively maintained and will be removed from edk2 master soon. Cc: Jordan Justen Cc: Laszlo Ersek Cc: Ard Biesheuvel Cc: Anthony Perard Cc: Julien Grall

[edk2] [PATCH v1 7/7] NetworkPkg: Remove some clarification from TCP/PXE/ISCSI driver INF.

2018-10-30 Thread Fu Siyuan
This patch is to remove the clarification about usage/difference between those drivers in MdeModulePkg and NetworkPkg, since the MdeModulePkg ones have been deleted now. Cc: Jiaxin Wu Cc: Ye Ting Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Fu Siyuan ---

[edk2] [PATCH v1 1/7] Nt32Pkg: Replace obsoleted network drivers from NT32 platform DSC/FDF.

2018-10-30 Thread Fu Siyuan
This patch replaces the MdeModulePkg TCP, PXE and iSCSI driver with those ones in NetworkPkg. These 3 drivers in MdeModulePkg are not being actively maintained and will be removed from edk2 master soon. Cc: Ruiyu Ni Cc: Hao Wu Contributed-under: TianoCore Contribution Agreement 1.1

[edk2] [PATCH v1 0/7] Delete TCP, PXE, iSCSI driver in MdeModulePkg.

2018-10-30 Thread Fu Siyuan
This patch series is to delete the Tcp4Dxe, UefiPxeBcDxe and IScsi4Dxe drivers in MdeModulePkg. These drivers will not be maintained and can't co-work with the dual-stack drivers in NetworkPkg. People should use below NetworkPkg drivers instead: NetworkPkg/IScsiDxe/IScsiDxe.inf

[edk2] [PATCH v1 5/7] ArmVirtPkg: Replace obsoleted network drivers from platform DSC/FDF.

2018-10-30 Thread Fu Siyuan
This patch replaces the MdeModulePkg TCP, PXE and iSCSI driver with those ones in NetworkPkg. These 3 drivers in MdeModulePkg are not being actively maintained and will be removed from edk2 master soon. Cc: Laszlo Ersek Cc: Ard Biesheuvel Cc: Julien Grall Contributed-under: TianoCore

Re: [edk2] [PATCH v2 1/2] ShellPkg-UefiShellLib: Add a function to fully-qualify paths

2018-10-30 Thread Ni, Ruiyu
> -Original Message- > From: jim.dai...@dell.com > Sent: Tuesday, October 30, 2018 5:15 AM > To: edk2-devel@lists.01.org > Cc: Carsey, Jaben ; Ni, Ruiyu > Subject: [PATCH v2 1/2] ShellPkg-UefiShellLib: Add a function to fully-qualify > paths > > +CHAR16* > +EFIAPI > +FullyQualifyPath( >

Re: [edk2] [Patch] FmpDevicePkg DSC: Add NOOPT target to verify NOOPT target

2018-10-30 Thread Zeng, Star
Reviewed-by: Star Zeng -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Liming Gao Sent: Tuesday, October 30, 2018 3:50 PM To: edk2-devel@lists.01.org Cc: Zeng, Star Subject: [edk2] [Patch] FmpDevicePkg DSC: Add NOOPT target to verify NOOPT

[edk2] [Patch] FmpDevicePkg DSC: Add NOOPT target to verify NOOPT target

2018-10-30 Thread Liming Gao
Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Liming Gao Cc: Star Zeng --- FmpDevicePkg/FmpDevicePkg.dsc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/FmpDevicePkg/FmpDevicePkg.dsc b/FmpDevicePkg/FmpDevicePkg.dsc index 444cd1f..62f4608 100644 ---

Re: [edk2] [PATCH v1 0/7] Delete TCP, PXE, iSCSI driver in MdeModulePkg.

2018-10-30 Thread Zeng, Star
Hi Siyuan, Have you checked the platforms in https://github.com/tianocore/edk2-platforms to see whether they need to be updated accordingly or not? Cc more people. Thanks, Star -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Fu Siyuan Sent:

[edk2] [PATCH 1/1] Vlv2TbltDevicePkg/SmBiosMiscDxe: fix the comparison of characters

2018-10-30 Thread Gary Lin
Dereference MatchLang before comparing it with a character. Cc: David Wei Cc: Mang Guo Cc: Michael D Kinney Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Gary Lin --- .../SmBiosMiscDxe/MiscNumberOfInstallableLanguagesFunction.c| 2 +- 1 file changed, 1

Re: [edk2] [PATCH v1 2/7] EmulatorPkg: Replace obsoleted network drivers from platform DSC/FDF.

2018-10-30 Thread Ni, Ruiyu
Reviewed-by: Ruiyu Ni Thanks/Ray > -Original Message- > From: edk2-devel On Behalf Of Fu > Siyuan > Sent: Tuesday, October 30, 2018 3:33 PM > To: edk2-devel@lists.01.org > Cc: Ni, Ruiyu ; Justen, Jordan L > > Subject: [edk2] [PATCH v1 2/7] EmulatorPkg: Replace obsoleted network >

Re: [edk2] [edk2-test][Patch] uefi-sct/SctPkg:Assign 0 to the tail of the HwErrRecVariableName

2018-10-30 Thread Leif Lindholm
Hi Eric, On Tue, Oct 30, 2018 at 04:38:36PM +0800, Eric Jin wrote: > Make the HwErrRecVariableName as valid the string. > Ensure the HwErrRecVariable could be deleted before the test exit. > > Cc: Supreeth Venkatesh (Sidenote - I don't see Supreeth actually on cc on this patch.) > Cc: Jiaxin

Re: [edk2] Reminder for deleting 3 network drivers in MdeModulePkg

2018-10-30 Thread Leif Lindholm
Hi Fu Siyan, On Tue, Oct 30, 2018 at 08:11:52AM +, Fu, Siyuan wrote: > People who want to continue use these deleted drivers could go to > edk2/UDK2018 branch to get them, but it's *highly not recommended*. They should also be able to use edk2-stable201811, right? > *If you have any

Re: [edk2] [PATCH v3 1/3] MdeModulePkg/UdfDxe: Check 'Component Type' within a Path Component

2018-10-30 Thread Wu, Hao A
> -Original Message- > From: Paulo Alcantara [mailto:pa...@paulo.ac] > Sent: Tuesday, October 30, 2018 9:41 AM > To: edk2-devel@lists.01.org; Wu, Hao A > Cc: Ni, Ruiyu > Subject: Re: [edk2] [PATCH v3 1/3] MdeModulePkg/UdfDxe: Check > 'Component Type' within a Path Component > > Hi Hao Wu,

Re: [edk2] [PATCH v1 0/7] Delete TCP, PXE, iSCSI driver in MdeModulePkg.

2018-10-30 Thread Leif Lindholm
On Tue, Oct 30, 2018 at 03:33:21PM +0800, Fu Siyuan wrote: > This patch series is to delete the Tcp4Dxe, UefiPxeBcDxe and IScsi4Dxe > drivers in MdeModulePkg. These drivers will not be maintained and can't > co-work with the dual-stack drivers in NetworkPkg. > > People should use below NetworkPkg

Re: [edk2] [Patch] BaseTools: Add special handle for '\' use in Pcd Value

2018-10-30 Thread Carsey, Jaben
Please separate includes to each on their own line. PEP8 says no to multiples on one line. Not: include random, string But instead: include string include random Also, if we only need sample from random, can we just use "from random import sample"? -Jaben > -Original Message- >

Re: [edk2] ** NOTICE ** edk2-devel mailing list configuration changes

2018-10-30 Thread Brian J. Johnson
I'm using Thunderbird 60.2.1 on Linux. If I respond to Leif's message (the one quoted below) with the "reply" button, it's addressed only to him. If I use "reply all", it goes to him, the list, and all other recipients of the original message. (That's what I did on this response.) If I use

[edk2] Building EmulatorPkg and EDK2 project issue.

2018-10-30 Thread Prem Kumar
Hi All, Below are the issue i'm currently facing, - EmulatorPkg: o Building of EmulatorPkg using below command ยง build -p EmulatorPkg\EmulatorPkg.dsc -t VS2015x86 -D WIN_SEC_BUILD -a IA32 o But when I try to launch Emulator using below command, it failed. I searched for

[edk2] [Patch] BaseTools: Add special handle for '\' use in Pcd Value

2018-10-30 Thread Yonghong Zhu
From: zhijufan Case: gEfiOzmosisPkgTokenSpaceGuid.PcdBootLogFolderPath|L"\\Logs\\"|VOID*|12 Fixes: https://bugzilla.tianocore.org/show_bug.cgi?id=1287 Cc: Liming Gao Cc: Yonghong Zhu Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Zhiju.Fan ---

[edk2] [Patch] BaseTools ConvertFceToStructurePcd: Fix the array value with empty string

2018-10-30 Thread Liming Gao
Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Liming Gao Cc: Yonghong Zhu --- BaseTools/Scripts/ConvertFceToStructurePcd.py | 17 +++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git a/BaseTools/Scripts/ConvertFceToStructurePcd.py

Re: [edk2] [PATCH V3 4/4] MdeModulePkg EhciDxe: Use common buffer for AsyncInterruptTransfer

2018-10-30 Thread Ard Biesheuvel
(add back the list) On 30 October 2018 at 09:07, Cohen, Eugene wrote: > Has this patch been tested on a system that does not have coherent DMA? > > > > It's not clear that this change would actually be faster on a system of that > type since using common buffers imply access to uncached memory.

Re: [edk2] [PATCH v5 1/1] ArmPkg/OpteeLib: Add APIs to communicate with OP-TEE

2018-10-30 Thread Leif Lindholm
Hi Sumit, Sorry this got delayed by licensing, plugfest, and then some holiday (for me). Reviewed-by: Leif Lindholm Pushed as a0f01e8a22. / Leif On Mon, Oct 22, 2018 at 11:59:36AM +0530, Sumit Garg wrote: > Add following APIs to communicate with OP-TEE pseudo/early TAs: > 1. OpteeInit >

Re: [edk2] [PATCH V3 4/4] MdeModulePkg EhciDxe: Use common buffer for AsyncInterruptTransfer

2018-10-30 Thread Leif Lindholm
On Tue, Oct 30, 2018 at 09:39:24AM -0300, Ard Biesheuvel wrote: > (add back the list) Oi! Go back on holiday! > On 30 October 2018 at 09:07, Cohen, Eugene wrote: > > Has this patch been tested on a system that does not have coherent DMA? > > > > It's not clear that this change would actually be

Re: [edk2] [edk2-test][Patch] uefi-sct/SctPkg:Assign 0 to the tail of the HwErrRecVariableName

2018-10-30 Thread Supreeth Venkatesh
Reviewed-by: Supreeth Venkatesh If the below magic number comments(inline) are fixed before commit. On Tue, 2018-10-30 at 16:38 +0800, Eric Jin wrote: > Make the HwErrRecVariableName as valid the string. > Ensure the HwErrRecVariable could be deleted before the test exit. > > Cc: Supreeth

Re: [edk2] Reminder for deleting 3 network drivers in MdeModulePkg

2018-10-30 Thread Fu, Siyuan
Hi, Leif I think checking the branch is a little better than the tag, because we may still have critical bug fixes after the official release. While any of them are not recommended, always using the NetworkPkg version driver is the best choice. I will modify the edk2 network wiki page for an

Re: [edk2] [PATCH v1 0/7] Delete TCP, PXE, iSCSI driver in MdeModulePkg.

2018-10-30 Thread Fu, Siyuan
Hi, Leif I have followed your wiki page to configure my Git when I generate this patch, and I don't know why the files are still unordered and truncated. I will do more test and try to figure out the problem. BestRegards Fu Siyuan > -Original Message- > From: edk2-devel

Re: [edk2] [PATCH v1 0/7] Delete TCP, PXE, iSCSI driver in MdeModulePkg.

2018-10-30 Thread Fu, Siyuan
Mike, Should I also update the devel branches in edk2-platform? Or the branch owner will take care of it? BestRegards Fu Siyuan > -Original Message- > From: Kinney, Michael D > Sent: Wednesday, October 31, 2018 5:15 AM > To: Fu, Siyuan ; Zeng, Star ; > edk2-devel@lists.01.org; Kinney,

Re: [edk2] Building EmulatorPkg and EDK2 project issue.

2018-10-30 Thread Gao, Liming
For emulator, please type below command and see what's happen. build -p EmulatorPkg\EmulatorPkg.dsc -t VS2015x86 -D WIN_SEC_BUILD -a IA32 -m EmulatorPkg/Win/Host/WinHost.inf >-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of >Prem Kumar >Sent:

Re: [edk2] [PATCH v1 0/7] Delete TCP, PXE, iSCSI driver in MdeModulePkg.

2018-10-30 Thread Kinney, Michael D
Fu Siyuan, Please review edk2-platform/master and prepare a patch for that branch if there are DSC/FDF files that refer to the network drivers that are being removed. We should never break any platforms in edk2-platform/master. The commits should be performed to the repos in the correct order

[edk2] [PATCH 0/2] SortLib for UEFI SEC

2018-10-30 Thread Jeff Brasen
This patch series enables support for BaseSortLib in UEFI SEC Phase. This requires the addition of the AllocateZeroPool which is implemented in the PrePiMemoryAllocationLib. Jeff Brasen (2): EmbeddedPkg/PrePiMemoryAllocationLib: Added AllocateZeroPool() MdeModulePkg/BaseSortLib: Enable for

[edk2] [PATCH 1/2] EmbeddedPkg/PrePiMemoryAllocationLib: Added AllocateZeroPool()

2018-10-30 Thread Jeff Brasen
This function is exposed by the MemoryAllocationLib header. An AllocateZeroPool() function has been added to fix modules depending on this library and this function. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jeff Brasen ---

[edk2] [PATCH 2/2] MdeModulePkg/BaseSortLib: Enable for all module types

2018-10-30 Thread Jeff Brasen
Expose BaseSortLib for use in SEC and PEI phases. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jeff Brasen --- MdeModulePkg/Library/BaseSortLib/BaseSortLib.inf | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [edk2] [PATCH 1/2] EmbeddedPkg/PrePiMemoryAllocationLib: Added AllocateZeroPool()

2018-10-30 Thread Carsey, Jaben
Code looks good. Reviewed-by: Jaben Carsey > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Jeff Brasen > Sent: Tuesday, October 30, 2018 2:31 PM > To: edk2-devel@lists.01.org > Cc: Jeff Brasen > Subject: [edk2] [PATCH 1/2]

Re: [edk2] [PATCH 2/2] MdeModulePkg/BaseSortLib: Enable for all module types

2018-10-30 Thread Carsey, Jaben
Reviewed-by: Jaben Carsey > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Jeff Brasen > Sent: Tuesday, October 30, 2018 2:31 PM > To: edk2-devel@lists.01.org > Cc: Jeff Brasen > Subject: [edk2] [PATCH 2/2] MdeModulePkg/BaseSortLib: Enable

Re: [edk2] [PATCH v1] NetworkPkg/TlsDxe: Fix failure to process multiple TLS records.

2018-10-30 Thread Fu, Siyuan
Reviewed-by: Fu Siyuan > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Jiaxin Wu > Sent: Wednesday, October 31, 2018 1:42 PM > To: edk2-devel@lists.01.org > Cc: Ye, Ting ; Fu, Siyuan ; Wu, > Jiaxin > Subject: [edk2] [PATCH v1]

[edk2] [PATCH 0/5] Remove EdkShellBinPkg in FDF, DSC and DEC

2018-10-30 Thread shenglei
Remove EdkShellBinPkg in CorebootPayloadPkg, EmulatorPkg, Nt32Pkg and OvmfPkg. Replace EdkShellBinPkg with EdkShellPkg in Vlv2TbltDevicePkg. shenglei (5): CorebootPayloadPkg: Remove EdkShellBinPkg in FDF EmulatorPkg: Remove EdkShellBinPkg in FDF and DEC Nt32Pkg: Remove EdkShellBinPkg in

[edk2] [PATCH 3/5] Nt32Pkg: Remove EdkShellBinPkg in FDF, DSC and DEC

2018-10-30 Thread shenglei
Remove EdkShellBinPkg in Nt32Pkg.dec, Nt32Pkg.dsc and Nt32Pkg.fdf. https://bugzilla.tianocore.org/show_bug.cgi?id=1108 Cc: Ruiyu Ni Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: shenglei --- Nt32Pkg/Nt32Pkg.dec | 2 +- Nt32Pkg/Nt32Pkg.dsc | 4 ++-- Nt32Pkg/Nt32Pkg.fdf

[edk2] [PATCH 5/5] Vlv2TbltDevicePkg: Remove EdkShellBinPkg with ShellPkg

2018-10-30 Thread shenglei
Replace EdkShellBinPkg with ShellPkg in PlatformPkg.fdf, PlatformPkgGcc.fdf, PlatformPkgGccX64.dsc, PlatformPkgIA32.dsc and PlatformPkgX64.dsc. https://bugzilla.tianocore.org/show_bug.cgi?id=1108 Cc: David Wei Cc: zailiang sun Contributed-under: TianoCore Contribution Agreement 1.1

[edk2] [PATCH 2/5] EmulatorPkg: Remove EdkShellBinPkg in FDF and DEC

2018-10-30 Thread shenglei
Remove EdkShellBinPkg in EmulatorPkg.dec and EmulatorPkg.fdf. https://bugzilla.tianocore.org/show_bug.cgi?id=1108 Cc: Jordan Justen Cc: Ruiyu Ni Cc: Andrew Fish Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: shenglei --- EmulatorPkg/EmulatorPkg.dec | 2 +-

[edk2] [PATCH 1/5] CorebootPayloadPkg: Remove EdkShellBinPkg in FDF

2018-10-30 Thread shenglei
Remove EdkShellBinPkg in CorebootPayloadPkg.fdf. https://bugzilla.tianocore.org/show_bug.cgi?id=1108 Cc: Maurice Ma Cc: Prince Agyeman Cc: Benjamin You Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: shenglei --- CorebootPayloadPkg/CorebootPayloadPkg.fdf | 8

[edk2] [PATCH v1] Edk2Platforms: Replace MdeModulePkg PXE/iSCSI/TCP with NetworkPkg Drivers.

2018-10-30 Thread Fu Siyuan
The PXE/iSCSI/TCP drivers in MdeModulePkg are going to be deprecated. All platform DSC/FDF files should be updated to use the dual-stack drivers in NetworkPkg. Cc: Michael A Kubacki Cc: Jiewen Yao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Fu Siyuan ---

Re: [edk2] [Patch] BaseTools ConvertFceToStructurePcd: Fix the array value with empty string

2018-10-30 Thread Zhu, Yonghong
Reviewed-by: Yonghong Zhu Best Regards, Zhu Yonghong -Original Message- From: Gao, Liming Sent: Tuesday, October 30, 2018 11:00 PM To: edk2-devel@lists.01.org Cc: Zhu, Yonghong Subject: [Patch] BaseTools ConvertFceToStructurePcd: Fix the array value with empty string

Re: [edk2] Reminder for deleting 3 network drivers in MdeModulePkg

2018-10-30 Thread Fu, Siyuan
Hi, Leif Just notice that you are saying edk2-stable201811 tag. We need more time to collect community/marketing feedback on deleting these driver, so it may won't be able to catch the stable tag in next month. BestRegards Fu Siyuan > -Original Message- > From: Fu, Siyuan > Sent:

Re: [edk2] [PATCH V3 4/4] MdeModulePkg EhciDxe: Use common buffer for AsyncInterruptTransfer

2018-10-30 Thread Zeng, Star
Good feedback. On 2018/10/30 20:50, Leif Lindholm wrote: On Tue, Oct 30, 2018 at 09:39:24AM -0300, Ard Biesheuvel wrote: (add back the list) Oi! Go back on holiday! On 30 October 2018 at 09:07, Cohen, Eugene wrote: Has this patch been tested on a system that does not have coherent DMA?

[edk2] [PATCH v1] NetworkPkg/TlsDxe: Fix failure to process multiple TLS records.

2018-10-30 Thread Jiaxin Wu
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1290. Current implementation failed to parse the multiple TLS record messages due to the incorrect pointer of TLS record header. This patch is to resolve that problem. Cc: Ye Ting Cc: Fu Siyuan Contributed-under: TianoCore Contribution

Re: [edk2] [edk2-test][Patch] uefi-sct/SctPkg:Assign 0 to the tail of the HwErrRecVariableName

2018-10-30 Thread Jin, Eric
Hi Supreeth, Thank for the comments. I will re-create the patch to add the definition of the HwErrRecVariableNamePrefixLength(8) and HwErrRecVariableNameIndexLength(4). There are two meanings to 2. To record the step number(2) used by the recoverylib or address (byte[2]) to save the

[edk2] [PATCH v1] Edk2Platforms: Replace MdeModulePkg PXE/iSCSI/TCP with NetworkPkg drivers.

2018-10-30 Thread Fu Siyuan
The PXE/iSCSI/TCP drivers in MdeModulePkg are going to be deprecated. All platform DSC/FDF files should be updated to use the dual-stack drivers in NetworkPkg. The NetworkPkg driver have all the functionality compared with MdeModulePkg one, with more bug fixes and new feature added. While its

[edk2] [Patch V2] BaseTools: Add special handle for '\' use in Pcd Value

2018-10-30 Thread Yonghong Zhu
From: zhijufan V2: Follow PEP8 to not multiples import on one line Case: gEfiOzmosisPkgTokenSpaceGuid.PcdBootLogFolderPath|L"\\Logs\\"|VOID*|12 Fixes: https://bugzilla.tianocore.org/show_bug.cgi?id=1287 Cc: Liming Gao Cc: Yonghong Zhu Contributed-under: TianoCore Contribution Agreement 1.1

Re: [edk2] [PATCH v5 1/1] ArmPkg/OpteeLib: Add APIs to communicate with OP-TEE

2018-10-30 Thread Sumit Garg
Hi Leif, No worries :). BTW, thanks for the review. Regards, Sumit On Tue, 30 Oct 2018 at 19:53, Leif Lindholm wrote: > > Hi Sumit, > > Sorry this got delayed by licensing, plugfest, and then some holiday > (for me). > > Reviewed-by: Leif Lindholm > Pushed as a0f01e8a22. > > / > Leif > >

Re: [edk2] [PATCH v2 1/2] ShellPkg-UefiShellLib: Add a function to fully-qualify paths

2018-10-30 Thread Jim.Dailey
>-Original Message- >From: Ni, Ruiyu [mailto:ruiyu...@intel.com] >Sent: Tuesday, October 30, 2018 2:33 AM >To: Dailey, Jim; edk2-devel@lists.01.org >Cc: Carsey, Jaben >Subject: RE: [PATCH v2 1/2] ShellPkg-UefiShellLib: Add a function to >fully-qualify paths > > >> -Original

[edk2] Reminder for deleting 3 network drivers in MdeModulePkg

2018-10-30 Thread Fu, Siyuan
Hi, All This email is a reminder for the patch series "Delete TCP, PXE, iSCSI driver in MdeModulePkg" https://lists.01.org/pipermail/edk2-devel/2018-October/031605.html, which *intend to delete 3 network drivers from edk2 repository*. Please help to review this email and also the patch series

Re: [edk2] [PATCH v1 7/7] NetworkPkg: Remove some clarification from TCP/PXE/ISCSI driver INF.

2018-10-30 Thread Ye, Ting
Reviewed-by: Ye Ting -Original Message- From: Fu, Siyuan Sent: Tuesday, October 30, 2018 3:33 PM To: edk2-devel@lists.01.org Cc: Wu, Jiaxin ; Ye, Ting Subject: [PATCH v1 7/7] NetworkPkg: Remove some clarification from TCP/PXE/ISCSI driver INF. This patch is to remove the

Re: [edk2] [PATCH v3 0/3] UdfDxe: Additional checks for ResolveSymlink()

2018-10-30 Thread Leif Lindholm
Many thanks for the rework. For the series: Reviewed-by: Leif Lindholm On Tue, Oct 30, 2018 at 09:26:14AM +0800, Hao Wu wrote: > V3 changes: > > According to Leif's recommendation, split the original patch into 3 > seperate ones. > > Since there is no code changes compared with the V2 of the

Re: [edk2] [PATCH v1 0/7] Delete TCP, PXE, iSCSI driver in MdeModulePkg.

2018-10-30 Thread Fu, Siyuan
Hi, Star This patch only covers the platforms in https://github.com/tianocore/edk2 I will modify the edk2 network wiki page for an updated sample DSC/FDF section, if this patch could pass review w/o objection.

Re: [edk2] [PATCH v1 1/7] Nt32Pkg: Replace obsoleted network drivers from NT32 platform DSC/FDF.

2018-10-30 Thread Ni, Ruiyu
Reviewed-by: Ruiyu Ni Thanks/Ray > -Original Message- > From: edk2-devel On Behalf Of Fu > Siyuan > Sent: Tuesday, October 30, 2018 3:33 PM > To: edk2-devel@lists.01.org > Cc: Ni, Ruiyu ; Wu, Hao A > Subject: [edk2] [PATCH v1 1/7] Nt32Pkg: Replace obsoleted network drivers > from NT32

[edk2] [edk2-test][Patch] uefi-sct/SctPkg:Assign 0 to the tail of the HwErrRecVariableName

2018-10-30 Thread Eric Jin
Make the HwErrRecVariableName as valid the string. Ensure the HwErrRecVariable could be deleted before the test exit. Cc: Supreeth Venkatesh Cc: Jiaxin Wu Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Eric Jin --- .../BlackBoxTest/VariableServicesBBTestFunction.c

Re: [edk2] ** NOTICE ** edk2-devel mailing list configuration changes

2018-10-30 Thread Leif Lindholm
Hi Mike, That resolves the issue at my end, thanks!. But it would be good to know how it works for others (does Intel have a default mail client config, and could someone else verify the behaviour is how you would normally expect?). Regards, Leif On Mon, Oct 29, 2018 at 10:40:06PM +,

Re: [edk2] [PATCH edk2-platforms v1 00/12] Fix D06 SBSA/SBBR issue and improve

2018-10-30 Thread Leif Lindholm
Hi Ming, I don't know when --stat was introduced, but it was a very long time ago. The oldest version of git I have easily available is 2.1.4, and that handles it properly. Something else must be going on. Regards, Leif On Tue, Oct 30, 2018 at 02:54:42PM +0800, Huangming (Mark) wrote: > Hi