REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1493
Pkcs7GetAttachedContent() implementation in current CryptPkcs7Verify.c
is actually shared by RuntimeCryptLib.inf, SmmCryptLib.inf and
BaseCryptLib.inf, which are not correct since there's no use scenario
for runtime and AllocatePool() used
On 01/25/19 21:28, Brian J. Johnson wrote:
> On 1/24/19 5:30 AM, Laszlo Ersek wrote:
>> On 01/24/19 10:31, David Woodhouse wrote:
>>> On Thu, 2019-01-24 at 01:48 +, Ni, Ray wrote:
David,
I think we got an agreement here to move CSM components in OvmfPkg.
I prefer we firstly
Reviewed-by: Liming Gao
> -Original Message-
> From: Chen, Chen A
> Sent: Monday, January 28, 2019 1:56 PM
> To: edk2-devel@lists.01.org
> Cc: Chen, Chen A ; Gao, Liming ;
> Kinney, Michael D ;
> Zhang, Chao B
> Subject: [PATCH v2 2/3] MdePkg/UefiGpt.h: Add new definition for enable
+Team.
-Original Message-
From: Poosapalli, Karunakar
Sent: Monday, January 28, 2019 1:20 PM
To: 'Gao, Liming'; Kinney, Michael D; ler...@redhat.com; edk2-devel@lists.01.org
Cc: Vidyadhara, Sumanth; S, Shekar Babu; Raju, SriramKumar
Subject: RE: [edk2] Conditional Compilation support in
On 01/25/19 22:30, Stefan Berger wrote:
> This patch adds the TCG2 Configuration menu to the Device Manager
> menu. We can apparently reuse the sample Tcg2ConfigDxe from
> SecurityPkg/Tcg/Tcg2Config without obvious adverse effects. The
> added TCG2 Configuration menu now shows details about the
Hi,
On 01/26/19 17:57, Sajeesh Kk wrote:
> Hello Rafeal,
>
> I believe The UEFI Sct test suite cannot be used for performance testing.
> Are there any tools which can be used from UEFI shell to measure disk IO
> perfomance using BlockIO2 Protocol ?
> Please let me know.
from a cursory look,
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Pete Batard
---
Platform/Raspberry/Pi3/AcpiTables/AcpiTables.h | 82
Platform/Raspberry/Pi3/AcpiTables/AcpiTables.inf | 51 ++
Platform/Raspberry/Pi3/AcpiTables/Csrt.aslc | 332 +
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Pete Batard
---
Platform/Raspberry/Pi3/Library/VirtualRealTimeClockLib/VirtualRealTimeClockLib.c
| 221
Platform/Raspberry/Pi3/Library/VirtualRealTimeClockLib/VirtualRealTimeClockLib.inf
| 43
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Pete Batard
---
Platform/Raspberry/Pi3/Drivers/PlatformSmbiosDxe/PlatformSmbiosDxe.c | 903
Platform/Raspberry/Pi3/Drivers/PlatformSmbiosDxe/PlatformSmbiosDxe.inf | 56 ++
2 files changed, 959
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Pete Batard
---
Platform/Raspberry/Pi3/DeviceTree/License.txt | 340 ++
Platform/Raspberry/Pi3/DeviceTree/bcm2710-rpi-3-b-plus.dtb | Bin 0 -> 25617
bytes
Changes applied to v3:
* As suggested, source is now split between Platform/Raspberry/Pi3 and
Silicon/Broacdom/Bcm283x.
Ideally, the SD/MMC drivers should also have gone to Silicon, but this is
tricky to do, as these drivers depend on the custom (platform specific) Pi
VideoCore to perform
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Pete Batard
---
Platform/Raspberry/Pi3/Drivers/GraphicsConsoleDxe/ComponentName.c
| 183 ++
Platform/Raspberry/Pi3/Drivers/GraphicsConsoleDxe/GraphicsConsole.c
| 1837
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Pete Batard
---
Platform/Raspberry/Pi3/Drivers/DwUsbHostDxe/ComponentName.c | 226 +++
Platform/Raspberry/Pi3/Drivers/DwUsbHostDxe/DriverBinding.c | 275
Platform/Raspberry/Pi3/Drivers/DwUsbHostDxe/DwUsbHostDxe.c |
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Pete Batard
---
Platform/Raspberry/Pi3/Library/MemoryInitPeiLib/MemoryInitPeiLib.c | 162
Platform/Raspberry/Pi3/Library/MemoryInitPeiLib/MemoryInitPeiLib.inf | 51
++
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Pete Batard
Reviewed-by: Ard Biesheuvel
---
Platform/Raspberry/Pi3/Drivers/RpiFirmwareDxe/RpiFirmwareDxe.c | 1084
Platform/Raspberry/Pi3/Drivers/RpiFirmwareDxe/RpiFirmwareDxe.inf | 49 +
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Pete Batard
---
Platform/Raspberry/Pi3/Readme.md | 259
Readme.md| 3 +
2 files changed, 262 insertions(+)
diff --git a/Platform/Raspberry/Pi3/Readme.md
On Mon, 28 Jan 2019 at 13:45, Pete Batard wrote:
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Pete Batard
> ---
> Platform/Raspberry/Pi3/RPi3.dec | 60 ++
> Platform/Raspberry/Pi3/RPi3.dsc | 637
> Platform/Raspberry/Pi3/RPi3.fdf | 449
Hi Pete,
A couple of general remarks on these tables.
- AFAICT (but is is difficult to tell from the binary dumps), these
are based on ACPI 5.0, which predates the introduction of ARM support
into the spec. That essentially makes them Windows-only, and not spec
based, which is unfortunate.
On 01/28/19 14:09, Tan Xiaojun wrote:
> On 2019/1/28 19:54, Laszlo Ersek wrote:
>> On 01/28/19 11:46, Mark Rutland wrote:
>>> On Wed, Jan 23, 2019 at 10:54:56AM +0100, Laszlo Ersek wrote:
On 01/23/19 10:26, Ard Biesheuvel wrote:
> On Wed, 23 Jan 2019 at 10:14, Laszlo Ersek wrote:
>>
Hi Bob,
On 01/28/19 11:35, Feng, Bob C wrote:
> Hi Laszlo,
>
> I sent out 2 patches to fix this issue. And I also pushed the patches to the
> repo https://github.com/BobCF/edk2.git branch py3basetools
I fetched your branch, and I found two new (fast-forward-able) commits:
$ git log --oneline
Reviewed-by: Jaben Carsey
> -Original Message-
> From: Bi, Dandan
> Sent: Sunday, January 27, 2019 7:29 PM
> To: edk2-devel@lists.01.org
> Cc: Krzysztof Koch ; Carsey, Jaben
> ; Ni, Ray
> Subject: [patch] ShellPkg/UefiShellAcpiViewCommandLib: Fix VS tool chain
> build failure
>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Pete Batard
---
Platform/Raspberry/Pi3/Drivers/ConfigDxe/ConfigDxe.c| 350
Platform/Raspberry/Pi3/Drivers/ConfigDxe/ConfigDxe.inf | 77 +
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Pete Batard
---
Platform/Raspberry/Pi3/Drivers/DisplayDxe/ComponentName.c | 222 +++
Platform/Raspberry/Pi3/Drivers/DisplayDxe/DisplayDxe.c| 606
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Pete Batard
---
Platform/Raspberry/Pi3/Drivers/VarBlockServiceDxe/FileIo.c | 196
Platform/Raspberry/Pi3/Drivers/VarBlockServiceDxe/FvbInfo.c | 115
+++
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Pete Batard
---
Platform/Raspberry/Pi3/Drivers/FdtDxe/FdtDxe.c | 364
Platform/Raspberry/Pi3/Drivers/FdtDxe/FdtDxe.inf | 53 +++
2 files changed, 417 insertions(+)
diff --git
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Pete Batard
---
Platform/Raspberry/Pi3/Library/PlatformBootManagerLib/PlatformBm.c
| 793
Platform/Raspberry/Pi3/Library/PlatformBootManagerLib/PlatformBm.h
| 60 ++
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Pete Batard
---
Platform/Raspberry/Pi3/Drivers/ArasanMmcHostDxe/ArasanMmcHostDxe.c | 723
Platform/Raspberry/Pi3/Drivers/ArasanMmcHostDxe/ArasanMmcHostDxe.h | 50 ++
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Pete Batard
---
Platform/Raspberry/Pi3/Drivers/SdHostDxe/SdHostDxe.c | 787
Platform/Raspberry/Pi3/Drivers/SdHostDxe/SdHostDxe.inf| 54 ++
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Pete Batard
---
Platform/Raspberry/Pi3/TrustedFirmware/License.txt | 26
Platform/Raspberry/Pi3/TrustedFirmware/README.md | 42
Platform/Raspberry/Pi3/TrustedFirmware/bl1.bin | Bin 0
ArmSetMemoryAttributes() still chokes in some cases, i.e., when the
length of the region exceeds 4 GB, the subtraction overflows, which
results in the region being misidentified as being 32-bit addressable.
Let's update the logic to trim the length to what we can address with
32 bits. This fixes
On Mon, Jan 28, 2019 at 09:09:26PM +0800, Tan Xiaojun wrote:
> On 2019/1/28 19:54, Laszlo Ersek wrote:
> > On 01/28/19 11:46, Mark Rutland wrote:
> >> On Wed, Jan 23, 2019 at 10:54:56AM +0100, Laszlo Ersek wrote:
> >>> And even on the original (unspecified) hardware, the same binary works
> >>>
On Wed, 23 Jan 2019 at 17:20, Leif Lindholm wrote:
>
> On Wed, Jan 23, 2019 at 05:16:57PM +0100, Ard Biesheuvel wrote:
> > On Wed, 23 Jan 2019 at 17:13, Leif Lindholm
> > wrote:
> > >
> > > On Wed, Jan 23, 2019 at 04:55:28PM +0100, Ard Biesheuvel wrote:
> > > > On Wed, 23 Jan 2019 at 16:46,
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Pete Batard
---
Platform/Raspberry/Pi3/Include/IndustryStandard/RpiMbox.h | 108
+
Platform/Raspberry/Pi3/Library/PlatformLib/AArch64/RaspberryPiHelper.S | 107
+
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Pete Batard
---
Platform/Raspberry/Pi3/RPi3.dec | 60 ++
Platform/Raspberry/Pi3/RPi3.dsc | 637
Platform/Raspberry/Pi3/RPi3.fdf | 449 ++
3 files changed, 1146 insertions(+)
diff --git
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Pete Batard
---
Platform/Raspberry/Pi3/Drivers/MmcDxe/ComponentName.c | 163
Platform/Raspberry/Pi3/Drivers/MmcDxe/Diagnostics.c | 263 ++
Platform/Raspberry/Pi3/Drivers/MmcDxe/Mmc.c | 460
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Pete Batard
---
Silicon/Broadcom/Bcm283x/Bcm283x.dec | 23 ++
Silicon/Broadcom/Bcm283x/Drivers/InterruptDxe/InterruptDxe.c | 367
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Pete Batard
---
Silicon/Broadcom/Bcm283x/Library/GpioLib/GpioLib.c | 88
Silicon/Broadcom/Bcm283x/Library/GpioLib/GpioLib.inf| 39 +
On Mon, 28 Jan 2019 at 13:45, Pete Batard wrote:
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Pete Batard
> ---
> Silicon/Broadcom/Bcm283x/Library/GpioLib/GpioLib.c | 88
>
> Silicon/Broadcom/Bcm283x/Library/GpioLib/GpioLib.inf| 39
Hi Pete,
On Mon, 28 Jan 2019 at 13:44, Pete Batard wrote:
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Pete Batard
> ---
> Silicon/Broadcom/Bcm283x/Bcm283x.dec | 23 ++
> Silicon/Broadcom/Bcm283x/Drivers/InterruptDxe/InterruptDxe.c |
Hi Laszlo,
Thank you for your comment.
I've sent an updated patch for review.
https://lists.01.org/pipermail/edk2-devel/2019-January/035806.html
Regards,
Neo
> -Original Message-
> From: Laszlo Ersek [mailto:ler...@redhat.com]
> Sent: Friday, January 25, 2019 1:07 AM
> To: Hsueh,
On Mon, Jan 28, 2019 at 01:29:54PM +0100, Ard Biesheuvel wrote:
> > > > > > > @@ -296,7 +297,8 @@ GetBlockEntryListFromAddress (
> > > > > > >
> > > > > > > // Fill the BlockEntry with the new TranslationTable
> > > > > > > ReplaceLiveEntry (BlockEntry,
> > > > > > > -
Skip runtime relocation for PE images that provide invalid relocation infomation
(ex: RelocDir->Size = 0) to fix a hang observed while booting
Windows.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Neo Hsueh
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Dandan Bi
Cc:
On Mon, Jan 28, 2019 at 05:23:32PM +0100, Ard Biesheuvel wrote:
> ArmSetMemoryAttributes() still chokes in some cases, i.e., when the
> length of the region exceeds 4 GB, the subtraction overflows, which
> results in the region being misidentified as being 32-bit addressable.
>
> Let's update the
On Mon, 28 Jan 2019 at 19:11, Leif Lindholm wrote:
>
> On Mon, Jan 28, 2019 at 05:23:32PM +0100, Ard Biesheuvel wrote:
> > ArmSetMemoryAttributes() still chokes in some cases, i.e., when the
> > length of the region exceeds 4 GB, the subtraction overflows, which
> > results in the region being
On 01/28/19 19:40, Neo Hsueh wrote:
> Skip runtime relocation for PE images that provide invalid relocation
> infomation
> (ex: RelocDir->Size = 0) to fix a hang observed while booting
> Windows.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
>
> Signed-off-by: Neo Hsueh
> Cc:
Hi Laszlo,
Thanks for your suggestion. I re-sent the patch set and pushed the new patch
set into branch py3basetools_v2.
Thanks,
Bob
-Original Message-
From: Laszlo Ersek [mailto:ler...@redhat.com]
Sent: Monday, January 28, 2019 9:48 PM
To: Feng, Bob C
Cc: edk2-devel@lists.01.org;
Hi, Tomas
> -Original Message-
> From: Tomas Pilar (tpilar) [mailto:tpi...@solarflare.com]
> Sent: Monday, January 28, 2019 7:24 PM
> To: Fu, Siyuan ; Wu, Jiaxin ; Laszlo
> Ersek ; edk2-devel@lists.01.org
> Cc: Ye, Ting
> Subject: Re: [edk2] Network Stack Budgeting
>
> Hi Siyuan,
>
> I
Minor comments regarding the parameter name.
> -Original Message-
> From: edk2-devel On Behalf Of Shenglei
> Zhang
> Sent: Thursday, January 10, 2019 8:44 PM
> To: edk2-devel@lists.01.org
> Cc: Kinney, Michael D ; Gao, Liming
>
> Subject: [edk2] [PATCH v2] MdePkg/BaseLib: Add
ValueError: non-hexadecimal number found in
fromhex() arg at position 0
Cc: Bob Feng
Cc: Liming Gao
Cc: Yonghong Zhu
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Zhiju.Fan
---
BaseTools/Source/Python/Rsa2048Sha256Sign/Rsa2048Sha256Sign.py | 4 ++--
1 file changed,
From: Zhijux Fan
Linux Python highest version check.
The path of Python interpreter assign values to PYTHON_COMMAND
Cc: Bob Feng
Cc: Liming Gao
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Zhiju.Fan
---
edksetup.sh | 16 +++-
1 file changed, 11
In python3,The keys of the dictionary not a list,It needs to be converted
Cc: Bob Feng
Cc: Liming Gao
Cc: Yonghong Zhu
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Zhiju.Fan
---
BaseTools/Source/Python/AutoGen/AutoGen.py | 26
+-
Deal with bytes and str is different, remove the unicode(),
correct open file parameter.
Using utcfromtimestamp instead of fromtimestamp.
Cc: Bob Feng
Cc: Liming Gao
Cc: Yonghong Zhu
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Zhiju.Fan
---
From: Zhijux Fan
print PYTHON3_ENABLE and PYTHON_COMMAND in build tool
Cc: Bob Feng
Cc: Liming Gao
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Zhiju.Fan
---
BaseTools/Source/Python/build/build.py | 6 ++
1 file changed, 6 insertions(+)
diff --git
From: Liming Gao
Update PYTHON env to PYTHON_COMMAND.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Liming Gao
---
BaseTools/Bin/CYGWIN_NT-5.1-i686/Ecc| 6 +++---
BaseTools/Bin/CYGWIN_NT-5.1-i686/GenDepex | 6 +++---
This patch is to make sure the AllPcdList is always evaluated.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Bob Feng
Cc: Liming Gao
---
BaseTools/Source/Python/AutoGen/AutoGen.py | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git
From: Zhijux Fan
argparse.ArgumentParser not have version parameter
Cc: Bob Feng
Cc: Liming Gao
Cc: Yonghong Zhu
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Zhiju.Fan
---
BaseTools/Source/Python/Pkcs7Sign/Pkcs7Sign.py | 3 ++-
From: Zhijux Fan
Modify windows script, PosixLike script, edksetup.sh, edksetup.bat to
use Python3 based on PYTHON3_ENABLE environment.
Cc: Bob Feng
Cc: Liming Gao
Cc: Yonghong Zhu
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Zhiju.Fan
---
In python2, the FvHeaderBuffer Type is a str
In python3, the FvHeaderBuffer Type is a bytes
Cc: Bob Feng
Cc: Liming Gao
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Zhiju.Fan
---
BaseTools/Source/Python/GenFds/FvImageSection.py | 10 --
1 file changed, 8
From: Zhijux Fan
In python3, if Value is octal data, the int(Value, 0) report an error
Cc: Bob Feng
Cc: Liming Gao
Cc: Yonghong Zhu
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Zhiju.Fan
---
BaseTools/Source/Python/AutoGen/GenC.py | 2 +-
From: Zhiju Fan
https://bugzilla.tianocore.org/show_bug.cgi?id=1379
Line 208 of BaseTools/Source/Python/Trim/Trim.py uses
'NewLines.append(os.linesep)' to insert a new line into
the list that will be written to the output file.
This causes the '\r\n' inserted with os.linesep to be
written as
correct open MapFile support python2 and python3
Cc: Bob Feng
Cc: Liming Gao
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Zhiju.Fan
---
BaseTools/Source/Python/BPDG/GenVpd.py | 10 +++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git
From: Zhiju Fan
Specifies encoding when opening a file using codecs
Cc: Bob Feng
Cc: Liming Gao
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Zhiju.Fan
---
BaseTools/Tests/TestTools.py | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git
From: Zhiju Fan
There should be no blank line across every
line in datalog if open it with Notepad++.
Cc: Bob Feng
Cc: Liming Gao
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Zhiju.Fan
---
BaseTools/Source/Python/build/BuildReport.py | 2 +-
1 file changed, 1
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1497
Current implementation of IsDevicePathValid() is not enough for type
of MEDIA_FILEPATH_DP, which has NULL-terminated string in the device
path. This patch add a simple NULL character check at Length position.
Cc: Liming Gao
Cc: Ray Ni
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1497
Current implementation of IsDevicePathValid() is not enough for type
of MEDIA_FILEPATH_DP, which has NULL-terminated string in the device
path. This patch add a simple NULL character check at Length position.
Cc: Liming Gao
Cc: Ray Ni
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1497
Jian J Wang (2):
MdePkg/UefiDevicePathLib: Add sanity check for FilePath device path
MdePkg/UefiDevicePathLibDevicePathProtocol: Add sanity check for
FilePath device path
MdePkg/Library/UefiDevicePathLib/DevicePathUtilities.c|
> -Original Message-
> From: Laszlo Ersek [mailto:ler...@redhat.com]
> Sent: Monday, January 28, 2019 2:17 PM
> To: Hsueh, Hong-chihX ; edk2-devel@lists.01.org
> Cc: Kinney, Michael D ; Gao, Liming
> ; Bi, Dandan
> Subject: Re: [PATCH] MdePkg/BasePeCoffLib: skip runtime relocation if
>
From: Zhijux Fan
UUID does not have the get_bytes_le() in python3
Cc: Bob Feng
Cc: Liming Gao
Cc: Yonghong Zhu
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Zhiju.Fan
---
BaseTools/Source/Python/Common/Misc.py | 2 +-
From: Zhijux Fan
Because the xrange() was not exist in Python3
Cc: Bob Feng
Cc: Liming Gao
Cc: Yonghong Zhu
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Zhiju.Fan
---
BaseTools/Source/Python/AutoGen/GenPcdDb.py | 22 +++---
use OrderedDict instead of sdict, and delete sdict
Cc: Bob Feng
Cc: Liming Gao
Cc: Yonghong Zhu
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Yunhua Feng
---
BaseTools/Source/Python/Common/Misc.py | 123
From: Yunhua Feng
Remove unnecessary super function
Cc: Bob Feng
Cc: Liming Gao
Cc: Yonghong Zhu
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Yunhua Feng
---
BaseTools/Source/Python/AutoGen/AutoGen.py | 5 -
1 file changed, 5 deletions(-)
diff --git
From: Zhijux Fan
itertools.imap() replace map(), itertools.ifilter() replace filter
Cc: Bob Feng
Cc: Liming Gao
Cc: Yonghong Zhu
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Zhiju.Fan
---
BaseTools/Source/Python/build/build.py | 6 ++
1 file changed, 2
From: Yunhua Feng
nametuple not have verbose parameter in python3
Cc: Bob Feng
Cc: Liming Gao
Cc: Yonghong Zhu
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Yunhua Feng
---
BaseTools/Source/Python/Workspace/BuildClassObject.py | 2 +-
1 file changed, 1
---
.../Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c | 918 +-
.../Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.h | 159 ++-
2 files changed, 519 insertions(+), 558 deletions(-)
diff --git a/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c
From: Zhijux Fan
update Test scripts support python2 and python3
Cc: Bob Feng
Cc: Liming Gao
Cc: Yonghong Zhu
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Zhiju.Fan
---
BaseTools/Tests/CToolsTests.py | 2 +-
BaseTools/Tests/CheckUnicodeSourceFiles.py
From: Zhijux Fan
In UPT Tool,merge python2 and python3
Cc: Bob Feng
Cc: Liming Gao
Cc: Yonghong Zhu
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Zhiju.Fan
---
BaseTools/Source/Python/UPT/Core/IpiDb.py | 4 ++--
From: Zhijux Fan
If ForceRebase is not set, and FV is specified in FD region,
it should have FvBaseAddress
Cc: Bob Feng
Cc: Liming Gao
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Zhiju.Fan
---
BaseTools/Source/Python/GenFds/FvImageSection.py | 2 ++
From: Zhijux Fan
in python2 and python3,use of line breaks
Cc: Bob Feng
Cc: Liming Gao
Cc: Yonghong Zhu
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Zhiju.Fan
---
BaseTools/Source/Python/AutoGen/AutoGen.py | 10 +-
From: Zhijux Fan
PEP 238 -- Changing the Division Operator
x/y to return a reasonable approximation of the mathematical result
of the division ("true division")
x//y to return the floor ("floor division")
Cc: Bob Feng
Cc: Liming Gao
Cc: Yonghong Zhu
Contributed-under: TianoCore
From: Zhijux Fan
In python3, if Value is octal data, the int(Value, 0) report an error
Cc: Bob Feng
Cc: Liming Gao
Cc: Yonghong Zhu
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Zhiju.Fan
---
BaseTools/Source/Python/AutoGen/GenC.py | 2 ++
From: Yunhua Feng
replace long by int
Because the long() was not exist in Python3
Cc: Bob Feng
Cc: Liming Gao
Cc: Yonghong Zhu
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Yunhua Feng
---
BaseTools/Source/Python/AutoGen/ValidCheckingInfoObject.py | 4 ++--
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=55
V2:
The python files under CParser4 folder of ECC/Eot tool
are generated by antlr4 and forpython3 usage.
They have python3 specific syntax, for example
the data type declaration for the arguments of a function. That
is not compitable with
From: Zhijux Fan
set PYTHONHASHSEED
Specifying the value 0 will disable hash randomization.
Cc: Bob Feng
Cc: Liming Gao
Cc: Yonghong Zhu
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Zhiju.Fan
---
BaseTools/toolsetup.bat | 1 +
edksetup.sh | 2 +-
2
From: Zhijux Fan
Porting PackageDocumentTools code to support python2 and python3
Cc: Bob Feng
Cc: Liming Gao
Cc: Yonghong Zhu
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Zhiju.Fan
---
BaseTools/Scripts/ConvertFceToStructurePcd.py
From: Zhijux Fan
replace the list iteritems by items in Python3.
Cc: Bob Feng
Cc: Liming Gao
Cc: Yonghong Zhu
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Zhiju.Fan
---
BaseTools/Source/Python/AutoGen/GenMake.py| 6 +++---
Jiansong:
The patch is good. Reviewed-by: Liming Gao
Besides, this patch is from MS Mu, please keep original patch author. Don't
need to send the patch again.
Thanks
LIming
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Jiansong
> -Original Message-
> From: Wang, Jian J
> Sent: Tuesday, January 29, 2019 11:28 AM
> To: Wu, Hao A; edk2-devel@lists.01.org
> Cc: Ni, Ray
> Subject: RE: [PATCH] MdeModulePkg/SdMmcPciHcDxe: Update comment for
> spec compliance status
>
> Just two typos (see below). With them addressed,
>
Hi,
Please share review comments.
Thanks,
Meenakshi
> -Original Message-
> From: Meenakshi Aggarwal
> Sent: Thursday, January 24, 2019 7:35 PM
> To: ard.biesheu...@linaro.org; leif.lindh...@linaro.org; edk2-
> de...@lists.01.org; jun@linaro.org; haojian.zhu...@linaro.org
> Cc:
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Mike
> Li (WH)
> Sent: Monday, January 28, 2019 3:36 PM
> To: edk2-devel@lists.01.org
> Subject: [edk2] [PATCH] patch1_add_support_bh720_emmc_chip
Hi,
Thanks for the contribution. I saw you sent
Just two typos (see below). With them addressed,
Reviewed-by: Jian J Wang
> -Original Message-
> From: Wu, Hao A
> Sent: Tuesday, January 29, 2019 11:14 AM
> To: edk2-devel@lists.01.org
> Cc: Wu, Hao A ; Wang, Jian J ;
> Ni, Ray
> Subject: [PATCH] MdeModulePkg/SdMmcPciHcDxe: Update
Shenglei:
The patch is good. Reviewed-by: Liming Gao
Besides, this patch is from MS Mu project. Please keep original patch author.
You don't need to send this patch again.
Thanks
Liming
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
---
MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdDevice.c | 147 ++
.../Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.c | 130 +++-
2 files changed, 174 insertions(+), 103 deletions(-)
diff --git a/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdDevice.c
Reviewed-by: Liming Gao
> -Original Message-
> From: Zhang, Shenglei
> Sent: Wednesday, December 19, 2018 4:55 PM
> To: edk2-devel@lists.01.org
> Cc: Leif Lindholm ; Laszlo Ersek
> ; Kinney, Michael D ; Gao,
> Liming ; Wang, Jian J ; Wu, Hao
> A ; Zeng, Star
> ; Philippe Mathieu-Daud�
Reviewed-by: Liming Gao
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Shenglei Zhang
> Sent: Wednesday, December 12, 2018 11:10 AM
> To: edk2-devel@lists.01.org
> Cc: Gao, Liming
> Subject: [edk2] [PATCH v2 2/2] BaseTools/DevicePath:
Reviewed-by: Liming Gao for this patch set.
> -Original Message-
> From: Zhang, Shenglei
> Sent: Tuesday, December 25, 2018 4:17 PM
> To: edk2-devel@lists.01.org
> Cc: Kinney, Michael D ; Gao, Liming
> ; Leif Lindholm ;
> Laszlo Ersek ; Wang, Jian J ; Wu,
> Hao A ; Zeng, Star
> ; Ni,
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1441
This commit will update the file-level comments within the SdMmcPciHcDxe
to reflect the latest specification compliance status of the driver.
Cc: Jian J Wang
Cc: Ray Ni
Contributed-under: TianoCore Contribution Agreement 1.1
Hi Chen,
Here're some overall comments:
1. Update all copyright year to 2019
2. Split this patch to smaller granularity (in public standalone file unit or
module unit),
and keep in mind that the patch order also matters. This patch can be split
into 3
patches.
3. Provide test
Reviewed-by: Ruiyu Ni
> -Original Message-
> From: edk2-devel On Behalf Of Shenglei
> Zhang
> Sent: Wednesday, December 12, 2018 11:10 AM
> To: edk2-devel@lists.01.org
> Cc: Kinney, Michael D ; Gao, Liming
>
> Subject: [edk2] [PATCH v2 2/2] MdePkg/UefiDevicePathLib: Add a checking
>
Skip runtime relocation for PE images that provide invalid relocation infomation
(ex: RelocDir->Size = 0) to fix a hang observed while booting Windows.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Neo Hsueh
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Dandan Bi
Cc:
Bob:
I have no comments on this patch. Reviewed-by: Liming Gao
Besides, please make sure the build report list the value from DEC file when
the value is specified in DEC file.
Thanks
Liming
> -Original Message-
> From: Feng, Bob C
> Sent: Friday, January 25, 2019 5:45 PM
> To:
1 - 100 of 129 matches
Mail list logo
