> -Original Message-
> From: Zhang, Shenglei
> Sent: Wednesday, January 30, 2019 2:34 PM
> To: edk2-devel@lists.01.org
> Cc: Wang, Jian J; Wu, Hao A; Ni, Ray; Zeng, Star
> Subject: [PATCH v5 4/7] MdeModulePkg/EbcDebugger: Use AsciiCharToUpper
> and CharToUpper
>
> InternalUnicodeToUpper
> -Original Message-
> From: Zhang, Shenglei
> Sent: Wednesday, January 30, 2019 2:34 PM
> To: edk2-devel@lists.01.org
> Cc: Wang, Jian J; Wu, Hao A; Ni, Ray; Zeng, Star
> Subject: [PATCH v5 5/7] MdeModulePkg/DxeHttpLib: Use BaseLib api
> AsciiCharToUpper
>
> Substitute HttpIoCharToUpper
> -Original Message-
> From: Zhang, Shenglei
> Sent: Wednesday, January 30, 2019 2:34 PM
> To: edk2-devel@lists.01.org
> Cc: Wang, Jian J; Wu, Hao A; Ni, Ray; Zeng, Star
> Subject: [PATCH v5 1/7] MdeModulePkg/EbcDebugger: Change function names
>
> Change UnicodeToUpper to
On 1/30/2019 2:34 PM, Shenglei Zhang wrote:
Introduce public functions CharToUpper and AsciiCharToUpper.
Remove internal functions InternalCharToUpper and InternalBaseLibAsciiToUpper.
v2: Update the title and commit message of 1/3.
v3: 1.Add a patch to remove AsciiToUpper in
Comments in below.
On 1/30/2019 2:28 PM, Shenglei Zhang wrote:
From: Mike Turner
Introduce public functions Base64Encode and Base64Decode.
https://bugzilla.tianocore.org/show_bug.cgi?id=1370
v2:1.Remove some white space.
2.Add unit test with test vectors in RFC 4648.
From: Hess Chen
Add a new type of exception for function body checkpoint.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Hess Chen
---
BaseTools/Source/Python/Ecc/c.py | 14 ++
1 file changed, 10 insertions(+), 4 deletions(-)
diff --git
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1435
This patch is going to fix the issue of incorrect line
number in PcdValueInit.c
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Bob Feng
Cc: Liming Gao
---
BaseTools/Source/Python/Workspace/MetaFileTable.py | 2 +-
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Chen
> A Chen
> Sent: Tuesday, January 29, 2019 1:28 PM
> To: edk2-devel@lists.01.org
> Cc: Ni, Ray; Zhang, Chao B
> Subject: [edk2] [PATCH v3 3/3] FatPkg: Add GPT check in FatPei to support
>
Reviewed-by: Ryszard Knop
On Tue, 2018-11-06 at 18:58 +0100, ard.biesheuvela wrote:
> Use intermediate (UINTN) casts when casting pointers to UINT64.
> This is needed to be able to build this code for 32-bit architectures
> such as ARM or IA32.
>
> Contributed-under: TianoCore Contribution
Just one note for this: We have separate defines for EFI32 (IA32),
EFI64 (IPF) and EFIX64 (X64) to sprinkle some workarounds where needed.
It seems ARM doesn't need that for now, but I'll add similar defines
for it as well so that we have that available in the future.
Reviewed-by: Ryszard Knop
Reviewed-by: Ryszard Knop
On Tue, 2018-11-06 at 18:58 +0100, ard.biesheuvela wrote:
> Unlike Visual Studio, GCC does not permit implicit conversion between
> a pointer-to-void-pointer and pointer to a typed pointer. So add the
> explicit casts where necessary.
>
> Contributed-under: TianoCore
Reviewed-by: Ryszard Knop
On Tue, 2018-11-06 at 18:58 +0100, ard.biesheuvela wrote:
> The Data4 member of the GUID/EFI_GUID struct type is an array of
> UINT8, so literals require two sets of { } braces. Add them where
> missing.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
>
Reviewed-by: Ryszard Knop
On Tue, 2018-11-06 at 18:58 +0100, ard.biesheuvela wrote:
> UINT8 and CHAR8 are not the same underlying type on all
> architectures,
> so add an explicit cast where necessary.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ard Biesheuvel
On Tue, 2018-11-06 at 21:31 +0100, philmd at redhat.com wrote:
> Hi Ard,
>
> On 6/11/18 18:58, Ard Biesheuvel wrote:
> > UINT8 and CHAR8 are not the same underlying type on all
> > architectures,
> > so add an explicit cast where necessary.
> >
> > Contributed-under: TianoCore Contribution
Reviewed-by: Ryszard Knop
On Tue, 2018-11-06 at 18:58 +0100, ard.biesheuvela wrote:
> The ## CPP token pasting operator is used to paste *tokens*, which
> is not the same thing as pasting arbitrary macro arguments. Since a
> token cannot contain . or ) characters in the first place, using
> the
Reviewed-by: Ryszard Knop
On Tue, 2018-11-06 at 18:58 +0100, ard.biesheuvela wrote:
> Remove the forward declaration of e1000_disable_ulp_lpt_lp (), which
> is never defined anywhere in the code.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ard Biesheuvel
> ---
Reviewed-by: Ryszard Knop
On Wed, 2018-11-14 at 18:33 -0800, ard.biesheuvela wrote:
> Use (VOID) casts to silence unreferenced parameter warnings on GCC.
> The
> existing macros generate 'statement with no effect' warnings instead,
> which does not really help.
>
> Contributed-under: TianoCore
Reviewed-by: Ryszard Knop
On Wed, 2018-11-14 at 18:33 -0800, ard.biesheuvela wrote:
> When building for the X64 target using GCC, correct use of the
> EFIAPI modifiers is essential to ensure that the correct calling
> convention is used. So add the missing ones where appropriate.
>
>
Reviewed-by: Ryszard Knop
On Wed, 2018-11-14 at 18:33 -0800, ard.biesheuvela wrote:
> Only define the CPP macro MDEPKG_NDEBUG for the RELEASE target so
> that debug features are functional otherwise.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ard Biesheuvel
>
I updated the subject line to start with EmbeddedPkg: instead.
On Thu, Jan 24, 2019 at 07:35:18PM +0530, Meenakshi Aggarwal wrote:
> Issue : SD read failure for high capacity cards e.g. 64 GB
> i
And I dropped the above stray i.
Reviewed-by: Leif Lindholm
Pushed as b566259c8a.
Thanks!
>
That's actually not quite correct - we need this package to build on
IA32. It's named rather unfortunately, since it's not the EDK2 StdLibC,
but rather a package in this repository - see IntelUndiPkg/LibC. It
contains the bare minimum of functionality required to fix missing 64-
bit math/shifts on
Ah, thanks!
On Wed, 2019-01-30 at 17:06 +0100, Ard Biesheuvel wrote:
> On Wed, 30 Jan 2019 at 17:05, Ryszard Knop <
> ryszard.k...@linux.intel.com> wrote:
> > Hmm, is there a list/something I can generate to see which globals
> > build tools emit? There are some more variables I'd happily get rid
Reviewed-by: Ryszard Knop
On Wed, 2018-11-14 at 18:33 -0800, ard.biesheuvela wrote:
> XgbeMemCopy () takes UINT8 pointers not INT8 pointers, so cast the
> arguments to the correct type.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ard Biesheuvel
> ---
>
> On Jan 30, 2019, at 9:26 AM, Ryszard Knop
> wrote:
>
> That's actually not quite correct - we need this package to build on
> IA32. It's named rather unfortunately, since it's not the EDK2 StdLibC,
> but rather a package in this repository - see IntelUndiPkg/LibC. It
> contains the bare
On 01/29/19 19:50, Neo Hsueh wrote:
> Skip runtime relocation for PE images that provide invalid relocation
> infomation (ex: RelocDir->Size = 0) to fix a hang observed while booting
> Windows.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Neo Hsueh
> Cc: Michael D
Just one thing - in E1000Receive, the removed Status is actually
needed, we've missed the error handling block in 1G while backporting
DMA changes from 40G drivers.
Reviewed-by: Ryszard Knop
On Tue, 2018-11-06 at 18:58 +0100, ard.biesheuvela wrote:
> Drop variables that are assigned but never
Reviewed-by: Ryszard Knop
On Wed, 2018-11-14 at 18:33 -0800, ard.biesheuvela wrote:
> Move the extern declaration of mBrandingTable[] after the definition
> of
> the type. This solves a build issue with GCC.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ard
Reviewed-by: Jaben Carsey
> -Original Message-
> From: Zhang, Shenglei
> Sent: Tuesday, January 29, 2019 10:34 PM
> To: edk2-devel@lists.01.org
> Cc: Ni, Ray ; Carsey, Jaben
> Subject: [PATCH v5 6/7] ShellPkg/Shell: Use BaseLib api CharToUpper
> Importance: High
>
> Substitute
Reviewed-by: Jaben Carsey
> -Original Message-
> From: Zhang, Shenglei
> Sent: Tuesday, January 29, 2019 10:34 PM
> To: edk2-devel@lists.01.org
> Cc: Ni, Ray ; Carsey, Jaben
> Subject: [PATCH v5 7/7] ShellPkg/UefiShellLib: Use BaseLib api CharToUpper
> Importance: High
>
> Substitute
Reviewed-by: Ryszard Knop
On Wed, 2018-11-14 at 18:33 -0800, ard.biesheuvela wrote:
> The ## CPP token pasting operator is used to paste *tokens*, which
> is not the same thing as pasting arbitrary macro arguments. Since a
> token cannot contain . or ) characters in the first place, using
> the
On Wed, 30 Jan 2019 at 16:31, Ryszard Knop wrote:
>
> Builds were fine, the result didn't work. Adding proper EFIAPIs fixed
> that, so should be okay everywhere.
>
Right. No I didn't spot that - I did build tests of all architectures,
and boot tests on 64-bit ARM. (I don't have x86 hardware with
Builds were fine, the result didn't work. Adding proper EFIAPIs fixed
that, so should be okay everywhere.
On Wed, 2019-01-30 at 16:20 +0100, Ard Biesheuvel wrote:
> On Wed, 30 Jan 2019 at 16:15, Ryszard Knop <
> ryszard.k...@linux.intel.com> wrote:
> > I'm going through all the protocols we have
Reviewed-by: Ryszard Knop
On Wed, 2018-11-14 at 18:33 -0800, ard.biesheuvela wrote:
> GCC chokes on the unknown MSVC specific #pragmas used for suppressing
> warnings, so remove them and use the INF BuildOptions section
> instead.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
>
Reviewed-by: Ryszard Knop
On Wed, 2018-11-14 at 18:33 -0800, ard.biesheuvela wrote:
> UINT8 and CHAR8 are not the same underlying type on all
> architectures,
> so add an explicit cast where necessary.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ard Biesheuvel
On Wed, 30 Jan 2019 at 16:15, Ryszard Knop wrote:
>
> I'm going through all the protocols we have defined/used and in
> Decode.c/h there's [E1000]UndiApiEntry for PXE/UNDI callbacks. I've
> tested an X64 GCC build under OVMF and these calls were broken due to
> mismatched calling conventions. Did
I'm going through all the protocols we have defined/used and in
Decode.c/h there's [E1000]UndiApiEntry for PXE/UNDI callbacks. I've
tested an X64 GCC build under OVMF and these calls were broken due to
mismatched calling conventions. Did this work correctly for your builds
on your platforms?
Reviewed-by: Ryszard Knop
On Wed, 2018-11-14 at 18:33 -0800, ard.biesheuvela wrote:
> Replace backslashes in paths with forward slashes to be compatible
> with
> non-Windows OSes.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ard Biesheuvel
> ---
>
Thanks for the rework.
(We should probably move that broken-out function to ArmPkg at some point.)
For the series:
Reviewed-by: Leif Lindholm
Pushed as b0bb325f20..0a7d8e7d93.
On Mon, Jan 28, 2019 at 10:45:10AM +0100, Marcin Wojtas wrote:
> Hi,
>
> The third version of the patchset moves the
Reviewed-by: Ryszard Knop
On Wed, 2018-11-14 at 18:33 -0800, ard.biesheuvela wrote:
> Drop some variables that are defined, assigned but never referenced.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ard Biesheuvel
> ---
> IntelUndiPkg/XGigUndiDxe/Decode.c
> On Jan 30, 2019, at 8:05 AM, Ryszard Knop
> wrote:
>
> Hmm, is there a list/something I can generate to see which globals
> build tools emit? There are some more variables I'd happily get rid
> of, eg if I could drop gSystemTable and others.
>
Ryszard,
You need to use libs by including
Hi,
I think this is maybe the 3rd or 4th iteration of the patch. That's OK,
but if you don't add v2, v3, v4 identifies to the subject prefix, such
as [PATCH v2], [PATCH v3] etc, then it's too difficult to follow what
one should review vs. what is obsolete.
Anyway, I think this version is good:
Reviewed-by: Ryszard Knop
On Wed, 2018-11-14 at 18:33 -0800, ard.biesheuvela wrote:
> Prefix the existing MSFT-only build option overrides with MSFT: and
> create the GCC: counterparts so we can build this code with GCC as
> well.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
>
Reviewed-by: Ryszard Knop
On Wed, 2018-11-14 at 18:33 -0800, ard.biesheuvela wrote:
> Unlike Visual Studio, GCC does not permit implicit conversion between
> a pointer-to-void-pointer and pointer to a typed pointer. So add the
> explicit casts where necessary.
>
> Contributed-under: TianoCore
On Wed, 30 Jan 2019 at 17:05, Ryszard Knop wrote:
>
> Hmm, is there a list/something I can generate to see which globals
> build tools emit? There are some more variables I'd happily get rid
> of, eg if I could drop gSystemTable and others.
>
You can look at the contents of the various AutoGen.h
Reviewed-by: Ryszard Knop
On Wed, 2018-11-14 at 18:33 -0800, ard.biesheuvela wrote:
> The Data4 member of the GUID/EFI_GUID struct type is an array of
> UINT8, so literals require two sets of { } braces. Add them where
> missing.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
>
Reviewed-by: Ryszard Knop
On Wed, 2018-11-14 at 18:33 -0800, ard.biesheuvela wrote:
> Use intermediate (UINTN) casts when casting pointers to UINT64.
> This is needed to be able to build this code for 32-bit architectures
> such as ARM or IA32.
>
> Contributed-under: TianoCore Contribution
Reviewed-by: Ryszard Knop
On Wed, 2018-11-14 at 18:33 -0800, ard.biesheuvela wrote:
> Taking the address of a cast expression is not permitted in C.
> Instead,
> take the address of the variable, and cast the pointer to the desired
> pointer type.
>
> Contributed-under: TianoCore Contribution
Hmm, is there a list/something I can generate to see which globals
build tools emit? There are some more variables I'd happily get rid
of, eg if I could drop gSystemTable and others.
Reviewed-by: Ryszard Knop
On Wed, 2018-11-14 at 18:33 -0800, ard.biesheuvela wrote:
> Remove duplicate
Expose the SoC's RNG peripheral via the EFI_RNG_PROTOCOL.
This is used by Linux to seed the KASLR routines.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ard Biesheuvel
---
Silicon/Broadcom/Bcm283x/Drivers/RngDxe/RngDxe.c | 204
Hi Pete,
I will only have minor comments on this set, but I'll start with this
documentation.
On Tue, Jan 29, 2019 at 04:26:52PM +, Pete Batard wrote:
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Pete Batard
> ---
> Platform/Raspberry/Pi3/Readme.md | 259
On Wed, 30 Jan 2019 at 20:42, Leif Lindholm wrote:
>
> On Wed, Jan 30, 2019 at 08:38:19PM +0100, Ard Biesheuvel wrote:
> > On Tue, 29 Jan 2019 at 22:10, Pete Batard wrote:
> > >
> > > On 2019.01.29 17:40, Ard Biesheuvel wrote:
> > > > I managed to build and run a RELEASE image, and I must say,
On Wed, Jan 30, 2019 at 09:59:34PM +, Leif Lindholm wrote:
> Hi Pete,
>
> I have two annoying pieces of feedback that apply to the whole set.
>
> Firstly, I would really appreciate if we could have some sort of
> commit messages rather than just subject lines.
> So, for ACPI, mention the
Hi Richard,
It is possible to update C code to prevent the use of compiler
intrinsic functions. This is what we have done for EDK II modules
that are built for both IA32 and X64.
The one exception is the use of OpenSSL. We prefer to use that
project "as is" as a git submodule, so modifying the
On Wed, Jan 30, 2019 at 08:38:19PM +0100, Ard Biesheuvel wrote:
> On Tue, 29 Jan 2019 at 22:10, Pete Batard wrote:
> >
> > On 2019.01.29 17:40, Ard Biesheuvel wrote:
> > > I managed to build and run a RELEASE image, and I must say, I'm
> > > impressed. It works really well, and looks really slick
On Tue, 29 Jan 2019 at 22:10, Pete Batard wrote:
>
> On 2019.01.29 17:40, Ard Biesheuvel wrote:
> > I managed to build and run a RELEASE image, and I must say, I'm
> > impressed. It works really well, and looks really slick too. Thanks a
> > lot for taking the time to upstream this, it makes the
First of all - this is something I would like to see contributed
directly to edk2 EmbeddedPkg. It's something me and Ard have discussed
adding at some point, but never getting around to.
I would also like to look into whether we could replace
PcdBootEpochSeconds with a -DBUILD_EPOCH=`date +%s`
Hi Pete,
I have two annoying pieces of feedback that apply to the whole set.
Firstly, I would really appreciate if we could have some sort of
commit messages rather than just subject lines.
So, for ACPI, mention the provenance and limitations.
For SMBIOS, version supported and any relevant
On 1/31/2019 1:00 PM, Digant H Solanki wrote:
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1454
Based on latest IGD OpRegion Spec, IGD_OPREGION_MBOX3 needs to be updated with
two new members : Physical Address of Raw VBT Data (RVDA) and Size of Raw VBT
Data (RVDS)
Contributed-under:
On 1/31/2019 2:55 PM, Ni, Ray wrote:
On 1/31/2019 1:00 PM, Digant H Solanki wrote:
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1454
Based on latest IGD OpRegion Spec, IGD_OPREGION_MBOX3 needs to be
updated with two new members : Physical Address of Raw VBT Data (RVDA)
and Size of Raw
From: Mike Turner
Introduce public functions Base64Encode and Base64Decode.
https://bugzilla.tianocore.org/show_bug.cgi?id=1370
v2:1.Remove some white space.
2.Add unit test with test vectors in RFC 4648.
https://github.com/shenglei10/edk2/tree/encode_test
On Thu, 31 Jan 2019 at 08:09, Ni, Ray wrote:
>
> On 1/29/2019 10:21 PM, Leif Lindholm wrote:
> > Hi Ray,
> >
> > First of all, thank you for restarting this discussion, and putting
> > the effort in for a POC.
> >
> > On Tue, Jan 29, 2019 at 05:59:35AM +, Ni, Ray wrote:
> >> Hello,
> >> I'd
Hi Maggie,
Thanks for your contribution!
Reviewed-by: Eric Dong
And pushed: 8a9301cdd75439e781754014f514fa06d99140d1
Thanks,
Eric
> -Original Message-
> From: Chu, Maggie
> Sent: Wednesday, January 30, 2019 2:41 PM
> To: edk2-devel@lists.01.org
> Cc: Zhang, Chao B ; Yao, Jiewen
> ;
Hao,
You could re-use the structure definition in AtaPassThru protocol.
For example: EFI_ATA_PASS_THRU_MODE v.s. EDKII_PEI_ATA_PASS_THRU_MODE
I see more duplicated structure definitions. We can avoid them.
Thanks,
Ray
> -Original Message-
> From: Wu, Hao A
> Sent: Thursday, January 31,
> -Original Message-
> From: Ni, Ray
> Sent: Thursday, January 31, 2019 11:35 AM
> To: Wu, Hao A; edk2-devel@lists.01.org
> Cc: Wang, Jian J; Dong, Eric
> Subject: RE: [PATCH v2 06/12] MdeModulePkg/NvmExpressPei: Add logic to
> produce SSC PPI
>
>
>
> > -Original Message-
> >
Based on KabylakeOpenBoardPkg from the following branch:
https://github.com/tianocore/edk2-platforms/tree/devel-MinPlatform
Library instances shared across Clevo board instances.
* BaseGpioExpanderLib - Support for the TCA6424 IO expander.
* PeiI2cAccessLib - Provides I2C read and write
Based on KabylakeOpenBoardPkg from the following branch:
https://github.com/tianocore/edk2-platforms/tree/devel-MinPlatform
Adds the DSC and build files necessary to build the N1xxWU Clevo
board instance.
The board follows the same build procedure as other OpenBoardPkg
instances in
Based on KabylakeOpenBoardPkg from the following branch:
https://github.com/tianocore/edk2-platforms/tree/devel-MinPlatform
Header files for the N1XXWU Clevo board instance.
* PeiPchPolicyUpdate.h - Shared interfaces and includes used for
Platform Controller Hub (PCH) initialization in
Based on KabylakeOpenBoardPkg from the following branch:
https://github.com/tianocore/edk2-platforms/tree/devel-MinPlatform
Create the ClevoOpenBoardPkg to provide an initial board package
for Clevo boards. The ClevoOpenBoardPkg is intended to contain a
series of specific Clevo board instances
Uses DEBUG_INFO instead of EFI_D_INFO in all ClevoOpenBoardPkg files.
Cc: Hao Wu
Cc: Liming Gao
Cc: Jiewen Yao
Cc: Michael D Kinney
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Michael Kubacki
---
.../ClevoOpenBoardPkg/N1xxWU/Library/BoardInitLib/PeiN1xxWUDetect.c
This series adds a new board package in Platform/Intel for Clevo
boards. This provides a board implementation for use with the
MinPlatformPkg. Currently, this is largely a copy of
KabylakeOpenBoardPkg with the name refactored. It is intended to
serve as a base for future community development.
A
Chen,
I just noticed that there's another patch series in which a new interface
CharToUpper()
is introduced in BaseLib which can be used to replace your local equivalent one
UpperCaseString(). I would suggest to hold your patch for a while and use the
new
interface instead once that patch
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Chen
> A Chen
> Sent: Tuesday, January 29, 2019 1:28 PM
> To: edk2-devel@lists.01.org
> Subject: [edk2] [PATCH v2 0/3] FatPkg/GPT: Introduce GPT patch v3
>
> No function change, fix code style
Push at a824c7ebde0a431413329049252b8c1d3770de82
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Gao,
> Liming
> Sent: Thursday, January 31, 2019 11:31 AM
> To: Bi, Dandan ; Hsueh, Hong-chihX
> ; edk2-devel@lists.01.org
> Cc: Kinney, Michael
Hi Jian.
The interface CharToUpper() is used to convert just one character, But the
UpperCaseString is used to convert a string.
I think it's no need to call CharToUpper repeatedly in UpperCaseString function
to convert a string.
Regards,
Chen
-Original Message-
From: Wang, Jian J
> -Original Message-
> From: Ni, Ray
> Sent: Wednesday, January 30, 2019 5:49 PM
> To: Zhang, Shenglei ; edk2-devel@lists.01.org
> Cc: Kinney, Michael D ; Mike Turner
> ; Gao, Liming
> Subject: Re: [edk2] [PATCH v4] MdePkg/BaseLib: Add Base64Encode() and
> Base64Decode()
>
> Comments
On 1/29/2019 10:21 PM, Leif Lindholm wrote:
Hi Ray,
First of all, thank you for restarting this discussion, and putting
the effort in for a POC.
On Tue, Jan 29, 2019 at 05:59:35AM +, Ni, Ray wrote:
Hello,
I'd like to propose to split today's BIG packages in following ways:
Hi Leif,
Thanks a lot. While at it - do you think ArmPkg/Include/Library/ArmLib.h
/ ArmPkg/Library/ArmLib/ArmLib.c would be a proper place for it?
Best regards,
Marcin
śr., 30 sty 2019 o 17:47 Leif Lindholm
napisał(a):
> Thanks for the rework.
>
> (We should probably move that broken-out
Karunakar:
There is one BZ https://bugzilla.tianocore.org/show_bug.cgi?id=1446 on
Feature Flag expression in INF. INF spec has listed the syntax for it. But,
BaseTools doesn't support it now. If you have the similar request, please add
the information in BZ (including the usage model and
Even ECC doesn't complain, I still suggest to change
Encoding_table/Decoding_table to a proper name, e.g.:
EncodingTable/DecodingTable.
With the rename applied in V5 patch,
Reviewed-by: Ray Ni
___
edk2-devel mailing list
edk2-devel@lists.01.org
On 1/31/2019 10:34 AM, Chen A Chen wrote:
BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=1482
UEFI Spec define this definition to support Capsule-on-Disk.
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Zhang Chao B
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Chen A
> -Original Message-
> From: Wu, Hao A
> Sent: Thursday, January 31, 2019 10:49 AM
> To: edk2-devel@lists.01.org
> Cc: Wu, Hao A ; Wang, Jian J ;
> Ni, Ray ; Dong, Eric
> Subject: [PATCH v2 07/12] MdeModulePkg/NvmExpressPei: Consume
> S3StorageDeviceInitList LockBox
>
>
> -Original Message-
> From: Ni, Ray
> Sent: Thursday, January 31, 2019 11:23 AM
> To: Wu, Hao A; edk2-devel@lists.01.org
> Cc: Wang, Jian J; Dong, Eric
> Subject: RE: [PATCH v2 02/12] MdeModulePkg: Add definitions for EDKII PEI
> ATA PassThru PPI
>
> Hao,
> You could re-use the structure
On 1/31/2019 10:48 AM, Hao Wu wrote:
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1409
This commit will add the support to enlarge a LockBox when using the
LockBoxLib API UpdateLockBox().
Please note that the new support will ONLY work for LockBox with attribute
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1454
Based on latest IGD OpRegion Spec, IGD_OPREGION_MBOX3 needs to be updated with
two new members : Physical Address of Raw VBT Data (RVDA) and Size of Raw VBT
Data (RVDS)
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by:
Reviewed-by: Liming Gao
> -Original Message-
> From: Feng, Bob C
> Sent: Wednesday, January 30, 2019 5:13 PM
> To: edk2-devel@lists.01.org
> Cc: Feng, Bob C ; Gao, Liming
> Subject: [Patch] BaseTools: Fixed incorrect line number in PcdValueInit.c
>
> BZ:
> -Original Message-
> From: Ni, Ray
> Sent: Thursday, January 31, 2019 11:45 AM
> To: Wu, Hao A; edk2-devel@lists.01.org
> Cc: Wang, Jian J; Dong, Eric
> Subject: RE: [PATCH v2 07/12] MdeModulePkg/NvmExpressPei: Consume
> S3StorageDeviceInitList LockBox
>
>
>
> > -Original
On 1/31/2019 10:48 AM, Hao Wu wrote:
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1409
This commit will add the AHCI mode ATA device support in the PEI phase.
More specifically, the newly add AhciPei driver will consume the ATA AHCI
host controller PPI for ATA controllers working under
Reviewed-by: Bi Dandan
Thanks,
Dandan
> -Original Message-
> From: Hsueh, Hong-chihX
> Sent: Wednesday, January 30, 2019 9:20 AM
> To: edk2-devel@lists.01.org
> Cc: Kinney, Michael D ; Gao, Liming
> ; Bi, Dandan ; Laszlo Ersek
>
> Subject: [PATCH] MdePkg/BasePeCoffLib: skip runtime
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1409
This commit will add the definitions for ATA AHCI host controller PPI. The
purpose of the PPI in to provide:
* MMIO base address
* Controller identification information (DevicePath)
for ATA host controllers working under AHCI mode.
Cc:
The series is also available at:
https://github.com/hwu25/edk2/tree/opal_remodel_v2
V2 changes:
For patch 8, the new series removes the codes to produce the Block IO PPIs
from the AhciPei driver.
The task to produce the Block IO services is out of the scope of BZ-1409
(actually covered by
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1409
For the NvmExpressPei driver, this commit will add codes to produce the
Storage Security Command PPI if the underlying NVM Express controller
supports the Security Send and Security Receive commands.
Cc: Jian J Wang
Cc: Ray Ni
Cc: Eric
This commit is out of the scope for BZ-1409. The commit will remove the
call of RegisterForShadow() at the entry point of the driver. By doing so,
the driver is now possible to be executed without being re-loaded into
permanent memory.
Thus, this commit will update the NvmExpressPei driver to
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1409
For the NvmExpressPei driver, this commit will update the driver to
consume the S3StorageDeviceInitList LockBox in S3 phase. The purpose is to
perform an on-demand (partial) NVM Express device
enumeration/initialization to benefit the S3
This commit is out of the scope for BZ-1409. It is a coding style
refinement for the SmmLockBoxLib.
More specifically, the commit will remove all the debug message display
level macros starting with 'EFI_D_' and replace them with macros starting
with 'DEBUG_'.
Cc: Jian J Wang
Cc: Ray Ni
Cc:
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1409
This commit will add the definitions for EDKII PEI ATA PassThru PPI. This
PPI will provide services that allow ATA commands to be sent to ATA
devices attached to an ATA controller in the PEI phase.
More specifically, the PPI will provide
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1409
This commit will add the definitions for Storage Security Command (SSC)
PPI. This PPI will be be used to abstract mass storage devices to allow
code running in the PEI phase to send security protocol commands to mass
storage devices without
This commit is out of the scope for BZ-1409. It is a refinement for the
PEI library instance within SmmLockBoxLib.
For the below ASSERT statement within function RestoreLockBox():
Status = SmmCommunicationPpi->Communicate (
SmmCommunicationPpi,
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1409
This commit will add the support to enlarge a LockBox when using the
LockBoxLib API UpdateLockBox().
Please note that the new support will ONLY work for LockBox with attribute
LOCK_BOX_ATTRIBUTE_RESTORE_IN_S3_ONLY set.
The functional
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1409
This commit will add the GUID definitions for LockBox which is used to
save a list of storage devices that need to get initialized during the S3
resume.
The content of the LockBox will be a DevicePath structure that contains
zero or more
Reviewed-by: Ray Ni
> -Original Message-
> From: Wu, Hao A
> Sent: Thursday, January 31, 2019 10:49 AM
> To: edk2-devel@lists.01.org
> Cc: Wu, Hao A ; Wang, Jian J ;
> Ni, Ray ; Dong, Eric
> Subject: [PATCH v2 03/12] MdeModulePkg: Add definitions for Storage
> Security Command PPI
>
>
1 - 100 of 120 matches
Mail list logo
