Re: [edk2] [Patch] MdePkg: update head files to meet UEFI 2.7

2017-06-06 Thread Fu, Siyuan
Reviewed-by: Fu Siyuan -Original Message- From: Wang, Fan Sent: 2017年6月6日 18:52 To: edk2-devel@lists.01.org Cc: Ye, Ting ; Fu, Siyuan ; Wang, Fan Subject: [Patch] MdePkg: update head files to meet UEFI 2.7 This patch is used to update supplicant.h and wifi2.h to meet UEFI 2.7 defini

[edk2] [PATCH] ShellPkg: Remove unnecessary Readme.txt

2017-06-06 Thread Ruiyu Ni
The Readme.txt contains instructions about how to integrate Shell into Nt32. Actually Nt32 already contains a macro USE_OLD_SHELL to choose OLD or NEW Shell. So remove this txt file. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ruiyu Ni Cc: Jaben Carsey --- ShellPkg/R

Re: [edk2] [PATCH] MdePkg SmmIoLib: Use NULL pointer check instead of useless Status check

2017-06-06 Thread Udit Kumar
Hi Star I restricted myself into debug mode only , while looking at patch . Regards Udit > -Original Message- > From: Zeng, Star [mailto:star.z...@intel.com] > Sent: Wednesday, June 07, 2017 6:41 AM > To: Udit Kumar ; edk2-devel@lists.01.org > Cc: Yao, Jiewen ; Zeng, Star > Subject: RE:

[edk2] HTTPS boot support questions

2017-06-06 Thread Santhapur Naveen
Hello, I have some questions regarding HTTPS Boot and are as below. 1. If I'm using iPXE port 80 to communicate with server because of firewall concern. Does https boot happen via the same 80 port? 2. Does it support WinPE/Windows 10 OS installation? If yes, is there any open document availabl

[edk2] [Patch][edk2-platforms/devel-MinnowBoard3-UDK2017] VBT table change.

2017-06-06 Thread zwei4
Disabling “Onboard LSPCON for HDMI 2.0” in VBT table Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: zwei4 --- .../Common/Binaries/Vbt/VbtBxtMipi.bin| Bin 5632 -> 5632 bytes 1 file changed, 0 insertions(+), 0 deletions(-) diff --git a/Platform/BroxtonPla

[edk2] [PATCH] MdeModulePkg/NvmExpressDxe: Handle timeout for blocking PassThru req

2017-06-06 Thread Hao Wu
https://bugzilla.tianocore.org/show_bug.cgi?id=433 When a blocking NVMe PassThru request experiences timeout, the current codes in function NvmExpressPassThru() do not abort the timeout request while advancing synchronous Submission Queue tail. Therefore, it is possible to submit a new blocking Pa

Re: [edk2] [Patch] BaseTools: Fix the bug use same FMP_PAYLOAD in different capsule file

2017-06-06 Thread Gao, Liming
Reviewed-by: Liming Gao >-Original Message- >From: Zhu, Yonghong >Sent: Tuesday, June 06, 2017 9:52 PM >To: edk2-devel@lists.01.org >Cc: Gao, Liming >Subject: [Patch] BaseTools: Fix the bug use same FMP_PAYLOAD in different >capsule file > >Fix the bug that use same FMP_PAYLOAD in differ

Re: [edk2] [Patch] BaseTools: Fix incremental build failure that override file be removed

2017-06-06 Thread Gao, Liming
Reviewed-by: Liming Gao >-Original Message- >From: Zhu, Yonghong >Sent: Tuesday, June 06, 2017 9:53 PM >To: edk2-devel@lists.01.org >Cc: Gao, Liming >Subject: [Patch] BaseTools: Fix incremental build failure that override file be >removed > >Fix a Incremental build failure. The case is:

Re: [edk2] UEFI SCT2.5A cannot run with exception

2017-06-06 Thread Jin, Eric
Hi Xiaofeng, Could you please resend the email to u...@uefi.org for this question? I mean UEFI SCT is not the scope of the EDK2 community. Please don't forget to attach the log file. I don't see it or filtered by system. Thanks. Best Regards Eric -Original Message- From: edk2-devel [m

Re: [edk2] Issue in ConvertHandleIndexToHandle and ConvertHandleToHandleIndex

2017-06-06 Thread GN Keshava
Thanks a lot for the detailed answer, Jaben. Regards, Keshava On Wed, Jun 7, 2017, 2:36 AM Carsey, Jaben wrote: > The problem is how the library assigns “handle indexes”… it just keeps a > list of the ones it has given out and only supports those. > > > > Your application is linked to the libra

[edk2] UEFI SCT2.5A cannot run with exception

2017-06-06 Thread wang xiaofeng
Hi , Thanks all for your kind help. I just update SCT from 2.4B to 2.5A, WIth the same platform, 2.4B cannot be installed on EDK2 shell , we have to switch to EDK1 shell and then switch back. 2.4B can run on edk2shell. 2.5A aslo cannot be installed on EDK2 shell , we have to switch to EDK1 sh

Re: [edk2] [PATCH] MdePkg SmmIoLib: Use NULL pointer check instead of useless Status check

2017-06-06 Thread Zeng, Star
Hi Udit, What does "If mSmmIoLibGcdMemSpace is NULL then if condition is not reachable." mean? ASSERT_EFI_ERROR macro only effects at DEBUG mode, and the if condition is for error handling. Thanks, Star -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Be

Re: [edk2] [PATCH] ShellPkg/parse: Handle Unicode stream from pipe correctly

2017-06-06 Thread Shah, Tapan
Reviewed-by: Tapan Shah -Original Message- From: Ni, Ruiyu [mailto:ruiyu...@intel.com] Sent: Tuesday, June 06, 2017 3:44 AM To: Ni, Ruiyu ; edk2-devel@lists.01.org Cc: Shah, Tapan Subject: RE: [edk2] [PATCH] ShellPkg/parse: Handle Unicode stream from pipe correctly Including Tapan. T

Re: [edk2] [PATCH] ShellPkg/alias: Return status for alias deletion

2017-06-06 Thread Shah, Tapan
Instead of using STR_GEN_ERR_UK here, it would be better to define a new string token as "alias: '' does not exist." > >> + ShellPrintHiiEx(-1, -1, NULL, STRING_TOKEN (STR_GEN_ERR_UK), > >> gShellLevel3HiiHandle, L"alias", Status); Reviewed-by: Tapan Shah -Original Message- F

Re: [edk2] [PATCH] ShellPkg/alias: Return status for alias deletion

2017-06-06 Thread Carsey, Jaben
I am good with more clear error information coming to the user. Reviewed-by: Jaben Carsey > -Original Message- > From: Ni, Ruiyu > Sent: Tuesday, June 06, 2017 2:26 PM > To: Ni, Ruiyu ; edk2-devel@lists.01.org > Cc: Tapan Shah ; Carsey, Jaben > > Subject: Re: [edk2] [PATCH] ShellPkg/alia

Re: [edk2] [PATCH] ShellPkg/alias: Return status for alias deletion

2017-06-06 Thread Ni, Ruiyu
Including Jaben for review. Send from mobile phone > 在 2017年6月6日,下午4:43,Ni, Ruiyu 写道: > > Including Tapan. > > Thanks/Ray > >> -Original Message- >> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ruiyu >> Ni >> Sent: Tuesday, June 6, 2017 4:29 PM >> To: edk2-de

Re: [edk2] [Patch V2] UefiCpuPkg/MpInitLib: Fix X64 XCODE5/NASM compatibility issues

2017-06-06 Thread hpa
On June 6, 2017 2:15:08 PM PDT, Andrew Fish wrote: > >> On Jun 6, 2017, at 2:05 PM, h...@zytor.com wrote: >> >> On June 6, 2017 1:49:34 PM PDT, Andrew Fish wrote: >>> On Jun 6, 2017, at 12:41 PM, H. Peter Anvin wrote: On 05/22/17 19:08, Fan, Jeff wrote: > > diff --git

Re: [edk2] [Patch V2] UefiCpuPkg/MpInitLib: Fix X64 XCODE5/NASM compatibility issues

2017-06-06 Thread Andrew Fish
> On Jun 6, 2017, at 2:05 PM, h...@zytor.com wrote: > > On June 6, 2017 1:49:34 PM PDT, Andrew Fish wrote: >> >>> On Jun 6, 2017, at 12:41 PM, H. Peter Anvin wrote: >>> >>> On 05/22/17 19:08, Fan, Jeff wrote: diff --git a/UefiCpuPkg/Library/MpInitLib/X64/MpFuncs.nasm >> b/UefiCpuPk

Re: [edk2] [Patch V2] UefiCpuPkg/MpInitLib: Fix X64 XCODE5/NASM compatibility issues

2017-06-06 Thread hpa
On June 6, 2017 1:49:34 PM PDT, Andrew Fish wrote: > >> On Jun 6, 2017, at 12:41 PM, H. Peter Anvin wrote: >> >> On 05/22/17 19:08, Fan, Jeff wrote: >>> >>> diff --git a/UefiCpuPkg/Library/MpInitLib/X64/MpFuncs.nasm >b/UefiCpuPkg/Library/MpInitLib/X64/MpFuncs.nasm >>> index fa54d01..0b14a53 100

Re: [edk2] Issue in ConvertHandleIndexToHandle and ConvertHandleToHandleIndex

2017-06-06 Thread Carsey, Jaben
The problem is how the library assigns “handle indexes”… it just keeps a list of the ones it has given out and only supports those. Your application is linked to the library and is keeping it’s own version of this list. So when you request a handle index, it gives you one… but your version of

Re: [edk2] [Patch V2] UefiCpuPkg/MpInitLib: Fix X64 XCODE5/NASM compatibility issues

2017-06-06 Thread Andrew Fish
> On Jun 6, 2017, at 12:41 PM, H. Peter Anvin wrote: > > On 05/22/17 19:08, Fan, Jeff wrote: >> >> diff --git a/UefiCpuPkg/Library/MpInitLib/X64/MpFuncs.nasm >> b/UefiCpuPkg/Library/MpInitLib/X64/MpFuncs.nasm >> index fa54d01..0b14a53 100644 >> --- a/UefiCpuPkg/Library/MpInitLib/X64/MpFuncs.na

Re: [edk2] [Patch V2] UefiCpuPkg/MpInitLib: Fix X64 XCODE5/NASM compatibility issues

2017-06-06 Thread H. Peter Anvin
On 05/22/17 19:08, Fan, Jeff wrote: > > diff --git a/UefiCpuPkg/Library/MpInitLib/X64/MpFuncs.nasm > b/UefiCpuPkg/Library/MpInitLib/X64/MpFuncs.nasm > index fa54d01..0b14a53 100644 > --- a/UefiCpuPkg/Library/MpInitLib/X64/MpFuncs.nasm > +++ b/UefiCpuPkg/Library/MpInitLib/X64/MpFuncs.nasm > @@ -1

Re: [edk2] [PATCH v6 00/17] x86: Secure Encrypted Virtualization (AMD)

2017-06-06 Thread Duran, Leo
Lazlo, et al, Calling back from DxeIpl after page tables are created seems like a major hack: - Duplicates logic already in GCD - Would need to pass the page-table root pointer So, as stated earlier, I'm favor of: using APRIORI in the interim, and reviewing GCD to support a more correct framew

Re: [edk2] [PATCH v6 00/17] x86: Secure Encrypted Virtualization (AMD)

2017-06-06 Thread Laszlo Ersek
On 06/06/17 17:54, Duran, Leo wrote: > Thank you all for the feedback… The summary of what I’m hearing is: > > 1) For now, use APRIORI in the stand-alone (SEV) driver in OvmfPkg > (albeit not as clean as desired, but least intrusive solution.). > > 2) Let’s revisit the existing GCD imp

Re: [edk2] [PATCH v6 00/17] x86: Secure Encrypted Virtualization (AMD)

2017-06-06 Thread Laszlo Ersek
On 06/06/17 17:43, Yao, Jiewen wrote: > Hi Andrew > Yes, I agree. If we could figure out a cleaner way to resolve the problem, we > should use the cleaner way. > > > > If we really really do not want to use a priori for AmdSec, we can > let AmdSec to publish a special protocol, and let the driv

Re: [edk2] [PATCH v6 00/17] x86: Secure Encrypted Virtualization (AMD)

2017-06-06 Thread Laszlo Ersek
On 06/06/17 16:54, Yao, Jiewen wrote: > Hi > It takes me some time to read all email below. I believe all of us have a > clean understanding on what problem we have now and the possible solutions to > clear C bit are below > > 1) In DxeIpl, when it builds page table. > > 2) In DxeCo

Re: [edk2] [PATCH 1/1] OvmfPkg/AcpiPlatformDxe: alloc blobs from 64-bit space unless restricted

2017-06-06 Thread Laszlo Ersek
On 06/05/17 19:47, Jordan Justen wrote: > On 2017-06-03 08:42:03, Laszlo Ersek wrote: >> ... by narrower than 8-byte ADD_POINTER references. >> >> Introduce the CollectRestrictedAllocations() function, which iterates over > > How about Collect32BitRestrictedAllocations and similar treatment for >

Re: [edk2] allocation zone extensions for the firmware linker/loader

2017-06-06 Thread Laszlo Ersek
On 06/05/17 18:02, Michael S. Tsirkin wrote: > On Sat, Jun 03, 2017 at 09:36:23AM +0200, Laszlo Ersek wrote: >> On 06/02/17 17:45, Laszlo Ersek wrote: >> >>> The patches can cause linker/loader breakage when old firmware is booted >>> on new QEMU. However, that's no problem (it's nothing new), the

Re: [edk2] [Qemu-devel] allocation zone extensions for the firmware linker/loader

2017-06-06 Thread Laszlo Ersek
On 06/05/17 11:54, Igor Mammedov wrote: > BTW: > how OVMF would deal with booting 32-bit OS if it would allocate > ACPI tables above 4Gb? > For BIOS on baremetal I'd expect some switch in settings, something > like "Disable 32-bit OS support". In order to answer your question exhaustively, I'd ha

Re: [edk2] [PATCH 1/2] EmulatorPkg/Unix/Host: Add GCC5 CC/DLINK commands (for GCC >= 5)

2017-06-06 Thread Laszlo Ersek
On 06/06/17 13:10, Ard Biesheuvel wrote: > On 5 June 2017 at 18:33, Jordan Justen wrote: >> On 2017-06-02 14:48:14, Laszlo Ersek wrote: >>> On 06/02/17 11:03, Ard Biesheuvel wrote: On 1 June 2017 at 23:56, Jordan Justen wrote: A commit log would be nice >>> >>> I agree. FWIW: >> >>

Re: [edk2] Issue in ConvertHandleIndexToHandle and ConvertHandleToHandleIndex

2017-06-06 Thread GN Keshava
Thanks Jaben. I expected this answer. :) Definitely I can't do that as of now. But do you think this would cause mismatch between the handle index that i get in my application? The handle index I'm getting is differing, even if the handle value is same. And, could you suggest any other ways to f

Re: [edk2] Issue in ConvertHandleIndexToHandle and ConvertHandleToHandleIndex

2017-06-06 Thread Carsey, Jaben
In general, you should really try to avoid it. it means you have to build and distribute a complete shell instead of a single application. There are some shell commands that simply cannot function without information not available via the shell protocol. If you find you need information, then

Re: [edk2] Issue in ConvertHandleIndexToHandle and ConvertHandleToHandleIndex

2017-06-06 Thread GN Keshava
Hi Jaben, Thanks for the reply. I understand that the sermode command is in shell, and it's sharing information through libraries. Can you tell me more about the library requirement of module to be linked into shell? How i can do this? Thanks again. Regards, Keshava On Tue, Jun 6, 2017, 9

[edk2] [PATCH v3 0/2] UefiCpuPkg: Add CPUID support for AMD.

2017-06-06 Thread Leo Duran
This patch-set requires and builds upon this submission: https://lists.01.org/pipermail/edk2-devel/2017-May/010867.html Changes since v2: - Account for actual thread count (e.g., SMT disabled). Changes since v1: - Revert to (MaxCoresPerPackage = 1) when CPUID is not explicit. Leo Duran (2): Ue

[edk2] [PATCH v3 1/2] UefiCpuPkg: Add CPUID definitions for AMD.

2017-06-06 Thread Leo Duran
Cc: Jordan Justen Cc: Jeff Fan Cc: Liming Gao Cc: Brijesh Singh Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Leo Duran --- UefiCpuPkg/Include/Register/Amd/Cpuid.h | 574 +++- 1 file changed, 565 insertions(+), 9 deletions(-) diff --git a/

Re: [edk2] [PATCH v6 00/17] x86: Secure Encrypted Virtualization (AMD)

2017-06-06 Thread Duran, Leo
Thank you all for the feedback… The summary of what I’m hearing is: 1) For now, use APRIORI in the stand-alone (SEV) driver in OvmfPkg (albeit not as clean as desired, but least intrusive solution.). 2) Let’s revisit the existing GCD implementation to allow for cleaner of features lik

Re: [edk2] Issue in ConvertHandleIndexToHandle and ConvertHandleToHandleIndex

2017-06-06 Thread Carsey, Jaben
That library may require the module to be linked into the shell. Remember that the sermode command is actually in the same binary as the shell and the shell and the command are sharing information through libraries. > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@list

Re: [edk2] [PATCH v6 00/17] x86: Secure Encrypted Virtualization (AMD)

2017-06-06 Thread Yao, Jiewen
Hi Andrew Yes, I agree. If we could figure out a cleaner way to resolve the problem, we should use the cleaner way. If we really really do not want to use a priori for AmdSec, we can let AmdSec to publish a special protocol, and let the driver depend that protocol, if this driver need add MMI

Re: [edk2] [PATCH] ShellPkg/parse: Handle Unicode stream from pipe correctly

2017-06-06 Thread Carsey, Jaben
I like removing the special local version of the function. Reviewed-by: Jaben Carsey > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ni, > Ruiyu > Sent: Tuesday, June 06, 2017 1:44 AM > To: Ni, Ruiyu ; edk2-devel@lists.01.org > Subject: Re: [e

Re: [edk2] [PATCH v6 00/17] x86: Secure Encrypted Virtualization (AMD)

2017-06-06 Thread Andrew Fish
> On Jun 6, 2017, at 7:54 AM, Yao, Jiewen wrote: > > Hi > It takes me some time to read all email below. I believe all of us have a > clean understanding on what problem we have now and the possible solutions to > clear C bit are below > > 1) In DxeIpl, when it builds page table. > > 2

Re: [edk2] [PATCH v6 00/17] x86: Secure Encrypted Virtualization (AMD)

2017-06-06 Thread Yao, Jiewen
Hi It takes me some time to read all email below. I believe all of us have a clean understanding on what problem we have now and the possible solutions to clear C bit are below 1) In DxeIpl, when it builds page table. 2) In DxeCore a) By use CpuArch b) By use page

[edk2] [Patch] BaseTools: Fix the bug use same FMP_PAYLOAD in different capsule file

2017-06-06 Thread Yonghong Zhu
Fix the bug that use same FMP_PAYLOAD in different capsule file. Because in previous FMP generation, the FMP already be generated, so we don't need to regenerate again. Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Yonghong Zhu --- BaseTools/Source/Python

[edk2] [Patch] BaseTools: Fix incremental build failure that override file be removed

2017-06-06 Thread Yonghong Zhu
Fix a Incremental build failure. The case is: Both A and B package will include a same .h file, and in the driver's packages section, A package is listed before B package, so we will use the .h file in the A package and build success, then we directly delete the .h file in package A, it cause incre

Re: [edk2] [staging/cadence-aarch64 PATCH v2 6/6] CadencePkg: Add .dsc, .fdf and .dec files for Cadence CSP platform.

2017-06-06 Thread Leif Lindholm
On Mon, Jun 05, 2017 at 11:50:28AM +0100, Scott Telford wrote: > Add .dsc, .fdf and .dec files for a Cadence CSP platform configured > with a single Cortex-A53, GIC-500, Cadence UART and Cadence PCIe Root > Complex. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Scott

Re: [edk2] [staging/cadence-aarch64 PATCH v2 5/6] CadencePkg: Add ACPI tables for Cadence CSP platform.

2017-06-06 Thread Leif Lindholm
On Mon, Jun 05, 2017 at 03:40:17PM +, Ard Biesheuvel wrote: > On 5 June 2017 at 10:50, Scott Telford wrote: > > Add ACPI tables for Cadence CSP platform configured with a single > > Cortex-A53, GIC-500, Cadence UART and Cadence PCIe Root Complex. > > > > Contributed-under: TianoCore Contributi

Re: [edk2] [PATCH] MdePkg SmmIoLib: Use NULL pointer check instead of useless Status check

2017-06-06 Thread Udit Kumar
Hi Star > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Star > Zeng > Sent: Monday, June 05, 2017 12:11 PM > To: edk2-devel@lists.01.org > Cc: Jiewen Yao ; Star Zeng > Subject: [edk2] [PATCH] MdePkg SmmIoLib: Use NULL pointer check instead of

Re: [edk2] [PATCH 1/2] EmulatorPkg/Unix/Host: Add GCC5 CC/DLINK commands (for GCC >= 5)

2017-06-06 Thread Ard Biesheuvel
On 5 June 2017 at 18:33, Jordan Justen wrote: > On 2017-06-02 14:48:14, Laszlo Ersek wrote: >> On 06/02/17 11:03, Ard Biesheuvel wrote: >> > On 1 June 2017 at 23:56, Jordan Justen wrote: >> > >> > A commit log would be nice >> >> I agree. FWIW: > > How about this? > > EmulatorPkg/Unix/Host: Add G

Re: [edk2] [staging/cadence-aarch64 PATCH v2 4/6] CadencePkg: Add SEC phase implementation for Cadence CSP platform.

2017-06-06 Thread Leif Lindholm
On Mon, Jun 05, 2017 at 11:50:26AM +0100, Scott Telford wrote: > Add SEC phase implementation for Cadence CSP platform configured with > a single Cortex-A53 processor and GIC-500. This appears to be a localised reinstatement of ArmPlatformPkg/Sec/, which was deleted by 9a8f6fb40712938ad562e9a9095d

[edk2] [Patch] MdePkg: update head files to meet UEFI 2.7

2017-06-06 Thread fanwang2
This patch is used to update supplicant.h and wifi2.h to meet UEFI 2.7 definition. Add EfiSupplicant80211PMK field in EFI_SUPPLICANT_DATA_TYPE and change **NetworkDesc to NetworkDesc[1] in EFI_80211_GET_NETWORKS_RESULT. Cc: Ye Ting Cc: Fu Siyuan Contributed-under: TianoCore Contribution Agreemen

[edk2] Issue in ConvertHandleIndexToHandle and ConvertHandleToHandleIndex

2017-06-06 Thread GN Keshava
Hi, Thanks all for your kind help. I'm doing few operations using serial port. So, I've done a small serial driver by referring FTDI code, and I'm accessing this using serialIO from my application. and it was working fine with older EFI shell. Now I'm using the latest UEFI shell. Now It's workin

Re: [edk2] [staging/cadence-aarch64 PATCH v2 2/6] CadencePkg: Add library for Cadence UART.

2017-06-06 Thread Leif Lindholm
On Mon, Jun 05, 2017 at 11:50:24AM +0100, Scott Telford wrote: > Add serial port library to support the Cadence IP6528 UART used in the > Cadence CSP platform. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Scott Telford A few style comments below. > --- > Cadence

Re: [edk2] [PATCH] ShellPkg/alias: Return status for alias deletion

2017-06-06 Thread Ni, Ruiyu
Including Tapan. Thanks/Ray > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ruiyu > Ni > Sent: Tuesday, June 6, 2017 4:29 PM > To: edk2-devel@lists.01.org > Subject: [edk2] [PATCH] ShellPkg/alias: Return status for alias deletion > > Contribu

Re: [edk2] [PATCH] ShellPkg/parse: Handle Unicode stream from pipe correctly

2017-06-06 Thread Ni, Ruiyu
Including Tapan. Thanks/Ray > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ruiyu > Ni > Sent: Tuesday, June 6, 2017 4:29 PM > To: edk2-devel@lists.01.org > Subject: [edk2] [PATCH] ShellPkg/parse: Handle Unicode stream from pipe > correctly >

[edk2] [PATCH] ShellPkg/parse: Handle Unicode stream from pipe correctly

2017-06-06 Thread Ruiyu Ni
The original code expects the Unicode stream from pipe doesn't contains the Unicode BOM. But that's not true. Commit [9ed21946c76e430097e9c4e59b419af928e0cb8c] changes CreateFileInterfaceMem() to add the BOM for Unicode stream. When parse pipe support was firstly added, a private implementation Pa

[edk2] [PATCH] ShellPkg/alias: Return status for alias deletion

2017-06-06 Thread Ruiyu Ni
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ruiyu Ni Cc: Tapan Shah --- ShellPkg/Library/UefiShellLevel3CommandsLib/Alias.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/ShellPkg/Library/UefiShellLevel3CommandsLib/Alias.c b/ShellPkg/L

Re: [edk2] [RFC v3 1/2] BaseTool/VfrCompile: Support Union type in VFR

2017-06-06 Thread Ni, Ruiyu
Reviewed-by: Ruiyu Ni Thanks/Ray > -Original Message- > From: Bi, Dandan > Sent: Tuesday, June 6, 2017 10:58 AM > To: edk2-devel@lists.01.org > Cc: Dong, Eric ; Gao, Liming ; Ni, > Ruiyu > Subject: [RFC v3 1/2] BaseTool/VfrCompile: Support Union type in VFR > > V3: Avoid adding new mem