Looks good to me. Series Reviewed-by: Ye Ting
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Fu Siyuan
Sent: Monday, September 4, 2017 4:07 PM
To: edk2-devel@lists.01.org
Subject: [edk2] [Patch 0/2] Fix bug in IP driver for IpSec protocol notify
Add PcdVTdPolicyPropertyMask
BIT0: This is to control if a platform wants to enable VTd
based protection during boot.
BIT1: This is to control if a platform wants to keep VTd
enabled at ExitBootService.
The default configuration is BIT0:1, BIT1:0.
Jiewen Yao (2):
IntelSiliconPkg/dec: Add VTd po
Cc: Star Zeng
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jiewen Yao
---
IntelSiliconPkg/IntelVTdDxe/DmaProtection.c | 7 +--
IntelSiliconPkg/IntelVTdDxe/IntelVTdDxe.c | 4
IntelSiliconPkg/IntelVTdDxe/IntelVTdDxe.inf | 3 +++
3 files changed, 12 insertions(+
BIT0: This is to control if a platform wants to enable VTd
based protection during boot.
BIT1: This is to control if a platform wants to keep VTd
enabled at ExitBootService.
The default configuration is BIT0:1, BIT1:0.
Cc: Star Zeng
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-
Reviewed-by: Liming Gao
>-Original Message-
>From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Eric
>Dong
>Sent: Wednesday, September 06, 2017 1:54 PM
>To: edk2-devel@lists.01.org
>Cc: Gao, Liming
>Subject: [edk2] [Patch] MdePkg/PiMmCis.h: Fix build failure.
>
>Inclu
Include the missed header file to fix build failure.
Cc: Liming Gao
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Eric Dong
---
MdePkg/Include/Pi/PiMmCis.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/MdePkg/Include/Pi/PiMmCis.h b/MdePkg/Include/Pi/PiMmCis.h
inde
For setting high speed in SD card,
First CMD 6 (Switch) is send to check if card supports High Speed and
Second command is send to switch card to high speed mode.
In current inplementation, CMD 6 was sent only once to switch the
card into HS mode without checking if card supports HS or not, which
We want to print name of the function resulted in error,
but __FUNCTION__ macro was missing.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Meenakshi Aggarwal
---
EmbeddedPkg/Universal/MmcDxe/MmcIdentification.c | 14 +++---
1 file changed, 7 insertions(+), 7 dele
Thanks for the clarification. Comment in line.
From: Laszlo Ersek [mailto:ler...@redhat.com]
Sent: Wednesday, September 6, 2017 1:57 AM
To: Yao, Jiewen ; Zeng, Star ;
edk2-devel-01
Cc: Dong, Eric ; Brijesh Singh
Subject: Re: [edk2] [PATCH 0/4] MdeModulePkg: some PCI HC drivers: unmap common
bu
Good suggestion. It can make error message more readable.
> -Original Message-
> From: Zeng, Star
> Sent: Wednesday, September 6, 2017 10:14 AM
> To: Yao, Jiewen ; edk2-devel@lists.01.org
> Cc: Zeng, Star
> Subject: RE: [PATCH 1/2] IntelSiliconPkg/Vtd: Support CSM usage.
>
> How about we
Sorry, I forgot to mention that the new SPI protocols still mention "SMM"
rather than "MM". Is this intended?
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Marvin H?user
> Sent: Wednesday, September 6, 2017 5:22 AM
> To: edk2-devel@lists.0
Reviewed-by: Liming Gao
>-Original Message-
>From: Zhu, Yonghong
>Sent: Tuesday, September 05, 2017 4:43 PM
>To: edk2-devel@lists.01.org
>Cc: Gao, Liming
>Subject: [Patch] BaseTools: Fix the bug that same region print twice in the
>build log
>
>This patch fixed the bug that same region p
Dear UEFI contributors,
I am not an UEFI contributor and hence cannot submit changes. Could somebody
please take note of the following?
1. I do not see EFI_SPI_TRANSACTION_TYPE defined anywhere. There is a list
of names for possible values with descriptions (PI 1.6, Vol. 5, page 368),
thou
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ge Song
Best Regards,
Songge
-Original Message-
From: songgeb...@gmail.com [mailto:songgeb...@gmail.com]
Sent: 2017年9月6日 11:12
To: edk2-devel@lists.01.org
Cc: Jordan Justen ; Laszlo Ersek
; Ard Biesheuvel ; Song, Ge
From: Ge Song
In earlier PEI stage, temporary memory at PcdOvmfSecPeiTempRamBase is
employed as stack and heap. We move them to the new room and do some
relocation fixup when permanent memory becomes available.
TemporaryRamMigration() is responsible for switching the stack.
Before entering Tempo
From: Ge Song
Here is the change from v2 patch:
* Change the author and contributor
Repo: https://github.com/sgbird/edk2.git
Branch: stack_switch
Best Regards,
Ge Song
Cc: Jordan Justen
Cc: Laszlo Ersek
Cc: Ard Biesheuvel
Ge Song (1):
OvmfPkg/SecMain: Fix stack switching to permanent
How about we also enhance the debug message like below?
if (HasError) {
DEBUG((DEBUG_INFO, " ERROR \n"));
DumpVtdRegs (Num);
DEBUG((DEBUG_INFO, " ERROR \n"));
}
->
if (HasError) {
DEBUG((DEBUG_INFO, "\n ERROR \n"));
DumpVtdRegs (N
On 5 September 2017 at 23:37, Laszlo Ersek wrote:
> On 09/06/17 00:18, Ard Biesheuvel wrote:
>> On 5 September 2017 at 22:59, Laszlo Ersek wrote:
>>> On 09/05/17 23:11, Ard Biesheuvel wrote:
>
(which means it could be the second time it was called).
>>>
>>> Side remark: the CoreExitBootServi
On 09/06/17 00:18, Ard Biesheuvel wrote:
> On 5 September 2017 at 22:59, Laszlo Ersek wrote:
>> On 09/05/17 23:11, Ard Biesheuvel wrote:
>>> (which means it could be the second time it was called).
>>
>> Side remark: the CoreExitBootServices() implementation does not notice
>> memory map changes
On 5 September 2017 at 22:59, Laszlo Ersek wrote:
> On 09/05/17 23:11, Ard Biesheuvel wrote:
>> On 5 September 2017 at 21:17, Laszlo Ersek wrote:
[...]
>>> * Option #2: add an ExitBootServices() handler to the IOMMU driver, and
>>> clean up mappings (= re-encrypt memory) after the PCI / Virtio
On 09/05/17 23:11, Ard Biesheuvel wrote:
> On 5 September 2017 at 21:17, Laszlo Ersek wrote:
> [...]
>> ... Based on the discussion in the other thread ("[edk2] [PATCH 0/4]
>> MdeModulePkg: some PCI HC drivers: unmap common buffers at
>> ExitBootServices()"), I'm worried that we might need another
On 5 September 2017 at 21:17, Laszlo Ersek wrote:
[...]
> ... Based on the discussion in the other thread ("[edk2] [PATCH 0/4]
> MdeModulePkg: some PCI HC drivers: unmap common buffers at
> ExitBootServices()"), I'm worried that we might need another
> restructuring for the IOMMU driver, and for t
On 09/05/17 20:57, Brijesh Singh wrote:
> Hi Laszlo,
>
> Thanks for quick reviews. I will go through each feedback address them
> in v2.
>
>
>
> On 09/05/2017 06:47 AM, Laszlo Ersek wrote:
>
> [...]
>
>>
>> Please also modify the commit message similarly: "map the VRING system
>> physical add
Hi Laszlo,
Thanks for quick reviews. I will go through each feedback address them in v2.
On 09/05/2017 06:47 AM, Laszlo Ersek wrote:
[...]
Please also modify the commit message similarly: "map the VRING system
physical address[es] to device address[es]".
Would it be OK with you to submit
Even though RELEASE builds produce some diagnostics when a crash
occurs, they can be rather unhelpful:
Synchronous Exception at 0x
and sometimes, it would be useful to get a full register dump from
a production machine without having to modify the firmware.
This can be achieved
On Tue, Sep 05, 2017 at 10:45:57AM -0700, Jordan Justen wrote:
> On 2017-09-04 14:25:48, Laszlo Ersek wrote:
> > On 09/04/17 17:11, Ge Song wrote:
> > > On 09/04/2017 09:34 PM, Jordan Justen wrote:
> > >
> > >> On 2017-09-03 16:55:36, Laszlo Ersek wrote:
> > >>> On 09/03/17 04:12, Ge Song wrote:
>
On 09/05/17 15:44, Yao, Jiewen wrote:
> Good discussion. Comment in line.
>
> From: Laszlo Ersek [mailto:ler...@redhat.com]
> Sent: Tuesday, September 5, 2017 5:16 PM
> To: Yao, Jiewen ; Zeng, Star ;
> edk2-devel-01
> Cc: Dong, Eric
> Subject: Re: [edk2] [PATCH 0/4] MdeModulePkg: some PCI HC dr
On 2017-09-04 14:25:48, Laszlo Ersek wrote:
> On 09/04/17 17:11, Ge Song wrote:
> > On 09/04/2017 09:34 PM, Jordan Justen wrote:
> >
> >> On 2017-09-03 16:55:36, Laszlo Ersek wrote:
> >>> On 09/03/17 04:12, Ge Song wrote:
> In earlier PEI stage, temporary memory(Cache As Ram) is employed as
>
You might want to look at Firmware Test Suite, it includes a Linux
kernel driver to help with it's interactions with UEFI. Note that this
is a Linux-centric test suite, solution won't work for other OSes.
http://kernel.ubuntu.com/git/hwe/fwts.git
https://bugs.launchpad.net/ubuntu/+source/linux/+b
On 5 September 2017 at 15:50, Ruiyu Ni wrote:
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Ruiyu Ni
> Cc: Ard Biesheuvel
Reviewed-by: Ard Biesheuvel
> ---
> MdePkg/Library/PciSegmentLibSegmentInfo/PciSegmentLibCommon.c | 6 +++---
> 1 file changed, 3 insertions(
Looks like I'm slowly getting to the 2nd patch after all:
On 09/01/17 13:24, Brijesh Singh wrote:
> When device is behind the IOMMU, VirtioNetDxe is required to use the
> device address in bus master operations. RxBuf is allocated using
> AllocatePool() which returns the system physical address.
>
In earlier PEI stage, temporary memory at PcdOvmfSecPeiTempRamBase is
employed as stack and heap. We move them to the new room and do some
relocation fixup when permanent memory becomes available.
TemporaryRamMigration() is responsible for switching the stack.
Before entering TemporaryRamMigration
Here are changes from v1 patch:
* Revise improper descriptions in subject and commit message
* Remove some debug information to compact the message
* Add a description of practical consequences of the bug
Repo: https://github.com/sgbird/edk2.git
Branch: stack_switch
Best Regards,
Ge Song
Cc: J
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ruiyu Ni
Cc: Ard Biesheuvel
---
MdePkg/Library/PciSegmentLibSegmentInfo/PciSegmentLibCommon.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/MdePkg/Library/PciSegmentLibSegmentInfo/PciSegmentLibComm
On 09/04/2017 10:57 AM, Laszlo Ersek wrote:
Since commit 19c6d9feaaf8 ("MdePkg: Expand BaseIoLibIntrinsic (IoLib
class) library", 2017-01-14), IoWriteFifo8() has been widely available to
modules. Use it to print debug messages and assertion failures to the QEMU
debug port, rather than open-code
On 09/04/2017 10:57 AM, Laszlo Ersek wrote:
In commit b6d11d7c4678 ("MdePkg: BaseIoLibIntrinsic (IoLib class)
library", 2017-04-12), the MOV instructions in the write loops were
probably copied from the read loops. However, the operand order was not
adjusted.
As a result, the IoWriteFifoXX() r
Good discussion. Comment in line.
From: Laszlo Ersek [mailto:ler...@redhat.com]
Sent: Tuesday, September 5, 2017 5:16 PM
To: Yao, Jiewen ; Zeng, Star ;
edk2-devel-01
Cc: Dong, Eric
Subject: Re: [edk2] [PATCH 0/4] MdeModulePkg: some PCI HC drivers: unmap common
buffers at ExitBootServices()
On
On 5 September 2017 at 08:07, Ni, Ruiyu wrote:
> Bartosz,
>
> Based on your findings, the AddrRangeMin has to be a device address☺
>
> As far as I can remember, this history is:
> In the very beginning, Spec owner assumes the device address equals to CPU
> address.
> The implementation of GetBarA
On Mon, Sep 04, 2017 at 03:03:42PM +, Evan Lloyd wrote:
> Thanks, Leif.
>
> > -Original Message-
> > From: Leif Lindholm [mailto:leif.lindh...@linaro.org]
> > Sent: 01 September 2017 22:48
> > To: Evan Lloyd
> > Cc: edk2-devel@lists.01.org; Ard Biesheuvel ;
> > Matteo Carlini ; ryan.h
On 09/05/17 14:41, Laszlo Ersek wrote:
> On 09/01/17 13:24, Brijesh Singh wrote:
>> When device is behind the IOMMU, driver is require to pass the device
>> address of transmit buffer for the bus master operations.
>>
>> The patch uses VirtioMapAllBytesInSharedBuffer() to map transmit buffer
>> sys
On 09/01/17 13:24, Brijesh Singh wrote:
> When device is behind the IOMMU, driver is require to pass the device
> address of transmit buffer for the bus master operations.
>
> The patch uses VirtioMapAllBytesInSharedBuffer() to map transmit buffer
> system physical address to the device address.
>
Create a new branch (devel-MinnowBoardMax-UDK2017 ) on edk2-platforms for
MinnowBoard Max. This code is based on UDK2017 core packages.
Code is ready in
https://github.com/mangguo321/edk2-platforms/tree/devel-MinnowBoardMax-UDK2017
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-
On 09/01/17 13:24, Brijesh Singh wrote:
> When device is behind the IOMMU then driver need to pass the device
> address when programing the bus master. The patch uses VirtioRingMap() to
> map the VRING system physical address to device address.
>
> Cc: Ard Biesheuvel
> Cc: Jordan Justen
> Cc: Tom
On 09/05/17 04:18, Yao, Jiewen wrote:
> HI Laszlo
> Thank you very much to raise this DMA topic.
>
> I have a chat with Star. We have couples of question, from high level to low
> level.
> Hope you can clarify:
>
>
> 1) About disable DMA
>
> As you mentioned, in UEFI_Driver_Writer_Guide_
This patch fixed the bug that same region print twice in the build log.
Cc: Liming Gao
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Yonghong Zhu
---
BaseTools/Source/Python/GenFds/Fd.py | 58
1 file changed, 32 insertions(+), 26 del
Ray, thanks for your answer. This makes sense to me, but I still see some
inconsistency in regard to specification.
UEFI spec says:
> Address Range Minimum. Starting address of a BAR.
and then
> Address Translation Offset. Offset to apply to the Starting address of a
> BAR to convert it to a PCI a
Good morning,
1.) Do you mean whether the OS exposes the Runtime Services? Windows and Linux
expose the Variable Services (Linux even more, if I remember correctly) and
macOS (not entirely sure about the latest version) the entire table via
DeviceTree.
2.) Yes, you need to write a DXE Runtime D
Bartosz,
Based on your findings, the AddrRangeMin has to be a device address☺
As far as I can remember, this history is:
In the very beginning, Spec owner assumes the device address equals to CPU
address.
The implementation of GetBarAttributes() directly returns the address read from
the BAR.
B
Reviewed-by: Ruiyu Ni
-Original Message-
From: Gao, Liming
Sent: Tuesday, September 5, 2017 2:56 PM
To: edk2-devel@lists.01.org
Cc: Ni, Ruiyu
Subject: [Patch] Nt32Pkg: Clean up DSC to remove unnecessary build option in
SecMain
Contributed-under: TianoCore Contribution Agreement 1.1
Si
49 matches
Mail list logo
