Re: [edk2] [PATCH v6 edk2-platforms 6/6] Platform/HiKey: enable virtual keyboard

On Thu, May 24, 2018 at 08:46:30AM +0800, Haojian Zhuang wrote: > Enable virtual keyboard on HiKey platform. It detects the pattern > in memory and GPIO pin setting, and simulates them into virtual > key. > > Cc: Leif Lindholm > Cc: Ard Biesheuvel

Re: [edk2] [PATCH v6 edk2-platforms 5/6] Platform/HiKey: do basic initialization on hikey

On Thu, May 24, 2018 at 08:46:29AM +0800, Haojian Zhuang wrote: > Do some basic initialization on HiKey platform, such as pin > setting, regulators and making peripherals out of reset mode. > > Cc: Leif Lindholm > Cc: Ard Biesheuvel >

Re: [edk2] [PATCH v6 edk2-platforms 3/6] Platform/HiKey960: enable virtual keyboard

On Thu, May 24, 2018 at 08:46:27AM +0800, Haojian Zhuang wrote: > Enable virtual keyboard on HiKey960 platform. It checks two > conditions, such as pattern in memory and GPIO pin setting. > Since code is ported from non-open > > The hardcoding code is taken from non-open reference code. > Can't

Re: [edk2] [PATCH v6 edk2-platforms 2/6] Platform/HiKey960: do basic initialization

On Thu, May 24, 2018 at 08:46:26AM +0800, Haojian Zhuang wrote: > Do some basic initliazation on peripherals, such as pins and > regulators. > > The hardcoding code is taken from non-open reference code. > Can't fix it for lack of documents. > > Cc: Leif Lindholm > Cc:

Re: [edk2] [PATCH v2] EmulatorPkg/SmbiosLib: Declare the correct library class.

BaseTools has no such check before. To avoid build break, I suggest to report the warning message if library class in DSC doesn't match one in library INF [Defines] section. > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Carsey, Jaben >

Re: [edk2] [PATCH v2] EmulatorPkg/SmbiosLib: Declare the correct library class.

> -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Marvin Häuser > Sent: Thursday, May 24, 2018 1:57 PM > To: edk2-devel@lists.01.org; Laszlo Ersek > Cc: Justen, Jordan L ; af...@apple.com >

Re: [edk2] [PATCH] MdeModulePkg/Library/BaseSerialPortLib16550: Ensure FIFO Polled Mode

Don''t have access to test platform at this time. But will report IER value if I,m able to. Leo Get Outlook for iOS From: Zeng, Star Sent: Friday, May 25, 2018 6:13:16 AM To: Duran, Leo; edk2-devel@lists.01.org Cc:

Re: [edk2] CpuS3DataDxe / DxeRegisterCpuFeaturesLib dependency.

Hey Laszlo and thanks once again for your detailed response. Comments are inline. Regards, Marvin. > -Original Message- > From: Laszlo Ersek > Sent: Friday, May 25, 2018 1:41 PM > To: Marvin Häuser > Cc: edk2-devel@lists.01.org;

Re: [edk2] CpuS3DataDxe / DxeRegisterCpuFeaturesLib dependency.

On 05/25/18 12:54, Marvin H?user wrote: > Good day, > > While I was inspecting CpuS3DataDxe and the modules depending on its > PCD PcdCpuS3DataAddress, (Side remark: see e.g. the commit message on 92b87f1c8c0b, "OvmfPkg: build CpuS3DataDxe for -D SMM_REQUIRE", 2015-11-30.) > I noticed that

Re: [edk2] [PATCH] MdeModulePkg/Library/BaseSerialPortLib16550: Ensure FIFO Polled Mode

Reviewed-by: Star Zeng Just a little curious about 1. Did you meet real issue without this patch? 2. what is the default value of IER in your case? Thanks, Star -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Leo Duran

Re: [edk2] [Patch v3 2/3] MdeModulePkg: Add DisplayUpdateProgressLib instances

Reviewed-by: Star Zeng Thanks, Star -Original Message- From: Kinney, Michael D Sent: Friday, May 25, 2018 2:16 PM To: edk2-devel@lists.01.org Cc: Sean Brogan ; Zeng, Star ; Dong, Eric Subject:

Re: [edk2] [PATCH v2 1/1] BaseTools: loop to retry remove when it fails.

Reviewed-by: Yonghong Zhu Best Regards, Zhu Yonghong -Original Message- From: Carsey, Jaben Sent: Thursday, May 10, 2018 11:15 PM To: edk2-devel@lists.01.org Cc: Kinney, Michael D ; Gao, Liming ; Zhu, Yonghong

Re: [edk2] [Patch v3 1/3] MdeModulePkg: Add DisplayUpdateProgressLib class

Reviewed-by: Star Zeng after fixing typo ' custoimize ' to ' customize '. Thanks, Star -Original Message- From: Kinney, Michael D Sent: Friday, May 25, 2018 2:16 PM To: edk2-devel@lists.01.org Cc: Sean Brogan ; Zeng, Star

[edk2] CpuS3DataDxe / DxeRegisterCpuFeaturesLib dependency.

Good day, While I was inspecting CpuS3DataDxe and the modules depending on its PCD PcdCpuS3DataAddress, I noticed that DxeRegisterCpuFeaturesLib seemingly has an asserted dependency on the PCD being ready when it its executed. I did neither see a Depex entry, nor an event callback ensuring

[edk2] [Patch][edk2-platforms/devel-MinnowBoardMax-UDK2017] Capsule Update

1. Fix ESRT issue 2. Add support for Capsule update processing between x64 and IA32 BIOS image Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Guo Mang --- .../Library/PlatformBdsLib/BdsPlatform.c | 7 +-

[edk2] [PATCH 0/2] MdeModulePkg/PciBus: Do not enable MemWriteAndInvalidate bit for PCIE

Per PCIE spec, Memory Write and Invalidate is hardwired to 0b so PciBus driver shouldn't write 1b to it. Patch #1 cleans up some unnecessary code. Ruiyu Ni (2): MdeModulePkg/PciBus: Remove unnecessary PCIE detection MdeModulePkg/PciBus: Do not enable MemWriteAndInvalidate bit for PCIE

[edk2] [PATCH 1/2] MdeModulePkg/PciBus: Remove unnecessary PCIE detection

CreatePciIoDevice() detects whether the PCI device is a PCI Express device and remembers the device type in PciIoDevice->IsPciExp. RegisterPciDevice() detects the device type again which is unnecessary. The detection logic can be removed. Contributed-under: TianoCore Contribution Agreement 1.1

[edk2] [PATCH 2/2] MdeModulePkg/PciBus: Do not enable MemWriteAndInvalidate bit for PCIE

Per PCIE spec, Memory Write and Invalidate is hardwired to 0b so PciBus driver shouldn't write 1b to it. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ruiyu Ni Cc: Star Zeng Cc: Chasel Chiu ---

Re: [edk2] [PATCH] PcAtChipsetPkg/PcRtc: Add two new PCD for RTC Index/Target registers

Star, Thanks for the comments. I will take #1. For #2, I prefer to remove the macro Thanks/Ray > -Original Message- > From: Zeng, Star > Sent: Friday, May 25, 2018 5:06 PM > To: Ni, Ruiyu ; edk2-devel@lists.01.org > Cc: Zeng, Star > Subject: RE:

Re: [edk2] [PATCH] PcAtChipsetPkg/PcRtc: Add two new PCD for RTC Index/Target registers

Two minor comments: 1. PcAtChipsetPkg.uni also needs to be updated for the new PCDs. 2. Update all the places of the two macros, or just update like below? Just for you to consider. :) I do not insist. #define PCAT_RTC_ADDRESS_REGISTER PcdGet8 (PcdRtcIndexRegister) #define

[edk2] [PATCH] UefiCpuPkg/CpuCommonFeatures: Follow SDM for MAX CPUID feature detect

According to IA manual: "Before setting this bit (MSR_IA32_MISC_ENABLE[22]) , BIOS must execute the CPUID.0H and examine the maximum value returned in EAX[7:0]. If the maximum value is greater than 2, this bit is supported." We need to fix our current detection logic to compare against 2.

[edk2] [PATCH] PcAtChipsetPkg/PcRtc: Add two new PCD for RTC Index/Target registers

In certain HW implementation, the BIT7 of RTC Index register(0x70) is for NMI sources enable/disable but the BIT7 of 0x70 cannot be read before writing. Software which doesn't want to change the NMI sources enable/disable setting can write to the alias register 0x74, through which only BIT0 ~ BIT6

Re: [edk2] [PATCH] MdeModulePkg/Library/BaseSerialPortLib16550: Ensure FIFO Polled Mode

Reviewed-by: Ruiyu Ni Thanks/Ray > -Original Message- > From: edk2-devel On Behalf Of Leo > Duran > Sent: Friday, May 25, 2018 3:08 AM > To: edk2-devel@lists.01.org > Cc: Dong, Eric ; Zeng, Star

[edk2] [edk2-platforms Patch v3 4/6] Styx/PlatformFlashAccessLib: Add progress API

From: "Kinney, Michael D" https://bugzilla.tianocore.org/show_bug.cgi?id=801 Add PerformFlashWriteWithProgress() to the PlatformFlashAccessLib. This allows the platform to inform the user of progress when a firmware storage device is being updated with a new firmware

[edk2] [edk2-platforms Patch v3 1/6] AMD/OverdriveBoard: Add DisplayUpdateProgressLib mapping

From: "Kinney, Michael D" https://bugzilla.tianocore.org/show_bug.cgi?id=801 Based on content from the following branch/commits: https://github.com/Microsoft/MS_UEFI/tree/share/MsCapsuleSupport Cc: Ard Biesheuvel Cc: Leif Lindholm

[edk2] [edk2-platforms Patch v3 5/6] Hisilicon/PlatformFlashAccessLib: Add progress API

From: "Kinney, Michael D" https://bugzilla.tianocore.org/show_bug.cgi?id=801 Add PerformFlashWriteWithProgress() to the PlatformFlashAccessLib. This allows the platform to inform the user of progress when a firmware storage device is being updated with a new firmware

[edk2] [edk2-platforms Patch v3 3/6] Socionext/SynQuacerEvalBoard: Add DisplayUpdateProgressLib mapping

From: "Kinney, Michael D" https://bugzilla.tianocore.org/show_bug.cgi?id=801 Based on content from the following branch/commits: https://github.com/Microsoft/MS_UEFI/tree/share/MsCapsuleSupport Cc: Ard Biesheuvel Cc: Leif Lindholm

[edk2] [edk2-platforms Patch v3 6/6] SynQuacer/PlatformFlashAccessLib: Add progress API

From: "Kinney, Michael D" https://bugzilla.tianocore.org/show_bug.cgi?id=801 Add PerformFlashWriteWithProgress() to the PlatformFlashAccessLib. This allows the platform to inform the user of progress when a firmware storage device is being updated with a new firmware

[edk2] [edk2-platforms Patch v3 2/6] Socionext/DeveloperBox: Add DisplayUpdateProgressLib mapping

From: "Kinney, Michael D" https://bugzilla.tianocore.org/show_bug.cgi?id=801 Based on content from the following branch/commits: https://github.com/Microsoft/MS_UEFI/tree/share/MsCapsuleSupport Cc: Ard Biesheuvel Cc: Leif Lindholm

[edk2] [edk2-platforms Patch v3 0/6] Add DisplayUpdateProgressLib to platforms

https://bugzilla.tianocore.org/show_bug.cgi?id=801 Based on content from: https://github.com/Microsoft/MS_UEFI/blob/share/MsCapsuleSupport/MsCapsuleUpdatePkg/Include/Library/DisplayUpdateProgressLib.h

[edk2] [Patch v3 4/4] QuarkPlatformPkg/PlatformFlashAccessLib: Add progress API

https://bugzilla.tianocore.org/show_bug.cgi?id=801 Add PerformFlashWriteWithProgress() to the PlatformFlashAccessLib. This allows the platform to inform the user of progress when a firmware storage device is being updated with a new firmware image. Cc: Kelly Steele

[edk2] [Patch v3 1/4] Vlv2Tbl2DevicePkg: Add DisplayUpdateProgressLib mapping

https://bugzilla.tianocore.org/show_bug.cgi?id=801 Based on content from the following branch/commits: https://github.com/Microsoft/MS_UEFI/tree/share/MsCapsuleSupport Cc: Sean Brogan Cc: David Wei Cc: Mang Guo Signed-off-by:

[edk2] [Patch v3 0/4] Add DisplayUpdateProgressLib to platforms

https://bugzilla.tianocore.org/show_bug.cgi?id=801 Based on content from: https://github.com/Microsoft/MS_UEFI/blob/share/MsCapsuleSupport/MsCapsuleUpdatePkg/Include/Library/DisplayUpdateProgressLib.h

[edk2] [Patch v3 3/4] QuarkPlatformPkg: Add DisplayUpdateProgressLib mapping

From: "Kinney, Michael D" https://bugzilla.tianocore.org/show_bug.cgi?id=801 Based on content from the following branch/commits: https://github.com/Microsoft/MS_UEFI/tree/share/MsCapsuleSupport Cc: Sean Brogan Cc: Kelly Steele

[edk2] [Patch v3 2/4] Vlv2TbltDevicePkg/PlatformFlashAccessLib: Add progress API

https://bugzilla.tianocore.org/show_bug.cgi?id=801 Add PerformFlashWriteWithProgress() to the PlatformFlashAccessLib. This allows the platform to inform the user of progress when a firmware storage device is being updated with a new firmware image. Cc: David Wei Cc: Mang

[edk2] [Patch v3 2/3] MdeModulePkg: Add DisplayUpdateProgressLib instances

https://bugzilla.tianocore.org/show_bug.cgi?id=801 Based on content from the following branch/commits: https://github.com/Microsoft/MS_UEFI/tree/share/MsCapsuleSupport Add DisplayUpdateProgressLib instances for text consoles and graphical consoles. Cc: Sean Brogan

[edk2] [Patch v3 1/3] MdeModulePkg: Add DisplayUpdateProgressLib class

https://bugzilla.tianocore.org/show_bug.cgi?id=801 Based on content from the following branch/commits: https://github.com/Microsoft/MS_UEFI/tree/share/MsCapsuleSupport Add the DisplayUpdateProgressLib class that is used to inform the user of progress during updates of firmware images in firmware

[edk2] [Patch v3 3/3] SignedCapsulePkg/PlatformFlashAccessLib: Add progress API

https://bugzilla.tianocore.org/show_bug.cgi?id=801 Add a new API to the PlatformFlashAccessLib that passes in an optional Progress() function along with a start and end percentage to call the Progress() function with. If the Progress() function is not NULL, then it is the Progress() function that

[edk2] [Patch v3 0/3] Add DisplayUpdateProgressLib for capsules

https://bugzilla.tianocore.org/show_bug.cgi?id=801 Based on content from: https://github.com/Microsoft/MS_UEFI/blob/share/MsCapsuleSupport/MsCapsuleUpdatePkg/Include/Library/DisplayUpdateProgressLib.h