Commit b22a62be5cdc8fd19d87ec1ecfa5b28fb9be50ad
* IntelFrameworkModule/LegacyBios:Use reserved memory for legacy data
allocates reserved memory for holding legacy code/data.
But with PcdDxeNxMemoryProtectionPolicy set to certain value to
forbid execution when code is in certain type of memory,
Laszlo:
I mean to keep the minimal change in PCCT. I don't prevent the necessary
change in PCCT code. Per your comments, this change in PCCT is necessary. If
so, I am OK to this patch.
Reviewed-by: Liming Gao
Thanks
Liming
>-Original Message-
>From: Laszlo Ersek
Reviewed-by: Liming Gao
>-Original Message-
>From: Zhu, Yonghong
>Sent: Wednesday, August 01, 2018 11:24 AM
>To: edk2-devel@lists.01.org
>Cc: Gao, Liming ; Kinney, Michael D
>; Shaw, Kevin W
>Subject: [Patch] Build Spec: Add rules for structure pcd display in the report
>
>Cc: Liming
Reviewed-by: Liming Gao
>-Original Message-
>From: Zhu, Yonghong
>Sent: Friday, August 03, 2018 2:12 PM
>To: edk2-devel@lists.01.org
>Cc: Gao, Liming ; Kinney, Michael D
>; Shaw, Kevin W
>Subject: [Patch] DSC Spec: limit the VOID* PCD max size to UINT16
>
>current the max size of VOID*
Reviewed-by: Liming Gao
>-Original Message-
>From: Feng, YunhuaX
>Sent: Tuesday, August 07, 2018 9:36 AM
>To: edk2-devel@lists.01.org
>Cc: Zhu, Yonghong ; Gao, Liming
>
>Subject: [PATCH] BaseTools:Fix incorrect %EDK_TOOLS_PATH%
>
>For non-root folder, such as "X:\bp", the EDK_TOOLS_PATH
For non-root folder, such as "X:\bp", the EDK_TOOLS_PATH will
resolve to "X:\bp\edk2\BaseTools". This is OK.
But if WORKSPACE is at a root folder, such as "X:\", the EDK_TOOLS_PATH
will look like "X:\\BaseTools". The *double backslash* can fail the command
like "del" and thus affect the
Reviewed-by: Dandan Bi
Thanks,
Dandan
-Original Message-
From: Ni, Ruiyu
Sent: Monday, August 6, 2018 2:30 PM
To: edk2-devel@lists.01.org
Cc: Bi, Dandan
Subject: [PATCH] ShellPkg/acpi: Fix XCODE5 X64 build failure
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by:
On 08/06/18 20:26, Jordan Justen wrote:
> On 2018-08-03 08:08:13, Laszlo Ersek wrote:
>>
>> Should I resubmit the patch for function-scoping (and renaming) the
>> global variables, or for inserting the blank linke?
>
> No need to resubmit. Furthermore, you can consider my suggestions as
>
On 2018-08-03 08:08:13, Laszlo Ersek wrote:
>
> Should I resubmit the patch for function-scoping (and renaming) the
> global variables, or for inserting the blank linke?
No need to resubmit. Furthermore, you can consider my suggestions as
optional. I don't feel too strongly about these ones.
pon., 6 sie 2018 o 19:44 Leif Lindholm napisał(a):
>
>
>
> On Mon, 6 Aug 2018, 17:09 Ard Biesheuvel, wrote:
>>
>> On 6 August 2018 at 18:08, Marcin Wojtas wrote:
>> > HI Ard,
>> >
>> > pon., 6 sie 2018 o 13:54 Ard Biesheuvel
>> > napisał(a):
>> >>
>> >> On 6 August 2018 at 01:28, Marcin
On Mon, 6 Aug 2018, 17:09 Ard Biesheuvel, wrote:
> On 6 August 2018 at 18:08, Marcin Wojtas wrote:
> > HI Ard,
> >
> > pon., 6 sie 2018 o 13:54 Ard Biesheuvel
> napisał(a):
> >>
> >> On 6 August 2018 at 01:28, Marcin Wojtas wrote:
> >> > This patch introduces DSDT table and adds necessary
>
Laszlo,
I agree for a patch like this that one patch
per module makes more sense.
We also need to make sure that this series is
tested with all supported compilers and CPU
architectures to make sure code is not being
removed that is required for a combination that
was missed.
Thanks,
Mike
>
Hi Liming,
On 08/06/18 17:18, Laszlo Ersek wrote:
> On 08/06/18 16:48, Gao, Liming wrote:
>> Laszlo:
>> Thanks for your detail information. I understand EXTRA_OPTFLAGS.
>> So, its name is OK to me.
>>
>> On Pccts, it is the third party code. I would like to make the
>> minimal change. So,
On 6 August 2018 at 18:08, Marcin Wojtas wrote:
> HI Ard,
>
> pon., 6 sie 2018 o 13:54 Ard Biesheuvel
> napisał(a):
>>
>> On 6 August 2018 at 01:28, Marcin Wojtas wrote:
>> > This patch introduces DSDT table and adds necessary
>> > wiring in order to enable ACPI support on Armada 7040 DB.
>> >
HI Ard,
pon., 6 sie 2018 o 13:54 Ard Biesheuvel napisał(a):
>
> On 6 August 2018 at 01:28, Marcin Wojtas wrote:
> > This patch introduces DSDT table and adds necessary
> > wiring in order to enable ACPI support on Armada 7040 DB.
> >
> > Contributed-under: TianoCore Contribution Agreement 1.1
>
On 6 August 2018 at 17:37, Laszlo Ersek wrote:
> On 08/06/18 16:54, Gao, Liming wrote:
>> Laszlo: We manually search the unused functions in the module source
>> files, and also verify the build to make sure the unused functions are
>> real dead code.
>
> Works for me, but then the commit message
On 08/06/18 16:54, Gao, Liming wrote:
> Laszlo: We manually search the unused functions in the module source
> files, and also verify the build to make sure the unused functions are
> real dead code.
Works for me, but then the commit message should state exactly this.
Such as:
"""
Remove
Hi Ricardo
I double checked OVMF Debug Build. All the 2 PCDs are already built as
Dynamic PCD. There should be no problem
Setting & Getting these PCD as Dynamic. We also verified this feature on
several real hardware platforms with same configuration.
No issue reported.
Can you share me
Laszlo:
We manually search the unused functions in the module source files, and also
verify the build to make sure the unused functions are real dead code. I agree
to separate this patch as the module level. So, we can document which unused
functions are removed in the driver.
Thanks
Liming
Hi Team
It’s got resolved now, thanks for kind support.
The link and documents mentioned help to resolve and understand the
architecture as well
Thanks for such kind support by Laszlo, Andrew and Dandan
> On 04-Aug-2018, at 3:41 PM, Bi, Dandan wrote:
>
> Hi Prabin,
>
> Here is a simple
Laszlo:
Thanks for your detail information. I understand EXTRA_OPTFLAGS. So, its name
is OK to me.
On Pccts, it is the third party code. I would like to make the minimal
change. So, I ask whether we not touch it.
Thanks
Liming
> -Original Message-
> From: Laszlo Ersek
On 08/06/18 04:54, shenglei wrote:
> Some dead code functions and redundant definitions
> have been removed in inf, .c and .h files.
>
> https://bugzilla.tianocore.org/show_bug.cgi?id=1063
>
> Cc: Liming Gao
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: shenglei
>
On 08/06/18 09:49, shenglei wrote:
> Some dead code has been removed in .c and .h files.
> https://bugzilla.tianocore.org/show_bug.cgi?id=1062
>
> Cc: Star Zeng
> Cc: Eric Dong
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: shenglei
> ---
>
On 08/06/18 12:20, Zeng, Star wrote:
> Cc Jian.
Right; I believe a non-empty commit message would be helpful. (Issue
description, circumstances of the failure, what the exact edk2 security
feature or setting is that the current LegacyBiosDxe code conflicts
with, ...)
Thanks,
Laszlo
> Thanks,
>
On 6 August 2018 at 01:28, Marcin Wojtas wrote:
> This patch introduces DSDT table and adds necessary
> wiring in order to enable ACPI support on Armada 7040 DB.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Marcin Wojtas
> ---
>
On Sun, Aug 05, 2018 at 10:38:53AM +0800, Ming Huang wrote:
> The major features of this patchset include:
> 1. Remove D02 platform;
> 2. Fix a D03 issue about switch generic PciHostBridge;
>
> Code can also be found in github:
> https://github.com/hisilicon/OpenPlatformPkg.git
> branch: rm-D02
Cc: Michael D Kinney
Star Zeng (2):
FmpDevicePkg FmpDxe: Need repopulate after SetImage is called
MdeModulePkg ErstFmpDxe: Create ESRT in ReadyToBoot event
FmpDevicePkg/FmpDxe/FmpDxe.c| 21 +--
MdeModulePkg/Universal/EsrtFmpDxe/EsrtFmp.c | 239
Current code just creates ESRT entry in FMP notification
and installs ESRT configuration table in ReadyToBoot event.
The LastAttemptVersion and LastAttemptStatus in ESRT will
be out of date after system continues to boot without reset
after capsule update (reset is required or capsule update
is
No need repopulate if SetImage is not called.
But need repopulate after SetImage is called to update
LastAttemptVersion and LastAttemptStatus
Cc: Michael D Kinney
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Star Zeng
---
FmpDevicePkg/FmpDxe/FmpDxe.c | 21
Cc Jian.
Thanks,
Star
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ruiyu Ni
Sent: Monday, August 6, 2018 5:57 PM
To: edk2-devel@lists.01.org
Cc: Zeng, Star
Subject: [edk2] [PATCH] IntelFrameworkModulePkg/Csm: Set CSM memory executable
On Tue, Jul 24, 2018 at 03:28:16PM +0800, Ming Huang wrote:
> Add initial binary for D06.
> Build commit infomation:
> edk2: e73f499
> edk2-platforms: 7f223e6
> HwPkg: e0bf35e
> TrusedFirmware: 4eda1d1
> Tools: 6b286b1
The above information is all good, but can you add a summary
specifying what
On Tue, Jul 24, 2018 at 03:09:22PM +0800, Ming Huang wrote:
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ming Huang
> ---
> Platform/Hisilicon/D03/D03.dsc | 2 +-
> Platform/Hisilicon/D05/D05.dsc | 2 +-
> Platform/Hisilicon/D06/D06.dsc | 4 ++--
> 3 files changed,
On Tue, Jul 24, 2018 at 03:09:21PM +0800, Ming Huang wrote:
> Add a Null PciPlatformLib for build D06.
Why? (Add some more detail to commit message, please.)
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ming Huang
> Signed-off-by: Heyi Guo
> ---
>
On Tue, Jul 24, 2018 at 03:09:20PM +0800, Ming Huang wrote:
> Select without SMMU iort while SMMU item is disable,
> Select with SMMU iort while SMMU item is enable.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ming Huang
> Signed-off-by: Heyi Guo
> ---
>
On Mon, Aug 06, 2018 at 11:01:04AM +0800, Ming wrote:
> >>> + OUTPUT_DIRECTORY = Build/$(PLATFORM_NAME)
> >>> + SUPPORTED_ARCHITECTURES= AARCH64
> >>> + BUILD_TARGETS = DEBUG|RELEASE
> >>
> >> Can you also add NOOPT please?
> >> Between DEBUG and RELEASE.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ruiyu Ni
Cc: Star Zeng
---
.../Csm/LegacyBiosDxe/LegacyBios.c | 22 +-
1 file changed, 17 insertions(+), 5 deletions(-)
diff --git a/IntelFrameworkModulePkg/Csm/LegacyBiosDxe/LegacyBios.c
Some redundant definitions adn comments
have been removed in .c and .h files.
https://bugzilla.tianocore.org/show_bug.cgi?id=1063
Cc: Liming Gao
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: shenglei
---
.../Bus/Isa/IsaIoDxe/IsaDriver.h | 1 -
Is there any proxy or firewall block the connection? Once you set the static
Ip4Gateway via ifconfig shell command, please try to ping the gateway/remote
address to check the connection.
Thanks,
Jiaxin
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On
Some dead code has been removed in .c and .h files.
https://bugzilla.tianocore.org/show_bug.cgi?id=1062
Cc: Star Zeng
Cc: Eric Dong
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: shenglei
---
.../Application/CapsuleApp/CapsuleDump.c | 31 ---
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ruiyu Ni
Cc: Dandan Bi
---
ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Fadt/FadtParser.c | 2 +-
ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Xsdt/XsdtParser.c | 2 +-
2 files changed, 2 insertions(+), 2
40 matches
Mail list logo
