[edk2] [PATCH 1/1] SD : Continue setting up sd even if SD_HIGH_SPEED is not supported

2019-02-21 Thread tien . hock . loh
From: "Loh, Tien Hock" If SD doesn't support SD_HIGH_SPEED, function should still continue to setup SD to go into 4 bits more if it is supported. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Loh Tien Hock --- EmbeddedPkg/Universal/MmcDxe/MmcIdentification.c | 20

[edk2] [PATCH 4/4] EmbeddedPkg/DwEmmc: Check DMA completion in SendCommand

2019-02-21 Thread tien . hock . loh
From: "Loh, Tien Hock" DwEmmcReadBlockData and DwEmmcWriteBlockData needs to check for the transfer completion before returning. This also adds error checking to the DMA transfer. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Loh Tien Hock ---

[edk2] [PATCH 0/4] EmbeddedPkg/DwEmmc: Fix bugs causing DwEmmc to fail to initialize

2019-02-21 Thread tien . hock . loh
From: Loh Tien Hock This patch series fixes bugs with DwEmmc driver, namely: * Added CMD6 handling * Fixed workaround querying SendCommand using delays * Fix DMA transfer length causing buffer underrun in FIFO * Check DMA completion before returning from SendCommand Loh, Tien Hock (4):

[edk2] [PATCH 2/4] EmbeddedPkg/DwEmmc: Fix SendCommand parameters

2019-02-21 Thread tien . hock . loh
From: "Loh, Tien Hock" Only send BIT_CMD_CHECK_RESPONSE_CRC if MMC commands needs it. Fixes parameters to ACMD6 where if CMD is application command, ie. CMD55 is sent before ACMD6, to do response instead of data transfer. Added CMD51 handling as CMD51 is a data transfer, and needs BIT_CMD_READ

[edk2] [PATCH 3/4] EmbeddedPkg/DwEmmc: Fix DMA transfer length

2019-02-21 Thread tien . hock . loh
From: "Loh, Tien Hock" DMA should not transfer more than requested length otherwise FIFO might run into buffer underrun and causes errors in future transfers. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Loh Tien Hock --- EmbeddedPkg/Drivers/DwEmmcDxe/DwEmmcDxe.c |

[edk2] [PATCH 1/4] EmbeddedPkg/DwEmmc: Remove unnecessary MicroSecondDelay

2019-02-21 Thread tien . hock . loh
From: "Loh, Tien Hock" Existing implementation checks for error regardless of if DWEMMC_INT_CMD_DONE is set, causing the loop check to errors out even when it shouldn't if the MicroSecondDelay doesn't do long enough delays. This removes MicroSecondDelay and updates the function to check for

Re: [edk2] [Patch] BaseTools: Fix a bug about Structure PCD

2019-02-21 Thread Gao, Liming
Reviewed-by: Liming Gao >-Original Message- >From: Feng, Bob C >Sent: Tuesday, February 19, 2019 9:30 PM >To: edk2-devel@lists.01.org >Cc: Feng, Bob C ; Gao, Liming >Subject: [Patch] BaseTools: Fix a bug about Structure PCD > >BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1535 >If

Re: [edk2] [Patch V2] BaseTool: Fixed incremental rebuild issue.

2019-02-21 Thread Gao, Liming
Reviewed-by: Liming Gao >-Original Message- >From: Feng, Bob C >Sent: Wednesday, February 20, 2019 11:22 PM >To: edk2-devel@lists.01.org >Cc: Feng, Bob C ; Gao, Liming >Subject: [Patch V2] BaseTool: Fixed incremental rebuild issue. > >BZ:

Re: [edk2] [PATCH 0/3] Add SMM CET support

2019-02-21 Thread Gao, Liming
Acked-by: Liming Gao >-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of >Jiewen Yao >Sent: Friday, February 22, 2019 12:16 PM >To: edk2-devel@lists.01.org >Cc: Dong, Eric ; Gao, Liming ; >Yao, Jiewen ; Kinney, Michael D >; Laszlo Ersek >Subject:

[edk2] [PATCH] BaseTools:PackageDocumentTools import lib error occurs.

2019-02-21 Thread Fan, ZhijuX
Steps: 1. Download edk2 tree 2. Build BaseTools 3. Go to edk2\BaseTools\Scripts\PackageDocumentTools to run packagedoc_cli.py An error occurs if relative imports are used when running a file alone Cc: Bob Feng Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.1

Re: [edk2] [Patch edk2 Wiki] Add three features for edk2-stable201903

2019-02-21 Thread Gao, Liming
Sorry for confuse. I just realize this patch wrongly remove SMM CET support in Q1 planning. This change is not in this patch scope. I will add back it. Thanks Liming >-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of >Liming Gao >Sent: Wednesday,

[edk2] [PATCH] Convert PosixLike scripts to sh, reduce duplication and fix some bugs

2019-02-21 Thread Rebecca Cran via edk2-devel
Since the scripts in the PosixLike directory are very simple, convert them to use /bin/sh, and move duplicated code into common files (one for python scripts, one for C binaries). Fix some bugs in edksetup.sh and BuildEnv: `test` uses single equals instead of double equals, and should have a

[edk2] [PATCH] BaseTools: Convert PosixLike scripts to sh, reduce duplication and fix some bugs in edksetup.sh and BuildEnv

2019-02-21 Thread Rebecca Cran via edk2-devel
To make it easier to use EDK2 on systems other than Linux, where the default shell might not be bash, I'd like to convert the shell scripts to use POSIX sh where possible. edksetup.sh and BuildEnv remain bash scripts, but I hope to convert them to sh in a future changeset. I did see the

[edk2] [PATCH 1/2] ShellPkg/UefiShellAcpiViewCommandLib: Add a description in uni

2019-02-21 Thread Zhichao Gao
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1146 Add DSDT and SSDT description in the help information. Add a note to clarify the use of -s option with indicated AcpiTable type parameter. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Zhichao Gao Cc: Ray Ni Cc:

[edk2] [PATCH 2/2] ShellPkg/UefiShellAcpiViewCommandLib: Change the description in uni

2019-02-21 Thread Zhichao Gao
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1153 The '-s' option of 'acpiview' do not support multiply invocation options. So clarify it for users. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Zhichao Gao Cc: Ray Ni Cc: Jaben Carsey Cc: Liming Gao ---

[edk2] [PATCH 1/3] MdePkg/BaseLib: Add Shadow Stack Support for X86.

2019-02-21 Thread Jiewen Yao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1521 This patch adds SSP - shadow stack pointer to JumpBuffer. It will be used for the platform that enabled CET/ShadowStack. Cc: Michael D Kinney Cc: Liming Gao Cc: Eric Dong Cc: Ray Ni Cc: Laszlo Ersek Contributed-under: TianoCore

[edk2] [PATCH 2/3] UefiCpuPkg/ExceptionLib: Add CET support.

2019-02-21 Thread Jiewen Yao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1521 Add information dump for Control Protection exception. Cc: Eric Dong Cc: Ray Ni Cc: Laszlo Ersek Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Yao Jiewen ---

[edk2] [PATCH 3/3] UefiCpuPkg/PiSmmCpu: Add Shadow Stack Support for X86 SMM.

2019-02-21 Thread Jiewen Yao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1521 We scan the SMM code with ROPgadget. http://shell-storm.org/project/ROPgadget/ https://github.com/JonathanSalwan/ROPgadget/tree/master This tool reports the gadget in SMM driver. This patch enabled CET ShadowStack for X86 SMM. If CET is

[edk2] [PATCH 0/3] Add SMM CET support

2019-02-21 Thread Jiewen Yao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1521 This patch series implement add CET ShadowStack support for SMM. The CET document can be found at: https://software.intel.com/sites/default/files/managed/4d/2a/control-flow-enforcement-technology-preview.pdf Patch 1 adds SSP

Re: [edk2] [Patch edk2 Wiki] Add ATA Security feature set support for edk2-stable201903

2019-02-21 Thread Gao, Liming
Reviewed-by: Liming Gao > -Original Message- > From: Wu, Hao A > Sent: Thursday, February 21, 2019 2:05 PM > To: edk2-devel@lists.01.org > Cc: Wu, Hao A ; Gao, Liming > Subject: [Patch edk2 Wiki] Add ATA Security feature set support for > edk2-stable201903 > > Cc: Liming Gao >

Re: [edk2] [PATCH V2] BaseTool/GenC: Fix build error when type is BASE or USER_DEFINED.

2019-02-21 Thread Feng, Bob C
Reviewed-by: Bob Feng -Original Message- From: Yao, Jiewen Sent: Thursday, February 21, 2019 9:38 AM To: edk2-devel@lists.01.org Cc: Feng, Bob C ; Gao, Liming ; Zhu, Yonghong Subject: [PATCH V2] BaseTool/GenC: Fix build error when type is BASE or USER_DEFINED.

Re: [edk2] [PATCH v6 00/13] Split the S3 PEI phase HW init codes from Opal driver

2019-02-21 Thread Wu, Hao A
Thanks all, Series pushed via commits: 94e0dd1afe53d23286968130d836ff0755c17c9b..a3efbc29c45183fe69bcb311c2d974ddc4e7c00a Best Regards, Hao Wu > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Hao Wu > Sent: Thursday, February 21, 2019 8:24

[edk2] [PATCH v3 1/2] MdePkg: Implement SCSI commands for Security Protocol In/Out

2019-02-21 Thread Christopher J Zurcher
This patch implements the Security Protocol In and Security Protocol Out commands in UefiScsiLib to prepare support for the Storage Security Command Protocol. Cc: Jiewen Yao Cc: Jian J Wang Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Christopher J

[edk2] [PATCH v3 0/2] Add SCSI Support for Storage Security Command Protocol

2019-02-21 Thread Christopher J Zurcher
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1546 V3 changes: Initialize AlignedBuffer variable in ScsiDiskReceiveData and ScsiDiskSendData functions. Remove redundant input validation and debug message in ScsiDiskSendData. V2 changes: Split the patch into separate commits for separate

[edk2] [PATCH v3 2/2] MdeModulePkg/ScsiDiskDxe: Support Storage Security Command Protocol

2019-02-21 Thread Christopher J Zurcher
This patch implements the EFI_STORAGE_SECURITY_COMMAND_PROTOCOL in the ScsiDiskDxe driver. Support is currently limited to the RPMB Well-known LUN for UFS devices. Cc: Jiewen Yao Cc: Jian J Wang Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Christopher

Re: [edk2] [PATCH v3 1/5] MdeModulePkg/UefiBootManagerLib: fix LoadImage/StartImage status code rep.

2019-02-21 Thread Bi, Dandan
Hi Laszlo, Thanks for helping fix it. Reviewed-by: Bi Dandan Thanks, Dandan > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Thursday, February 21, 2019 6:41 PM > To: edk2-devel@lists.01.org > Cc: Bi, Dandan ; Wu, Hao A ; > Wang, Jian J ; Ni, Ray ; Sean >

[edk2] [PATCH] IntelSiliconPkg/MicrocodeUpdate: Fix incorrect checksum issue

2019-02-21 Thread Chen A Chen
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1020 The same issue has fixed in UefiCpuPkg/Microcode.c file. Please reference b6f67b4d58b81f12f63f5f8c94cf8af3600297ab to get more detail information. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Chen A Chen Cc: Ray

[edk2] [PATCH] MdeModulePkg: Rename confusion function name

2019-02-21 Thread Chen A Chen
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1536 To avoid the confusion caused by function name, rename EfiBootManagerGetNextFullDevicePath to EfiBootManagerGetNextLoadOptionDevicePath. As an API function should add EFIAPI prefix for this function. Cc: Ray Ni Cc: Liming Gao

Re: [edk2] [PATCHv2 1/1] MdeModulePkg/SdMmcPciHcDxe Fix eMMC HS400 switch sequence

2019-02-21 Thread Wu, Hao A
> -Original Message- > From: Philippe Mathieu-Daudé [mailto:phi...@redhat.com] > Sent: Friday, February 22, 2019 4:57 AM > To: Wu, Hao A; edk2-devel@lists.01.org > Cc: Albecki, Mateusz > Subject: Re: [edk2] [PATCHv2 1/1] MdeModulePkg/SdMmcPciHcDxe Fix > eMMC HS400 switch sequence > > Hi

[edk2] Configure bugs.tianocore.org as an alias for bugzilla.tianocore.org?

2019-02-21 Thread Rebecca Cran via edk2-devel
Could we allow people to access the Bugzilla tracker via bugs.tianocore.org (in addition to bugzilla.tianocore.org) please? It looks like .tianocore.org (except www, bugzilla etc.) is configured as address 54.245.252.80, which just times out trying to access via http or https. -- Rebecca

[edk2] [PATCH] Maintainers.txt: Register myself as OvmfPkg/ArmVirtPkg reviewer

2019-02-21 Thread Philippe Mathieu-Daude
Part of my assignment is to review OVMF and ArmVirt patches, having my address listed will help me to catch the related patches. Signed-off-by: Philippe Mathieu-Daude --- Maintainers.txt | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Maintainers.txt b/Maintainers.txt index

Re: [edk2] [PATCHv2 1/1] MdeModulePkg/SdMmcPciHcDxe Fix eMMC HS400 switch sequence

2019-02-21 Thread Philippe Mathieu-Daudé
Hi Hao A, On 2/20/19 2:11 AM, Wu, Hao A wrote: > Thanks Mateusz, > > Reviewed-by: Hao Wu > And pushed via commit 68c67d3a2a33261e41ff0123129b4e9759617f71. I think you mean "pushed 'after' commit 68c67d3a2a33261e41ff0123129b4e9759617f71". Commit 68c67d3a2a33261e41ff0123129b4e9759617f71 is:

Re: [edk2] [PATCH] Maintainers.txt: Update e-mail address for Julien Grall

2019-02-21 Thread Laszlo Ersek
On 02/21/19 16:21, Julien Grall wrote: > I don't watch much my Linaro e-mail anymore. So update my e-mail address > from Linaro to the Arm one. > > Contributed-under: Tianocore Contribution Agreement 1.1 > Signed-off-by: Julien Grall > --- > Maintainers.txt | 4 ++-- > 1 file changed, 2

Re: [edk2] [PATCH v2 0/2] Maintainers: updates for ArmVirtPkg and OvmfPkg

2019-02-21 Thread Laszlo Ersek
On 02/21/19 13:28, Laszlo Ersek wrote: > Previous version: > [edk2] [PATCH] Maintainers: add TPM2 reviewers for OvmfPkg > https://lists.01.org/pipermail/edk2-devel/2019-February/036495.html > > Patch #1 in v2 is an iteration of the above. Patch #2 in v2 is new. > > Cc: Andrew Fish > Cc:

[edk2] [PATCH 2/2] DynamicTablesPkg/AcpiSpcrLibArm: Support 16550 UART.

2019-02-21 Thread Ashish Singhal
Add support for 16550 UART to ACPI SPCR table as it is a supported UART type by HLOS. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ashish Singhal --- DynamicTablesPkg/Library/Acpi/Arm/AcpiSpcrLibArm/SpcrGenerator.c | 2 ++ 1 file changed, 2 insertions(+) diff --git

[edk2] [PATCH 1/2] DynamicTablesPkg/DynamicTableManagerDxe: Update DEPEX

2019-02-21 Thread Ashish Singhal
DynamicTableManagerDxe initialization fails if gEdkiiDynamicTableFactoryProtocolGuid, gEdkiiConfigurationManagerProtocolGuid and gEfiAcpiTableProtocolGuid are not already available. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ashish Singhal ---

[edk2] [PATCH edk2-platforms v1 0/4] Platform/ARM: Updates corresponding to Dynamic Tables Framework changes

2019-02-21 Thread Sami Mujawar
The Dynamic tables framework has been updated to incorporated a series of updates namely: * Resolving DEPEX order for modules. * Removing GIC Distributor ID This patch series implement the corresponding changes required in the platform Configuration Manager. Note: This patch series is

[edk2] [PATCH 0/2] DynamicTablesPkg Updates

2019-02-21 Thread Ashish Singhal
DynamicTablesPkg/DynamicTableManagerDxe: Update DEPEX This patch adds appropriate dependencies to DynamicTableManagerDxe. The initialization function fails if gEdkiiDynamicTableFactoryProtocolGuid and gEdkiiConfigurationManagerProtocolGuid are not present already. Since we are not relying on a

[edk2] [PATCH edk2-platforms v1 2/4] Platform/ARM: FVP: Configuration Manager depex

2019-02-21 Thread Sami Mujawar
The Configuration Manager needs to be loaded before other Dynamic Tables Framework Modules. Fix the DEPEX section for Configuration Manager Dxe to remove incorrect dependency. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Sami Mujawar ---

[edk2] [PATCH edk2-platforms v1 3/4] Platform/ARM: FVP: Config Mgr remove GICD ID

2019-02-21 Thread Sami Mujawar
According to ACPI 6.2 Specification - Errata A, 'One, and only one, GIC distributor structure must be present in the MADT for an ARM based system'. Accordingly the CM_ARM_GICD_INFO structure has been updated to remove the GicId field as this value is set to zero by the MADT generator. This update

[edk2] [PATCH edk2-platforms v1 1/4] Platform/ARM: Juno: Configuration Manager depex

2019-02-21 Thread Sami Mujawar
The Configuration Manager needs to be loaded before other Dynamic Tables Framework Modules. Fix the DEPEX section for Configuration Manager Dxe to remove incorrect dependency. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Sami Mujawar ---

[edk2] [PATCH edk2-platforms v1 4/4] Platform/ARM: Juno: Config Mgr remove GICD ID

2019-02-21 Thread Sami Mujawar
According to ACPI 6.2 Specification - Errata A, 'One, and only one, GIC distributor structure must be present in the MADT for an ARM based system'. Accordingly the CM_ARM_GICD_INFO structure has been updated to remove the GicId field as this value is set to zero by the MADT generator. This update

[edk2] [PATCH v1 6/6] DynamicTablesPkg: Minor updates and fix typos

2019-02-21 Thread Sami Mujawar
Minor updates to comments and typo fixes. Also removed unused structure CM_ARM_CPU_INFO_LIST. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Sami Mujawar --- DynamicTablesPkg/Include/ArmNameSpaceObjects.h | 66 1 file changed, 55 insertions(+), 11

[edk2] [PATCH v1 3/6] DynamicTablesPkg: Add OEM Info

2019-02-21 Thread Sami Mujawar
Added option for OEMs to provide OEM Table ID and OEM Revision for ACPI tables. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Sami Mujawar --- DynamicTablesPkg/Include/Library/TableHelperLib.h| 4 +-- DynamicTablesPkg/Include/StandardNameSpaceObjects.h

[edk2] [PATCH v1 1/6] DynamicTablesPkg: Fix depex and protocol section

2019-02-21 Thread Sami Mujawar
Updated the DynamicTableFactoryDxe and DynamicTableManagerDxe to setup the correct dependency order. Also updated the Protocols section to reflect the protocols that are produced or consumed. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Sami Mujawar ---

[edk2] [PATCH v1 4/6] DynamicTablesPkg: DGB2: Update DBG2_DEBUG_PORT_DDI

2019-02-21 Thread Sami Mujawar
The DBG2_DEBUG_PORT_DDI() macro supports adding only one Generic Base Address Register. Therefore, removed the superfluous parameter NumReg and updated the macro to use DBG2_NUMBER_OF_GENERIC_ADDRESS_REGISTERS which has a value 1. Contributed-under: TianoCore Contribution Agreement 1.1

[edk2] [PATCH v1 2/6] DynamicTablesPkg: Rename enum used for ID Mapping

2019-02-21 Thread Sami Mujawar
Renamed the enum EArmObjIdMapping to EArmObjIdMappingArray and updated the IORT generator accordingly. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Sami Mujawar --- DynamicTablesPkg/Include/ArmNameSpaceObjects.h | 2 +-

[edk2] [PATCH v1 0/6] DynamicTablesPkg: Framework updates and fixes

2019-02-21 Thread Sami Mujawar
This patch series updates the Dynamic Tables Framework to incorporate the following changes: * Fix DEPEX to load modules in correct order. * Add options for OEMs to provide OEM Table ID and revision. * Update DBG2_DEBUG_PORT_DDI macro to remove unused parameter. * Remove GIC Distributor ID

[edk2] [PATCH v1 5/6] DynamicTablesPkg: Remove GIC Distributor Id field

2019-02-21 Thread Sami Mujawar
According to ACPI 6.2 Specification - Errata A, 'One, and only one, GIC distributor structure must be present in the MADT for an ARM based system'. Therefore, the GIC Distributor ID field in the ACPI MADT GICD substructure can be set to zero and there is no need for the Configuration Manager to

Re: [edk2] [PATCH v2 1/2] Maintainers: add TPM2 reviewers for OvmfPkg

2019-02-21 Thread Marc-André Lureau
Hi On Thu, Feb 21, 2019 at 1:28 PM Laszlo Ersek wrote: > > OVMF can be built with a significant amount of TPM2 code now; add > Marc-André and Stefan as Reviewers for TPM2-related patches. > > Keep the list of "R" entries alphabetically sorted. > > Cc: Andrew Fish > Cc: Ard Biesheuvel > Cc:

Re: [edk2] [PATCH] Maintainers.txt: Update e-mail address for Julien Grall

2019-02-21 Thread Julien Grall
Hi, On 21/02/2019 16:47, Laszlo Ersek wrote: On 02/21/19 16:21, Julien Grall wrote: I don't watch much my Linaro e-mail anymore. So update my e-mail address from Linaro to the Arm one. Contributed-under: Tianocore Contribution Agreement 1.1 Signed-off-by: Julien Grall --- Maintainers.txt |

Re: [edk2] [PATCH v2 2/2] Maintainers: specify the scope for OvmfPkg/ArmVirtPkg Xen module reviewers

2019-02-21 Thread Laszlo Ersek
On 02/21/19 17:49, Julien Grall wrote: > Hi Laszlo, > > On 21/02/2019 12:28, Laszlo Ersek wrote: >> We can use the format introduced under MdeModulePkg to clarify the >> reviewership scopes a little. This should decrease the review spam that >> Xen reviewers get. >> >> Cc: Andrew Fish >> Cc:

Re: [edk2] [PATCH v2 2/2] Maintainers: specify the scope for OvmfPkg/ArmVirtPkg Xen module reviewers

2019-02-21 Thread Julien Grall
Hi Laszlo, On 21/02/2019 12:28, Laszlo Ersek wrote: We can use the format introduced under MdeModulePkg to clarify the reviewership scopes a little. This should decrease the review spam that Xen reviewers get. Cc: Andrew Fish Cc: Anthony Perard Cc: Ard Biesheuvel Cc: Jordan Justen Cc:

Re: [edk2] [PATCH] Maintainers.txt: Update e-mail address for Julien Grall

2019-02-21 Thread Laszlo Ersek
On 02/21/19 16:21, Julien Grall wrote: > I don't watch much my Linaro e-mail anymore. So update my e-mail address > from Linaro to the Arm one. > > Contributed-under: Tianocore Contribution Agreement 1.1 > Signed-off-by: Julien Grall > --- > Maintainers.txt | 4 ++-- > 1 file changed, 2

Re: [edk2] [PATCH] Maintainers.txt: Update e-mail address for Julien Grall

2019-02-21 Thread Ard Biesheuvel
On Thu, 21 Feb 2019 at 16:29, Julien Grall wrote: > > I don't watch much my Linaro e-mail anymore. So update my e-mail address > from Linaro to the Arm one. > > Contributed-under: Tianocore Contribution Agreement 1.1 > Signed-off-by: Julien Grall Acked-by: Ard Biesheuvel > --- >

[edk2] [PATCH] Maintainers.txt: Update e-mail address for Julien Grall

2019-02-21 Thread Julien Grall
I don't watch much my Linaro e-mail anymore. So update my e-mail address from Linaro to the Arm one. Contributed-under: Tianocore Contribution Agreement 1.1 Signed-off-by: Julien Grall --- Maintainers.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Maintainers.txt

[edk2] [Patch V2] BaseTools: Correct the value assignment for StructurePcd

2019-02-21 Thread Feng, Bob C
This patch is to fix the code bug in StructurePcd overall value assignment logic. If a Pcd Array size is fixed but the size of actual value in Dsc or Dec is bigger than the Pcd array size, the tool will report error about such setting and stop build. Contributed-under: TianoCore Contribution

Re: [edk2] [PATCH v2 2/2] Maintainers: specify the scope for OvmfPkg/ArmVirtPkg Xen module reviewers

2019-02-21 Thread Anthony PERARD
On Thu, Feb 21, 2019 at 01:28:04PM +0100, Laszlo Ersek wrote: > We can use the format introduced under MdeModulePkg to clarify the > reviewership scopes a little. This should decrease the review spam that > Xen reviewers get. > > Cc: Andrew Fish > Cc: Anthony Perard > Cc: Ard Biesheuvel > Cc:

Re: [edk2] [PATCH v2 0/2] Maintainers: updates for ArmVirtPkg and OvmfPkg

2019-02-21 Thread Ard Biesheuvel
On Thu, 21 Feb 2019 at 13:28, Laszlo Ersek wrote: > > Previous version: > [edk2] [PATCH] Maintainers: add TPM2 reviewers for OvmfPkg > https://lists.01.org/pipermail/edk2-devel/2019-February/036495.html > > Patch #1 in v2 is an iteration of the above. Patch #2 in v2 is new. > > Cc: Andrew

[edk2] [PATCH v2 1/2] Maintainers: add TPM2 reviewers for OvmfPkg

2019-02-21 Thread Laszlo Ersek
OVMF can be built with a significant amount of TPM2 code now; add Marc-André and Stefan as Reviewers for TPM2-related patches. Keep the list of "R" entries alphabetically sorted. Cc: Andrew Fish Cc: Ard Biesheuvel Cc: Jordan Justen Cc: Leif Lindholm Cc: Marc-André Lureau Cc: Michael D

[edk2] [PATCH v2 2/2] Maintainers: specify the scope for OvmfPkg/ArmVirtPkg Xen module reviewers

2019-02-21 Thread Laszlo Ersek
We can use the format introduced under MdeModulePkg to clarify the reviewership scopes a little. This should decrease the review spam that Xen reviewers get. Cc: Andrew Fish Cc: Anthony Perard Cc: Ard Biesheuvel Cc: Jordan Justen Cc: Julien Grall Cc: Leif Lindholm Cc: Michael D Kinney

[edk2] [PATCH v2 0/2] Maintainers: updates for ArmVirtPkg and OvmfPkg

2019-02-21 Thread Laszlo Ersek
Previous version: [edk2] [PATCH] Maintainers: add TPM2 reviewers for OvmfPkg https://lists.01.org/pipermail/edk2-devel/2019-February/036495.html Patch #1 in v2 is an iteration of the above. Patch #2 in v2 is new. Cc: Andrew Fish Cc: Anthony Perard Cc: Ard Biesheuvel Cc: Jordan Justen Cc:

[edk2] [PATCH v3 3/5] OvmfPkg/PlatformBootManagerLib: display boot option loading/starting

2019-02-21 Thread Laszlo Ersek
Consume PlatformBmPrintScLib, added earlier in this series. When BdsDxe+UefiBootManagerLib report LoadImage() / StartImage() preparations and return statuses, print the reports to the UEFI console. This allows end-users better visibility into the boot process. Cc: Anthony Perard Cc: Ard

[edk2] [PATCH v3 4/5] ArmVirtPkg/ArmVirtQemu*: enable minimal Status Code Routing in DXE

2019-02-21 Thread Laszlo Ersek
The EFI_RETURN_STATUS_EXTENDED_DATA feature from PI-1.7 () enables platform code to learn about boot option failures (loading and launching) via status codes reported by the UEFI Boot Manager. In commit 59541d41633c, we removed all status code

[edk2] [PATCH v3 2/5] OvmfPkg: add library to track boot option loading/starting on the console

2019-02-21 Thread Laszlo Ersek
Introduce the Platform Boot Manager Print Status Code Library (for short, PlatformBmPrintScLib) class for catching and printing the LoadImage() / StartImage() preparations, and return statuses, that are reported by UefiBootManagerLib. In the primary library instance, catch only such status codes

[edk2] [PATCH v3 5/5] ArmVirtPkg/PlatformBootManagerLib: display boot option loading/starting

2019-02-21 Thread Laszlo Ersek
Consume PlatformBmPrintScLib, added earlier in this series. When BdsDxe+UefiBootManagerLib report LoadImage() / StartImage() preparations and return statuses, print the reports to the UEFI console. This allows end-users better visibility into the boot process. Cc: Ard Biesheuvel Ref:

[edk2] [PATCH v3 1/5] MdeModulePkg/UefiBootManagerLib: fix LoadImage/StartImage status code rep.

2019-02-21 Thread Laszlo Ersek
In the EFI_RETURN_STATUS_EXTENDED_DATA structure from PI-1.7, there may be padding between the DataHeader and ReturnStatus members. The REPORT_STATUS_CODE_EX() macro starts populating the structure immediately after DataHeader, therefore the source data must provide for the padding. Extract the

[edk2] [PATCH v3 0/5] MdeModulePkg, OvmfPkg, ArmVirtPkg: more visible boot progress reporting

2019-02-21 Thread Laszlo Ersek
Repo: https://github.com/lersek/edk2.git Branch: boot_diags_v3 Addressing feedback for v2, which was posted at: https://lists.01.org/pipermail/edk2-devel/2019-February/036965.html 20190220081644.8238-1-lersek@redhat.com">http://mid.mail-archive.com/20190220081644.8238-1-lersek@redhat.com

Re: [edk2] [PATCH] MdeModulePkg/VariableSmmRuntimeDxe: Refactor locating Variable Arch Protocol

2019-02-21 Thread Ard Biesheuvel
On Thu, 21 Feb 2019 at 10:33, Zeng, Star wrote: > > On 2019/2/21 17:11, Ard Biesheuvel wrote: > > On Thu, 21 Feb 2019 at 10:04, Laszlo Ersek wrote: > >> > >> On 02/20/19 13:23, Ard Biesheuvel wrote: > >>> On Wed, 20 Feb 2019 at 06:53, Jagadeesh Ujja > >>> wrote: > > hi Ard, > On

Re: [edk2] [PATCH] MdeModulePkg/VariableSmmRuntimeDxe: Refactor locating Variable Arch Protocol

2019-02-21 Thread Zeng, Star
On 2019/2/21 17:11, Ard Biesheuvel wrote: On Thu, 21 Feb 2019 at 10:04, Laszlo Ersek wrote: On 02/20/19 13:23, Ard Biesheuvel wrote: On Wed, 20 Feb 2019 at 06:53, Jagadeesh Ujja wrote: hi Ard, On Tue, Feb 19, 2019 at 6:55 PM Ard Biesheuvel wrote: Hello Jagadeesh, On Tue, 19 Feb 2019

Re: [edk2] [PATCH] MdeModulePkg/VariableSmmRuntimeDxe: Refactor locating Variable Arch Protocol

2019-02-21 Thread Ard Biesheuvel
On Thu, 21 Feb 2019 at 10:04, Laszlo Ersek wrote: > > On 02/20/19 13:23, Ard Biesheuvel wrote: > > On Wed, 20 Feb 2019 at 06:53, Jagadeesh Ujja wrote: > >> > >> hi Ard, > >> On Tue, Feb 19, 2019 at 6:55 PM Ard Biesheuvel > >> wrote: > >>> > >>> Hello Jagadeesh, > >>> > >>> On Tue, 19 Feb 2019

Re: [edk2] [PATCH] MdeModulePkg/VariableSmmRuntimeDxe: Refactor locating Variable Arch Protocol

2019-02-21 Thread Laszlo Ersek
On 02/20/19 13:23, Ard Biesheuvel wrote: > On Wed, 20 Feb 2019 at 06:53, Jagadeesh Ujja wrote: >> >> hi Ard, >> On Tue, Feb 19, 2019 at 6:55 PM Ard Biesheuvel >> wrote: >>> >>> Hello Jagadeesh, >>> >>> On Tue, 19 Feb 2019 at 11:47, Jagadeesh Ujja wrote: In preparation for providing a

Re: [edk2] [patch 2/2] MdeModulePkg/BmBoot: Report status when fail to load/start boot option

2019-02-21 Thread Laszlo Ersek
On 02/20/19 18:19, Doran, Mark wrote: >> -Original Message- >> From: Laszlo Ersek [mailto:ler...@redhat.com] >> Sent: Wednesday, February 20, 2019 1:25 AM >> To: Ni, Ray ; Bi, Dandan >> Cc: edk2-devel@lists.01.org; Wu, Hao A ; Doran, Mark >> >> Subject: Re: [edk2] [patch 2/2]

Re: [edk2] [PATCH v2 1/5] MdeModulePkg/UefiBootManagerLib: fix LoadImage/StartImage status code rep.

2019-02-21 Thread Laszlo Ersek
On 02/20/19 14:17, Ni, Ray wrote: > On 2/20/2019 4:16 PM, Laszlo Ersek wrote: >> In the EFI_RETURN_STATUS_EXTENDED_DATA structure from PI-1.7, there >> may be >> padding between the DataHeader and ReturnStatus members. The >> REPORT_STATUS_CODE_EX() macro starts populating the structure