Re: [edk2] BaseTools features: multiple workspaces

ler...@redhat.com; Tim Lewis tim.le...@insyde.com; Gao, Liming liming@intel.com Subject: Re: [edk2] BaseTools features: multiple workspaces On Aug 5, 2015, at 12:16 PM, Jordan Justen jordan.l.jus...@intel.com wrote: On 2015-08-05 07:06:46, Gao, Liming wrote: Tim gave another idea

Re: [edk2] BaseTools features: multiple workspaces

) and the root of the source code. I don't think the current proposal disambiguates these. Tim -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jordan Justen Sent: Monday, August 03, 2015 11:55 AM To: Tim Lewis tim.le...@insyde.com; Gao, Liming liming

Re: [edk2] [PATCH v2 11/41] OvmfPkg: implement EFI_SMM_CONTROL2_PROTOCOL with a DXE_RUNTIME_DRIVER

Laszlo, The PI specification describes DynamicEx PCDs. The PCD protocol is in PI: volume 3, chapter 8. All other PCDs are EDK2 artifacts, although some bits have drifted into the packaging specification. Tim -Original Message- From: edk2-devel

Re: [edk2] worth openning gEfiSimpleTextIinputProtocol ?

Which instance? There could be dozens: one from the PS/2, one from each USB device, one from the I2C-attached touch panel, one from the serial port. gST->ConIn uses a ConSplitter to aggregate all of this input to appear as one. Tim -Original Message- From: edk2-devel

Re: [edk2] worth openning gEfiSimpleTextIinputProtocol ?

Also, I would point out: If this is a shell app, input redirection works because the shell replaces these with instances that get the data from the redirection source. Tim -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Miller, Carl H Sent:

Re: [edk2] install a PPI with a NULL Ppi value?

That looks like it is setting up for a dependency expression. Check your .infs to see if anyone uses it in their [depex] section. Tim -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Hamel, Lee M Sent: Friday, August 28, 2015 6:24 AM To:

Re: [edk2] skip enumeration of a PCI device

Lee -- How will you prevent the OS from touching this device? It seems that preventing the BIOS from touching it only delays your pain ;-) Can you disable this PCI device entirely? I.e. make it disappear from config space? Tim -Original Message- From: edk2-devel

Re: [edk2] [PATCH] MdeModulePkg: allow DxeIpl to load without permanent memory to enable S3 resume from temporary memory

Eugene -- Personally, I don't see this as a positive change. The PEI flow from the earliest days has said: at the end of PEI there is memory and there is a boot mode (see 11.2.1). You can see this assumption in 2.5 and 9.1 of the PI specification, where the result of the PEI Foundation (not

Re: [edk2] [PATCH] MdeModulePkg: allow DxeIpl to load without permanent memory to enable S3 resume from temporary memory

terminology muddle makes it hard to be precise about this kind of thing. Tim -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Cohen, Eugene Sent: Thursday, December 03, 2015 11:16 AM To: Tim Lewis <tim.le...@insyde.com>; Laszlo Erse

Re: [edk2] EDK II Spec Updates

Laurie -- Did I miss a review period for these? This would help those of us who depend on the exact syntax of the files for a living :-) Tim -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jarlstrom, Laurie Sent: Tuesday, January 05, 2016 3:36

Re: [edk2] Reboot directly to UEFI firmware settings

Look at the OsIndications UEFI variable in the UEFI specification. Tim -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Stephen Polkowski Sent: Tuesday, January 05, 2016 2:23 PM To: edk2-de...@ml01.01.org Subject: [edk2] Reboot directly to UEFI

Re: [edk2] propose 3 new UserExtensions in the INF specification

Jaben -- For the record, I think that continuing to add meta-build information to the .inf files is counter-productive. As a company that has written tools that conform to the grammar, these extensions to an .ini style file format are becoming more and more arcane to parse and process. Some

Re: [edk2] [RFC] Add more flexible PCD value formats in DEC/DSC files

d) UINT8(0x4B), "S4BKn_ComDataRead00",UINT8(0x80) } } -Original Message- From: Kinney, Michael D [mailto:michael.d.kin...@intel.com] Sent: Tuesday, June 14, 2016 6:56 PM To: Tim Lewis <tim.le...@insyde.com>; Zhu, Yonghong <yonghong@intel.com>; e

Re: [edk2] [RFC] Add more flexible PCD value formats in DEC/DSC files

is that it is not distinguishable from subtraction expressions. Tim -Original Message- From: Kinney, Michael D [mailto:michael.d.kin...@intel.com] Sent: Tuesday, June 14, 2016 4:50 PM To: Tim Lewis <tim.le...@insyde.com>; Zhu, Yonghong <yonghong@intel.com>; edk2-devel@lists.01

Re: [edk2] [RFC] Add more flexible PCD value formats in DEC/DSC files

Mike -- We have traditionally used a preprocessor to convert the following into byte arrays: UINT8(xx), UINT16(xx), UINT32(xx), UINT64(xx), BOOLEAN(TRUE|FALSE), GUID(struct-style {} or registry style "xx-yyy..."), "" (ASCII string no-nullterminator), L"" (UCS16 string no null-terminator),

Re: [edk2] [RFC] Add more flexible PCD value formats in DEC/DSC files

[mailto:michael.d.kin...@intel.com] Sent: Tuesday, June 14, 2016 4:50 PM To: Tim Lewis <tim.le...@insyde.com>; Zhu, Yonghong <yonghong@intel.com>; edk2-devel@lists.01.org; Kinney, Michael D <michael.d.kin...@intel.com> Subject: RE: [RFC] Add more flexible PCD value formats in

Re: [edk2] [RFC] Add more flexible PCD value formats in DEC/DSC files

ael D Sent: Tuesday, June 14, 2016 5:22 PM To: Tim Lewis <tim.le...@insyde.com>; Zhu, Yonghong <yonghong@intel.com>; edk2-devel@lists.01.org; Kinney, Michael D <michael.d.kin...@intel.com> Subject: Re: [edk2] [RFC] Add more flexible PCD value formats in DEC/DSC files Ti

Re: [edk2] [RFC] Add more flexible PCD value formats in DEC/DSC files

to handle data structures where offsets or sizes are required to be embedded. Doesn't work cross-PCDs, but does in more complicated data structures. Tim -Original Message- From: Kinney, Michael D [mailto:michael.d.kin...@intel.com] Sent: Tuesday, June 14, 2016 4:50 PM To: Tim Lewis <tim

Re: [edk2] PCD Local Token Numbers in PEI/DXE

Of Kinney, Michael D Sent: Wednesday, February 10, 2016 9:41 AM To: Tim Lewis <tim.le...@insyde.com>; edk2-devel@lists.01.org; Kinney, Michael D <michael.d.kin...@intel.com> Subject: Re: [edk2] PCD Local Token Numbers in PEI/DXE Hi Tim, Your description looks correct to me. The cu

[edk2] PCD Local Token Numbers in PEI/DXE

We have run into an interesting problem with the PCD database when the PEI and DXE databases were not built at the same time. This happens with boot-block type arrangements. This is not a Dynamic vs. DynamicEx issue. Short form: 1) The standard PCD database for Dynamic/DynamicEx PCDs is

Re: [edk2] PCD Local Token Numbers in PEI/DXE

might be to timestamp (rather than assume PEI before DXE). Tim -Original Message- From: Zeng, Star [mailto:star.z...@intel.com] Sent: Sunday, February 14, 2016 9:33 PM To: Kinney, Michael D <michael.d.kin...@intel.com>; Tim Lewis <tim.le...@insyde.com>; edk2-devel@lists.01.org

Re: [edk2] PCD Local Token Numbers in PEI/DXE

value. Tim -Original Message- From: Zeng, Star [mailto:star.z...@intel.com] Sent: Sunday, February 14, 2016 9:54 PM To: Tim Lewis <tim.le...@insyde.com>; Kinney, Michael D <michael.d.kin...@intel.com>; edk2-devel@lists.01.org Cc: Zeng, Star <star.z...@intel.com> Subj

Re: [edk2] PCD Local Token Numbers in PEI/DXE

y, Michael D [mailto:michael.d.kin...@intel.com] Sent: Wednesday, February 17, 2016 9:00 AM To: Gao, Liming <liming@intel.com>; Tim Lewis <tim.le...@insyde.com>; Zeng, Star <star.z...@intel.com>; edk2-devel@lists.01.org; Kinney, Michael D <michael.d.kin...@intel.co

Re: [edk2] PCD Local Token Numbers in PEI/DXE

...@intel.com] Sent: Wednesday, February 17, 2016 6:48 PM To: Kinney, Michael D <michael.d.kin...@intel.com>; Tim Lewis <tim.le...@insyde.com>; edk2-devel@lists.01.org Subject: RE: PCD Local Token Numbers in PEI/DXE Could we let PEI PCD database includes all PCDs' information used

[edk2] BOM in .dec, .dsc, .fdf

I thought I saw a thread talking about this. We are seeing an issue with a UTF-8 BOM appears at the beginning of a .dec file, even if there are no other non-ASCII characters. In our case, this causes the parser to bomb out with a stack trace. This happens to our users in Asia. I couldn't find

Re: [edk2] BOM in .dec, .dsc, .fdf

, Michael D [mailto:michael.d.kin...@intel.com] Sent: Tuesday, March 01, 2016 3:33 PM To: Tim Lewis <tim.le...@insyde.com>; edk2-devel@lists.01.org; Kinney, Michael D <michael.d.kin...@intel.com> Subject: RE: BOM in .dec, .dsc, .fdf Tim, Those files types are all required to be

Re: [edk2] BOM in .dec, .dsc, .fdf

] Sent: Wednesday, March 02, 2016 11:27 PM To: Tim Lewis <tim.le...@insyde.com>; Kinney, Michael D <michael.d.kin...@intel.com>; edk2-devel@lists.01.org Subject: RE: BOM in .dec, .dsc, .fdf Tim: So, you suggest to let build tool report the meaning error message if .dec, .dsc, .

Re: [edk2] [PATCH 17/19] IntelFspWrapperPkg/FspInit: Split FspInitPei to FspmWrapperPeim and FspsWrapperPeim.

Yes. Tim -Original Message- From: Yao, Jiewen [mailto:jiewen@intel.com] Sent: Monday, May 09, 2016 6:42 PM To: Kinney, Michael D <michael.d.kin...@intel.com>; Tim Lewis <tim.le...@insyde.com>; Mudusuru, Giri P <giri.p.mudus...@intel.com>; edk2-devel@lists.01.org

Re: [edk2] [PATCH 17/19] IntelFspWrapperPkg/FspInit: Split FspInitPei to FspmWrapperPeim and FspsWrapperPeim.

Is this really a good idea, dropping 1.1 support? We don't maintain two separate trees for our products, just 1. There are several chipsets which have long life that will need additional features, but are only 1.1 Tim -Original Message- From: edk2-devel

Re: [edk2] [PATCH 17/19] IntelFspWrapperPkg/FspInit: Split FspInitPei to FspmWrapperPeim and FspsWrapperPeim.

u can have both in a single tree. Thanks, -Giri -Original Message- From: Tim Lewis [mailto:tim.le...@insyde.com] Sent: Tuesday, May 3, 2016 4:48 AM To: Yao, Jiewen <jiewen@intel.com>; edk2-devel@lists.01.org Cc: Mudusuru, Giri P <giri.p.mudus...@intel.com>; Rangarajan, Ravi P &l

Re: [edk2] [PATCH 17/19] IntelFspWrapperPkg/FspInit: Split FspInitPei to FspmWrapperPeim and FspsWrapperPeim.

That works well, thank you Tim Sent from my Windows 10 phone From: Mudusuru, Giri P<mailto:giri.p.mudus...@intel.com> Sent: Thursday, May 5, 2016 12:07 PM To: Tim Lewis<mailto:tim.le...@insyde.com>; Yao, Jiewen<mailto:jiewen@intel.com>; edk2-devel@lists.01.org<mailt

Re: [edk2] [PATCH 17/19] IntelFspWrapperPkg/FspInit: Split FspInitPei to FspmWrapperPeim and FspsWrapperPeim.

Thank you. Tim Sent from my Windows 10 phone From: Mudusuru, Giri P<mailto:giri.p.mudus...@intel.com> Sent: Tuesday, May 3, 2016 11:06 PM To: Tim Lewis<mailto:tim.le...@insyde.com>; Yao, Jiewen<mailto:jiewen@intel.com>; edk2-devel@lists.01.org<mailto:edk2-d

Re: [edk2] [PATCH 17/19] IntelFspWrapperPkg/FspInit: Split FspInitPei to FspmWrapperPeim and FspsWrapperPeim.

the final file resides. That leads to bad bug reports, etc. Tim -Original Message- From: Kinney, Michael D [mailto:michael.d.kin...@intel.com] Sent: Thursday, May 05, 2016 6:14 PM To: Tim Lewis <tim.le...@insyde.com>; Mudusuru, Giri P <giri.p.mudus...@intel.com>; Yao, Ji

Re: [edk2] [PATCH 17/19] IntelFspWrapperPkg/FspInit: Split FspInitPei to FspmWrapperPeim and FspsWrapperPeim.

product launch. Because of features and security concerns, we continually upgrade our chipsets to use newer kernel code. This puts an extra variable. Regards, Tim Lewis CTO, Insyde Software www.insyde.com From: Mudusuru, Giri P [mailto:giri.p.mudus...@intel.com] Sent: Tuesday, May 03, 2016 4:07 PM

Re: [edk2] [PATCH] MdePkg: Add DmaRemappingReportingTable.h

Giri -- Is MdePkg the right place for this? This appears to be an Intel-specific definition, right? I understand that it was in IndustryStandard for EdkCompatibilityPkg, but it might do better now in the IntelSiliconPkg. Regards, Tim -Original Message- From: edk2-devel

Re: [edk2] [PATCH] MdePkg: Add DmaRemappingReportingTable.h

, 2016 9:29 AM To: Tim Lewis <tim.le...@insyde.com>; Giri P Mudusuru <giri.p.mudus...@intel.com>; edk2-devel@lists.01.org <edk2-de...@ml01.01.org> Cc: Michael Kinney <michael.d.kin...@intel.com>; Jiewen Yao <jiewen@intel.com>; Liming Gao <liming@intel.com>

Re: [edk2] [PATCH] add top-level .gitattributes file, dealing with .depex

[mailto:jordan.l.jus...@intel.com] Sent: Monday, August 01, 2016 12:03 AM To: Kinney, Michael D <michael.d.kin...@intel.com>; Leif Lindholm <leif.lindh...@linaro.org>; Tim Lewis <tim.le...@insyde.com>; Kinney, Michael D <michael.d.kin...@intel.com> Cc: Laszlo Ersek <ler...@re

Re: [edk2] StdLib usage for drivers?

-Original Message- From: Carsey, Jaben [mailto:jaben.car...@intel.com] Sent: Wednesday, July 06, 2016 2:02 PM To: Tim Lewis <tim.le...@insyde.com>; af...@apple.com Cc: edk2-devel@lists.01.org; Michael Zimmermann <sigmaepsilo...@gmail.com>; Daryl McDaniel (edk2-li...@mc2researc

Re: [edk2] StdLib usage for drivers?

Jaben -- I can certainly recall instances where drivers that publish HII setup pages load things from the disk (such as when checking for specific file names). I also seem to recall that the original EDK shell library was designed to that volume names were simply ignored if the shell protocol

Re: [edk2] StdLib usage for drivers?

smaller and cleaner shell applications. Tim -Original Message- From: Carsey, Jaben [mailto:jaben.car...@intel.com] Sent: Wednesday, July 06, 2016 2:12 PM To: Tim Lewis <tim.le...@insyde.com>; af...@apple.com Cc: edk2-devel@lists.01.org; Michael Zimmermann <sigmaepsilo...@

Re: [edk2] Shell version 2.2

Jaben -- Are there no shell commands where the standard command-line parameters have changed? Tim -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Carsey, Jaben Sent: Friday, August 05, 2016 10:26 AM To: Meenakshi Aggarwal

Re: [edk2] Shell version 2.2

riginal Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Carsey, Jaben Sent: Friday, August 05, 2016 12:10 PM To: Tim Lewis <tim.le...@insyde.com>; Meenakshi Aggarwal <meenakshi.aggar...@nxp.com>; edk2-devel@lists.01.org <edk2-de...@ml01.01.org

Re: [edk2] [PATCH] add top-level .gitattributes file, dealing with .depex

It appears that this file is not actually used. It is only referenced in the [Rule.Common.UEFI_DRIVER.NATIVE_BINARY] rule in PlatformPkg.fdf. A little further research shows that an alternate method was used for the actual GOP binary (see below). A grep of the entire tree shows that no one uses

Re: [edk2] Print from DXE_DRIVER

Also, on many systems, the output will be invisible, since boot screen output is a platform policy. In general, using DEBUG() is better, since it can either be redirected to StdErr() or through the serial port. Tim -Original Message- From: edk2-devel

Re: [edk2] [PATCH 3/3] ShellPkg SmbiosView: Add decoding of SMBIOS spec 3.1.1

: Carsey, Jaben [mailto:jaben.car...@intel.com] Sent: Monday, January 23, 2017 1:48 PM To: Tim Lewis <tim.le...@insyde.com>; Ni, Ruiyu <ruiyu...@intel.com>; Zeng, Star <star.z...@intel.com>; edk2-devel@lists.01.org Cc: Carsey, Jaben <jaben.car...@intel.com> Subject: RE: [PATCH

Re: [edk2] [PATCH 3/3] ShellPkg SmbiosView: Add decoding of SMBIOS spec 3.1.1

: Monday, January 23, 2017 1:59 PM To: Tim Lewis <tim.le...@insyde.com>; Ni, Ruiyu <ruiyu...@intel.com>; Zeng, Star <star.z...@intel.com>; edk2-devel@lists.01.org Cc: Carsey, Jaben <jaben.car...@intel.com> Subject: RE: [PATCH 3/3] ShellPkg SmbiosView: Add decoding of SMBIOS spe

Re: [edk2] [PATCH 3/3] ShellPkg SmbiosView: Add decoding of SMBIOS spec 3.1.1

onal shell in a much more restricted environment. Tim -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Carsey, Jaben Sent: Monday, January 23, 2017 1:15 PM To: Tim Lewis <tim.le...@insyde.com>; Ni, Ruiyu <ruiyu...@intel.com>; Zeng, Sta

Re: [edk2] [PATCH 3/3] ShellPkg SmbiosView: Add decoding of SMBIOS spec 3.1.1

Also, in some cases, the text is taken directly from the specification. Introducing HII strings in order to make these translatable when the source material is normative doesn't help, IMO. Tim -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of

[edk2] SetCurDir() doesn't allow '\\' in Dir?

I did a simple break apart of a path into map-name and directory. fs0:\MdeModulePkg So FileSystem was "fs0:" and Dir was "\MdeModulePkg" and the resulting working directory was: "fs0:MdeModulePkg" (with escape characters).. It seems the culprit is in EfiShellSetCurDir: if

Re: [edk2] Assert in ShellPkg with latest tianocore edk2 source on the Reference Platform

Jaben -- In which cases would you have the Shell protocol present and not have the Unicode Collation protocol? By my count, the Shell itself cannot function without it (see ProcessCommandLine()). Tim -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On

Re: [edk2] Assert in ShellPkg with latest tianocore edk2 source on the Reference Platform

Daniil -- Per your point about modules: Adding a dependency expression to a library should NOT have any effect on an application, since applications do not have dependency expressions. So this would indicate that you are trying to link a driver against the UefiShellLib. Is this correct?

Re: [edk2] Assert in ShellPkg with latest tianocore edk2 source on the Reference Platform

Is it possible that Daniil has UnicodeCollation and not UnicodeCollation2? The shell itself can handle this case, but the ShellLib cannot. Tim -Original Message- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Wednesday, October 05, 2016 1:58 PM To: Tim Lewis <tim.le...@insyde.

Re: [edk2] Assert in ShellPkg with latest tianocore edk2 source on the Reference Platform

...@apple.com] Sent: Wednesday, October 05, 2016 1:59 PM To: Laszlo Ersek <ler...@redhat.com> Cc: Tim Lewis <tim.le...@insyde.com>; Carsey, Jaben <jaben.car...@intel.com>; Shah, Tapan <tapands...@hpe.com>; Daniil Egranov <daniil.egra...@arm.com>; edk2-devel-01 <edk2-

Re: [edk2] Assert in ShellPkg with latest tianocore edk2 source on the Reference Platform

ionMap.SetFileInfo(*FileHandle, FileInfo); FreePool(FileInfo); if (EFI_ERROR (Status2)) { gEfiShellProtocol->CloseFile(*FileHandle); } Status = Status2; } -Original Message- From: Carsey, Jaben [mailto:jaben.car...@intel.com] Sent: Wednesday, October 05, 2016 2:17 P

Re: [edk2] Protocol EFI_FORM_BROWSER_EXTENSION_PROTOCOL - included in UDK code but not part of the spec

Liming -- Could you change the protocol name, and then use a typedef with the old name for compatibility? Tim -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Gao, Liming Sent: Tuesday, September 20, 2016 8:57 PM To: Boaz Kahana

Re: [edk2] RFC: ProtocolLib for cross DXE and SMM Protocol and Handle Services

Eugene -- Since SMM drivers today are actually DXE drivers during the initialization phase, are you going to (a) have your library check InSmm? or (b) only work with pure SMM stand-alone drivers? Thanks, Tim -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org]

Re: [edk2] RFC: ProtocolLib for cross DXE and SMM Protocol and Handle Services

Eugene -- Since the standalone file type isn't yet in the EDK2 code, the build system will not be able to make this distinction in the library's INF file. Tim -Original Message- From: Cohen, Eugene [mailto:eug...@hp.com] Sent: Friday, September 30, 2016 9:51 AM To: Tim Lewis <tim

Re: [edk2] [shell] AliasLower never used in InternalSetAlias

.org] On Behalf Of Tim Lewis Sent: Thursday, October 27, 2016 2:11 PM To: edk2-devel@lists.01.org Subject: [edk2] [shell] AliasLower never used in InternalSetAlias In the function InternalSetAlias, it appears that AliasLower is duplicated (fromAlias), converted to lower case and freed ,but never

[edk2] [shell] AliasLower never used in InternalSetAlias

In the function InternalSetAlias, it appears that AliasLower is duplicated (fromAlias), converted to lower case and freed ,but never actually used. Am I missing something? // Convert to lowercase to make aliases case-insensitive if (Alias != NULL) { AliasLower = AllocateCopyPool

[edk2] [shell]cd.. and cd\ are not valid alias

But the EDK2 registers them as a part of Level 2 supported command initialization. ShellCommandRegisterAlias(L"cd ..", L"cd.."); ShellCommandRegisterAlias(L"cd \\", L"cd\\"); According to the SetAlias() description: An alias is a C-style identifier The same language is repeated in 3.6.4.

Re: [edk2] [shell] AliasLower never used in InternalSetAlias

ar...@intel.com] Sent: Friday, October 28, 2016 8:20 AM To: Tim Lewis <tim.le...@insyde.com>; edk2-devel@lists.01.org Cc: Carsey, Jaben <jaben.car...@intel.com> Subject: RE: [shell] AliasLower never used in InternalSetAlias Tim, Given that all commands are case insensitive, I couldn't

Re: [edk2] [shell] AliasLower never used in InternalSetAlias

Sure. I think we should adjust the specification in this case. My problem has been when someone says "but the EDK2 version does X" Tim -Original Message- From: Carsey, Jaben [mailto:jaben.car...@intel.com] Sent: Friday, October 28, 2016 9:59 AM To: Tim Lewis <tim.le.

[edk2] FW: [shell] Problems in EfiShellGetGuidFromName

Did anyone have a chance to look at this EFI_SHELL_PROTOCOL bug in the EDK2 implementation? Thanks, Tim -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Tim Lewis Sent: Thursday, October 13, 2016 11:16 AM To: edk2-devel-01 <edk2-devel@lists

Re: [edk2] [PATCH] ShellPkg/Shell: fix CopyGuid() arg order in EfiShellGetGuidFromName()

Reviewed-by: Tim Lewis <tim.le...@insyde.com> -Original Message- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Tuesday, October 18, 2016 4:07 AM To: edk2-devel-01 <edk2-de...@ml01.01.org> Cc: Jaben Carsey <jaben.car...@intel.com>; Ruiyu Ni <ruiyu...@intel.com

[edk2] [shell] Problems in EfiShellGetGuidFromName

In EfiShellGetGuidFromName (ShellProtocol.c), we see: EfiShellGetGuidFromName( IN CONST CHAR16 *GuidName, OUT EFI_GUID *Guid ) { EFI_GUID*NewGuid; EFI_STATUS Status; if (Guid == NULL || GuidName == NULL) { return (EFI_INVALID_PARAMETER); } Status =

[edk2] AsciiPrint behavior with \n linefeed characters.

In using AsciiPrint (I'm presuming the behavior is also in Print, but I haven't tested), I found an interesting behavior for linefeed characters embedded in strings that are parameters. I post it here just so people who are mystified by their output can understand it. Consider this example:

Re: [edk2] AsciiPrint behavior with \n linefeed characters.

Liming -- And I agree that this should be the behavior. I was surprised by the lack of translation for the other string printed via %s. Tim -Original Message- From: Gao, Liming [mailto:liming@intel.com] Sent: Thursday, October 13, 2016 6:24 PM To: Tim Lewis <tim.le...@insyde.

Re: [edk2] [PATCH 0/5] Move Shell protocol definitions to MdePkg

I prefer the renamed .h file, even though I have substantial investment in the current infrastructure. Why? Because engineers don't have time to remember "how does protocol X translate to header file Y" It should be a consistent rule. How many times have I needed to grep the header file name

Re: [edk2] [PATCH 1/5] ShellPkg: Move SHELL_FREE_NON_NULL from ShellBase.h to ShellLib.h

Glad to see this is finally being done! -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ruiyu Ni Sent: Friday, October 14, 2016 2:44 AM To: edk2-devel@lists.01.org Cc: Jaben Carsey ; Michael D Kinney

[edk2] Pipe causes pool failure in Shell.c

Using the latest Shell build, try: ls -sfo | parse FileInfo 2 This ends up with a breakpoint when FreePool is called on Shell.c, line 1756. I'm still debugging, but I wondered if anyone else has seen this? Also: ls -sfo > tmp parse FileInfo 2 < tmp prints nothing, but parse tmp FileInfo 2

[edk2] [shell] Redirection to environment variable used on command-line not working.

I have a command like this: X %_key% >v _key and X %_key% _key These two commands should do, essentially the same thing, since the command 'X' calls ShellSetEnvironmentVariable() if the 2nd parameter is present. Any thoughts? Tim ___ edk2-devel

[edk2] Root Cause of Parse Failure With Redirected Input

if (StrStr (TempLine, L"ShellCommand,") == TempLine) { LoopVariable++; } This line fails because, with redirected input, the file has the UCS-2 byte order mark, so the string "ShellCommand," is not at the beginning of the line. With the file, the byte order mark is not

[edk2] [shell] Redirected Environment Variables Are Not Saved Correctly

Test by doing this, immediately after booting: Notice that echo has created a new environment variable _key to the value 4, But this variable does not show up when running "set" Why? It is because the FileHandleWrappers does not use SetEnvironmentVariable. Instead, it tries to read and write

[edk2] [shell] @ does not work before if, endif, for and many other command.

Try this: :start @if %1 == "" then @goto Done @endif @echo Parameter: %1 @shift goto start :Done Per Chapter 4 Also, additional '@' before a command in a script file can prevent the current command from being echoed.

[edk2] [shell] shift generates errors with no command-line options

In a script that looks like this: :start if not %1 == "" then echo %1 shift goto start endif 'shift' will generate an error message. The spec doesn't describe any behavior like this and it is annoying to write scripts that must avoid it. Of course you can work around it... Tim

Re: [edk2] [shell] Pipe causes pool failure in Shell.c

Jaben -- I'm not sure. In the debugger, it clearly showed the memory as having already been freed at the pointer. But I didn't track down who had done it. Tim -Original Message- From: Carsey, Jaben [mailto:jaben.car...@intel.com] Sent: Friday, December 02, 2016 8:39 AM To: Tim Lewis

Re: [edk2] UEFI Shell Lib Constructor and Shell Parameters Protocol

There are "load options" that are passed to drivers (as a part of the EFI_LOADED_IMAGE_PROTOCOL), but there is no guarantee as to their format (binary data or ASCII string or UCS-2 string). It is possible for "load" to be modified to create this data and populate it between the calls to

Re: [edk2] Using NULL| style library linkable in EDK2

Mike -- Ok, I will enter it into Bugzilla later today. Tim -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Kinney, Michael D Sent: Thursday, July 20, 2017 10:57 AM To: Tim Lewis <tim.le...@insyde.com>; edk2-devel@lists.01.org; Kinney, M

[edk2] Using NULL| style library linkable in EDK2

t; Thanks, Tim Lewis CTO, Insyde Software www.insyde.com<http://www.insyde.com> ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [edk2-UniSpecification PATCH] Allow .uni files on disk to be UTF-8 without a BOM

when one is not present won't help the vast quantities of existing UNI files out there. Tim -Original Message- From: Carsey, Jaben [mailto:jaben.car...@intel.com] Sent: Wednesday, April 26, 2017 10:45 AM To: Tim Lewis <tim.le...@insyde.com>; Kinney, Michael D <michael.d.kin...@

Re: [edk2] [RFC] PCD: Extended SKU support 1 - inheritance

...@intel.com] Sent: Wednesday, April 26, 2017 11:05 AM To: Tim Lewis <tim.le...@insyde.com>; Zeng, Star <star.z...@intel.com>; edk2-devel@lists.01.org; Kinney, Michael D <michael.d.kin...@intel.com> Cc: Gao, Liming <liming@intel.com> Subject: RE: [RFC] PCD: Extended SKU s

Re: [edk2] [RFC] PCD: Extended SKU support 1 - inheritance

Star -- This assumes that the SKU ID is only used for PCDs, which is not the case. The SKU ID may be used by other components, and other components may use the 0|DEFAULT rule as well. 1) There is no way to read this defaulting rule at runtime. The information is buried in the PCD database,

Re: [edk2] [edk2-UniSpecification PATCH] Allow .uni files on disk to be UTF-8 without a BOM

compatible for these files. Tim -Original Message- From: Kinney, Michael D [mailto:michael.d.kin...@intel.com] Sent: Wednesday, April 26, 2017 11:11 AM To: Tim Lewis <tim.le...@insyde.com>; edk2-devel@lists.01.org; Kinney, Michael D <michael.d.kin...@intel.com> Cc: C

Re: [edk2] [RFC] PCD: Extended SKU support 1 - inheritance

Mike -- I am saying that creating a relationship between SKUs that cannot be determined at runtime is a confusing thing to add to the DSC. Tim -Original Message- From: Kinney, Michael D [mailto:michael.d.kin...@intel.com] Sent: Wednesday, April 26, 2017 11:40 AM To: Tim Lewis <tim

Re: [edk2] [edk2-UniSpecification PATCH] Allow .uni files on disk to be UTF-8 without a BOM

, April 26, 2017 11:47 AM To: Tim Lewis <tim.le...@insyde.com>; edk2-devel@lists.01.org; Kinney, Michael D <michael.d.kin...@intel.com> Cc: Carsey, Jaben <jaben.car...@intel.com>; Shaw, Kevin W <kevin.w.s...@intel.com> Subject: RE: [edk2] [edk2-UniSpecification PATCH]

Re: [edk2] [RFC] PCD: Extended SKU support 1 - inheritance

- From: Kinney, Michael D [mailto:michael.d.kin...@intel.com] Sent: Wednesday, April 26, 2017 12:04 PM To: Tim Lewis <tim.le...@insyde.com>; Zeng, Star <star.z...@intel.com>; edk2-devel@lists.01.org; Kinney, Michael D <michael.d.kin...@intel.com> Cc: Gao, Liming <liming@i

Re: [edk2] [edk2-UniSpecification PATCH] Allow .uni files on disk to be UTF-8 without a BOM

e previous behavior. Tim -Original Message- From: Kinney, Michael D [mailto:michael.d.kin...@intel.com] Sent: Wednesday, April 26, 2017 5:02 PM To: Tim Lewis <tim.le...@insyde.com>; edk2-devel@lists.01.org; Kinney, Michael D <michael.d.kin...@intel.com> Cc: Carsey, Jaben &

Re: [edk2] [edk2-UniSpecification PATCH] Allow .uni files on disk to be UTF-8 without a BOM

d. Tim -Original Message- From: Kinney, Michael D [mailto:michael.d.kin...@intel.com] Sent: Wednesday, April 26, 2017 3:47 PM To: Tim Lewis <tim.le...@insyde.com>; edk2-devel@lists.01.org; Kinney, Michael D <michael.d.kin...@intel.com> Cc: Carsey, Jaben <jaben.car...

Re: [edk2] [RFC] PCD: Extended SKU support 1 - inheritance

...@intel.com] Sent: Wednesday, April 26, 2017 3:57 PM To: Tim Lewis <tim.le...@insyde.com>; Zeng, Star <star.z...@intel.com>; edk2-devel@lists.01.org; Kinney, Michael D <michael.d.kin...@intel.com> Cc: Gao, Liming <liming@intel.com> Subject: RE: [RFC] PCD: Extended SKU support

Re: [edk2] [RFC] PCD: Extended SKU support 1 - inheritance

Mike -- For the one-logo case, yes, that would work. But this is the simplest case. Consider HII string packages. Tim -Original Message- From: Kinney, Michael D [mailto:michael.d.kin...@intel.com] Sent: Wednesday, April 26, 2017 5:28 PM To: Tim Lewis <tim.le...@insyde.com>

Re: [edk2] [edk2-UniSpecification PATCH] Allow .uni files on disk to be UTF-8 without a BOM

-boun...@lists.01.org] On Behalf Of Tim Lewis Sent: Wednesday, April 26, 2017 5:27 PM To: Kinney, Michael D <michael.d.kin...@intel.com>; edk2-devel@lists.01.org Cc: Carsey, Jaben <jaben.car...@intel.com>; Shaw, Kevin W <kevin.w.s...@intel.com> Subject: Re: [edk2] [edk2-UniSpecific

Re: [edk2] [RFC] PCD: Extended SKU support 1 - inheritance

. Tim -Original Message- From: Zeng, Star [mailto:star.z...@intel.com] Sent: Thursday, April 27, 2017 6:00 PM To: Tim Lewis <tim.le...@insyde.com>; Kinney, Michael D <michael.d.kin...@intel.com>; edk2-devel@lists.01.org Cc: Gao, Liming <liming@intel.com>;

Re: [edk2] [RFC] PCD: Extended SKU support 1 - inheritance

, Star<mailto:star.z...@intel.com> Sent: Thursday, April 27, 2017 6:53 PM To: Tim Lewis<mailto:tim.le...@insyde.com>; Kinney, Michael D<mailto:michael.d.kin...@intel.com>; edk2-devel@lists.01.org<mailto:edk2-devel@lists.01.org> Cc: Gao, Liming<mailto:liming@intel.com&

Re: [edk2] [RFC] PCD: Extended SKU support 1 - inheritance

not found in array } Resource = NULL; while (!GetResourceForSkuId(*SkuId, ) && *SkuId == 0) { *SkuId++; } If (Resource == NULL) { // error, no resource found for any of the SKU IDs } From: Zeng, Star [mailto:star.z...@intel.com] Sent: Wednesday, May 03, 2017 7:03 AM To:

Re: [edk2] [RFC] PCD: Extended SKU support 1 - inheritance

Star -- Thanks for your work on this. I have reviewed this and it looks good, addressing all of our concerns. Tim -Original Message- From: Zeng, Star [mailto:star.z...@intel.com] Sent: Monday, May 15, 2017 2:46 AM To: Tim Lewis <tim.le...@insyde.com>; Kinney, Michael D <mich

Re: [edk2] [PATCH] ShellPkg/Touch: Create file if it doesn't exist

I don't think it is good to change the behavior of the tool beyond what is in the specification. Further, this tool has existed for quite a long time in the EDK shell and now the UEFI shell without this behavior. So the de-facto standard of this environment is "don't create". Leaving behind

Re: [edk2] [RFC] PCD: Database size optimization for multi-SKU

01.org<mailto:edk2-devel@lists.01.org> Cc: Star Zeng<mailto:star.z...@intel.com>; Michael Kinney<mailto:michael.d.kin...@intel.com>; Liming Gao<mailto:liming@intel.com>; Tim Lewis<mailto:tim.le...@insyde.com>; Yonghong Zhu<mailto:yonghong@intel.com> Subj

Re: [edk2] [RFC 0/3] Structure PCD value assignment in DEC/DSC

Mike -- Sorry for the delay. We have reviewed this RFC internally and we believe it is a useful change. Thanks, Tim -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Gao, Liming Sent: Tuesday, April 11, 2017 8:17 AM To: edk2-devel@lists.01.org

Re: [edk2] [RFC] PCD: Extended SKU support 1 - inheritance

can decide not to use this, but we actually like it. Tim -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Zeng, Star Sent: Friday, May 05, 2017 3:08 AM To: Tim Lewis <tim.le...@insyde.com>; Kinney, Michael D <michael.d.kin...@intel.com

Re: [edk2] [RFC] PCD: Extended SKU support 1 - inheritance

...@intel.com] Sent: Thursday, May 04, 2017 6:42 AM To: Tim Lewis <tim.le...@insyde.com>; Kinney, Michael D <michael.d.kin...@intel.com>; edk2-devel@lists.01.org Cc: Gao, Liming <liming@intel.com>; Zeng, Star <star.z...@intel.com> Subject: RE: [RFC] PCD: Extended SKU supp

  1   2   >