-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
Laszlo Ersek
Sent: Saturday, August 8, 2015 12:00 AM
To: edk2-devel-01
Cc: Paolo Bonzini; Zeng, Star; Justen, Jordan L
Subject: [edk2] [PATCH] OvmfPkg: prevent code execution from DXE stack
On 2015/8/18 17:25, Liming Gao wrote:
For patchable PCD, map SetPcdPtr() to LibPatchPcdSetPtrAndSize(),
then the size of the updated VOID* value can be cached.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Liming Gao liming@intel.com
Reviewed-by: Star Zeng
Liming,
Minor comments inline below.
Reviewed-by: Star Zeng star.z...@intel.com
On 2015/8/18 17:25, Liming Gao wrote:
Two new APIs LibPatchPcdSetPtrAndSize() and LibPatchPcdSetPtrAndSizeS()
are added to catch the size of the updated VOID* PCD value buffer, then
PcdGetSize() API can return the
Another minor below inline.
On 2015/8/20 15:35, Zeng, Star wrote:
Liming Bob,
Comments inline.
On 2015/8/18 17:25, Liming Gao wrote:
PcdLib introduces new APIs to get the size of PCD value.
BaseTools generates those macros in AutoGen code.
Contributed-under: TianoCore Contribution
On 2015/8/18 17:25, Liming Gao wrote:
PcdLib introduces generic API to get the size of VOID* PCD value.
Update Pei and Dxe RsaGuidedLib to use generic PCD API instead of GetEx API.
This change can remove PCD type limitation in these two libraries.
Contributed-under: TianoCore Contribution
Liming,
Minor comments inline below.
Reviewed-by: Star Zeng star.z...@intel.com
On 2015/8/18 17:25, Liming Gao wrote:
Add below four PcdGetSize() API in PcdLib header file. They can be used
to get the size of PCD value.
FixedPcdGetSize()
PatchPcdGetSize()
PcdGetSize()
PcdGetExSize()
On 2015/8/19 16:12, Liming Gao wrote:
For DynamicEx PCD, if NULL pointer is specified as token space GUID,
it will directly be used to compare GUID value in AutoGen code.
To avoid access NULL pointer, NULL pointer will be checked first.
Contributed-under: TianoCore Contribution Agreement 1.0
Reviewed-by: Star Zeng star.z...@intel.com
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Tian Feng
Sent: Tuesday, July 28, 2015 1:41 PM
To: Zeng, Star
Cc: edk2-devel@lists.01.org; Tian, Feng
Subject: [edk2] [patch] MdeModulePkg/Usb: Adjust TPL
-Original Message-
From: Laszlo Ersek [mailto:ler...@redhat.com]
Sent: Tuesday, August 4, 2015 4:34 PM
To: Zeng, Star
Cc: edk2-de...@ml01.01.org; Yao, Jiewen; Paolo Bonzini
Subject: Re: [edk2] [PATCH] MdeModulePkg DxeIpl: Add stack NX support
Star,
On 07/31/15 14:22, Star Zeng
Reviewed-by: Star Zeng star.z...@intel.com
-Original Message-
From: Tian, Feng
Sent: Wednesday, July 29, 2015 11:26 AM
To: Zeng, Star; Ni, Ruiyu
Cc: edk2-devel@lists.01.org; Kinney, Michael D
Subject: [patch 1/2] MdeModulePkg/Variable: Fix VS2015 warning about
uninitialized local var
Reviewed-by: Star Zeng star.z...@intel.com
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Liming
Gao
Sent: Thursday, July 30, 2015 5:40 PM
To: edk2-devel@lists.01.org
Subject: [edk2] [PATCH v2] MdeModulePkg PeiCore: Add PCD to specify PEIM
Hi Laszlo,
Could you help take a try with the attached patch on your VM before I send it
for formal review?
Thanks,
Star
-Original Message-
From: Laszlo Ersek [mailto:ler...@redhat.com]
Sent: Thursday, August 6, 2015 4:40 PM
To: Zeng, Star
Cc: Andrew Fish; Justen, Jordan L; edk2-de
Hi Laszlo,
Have sent out the formal patch for review.
Thanks,
Star
[EOM]
-Original Message-
From: Zeng, Star
Sent: Friday, August 7, 2015 9:36 AM
To: Zeng, Star; Laszlo Ersek; Paolo Bonzini
Cc: Justen, Jordan L; edk2-de...@ml01.01.org; Andrew Fish; Yao, Jiewen;
Chen Fan; Fan, Jeff
Hi David,
-Original Message-
From: David Woodhouse [mailto:dw...@infradead.org]
Sent: Thursday, August 6, 2015 8:11 PM
To: Zeng, Star; edk2-de...@ml01.01.org
Cc: Yao, Jiewen
Subject: Re: [edk2] [PATCH] MdeModulePkg DxeIpl: Add stack NX support
On Fri, 2015-07-31 at 20:22 +0800
Reviewed-by: Star Zeng star.z...@intel.com
-Original Message-
From: Ni, Ruiyu
Sent: Wednesday, August 5, 2015 6:42 PM
To: edk2-devel@lists.01.org
Cc: Ni, Ruiyu; Zeng, Star
Subject: [Patch] Nt32Pkg: Platform BDS should test the untested memory
NT32 has two ranges of memory, each 64MB
; Paolo
Bonzini; Fan, Jeff; Zeng, Star
Subject: Re: [edk2] [PATCH] MdeModulePkg DxeIpl: Add stack NX support
On 08/05/15 18:18, Andrew Fish wrote:
On Aug 5, 2015, at 8:41 AM, Laszlo Ersek ler...@redhat.com
mailto:ler...@redhat.com wrote:
On 07/31/15 14:22, Star Zeng wrote:
This feature
Reviewed-by: Star Zeng star.z...@intel.com
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Tian Feng
Sent: Monday, July 27, 2015 2:28 PM
To: Zeng, Star
Cc: edk2-devel@lists.01.org; Tian, Feng
Subject: [edk2] [patch] MdeModulePkg/UfsPassThru: Fix
To: Zeng, Star; edk2-de...@ml01.01.org
Subject: Re: [edk2] [PATCH 0/2] Correct address pointers from AuthVariableLib
On 07/21/15 11:01, Star Zeng wrote:
Star Zeng (2):
MdeModulePkg VariableDxe: Correct address pointers from
AuthVariableLib
SecurityPkg AuthVariableLib: Correct address
I just pulled the edk2-svn-offline code and took a look.
And I found Jordan had a commit for the attached patch which has been committed
in SVN at 18031 and I also have git-svn r18031 in local. Is it still needed in
this temporary git repo?
Thanks,
Star
-Original Message-
From:
Got it, good point.
Thanks,
Star
-Original Message-
From: Yao, Jiewen
Sent: Monday, July 27, 2015 8:45 AM
To: Zeng, Star; edk2-devel@lists.01.org
Subject: RE: [edk2] [PATCH 1/2] MdeModulePkg CapsuleX64: Reduce reserved memory
consumption
Reviewed by: Yao, Jiewen jiewen@intel.com
I
Good comments and sure to add (VOID **) cast. Thanks for your Tested-by.
Thanks,
Star
-Original Message-
From: Laszlo Ersek [mailto:ler...@redhat.com]
Sent: Tuesday, July 21, 2015 8:39 PM
To: Zeng, Star; edk2-de...@ml01.01.org
Cc: Yao, Jiewen; Alex Williamson
Subject: Re: [edk2] [PATCH 2
2015 9:31 AM
To: Zeng, Star
Cc: edk2-devel-01
Subject: Re: [edk2] [MdeModulePkg] PeiMain PeiCore does not compile with Xcode
6.3.2
> On Oct 25, 2015, at 6:04 PM, Zeng, Star <star.z...@intel.com> wrote:
>
> On 2015/10/23 22:11, Andrew Fish wrote:
>>
>>> On Oct 23, 2015, at
On 2015/10/23 22:11, Andrew Fish wrote:
On Oct 23, 2015, at 12:53 AM, Zeng, Star <star.z...@intel.com> wrote:
On 2015/10/22 23:54, Andrew Fish wrote:
/Users/andrewfish/work/src/edk2/MdeModulePkg/Core/Pei/Dispatcher/Dispatcher.c:682:28:
error: for loop has empty body [-Werror,-Wempt
I think we can use GET_GUID_HOB_DATA + GET_GUID_HOB_DATA_SIZE to simply the
logic below.
+BuildGuidDataHob (
+ >Name,
+ (VOID *)(FspHob.Raw + sizeof (EFI_HOB_GENERIC_HEADER) + sizeof
(EFI_GUID)),
+ FspHob.Header->HobLength
+);
FspHob.Header->HobLength
Reviewed-by: Star Zeng <star.z...@intel.com>
To the attached patch.
Thanks,
Star
From: af...@apple.com [mailto:af...@apple.com]
Sent: Monday, October 26, 2015 9:31 AM
To: Zeng, Star
Cc: edk2-devel-01
Subject: Re: [edk2] [MdeModulePkg] PeiMain PeiCore does not compile with Xcode
On 2015/10/26 16:38, jiewen yao wrote:
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Yao, Jiewen <jiewen@intel.com>
Cc: Zeng, Star <star.z...@intel.com>
---
MdeModulePkg/Universal/SmbiosDxe/SmbiosDxe.h | 12
1 file changed, 12 deletions(-
On 2015/10/26 16:13, jiewen yao wrote:
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Yao, Jiewen <jiewen@intel.com>
Cc: Zeng, Star <star.z...@intel.com>
---
MdePkg/Include/IndustryStandard/SmBios.h | 12
1 file changed, 12 insertions(+
On 2015/10/26 16:13, jiewen yao wrote:
This is patch to add smbios measurement.
The problem of current SMBIOS measurement is:
1) TCG drivers do not support SMBIOS3.0 table.
2) TCG drivers do not follow TCG platform spec on: "Platform configuration
information that is automatically updated,
On 2015/10/26 16:13, jiewen yao wrote:
This is patch to add smbios measurement.
The problem of current SMBIOS measurement is:
1) TCG drivers do not support SMBIOS3.0 table.
2) TCG drivers do not follow TCG platform spec on: "Platform configuration
information that is automatically updated,
On 2015/10/28 9:44, Ard Biesheuvel wrote:
On 28 October 2015 at 10:33, Star Zeng wrote:
This patch does below things.
1. Smbios3Table used as SmbiosTable wrongly after SmbiosTable got from
configuration table.
2. Correct the return comments of entrypoint function.
3. Add
On 2015/10/28 10:58, Yao, Jiewen wrote:
Thanks.
Can we use CopyGuid() for below assignment?
HandoffTables.TableEntry[0].VendorGuid = gEfiSmbiosTableGuid;
Yes, have included this into PATCH 1/5 of the new split patch set and
with your Reviewed-by.
Thanks,
Star
Reviewed-by:
On 2015/10/22 23:29, Andrew Fish wrote:
On Oct 21, 2015, at 6:34 PM, Zeng, Star <star.z...@intel.com> wrote:
On 2015/10/22 7:02, Andrew Fish wrote:
"/usr/bin/clang" -target x86_64-pc-win32-macho -c -g -Os -Wall -Werror -Wextra
-include AutoGen.h -funsigned-char -fno-ms-exten
On 2015/10/22 16:52, Derek Lin wrote:
Current variable driver already have memory cache to improve performance.
Change the code which read from physical MMIO address to read from memory cache.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Derek Lin
On 2015/10/22 23:54, Andrew Fish wrote:
/Users/andrewfish/work/src/edk2/MdeModulePkg/Core/Pei/Dispatcher/Dispatcher.c:682:28:
error: for loop has empty body [-Werror,-Wempty-body]
StackPointer ++);
^
The authentication status and its inheritance support in FvInfo2 and FvPpi were
covered by the mantis we submitted to support PEI security and to be equivalent
with DXE.
You raised another issue here to inherit authentication status from PEI to DXE.
Currently, only verified pass FV in PEI will
On 2015/11/9 20:47, Cohen, Eugene wrote:
Feng,
The patch was attached as a ".patch" file attachment and was stripped off
before it came to the list. I'll just use plaintext this time.
MdeModulePkg: PeiCore: fix issue where AuthenticationStatus is not
propagated correctly to encapsulated FVs
On 2015/11/10 9:01, Zeng, Star wrote:
On 2015/11/9 22:02, Cohen, Eugene wrote:
Star,
Apologies - the copyright change was a merge error from an older edk2
snapshot. Updated patch below.
---
MdeModulePkg: PeiCore: fix issue where AuthenticationStatus is not
propagated correctly
On 2015/11/2 18:30, Liming Gao wrote:
The BasePostCodeLibPort80 instance just prints UINT8 to IoPort 80. Some boards
may support 16bit or 32bit. To support them, new PCD PcdPort80DataWidth is
introduced to specify the width of data bits to Port80.
Contributed-under: TianoCore Contribution
AuthenticationStatus, right?
Thanks,
Star
Eugene
-Original Message-
From: Zeng, Star [mailto:star.z...@intel.com]
Sent: Monday, November 09, 2015 6:43 AM
To: Cohen, Eugene <eug...@hp.com>; edk2-devel@lists.01.org
Cc: Zeng, Star <star.z...@intel.com>
Subject: RE: Authentic
On 2015/11/17 20:16, Laszlo Ersek wrote:
On 11/17/15 11:55, Zeng, Star wrote:
On 2015/11/17 18:09, Laszlo Ersek wrote:
On 11/17/15 10:35, Star Zeng wrote:
It is also to add GetControl/SetControl/SetAttributes implementation
for EarlyFdtPL011SerialPortLib and FdtPL011SerialPortLib.
Cc
On 2015/11/17 18:09, Laszlo Ersek wrote:
On 11/17/15 10:35, Star Zeng wrote:
It is also to add GetControl/SetControl/SetAttributes implementation
for EarlyFdtPL011SerialPortLib and FdtPL011SerialPortLib.
Cc: Michael D Kinney
Cc: Liming Gao
On 2015/11/17 20:24, Laszlo Ersek wrote:
On 11/17/15 12:07, Star Zeng wrote:
Generally, this patch series are to upstream SerialDxe from EmbeddedPkg to
MdeModulePkg,
relatively, they are also to upstream SerialPortExtLib.h from EmbeddedPkg to
SerialPortLib.h in MdePkg.
For your easy review,
On 2015/11/10 23:31, Andrew Fish wrote:
On Nov 10, 2015, at 7:04 AM, Andrew Fish wrote:
On Nov 10, 2015, at 12:06 AM, Gao, Liming wrote:
Andrew:
The patch is missing.
Liming,
My sent mail shows these 3 patches attached?
On 2015/11/10 23:33, Andrew Fish wrote:
On Nov 10, 2015, at 7:04 AM, Andrew Fish wrote:
On Nov 10, 2015, at 12:06 AM, Gao, Liming > wrote:
Andrew:
The patch is missing.
Liming,
My sent mail shows these 3 patches
On 2015/11/2 10:24, El-Haj-Mahmoud, Samer wrote:
Yes please fix the typo and commit it thank you for your help.
Committed at R18714.
Thanks,
Star
-Original Message-
From: Zeng, Star [star.z...@intel.com]
Received: Sunday, 01 Nov 2015, 7:57PM
To: El-Haj-Mahmoud, Samer [samer.el
On 2015/10/31 7:12, Samer El-Haj-Mahmoud wrote:
Add a DEBUG statement when the number of PEI perf log entries
exceeds PcdMaxPeiPerformanceLogEntries
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Samer El-Haj-Mahmoud
---
On 2015/11/2 9:28, Zeng, Star wrote:
On 2015/10/31 7:12, Samer El-Haj-Mahmoud wrote:
Add a DEBUG statement when the number of PEI perf log entries
exceeds PcdMaxPeiPerformanceLogEntries
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Samer El-Haj-Mahmoud <samer.el-
On 2015/11/4 0:55, Cinnamon Shia wrote:
Add a new option -c to dump cumulative data.
For example:
shell> dp -c
==[ Cumulative ]
(Times in microsec.) Cumulative Average ShortestLongest
Name CountDurationDurationDurationDuration
LoadImage:
On 2015/11/4 0:55, Cinnamon Shia wrote:
The value of PERF_CUM_DATA.Count and PERF_CUM_DATA.Duration field
keep cumulating on every execution of dp.
Initialize the CumData at dp's entry point.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Cinnamon Shia
On 2015/10/26 9:54, Zeng, Star wrote:
Reviewed-by: Star Zeng <star.z...@intel.com>
to the attached patch.
I could not see the email I replied to edk2-devel-01 <edk2-de...@ml01.01.org>,
so re-reply to edk2-devel@lists.01.org.
Andrew,
Will you commit this patch by yourself, or
\Dp_App?
Thanks,
Star
Thanks,
Cinnamon Shia
-Original Message-
From: Zeng, Star [mailto:star.z...@intel.com]
Sent: Tuesday, November 3, 2015 11:16 AM
To: Shia, Cinnamon; edk2-devel@lists.01.org
Subject: Re: [edk2] [PATCH 2/2] ShellPkg/UefiDpLib: Support dumping cumulative
data
On 2015/11
On 2015/10/23 14:04, Andrew Fish wrote:
On Oct 22, 2015, at 10:10 PM, Zeng, Star <star.z...@intel.com> wrote:
On 2015/10/22 23:29, Andrew Fish wrote:
On Oct 21, 2015, at 6:34 PM, Zeng, Star <star.z...@intel.com> wrote:
On 2015/10/22 7:02, Andrew Fish wrote:
"/usr/b
On 2015/11/3 21:26, Cinnamon Shia wrote:
Add a new option -c to dump cumulative data.
For example:
shell> dp -c
==[ Cumulative ]
(Times in microsec.) Cumulative Average ShortestLongest
Name CountDurationDurationDurationDuration
LoadImage:
On 2015/10/16 16:04, Dimitri wrote:
Hi,
Fist of all: I am DimitRi.
UDK2014/UEFI 2.4 does not have EFI_PROPERTIES_TABLE feature. Anyway we have
a bug by default.
Collegue from Apple confirmed that os x boot loader move EfiRuntime memory
to different physical address. I did not find in UEFI
On 2015/10/13 19:55, Laszlo Ersek wrote:
These messages don't report errors, hence they should be emitted as
EFI_D_INFO (or EFI_D_VERBOSE even).
Cc: Star Zeng
Cc: Elvin Li
Cc: Drew Jones
Contributed-under: TianoCore Contribution
On 2015/10/13 19:55, Laszlo Ersek wrote:
The IsValidWorkSpace() function checks if the working block header of the
workspace is valid. A mismatch detected by this function is not
necessarily an error; it can happen with an as-yet unwritten flash chip,
which is e.g. common and normal when a new
On 2015/10/14 13:35, Eric Dong wrote:
PcdSet## has no error status returned, then the caller has no idea about
whether the set operation is successful or not.
PcdSet##S were added to return error status and PcdSet## APIs were put in
ifndef DISABLE_NEW_DEPRECATED_INTERFACES condition.
To adopt
On 2015/10/14 20:30, Laszlo Ersek wrote:
The "success" messages in FtwRestart(), FtwAbort(), and FtwGetLastWrite()
should be logged on EFI_D_INFO level. We can also unify their format with
the __FUNCTION__ macro.
Cc: Star Zeng
Cc: Liming Gao
Cc: Drew
On 2015/10/9 6:33, Andrew Fish wrote:
On Oct 8, 2015, at 3:11 PM, Laszlo Ersek wrote:
On 10/08/15 09:39, Star Zeng wrote:
PcdSet## has no error status returned, then the caller has no idea about
whether the set operation is successful or not.
PcdSet##S were added to
On 2015/11/17 22:28, Laszlo Ersek wrote:
On 11/17/15 14:00, Zeng, Star wrote:
On 2015/11/17 20:24, Laszlo Ersek wrote:
On 11/17/15 12:07, Star Zeng wrote:
Generally, this patch series are to upstream SerialDxe from
EmbeddedPkg to MdeModulePkg,
relatively, they are also to upstream
On 2015/11/17 16:48, Ruiyu Ni wrote:
The patch updates the Century value in CMOS location 50 (32h)
to avoid UEFI Win7 hang during booting. (Though Win8 is good.)
Per the ACPI spec the Century storage in CMOS is optional,
but the fact is even we set the FADT.CenturyOffset to 0 indicating
the
On 2015/11/17 18:19, Laszlo Ersek wrote:
Although this also updates Ard's code, mainly, I think I can comment on it:
On 11/17/15 10:35, Star Zeng wrote:
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Jordan Justen
Cc:
On 2015/8/26 18:57, Laszlo Ersek wrote:
On 08/26/15 12:27, Laszlo Ersek wrote:
Star,
On 08/17/15 10:24, Star Zeng wrote:
Cc: Jordan Justen jordan.l.jus...@intel.com
Cc: Laszlo Ersek ler...@redhat.com
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Star Zeng
On 2015/9/9 13:36, Ruiyu Ni wrote:
The mBmPerfHeader.Count isn't reset to 0 in BmWriteBootToOsPerformanceData()
so when the actual performance data entry count exceeds the LimitCount,
the performance data collection breaks on condition
if (mBmPerfHeader.Count == LimitCount), but 2nd time calling
On 2015/9/9 13:34, Tian Feng wrote:
EFI_SCSI_IO_PROTOCOL has alignment requirement on any data buffer
used in SCSI data transfer. As a wrap of this protocol, UefiScsiLib
have same request. Adding EFI_INVALID_PARAMETER return status in
function comments to ask the caller to guarantee this
On 2015/9/15 17:28, Laszlo Ersek wrote:
On 09/14/15 15:58, Star Zeng wrote:
What to do:
1. Remove a hidden assumption "No SMM driver writes BootScript between
SmmReadyToLock and S3SleepEntryCallback".
1.1. Use SmmExitBootServices and SmmLegacyBoot notification to record
AtRuntime flag.
On 2015/9/18 22:21, Laszlo Ersek wrote:
These trip up compilation with gcc.
Cc: Liming Gao
Cc: Jiewen Yao
Cc: Star Zeng
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Laszlo Ersek
---
On 2015/9/25 13:14, Jeff Fan wrote:
CpuData buffer should be located in allocated buffer instead of at end of
WakeupBuffer.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jeff Fan
CC: Star Zeng
CC: Feng Tian
On 2015/9/25 13:13, Jeff Fan wrote:
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jeff Fan
CC: Star Zeng
CC: Feng Tian
---
UefiCpuPkg/CpuMpPei/CpuMpPei.c | 1 +
1 file changed, 1 insertion(+)
On 2015/12/3 2:58, Cohen, Eugene wrote:
Star,
Do you have the patch tested on your real platforms (with and without
InstallPeiMemory()?
Yes, we've been running this way for a couple years. I had it on my list of
changes to upstream and forgot about it until now. The only other requirement
Based on this V2 patch about AuthVariableLib update.
Seemingly, you have forgotten partial of previous 2) and 5) comments.
2. Remove IsPkExist fields from SECURE_BOOT_MODE
structure since only any place to use them.
5. Suggest to update EFI_SECURE_MODE_NAME and gEfiSecureBootModeGuid
to like
Hi Eugene,
Thanks for the updated patch, but it seems not resolve my concern.
On 2015/12/8 22:42, Cohen, Eugene wrote:
[This patch is updated from v1 to defer publication of the decompression and
extraction PPIs
until after permanent memory is installed. Tested for normal boots and our
Hi Eugene,
On 2015/12/1 21:16, Cohen, Eugene wrote:
This is a patch that enables the S3 Resume path from PEI without permanent
memory installed. There is not a strict requirement that we can see to have
permanent memory installed for S3 resume. We have platforms that hold PEI code
(not
Hi Chao,
I have comments below to this patch about AuthVariableLib update.
1. Move SecureBootState to AuthService.c since it is only used by
AuthService.c, and update the name to mSecureBootState.
2. Remove IsPkExist and SetupModeValAttr fields from SECURE_BOOT_MODE
structure since only any
On 2015/12/8 13:06, Zhang, Chao B wrote:
Restore SetupMode macro definition to keep backward compatibility. No current
module is referencing them now.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Chao Zhang
---
On 2015/12/15 7:57, Samer El-Haj-Mahmoud wrote:
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Samer El-Haj-Mahmoud
---
MdePkg/Include/IndustryStandard/SmBios.h | 3 +++
1 file changed, 3 insertions(+)
diff --git
.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: "Yao, Jiewen" <jiewen@intel.com>
Cc: "Zeng, Star" <star.z...@intel.com>com>
---
MdeModulePkg/MdeModulePkg.dec | 14 ++
1 file changed, 14 insertions(+)
Reviewed-by: Star
On 2015/12/17 18:00, Ard Biesheuvel wrote:
LcrParity and LcrStop may end up being referenced without being
initialized, so make sure they always have a value.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ard Biesheuvel
---
On 2015/12/17 18:01, Ard Biesheuvel wrote:
C99 does not define left-shifting negative values, so make all
[positive] preprocessor constants unsigned explicitly, so they
do not become negative values after bitwise negation.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by:
On 2015/12/17 18:00, Ard Biesheuvel wrote:
Clang does not allow straight assignment of va_list types, so use the
correct VA_COPY() instead.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ard Biesheuvel
---
On 2015/12/17 23:05, Ard Biesheuvel wrote:
On 17 December 2015 at 15:23, Zeng, Star <star.z...@intel.com> wrote:
On 2015/12/17 18:00, Ard Biesheuvel wrote:
Clang does not allow straight assignment of va_list types, so use the
correct VA_COPY() instead.
Contributed-under: Tia
On 2015/11/11 10:41, Zeng, Star wrote:
On 2015/11/10 23:31, Andrew Fish wrote:
On Nov 10, 2015, at 7:04 AM, Andrew Fish <af...@apple.com> wrote:
On Nov 10, 2015, at 12:06 AM, Gao, Liming <liming@intel.com> wrote:
Andrew:
The patch is missing.
Liming,
My sent mail s
On 2015/12/16 4:44, Samer El-Haj-Mahmoud wrote:
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Samer El-Haj-Mahmoud
---
MdePkg/Include/IndustryStandard/SmBios.h | 3 +++
1 file changed, 3 insertions(+)
Reviewed-by: Star Zeng
10, 2015 9:36 AM
To: Kinney, Michael D; Laszlo Ersek
Cc: Paolo Bonzini; Scott Duplichan; edk2-devel@lists.01.org; Zeng, Star
Subject: RE: [edk2] [Patch] PcAtChipsetPkg/Rtc: Fix a UEFI Win7 boot hang issue
Yes.
Regards,
Ray
-Original Message-
From: Kinney, Michael D
Sent: Thursday
On 2016/1/7 10:55, Tian Feng wrote:
Two drivers are involved:
1. UfsBlockIoPei
2. NvmExpressDxe
Tian Feng (2):
MdeModulePkg/UfsBlockIoPei: Fix MS toolchain /Od 32bit build failure
MdeModulePkg/NvmExpressDxe: Fix MS toolchain /Od 32bit build failure
On 2016/1/8 10:42, Hao Wu wrote:
When overriding compiler options '/GL' with '/GL-', VS2010 will report
warning C4701 potentially uninitialized local variable in SerialPort
libraries.
Hao Wu (2):
MdeModulePkg BaseSerialPortLib: Fix VS2010 build error
PcAtChipsetPkg SerialIoLib: Fix VS2010
Hao,
Could you also do the similar fix for
PcAtChipsetPkg/Library/SerialIoLib/SerialPortLib.c?
Thanks,
Star
On 2016/1/7 12:40, Hao Wu wrote:
When overriding compiler options '/GL' with '/GL-', VS2010 will report
warning C4701 potentially uninitialized local variable for 'LcrParity'
and
On 2015/12/21 13:47, Zhang, Chao B wrote:
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Zhang, Chao
Reviewed-by: Star Zeng
---
.../SecureBootConfigDxe/SecureBootConfig.vfr | 70 --
1 file
Reviewed-by: Star Zeng
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Liming
Gao
Sent: Wednesday, December 23, 2015 5:57 PM
To: edk2-devel@lists.01.org
Subject: [edk2] [Patch 5/8] MdeModulePkg: Update SerialDxe inf to
Baranne,
On 2015/12/28 10:16, Anbazhagan, Baraneedharan wrote:
Hi,
Variable driver uses gEdkiiFaultTolerantWriteGuid hob and copies data to
NvStorageData if hob exists. If FaultTolerantWriteDxe driver executed prior to
variable driver then spare block is erased and potentially NvStorageData
On 2015/12/21 22:53, Ruiyu Ni wrote:
The patch updates the Century value in CMOS location specified
by FADT.Century to avoid UEFI Win7 hang during booting.
Per the ACPI spec if the FADT.Century is zero, it's not needed
to store the century value in CMOS. But UEFI Win7 treats the
Century storage
be a
enhancement. And,
1. Before ReadyToBoot, the code still need to parse configuration
(EfiGetSystemConfigurationTable).
2. I do not want to assume there are how many tables in configuration
table and RSDT/XSDT for a platform.
Thanks,
Star
Regards,
Ray
-Original Message-
From: Zeng, Star
Sent
On 2015/11/24 16:50, Tian Feng wrote:
Memory pointed to by Private->ControllerData has not been freed up
correctly at error handling path.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Feng Tian
Cc: Simon (Xiang) Lian-SSI
On 2015/11/24 16:50, Tian Feng wrote:
In EnumerateNvmeDevNamespace(), when Private->ControllerData->Sn and/or
Private->ControllerData->Mn are NOT null-terminated strings,
UnicodeSPrintAsciiFormat(…) may generate unexpected (garbage) output
string.
Contributed-under: TianoCore Contribution
On 2015/11/24 22:42, Laszlo Ersek wrote:
On 11/24/15 15:27, Zeng, Star wrote:
On 2015/11/24 21:17, Laszlo Ersek wrote:
On 11/24/15 02:01, Zeng, Star wrote:
On 2015/11/23 22:01, Laszlo Ersek wrote:
[snip]
(2) although I see that you unified the GetControl / SetControl /
SetAttributes
feedback. Thanks!
Have addressed this comment in the just sent out V4 patch series.
Hopefully V4 could be the final version. :)
Thanks,
Star
Mike
-Original Message-
From: Zeng, Star
Sent: Sunday, November 22, 2015 5:44 PM
To: edk2-devel@lists.01.org
Cc: Kinney, Michael D
l01.01.org; Kinney, Michael D
Cc: Zeng, Star; Fan, Jeff
Subject: RE: [patch] MdeModulePkg/PiSmmCore: Install LoadedImage protocol.
Jiewen,
One typo in a comment noted below. With that fix:
Reviewed-by: Michael Kinney <michael.d.kin...@intel.com>
Mike
-Original Message-
From:
On 2015/11/24 21:00, jiewen yao wrote:
We had put communication buffer to Runtime memory,
so that SMI handler can know it is not used by OS.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: "Yao, Jiewen" <jiewen@intel.com>
Cc: "Zeng, Star"
Hi Laszlo,
On 2015/11/27 1:44, Laszlo Ersek wrote:
On 11/26/15 18:39, Laszlo Ersek wrote:
Hi Star,
On 11/25/15 02:33, Star Zeng wrote:
1. Update fdf and dsc to use SerialDxe in MdeModulePkg.
2. Separate the code that gets SerialRegBase and SerialRegAccessType
by CbParseLib from
On 2015/11/3 15:34, Zhang, Chao B wrote:
Enable Secure Boot feature defined in UEFI2.5 ECR1263. Add
AuditMode/DeployedMode value definition.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Chao Zhang
---
MdePkg/Include/Guid/GlobalVariable.h
1 - 100 of 1302 matches
Mail list logo