Re: [edk2] [PATCH 06/21] ArmVirtPkg/ArmGicArchLib: move to FdtClient protocol

2016-04-07 Thread Ard Biesheuvel
On 7 April 2016 at 14:02, Laszlo Ersek wrote: > On 04/07/16 13:44, Ard Biesheuvel wrote: >> On 7 April 2016 at 13:18, Laszlo Ersek wrote: > >>> I tried to round up users of the lib class ArmGicArchLib. I found two >>> client INF files: >>> >>> -

Re: [edk2] [PATCH 03/12] FatBinPkg: Change to 2-clause BSD license

2016-04-07 Thread Carsey, Jaben
> -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Laszlo Ersek > Sent: Thursday, April 07, 2016 12:30 AM > To: Justen, Jordan L ; Ni, Ruiyu > ; edk2-devel@lists.01.org >

Re: [edk2] [PATCH V3 3/8] OvmfPkg: Install LockBox protocol in constructor of LockBoxDxeLib

2016-04-07 Thread Laszlo Ersek
On 04/07/16 13:37, Laszlo Ersek wrote: > On 04/07/16 12:19, Star Zeng wrote: >> Currently, the LockBox protocol is installed in entrypoint of >> OVMF AcpiS3SaveDxe. >> >> We can let the first driver run with LockBoxDxeLib linked to have its >> library constructor to install LockBox protocol on the

[edk2] [PATCH 1/2] OvmfPkg: remove USE_OLD_PCI_HOST build option

2016-04-07 Thread Laszlo Ersek
It's been a month since the following commits appeared in the repo: 4014885ffdfa8 OvmfPkg: switch to MdeModulePkg/Bus/Pci/PciHostBridgeDxe c47ed6fcb5e60 OvmfPkg: match PCI config access to machine type (if not USE_OLD_PCI_HOST) in which we introduced the USE_OLD_PCI_HOST

[edk2] [PATCH 0/2] OvmfPkg: drop PciHostBridgeDxe fork

2016-04-07 Thread Laszlo Ersek
I like the diffstat on this one. Public branch: . Cc: Jordan Justen Laszlo Ersek (2): OvmfPkg: remove USE_OLD_PCI_HOST build option OvmfPkg: remove PciHostBridgeDxe fork OvmfPkg/OvmfPkgIa32.dsc

Re: [edk2] [PATCH 06/21] ArmVirtPkg/ArmGicArchLib: move to FdtClient protocol

2016-04-07 Thread Ard Biesheuvel
On 7 April 2016 at 14:26, Laszlo Ersek wrote: > On 04/07/16 14:04, Ard Biesheuvel wrote: >> On 7 April 2016 at 14:02, Laszlo Ersek wrote: >> Does that mean you are going to ignore my v2? > > I certainly don't *want* to ignore it, but I think we have

Re: [edk2] [PATCH V3 3/8] OvmfPkg: Install LockBox protocol in constructor of LockBoxDxeLib

2016-04-07 Thread Laszlo Ersek
On 04/07/16 12:19, Star Zeng wrote: > Currently, the LockBox protocol is installed in entrypoint of > OVMF AcpiS3SaveDxe. > > We can let the first driver run with LockBoxDxeLib linked to have its > library constructor to install LockBox protocol on the ImageHandle. > As other drivers may have

Re: [edk2] [PATCH 2/2] ArmVirtPkg: drop bogus ArmPlatformSecExtraActionLib resolution

2016-04-07 Thread Laszlo Ersek
On 04/07/16 14:11, Ard Biesheuvel wrote: > Nothing we use on any of the ArmVirtPkg platforms depends on the > ArmPlatformSecExtraActionLib library class, so drop the resolution > from ArmVirt.dsc.inc > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Ard Biesheuvel

Re: [edk2] [PATCH 06/21] ArmVirtPkg/ArmGicArchLib: move to FdtClient protocol

2016-04-07 Thread Laszlo Ersek
On 04/07/16 14:04, Ard Biesheuvel wrote: > On 7 April 2016 at 14:02, Laszlo Ersek wrote: >> On 04/07/16 13:44, Ard Biesheuvel wrote: >>> On 7 April 2016 at 13:18, Laszlo Ersek wrote: >> I tried to round up users of the lib class ArmGicArchLib. I found

Re: [edk2] [PATCH 06/21] ArmVirtPkg/ArmGicArchLib: move to FdtClient protocol

2016-04-07 Thread Laszlo Ersek
On 04/07/16 14:28, Ard Biesheuvel wrote: > On 7 April 2016 at 14:26, Laszlo Ersek wrote: >> On 04/07/16 14:04, Ard Biesheuvel wrote: >>> On 7 April 2016 at 14:02, Laszlo Ersek wrote: >>> Does that mean you are going to ignore my v2? >> >> I certainly don't

[edk2] [Patch] SecurityPkg OpalPasswordDxe: Clean up debug message.

2016-04-07 Thread Eric Dong
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Eric Dong Cc: Feng Tian --- SecurityPkg/Tcg/Opal/OpalPasswordDxe/OpalHii.c | 13 - 1 file changed, 13 deletions(-) diff --git

[edk2] [Patch] SecurityPkg TcgStorageOpalLib: Fix a typo.

2016-04-07 Thread Eric Dong
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Eric Dong Cc: Feng Tian --- SecurityPkg/Library/TcgStorageOpalLib/TcgStorageOpalUtil.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [edk2] [patch 0/4] Add EDKII SD/MMC stack to manage SD/EMMC device

2016-04-07 Thread Ard Biesheuvel
On 23 March 2016 at 03:51, Feng Tian wrote: > The EDKII SD/MMC stack includes: > 1. Dxe phase support by: >i. SdMmcPciHcDxe driver to consume PciIo and produce SdMmcPassThru >ii. SdDxe driver to consume SdMmcPassThru to produce BlkIo1/BlkIo2 >iii.EmmcDxe driver

Re: [edk2] [PATCH 00/12] Cleanups to follow FatPkg license update

2016-04-07 Thread Laszlo Ersek
On 04/06/16 17:14, Jordan Justen wrote: > web: https://github.com/jljusten/edk2/tree/fatpkg-open-source-cleanups-v1 > > git: https://github.com/jljusten/edk2.git fatpkg-open-source-cleanups-v1 > > The license update to FatPkg is expected to be pushed later today. > > Following the license

Re: [edk2] [PATCH 06/21] ArmVirtPkg/ArmGicArchLib: move to FdtClient protocol

2016-04-07 Thread Ard Biesheuvel
On 7 April 2016 at 13:18, Laszlo Ersek wrote: > On 04/06/16 18:15, Ard Biesheuvel wrote: >> Instead of relying on VirtFdtDxe to populate the GIC related PCDs, move >> this handling to our implementation of ArmGicArchLib, and retrieve the >> required DT info using the new FDT

Re: [edk2] [PATCH 06/21] ArmVirtPkg/ArmGicArchLib: move to FdtClient protocol

2016-04-07 Thread Laszlo Ersek
On 04/07/16 13:44, Ard Biesheuvel wrote: > On 7 April 2016 at 13:18, Laszlo Ersek wrote: >> I tried to round up users of the lib class ArmGicArchLib. I found two >> client INF files: >> >> - ArmPkg/Drivers/ArmGic/ArmGicLib.inf >> - ArmPkg/Drivers/ArmGic/ArmGicSecLib.inf >> >>

Re: [edk2] [PATCH 1/2] ArmVirtPkg: remove linux loader from ARM builds

2016-04-07 Thread Laszlo Ersek
On 04/07/16 14:11, Ard Biesheuvel wrote: > The built in Linux loader was a temporary solution to boot ARM Linux > without EFI support in the OS. Now that EFI support is merged in the > upstream v4.5 release, we no longer need it. So drop it. > > Contributed-under: TianoCore Contribution Agreement

[edk2] [PATCH 1/2] ArmVirtPkg: remove linux loader from ARM builds

2016-04-07 Thread Ard Biesheuvel
The built in Linux loader was a temporary solution to boot ARM Linux without EFI support in the OS. Now that EFI support is merged in the upstream v4.5 release, we no longer need it. So drop it. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel

[edk2] [PATCH 2/2] ArmVirtPkg: drop bogus ArmPlatformSecExtraActionLib resolution

2016-04-07 Thread Ard Biesheuvel
Nothing we use on any of the ArmVirtPkg platforms depends on the ArmPlatformSecExtraActionLib library class, so drop the resolution from ArmVirt.dsc.inc Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel ---

Re: [edk2] [PATCH 06/21] ArmVirtPkg/ArmGicArchLib: move to FdtClient protocol

2016-04-07 Thread Laszlo Ersek
On 04/06/16 18:15, Ard Biesheuvel wrote: > Instead of relying on VirtFdtDxe to populate the GIC related PCDs, move > this handling to our implementation of ArmGicArchLib, and retrieve the > required DT info using the new FDT client protocol. > > This removes one of the reasons we need to load

Re: [edk2] [PATCH 06/21] ArmVirtPkg/ArmGicArchLib: move to FdtClient protocol

2016-04-07 Thread Laszlo Ersek
On 04/07/16 13:18, Laszlo Ersek wrote: > On 04/06/16 18:15, Ard Biesheuvel wrote: >> + >> + GicRevision = 2; >> + Status = FdtClient->FindCompatibleNodeReg (FdtClient, >> + "arm,cortex-a15-gic", >> + , >> +

Re: [edk2] [PATCH 11/12] OvmfPkg: Convert to using FatPkg in the EDK II tree

2016-04-07 Thread Laszlo Ersek
On 04/06/16 17:15, Jordan Justen wrote: > Now that FatPkg is open source (and therefore can be included in the > EDK II tree) we build and use it directly. > > Build tested with GCC 5.3 on IA32 and X64. Boot tested to UEFI Shell > on IA32 and UEFI Linux on X64. > > Contributed-under: TianoCore

Re: [edk2] [PATCH 09/12] EmulatorPkg: Convert to always build FatPkg

2016-04-07 Thread Laszlo Ersek
On 04/06/16 17:35, Andrew Fish wrote: > >> On Apr 6, 2016, at 8:14 AM, Jordan Justen wrote: >> >> Now that FatPkg is open source (and therefore can be included in the >> EDK II tree) we always build and use it directly. >> >> Build and boot tested with GCC 5.3 on X64,

Re: [edk2] [PATCH 0/2] OvmfPkg: drop PciHostBridgeDxe fork

2016-04-07 Thread Jordan Justen
On 2016-04-07 08:07:35, Laszlo Ersek wrote: > I like the diffstat on this one. > :) Series Reviewed-by: Jordan Justen Ray, I noticed one possible issue. With the new driver, did we lose this commit? commit 1fd376d979221e9765dbec215916f5a6ab92879f

Re: [edk2] [PATCH 04/12] ArmVirtPkg: Convert to build FatPkg from source

2016-04-07 Thread Laszlo Ersek
On 04/06/16 17:14, Jordan Justen wrote: > Now that FatPkg is open source (and therefore can be included in the > EDK II tree) we build and use it directly. > > Note: Not build tested > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Jordan Justen

Re: [edk2] [PATCH 09/12] EmulatorPkg: Convert to always build FatPkg

2016-04-07 Thread Laszlo Ersek
On 04/06/16 17:14, Jordan Justen wrote: > Now that FatPkg is open source (and therefore can be included in the > EDK II tree) we always build and use it directly. > > Build and boot tested with GCC 5.3 on X64, but I did not test > attaching a disk image with a FAT filesystem. > >

Re: [edk2] [PATCH 05/12] BeagleBoardPkg: Convert to build FatPkg from source

2016-04-07 Thread Laszlo Ersek
On 04/06/16 17:14, Jordan Justen wrote: > Now that FatPkg is open source (and therefore can be included in the > EDK II tree) we build and use it directly. > > Note: Not build tested > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Jordan Justen

Re: [edk2] [PATCH 06/12] CorebootPayloadPkg: Convert to build FatPkg from source

2016-04-07 Thread Laszlo Ersek
On 04/06/16 17:14, Jordan Justen wrote: > Now that FatPkg is open source (and therefore can be included in the > EDK II tree) we build and use it directly. > > Note: Build tested with GCC 5.3 on IA32 and IA32+X64. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by:

Re: [edk2] [PATCH 03/12] FatBinPkg: Change to 2-clause BSD license

2016-04-07 Thread Laszlo Ersek
On 04/07/16 18:30, Andrew Fish wrote: > >> On Apr 7, 2016, at 9:29 AM, Kinney, Michael D >> wrote: >> >> In the transition to github, we added the repository tianocore/udk >> >> https://github.com/tianocore/udk >> >> This is intended for UEFI Development Kit

Re: [edk2] [PATCH 03/12] FatBinPkg: Change to 2-clause BSD license

2016-04-07 Thread Andrew Fish
> On Apr 7, 2016, at 9:29 AM, Kinney, Michael D > wrote: > > In the transition to github, we added the repository tianocore/udk > > https://github.com/tianocore/udk > > This is intended for UEFI Development Kit releases that are fully validated > releases

Re: [edk2] [PATCH 00/12] Cleanups to follow FatPkg license update

2016-04-07 Thread Jordan Justen
On 2016-04-07 07:11:58, Laszlo Ersek wrote: > On 04/06/16 17:14, Jordan Justen wrote: > > web: https://github.com/jljusten/edk2/tree/fatpkg-open-source-cleanups-v1 > > > > git: https://github.com/jljusten/edk2.git fatpkg-open-source-cleanups-v1 > > > > The license update to FatPkg is expected to

[edk2] [RFC] EDK2 Staging Proposal 4th Draft

2016-04-07 Thread Kinney, Michael D
Hello, We left off with the 3rd draft of the edk2-staging proposal with some really good feedback. The consistent feedback was to keep any process here simple and to use features already available from github where it makes sense to do so. The main purpose of the edk2-staging repo is to

Re: [edk2] [PATCH 0/2] OvmfPkg: drop PciHostBridgeDxe fork

2016-04-07 Thread Laszlo Ersek
On 04/07/16 21:36, Laszlo Ersek wrote: > On 04/07/16 20:24, Jordan Justen wrote: >> Someone was reporting slowness with the Windows 7 ISO on irc a few >> days back. Maybe this is the cause? > I think you are referring to the following discussion on April 4th: >> if i use a VM in bios mode it

Re: [edk2] [PATCH 06/12] CorebootPayloadPkg: Convert to build FatPkg from source

2016-04-07 Thread Jordan Justen
On 2016-04-07 11:57:20, Laszlo Ersek wrote: > On 04/06/16 17:14, Jordan Justen wrote: > > Now that FatPkg is open source (and therefore can be included in the > > EDK II tree) we build and use it directly. > > > > Note: Build tested with GCC 5.3 on IA32 and IA32+X64. > > > > Contributed-under:

Re: [edk2] [PATCH 0/2] OvmfPkg: drop PciHostBridgeDxe fork

2016-04-07 Thread Laszlo Ersek
On 04/07/16 20:24, Jordan Justen wrote: > On 2016-04-07 08:07:35, Laszlo Ersek wrote: >> I like the diffstat on this one. >> > > :) > > Series Reviewed-by: Jordan Justen Thanks. Committed as aa47e5297851..4a392a451d4d. > Ray, > > I noticed one possible issue. With

Re: [edk2] [PATCH 0/2] OvmfPkg: drop PciHostBridgeDxe fork

2016-04-07 Thread Jordan Justen
On 2016-04-07 12:36:36, Laszlo Ersek wrote: > On 04/07/16 20:24, Jordan Justen wrote: > > On 2016-04-07 08:07:35, Laszlo Ersek wrote: > >> I like the diffstat on this one. > >> > > > > :) > > > > Series Reviewed-by: Jordan Justen > > Thanks. Committed as

[edk2] [PATCH] UefiCpuPkg: CpuIo2Dxe: optimize FIFO reads and writes of IO ports

2016-04-07 Thread Laszlo Ersek
* Short description: The CpuIoServiceRead() and CpuIoServiceWrite() functions transfer data between memory and IO ports with individual Io(Read|Write)(8|16|32) function calls, each in an appropriately set up loop. On the Ia32 and X64 platforms however, FIFO reads and writes can be

[edk2] [PATCH v2] NetworkPkg: Add RAM disk boot support to HTTP Boot driver.

2016-04-07 Thread Fu Siyuan
V2 update: Add parameter check for HttpBootCheckImageType() fucntion, and other function description according to Ye, Ting's comments for V1 patch. This patch updates the HTTP Boot driver to support the download and boot a RAM disk image from HTTP server. The HTTP RAM disk boot is described in

[edk2] [Patch 1/2] BaseTools/VolInfo: generate HASH value for each PE image

2016-04-07 Thread Yonghong Zhu
VolInfo Tool add new option --hash to use openssl to generate hash value for each PE image. If the image base address is not zero, we will rebase its base address to zero before generate hash value. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Yonghong Zhu

[edk2] [Patch 0/2] Tool generate hash value for each output EFI image

2016-04-07 Thread Yonghong Zhu
Build Tool add new report type 'HASH' to generate hash value in the build report. VolInfo Tool add new option --hash to use openssl to generate hash value for each PE image. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Yonghong Zhu Yonghong Zhu

[edk2] [Patch 2/2] BaseTools: generate hash value in build report for each output EFI image

2016-04-07 Thread Yonghong Zhu
Build report add new report type 'HASH' to include the hash value for each output EFI image. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Yonghong Zhu --- BaseTools/Source/Python/build/BuildReport.py | 53 +++-

Re: [edk2] [PATCH 03/12] FatBinPkg: Change to 2-clause BSD license

2016-04-07 Thread Jordan Justen
(How about an r-b for some of the patches I Cc'd you on? :) On 2016-04-06 19:11:05, Ni, Ruiyu wrote: >My understanding is: > >Shell is a very standalone project so the binary package was >created for a certain level of isolation. And it does save build >time. It also assumes that

Re: [edk2] [PATCH V2 4/8] MdeModulePkg S3SaveStateDxe: Consume PcdAcpiS3Enable to control the code

2016-04-07 Thread Laszlo Ersek
On 04/07/16 09:21, Zeng, Star wrote: > Laszlo, > > On 2016/4/7 0:26, Laszlo Ersek wrote: >> On 04/06/16 14:40, Star Zeng wrote: >>> Cc: Feng Tian >>> Cc: Jiewen Yao >>> Cc: Laszlo Ersek >>> Contributed-under: TianoCore Contribution

Re: [edk2] [Patch 2/3] ShellPkg: Update Guid/Protocol usages in INF files.

2016-04-07 Thread Qiu, Shumin
Reviewed-by: Qiu Shumin -Original Message- From: Gao, Liming Sent: Thursday, April 07, 2016 2:54 PM To: edk2-devel@lists.01.org Cc: Carsey, Jaben; Qiu, Shumin Subject: [Patch 2/3] ShellPkg: Update Guid/Protocol usages in INF files. Cc: Jaben Carsey

Re: [edk2] [PATCH 05/21] ArmVirtPkg: add FdtClientDxe to the ArmVirtPkg platforms

2016-04-07 Thread Laszlo Ersek
On 04/06/16 18:15, Ard Biesheuvel wrote: > Add FdtClientDxe to the various platforms under ArmVirtPkg, which will be > required when we update the shared ArmGicArchLib to depend on it. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Ard Biesheuvel

Re: [edk2] [PATCH 04/21] ArmVirtPkg/FdtClientDxe: implement new driver

2016-04-07 Thread Laszlo Ersek
On 04/07/16 09:32, Ard Biesheuvel wrote: > On 6 April 2016 at 22:25, Laszlo Ersek wrote: >> (5) For new code, please strive to keep the Packages / LibraryClasses / >> etc sections in INF files sorted. First, it looks nice; second (more >> importantly), it helps you verify that

Re: [edk2] [PATCH 04/21] ArmVirtPkg/FdtClientDxe: implement new driver

2016-04-07 Thread Ard Biesheuvel
On 7 April 2016 at 09:57, Laszlo Ersek wrote: > On 04/07/16 09:32, Ard Biesheuvel wrote: >> On 6 April 2016 at 22:25, Laszlo Ersek wrote: > >>> (5) For new code, please strive to keep the Packages / LibraryClasses / >>> etc sections in INF files sorted.

[edk2] [Patch 3/3] MdeModulePkg: Update Guid/Protocol usages in INF files.

2016-04-07 Thread Liming Gao
Cc: Star Zeng Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Liming Gao --- .../Library/VarCheckUefiLib/VarCheckUefiLib.inf| 78 +++--- .../Variable/RuntimeDxe/VariableRuntimeDxe.inf | 10 +-- 2 files

[edk2] [Patch 1/3] SecurityPkg: Update protocol usage in module INF files.

2016-04-07 Thread Liming Gao
Update TCG and Library module uses gEdkiiVariableLockProtocolGuid as SOMETIMES_CONSUMES instead of CONSUMES to follow the code logic. Cc: Chao Zhang Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Liming Gao ---

[edk2] [Patch 2/3] ShellPkg: Update Guid/Protocol usages in INF files.

2016-04-07 Thread Liming Gao
Cc: Jaben Carsey Cc: Shumin Qiu Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Liming Gao --- ShellPkg/Application/Shell/Shell.inf | 10 -

Re: [edk2] [PATCH V2 4/8] MdeModulePkg S3SaveStateDxe: Consume PcdAcpiS3Enable to control the code

2016-04-07 Thread Zeng, Star
Laszlo, On 2016/4/7 0:26, Laszlo Ersek wrote: On 04/06/16 14:40, Star Zeng wrote: Cc: Feng Tian Cc: Jiewen Yao Cc: Laszlo Ersek Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Star Zeng

Re: [edk2] [PATCH 03/12] FatBinPkg: Change to 2-clause BSD license

2016-04-07 Thread Laszlo Ersek
On 04/07/16 08:16, Jordan Justen wrote: > (How about an r-b for some of the patches I Cc'd you on? :) > > On 2016-04-06 19:11:05, Ni, Ruiyu wrote: >>My understanding is: >> >>Shell is a very standalone project so the binary package was >>created for a certain level of isolation. And

Re: [edk2] [PATCH 20/21] ArmVirtPkg/VirtFdtDxe: drop RTC handling

2016-04-07 Thread Ard Biesheuvel
On 6 April 2016 at 18:15, Ard Biesheuvel wrote: > The RTC driver no longer relies on VirtFdtDxe to set the pl031 RTC base > address in a dynamic PCD, so drop the handling altogether. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Ard

Re: [edk2] [PATCH v2] Merge 2-clause BSD licensed FatPkg

2016-04-07 Thread Jordan Justen
Pushed as 2777ed7068f0ce186761f5cfef8a0c2252e3e2a5. Cheers! -Jordan On 2016-04-04 21:43:01, Jordan Justen wrote: > === > > web: https://github.com/jljusten/edk2/tree/fatpkg-open-source-v2 > > git: https://github.com/jljusten/edk2.git fatpkg-open-source-v2 > > In this commit

Re: [edk2] [PATCH V2 2/8] OvmfPkg: Set PcdAcpiS3Enable according to QemuFwCfgS3Enabled()

2016-04-07 Thread Laszlo Ersek
On 04/07/16 03:07, Zeng, Star wrote: > On 2016/4/7 0:16, Laszlo Ersek wrote: >> On 04/06/16 14:40, Star Zeng wrote: >>> Also need to declare PcdAcpiS3Enable as DynamicDefault in *.dsc. >>> >>> Cc: Laszlo Ersek >>> Cc: Jordan Justen >>> Cc: Jiewen Yao

Re: [edk2] [PATCH 04/21] ArmVirtPkg/FdtClientDxe: implement new driver

2016-04-07 Thread Ard Biesheuvel
On 6 April 2016 at 22:25, Laszlo Ersek wrote: > On 04/06/16 18:15, Ard Biesheuvel wrote: >> This implements a new DXE driver FdtClientDxe to produce the FDT client >> protocol based on a device tree image supplied by the virt host. >> >> Contributed-under: TianoCore

[edk2] [Patch 0/2] Add Ps2KeyboardDxe and Ps2MouseDxe to MdeModulePkg

2016-04-07 Thread Ruiyu Ni
The patch serials add the Ps2KeyboardDxe and Ps2MouseDxe to MdeModulePkg and they only depend on SIO protocol instead of ISA IO protocol. So that platform which contains SIO can use the new drivers other than using the old drivers in IntelFrameworkModulePkg. Ruiyu Ni (2): MdeModulePkg: Add

[edk2] [Patch 2/2] MdeModulePkg: Add Ps2MouseDxe driver

2016-04-07 Thread Ruiyu Ni
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ruiyu Ni Cc: Feng Tian --- MdeModulePkg/Bus/Isa/Ps2MouseDxe/CommPs2.c | 858 + MdeModulePkg/Bus/Isa/Ps2MouseDxe/CommPs2.h | 395 ++

[edk2] [Patch 1/2] MdeModulePkg: Add Ps2KeyboardDxe driver.

2016-04-07 Thread Ruiyu Ni
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ruiyu Ni Cc: Feng Tian --- .../Bus/Isa/Ps2KeyboardDxe/ComponentName.c | 352 .../Bus/Isa/Ps2KeyboardDxe/Ps2KbdCtrller.c | 1872

Re: [edk2] [Patch] SecurityPkg OpalPasswordDxe: Suppress option for special device.

2016-04-07 Thread Tian, Feng
Reviewed-by: Feng Tian Thanks Feng -Original Message- From: Dong, Eric Sent: Thursday, April 7, 2016 1:59 PM To: edk2-devel@lists.01.org Cc: Tian, Feng Subject: [Patch] SecurityPkg OpalPasswordDxe: Suppress option for special device.

Re: [edk2] [PATCH] UefiCpuPkg: CpuIo2Dxe: optimize FIFO reads and writes of IO ports

2016-04-07 Thread Fan, Jeff
Laszlo, Please add .asm file implementation to support MSFT tool chain also, because NASM is not required for MSTF tool chain now. If you cannot verify MSFT build, I could help to verify your patch with .asm file. Jeff -Original Message- From: edk2-devel

[edk2] [patch] MdeModulePkg/Usb: Fix wrong condition judgment to support usb3.1 dev

2016-04-07 Thread Feng Tian
The bcdUSB value of usb3.1 is 0x0310, we update the condition judgment to get correct max packet size for usb3.1 dev. Cc: Star Zeng Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Feng Tian --- MdeModulePkg/Bus/Pci/XhciDxe/Xhci.c

Re: [edk2] [patch] MdeModulePkg/Usb: Fix wrong condition judgment to support usb3.1 dev

2016-04-07 Thread Zeng, Star
Reviewed-by: Star Zeng -Original Message- From: Tian, Feng Sent: Friday, April 8, 2016 1:48 PM To: edk2-devel@lists.01.org Cc: Zeng, Star Subject: [patch] MdeModulePkg/Usb: Fix wrong condition judgment to support usb3.1 dev The bcdUSB value

Re: [edk2] [Patch] SecurityPkg TcgStorageOpalLib: Fix a typo.

2016-04-07 Thread Tian, Feng
Please update the commit log title. It's not a typo. It's a bug which has wrong condition judgment. Others looks good to me Reviewed-by: Feng Tian Thanks Feng -Original Message- From: Dong, Eric Sent: Thursday, April 7, 2016 9:27 PM To: edk2-devel@lists.01.org

Re: [edk2] [Patch] SecurityPkg OpalPasswordDxe: Clean up debug message.

2016-04-07 Thread Dong, Eric
Yes, I checked all files. > -Original Message- > From: Tian, Feng > Sent: Friday, April 08, 2016 10:15 AM > To: Dong, Eric; edk2-devel@lists.01.org > Cc: Tian, Feng > Subject: RE: [Patch] SecurityPkg OpalPasswordDxe: Clean up debug message. > > Do you check all files for unnecessary

Re: [edk2] [PATCH] UefiCpuPkg: CpuIo2Dxe: optimize FIFO reads and writes of IO ports

2016-04-07 Thread Ni, Ruiyu
Laszlo, After I sent the mail to propose changing the CpuIo driver to improve IO performance, I now saw your patch sent earlier than my last mail. A very interesting feeling. Reviewed-by: Ruiyu Ni Regards, Ray >-Original Message- >From: edk2-devel

Re: [edk2] [PATCH 0/2] OvmfPkg: drop PciHostBridgeDxe fork

2016-04-07 Thread Jordan Justen
On 2016-04-07 19:53:37, Ni, Ruiyu wrote: > PciHostBridge driver calls CpuIo to perform IO operation, > which is different from the previous implementation in > PcAtChipsetPkg. > > I suggest we put the IO optimization in CpuIo driver. > It can also benefit all other modules. > > Jeff, > Do you

Re: [edk2] [PATCH 08/12] DuetPkg: Convert to build FatPkg from source

2016-04-07 Thread Ni, Ruiyu
Reviewed-by: Ruiyu Ni On 2016-04-06 23:14, Jordan Justen wrote: Now that FatPkg is open source (and therefore can be included in the EDK II tree) we build and use it directly. Note: Build tested with GCC 5.3 on IA32 and X64. Contributed-under: TianoCore Contribution

Re: [edk2] [PATCH 07/12] DuetPkg scripts: Support building with GCC45 - GCC49

2016-04-07 Thread Ni, Ruiyu
Reviewed-by: Ruiyu Ni On 2016-04-06 23:14, Jordan Justen wrote: Build tested with GCC 5.3 with both IA32 and X64. Unfortunately both seemed to hang very early when boot tested on QEMU. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jordan Justen

Re: [edk2] [Patch] SecurityPkg OpalPasswordDxe: Clean up debug message.

2016-04-07 Thread Tian, Feng
Do you check all files for unnecessary debug message? If not, please update your commit title to show up this change is only for Opalhii.c Reviewed-by: Feng Tian Thanks Feng -Original Message- From: Dong, Eric Sent: Thursday, April 7, 2016 9:27 PM To:

Re: [edk2] [PATCH 10/12] Nt32Pkg: Convert to build FatPkg from source

2016-04-07 Thread Ni, Ruiyu
Reviewed-by: Ruiyu Ni On 2016-04-06 23:14, Jordan Justen wrote: Now that FatPkg is open source (and therefore can be included in the EDK II tree) we build and use it directly. Note: Not build tested Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by:

[edk2] [PATCH V3 8/8] IntelFrameworkModulePkg AcpiS3SaveDxe: Remove S3Ready() functional code

2016-04-07 Thread Star Zeng
The S3Ready() functional code has been moved to S3SaveStateDxe in MdeModulePkg, the ACPI global variable related code is leaved as is for compatibility. PcdS3BootScriptStackSize is also moved to MdeModulePkg. Cc: Jiewen Yao Cc: Jeff Fan

[edk2] [PATCH V3 2/8] OvmfPkg: Set PcdAcpiS3Enable according to QemuFwCfgS3Enabled()

2016-04-07 Thread Star Zeng
Also need to declare PcdAcpiS3Enable as DynamicDefault in *.dsc. Cc: Laszlo Ersek Cc: Jordan Justen Cc: Jiewen Yao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Star Zeng

[edk2] [PATCH V3 7/8] IntelFrameworkModulePkg AcpiS3SaveDxe: Consume PcdAcpiS3Enable to control the code

2016-04-07 Thread Star Zeng
Cc: Jeff Fan Cc: Jiewen Yao Cc: Laszlo Ersek Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Star Zeng Reviewed-by: Jiewen Yao ---

[edk2] [PATCH V3 5/8] MdeModulePkg S3SaveStateDxe: Move S3Ready() functional code from AcpiS3SaveDxe

2016-04-07 Thread Star Zeng
The S3Ready() functional code in AcpiS3SaveDxe of IntelFrameworkModulePkg is to do ACPI S3 Context save. In fact, that is not really related to Intel framework ACPI S3 protocol. IntelFrameworkModulePkg will be deprecated step by step, so move the functional code to MdeModulePkg and S3SaveStateDxe

[edk2] [PATCH V3 0/8] Move S3Ready() functional code from AcpiS3SaveDxe to S3SaveStateDxe

2016-04-07 Thread Star Zeng
The S3Ready() functional code in AcpiS3SaveDxe of IntelFrameworkModulePkg is to do ACPI S3 Context save. In fact, that is not really related to Intel framework ACPI S3 protocol. IntelFrameworkModulePkg will be deprecated step by step, so move the functional code to MdeModulePkg and S3SaveStateDxe

[edk2] [PATCH V3 1/8] MdeModulePkg: Introduce new PCD PcdAcpiS3Enable

2016-04-07 Thread Star Zeng
Platform can configure the PCD statically or dynamically to control if ACPI S3 will be enabled. S3 related modules can consume the PCD to control the code. Cc: Feng Tian Cc: Jiewen Yao Cc: Laszlo Ersek Contributed-under: TianoCore

[edk2] [PATCH V3 3/8] OvmfPkg: Install LockBox protocol in constructor of LockBoxDxeLib

2016-04-07 Thread Star Zeng
Currently, the LockBox protocol is installed in entrypoint of OVMF AcpiS3SaveDxe. We can let the first driver run with LockBoxDxeLib linked to have its library constructor to install LockBox protocol on the ImageHandle. As other drivers may have gEfiLockBoxProtocolGuid dependency, the first

[edk2] [PATCH V3 6/8] OvmfPkg: Retire AcpiS3SaveDxe

2016-04-07 Thread Star Zeng
The same functional code has been in S3SaveStateDxe, OVMF AcpiS3SaveDxe can be retired now. Cc: Laszlo Ersek Cc: Jordan Justen Cc: Jiewen Yao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Star Zeng

[edk2] [PATCH V3 4/8] MdeModulePkg S3SaveStateDxe: Consume PcdAcpiS3Enable to control the code

2016-04-07 Thread Star Zeng
Cc: Feng Tian Cc: Jiewen Yao Cc: Laszlo Ersek Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Star Zeng Reviewed-by: Laszlo Ersek Tested-by: Laszlo Ersek

Re: [edk2] [PATCH 05/12] BeagleBoardPkg: Convert to build FatPkg from source

2016-04-07 Thread Leif Lindholm
On Wed, Apr 06, 2016 at 08:14:54AM -0700, Jordan Justen wrote: > Now that FatPkg is open source (and therefore can be included in the > EDK II tree) we build and use it directly. > > Note: Not build tested I have build tested it, and no issues found. Reviewed-by: Leif Lindholm