Re: [edk2] [PATCH 4/4] OvmfPkg: Introduce UDF_ENABLE build flag

2017-08-09 Thread Andrew Fish
> On Aug 9, 2017, at 10:33 AM, Laszlo Ersek wrote: > > On 08/09/17 17:45, Andrew Fish wrote: >> >>> On Aug 9, 2017, at 2:44 AM, Laszlo Ersek wrote: >>> >>> CC Ard and Andrew >>> >>> On 08/08/17 21:31, Paulo Alcantara wrote: By defining this build

Re: [edk2] Qestion about how to debug OVMF with UDT on QEMU

2017-08-09 Thread Kinney, Michael D
Laszlo, I works really well for me using QEMU on Windows. * Build OVMF setting -D SOURCE_DEBUG_ENABLE and -D DEBUG_ON_SERIAL_PORT. * Configure The UDK Debugger SoftDebugger.ini file to use TCP port 20716 [Debug Port] Channel = TCP Server = localhost Port = 20716 * Configure QEMU so

Re: [edk2] [PATCH 4/4] OvmfPkg: Introduce UDF_ENABLE build flag

2017-08-09 Thread Andrew Fish
> On Aug 9, 2017, at 2:44 AM, Laszlo Ersek wrote: > > CC Ard and Andrew > > On 08/08/17 21:31, Paulo Alcantara wrote: >> By defining this build flag, OVMF will support booting from UDF file >> systems. >> >> Cc: Jordan Justen >> Cc: Laszlo Ersek

Re: [edk2] [PATCH 4/4] OvmfPkg: Introduce UDF_ENABLE build flag

2017-08-09 Thread Laszlo Ersek
On 08/09/17 17:45, Andrew Fish wrote: > >> On Aug 9, 2017, at 2:44 AM, Laszlo Ersek wrote: >> >> CC Ard and Andrew >> >> On 08/08/17 21:31, Paulo Alcantara wrote: >>> By defining this build flag, OVMF will support booting from UDF file >>> systems. >>> >>> Cc: Jordan Justen

Re: [edk2] [PATCH v1 01/14] OvmfPkg/Virtio: Introduce new member functions in VIRTIO_DEVICE_PROTOCOL

2017-08-09 Thread Brijesh Singh
On 08/09/2017 09:27 AM, Laszlo Ersek wrote: On 08/07/17 13:58, Brijesh Singh wrote: The patch extends VIRTIO_DEVICE_PROTOCOL to provide the following new member functions: - AllocateSharedPages : allocate a memory region suitable for sharing between guest and hypervisor (e.g ring

Re: [edk2] Qestion about how to debug OVMF with UDT on QEMU

2017-08-09 Thread wang xiaofeng
HI Michael, I have tried your suggestion. ttermpro.exe shows connection refused in my Win7 after command "start "Monitor" /B %TERA_TERM_PATH% localhost:20717 /nossh" the tool also cannot work lonely. Any other software or configuration should I apply? Thanks! At 2017-08-10

[edk2] [Patch 2/2] UefiCpuPkg UefiCpupkg.uni: Add new pcds comments.

2017-08-09 Thread Eric Dong
Cc: Liming Gao Cc: Ruiyu Ni Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Eric Dong --- UefiCpuPkg/UefiCpuPkg.uni | 8 1 file changed, 8 insertions(+) diff --git a/UefiCpuPkg/UefiCpuPkg.uni

[edk2] [Patch 1/2] UefiCpuPkg: Add comments for PCDs definition.

2017-08-09 Thread Eric Dong
Cc: Liming Gao Cc: Ruiyu Ni Cc: Michael D Kinney Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Eric Dong --- UefiCpuPkg/UefiCpuPkg.dec | 22 ++ 1 file

[edk2] [Patch 0/2] Add comments for new Pcds

2017-08-09 Thread Eric Dong
Add missed Pcds definition and comments in dec and inf files. Eric Dong (2): UefiCpuPkg: Add comments for PCDs definition. UefiCpuPkg UefiCpupkg.uni: Add new pcds comments. UefiCpuPkg/UefiCpuPkg.dec | 22 ++ UefiCpuPkg/UefiCpuPkg.uni | 8 2 files changed, 30

[edk2] Qestion about how to debug OVMF with UDT on QEMU

2017-08-09 Thread wang xiaofeng
Hello All, I try to debug OVMF with UDT on QEMU in windows. I build OVMF on windows 7 with VS2013 . And also runs it in QEMUWin32. I add DEFINE SOURCE_DEBUG_ENABLE = TRUE in ovmf.dsc and build a new bios. From makefile it seems this feature is enabled for OVMF SecMain

[edk2] [PATCH 2/2] ShellPkg/driver: Show "-" in non-SFO mode

2017-08-09 Thread Ruiyu Ni
From: Huajing Li The patch shows "X"/"-" instead of "Y"/"N" in column "CFG" and "DIAG". The patch shows "-" instead of "0" in column "#D" and "#C". Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Huajing Li Reviewed-by: Ruiyu

Re: [edk2] [PATCH 0/2] Notify NVME HW when system reset happens

2017-08-09 Thread Wu, Hao A
> -Original Message- > From: Ni, Ruiyu > Sent: Wednesday, August 09, 2017 3:57 PM > To: Wu, Hao A; edk2-devel@lists.01.org > Subject: RE: [edk2] [PATCH 0/2] Notify NVME HW when system reset happens > > The NVME controller requires notification for shutdown as part of its > management of

[edk2] [PATCH 0/2] Refine output of "driver" command

2017-08-09 Thread Ruiyu Ni
Huajing Li (2): ShellPkg/driver: Show Image Name in non-SFO mode ShellPkg/driver: Show "-" in non-SFO mode .../Library/UefiShellDriver1CommandsLib/Drivers.c | 130 ++--- .../UefiShellDriver1CommandsLib.h | 4 + .../UefiShellDriver1CommandsLib.uni

[edk2] [PATCH 1/2] ShellPkg/driver: Show Image Name in non-SFO mode

2017-08-09 Thread Ruiyu Ni
From: Huajing Li Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Huajing Li Reviewed-by: Ruiyu Ni --- .../Library/UefiShellDriver1CommandsLib/Drivers.c | 99 +-

Re: [edk2] [PATCH 0/4] read-only UDF file system support

2017-08-09 Thread Ni, Ruiyu
Paulo, Thanks for enabling the UDF support into EDKII. Below are several comments: 1. Could you please separate the patch to modify MdePkg and MdeModulePkg? 2. UDF_CDROM_VOLUME_IDENTIFIER is also defined in Eltorito.h as CDVOL_ID. Maybe we could redefine CDVOL_ID to

Re: [edk2] [PATCH 4/4] OvmfPkg: Introduce UDF_ENABLE build flag

2017-08-09 Thread Laszlo Ersek
CC Ard and Andrew On 08/08/17 21:31, Paulo Alcantara wrote: > By defining this build flag, OVMF will support booting from UDF file > systems. > > Cc: Jordan Justen > Cc: Laszlo Ersek > Contributed-under: TianoCore Contribution Agreement 1.1 >

[edk2] [PATCH v6 1/2] EmbeddedPkg/AndroidFastboot: split android boot header

2017-08-09 Thread Jun Nie
Split android boot header definition to share code among different applications and libraries. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jun Nie --- .../Application/AndroidFastboot/AndroidBootImg.c | 35 ++---

[edk2] [PATCH v6 2/2] EmbeddedPkg/AndroidBoot: boot android kernel from storage

2017-08-09 Thread Jun Nie
Add an android kernel loader that could load kernel from storage device. This android boot image BDS add addtitional cmdline/dtb/ramfs support besides kernel that is introduced by Android boot header. This patch is derived from Haojian's code as below link. https://patches.linaro.org/patch/94683/

Re: [edk2] Qestion about how to debug OVMF with UDT on QEMU

2017-08-09 Thread Laszlo Ersek
On 08/09/17 09:34, wang xiaofeng wrote: > Hello All, >I try to debug OVMF with UDT on QEMU in windows. >I build OVMF on windows 7 with VS2013 . And also runs it in QEMUWin32. >I add DEFINE SOURCE_DEBUG_ENABLE = TRUE in ovmf.dsc and build a new > bios. From makefile it seems this

Re: [edk2] [Patch 0/2] Add comments for new Pcds

2017-08-09 Thread Laszlo Ersek
Eric, On 08/09/17 08:32, Eric Dong wrote: > Add missed Pcds definition and comments in dec and inf files. > > Eric Dong (2): > UefiCpuPkg: Add comments for PCDs definition. > UefiCpuPkg UefiCpupkg.uni: Add new pcds comments. > > UefiCpuPkg/UefiCpuPkg.dec | 22 ++ >

Re: [edk2] [Patch 0/2] Add comments for new Pcds

2017-08-09 Thread Dong, Eric
Laszlo, Thanks for your advice. I will pay more attention to the check in log later. Thanks, Eric -Original Message- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Wednesday, August 9, 2017 7:15 PM To: Dong, Eric Cc: edk2-devel@lists.01.org; Justen, Jordan L

Re: [edk2] [PATCH v1 00/14] OvmfPkg/Virtio: Add APIs to map system physical to device address

2017-08-09 Thread Laszlo Ersek
On 08/09/17 19:56, Laszlo Ersek wrote: > Build instructions for ArmVirtQemu, and usage hints for the QEMU command > line, can be found in the Linaro Wiki: > > https://wiki.linaro.org/LEG/UEFIforQEMU It's visible in the Wiki article, but I'd like to point it out nevertheless, that you can

Re: [edk2] [PATCH v1 04/14] OvmfPkg/VirtioLib: Add SharedBuffer helper functions

2017-08-09 Thread Laszlo Ersek
On 08/07/17 13:58, Brijesh Singh wrote: > Patch adds convenience helper functions to call VIRTIO_DEVICE_PROTOCOL > AllocateSharedPages, FreeSharedPages, MapSharedBuffer and UnmapSharedBuffer > member functions. > > Cc: Ard Biesheuvel > Cc: Jordan Justen

Re: [edk2] Qestion about how to debug OVMF with UDT on QEMU

2017-08-09 Thread Laszlo Ersek
On 08/09/17 20:21, Kinney, Michael D wrote: > Laszlo, > > I works really well for me using QEMU on Windows. > > * Build OVMF setting -D SOURCE_DEBUG_ENABLE and -D DEBUG_ON_SERIAL_PORT. > > * Configure The UDK Debugger SoftDebugger.ini file to use TCP port 20716 > > [Debug Port] > Channel =

[edk2] [Patch 1/2] QuarkSocPkg/MemoryInit: Remove use of memset()/memcpy()

2017-08-09 Thread Michael D Kinney
Map the use of memset() and memcpy() to the BaseMemoryLib functions ZeroMem(), SetMem(), and CopyMem(). This fixes GCC build issues with this module. With the remap of the functions, the [BuildOptions] MSFT CC_FLAGS to enable /Oi can also be removed, so the MSFT and GCC builds behave the same.

[edk2] OvmfPkg (PlatformPei?): supporting Qemu's nvdimm device

2017-08-09 Thread Rebecca Cran
I've been investigating adding support for Qemu's nvdimm devices to OVMF. I was thinking such support would go into PlatformPei, but it looks like I can only read the ACPI NFIT in the DXE phase. So, should Qemu be changed to add non-volatile memory to the e820 table, or should such memory be

[edk2] [Patch 0/2] Update Quark for edk2-non-osi changes

2017-08-09 Thread Michael D Kinney
Update PACKAGES_PATH requirements Readme.md to match the new directory structure in the edk2-non-osi repository and update instructions to run python-based build tools from sources and remove edk2-FatPkg repository. Also fix GCC compatibility issues from use of memset() in the MemoryInit module

Re: [edk2] [PATCH v1 02/14] OvmfPkg/Virtio10Dxe: Implement new member functions

2017-08-09 Thread Laszlo Ersek
(1) For the subject, I suggest again OvmfPkg/Virtio10Dxe: Implement IOMMU-like member functions On 08/07/17 13:58, Brijesh Singh wrote: > The patch implements the newly added member functions by respectively > delegating the job to: > > - EFI_PCI_IO_PROTOCOL.AllocateBuffer() -- with

Re: [edk2] [PATCH v1 03/14] OvmfPkg/VirtioPciDeviceDxe: Implement new member functions

2017-08-09 Thread Laszlo Ersek
On 08/07/17 13:58, Brijesh Singh wrote: > The patch implements the newly added member functions by respectively > delegating the job to: > > - MemoryApplicationLib.AllocatePages () -- with BootServicesData > - MemoryApplicationLib.FreePages () > - no-op (host address is same as device DMA

Re: [edk2] [PATCH v1 00/14] OvmfPkg/Virtio: Add APIs to map system physical to device address

2017-08-09 Thread Brijesh Singh
On 08/09/2017 09:39 AM, Laszlo Ersek wrote: On 08/07/17 13:58, Brijesh Singh wrote: Currently, virtio drivers provides the system physical address to the device. However, some systems may feature an IOMMU that requires the drivers to pass the device addresses to the device - which are then

Re: [edk2] [PATCH v1 05/14] OvmfPkg/VirtioLib: Pass VirtIo instance in VringInit/Uinit()

2017-08-09 Thread Laszlo Ersek
(1) the subject has a typo ("Uinit()") so I suggest: OvmfPkg/VirtioLib: take VirtIo instance in VirtioRingInit/VirtioRingUninit (74 characters). On 08/07/17 13:58, Brijesh Singh wrote: > Passing the VirtIo protocol instance will allow the vring to use >

Re: [edk2] [PATCH v1 00/14] OvmfPkg/Virtio: Add APIs to map system physical to device address

2017-08-09 Thread Brijesh Singh
On 08/09/2017 05:38 PM, Laszlo Ersek wrote: On 08/07/17 13:58, Brijesh Singh wrote: Currently, virtio drivers provides the system physical address to the device. However, some systems may feature an IOMMU that requires the drivers to pass the device addresses to the device - which are then

Re: [edk2] [PATCH v1 00/14] OvmfPkg/Virtio: Add APIs to map system physical to device address

2017-08-09 Thread Laszlo Ersek
On 08/07/17 13:58, Brijesh Singh wrote: > Currently, virtio drivers provides the system physical address to the device. > However, some systems may feature an IOMMU that requires the drivers to pass > the device addresses to the device - which are then translated by the IOMMU > into physical

Re: [edk2] OvmfPkg (PlatformPei?): supporting Qemu's nvdimm device

2017-08-09 Thread Laszlo Ersek
On 08/09/17 22:47, Rebecca Cran wrote: > I've been investigating adding support for Qemu's nvdimm devices to > OVMF. I was thinking such support would go into PlatformPei, but it > looks like I can only read the ACPI NFIT in the DXE phase. So, should > Qemu be changed to add non-volatile memory

Re: [edk2] [PATCH v1 14/14] OvmfPkg/VirtioRngDxe: Use DeviceAddresses in vring descriptors

2017-08-09 Thread Laszlo Ersek
On 08/10/17 02:25, Laszlo Ersek wrote: > On 08/07/17 13:58, Brijesh Singh wrote: >> The patch uses newly introduced VIRTIO_DEVICE_PROTOCOL.MapSharedBuffer() >> to map system memory to device address and programs the vring descriptors >> with device addresses. >> >> Cc: Ard Biesheuvel

Re: [edk2] [PATCH] BaseTools/edksetup.sh: fix invalid test for current working directory

2017-08-09 Thread Zhu, Yonghong
Reviewed-by: Yonghong Zhu Best Regards, Zhu Yonghong -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Chris Ruffin Sent: Thursday, August 03, 2017 11:38 PM To: edk2-devel@lists.01.org Subject: [edk2] [PATCH]

Re: [edk2] [PATCH 05/11] ShellPkg/UefiShellLevel2CommandsLib: Remove unnecessary EFIAPI

2017-08-09 Thread Palmer, Thomas
It is not urgent for me. Regards, Thomas Palmer "I have only made this letter longer because I have not had the time to make it shorter" - Blaise Pascal -Original Message- From: Ni, Ruiyu [mailto:ruiyu...@intel.com] Sent: Wednesday, August 9, 2017 7:42 PM To: Palmer, Thomas

[edk2] Does a double Page free report "ConvertPages: Incompatible memory types", maybe we could do better.

2017-08-09 Thread Andrew Fish
It looks to me like if you Free pages, after you free pages you hit this DEBUG message. https://github.com/tianocore/edk2/blob/master/MdeModulePkg/Core/Dxe/Mem/Page.c#L790 if (!(NewType == EfiConventionalMemory ? 1 : 0) ^ (Entry->Type == EfiConventionalMemory ? 1 : 0)) { DEBUG

Re: [edk2] [PATCH 0/4] read-only UDF file system support

2017-08-09 Thread Ni, Ruiyu
Regards, Ray >-Original Message- >From: Paulo Alcantara [mailto:pca...@zytor.com] >Sent: Wednesday, August 9, 2017 10:01 PM >To: Ni, Ruiyu ; Zeng, Star ; >edk2-devel@lists.01.org >Cc: Dong, Eric ; Wu, Hao A

Re: [edk2] [edk2-DSCSpecification Patch] DSC Spec: Remove Restriction on Using NULL in [LibraryClasses] Section

2017-08-09 Thread Kinney, Michael D
Reviewed-by: Michael D Kinney > -Original Message- > From: Zhu, Yonghong > Sent: Wednesday, August 2, 2017 12:41 AM > To: edk2-devel@lists.01.org > Cc: Gao, Liming ; Kinney, Michael D > ; Shaw, Kevin W >

Re: [edk2] [PATCH 05/11] ShellPkg/UefiShellLevel2CommandsLib: Remove unnecessary EFIAPI

2017-08-09 Thread Palmer, Thomas
Ruiyu, Will you put out the appropriate patch or should I? Regards, Thomas Palmer "I have only made this letter longer because I have not had the time to make it shorter" - Blaise Pascal -Original Message- From: Ni, Ruiyu [mailto:ruiyu...@intel.com] Sent: Monday, August 7,

Re: [edk2] [PATCH v1 06/14] OvmfPkg/VirtioLib: Add functions to map/unmap VRING

2017-08-09 Thread Laszlo Ersek
First some superficial comments, then some more serious ones. On 08/07/17 13:58, Brijesh Singh wrote: > Add functions to map and unmap the ring buffer with BusMasterCommonBuffer. > > Cc: Ard Biesheuvel > Cc: Jordan Justen > Cc: Tom Lendacky

Re: [edk2] [Patch 1/2] UefiCpuPkg: Add comments for PCDs definition.

2017-08-09 Thread Kinney, Michael D
Eric, Please add the default value settings to the detailed description. For example, PcdCpuProcTraceMemSize should say that the default value is 0x10 which disables the processor memory trace. Also, the .uni file _HELP should contains the same information as the detailed description, including

Re: [edk2] [PATCH v1 07/14] OvmfPkg/VirtioLib: Use AllocateShared() to allocate vring buffer

2017-08-09 Thread Laszlo Ersek
On 08/07/17 13:58, Brijesh Singh wrote: > The vring buffer is communication block between guest and hypervisor, > allocate the vring buffer using AllocateSharedPages() so that it can be > Map() with BusMasterCommonBufer for bi-directional access. > > Cc: Ard Biesheuvel

Re: [edk2] [PATCH v1 14/14] OvmfPkg/VirtioRngDxe: Use DeviceAddresses in vring descriptors

2017-08-09 Thread Laszlo Ersek
On 08/07/17 13:58, Brijesh Singh wrote: > The patch uses newly introduced VIRTIO_DEVICE_PROTOCOL.MapSharedBuffer() > to map system memory to device address and programs the vring descriptors > with device addresses. > > Cc: Ard Biesheuvel > Cc: Jordan Justen

Re: [edk2] [PATCH] MdeModulePkg/EmmcDxe: Use Trim instead of Erase for EraseBlocks

2017-08-09 Thread Jun Nie
On 2017年08月08日 10:04, Hao Wu wrote: The current implementation of the Erase Block Protocol service EraseBlocks() uses the erase command. According to spec eMMC Electrical Standard 5.1, Section 6.6.9: The erasable unit of the eMMC is the "Erase Group"; Erase group is measured in write blocks

Re: [edk2] [PATCH 4/4] OvmfPkg: Introduce UDF_ENABLE build flag

2017-08-09 Thread Paulo Alcantara
Hi, On 8/9/2017 6:44 AM, Laszlo Ersek wrote: CC Ard and Andrew On 08/08/17 21:31, Paulo Alcantara wrote: By defining this build flag, OVMF will support booting from UDF file systems. Cc: Jordan Justen Cc: Laszlo Ersek Contributed-under:

Re: [edk2] [PATCH v1 01/14] OvmfPkg/Virtio: Introduce new member functions in VIRTIO_DEVICE_PROTOCOL

2017-08-09 Thread Laszlo Ersek
On 08/07/17 13:58, Brijesh Singh wrote: > The patch extends VIRTIO_DEVICE_PROTOCOL to provide the following new > member functions: > > - AllocateSharedPages : allocate a memory region suitable for sharing >between guest and hypervisor (e.g ring buffer). > > - FreeSharedPages: free the

[edk2] [Patch v2 2/2] UefiCpuPkg UefiCpupkg.uni: Add new pcds comments.

2017-08-09 Thread Eric Dong
Add prompt/help string for pcd PcdCpuProcTraceOutputScheme and PcdCpuProcTraceMemSize in UefiCpuPkg.uni file. Cc: Liming Gao Cc: Ruiyu Ni Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Eric Dong ---

[edk2] [Patch v2 1/2] UefiCpuPkg: Add comments for PCDs definition.

2017-08-09 Thread Eric Dong
Add valid values for PCD PcdCpuProcTraceMemSize and PcdCpuProcTraceOutputScheme in the comment part. Cc: Liming Gao Cc: Ruiyu Ni Cc: Michael D Kinney Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by:

Re: [edk2] [PATCH 0/4] read-only UDF file system support

2017-08-09 Thread Paulo Alcantara
Hi Ray, Thanks for the review. My comments below. On 8/9/2017 3:05 AM, Ni, Ruiyu wrote: Paulo, Thanks for enabling the UDF support into EDKII. Below are several comments: 1. Could you please separate the patch to modify MdePkg and MdeModulePkg? Sure. 2. UDF_CDROM_VOLUME_IDENTIFIER is also

Re: [edk2] [PATCH v1 00/14] OvmfPkg/Virtio: Add APIs to map system physical to device address

2017-08-09 Thread Laszlo Ersek
On 08/07/17 13:58, Brijesh Singh wrote: > Currently, virtio drivers provides the system physical address to the device. > However, some systems may feature an IOMMU that requires the drivers to pass > the device addresses to the device - which are then translated by the IOMMU > into physical

Re: [edk2] [PATCH 0/4] read-only UDF file system support

2017-08-09 Thread Paulo Alcantara
(heh - forgot to answer your question about the GUID :-) ) On 8/9/2017 10:26 AM, Paulo Alcantara wrote: Hi Ray, Thanks for the review. My comments below. On 8/9/2017 3:05 AM, Ni, Ruiyu wrote: Paulo, Thanks for enabling the UDF support into EDKII. Below are several comments: 1. Could you