Hello All,
I try to debug OVMF with UDT on QEMU in windows.
I build OVMF on windows 7 with VS2013 . And also runs it in QEMUWin32.
I add DEFINE SOURCE_DEBUG_ENABLE = TRUE in ovmf.dsc and build a new
bios. From makefile it seems this feature is enabled for OVMF SecMain
$(BIN_
From: Huajing Li
The patch shows "X"/"-" instead of "Y"/"N" in column "CFG"
and "DIAG".
The patch shows "-" instead of "0" in column "#D" and "#C".
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Huajing Li
Reviewed-by: Ruiyu Ni
---
.../Library/UefiShellDriver1CommandsL
Huajing Li (2):
ShellPkg/driver: Show Image Name in non-SFO mode
ShellPkg/driver: Show "-" in non-SFO mode
.../Library/UefiShellDriver1CommandsLib/Drivers.c | 130 ++---
.../UefiShellDriver1CommandsLib.h | 4 +
.../UefiShellDriver1CommandsLib.uni
From: Huajing Li
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Huajing Li
Reviewed-by: Ruiyu Ni
---
.../Library/UefiShellDriver1CommandsLib/Drivers.c | 99 +-
.../UefiShellDriver1CommandsLib.h | 4 +
.../UefiShellDriver1CommandsLi
The NVME controller requires notification for shutdown as part of its
management of internal structures. Even with FUA, failing to notify the NVME
controller to shutdown power off causes the NVME controller to take quite some
time to organize its tables on the next power on. This time exceeds
> -Original Message-
> From: Ni, Ruiyu
> Sent: Wednesday, August 09, 2017 3:57 PM
> To: Wu, Hao A; edk2-devel@lists.01.org
> Subject: RE: [edk2] [PATCH 0/2] Notify NVME HW when system reset happens
>
> The NVME controller requires notification for shutdown as part of its
> management of in
CC Ard and Andrew
On 08/08/17 21:31, Paulo Alcantara wrote:
> By defining this build flag, OVMF will support booting from UDF file
> systems.
>
> Cc: Jordan Justen
> Cc: Laszlo Ersek
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Paulo Alcantara
> ---
> OvmfPkg/Ovm
Add an android kernel loader that could load kernel from storage
device.
This android boot image BDS add addtitional cmdline/dtb/ramfs
support besides kernel that is introduced by Android boot header.
This patch is derived from Haojian's code as below link.
https://patches.linaro.org/patch/94683/
Split android boot header definition to share code among
different applications and libraries.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jun Nie
---
.../Application/AndroidFastboot/AndroidBootImg.c | 35 ++---
.../AndroidFastboot/AndroidFastbootApp.h
On 08/09/17 09:34, wang xiaofeng wrote:
> Hello All,
>I try to debug OVMF with UDT on QEMU in windows.
>I build OVMF on windows 7 with VS2013 . And also runs it in QEMUWin32.
>I add DEFINE SOURCE_DEBUG_ENABLE = TRUE in ovmf.dsc and build a new
> bios. From makefile it seems this
Eric,
On 08/09/17 08:32, Eric Dong wrote:
> Add missed Pcds definition and comments in dec and inf files.
>
> Eric Dong (2):
> UefiCpuPkg: Add comments for PCDs definition.
> UefiCpuPkg UefiCpupkg.uni: Add new pcds comments.
>
> UefiCpuPkg/UefiCpuPkg.dec | 22 ++
> UefiC
Laszlo,
Thanks for your advice. I will pay more attention to the check in log later.
Thanks,
Eric
-Original Message-
From: Laszlo Ersek [mailto:ler...@redhat.com]
Sent: Wednesday, August 9, 2017 7:15 PM
To: Dong, Eric
Cc: edk2-devel@lists.01.org; Justen, Jordan L ;
Kinney, Michael D
v2 changes includes: Add valid values and prompt/help string for new add pcd
PcdCpuProcTraceMemSize and PcdCpuProcTraceOutputScheme.
Eric Dong (2):
UefiCpuPkg: Add comments for PCDs definition.
UefiCpuPkg UefiCpupkg.uni: Add new pcds comments.
UefiCpuPkg/UefiCpuPkg.dec | 22 +
Add prompt/help string for pcd PcdCpuProcTraceOutputScheme
and PcdCpuProcTraceMemSize in UefiCpuPkg.uni file.
Cc: Liming Gao
Cc: Ruiyu Ni
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Eric Dong
---
UefiCpuPkg/UefiCpuPkg.uni | 8
1 file changed, 8 insertions(+)
Add valid values for PCD PcdCpuProcTraceMemSize and
PcdCpuProcTraceOutputScheme in the comment part.
Cc: Liming Gao
Cc: Ruiyu Ni
Cc: Michael D Kinney
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Eric Dong
---
UefiCpuPkg/UefiCpuPkg.dec | 22 ++
1 f
Hi Ray,
Thanks for the review. My comments below.
On 8/9/2017 3:05 AM, Ni, Ruiyu wrote:
Paulo,
Thanks for enabling the UDF support into EDKII.
Below are several comments:
1. Could you please separate the patch to modify MdePkg and MdeModulePkg?
Sure.
2. UDF_CDROM_VOLUME_IDENTIFIER is also d
Hi,
On 8/9/2017 6:44 AM, Laszlo Ersek wrote:
CC Ard and Andrew
On 08/08/17 21:31, Paulo Alcantara wrote:
By defining this build flag, OVMF will support booting from UDF file
systems.
Cc: Jordan Justen
Cc: Laszlo Ersek
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Pa
(heh - forgot to answer your question about the GUID :-) )
On 8/9/2017 10:26 AM, Paulo Alcantara wrote:
Hi Ray,
Thanks for the review. My comments below.
On 8/9/2017 3:05 AM, Ni, Ruiyu wrote:
Paulo,
Thanks for enabling the UDF support into EDKII.
Below are several comments:
1. Could you pleas
On 08/07/17 13:58, Brijesh Singh wrote:
> The patch extends VIRTIO_DEVICE_PROTOCOL to provide the following new
> member functions:
>
> - AllocateSharedPages : allocate a memory region suitable for sharing
>between guest and hypervisor (e.g ring buffer).
>
> - FreeSharedPages: free the memory
On 08/07/17 13:58, Brijesh Singh wrote:
> Currently, virtio drivers provides the system physical address to the device.
> However, some systems may feature an IOMMU that requires the drivers to pass
> the device addresses to the device - which are then translated by the IOMMU
> into physical addre
> On Aug 9, 2017, at 2:44 AM, Laszlo Ersek wrote:
>
> CC Ard and Andrew
>
> On 08/08/17 21:31, Paulo Alcantara wrote:
>> By defining this build flag, OVMF will support booting from UDF file
>> systems.
>>
>> Cc: Jordan Justen
>> Cc: Laszlo Ersek
>> Contributed-under: TianoCore Contribution A
(1) For the subject, I suggest again
OvmfPkg/Virtio10Dxe: Implement IOMMU-like member functions
On 08/07/17 13:58, Brijesh Singh wrote:
> The patch implements the newly added member functions by respectively
> delegating the job to:
>
> - EFI_PCI_IO_PROTOCOL.AllocateBuffer() -- with BootServi
On 08/07/17 13:58, Brijesh Singh wrote:
> The patch implements the newly added member functions by respectively
> delegating the job to:
>
> - MemoryApplicationLib.AllocatePages () -- with BootServicesData
> - MemoryApplicationLib.FreePages ()
> - no-op (host address is same as device DMA address)
On 08/09/17 17:45, Andrew Fish wrote:
>
>> On Aug 9, 2017, at 2:44 AM, Laszlo Ersek wrote:
>>
>> CC Ard and Andrew
>>
>> On 08/08/17 21:31, Paulo Alcantara wrote:
>>> By defining this build flag, OVMF will support booting from UDF file
>>> systems.
>>>
>>> Cc: Jordan Justen
>>> Cc: Laszlo Ersek
On 08/09/2017 09:39 AM, Laszlo Ersek wrote:
On 08/07/17 13:58, Brijesh Singh wrote:
Currently, virtio drivers provides the system physical address to the device.
However, some systems may feature an IOMMU that requires the drivers to pass
the device addresses to the device - which are then tra
> On Aug 9, 2017, at 10:33 AM, Laszlo Ersek wrote:
>
> On 08/09/17 17:45, Andrew Fish wrote:
>>
>>> On Aug 9, 2017, at 2:44 AM, Laszlo Ersek wrote:
>>>
>>> CC Ard and Andrew
>>>
>>> On 08/08/17 21:31, Paulo Alcantara wrote:
By defining this build flag, OVMF will support booting from UDF
On 08/09/17 19:35, Brijesh Singh wrote:
>
>
> On 08/09/2017 09:39 AM, Laszlo Ersek wrote:
>> On 08/07/17 13:58, Brijesh Singh wrote:
>>> Currently, virtio drivers provides the system physical address to the
>>> device.
>>> However, some systems may feature an IOMMU that requires the drivers
>>> t
Laszlo,
I works really well for me using QEMU on Windows.
* Build OVMF setting -D SOURCE_DEBUG_ENABLE and -D DEBUG_ON_SERIAL_PORT.
* Configure The UDK Debugger SoftDebugger.ini file to use TCP port 20716
[Debug Port]
Channel = TCP
Server = localhost
Port = 20716
* Configure QEMU so the
On 08/09/2017 09:27 AM, Laszlo Ersek wrote:
On 08/07/17 13:58, Brijesh Singh wrote:
The patch extends VIRTIO_DEVICE_PROTOCOL to provide the following new
member functions:
- AllocateSharedPages : allocate a memory region suitable for sharing
between guest and hypervisor (e.g ring buffer).
On 08/09/17 19:56, Laszlo Ersek wrote:
> Build instructions for ArmVirtQemu, and usage hints for the QEMU command
> line, can be found in the Linaro Wiki:
>
> https://wiki.linaro.org/LEG/UEFIforQEMU
It's visible in the Wiki article, but I'd like to point it out
nevertheless, that you can selec
On 08/09/17 20:21, Kinney, Michael D wrote:
> Laszlo,
>
> I works really well for me using QEMU on Windows.
>
> * Build OVMF setting -D SOURCE_DEBUG_ENABLE and -D DEBUG_ON_SERIAL_PORT.
>
> * Configure The UDK Debugger SoftDebugger.ini file to use TCP port 20716
>
> [Debug Port]
> Channel =
Update PACKAGES_PATH requirements Readme.md to match the new directory
structure in the edk2-non-osi repository and update instructions to run
python-based build tools from sources and remove edk2-FatPkg repository.
Also fix GCC compatibility issues from use of memset() in the MemoryInit
module i
The following commit moved the QuarkSocBinPkg from the root
directory to the the Silicon/Intel directory.
https://github.com/tianocore/edk2-non-osi/commit/182e85d04566800fe188de4b1c30a50533dd74b7
The following updates are made to Readme.md:
* PACKAGES_PATH setting for edk2-non-osi directory chan
Map the use of memset() and memcpy() to the BaseMemoryLib
functions ZeroMem(), SetMem(), and CopyMem(). This fixes
GCC build issues with this module.
With the remap of the functions, the [BuildOptions] MSFT
CC_FLAGS to enable /Oi can also be removed, so the MSFT
and GCC builds behave the same.
C
On 08/07/17 13:58, Brijesh Singh wrote:
> Patch adds convenience helper functions to call VIRTIO_DEVICE_PROTOCOL
> AllocateSharedPages, FreeSharedPages, MapSharedBuffer and UnmapSharedBuffer
> member functions.
>
> Cc: Ard Biesheuvel
> Cc: Jordan Justen
> Cc: Tom Lendacky
> Cc: Laszlo Ersek
>
I've been investigating adding support for Qemu's nvdimm devices to
OVMF. I was thinking such support would go into PlatformPei, but it
looks like I can only read the ACPI NFIT in the DXE phase. So, should
Qemu be changed to add non-volatile memory to the e820 table, or should
such memory be a
(1) the subject has a typo ("Uinit()") so I suggest:
OvmfPkg/VirtioLib: take VirtIo instance in VirtioRingInit/VirtioRingUninit
(74 characters).
On 08/07/17 13:58, Brijesh Singh wrote:
> Passing the VirtIo protocol instance will allow the vring to use
> VIRTIO_DEVICE_PROTOCOL.AllocateSharedPages
On 08/09/17 22:47, Rebecca Cran wrote:
> I've been investigating adding support for Qemu's nvdimm devices to
> OVMF. I was thinking such support would go into PlatformPei, but it
> looks like I can only read the ACPI NFIT in the DXE phase. So, should
> Qemu be changed to add non-volatile memory to
On 08/07/17 13:58, Brijesh Singh wrote:
> Currently, virtio drivers provides the system physical address to the device.
> However, some systems may feature an IOMMU that requires the drivers to pass
> the device addresses to the device - which are then translated by the IOMMU
> into physical addre
On 08/09/2017 05:38 PM, Laszlo Ersek wrote:
On 08/07/17 13:58, Brijesh Singh wrote:
Currently, virtio drivers provides the system physical address to the device.
However, some systems may feature an IOMMU that requires the drivers to pass
the device addresses to the device - which are then tra
Eric,
Please add the default value settings to the detailed description.
For example, PcdCpuProcTraceMemSize should say that the default
value is 0x10 which disables the processor memory trace.
Also, the .uni file _HELP should contains the same information
as the detailed description, including
Ruiyu,
Will you put out the appropriate patch or should I?
Regards,
Thomas Palmer
"I have only made this letter longer because I have not had the time to make it
shorter" - Blaise Pascal
-Original Message-
From: Ni, Ruiyu [mailto:ruiyu...@intel.com]
Sent: Monday, August 7,
First some superficial comments, then some more serious ones.
On 08/07/17 13:58, Brijesh Singh wrote:
> Add functions to map and unmap the ring buffer with BusMasterCommonBuffer.
>
> Cc: Ard Biesheuvel
> Cc: Jordan Justen
> Cc: Tom Lendacky
> Cc: Laszlo Ersek
> Contributed-under: TianoCore Co
On 08/07/17 13:58, Brijesh Singh wrote:
> The vring buffer is communication block between guest and hypervisor,
> allocate the vring buffer using AllocateSharedPages() so that it can be
> Map() with BusMasterCommonBufer for bi-directional access.
>
> Cc: Ard Biesheuvel
> Cc: Jordan Justen
> Cc:
On 08/07/17 13:58, Brijesh Singh wrote:
> The patch uses newly introduced VIRTIO_DEVICE_PROTOCOL.MapSharedBuffer()
> to map system memory to device address and programs the vring descriptors
> with device addresses.
>
> Cc: Ard Biesheuvel
> Cc: Jordan Justen
> Cc: Tom Lendacky
> Cc: Laszlo Erse
I've submitted a tracker for this:
https://bugzilla.tianocore.org/show_bug.cgi?id=664
It's in my to-do list. do you need the fix urgent?
Regards,
Ray
>-Original Message-
>From: Palmer, Thomas [mailto:thomas.pal...@hpe.com]
>Sent: Thursday, August 10, 2017 7:40 AM
>To: Ni, Ruiyu ; edk2-dev
On 08/10/17 02:25, Laszlo Ersek wrote:
> On 08/07/17 13:58, Brijesh Singh wrote:
>> The patch uses newly introduced VIRTIO_DEVICE_PROTOCOL.MapSharedBuffer()
>> to map system memory to device address and programs the vring descriptors
>> with device addresses.
>>
>> Cc: Ard Biesheuvel
>> Cc: Jordan
Reviewed-by: Yonghong Zhu
Best Regards,
Zhu Yonghong
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Chris
Ruffin
Sent: Thursday, August 03, 2017 11:38 PM
To: edk2-devel@lists.01.org
Subject: [edk2] [PATCH] BaseTools/edksetup.sh: fix invalid te
It is not urgent for me.
Regards,
Thomas Palmer
"I have only made this letter longer because I have not had the time to make it
shorter" - Blaise Pascal
-Original Message-
From: Ni, Ruiyu [mailto:ruiyu...@intel.com]
Sent: Wednesday, August 9, 2017 7:42 PM
To: Palmer, Thomas ; edk2-d
It looks to me like if you Free pages, after you free pages you hit this DEBUG
message.
https://github.com/tianocore/edk2/blob/master/MdeModulePkg/Core/Dxe/Mem/Page.c#L790
if (!(NewType == EfiConventionalMemory ? 1 : 0) ^ (Entry->Type ==
EfiConventionalMemory ? 1 : 0)) {
DEBUG (
Regards,
Ray
>-Original Message-
>From: Paulo Alcantara [mailto:pca...@zytor.com]
>Sent: Wednesday, August 9, 2017 10:01 PM
>To: Ni, Ruiyu ; Zeng, Star ;
>edk2-devel@lists.01.org
>Cc: Dong, Eric ; Wu, Hao A ; Justen,
>Jordan L ;
>Andrew Fish ; Gao, Liming ; Kinney,
>Michael D ;
>Laszl
V2 changes:
The Trim command is not supported on all eMMC devices. For those devices
that do not support such command, add codes to handle the scenario.
Commit message:
The current implementation of the Erase Block Protocol service
EraseBlocks() uses the erase command. According to spec eMMC Ele
Andrew,
Another path may hit this DEBUG message is AllocatePages() by AllocateAddress
type.
I think it is a good suggestion to enhance the DEBUG message. How about the
update like below?
-DEBUG ((DEBUG_ERROR | DEBUG_PAGE, "ConvertPages: Incompatible memory
types\n"));
+DEBUG ((
Reviewed-by: Michael D Kinney
> -Original Message-
> From: Zhu, Yonghong
> Sent: Wednesday, August 2, 2017 12:41 AM
> To: edk2-devel@lists.01.org
> Cc: Gao, Liming ; Kinney, Michael D
> ; Shaw, Kevin W
>
> Subject: [edk2-DSCSpecification Patch] DSC Spec: Remove
> Restriction on Using NUL
On 2017年08月08日 10:04, Hao Wu wrote:
The current implementation of the Erase Block Protocol service
EraseBlocks() uses the erase command. According to spec eMMC Electrical
Standard 5.1, Section 6.6.9:
The erasable unit of the eMMC is the "Erase Group"; Erase group is
measured in write blocks that
HI Michael,
I have tried your suggestion. ttermpro.exe shows connection refused in my
Win7 after command "start "Monitor" /B %TERA_TERM_PATH% localhost:20717 /nossh"
the tool also cannot work lonely.
Any other software or configuration should I apply?
Thanks!
At 2017-08-10 03:37:
56 matches
Mail list logo