The major features of this patchset include
adding PPTT support,
switching to Generic BDS driver,
adding capsule upgrade support,
open-source version for SnpPlatform and SasPlatform
changing DmaLib to CoherentDmaLib.
Comparison of V3:
1 Modify PPTT as the edk2 patch "MdePkg ACPI: Add some macros
Add Processor Properties Topology Table, PPTT include
Processor hierarchy node, Cache Type Structure and ID structure.
PPTT is needed for lscpu command to show socket information correctly.
https://bugs.linaro.org/show_bug.cgi?id=3206
Contributed-under: TianoCore Contribution Agreement 1.1
Signed
Move definition of Madt struct to head file, so PPTT driver
can include it.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ming Huang
Signed-off-by: Heyi Guo
Reviewed-by: Ard Biesheuvel
Reviewed-by: Graeme Gregory
Reveiwed-by: Jeremy Linton
---
Silicon/Hisilicon/Hi161
The FSP-S preferred memory region, which is defined in FSP Integration Guide,
must be reserved for BIOS S3 resume.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: zwei4
---
.../PlatformPreMemPei/FvCallback.c | 29 +++---
.../PlatformDsc/Pcd
Hisilicon-specific PlatformBootManagerLib added. It is convenient
to add specific feature, like BMC control boot option.
Remove Intel BDS from dsc file because it is out of use.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ming Huang
Signed-off-by: Heyi Guo
Signed-off-b
Modify the feature of BMC set boot option as switching generic
BDS. Break BMC SetBoot option out into BmcConfigBootLib.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ming Huang
Signed-off-by: Heyi Guo
Reviewed-by: Leif Lindholm
Reviewed-by: Ard Biesheuvel
---
Platform
Unify all D0x(include D06 in further) to cache coherent DmaLib.
This can improve boot speed.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Wang Yue
Signed-off-by: Ming Huang
Signed-off-by: Heyi Guo
Reviewed-by: Leif Lindholm
Reviewed-by: Ard Biesheuvel
---
Platform/H
1. This driver install a protocol for SnpPV600Dxe driver.
The protocol indicate which ethernet port to use and port sequence.
2. Fixed bug:Confusing Ethernet port sequence.
Move the most right Ethernet port (when looking from the front
of the chassis) to the first one in BootManage for PXE
This module support updating the boot CPU firmware only.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jason Zhang
Signed-off-by: Ming Huang
Signed-off-by: Heyi Guo
Reviewed-by: Ard Biesheuvel
Reviewed-by: Leif Lindholm
---
Platform/Hisilicon/D03/Capsule/SystemFirmw
Hi Laszlo,
Thanks for your comments. I will update the commit message.
Regards,
Dandan
-Original Message-
From: Laszlo Ersek [mailto:ler...@redhat.com]
Sent: Wednesday, February 7, 2018 4:17 PM
To: Zeng, Star ; Bi, Dandan ;
edk2-devel@lists.01.org
Cc: Ni, Ruiyu
Subject: Re: [patch]
modify processorFamily of type 4 to ProcessorFamilyIndicatorFamily2,
indicator to obtain the processor family from the Processor Family 2 field.
ProcessorFamily2 is already specified as ProcessorFamilyARM in the existing
table.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by:
This module install a protocol for SasDriverDxe. the protocol
include main information of sas controller, like controller ID,
enable or disable,base address of registers.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jason Zhang
Signed-off-by: Ming Huang
Signed-off-by: H
In order to replace command line parameter pcie_aspm=off, BIOS needs to
disable Pcie Aspm support during Pcie initilization.
D03 and D05 do not support PCIe ASPM, so we disable it in BIOS.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ming Huang
Signed-off-by: Heyi Guo
S
Add ITS affinity structure in SRAT.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ming Huang
Signed-off-by: Heyi Guo
Reviewed-by: Ard Biesheuvel
Reviewed-by: Leif Lindholm
Reviewed-by: Graeme Gregory
---
Silicon/Hisilicon/Hi1616/D05AcpiTables/D05Srat.aslc | 10 ++
Replace the old string with short one. The old one is
too long that can not be show integrallty in Setup nemu.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ming Huang
Signed-off-by: Heyi Guo
Reviewed-by: Leif Lindholm
Reviewed-by: Ard Biesheuvel
Reviewed-by: Graeme Gr
Add PXM method for Pcie device, HNS device and SAS device.
Add STA method for HNS.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: hensonwang
Signed-off-by: Ming Huang
Signed-off-by: Heyi Guo
Reviewed-by: Ard Biesheuvel
Reviewed-by: Leif Lindholm
Reviewed-by: Graeme Gre
In SCT test,we find SP805 watchdog driver can't reset when timeout
so we use another driver in MdeModulePkg.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ming Huang
Signed-off-by: Heyi Guo
Signed-off-by: GongChengYa
Reviewed-by: Leif Lindholm
Reviewed-by: Ard Biesheuv
In SCT test,we find SP805 watchdog driver can't reset when timeout
so we use another driver in MdeModulePkg.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ming Huang
Signed-off-by: Heyi Guo
Signed-off-by: GongChengYa
Reviewed-by: Leif Lindholm
Reviewed-by: Ard Biesheuv
On 6 February 2018 at 23:01, Laszlo Ersek wrote:
> "Platform.h" declares the AmdSevInitialize() function without EFIAPI, but
> the definition in "AmdSev.c" includes EFIAPI.
>
> GCC toolchains without LTO do not catch this error because "AmdSev.c" does
> not include "Platform.h"; i.e. the declarati
On Tue, Feb 06, 2018 at 03:04:48PM +, Leif Lindholm wrote:
> On Fri, Feb 02, 2018 at 08:05:41PM +0800, Heyi Guo wrote:
> > Add ITS affinity structure in SRAT.
> >
> > Contributed-under: TianoCore Contribution Agreement 1.1
> > Signed-off-by: Ming Huang
> > Signed-off-by: Heyi Guo
> > Reviewe
Thanks Liming. Looks good to me.
/Pete
On 2018.02.07 01:56, Liming Gao wrote:
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Liming Gao
Reviewed-by: Pete Batard
---
MdePkg/Library/BaseCpuLib/BaseCpuLib.inf | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
On 2018/2/2 14:45, Ruiyu Ni wrote:
From: Michael D Kinney
Add the PeiServicesResetSytstem2() function to the PeiServiesLib
to call the ResetSystem2() services in the PEI Services Table.
Cc: Liming Gao
Cc: Ruiyu Ni
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Michael
On 2018/2/2 14:45, Ruiyu Ni wrote:
From: Michael D Kinney
Update PEI Service ResetSystem() to always attempt to use
the Reset2 PPI before looking for the Reset PPI.
Cc: Liming Gao
Reviewed-by: Ruiyu Ni
Cc: Star Zeng
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Mich
On 2018/2/2 14:45, Ruiyu Ni wrote:
From: Michael D Kinney
Cc: Liming Gao
Reviewed-by: Ruiyu Ni
Cc: Star Zeng
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Michael D Kinney
Reviewed-by: Star Zeng
Thanks,
Star
---
MdeModulePkg/Core/Pei/Reset/Reset.c | 41 ++
Some minor comments added below except Laszlo's.
With them handled, Reviewed-by: Star Zeng
On 2018/2/2 14:45, Ruiyu Ni wrote:
From: Michael D Kinney
Add support for platform specific reset filters and platform
specific reset handlers to ResetSystem(). A filter may modify
the reset type and
On 2018/2/2 14:45, Ruiyu Ni wrote:
The patch adds more debug message in ResetSystem().
It also removes unnecessary check of mResetNotifyDepth.
Cc: Liming Gao
Cc: Michael D Kinney
Cc: Star Zeng
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ruiyu Ni
---
.../Universal
On 2018/2/2 14:45, Ruiyu Ni wrote:
From: Michael D Kinney
Add a PEI instance of ResetSystemLib that calls the ResetSystem2()
service in the PEI Services Table.
Add a DXE instance of ResetSystemLib that calls the ResetSystem()
service in the UEFI Runtime Services Table.
These 2 library instanc
On 2018/2/2 14:45, Ruiyu Ni wrote:
Because DxeResetSystemLib links to this library to provide
reset system services, change UefiRuntimeLib to support
the same set of module types as what DxeResetSystemLib does.
Cc: Liming Gao
Cc: Michael D Kinney
Cc: Star Zeng
Contributed-under: TianoCore Con
On 2018/2/2 14:45, Ruiyu Ni wrote:
From: Michael D Kinney
The library class that provides services to generate a GUID specific
reset, parse the GUID from a GUID specific reset, and build the
ResetData buffer for any type of reset that requires extra data.
Cc: Liming Gao
Reviewed-by: Ruiyu Ni
V2: update EBNF for Array format.
Cc: Liming Gao
Cc: Michael Kinney
Cc: Kevin W Shaw
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Yonghong Zhu
---
2_expression_overview.md | 3 +++
3_expression_format.md | 50 +++-
2 fil
On 2018/2/2 14:45, Ruiyu Ni wrote:
This driver implements Reset2, ResetFilter and ResetHandler PPIs.
Cc: Liming Gao
Cc: Michael D Kinney
Cc: Star Zeng
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ruiyu Ni
Should ResetSystemPei be added in MdeModulePkg.dsc for buil
V2: update EBNF for Array format.
Cc: Liming Gao
Cc: Michael Kinney
Cc: Kevin W Shaw
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Yonghong Zhu
---
.../32_component_inf_definition.md | 75 +-
3_edk_ii_inf_file_format/38_pcd_sections
V2: update EBNF for Array format.
Cc: Liming Gao
Cc: Michael Kinney
Cc: Kevin W Shaw
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Yonghong Zhu
---
3_edk_ii_dsc_file_format/310_pcd_sections.md | 160 +
.../33_platform_dsc_definition.md
V2: update EBNF for Array format.
Cc: Liming Gao
Cc: Michael Kinney
Cc: Kevin W Shaw
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Yonghong Zhu
---
3_edk_ii_dec_file_format/310_pcd_sections.md | 14 ++--
.../32_package_declaration_dec_definitions.md | 74 ++
V2: update EBNF for Array format.
Cc: Liming Gao
Cc: Michael Kinney
Cc: Kevin W Shaw
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Yonghong Zhu
---
7_build_environment/73_guided_tools.md | 8 +--
.../82_auto-generation_process.md | 18 +++
On 2018/2/2 14:45, Ruiyu Ni wrote:
From: Bret Barkelew
The Reset Notification protocol is added in UEFI spec to support
reset notification mechanism in the DXE phase.
This patch adds similar EDKII specific Reset Notification PPI to PEI
phase to provide the same support.
Cc: Liming Gao
Cc: Mic
Hi All,
my deepest apology for spamming the list with a test message. I have been
having problems sending emails to the list, both with git-send-email (i.e.
patches) and with Thunderbird (i.e. manually written emails). Both kinds have
been rejected with SPF (Sender Policy Framework) error messa
Thanks!
For the series:
Reviewed-by: Leif Lindholm
Pushed as 168344f..1aaec67
On Fri, Feb 02, 2018 at 07:57:21PM +0800, Heyi Guo wrote:
> The major features of this patchset:
> 1 Upgrade trusted firmware to 1.4
> 2 Workarounds for CVE-2017-5715 on Cortex A57/A72/A73 and A75 #1214
> 3 Delete som
On Wed, Feb 07, 2018 at 04:22:34PM +0800, Heyi Guo wrote:
> The major features of this patchset include
> adding PPTT support,
> switching to Generic BDS driver,
> adding capsule upgrade support,
> open-source version for SnpPlatform and SasPlatform
> changing DmaLib to CoherentDmaLib.
>
> Compar
On 7 February 2018 at 01:29, Leif Lindholm wrote:
> On Mon, Feb 05, 2018 at 04:25:52PM +0800, Haojian Zhuang wrote:
>> Add skeleton of HiKey960 platform.
>>
>> Contributed-under: TianoCore Contribution Agreement 1.1
>> Signed-off-by: Haojian Zhuang
>> ---
>> + gEmbeddedTokenSpaceGuid.PcdEmbedded
Hi all,
I have an issue on tty terminal. I setup PL011 serial console as the
tty terminal on HiKey platform. When it's built in debug mode, arrow
key works well. When it's built in release mode, arrow key can't work.
For example, DOWN key is gotten in terminal with "~[B" value in debug
build. DOW
> On 7 Feb 2018, at 15:50, Haojian Zhuang wrote:
>
> Hi all,
>
> I have an issue on tty terminal. I setup PL011 serial console as the
> tty terminal on HiKey platform. When it's built in debug mode, arrow
> key works well. When it's built in release mode, arrow key can't work.
>
> For example,
On 7 February 2018 at 23:52, Ard Biesheuvel wrote:
>
>> On 7 Feb 2018, at 15:50, Haojian Zhuang wrote:
>>
>> Hi all,
>>
>> I have an issue on tty terminal. I setup PL011 serial console as the
>> tty terminal on HiKey platform. When it's built in debug mode, arrow
>> key works well. When it's buil
On 7 February 2018 at 16:12, Haojian Zhuang wrote:
> On 7 February 2018 at 23:52, Ard Biesheuvel wrote:
>>
>>> On 7 Feb 2018, at 15:50, Haojian Zhuang wrote:
>>>
>>> Hi all,
>>>
>>> I have an issue on tty terminal. I setup PL011 serial console as the
>>> tty terminal on HiKey platform. When it's
On Wed, Feb 07, 2018 at 11:45:54PM +0800, Haojian Zhuang wrote:
> On 7 February 2018 at 01:29, Leif Lindholm wrote:
> > On Mon, Feb 05, 2018 at 04:25:52PM +0800, Haojian Zhuang wrote:
> >> Add skeleton of HiKey960 platform.
> >>
> >> Contributed-under: TianoCore Contribution Agreement 1.1
> >> Sig
On 8 February 2018 at 00:13, Ard Biesheuvel wrote:
> On 7 February 2018 at 16:12, Haojian Zhuang wrote:
>> On 7 February 2018 at 23:52, Ard Biesheuvel
>> wrote:
>>>
On 7 Feb 2018, at 15:50, Haojian Zhuang wrote:
Hi all,
I have an issue on tty terminal. I setup PL011 se
On 7 February 2018 at 16:43, Haojian Zhuang wrote:
> On 8 February 2018 at 00:13, Ard Biesheuvel wrote:
>> On 7 February 2018 at 16:12, Haojian Zhuang
>> wrote:
>>> On 7 February 2018 at 23:52, Ard Biesheuvel
>>> wrote:
> On 7 Feb 2018, at 15:50, Haojian Zhuang wrote:
>
> Hi
As per PI specification v1.6,
As per section 2.1.4.1,
The following file types exist:
Table 3. Defined File Types
Name Value
EFI_FV_FILETYPE_RAW0x01
EFI_FV_FILETYPE_FREEFORM 0x02
EFI_FV_FILETYPE_SECURITY_CORE 0x03
EFI_FV_F
Liming,
Thanks for your feedback.
I have sent v3 of this patch with your feedback, incorporated.
Supreeth
-Original Message-
From: Gao, Liming [mailto:liming@intel.com]
Sent: Tuesday, February 6, 2018 9:43 PM
To: Supreeth Venkatesh ; edk2-devel@lists.01.org
Cc: Kinney, Michael D ; ma
https://bugzilla.tianocore.org/show_bug.cgi?id=873
Update IsNestedFmpCapsule() to verify the CapsuleGuid in
the CapsuleHeader against the installed Firmware Management
Protocol instances. The current logic that uses the ESRT
Table does not work because capsules are processed before
the ESRT Table
From: Michael D Kinney
https://bugzilla.tianocore.org/show_bug.cgi?id=802
Based on content from the following branch/commits:
https://github.com/Microsoft/MS_UEFI/tree/share/MsCapsuleSupport
The EsrtFmpDxe module is a lightweight version of the EsrtDxe
module that produces ESRT entries based on
From: Michael D Kinney
https://bugzilla.tianocore.org/show_bug.cgi?id=802
Based on content from the following branch/commits:
https://github.com/Microsoft/MS_UEFI/tree/share/MsCapsuleSupport
The EsrtFmpDxe module is a lightweight version of the EsrtDxe
module that produces ESRT entries based on
From: Michael D Kinney
https://bugzilla.tianocore.org/show_bug.cgi?id=802
Based on content from the following branch/commits:
https://github.com/Microsoft/MS_UEFI/tree/share/MsCapsuleSupport
The EsrtFmpDxe module is a lightweight version of the EsrtDxe
module that produces ESRT entries based on
V2:
* Add .uni files with module name, abstract, description
* Use EfiCreateEventReadyToBootEx() instead of gBS->CreateEventEx()
* Change module type from UEFI_DRIVER to DXE_DRIVER with depex TRUE
https://bugzilla.tianocore.org/show_bug.cgi?id=802
Branch for review:
https://github.com/mdkinney/ed
"Platform.h" declares the AmdSevInitialize() function without EFIAPI, but
the definition in "AmdSev.c" includes EFIAPI.
GCC toolchains without LTO do not catch this error because "AmdSev.c" does
not include "Platform.h"; i.e. the declaration used by callers such as
"Platform.c" is not actually mat
"Compress.h" declares the Compress() function as EFIAPI, but the
definition in "Compress.c" lacks EFIAPI.
GCC toolchains without LTO do not catch this error because "Compress.c"
does not include "Compress.h"; i.e. the declaration used by callers such
as "EfiCompress.c" is not actually matched agai
Repo: https://github.com/lersek/edk2.git
Branch: sync_defs_to_decls_v2
This is version 2 of the series that I posted earlier. Because that
series didn't reach the list at all, due to SMTP issues on my end, I'm
including the v1 blurb here:
> The patches say it all, just a side remark up here:
>
Coming late to the party because Leif called my attention to this
thread...
On Mon, Jan 29, 2018 at 11:16:21AM +, Leif Lindholm wrote:
> This type of system behaviour has been seen multiple times to break
> installations in the real world.
I can't agree more; that's why there's a pile of lang
https://bugzilla.tianocore.org/show_bug.cgi?id=800
Branch for review:
https://github.com/mdkinney/edk2/commits/Bug_800_BmpSupportLib_V2
Based on content from the following branch/commits:
https://github.com/Microsoft/MS_UEFI/tree/share/MsCapsuleSupport
https://github.com/Microsoft/MS_UEFI/commit/
https://bugzilla.tianocore.org/show_bug.cgi?id=800
Based on content from the following branch/commits:
https://github.com/Microsoft/MS_UEFI/tree/share/MsCapsuleSupport
https://github.com/Microsoft/MS_UEFI/commit/33bab4031a417d7d5a7d356c15a14c2e60302b2d
https://github.com/Microsoft/MS_UEFI/commit/c
From: Michael D Kinney
https://bugzilla.tianocore.org/show_bug.cgi?id=800
Based on content from the following branch/commits:
https://github.com/Microsoft/MS_UEFI/tree/share/MsCapsuleSupport
https://github.com/Microsoft/MS_UEFI/commit/33bab4031a417d7d5a7d356c15a14c2e60302b2d
https://github.com/M
From: Michael D Kinney
https://bugzilla.tianocore.org/show_bug.cgi?id=800
Based on content from the following branch/commits:
https://github.com/Microsoft/MS_UEFI/tree/share/MsCapsuleSupport
https://github.com/Microsoft/MS_UEFI/commit/33bab4031a417d7d5a7d356c15a14c2e60302b2d
https://github.com/M
From: Michael D Kinney
https://bugzilla.tianocore.org/show_bug.cgi?id=800
Based on content from the following branch/commits:
https://github.com/Microsoft/MS_UEFI/tree/share/MsCapsuleSupport
https://github.com/Microsoft/MS_UEFI/commit/33bab4031a417d7d5a7d356c15a14c2e60302b2d
https://github.com/M
From: Michael D Kinney
https://bugzilla.tianocore.org/show_bug.cgi?id=800
Based on content from the following branch/commits:
https://github.com/Microsoft/MS_UEFI/tree/share/MsCapsuleSupport
https://github.com/Microsoft/MS_UEFI/commit/33bab4031a417d7d5a7d356c15a14c2e60302b2d
https://github.com/M
From: Michael D Kinney
https://bugzilla.tianocore.org/show_bug.cgi?id=800
Based on content from the following branch/commits:
https://github.com/Microsoft/MS_UEFI/tree/share/MsCapsuleSupport
https://github.com/Microsoft/MS_UEFI/commit/33bab4031a417d7d5a7d356c15a14c2e60302b2d
https://github.com/M
From: Michael D Kinney
https://bugzilla.tianocore.org/show_bug.cgi?id=800
Based on content from the following branch/commits:
https://github.com/Microsoft/MS_UEFI/tree/share/MsCapsuleSupport
https://github.com/Microsoft/MS_UEFI/commit/33bab4031a417d7d5a7d356c15a14c2e60302b2d
https://github.com/M
From: Michael D Kinney
https://bugzilla.tianocore.org/show_bug.cgi?id=800
Based on content from the following branch/commits:
https://github.com/Microsoft/MS_UEFI/tree/share/MsCapsuleSupport
https://github.com/Microsoft/MS_UEFI/commit/33bab4031a417d7d5a7d356c15a14c2e60302b2d
https://github.com/M
From: Michael D Kinney
https://bugzilla.tianocore.org/show_bug.cgi?id=800
Based on content from the following branch/commits:
https://github.com/Microsoft/MS_UEFI/tree/share/MsCapsuleSupport
https://github.com/Microsoft/MS_UEFI/commit/33bab4031a417d7d5a7d356c15a14c2e60302b2d
https://github.com/M
From: Michael D Kinney
https://bugzilla.tianocore.org/show_bug.cgi?id=800
Based on content from the following branch/commits:
https://github.com/Microsoft/MS_UEFI/tree/share/MsCapsuleSupport
https://github.com/Microsoft/MS_UEFI/commit/33bab4031a417d7d5a7d356c15a14c2e60302b2d
https://github.com/M
Hi Mike,
On 02/07/18 23:58, Kinney, Michael D wrote:
> From: Michael D Kinney
>
> https://bugzilla.tianocore.org/show_bug.cgi?id=800
>
> Based on content from the following branch/commits:
> https://github.com/Microsoft/MS_UEFI/tree/share/MsCapsuleSupport
> https://github.com/Microsoft/MS_UEFI/
On 02/07/18 23:58, Kinney, Michael D wrote:
> From: Michael D Kinney
>
> https://bugzilla.tianocore.org/show_bug.cgi?id=800
>
> Based on content from the following branch/commits:
> https://github.com/Microsoft/MS_UEFI/tree/share/MsCapsuleSupport
> https://github.com/Microsoft/MS_UEFI/commit/33b
Laszlo,
The BmpSupportLib content was from contributions from
a capsule related branch. However, the BmpSupportLib
can be used for UX capsules as well as other places that
conversions between BMP and GOP BLT buffers are needed,
so it is a more generic feature. The SafeIntLib was also
based on
Reviewed-by: jiewen@intel.com
> -Original Message-
> From: Kinney, Michael D
> Sent: Thursday, February 8, 2018 2:50 AM
> To: edk2-devel@lists.01.org
> Cc: Yao, Jiewen ; Zeng, Star ;
> Dong, Eric ; Kinney, Michael D
>
> Subject: [Patch] MdeModulePkg/DxeCapsuleLibFmp: Verify nested cap
On 12/19/17 20:36, Kinney, Michael D wrote:
> From: Sean Brogan
>
> SafeIntLib provides helper functions to prevent integer overflow
> during type conversion, addition, subtraction, and multiplication.
I clearly cannot review such a huge patch, but I've noticed something
and would like to ask fo
On 02/08/18 00:48, Kinney, Michael D wrote:
> Laszlo,
>
> The BmpSupportLib content was from contributions from
> a capsule related branch. However, the BmpSupportLib
> can be used for UX capsules as well as other places that
> conversions between BMP and GOP BLT buffers are needed,
> so it is
On 02/08/18 01:32, Laszlo Ersek wrote:
> On 12/19/17 20:36, Kinney, Michael D wrote:
>> From: Sean Brogan
>>
>> SafeIntLib provides helper functions to prevent integer overflow
>> during type conversion, addition, subtraction, and multiplication.
>
> I clearly cannot review such a huge patch, but
Another minor comments is to remove below sentences in ResetUtilityLib.inf.
> +# The application pops up a menu showing all the boot options
referenced by
> +# BootOrder NV variable and user can choose to boot from one of them.
Thanks,
Star
On 2018/2/7 20:28, Zeng, Star wrote:
On 2018/2/2
V3: Update the build option help info
when MAX_CONCURRENT_THREAD_NUMBER is not specified, tool will
automatically detect number of processor threads.
Fixes: https://bugzilla.tianocore.org/show_bug.cgi?id=775
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Yonghong Zhu
---
Sorry for the trivial comments.
"@param[in] ResetType Base reset type as defined in UEFI spec."
needs to be removed for ResetPlatformSpecificGuid.
There is "in in" in the comments for the implementation of
GetResetPlatformSpecificGuid(). May should be one "in" only?
Thanks,
Star
On 2
V3: Update the build option help info
Add description about enable auto detect thread number when
MAX_CONCURRENT_THREAD_NUMBER is not specified.
Fixes: https://bugzilla.tianocore.org/show_bug.cgi?id=775
Cc: Liming Gao
Cc: Michael Kinney
Cc: Kevin W Shaw
Contributed-under: TianoCore Contributio
Sorry for the trivial comments.
1. A typo "recurstion" should be "recursion" is in ResetSystem.h for
both ResetSystemPei and ResetSystemRuntimeDxe.
2. Should "RUNTIME/runtime/RS" be "PEI" in the comments and code like below?
//
// Indicate reset system runtime service is called.
/
On 2018/2/7 20:40, Zeng, Star wrote:
On 2018/2/2 14:45, Ruiyu Ni wrote:
From: Bret Barkelew
The Reset Notification protocol is added in UEFI spec to support
reset notification mechanism in the DXE phase.
This patch adds similar EDKII specific Reset Notification PPI to PEI
phase to provide the
Reviewed-by: Liming Gao
>-Original Message-
>From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
>Yonghong Zhu
>Sent: Thursday, February 08, 2018 9:50 AM
>To: edk2-devel@lists.01.org
>Subject: [edk2] [Patch] BaseTools: not specified value of
>MAX_CONCURRENT_THREAD_NUMBE
Reviewed-by: Liming Gao
>-Original Message-
>From: Feng, Bob C
>Sent: Wednesday, February 07, 2018 10:02 AM
>To: edk2-devel@lists.01.org
>Cc: Feng, Bob C ; Gao, Liming
>Subject: [Patch] BaseTool: Fixed Pcd issues.
>
>1. Check variable offset when merging Hii Pcds
>2. Fixed the issue of H
Reviewed-by: Liming Gao
>-Original Message-
>From: Feng, Bob C
>Sent: Wednesday, February 07, 2018 12:10 PM
>To: edk2-devel@lists.01.org
>Cc: Feng, Bob C ; Gao, Liming
>Subject: [Patch] BaseTools: Fixed incorrect Structure Pcd Value.
>
>When structurePCD only has overall value assigned
>
Reviewed-by: Liming Gao
>-Original Message-
>From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
>BobCF
>Sent: Tuesday, February 06, 2018 3:21 PM
>To: edk2-devel@lists.01.org
>Cc: Gao, Liming
>Subject: [edk2] [Patch] BaseTools: Fixed Build failed issue.
>
>If the PCD i
On Wed, Feb 07, 2018 at 11:44:34PM +0100, Laszlo Ersek wrote:
> "Compress.h" declares the Compress() function as EFIAPI, but the
> definition in "Compress.c" lacks EFIAPI.
>
> GCC toolchains without LTO do not catch this error because "Compress.c"
> does not include "Compress.h"; i.e. the declarat
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ruiyu Ni
Cc: Jaben Carsey
---
ShellPkg/Library/UefiShellLevel2CommandsLib/Rm.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/ShellPkg/Library/UefiShellLevel2CommandsLib/Rm.c
b/ShellPkg/Library/Ue
HDiskImageSetDiskNameOffsetSize() and HFileImageSetFileName()
may be called using the current disk name or file name.
When this happens, today's implementation firstly frees the memory
and then accesses the just-freed memory.
The patch fixes this issue by doing nothing when the disk or file
name is
Reviewed-by: Star Zeng to MdeModulePkg change with a
minor comment below.
Update the comments in MdeModulePkg/Include/Library/BmpSupportLib.h and
MdeModulePkg.dec?
Provides services to convert a BMP graphics image to a GOP BLT buffer.
->
Provides services to convert a BMP graphics image to a G
Reviewed-by: Star Zeng
Thanks,
Star
-Original Message-
From: Yao, Jiewen
Sent: Thursday, February 8, 2018 8:18 AM
To: Kinney, Michael D ; edk2-devel@lists.01.org
Cc: Zeng, Star ; Dong, Eric
Subject: RE: [Patch] MdeModulePkg/DxeCapsuleLibFmp: Verify nested capsule with
FMP
Reviewed-by:
Reviewed-by: Star Zeng
Thanks,
Star
-Original Message-
From: Kinney, Michael D
Sent: Thursday, February 8, 2018 6:38 AM
To: edk2-devel@lists.01.org
Cc: Kinney, Michael D ; Sean Brogan
; Yao, Jiewen ; Zeng, Star
; Dong, Eric ; Ni, Ruiyu
Subject: [Patch V2 1/3] MdeModulePkg/EsrtFmpDxe:
V2: Just update the commit message.
Add more perf entry to hook BootScriptDonePpi/EndOfPeiPpi/
EndOfS3Resume.
Add the new perf entry with Identifier
PERF_INMODULE_START_ID/PERF_INMODULE_END_ID which are defined
in new performance infrastructure (edk2 trunk commit hash value:
SHA-1: 73fef64f14d1b9
Fix type casting issue when calculating pointers offset
Cc: Wu Hao
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Chao Zhang
---
SecurityPkg/Tcg/Tcg2Smm/Tcg2Smm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/SecurityPkg/Tcg/Tcg2Smm/Tcg2Smm.c
b/Sec
Reviewed-by: Liming Gao
>-Original Message-
>From: Bi, Dandan
>Sent: Thursday, February 08, 2018 2:20 PM
>To: edk2-devel@lists.01.org
>Cc: Dong, Eric ; Laszlo Ersek ;
>Gao, Liming
>Subject: [PATCH v2] UefiCpuPkg/S3Resume: Add more perf entry for S3
>phase
>
>V2: Just update the commit me
Today's McaInitialize() doesn't check State value before initialize
MCi_CTL and MCi_STATUS.
The patch fixes this issue by only initializing the two kinds of
MSRs when State is enabled.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ruiyu Ni
Cc: Eric Dong
---
.../Library/
Reviewed-by: Eric Dong
-Original Message-
From: Ni, Ruiyu
Sent: Thursday, February 8, 2018 2:44 PM
To: edk2-devel@lists.01.org
Cc: Dong, Eric
Subject: [PATCH] UefiCpuPkg/FeaturesLib: don't init MCi_CTL/STATUS when MCA's
disabled
Today's McaInitialize() doesn't check State value before
Remember to update the copyright year when committing the patch.
Thanks/Ray
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ni,
> Ruiyu
> Sent: Wednesday, February 7, 2018 11:30 AM
> To: Zeng, Star ; edk2-devel@lists.01.org
> Cc: Wu, Hao A
>
Reviewed-by: Ruiyu Ni
Thanks/Ray
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Star Zeng
> Sent: Tuesday, February 6, 2018 8:23 PM
> To: edk2-devel@lists.01.org
> Cc: Ni, Ruiyu ; Wu, Hao A ; Yao,
> Jiewen ; Zeng, Star
> Subject: [edk2] [
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Liming Gao
---
BaseTools/Source/C/GenFv/GenFvInternalLib.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/BaseTools/Source/C/GenFv/GenFvInternalLib.c
b/BaseTools/Source/C/GenFv/GenFvInternalLib.c
in
1 - 100 of 102 matches
Mail list logo