Re: [edk2] [PATCH] BaseTools/header.makefile: revert gcc-8 "-Wno-xxx" options on OSX

On 7 March 2018 at 20:28, Laszlo Ersek wrote: > On 03/07/18 12:51, Gao, Liming wrote: >> Reviewed-by: Liming Gao > > Thank you, Liming. > > Ard, are you OK with this patch as well? > Sure Acked-by: Ard Biesheuvel >>>

Re: [edk2] [PATCH] BaseTools/header.makefile: revert gcc-8 "-Wno-xxx" options on OSX

On 03/07/18 12:51, Gao, Liming wrote: > Reviewed-by: Liming Gao Thank you, Liming. Ard, are you OK with this patch as well? Thanks Laszlo >> -Original Message- >> From: Laszlo Ersek [mailto:ler...@redhat.com] >> Sent: Wednesday, March 7, 2018 5:33 PM >> To:

Re: [edk2] [PATCH v2 1/1] SecurityPkg: fix ZeroMem HashInterfaceHob

On 03/07/18 16:35, Zhang, Chao B wrote: > Star: >Why do we need to add HashInterfaceHob->SupportedHashMask = 0? > HashInterfaceHob is internally maintained and accessed by HashLibRouterPei. > There is no impact to leave the value after module has been re-shadowed. There seems to be no

[edk2] RFC: Proposal to halt automatic builds of Windows BaseTools executables

I would like to propose that the automatic builds of Windows BaseTools executables be halted. This implies there will no longer be updates to the edk2-BaseTools-win32 repository. With this change, developers using Windows must install Python 2.7.x and configure their environment to build C

Re: [edk2] [PATCH 0/4] Virtio non-discoverable devices

On 03/07/18 09:03, Ard Biesheuvel wrote: > (+ Laszlo) > > Hello Daniil, > > On 7 March 2018 at 01:36, Daniil Egranov wrote: >> This is an attempt to add MMIO Virtio devices into the >> non-discoverable device registration procedure and allow >> Virtio PCI drivers to

Re: [edk2] [PATCH 0/3] BaseTools: let the C-language build utils compile with gcc-8

On 03/07/18 10:12, Ard Biesheuvel wrote: > On 7 March 2018 at 09:11, Laszlo Ersek wrote: >> On 03/07/18 07:43, Gao, Liming wrote: >>> Laszlo: >>> We just find this change causes XCODE5 build failure, because XCODE >>> compiler doesn't know these two options. So, could you

Re: [edk2] [PATCH 1/1] RFC: SecurityPkg: only clear HashInterface informations

On 03/07/18 10:42, Zeng, Star wrote: > Hi Laszlo, > > Good analysis. > > Yes, the SupportedHashMask field in HashInterfaceHob will have stale value, > but that does not impact the functionality since the code have. > So the patch could fix the problem. > >

[edk2] [Patch v2] EmbeddedPkg: Correct the way of handling sections with a large size

Correct the way of handling EFI_SECTION_GUID_DEFINED type sections with a large size Cc: Leif Lindholm Cc: Ard Biesheuvel Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ge Song Reviewed-by:

Re: [edk2] [PATCH v2 1/8] SecurityPkg: also clear HashInterfaceHob.SupportedHashMask

Reviewed-by: Chao Zhang -Original Message- From: marcandre.lur...@redhat.com [mailto:marcandre.lur...@redhat.com] Sent: Wednesday, March 7, 2018 11:58 PM To: edk2-devel@lists.01.org Cc: pjo...@redhat.com; Yao, Jiewen ;

Re: [edk2] [PATCH v2 2/8] SecurityPkg/Tcg2Pei: drop PeiReadOnlyVariable from Depex

Hi Lureau: I think we can remove same dependency in TcgPei. -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of marcandre.lur...@redhat.com Sent: Wednesday, March 7, 2018 11:58 PM To: edk2-devel@lists.01.org Cc: qemu-de...@nongnu.org;

Re: [edk2] [PATCH v2 1/8] SecurityPkg: also clear HashInterfaceHob.SupportedHashMask

Reviewed-by: Star Zeng Thanks, Star -Original Message- From: Zhang, Chao B Sent: Thursday, March 8, 2018 8:35 AM To: marcandre.lur...@redhat.com; edk2-devel@lists.01.org Cc: pjo...@redhat.com; Yao, Jiewen ; stef...@linux.vnet.ibm.com;

[edk2] HELP: Qemu not able to load Duet image

Hi, I am having difficulty loading Duet image via Qemu x86-64 or Bochs in Windows 10-64. Command line I type ‘Qemu -fda floppy.img’ and does not get past ‘Welcome to Efi World’ but if I burn the image to a flash usb drive it will boot up just fine. Are there any settings or drivers that need

Re: [edk2] RFC: Proposal to halt automatic builds of Windows BaseTools executables

Hi, all Here is wiki https://github.com/tianocore/tianocore.github.io/wiki/Windows-systems#compile-tools on Compile BaseTools in windows. Thanks Liming > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Bjorge, Erik C > Sent: Thursday,

Re: [edk2] [PATCH 1/3] Hisilicon/D0x: Set ACPI GTDT always-on flag

Yes it is. Sorry for missing to do that. Will keep in mind next time :) Thanks, Heyi On Wed, Mar 07, 2018 at 10:36:48AM +0100, Laszlo Ersek wrote: > Hello Heyi, > > On 03/07/18 07:55, Heyi Guo wrote: > > From: Jason Zhang > > > > Timer is always working on Hisilicon

Re: [edk2] [PATCH] BaseTools/header.makefile: revert gcc-8 "-Wno-xxx" options on OSX

On 03/07/18 21:42, Ard Biesheuvel wrote: > On 7 March 2018 at 20:28, Laszlo Ersek wrote: >> On 03/07/18 12:51, Gao, Liming wrote: >>> Reviewed-by: Liming Gao >> >> Thank you, Liming. >> >> Ard, are you OK with this patch as well? >> > > Sure > >

[edk2] [PATCH v1 1/1] BaseTools: GlobalData remove unused variable

gWideStringPattern is not used. Cc: Yonghong Zhu Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jaben Carsey --- BaseTools/Source/Python/Common/GlobalData.py | 3 +-- 1 file changed, 1

[edk2] [PATCH v1 0/1] BaseTools: remove unused variable

delete a variable never uised and the comment Cc: Yonghong Zhu Cc: Liming Gao Jaben Carsey (1): BaseTools: GlobalData remove unused variable BaseTools/Source/Python/Common/GlobalData.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)

[edk2] [Patch] BaseTools: Update --pcd parser to support flexible pcd format

This patch update --pcd parser to support flexible pcd format. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Yonghong Zhu --- BaseTools/Source/Python/Common/Expression.py | 21 +- BaseTools/Source/Python/Common/Misc.py | 41

[edk2] [Patch] BaseTools: Fixed Pcd from command line issue.

Save the pcd command line value in Pcd object Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Bob Feng Cc: Liming Gao --- BaseTools/Source/Python/AutoGen/GenC.py| 15 +++

Re: [edk2] [PATCH 1/1] MdeModulePkg/UefiBootManagerLib: limit recursive call depth

On 3/7/2018 9:54 AM, Guo Heyi wrote: Hi Ray, Sorry to disturb, but I didn't find the patch committed. Could you help to do that? Thanks, Heyi On Thu, Mar 01, 2018 at 12:46:32PM +0800, Ni, Ruiyu wrote: On 3/1/2018 10:39 AM, Heyi Guo wrote: Function BmRepairAllControllers may recursively

Re: [edk2] [Patch] BaseTools: Fix a bug for --pcd used in ConditionalStatement calculate

Reviewed-by: Liming Gao > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Yonghong Zhu > Sent: Wednesday, March 7, 2018 4:34 PM > To: edk2-devel@lists.01.org > Subject: [edk2] [Patch] BaseTools: Fix a bug for --pcd used

[edk2] [Patch] BaseTools: Fixed Pcd from command line issue.

Save the pcd command line value in Pcd object Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Bob Feng Cc: Liming Gao --- BaseTools/Source/Python/AutoGen/GenC.py| 15 +++

Re: [edk2] [PATCH 0/4] Virtio non-discoverable devices

Hi Daniil, On 03/07/18 02:36, Daniil Egranov wrote: > This is an attempt to add MMIO Virtio devices into the > non-discoverable device registration procedure and allow > Virtio PCI drivers to recognize and program such devices > correctly. > The main issue is that the set of MMIO registers is

Re: [edk2] [PATCH 0/4] Virtio non-discoverable devices

(+ Laszlo) Hello Daniil, On 7 March 2018 at 01:36, Daniil Egranov wrote: > This is an attempt to add MMIO Virtio devices into the > non-discoverable device registration procedure and allow > Virtio PCI drivers to recognize and program such devices > correctly. Why? The

Re: [edk2] [PATCH 1/1] RFC: SecurityPkg: only clear HashInterface informations

Hi Laszlo, Good analysis. Yes, the SupportedHashMask field in HashInterfaceHob will have stale value, but that does not impact the functionality since the code have. So the patch could fix the problem. HashLibBaseCryptoRouterPeiConstructor(): Status = PcdSet32S (PcdTcg2HashAlgorithmBitmap,

[edk2] [PATCH] BaseTools/header.makefile: revert gcc-8 "-Wno-xxx" options on OSX

I recently added the gcc-8 specific "-Wno-stringop-truncation" and "-Wno-restrict" options to BUILD_CFLAGS, both for "Darwin" (XCODE5 / clang, OSX) and otherwise (gcc, Linux / Cygwin). I also regression-tested the change with gcc-4.8 on Linux -- gcc-4.8 does not know either of the (gcc-8

Re: [edk2] [PATCH 1/1] RFC: SecurityPkg: only clear HashInterface informations

Hi On Wed, Mar 7, 2018 at 10:06 AM, Laszlo Ersek wrote: > Hi Marc-André, > > On 03/06/18 21:27, marcandre.lur...@redhat.com wrote: >> From: Marc-André Lureau >> >> The ZeroMem() call goes beyond the HashInterfaceHob structure, causing >> HOB list

[edk2] [Patch] MdeModulePkg PCD: Remove unused PCD attribute PCD_TYPE_SKU_ENABLED

PcdDb optimization has handled PCD DB for each SKU, not for single PCD. So, this PCD attribute is not used any more. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Liming Gao Cc: Reviewed-by: Liming Gao ---

Re: [edk2] [PATCH 0/3] BaseTools: let the C-language build utils compile with gcc-8

On 7 March 2018 at 09:11, Laszlo Ersek wrote: > On 03/07/18 07:43, Gao, Liming wrote: >> Laszlo: >> We just find this change causes XCODE5 build failure, because XCODE >> compiler doesn't know these two options. So, could you provide the patch to >> remove the change in

Re: [edk2] [PATCH 1/3] Hisilicon/D0x: Set ACPI GTDT always-on flag

Hello Heyi, On 03/07/18 07:55, Heyi Guo wrote: > From: Jason Zhang > > Timer is always working on Hisilicon D0x, even system enters WFI/WFE, > and there is no other low power status, so we set "always-on" flag in > ACPI GTDT. > > Contributed-under: TianoCore

Re: [edk2] [Patch V2] Build spec: update PCD value and SKU, DefaultStore info in report

Reviewed-by: Liming Gao >-Original Message- >From: Zhu, Yonghong >Sent: Friday, February 23, 2018 1:21 PM >To: edk2-devel@lists.01.org >Cc: Gao, Liming ; Kinney, Michael D >; Shaw, Kevin W

Re: [edk2] [PATCH 0/3] BaseTools: let the C-language build utils compile with gcc-8

On 03/07/18 07:43, Gao, Liming wrote: > Laszlo: > We just find this change causes XCODE5 build failure, because XCODE > compiler doesn't know these two options. So, could you provide the patch to > remove the change in BUILD_CFLAGS for MAC? Yep, I was a bit concerned about that. Ultimately I

[edk2] [PATCH V2 0/7] OpalPassword: New solution without SMM device code

The patch series is also at https://github.com/lzeng14/edk2 OpalPasswordNewV2 branch. After IOMMU is enabled in S3, original solution with SMM device code (OpalPasswordSmm) to unlock OPAL device for S3 will not work as the DMA operation will be aborted without granted DMA buffer. Instead, this

[edk2] [PATCH V2 1/7] MdeModulePkg LockBoxLib: Support LOCK_BOX_ATTRIBUTE_RESTORE_IN_S3_ONLY

With this flag, the LockBox can be restored in S3 resume only. The LockBox can not be restored after SmmReadyToLock in normal boot and after EndOfS3Resume in S3 resume. It can not be set together with LOCK_BOX_ATTRIBUTE_RESTORE_IN_PLACE. Cc: Jiewen Yao Contributed-under:

[edk2] [PATCH V2 6/7] SecurityPkg OpalPasswordSupportLib: Remove it

Remove OpalPasswordSupportLib as it is not been used anymore. Cc: Jiewen Yao Cc: Eric Dong Cc: Chao Zhang Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Star Zeng Reviewed-by:

[edk2] [PATCH V2 2/7] SecurityPkg TcgStorageOpalLib: Make it be base type really

Cc: Jiewen Yao Cc: Eric Dong Cc: Chao Zhang Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Star Zeng Reviewed-by: Jiewen Yao ---

[edk2] [PATCH V2 3/7] SecurityPkg TcgStorageCoreLib: Make it be base type really

Cc: Jiewen Yao Cc: Eric Dong Cc: Chao Zhang Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Star Zeng Reviewed-by: Jiewen Yao ---

[edk2] [PATCH V2 7/7] SecurityPkg OpalPasswordExtraInfoVariable.h: Remove it

Remove OpalPasswordExtraInfoVariable.h as it is not been used anymore. Cc: Jiewen Yao Cc: Eric Dong Cc: Chao Zhang Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Star Zeng

[edk2] [PATCH v2 1/1] SecurityPkg: fix ZeroMem HashInterfaceHob

From: Marc-André Lureau The ZeroMem() call goes beyond the HashInterfaceHob structure, causing HOB list corruption. The intent was to clear all but the Identifier, that is starting from HashInterfaceCount. Quoting Laszlo Ersek: Therefore I think the *first*

Re: [edk2] [PATCH v2 1/1] SecurityPkg: fix ZeroMem HashInterfaceHob

Hi On Wed, Mar 7, 2018 at 12:24 PM, wrote: > From: Marc-André Lureau > > The ZeroMem() call goes beyond the HashInterfaceHob structure, causing > HOB list corruption. The intent was to clear all but the Identifier, > that is starting

Re: [edk2] [PATCH 1/1] RFC: SecurityPkg: only clear HashInterface informations

My head was stuck to say using " ZeroMem (HashInterfaceHob, sizeof (*HashInterfaceHob) - sizeof (EFI_GUID)) ", that is wrong. :( Thanks, Star -Original Message- From: Zeng, Star Sent: Wednesday, March 7, 2018 5:42 PM To: Laszlo Ersek ; marcandre.lur...@redhat.com Cc:

Re: [edk2] [PATCH v2 1/1] SecurityPkg: fix ZeroMem HashInterfaceHob

Yes, since the V1 has been pushed. Just adding one line like below based on V1 should be ok. HashInterfaceHob->SupportedHashMask = 0; Thanks, Star -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Marc-André Lureau Sent: Wednesday, March 7, 2018

Re: [edk2] [PATCH 1/1] RFC: SecurityPkg: only clear HashInterface informations

Hi Marc-André, On 03/06/18 21:27, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > The ZeroMem() call goes beyond the HashInterfaceHob structure, causing > HOB list corruption. Instead, just clear the HashInterface fields, as > I suppose was

Re: [edk2] [PATCH v1] Platform/ARM/VExpressPkg: Fix RSDT pointer in RSDP

On 6 March 2018 at 14:15, Sami Mujawar wrote: > According to the SBBR Specification (ARM DEN 0044B), Section 4.2.1.1 > "Within the RSDP, the RsdtAddress field must be null (zero) >and the XsdtAddresss MUST be a valid, non-null, 64-bit value." > > The

[edk2] [PATCH v2 5/8] ovmf: add OvmfPkg Tcg2ConfigPei module

From: Marc-André Lureau The Tcg2ConfigPei module informs the firmware globally about the TPM device type, by setting the PcdTpmInstanceGuid PCD to the appropriate GUID value. The original module under SecurityPkg can perform device detection, or read a cached value

[edk2] [PATCH v2 6/8] ovmf: link with Tcg2Pei module

From: Marc-André Lureau This module will initialize TPM device, measure reported FVs and BIOS version. We keep both SHA-1 and SHA-256 for the TCG 1.2 log format compatibility, but the SHA-256 measurements and TCG 2 log format are now recommended. Cc: Laszlo Ersek

[edk2] [PATCH v2 0/8] RFC: ovmf: preliminary TPM2 support

From: Marc-André Lureau Hi, The following series adds basic TPM2 support for OVMF-on-QEMU (I haven't tested TPM1, for lack of interest). It links with the modules to initializes the device in PEI phase, and do measurements (both PEI and DXE). The Tcg2Dxe module

[edk2] [PATCH v2 3/8] MdeModulePkg: fix REGISITER -> REGISTER

From: Marc-André Lureau Cc: Laszlo Ersek Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Marc-André Lureau --- MdeModulePkg/Core/Pei/Dispatcher/Dispatcher.c | 18 +-

[edk2] [PATCH v2 7/8] ovmf: link with Tcg2Dxe module

From: Marc-André Lureau This module measures and log the boot environment. It also produces the Tcg2 protocol, which allows for example to read the log from OS. The linux kernel doesn't yet read the EFI_TCG2_EVENT_LOG_FORMAT_TCG_2, which is required for crypto-agile

[edk2] [PATCH v2 8/8] ovmf: add DxeTpm2MeasureBootLib

From: Marc-André Lureau The library registers a security management handler, to measure images that are not measure in PEI phase. This seems to work for example with the qemu PXE rom: Loading driver at 0x0003E6C2000 EntryPoint=0x0003E6C9076 8086100e.efi And the

Re: [edk2] [PATCH 2/2] Hisilicon/D0x: Enable tftp command by default

On 7 March 2018 at 03:03, Heyi Guo wrote: > Since D0x platforms always have network enabled, we would like to > enable tftp command by default so that we can download something in > EFI Shell. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Heyi

Re: [edk2] [PATCH 3/3] Hisilicon/D05: Support SBSA watchdog

On 7 March 2018 at 06:55, Heyi Guo wrote: > From: Chenhui Sun > > Add description of SBSA watchdogs to ACPI GTDT on D05. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Chenhui Sun > Signed-off-by:

Re: [edk2] [PATCH v2 2/8] SecurityPkg/Tcg2Pei: drop PeiReadOnlyVariable from Depex

Reviewed-by: jiewen@intel.com > -Original Message- > From: marcandre.lur...@redhat.com [mailto:marcandre.lur...@redhat.com] > Sent: Wednesday, March 7, 2018 11:58 PM > To: edk2-devel@lists.01.org > Cc: pjo...@redhat.com; Yao, Jiewen ; >

Re: [edk2] [PATCH 3/3] Hisilicon/D05: Support SBSA watchdog

On 7 March 2018 at 16:10, Ard Biesheuvel wrote: > On 7 March 2018 at 06:55, Heyi Guo wrote: >> From: Chenhui Sun >> >> Add description of SBSA watchdogs to ACPI GTDT on D05. >> >> Contributed-under: TianoCore Contribution