[edk2] [PATCH edk2-platforms v4 2/2] Platform/HiKey: create 4 boot options

Create 4 predefined boot options for HiKey. They're "Boot from SD", "Grub", "Android Boot" and "Android Fastboot". Cc: Laszlo Ersek Cc: Leif Lindholm Cc: Ard Biesheuvel Contributed-under: TianoCore Contribution Agreement

[edk2] [PATCH] UefiCpuPkg MpInitLib: Fix typo "sCPUID" to "CPUID"

Cc: Eric Dong Cc: Ruiyu Ni Cc: Jiewen Yao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Star Zeng --- UefiCpuPkg/Library/MpInitLib/Microcode.c | 4 ++-- 1 file changed, 2

[edk2] [PATCH v4 1/2] EmbeddedPkg: add platform boot manager protocol

Create the PlatformBootManagerProtocol that is used to add predefined boot options in platform driver. This interface will be used in ArmPkg/PlatformBootManagerLib. Cc: Laszlo Ersek Cc: Leif Lindholm Cc: Ard Biesheuvel

[edk2] [PATCH edk2-platforms v4 1/2] Platform/HiKey960: register predefined boot options

Create 4 boot options on HiKey960 platform. They're "Boot from SD", "Grub", "Android Boot" and "Android Fastboot". Cc: Laszlo Ersek Cc: Leif Lindholm Cc: Ard Biesheuvel Contributed-under: TianoCore Contribution Agreement

[edk2] [PATCH v4 0/2] add platform boot manager protocol

Changelog: v4: * Add BootCount parameter in the interface. * Clean the logic on boot options according to Laszlo's comment. v3: * Update the name of interface. * Move the initialization into platform driver. * Fix comment style. * Fix minor issues with comments. v2: * Avoid to use

[edk2] [PATCH v4 2/2] ArmPkg/PlatformBootManagerLib: load platform boot options

Make platform driver to create predefined boot options and related hot keys. Cc: Laszlo Ersek Cc: Leif Lindholm Cc: Ard Biesheuvel Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Haojian Zhuang

[edk2] [PATCH edk2-platforms v4 0/2] add platform boot options

Changelog: v4: * Add BootCount parameter in the interface. v3: * Move in initilization of boot entry. * Update the name of interface in platform boot manager protocol. v2: * Update with platform boot manager protocol. Haojian Zhuang (2): Platform/HiKey960: register predefined boot

[edk2] [PATCH 2/3] IntelSiliconPkg MicrocodeUpdate: Fix typo EFI_SECURITY_VIOLATIO

Fix typo EFI_SECURITY_VIOLATIO to EFI_SECURITY_VIOLATION. Cc: Jiewen Yao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Star Zeng --- .../Feature/Capsule/MicrocodeUpdateDxe/MicrocodeFmp.c | 10 +-

[edk2] [PATCH 0/3] FirmwareManagement: Fix typo EFI_SECURITY_VIOLATIO

Fix typo EFI_SECURITY_VIOLATIO to EFI_SECURITY_VIOLATION. Cc: Jiewen Yao Cc: Michael D Kinney Cc: Liming Gao Star Zeng (3): MdePkg FirmwareManagement.h: Fix typo EFI_SECURITY_VIOLATIO IntelSiliconPkg MicrocodeUpdate:

[edk2] [PATCH 1/3] MdePkg FirmwareManagement.h: Fix typo EFI_SECURITY_VIOLATIO

Fix typo EFI_SECURITY_VIOLATIO to EFI_SECURITY_VIOLATION. Cc: Jiewen Yao Cc: Michael D Kinney Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Star Zeng ---

[edk2] [PATCH 3/3] SignedCapsulePkg SystemFirmwareUpdate: Fix typo EFI_SECURITY_VIOLATIO

Fix typo EFI_SECURITY_VIOLATIO to EFI_SECURITY_VIOLATION. Cc: Jiewen Yao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Star Zeng --- .../Universal/SystemFirmwareUpdate/SystemFirmwareCommonDxe.c | 8

[edk2] [PATCH] MdeModulePkg EsrtFmpDxe: Use EfiBootServicesData for ESRT table

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=933 We see UEFI spec is saying to use EfiBootServicesData for ESRT table. UEFI 2.7 chapter 23.3: The ESRT shall be stored in memory of type EfiBootServicesData. And we see EsrtDxe is using AllocatePool for ESRT table, but EsrtFmpDxe is using

Re: [edk2] [PATCH] UefiCpuPkg MpInitLib: Fix typo "sCPUID" to "CPUID"

Reviewed-by: Eric Dong -Original Message- From: Zeng, Star Sent: Monday, April 23, 2018 3:04 PM To: edk2-devel@lists.01.org Cc: Zeng, Star ; Dong, Eric ; Ni, Ruiyu ; Yao, Jiewen

Re: [edk2] [PATCH] IntelSiliconPkg MicrocodeUpdateDxe: Honor FIT table

Yonghong helped run regression test for the cases without FIT table. I created below cases with FIT table, checked the boot log and confirmed the signature is correct after microcode update. 1. Update in situ. 2. Empty FIT microcode entry with enough space. 3. Unused FIT microcode entry with

Re: [edk2] [PATCH] IntelSiliconPkg MicrocodeUpdateDxe: Honor FIT table

I also built VS2015/GCC49 (tool chain in my local), and checked ecc result. Thanks, Star -Original Message- From: Zeng, Star Sent: Monday, April 23, 2018 4:55 PM To: Yao, Jiewen ; edk2-devel@lists.01.org Cc: Zhu, Yonghong ; Zeng, Star

Re: [edk2] [PATCH edk2-platforms v1 0/2] Add two patch fot D03

For series: Reviewed-by: Leif Lindholm Pushed as a30a05ba45..0b5af57f00. On Thu, Feb 22, 2018 at 05:26:58PM +0800, Ming Huang wrote: > These two patchs are missed for 18.02. They are recommended for 18.02. > > > Ming Huang (2): > Hilisicon/D03: Change DmaLib for

[edk2] [PATCH] MdeModulePkg NvmExpressDxe: return error code in error path

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=937 In NvmeExpressPassthru.c near line 659: Prp = NvmeCreatePrpList ( PciIo, PhyAddr, EFI_SIZE_TO_PAGES(Offset + Bytes) - 1, , , ); if (Prp == NULL) {

Re: [edk2] [PATCH edk2-platforms 05/39] Silicon/NXP: Add support for I2c driver

On Mon, Apr 23, 2018 at 08:21:22AM +, Meenakshi Aggarwal wrote: > > > +/** > > > + Function to read data using i2c bus > > > + > > > + @param I2cBus I2c Controller number > > > + @param ChipAddress of slave device from where data to be > > > read > > > + @param

Re: [edk2] [PATCH 0/3] FirmwareManagement: Fix typo EFI_SECURITY_VIOLATIO

Reviewed-by: jiewen@intel.com > -Original Message- > From: Zeng, Star > Sent: Monday, April 23, 2018 3:01 PM > To: edk2-devel@lists.01.org > Cc: Zeng, Star ; Yao, Jiewen ; > Kinney, Michael D ; Gao, Liming >

Re: [edk2] [PATCH edk2-platforms 05/39] Silicon/NXP: Add support for I2c driver

> -Original Message- > From: Leif Lindholm [mailto:leif.lindh...@linaro.org] > Sent: Tuesday, April 17, 2018 10:07 PM > To: Meenakshi Aggarwal > Cc: ard.biesheu...@linaro.org; edk2-devel@lists.01.org; Udit Kumar > ; Varun Sethi

Re: [edk2] [PATCH] MdeModulePkg EsrtFmpDxe: Use EfiBootServicesData for ESRT table

Reviewed-by: jiewen@intel.com > -Original Message- > From: Zeng, Star > Sent: Monday, April 23, 2018 3:06 PM > To: edk2-devel@lists.01.org > Cc: Zeng, Star ; Yao, Jiewen ; > Kinney, Michael D ; Sean Brogan >

Re: [edk2] [PATCH] IntelSiliconPkg MicrocodeUpdateDxe: Honor FIT table

Thanks for the update. Would you please share what unit test has been done for this patch? Thank you Yao Jiewen > -Original Message- > From: Zeng, Star > Sent: Monday, April 23, 2018 2:57 PM > To: edk2-devel@lists.01.org > Cc: Zeng, Star ; Yao, Jiewen

[edk2] [PATCH] IntelSiliconPkg MicrocodeUpdateDxe: Honor FIT table

It is the second step for https://bugzilla.tianocore.org/show_bug.cgi?id=540. Cc: Jiewen Yao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Star Zeng --- .../Capsule/MicrocodeUpdateDxe/MicrocodeFmp.c | 184 ++-

Re: [edk2] [PATCH v2] ArmPkg/TimerDxe: remove workaround for KVM timer handling

On 19/04/18 15:34, Ard Biesheuvel wrote: On 19 April 2018 at 16:23, Julien Grall wrote: Hi Ard, Sorry for the late reply. On 19/04/18 09:16, Ard Biesheuvel wrote: On 17 April 2018 at 08:03, Ard Biesheuvel wrote: When we first ported

Re: [edk2] [PATCH v3 14/16] ArmPlatformPkg: New DP500/DP550/DP650 GOP driver

On Tue, Mar 20, 2018 at 04:12:10PM +, Girish Pathak wrote: > From: Girish Pathak > > This change adds support for the ARM Mali DP500/DP500/DP650 display > processors using the GOP protocol. It has been tested on FVP base > models + DP550 support. This change adds platform independant

Re: [edk2] [PATCH edk2-platforms v4 00/17] Update GOP

For the series: Reviewed-by: Leif Lindholm Not pushed yet due to dependencies on the corresponding edk2 set. Evan: since you already have Signed-off-by on all of the patches, I don't intend to add your Reviewed-by as well (I did see them). On Thu, Apr 05, 2018 at

Re: [edk2] [PATCH edk2-platforms 05/39] Silicon/NXP: Add support for I2c driver

On 23 April 2018 at 12:34, Meenakshi Aggarwal wrote: > Hi Leif > >> -Original Message- >> From: Leif Lindholm [mailto:leif.lindh...@linaro.org] >> Sent: Monday, April 23, 2018 2:08 PM >> To: Meenakshi Aggarwal >> Cc:

Re: [edk2] [PATCH 4/4] ArmPlatformPkg: add PL011 UART runtime debug driver

On 20 April 2018 at 16:14, Alexei Fedorov wrote: > Leif, Ard > > > When do you plan to push this patch? > I don't. There was some pushback from the Intel guys regarding the use of status codes instead of a runtime debug protocol, and nobody came forward to say that they

Re: [edk2] [PATCH v3 16/16] ArmPkg: Introduce SCMI protocol

Hmm, I did find a few minor things below that I need to hear back on before pushing. On Tue, Mar 20, 2018 at 04:12:12PM +, Girish Pathak wrote: > This change introduces a new SCMI protocol driver for > Arm systems. The driver currently supports only clock > and performance management

Re: [edk2] [PATCH edk2-platforms 05/39] Silicon/NXP: Add support for I2c driver

Hi Leif > -Original Message- > From: Leif Lindholm [mailto:leif.lindh...@linaro.org] > Sent: Monday, April 23, 2018 2:08 PM > To: Meenakshi Aggarwal > Cc: ard.biesheu...@linaro.org; edk2-devel@lists.01.org; Udit Kumar > ; Varun Sethi

Re: [edk2] [PATCH] MdeModulePkg NvmExpressDxe: return error code in error path

Reviewed-by: Hao Wu Best Regards, Hao Wu > -Original Message- > From: Zeng, Star > Sent: Monday, April 23, 2018 4:18 PM > To: edk2-devel@lists.01.org > Cc: Zeng, Star; Wu, Hao A; Ni, Ruiyu; Michael Turner > Subject: [PATCH] MdeModulePkg NvmExpressDxe: return error

Re: [edk2] [PATCH v3 15/16] ArmPkg: MTL Library interface and Null library implementation

On Tue, Mar 20, 2018 at 04:12:11PM +, Girish Pathak wrote: > Upcoming new component ArmPkg/Drivers/ArmScmiDxe is dependent on > platform specific ArmMtlLib library implementation, however in order > to be able to build the ArmScmiDxe component outside of the context of a > particular platform,

[edk2] [PATCH 1/2] ArmPkg: add reenable hook to ArmGenericTimerCounterLib

In preparation of selectively reinstating the timer enable quirk for Xen that we removed in commit 411a373ed642 ("ArmPkg/TimerDxe: remove workaround for KVM timer handling"), add a ArmGenericTimerReenableTimer() library function to ArmGenericTimerCounterLib that we will populate for Xen only.

[edk2] [PATCH 0/2] Reenable timer mask quirk for Xen

Reinstate the timer mask quirk for Xen that we recently removed under the assumption that only ancient KVM host implementations still needed it. Ard Biesheuvel (2): ArmPkg: add reenable hook to ArmGenericTimerCounterLib ArmVirtPkg: reinstate timer unmask quirk for Xen

[edk2] [PATCH 2/2] ArmVirtPkg: reinstate timer unmask quirk for Xen

Commit 411a373ed642 ("ArmPkg/TimerDxe: remove workaround for KVM timer handling") removed the virtual timer handling quirk that cleared the mask bit in the control register when enabling the timer, under the assumption that only ancient KVM host implementations required it. However, Julien reports

Re: [edk2] [PATCH v3 16/16] ArmPkg: Introduce SCMI protocol

On Mon, Apr 23, 2018 at 04:06:43PM +, Girish Pathak wrote: > > From: Leif Lindholm > > Sent: 23 April 2018 12:32 > > To: Girish Pathak > > Cc: edk2-devel@lists.01.org; ard.biesheu...@linaro.org; Matteo Carlini > > ;

Re: [edk2] [PATCH edk2-platforms 05/39] Silicon/NXP: Add support for I2c driver

Hi Ard > -Original Message- > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > Sent: Monday, April 23, 2018 7:10 PM > To: Meenakshi Aggarwal > Cc: Leif Lindholm ; edk2-devel@lists.01.org; Udit > Kumar ;

Re: [edk2] [PATCH edk2-platforms 05/39] Silicon/NXP: Add support for I2c driver

On 23 April 2018 at 17:50, Meenakshi Aggarwal wrote: > Hi Ard > >> -Original Message- >> From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] >> Sent: Monday, April 23, 2018 7:10 PM >> To: Meenakshi Aggarwal >> Cc: Leif Lindholm

Re: [edk2] [PATCH v3 16/16] ArmPkg: Introduce SCMI protocol

Hi Leif, > -Original Message- > From: Leif Lindholm > Sent: 23 April 2018 12:32 > To: Girish Pathak > Cc: edk2-devel@lists.01.org; ard.biesheu...@linaro.org; Matteo Carlini > ; Stephanie Hughes-Fitt f...@arm.com>;

Re: [edk2] [PATCH v3 16/16] ArmPkg: Introduce SCMI protocol

Hi Leif, > -Original Message- > From: Leif Lindholm > Sent: 23 April 2018 17:22 > To: Girish Pathak > Cc: edk2-devel@lists.01.org; ard.biesheu...@linaro.org; Matteo Carlini > ; Stephanie Hughes-Fitt f...@arm.com>;

Re: [edk2] [PATCH 0/2] Reenable timer mask quirk for Xen

On Mon, Apr 23, 2018 at 05:00:55PM +0200, Ard Biesheuvel wrote: > Reinstate the timer mask quirk for Xen that we recently removed under the > assumption that only ancient KVM host implementations still needed it. >From my point of view, for the series: Reviewed-by: Leif Lindholm

Re: [edk2] [PATCH edk2-platforms v4 04/17] ARM/VExpressPkg: Remove unused PcdPL111LcdMaxMode from HDLCD inf

On Mon, Apr 23, 2018 at 05:07:02PM +, Girish Pathak wrote: > Hi Leif, > > > -Original Message- > > From: Leif Lindholm > > Sent: 23 April 2018 18:03 > > To: Girish Pathak > > Cc: edk2-devel@lists.01.org; ard.biesheu...@linaro.org;

Re: [edk2] [PATCH edk2-platforms v4 04/17] ARM/VExpressPkg: Remove unused PcdPL111LcdMaxMode from HDLCD inf

On Thu, Apr 05, 2018 at 07:07:50PM +0100, Girish Pathak wrote: > PCD PcdPL111LcdMaxMode is not used in HDLCD platform library. > Presence of this PCD in HDLCD is probably due to copy/paste code > from PL111 Lcd platform library. This change removes it from > the HdLcdArmVExpressLib.inf file. > >

Re: [edk2] [PATCH edk2-platforms v4 04/17] ARM/VExpressPkg: Remove unused PcdPL111LcdMaxMode from HDLCD inf

Hi Leif, > -Original Message- > From: Leif Lindholm > Sent: 23 April 2018 18:03 > To: Girish Pathak > Cc: edk2-devel@lists.01.org; ard.biesheu...@linaro.org; Matteo Carlini > ; Stephanie Hughes-Fitt f...@arm.com>;

Re: [edk2] [PATCH v3 00/16] Update GOP

On Tue, Mar 20, 2018 at 04:11:56PM +, Girish Pathak wrote: > This patch series addresses comments on the patch v2 > (https://lists.01.org/pipermail/edk2-devel/2017-December/019389.html) > reworking of the Graphics Output Protocol code in ArmPlatformPkg. > It also contains updates for the new

Re: [edk2] [PATCH edk2-platforms v4 1/2] Platform/HiKey960: register predefined boot options

Hello Haojian, On 04/23/18 08:22, Haojian Zhuang wrote: > Create 4 boot options on HiKey960 platform. They're "Boot from SD", > "Grub", "Android Boot" and "Android Fastboot". > > Cc: Laszlo Ersek > Cc: Leif Lindholm > Cc: Ard Biesheuvel

Re: [edk2] [PATCH v4 0/2] add platform boot manager protocol

On 04/23/18 08:21, Haojian Zhuang wrote: > Changelog: > v4: > * Add BootCount parameter in the interface. > * Clean the logic on boot options according to Laszlo's comment. > v3: > * Update the name of interface. > * Move the initialization into platform driver. > * Fix comment style. >

Re: [edk2] [PATCH] Maintainers.txt: add Laszlo Ersek to stewards

Welcome Indeed. Reviewed-by: Andrew J. Fish Thanks, Andrew Fish > On Apr 14, 2018, at 10:26 AM, Kinney, Michael D > wrote: > > Welcome Laszlo! > > Reviewed-by: Michael D Kinney > > Mike > >> -Original

Re: [edk2] [PATCH edk2-platforms v4 2/2] Platform/HiKey: create 4 boot options

On 04/23/18 08:22, Haojian Zhuang wrote: > Create 4 predefined boot options for HiKey. They're > "Boot from SD", "Grub", "Android Boot" and "Android Fastboot". > > Cc: Laszlo Ersek > Cc: Leif Lindholm > Cc: Ard Biesheuvel

[edk2] [PATCH] ArmVirtPkg: use protocol-based DevicePathLib instance for most DXE modules

Port OvmfPkg commit 5c3481b0b611e to ArmVirtPkg. Some explanation should be in order (because 5c3481b0b611e doesn't offer any): - The UefiDevicePathLibDevicePathProtocol instance uses the Device Path Utilities Protocol, produced by DevicePathDxe, for formatting and parsing the textual device

Re: [edk2] [PATCH] MdeModulePkg/UefiBootManagerLib: fix AddLoadOptionVariable docs/prototype

That is fine. :) Thanks, Star -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo Ersek Sent: Tuesday, April 24, 2018 2:48 AM To: Zeng, Star ; edk2-devel@lists.01.org Cc: Ni, Ruiyu ; Dong, Eric

Re: [edk2] [PATCH 1/1] OvmfPkg/README: add HTTPS Boot

On Fri, Apr 20, 2018 at 01:07:17PM +0200, Laszlo Ersek wrote: > On 04/19/18 11:55, Gary Lin wrote: > > Add the new section for HTTPS Boot. > > > > Cc: Ard Biesheuvel > > Cc: Jordan Justen > > Cc: Laszlo Ersek > >

Re: [edk2] gdb reload-uefi missing EFI_SYSTEM_TABLE_POINTER [was: Source code debugging of OVMF]

On Fri, Apr 20, 2018 at 04:54:06PM +0200, Johannes Swoboda wrote: > Hello, > > Thank you all for your insights. > > You advised me to use the scripts from [1]. > I did so following this guide [2] (thank you also for putting it back up!), > with the minor adaptions that I made the script

Re: [edk2] [PATCH] MdeModulePkg/UefiBootManagerLib: fix AddLoadOptionVariable docs/prototype

On 04/23/18 05:24, Zeng, Star wrote: > Reviewed-by: Star Zeng Thanks, Star -- I intended to push the patch now, but then I noticed Ray pushed it already (commit 8b5c80e0296c). Thanks! Laszlo ___ edk2-devel mailing list

Re: [edk2] [PATCH 0/2] Reenable timer mask quirk for Xen

On 04/23/18 17:00, Ard Biesheuvel wrote: > Reinstate the timer mask quirk for Xen that we recently removed under the > assumption that only ancient KVM host implementations still needed it. > > Ard Biesheuvel (2): > ArmPkg: add reenable hook to ArmGenericTimerCounterLib > ArmVirtPkg: