Re: [edk2] Obtaining TCG final events on systems without TCG2 log support

2018-12-14 Thread Yao, Jiewen
thanks i will raise the topic in next tcg pc client meeting. thank you! Yao, Jiewen > 在 2018年12月14日,下午5:32,Laszlo Ersek 写道: > >> On 12/13/18 19:55, Matthew Garrett wrote: >>> On Thu, Dec 13, 2018 at 01:36:09PM +0100, Laszlo Ersek wrote: >>> >>> (2) EFI_TCG2_FINAL_EVENTS_TABLE is defined

Re: [edk2] Obtaining TCG final events on systems without TCG2 log support

2018-12-14 Thread Matthew Garrett
On Fri, Dec 14, 2018 at 10:32:29AM +0100, Laszlo Ersek wrote: > On 12/13/18 19:55, Matthew Garrett wrote: > > If a platform is unable to produce them in the final events table then > > it's violating the spec. > > The question is why it's made impossible to comply with the spec if the > platform

[edk2] [PATCH 4/7] MdeModulePkg PeiCore: Remove the using of PcdPeiCoreMaxPpiSupported

2018-12-14 Thread Star Zeng
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1405 Background as below. Problem: As static configuration from the PCDs, the binary PeiCore (for example in FSP binary with dispatch mode) could not predict how many FVs, Files or PPIs for different platforms. Burden: Platform developers need

[edk2] [PATCH 0/7] Remove PcdPeiCoreMaxXXX PCDs

2018-12-14 Thread Star Zeng
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1405 Repo: g...@github.com:lzeng14/edk2.git Branch: RemovePcdPeiCoreMaxXXX Background as below. Problem: As static configuration from the PCDs, the binary PeiCore (for example in FSP binary with dispatch mode) could not predict how many FVs,

[edk2] [PATCH 1/7] MdeModulePkg PeiCore: Remove the using of PcdPeiCoreMaxPeimPerFv

2018-12-14 Thread Star Zeng
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1405 Background as below. Problem: As static configuration from the PCDs, the binary PeiCore (for example in FSP binary with dispatch mode) could not predict how many FVs, Files or PPIs for different platforms. Burden: Platform developers need

[edk2] [PATCH 2/7] SecurityPkg Tcg(2)Pei: Remove the using of PcdPeiCoreMaxFvSupported

2018-12-14 Thread Star Zeng
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1405 Background as below. Problem: As static configuration from the PCDs, the binary PeiCore (for example in FSP binary with dispatch mode) could not predict how many FVs, Files or PPIs for different platforms. Burden: Platform developers need

[edk2] [PATCH] ArmVirtPkg/ArmVirt.dsc.inc: define TcpIoLib resolution unconditionally

2018-12-14 Thread Ard Biesheuvel
Commit 9a67ba261fe9 ("ArmVirtPkg: Replace obsoleted network drivers from platform DSC/FDF") failed to take into account that the now unconditionally included IScsiDxe.inf from NetworkPkg requires a resolution for TcpIoLib. Since specifying such a resolution is harmless for platforms that have no

[edk2] [PATCH v2 0/3] Introduce two public functions and remove internal ones

2018-12-14 Thread Shenglei Zhang
Introduce public functions CharToUpper and AsciiToUpper. Remove internal functions InternalCharToUpper and InternalBaseLibAsciiToUpper. Cc: Bob Feng Cc: Liming Gao Cc: Yonghong Zhu Cc: Leif Lindholm Cc: Laszlo Ersek Cc: Michael D Kinney Cc: Liming Gao Shenglei Zhang (3):

[edk2] [PATCH v2 3/3] MdePkg/BaseLib: Remove InternalCharToUpper and InternalBaseLibAsciiToUpper

2018-12-14 Thread Shenglei Zhang
InternalCharToUpper and InternalBaseLibAsciiToUpper are internal functions and now we will introduce public functions that have the same effects. So I remove their definition in BaseLibInternals.h. https://bugzilla.tianocore.org/show_bug.cgi?id=1369 Cc: Leif Lindholm Cc: Laszlo Ersek Cc:

[edk2] [PATCH v2 1/3] BaseTools/Common: Remove InternalCharToUpper

2018-12-14 Thread Shenglei Zhang
InternalCharToUpper is an internal function. So now remove InternalCharToUpper and replace it with a public function CharToUpper in all places. https://bugzilla.tianocore.org/show_bug.cgi?id=1369 Cc: Bob Feng Cc: Liming Gao Cc: Yonghong Zhu Contributed-under: TianoCore Contribution Agreement

[edk2] [PATCH v2 2/3] MdePkg/BaseLib: Introduce CharToUpper and AsciiToUpper publicly

2018-12-14 Thread Shenglei Zhang
Introduce two public functions CharToUpper and AsciiToUpper. They have the same functions as InternalCharToUpper and InternalBaseLibAsciiToUpper.Considering the internal functions will be removed,so directly I change their function names to the public ones'.

Re: [edk2] Obtaining TCG final events on systems without TCG2 log support

2018-12-14 Thread Laszlo Ersek
On 12/13/18 19:55, Matthew Garrett wrote: > On Thu, Dec 13, 2018 at 01:36:09PM +0100, Laszlo Ersek wrote: > >> (2) EFI_TCG2_FINAL_EVENTS_TABLE is defined with TCG_PCR_EVENT2 entries >> *only*. TCG_PCR_EVENT is not accommodated. >> >> >> That's the contradiction. If a platform is unable to produce

Re: [edk2] [PATCH 5/7] OvmfPkg: Remove PcdPeiCoreMaxXXX PCDs' statement

2018-12-14 Thread Ard Biesheuvel
On Fri, 14 Dec 2018 at 11:29, Star Zeng wrote: > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1405 > > The codes have been updated to not use PcdPeiCoreMaxFvSupported, > PcdPeiCoreMaxPeimPerFv and PcdPeiCoreMaxPpiSupported, so their > statement in platform DSC could be removed. > > Cc:

[edk2] [Patch] BaseTools: Fix PcdArray issue

2018-12-14 Thread BobCF
https://bugzilla.tianocore.org/show_bug.cgi?id=1390 1. support hex number for array index 2. support Non-Dynamic Pcd for array data type 3. support {} and {CODE()} for array data type Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Bob Feng Cc: Liming Gao Cc: Ard

Re: [edk2] [PATCH v2] ShellPkg/UefiShellDebug1CommandsLib: Remove the unused function CharToUpper

2018-12-14 Thread Laszlo Ersek
On 12/14/18 08:56, Shenglei Zhang wrote: > CharToUpper is an unused function, so it will be removed. > https://bugzilla.tianocore.org/show_bug.cgi?id=1399 > > v2:Update the title. > > Cc: Laszlo Ersek > Cc: Jaben Carsey > Cc: Ruiyu Ni > Contributed-under: TianoCore Contribution Agreement 1.1

Re: [edk2] [Patch] BaseTools: Fix PcdArray issue

2018-12-14 Thread Philippe Mathieu-Daudé
Hi Bob, On 12/14/18 10:55 AM, BobCF wrote: > https://bugzilla.tianocore.org/show_bug.cgi?id=1390 > 1. support hex number for array index > 2. support Non-Dynamic Pcd for array data type > 3. support {} and {CODE()} for array data type > > Contributed-under: TianoCore Contribution Agreement 1.1 >

Re: [edk2] [PATCH] Maintainers.txt: Change package maintainer and reviewer of CryptoPkg.

2018-12-14 Thread Laszlo Ersek
On 12/14/18 01:47, Ye, Ting wrote: > Thanks all for the info and follow up. Laszlo, please let me know if there is > additional step you think I need follow, thanks. In the future, please let's make sure that the maintainer that is about to give up the role posts the maintenance change *in

[edk2] [edk2-platforms PATCH 0/2] Remove PcdPeiCoreMaxXXX PCDs

2018-12-14 Thread Star Zeng
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1405 https://lists.01.org/pipermail/edk2-devel/2018-December/033985.html is going to remove PcdPeiCoreMaxFvSupported, PcdPeiCoreMaxPeimPerFv and PcdPeiCoreMaxPpiSupported in edk2 Repo, this patch series is to update edk2-platforms Repo

[edk2] [edk2-platforms PATCH 1/2] KabylakeOpenBoardPkg: Remove PcdPeiCoreMaxXXX PCDs' statement

2018-12-14 Thread Star Zeng
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1405 The codes have been updated to not use PcdPeiCoreMaxFvSupported, PcdPeiCoreMaxPeimPerFv and PcdPeiCoreMaxPpiSupported, so their statement in platform DSC could be removed. Cc: Chasel Chiu Cc: Michael A Kubacki Contributed-under:

[edk2] [edk2-platforms PATCH 2/2] PurleyOpenBoardPkg: Remove PcdPeiCoreMaxXXX PCDs' statement

2018-12-14 Thread Star Zeng
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1405 The codes have been updated to not use PcdPeiCoreMaxFvSupported, PcdPeiCoreMaxPeimPerFv and PcdPeiCoreMaxPpiSupported, so their statement in platform DSC could be removed. Cc: Shifei A Lu Cc: Xiaohu Zhou Cc: Isaac W Oram

[edk2] Line endings: Was "Re: [edk2-test][Patch] uefi-sct/SctPkg:Correct macro name style in HwErrRecVariable Test"

2018-12-14 Thread Leif Lindholm
Hmm, this gets me thinking... We were discussing before about doing a line ending conversion in edk2, and let the git gools provide native line endings (as designed). Is this a good opportunity to run a pilot with edk2-test, where much less history will be lost? Regards, Leif On Fri, Dec 14,

Re: [edk2] [RFC PATCH v4 00/12] Extend secure variable service to be usable from Standalone MM

2018-12-14 Thread Jagadeesh Ujja
Hi Liming, On Thu, Dec 13, 2018 at 8:02 PM Gao, Liming wrote: > > I add my comments. Thanks for the clarification. Will fix the patches accordingly. Regards, Jagadeesh. > > > -Original Message- > > From: Jagadeesh Ujja [mailto:jagadeesh.u...@arm.com] > > Sent: Thursday, December 13,

[edk2] [PATCH 3/7] MdeModulePkg PeiCore: Remove the using of PcdPeiCoreMaxFvSupported

2018-12-14 Thread Star Zeng
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1405 Background as below. Problem: As static configuration from the PCDs, the binary PeiCore (for example in FSP binary with dispatch mode) could not predict how many FVs, Files or PPIs for different platforms. Burden: Platform developers need

[edk2] [PATCH 7/7] MdeModulePkg: Remove PcdPeiCoreMaxXXX PCDs

2018-12-14 Thread Star Zeng
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1405 The codes have been updated to not use PcdPeiCoreMaxFvSupported, PcdPeiCoreMaxPeimPerFv and PcdPeiCoreMaxPpiSupported. The patch removes them in MdeModulePkg.dec. Cc: Jian J Wang Cc: Hao Wu Cc: Liming Gao Cc: Ruiyu Ni Cc: Michael D

[edk2] [PATCH 5/7] OvmfPkg: Remove PcdPeiCoreMaxXXX PCDs' statement

2018-12-14 Thread Star Zeng
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1405 The codes have been updated to not use PcdPeiCoreMaxFvSupported, PcdPeiCoreMaxPeimPerFv and PcdPeiCoreMaxPpiSupported, so their statement in platform DSC could be removed. Cc: Jordan Justen Cc: Laszlo Ersek Cc: Ard Biesheuvel Cc:

[edk2] [PATCH 6/7] Vlv2TbltDevicePkg: Remove PcdPeiCoreMaxXXX PCDs' statement

2018-12-14 Thread Star Zeng
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1405 The codes have been updated to not use PcdPeiCoreMaxFvSupported, PcdPeiCoreMaxPeimPerFv and PcdPeiCoreMaxPpiSupported, so their statement in platform DSC could be removed. Cc: Zailiang Sun Cc: Yi Qian Contributed-under: TianoCore

Re: [edk2] [PATCH v2 2/3] MdePkg/BaseLib: Introduce CharToUpper and AsciiToUpper publicly

2018-12-14 Thread Leif Lindholm
On Fri, Dec 14, 2018 at 04:20:27PM +0800, Shenglei Zhang wrote: > Introduce two public functions CharToUpper and AsciiToUpper. > They have the same functions as InternalCharToUpper and > InternalBaseLibAsciiToUpper.Considering the internal functions will > be removed,so directly I change their

Re: [edk2] Line endings: Was "Re: [edk2-test][Patch] uefi-sct/SctPkg:Correct macro name style in HwErrRecVariable Test"

2018-12-14 Thread Laszlo Ersek
On 12/14/18 18:12, Supreeth Venkatesh wrote: > On Fri, 2018-12-14 at 14:24 +0100, Laszlo Ersek wrote: >> On 12/14/18 11:59, Leif Lindholm wrote: >>> Hmm, this gets me thinking... >>> >>> We were discussing before about doing a line ending conversion in >>> edk2, and let the git gools provide

Re: [edk2] [PATCH edk2-platforms 19/27] Silicon/NXP: Add i.MX6 ACPI tables

2018-12-14 Thread Leif Lindholm
On Fri, Sep 21, 2018 at 08:26:12AM +, Chris Co wrote: > This adds baseline ACPI table support for booting Windows on > NXP i.MX6 SoCs. Platforms may override these tables as necessary. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Christopher Co > Cc: Ard

Re: [edk2] [PATCH edk2-platforms 21/27] Silicon/NXP: Add i.MX6 PCIe DXE driver

2018-12-14 Thread Leif Lindholm
On Fri, Sep 21, 2018 at 08:26:13AM +, Chris Co wrote: > This adds DXE driver support for PCIe on NXP i.MX6 SoCs. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Christopher Co > Cc: Ard Biesheuvel > Cc: Leif Lindholm > Cc: Michael D Kinney > --- >

Re: [edk2] [PATCH edk2-platforms 23/27] Silicon/NXP: Add i.MX6 Smbios Driver

2018-12-14 Thread Leif Lindholm
On Fri, Sep 21, 2018 at 08:26:15AM +, Chris Co wrote: > This adds support populating the SMBIOS tables on an i.MX6 SoC. > Platforms just need to define the relevant PCDs in their dsc file and > this driver will fill out the SMBIOS table structures. > > Contributed-under: TianoCore

[edk2] [PATCH 00/13] Extend secure variable service to be usable from Standalone MM

2018-12-14 Thread Jagadeesh Ujja
Changes since RFC v4: - Addressed all the comments from Liming Gao - Added an additional PCD 'PcdStandaloneMmCodeEnabled' to indicate presence of StandaloneMM support. - MdePkg.dec file updated to include StandaloneMmServiceTableLib and StandaloneMmRuntimeDxe library. - Platform

[edk2] [PATCH 01/13] StandaloneMmPkg: Pull in additonal libraries from staging branch

2018-12-14 Thread Jagadeesh Ujja
Three additional library packages are being pulled into StandaloneMmPkg from the staging area in order to support the secure variable service. The three packages being pulled in are - StandaloneMmHobLib - StandaloneMmMemoryAllocationLib - StandaloneMmServicesTableLib Contributed-under:

[edk2] [PATCH 02/13] MdePkg: Add a PCD that indicates presence of Standalone MM mode

2018-12-14 Thread Jagadeesh Ujja
Add a flag to indicate the presence of Standalone MM mode. For existing library and/or drivers that can be refactored to be used as a Standalone MM component, this flag can be used to choose the portions of the code that gets executed in Standalone MM. Contributed-under: TianoCore Contribution

[edk2] [PATCH 08/13] MdeModulePkg/Variable/RuntimeDxe: adapt for usability with MM Standalone

2018-12-14 Thread Jagadeesh Ujja
Adapt the VariableSmmRuntimeDxe driver to communicate with a VariableSmm driver that is implemented as a MM Standalone driver. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jagadeesh Ujja --- MdeModulePkg/Universal/Variable/RuntimeDxe/VariableRuntimeDxe.inf| 1 +

[edk2] [PATCH 05/13] MdePkg/Library/BaseLib/AArch64: Add AsmLfence function

2018-12-14 Thread Jagadeesh Ujja
Variable service driver includes a call to AsmLfence. To reuse this driver on AArch64 based platforms, add an implementation of AsmLfence that acts as a wrapper on the AArch64 specific MemoryFence function. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jagadeesh Ujja ---

[edk2] [PATCH 06/13] MdePkg/Library: Add StandaloneMmRuntimeDxe library

2018-12-14 Thread Jagadeesh Ujja
To resuse some the libraries in both MM and non-MM mode, a mechanism to determine the execution mode is required, i.e, in MM or non-MM. Add a new library for use by non-MM code to determine the current execution mode. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by:

[edk2] [PATCH 12/13] SecurityPkg/AuthVariableLib: allow MM_STANDALONE drivers to use this library

2018-12-14 Thread Jagadeesh Ujja
“AuthVariableLib” library can be used by MM_STANDALONE drivers as well. So add MM_STANDALONE as the module type this library supports. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jagadeesh Ujja Reviewed-by: Chao Zhang ---

[edk2] [PATCH 09/13] MdeModulePkg/Variable/RuntimeDxe: adapt as a MM Standalone driver

2018-12-14 Thread Jagadeesh Ujja
Adapt the variable runtime dxe driver to be used as a MM_STANDALONE driver to provide variable storage service in MM Standalone mode. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jagadeesh Ujja --- MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c |

[edk2] [PATCH 10/13] MdeModulePkg/VarCheckLib: allow MM_STANDALONE drivers to use this library

2018-12-14 Thread Jagadeesh Ujja
“VarCheckLib” library can be used by MM_STANDALONE drivers as well. So add MM_STANDALONE as the module type this library supports. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jagadeesh Ujja --- MdeModulePkg/Library/VarCheckLib/VarCheckLib.inf | 5 +++-- 1 file

[edk2] [PATCH 11/13] ArmPlatformPkg/NorFlashDxe: allow reusability as a MM driver

2018-12-14 Thread Jagadeesh Ujja
Adapt the NorFlashDxe driver to be used as a MM_STANDALONE driver to allow access to NOR flash for code executing in MM_STANDALONE mode. This allows storing of EFI variables on NOR flash which is accessible only via the MM STANDALONE mode software. Contributed-under: TianoCore Contribution

[edk2] [PATCH 13/13] CryptoPkg/BaseCryptLib: allow MM_STANDALONE drivers to use this library

2018-12-14 Thread Jagadeesh Ujja
“BaseCryptLib” library can be used by MM_STANDALONE drivers as well. So add MM_STANDALONE as the module type this library supports. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jagadeesh Ujja --- CryptoPkg/Library/BaseCryptLib/BaseCryptLib.inf | 7 ++-

Re: [edk2] Line endings: Was "Re: [edk2-test][Patch] uefi-sct/SctPkg:Correct macro name style in HwErrRecVariable Test"

2018-12-14 Thread Laszlo Ersek
On 12/14/18 11:59, Leif Lindholm wrote: > Hmm, this gets me thinking... > > We were discussing before about doing a line ending conversion in > edk2, and let the git gools provide native line endings (as designed). > > Is this a good opportunity to run a pilot with edk2-test, where much > less

Re: [edk2] [PATCH] ArmVirtPkg/ArmVirt.dsc.inc: define TcpIoLib resolution unconditionally

2018-12-14 Thread Laszlo Ersek
On 12/14/18 12:22, Ard Biesheuvel wrote: > Commit 9a67ba261fe9 ("ArmVirtPkg: Replace obsoleted network drivers > from platform DSC/FDF") failed to take into account that the now > unconditionally included IScsiDxe.inf from NetworkPkg requires a > resolution for TcpIoLib. I don't understand why

Re: [edk2] [PATCH 5/7] OvmfPkg: Remove PcdPeiCoreMaxXXX PCDs' statement

2018-12-14 Thread Laszlo Ersek
On 12/14/18 11:28, Star Zeng wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1405 > > The codes have been updated to not use PcdPeiCoreMaxFvSupported, > PcdPeiCoreMaxPeimPerFv and PcdPeiCoreMaxPpiSupported, so their > statement in platform DSC could be removed. > > Cc: Jordan Justen

Re: [edk2] [PATCH 05/13] MdePkg/Library/BaseLib/AArch64: Add AsmLfence function

2018-12-14 Thread Ard Biesheuvel
On Fri, 14 Dec 2018 at 13:13, Jagadeesh Ujja wrote: > > Variable service driver includes a call to AsmLfence. To reuse this > driver on AArch64 based platforms, add an implementation of AsmLfence > that acts as a wrapper on the AArch64 specific MemoryFence function. > > Contributed-under:

[edk2] [PATCH 03/13] MdeModulePkg: Add a PCD to indicate Standalone MM supports secure variable

2018-12-14 Thread Jagadeesh Ujja
Add a flag that indicates whether Standalone MM mode supports secure storage of variables. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jagadeesh Ujja --- MdeModulePkg/MdeModulePkg.dec | 5 + 1 file changed, 5 insertions(+) diff --git

[edk2] [PATCH 04/13] MdePkg/Include: add StandaloneMmServicesTableLib header file

2018-12-14 Thread Jagadeesh Ujja
Some of the existing DXE drivers can be refactored to execute within the Standalone MM execution environment as well. Allow such drivers to get access to the Standalone MM services tables. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jagadeesh Ujja ---

[edk2] [PATCH 07/13] MdeModulePkg/FaultTolerantWriteDxe: allow reusability as a MM driver

2018-12-14 Thread Jagadeesh Ujja
Adapt the FaultTolerantWriteDxe driver to be used as a MM_STANDALONE driver to provide UEFI fault tolerant write protocol functionality for variable reclaim operation on EFI variables stored on a NOR flash that is only accessible to code executing in MM Standalone mode. Contributed-under:

Re: [edk2] [PATCH] ArmVirtPkg/ArmVirt.dsc.inc: define TcpIoLib resolution unconditionally

2018-12-14 Thread Ard Biesheuvel
On Fri, 14 Dec 2018 at 14:56, Laszlo Ersek wrote: > > On 12/14/18 12:22, Ard Biesheuvel wrote: > > Commit 9a67ba261fe9 ("ArmVirtPkg: Replace obsoleted network drivers > > from platform DSC/FDF") failed to take into account that the now > > unconditionally included IScsiDxe.inf from NetworkPkg

Re: [edk2] [PATCH] MdeModulePkg/PciBus: Fix system hang when no PCI Option ROM exists

2018-12-14 Thread Philippe Mathieu-Daudé
On 12/12/18 4:10 PM, Ruiyu Ni wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1394 > > When there is no PCI option ROM exists, today's logic still creates > virtual BAR for option ROM using Length = 0, Alignment = (-1). > It causes the final MEM32 alignment requirement is as big as >

Re: [edk2] Line endings: Was "Re: [edk2-test][Patch] uefi-sct/SctPkg:Correct macro name style in HwErrRecVariable Test"

2018-12-14 Thread Jin, Eric
Currently, the git am fail with " --ignore-space-change" switch on/off. It is better if we can solve it with "core.whitespace", "am.keepcr" and "core.autocrlf" in the meantime. Should all existing patches hold until the conversion done or the conversion is tried on the branch until it is

Re: [edk2] [PATCH edk2-platforms 24/27] Silicon/NXP: Add i.MX6 common dsc and fdf files

2018-12-14 Thread Leif Lindholm
On Fri, Sep 21, 2018 at 08:26:16AM +, Chris Co wrote: > This adds the common dsc and fdf definitions for NXP i.MX6 platforms. > Platform dsc definitions will define $(BOARD_NAME), $(IMX_FAMILY), > $(IMX_CHIP_TYPE), $(DRAM_SIZE), and $(BOARD_DIR) to indicate > i.MX SoC family and board-specific

Re: [edk2] Line endings: Was "Re: [edk2-test][Patch] uefi-sct/SctPkg:Correct macro name style in HwErrRecVariable Test"

2018-12-14 Thread Supreeth Venkatesh
On Fri, 2018-12-14 at 20:57 +0100, Laszlo Ersek wrote: > On 12/14/18 18:12, Supreeth Venkatesh wrote: > > On Fri, 2018-12-14 at 14:24 +0100, Laszlo Ersek wrote: > > > On 12/14/18 11:59, Leif Lindholm wrote: > > > > Hmm, this gets me thinking... > > > > > > > > We were discussing before about

Re: [edk2] [PATCH v2] ShellPkg/UefiShellDebug1CommandsLib: Remove the unused function CharToUpper

2018-12-14 Thread Carsey, Jaben
Reviewed-by: Jaben Carsey > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Friday, December 14, 2018 1:54 AM > To: Zhang, Shenglei ; edk2-devel@lists.01.org > Cc: Carsey, Jaben ; Ni, Ruiyu > Subject: Re: [PATCH v2] ShellPkg/UefiShellDebug1CommandsLib: Remove

Re: [edk2] [PATCH v1 edk2-platforms 1/8] Platform/ARM/SgiPkg: Restructure virtio device registration

2018-12-14 Thread Vijayenthiran Subramaniam
On Fri, Dec 14, 2018 at 8:26 PM Ard Biesheuvel wrote: > > On Tue, 11 Dec 2018 at 10:08, Vijayenthiran Subramaniam > wrote: > > > > On Fri, Dec 7, 2018 at 5:49 AM Vijayenthiran Subramaniam > > wrote: > > > > > > On Thu, Dec 6, 2018 at 5:18 PM Ard Biesheuvel > > > wrote: > > > > > > > > On Wed,

Re: [edk2] [PATCH v2 edk2-platforms 00/20] Platform/Broadcom: Add Raspberry Pi 3 support

2018-12-14 Thread Philippe Mathieu-Daudé
Hi Pete, Leif. On 12/12/18 9:01 PM, Leif Lindholm wrote: > On Wed, Dec 12, 2018 at 07:53:04PM +, Pete Batard wrote: >> On 2018.12.12 18:32, Leif Lindholm wrote: >>> On Tue, Dec 11, 2018 at 08:16:07PM +, Pete Batard wrote: > I _think_ all of the ATF binaries we have in non-osi are

[edk2] [Patch V2] BaseTools: Fix PcdArray issue

2018-12-14 Thread BobCF
From: "Feng, Bob C" https://bugzilla.tianocore.org/show_bug.cgi?id=1390 1. support hex number for array index 2. support Non-Dynamic Pcd for array data type 3. support {} and {CODE()} for array data type 4. Change GetStructurePcdMaxSize to be a static function since it need to be called in

Re: [edk2] [PATCH v2 edk2-platforms 16/20] Platform/Broadcom/RPi3: Add Raspberry Pi 3 Platform

2018-12-14 Thread Pete Batard
Hi Ard, Thanks for the review. I will incorporate the points you raised for 8/9/13. On 2018.12.14 15:39, Ard Biesheuvel wrote: On Mon, 10 Dec 2018 at 13:39, Pete Batard wrote: Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Pete Batard ---

Re: [edk2] [PATCH v2 edk2-platforms 00/20] Platform/Broadcom: Add Raspberry Pi 3 support

2018-12-14 Thread Leif Lindholm
On Fri, Dec 14, 2018 at 05:14:05PM +0100, Philippe Mathieu-Daudé wrote: > >> I can certainly upload binary releases for the required ATF files in my > >> github clone of ATF, and then add links to that in the readme with the > >> instructions on how to rebuild ATF. > >> > >> However, I'd rather

Re: [edk2] [PATCH v2 edk2-platforms 08/20] Platform/Broadcom/RPi3: Add Display driver

2018-12-14 Thread Ard Biesheuvel
On Mon, 10 Dec 2018 at 13:39, Pete Batard wrote: > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Pete Batard Please fix the usual things like INF_VERSION and space before ( in function or macro invocations. Otherwise, this looks fine ' > --- >

Re: [edk2] [PATCH v2 edk2-platforms 13/20] Platform/Broadcom/RPi3: Add SMBIOS driver

2018-12-14 Thread Ard Biesheuvel
On Mon, 10 Dec 2018 at 13:39, Pete Batard wrote: > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Pete Batard Please use STATIC etc etc > --- > Platform/Broadcom/Bcm283x/Drivers/PlatformSmbiosDxe/PlatformSmbiosDxe.c | > 915 >

Re: [edk2] [PATCH v1 edk2-platforms 1/8] Platform/ARM/SgiPkg: Restructure virtio device registration

2018-12-14 Thread Ard Biesheuvel
On Tue, 11 Dec 2018 at 10:08, Vijayenthiran Subramaniam wrote: > > On Fri, Dec 7, 2018 at 5:49 AM Vijayenthiran Subramaniam > wrote: > > > > On Thu, Dec 6, 2018 at 5:18 PM Ard Biesheuvel > > wrote: > > > > > > On Wed, 5 Dec 2018 at 07:10, Vijayenthiran Subramaniam > > > wrote: > > > > > > > >

Re: [edk2] [PATCH v2 edk2-platforms 09/20] Platform/Broadcom/RPi3: Add Graphic Console driver

2018-12-14 Thread Ard Biesheuvel
On Mon, 10 Dec 2018 at 13:39, Pete Batard wrote: > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Pete Batard > --- > Platform/Broadcom/Bcm283x/Drivers/GraphicsConsoleDxe/ComponentName.c > | 183 ++ >

Re: [edk2] [PATCH v2 edk2-platforms 16/20] Platform/Broadcom/RPi3: Add Raspberry Pi 3 Platform

2018-12-14 Thread Ard Biesheuvel
On Mon, 10 Dec 2018 at 13:39, Pete Batard wrote: > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Pete Batard > --- > Platform/Broadcom/Bcm283x/RaspberryPiPkg.dec | 63 ++ > Platform/Broadcom/Bcm283x/RaspberryPiPkg.dsc | 636 >

Re: [edk2] [PATCH edk2-platforms 20/27] Silicon/NXP: Add i.MX6 Board init library

2018-12-14 Thread Leif Lindholm
On Fri, Sep 21, 2018 at 08:26:12AM +, Chris Co wrote: > This adds support for board initialization which is common to > NXP i.MX6-based platforms. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Christopher Co > Cc: Ard Biesheuvel > Cc: Leif Lindholm > Cc:

[edk2] [PATCH v2 edk2-platforms 0/8] Platform/ARM/Sgi: Add support for virtio network device

2018-12-14 Thread Vijayenthiran Subramaniam
Changes since v1: - Rebased the series against latest edk2-platforms This patch series adds support for virtio network controller found in ARM SGI plaform's fast models. The first patch in this series restructure the virtio device registration code to allow registration of additional virtio

[edk2] [PATCH v2 edk2-platforms 1/8] Platform/ARM/SgiPkg: Restructure virtio device registration

2018-12-14 Thread Vijayenthiran Subramaniam
From: Daniil Egranov SGI platforms support multiple virtio devices. So the existing code, that supports registration of only the virtio disk, is restructured to accommodate the registration of additional virtio devices. In addition to this, PCDs to represent the virtio controller base and

[edk2] [PATCH v2 edk2-platforms 6/8] SgiClark.Ares: AcpiTables: Add entry for virtio network device

2018-12-14 Thread Vijayenthiran Subramaniam
SgiClark Ares include an instance of the virtio network device. Add a representation for it in the ACPI tables. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Vijayenthiran Subramaniam --- Platform/ARM/SgiPkg/AcpiTables/SgiClarkAresAcpiTables.inf | 3 +++

[edk2] [PATCH v2 edk2-platforms 7/8] SgiClark.Helios: AcpiTables: Use PCDs for virtio disk

2018-12-14 Thread Vijayenthiran Subramaniam
Use PCDs instead of hardcoded values for virtio disk in DSDT. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Vijayenthiran Subramaniam --- Platform/ARM/SgiPkg/AcpiTables/SgiClarkHeliosAcpiTables.inf | 4 Platform/ARM/SgiPkg/AcpiTables/SgiClarkHelios/Dsdt.asl |

[edk2] [PATCH v2 edk2-platforms 8/8] SgiClark.Helios: AcpiTables: Add entry for virtio network device

2018-12-14 Thread Vijayenthiran Subramaniam
SgiClark Helios include an instance of the virtio network device. Add a representation for it in the ACPI tables. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Vijayenthiran Subramaniam --- Platform/ARM/SgiPkg/AcpiTables/SgiClarkHeliosAcpiTables.inf | 3 +++

Re: [edk2] [PATCH v2 edk2-platforms 00/20] Platform/Broadcom: Add Raspberry Pi 3 support

2018-12-14 Thread Pete Batard
Hi Philippe, Hi Leif, On 2018.12.14 16:36, Leif Lindholm wrote: On Fri, Dec 14, 2018 at 05:14:05PM +0100, Philippe Mathieu-Daudé wrote: I can certainly upload binary releases for the required ATF files in my github clone of ATF, and then add links to that in the readme with the instructions on

Re: [edk2] [PATCH edk2-platforms 17/27] Silicon/NXP: Add i.MX6 USB Phy Library

2018-12-14 Thread Leif Lindholm
On Fri, Sep 21, 2018 at 08:26:09AM +, Chris Co wrote: > This adds support for configuring the USB EHCI PHY on NXP i.MX6 SoCs. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Christopher Co > Cc: Ard Biesheuvel > Cc: Leif Lindholm > Cc: Michael D Kinney > --- >

Re: [edk2] Line endings: Was "Re: [edk2-test][Patch] uefi-sct/SctPkg:Correct macro name style in HwErrRecVariable Test"

2018-12-14 Thread Supreeth Venkatesh
On Fri, 2018-12-14 at 14:24 +0100, Laszlo Ersek wrote: > On 12/14/18 11:59, Leif Lindholm wrote: > > Hmm, this gets me thinking... > > > > We were discussing before about doing a line ending conversion in > > edk2, and let the git gools provide native line endings (as > > designed). > > > > Is

Re: [edk2] [PATCH edk2-platforms 18/27] Silicon/NXP: Add i.MX6 Clock Library

2018-12-14 Thread Leif Lindholm
On Fri, Sep 21, 2018 at 08:26:11AM +, Chris Co wrote: > This adds support for managing clocks on NXP i.MX6 SoC. It will > manipulate the Clock Gating registers (CCGR). > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Christopher Co > Cc: Ard Biesheuvel > Cc: Leif

Re: [edk2] [PATCH v2 edk2-platforms 00/20] Platform/Broadcom: Add Raspberry Pi 3 support

2018-12-14 Thread Leif Lindholm
On Fri, Dec 14, 2018 at 05:08:05PM +, Pete Batard wrote: > Hi Philippe, Hi Leif, > > On 2018.12.14 16:36, Leif Lindholm wrote: > > On Fri, Dec 14, 2018 at 05:14:05PM +0100, Philippe Mathieu-Daudé wrote: > > > > > I can certainly upload binary releases for the required ATF files in > > > > >

[edk2] [PATCH v2 edk2-platforms 2/8] Platform/ARM/SgiPkg: Add support for virtio net device

2018-12-14 Thread Vijayenthiran Subramaniam
From: Daniil Egranov Add support for virtio net device by adding PCDs to specify the data required to setup the virtio net device and register it. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Daniil Egranov --- Platform/ARM/SgiPkg/SgiPlatform.dec

[edk2] [PATCH v2 edk2-platforms 3/8] Sgi575: AcpiTables: Use PCDs for virtio disk

2018-12-14 Thread Vijayenthiran Subramaniam
From: Daniil Egranov Use PCDs instead of hardcoded values for virtio disk in DSDT. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Daniil Egranov --- Platform/ARM/SgiPkg/AcpiTables/Sgi575AcpiTables.inf | 4 Platform/ARM/SgiPkg/AcpiTables/Sgi575/Dsdt.asl | 10

[edk2] [PATCH v2 edk2-platforms 4/8] Sgi575: AcpiTables: Add entry for virtio network device

2018-12-14 Thread Vijayenthiran Subramaniam
From: Daniil Egranov SGI575 include an instance of the virtio network device. So add a representation for it in the ACPI tables. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Daniil Egranov --- Platform/ARM/SgiPkg/AcpiTables/Sgi575AcpiTables.inf | 3 +++

[edk2] [PATCH v2 edk2-platforms 5/8] SgiClark.Ares: AcpiTables: Use PCDs for virtio disk

2018-12-14 Thread Vijayenthiran Subramaniam
Use PCDs instead of hardcoded values for virtio disk in DSDT. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Vijayenthiran Subramaniam --- Platform/ARM/SgiPkg/AcpiTables/SgiClarkAresAcpiTables.inf | 4 Platform/ARM/SgiPkg/AcpiTables/SgiClarkAres/Dsdt.asl | 12