[edk2] [PATCH RESEND 3/3] OvmfPkg/XenSupport: turn off address decoding before BAR sizing

On Xen, hvmloader firmware leaves address decoding enabled for enumerated PCI device before jumping into OVMF. OVMF seems to expect it to be disabled and tries to size PCI BARs in several places without disabling it which causes BAR64, for example, being incorrectly placed by QEMU. Fix it by

[edk2] [PATCH RESEND 0/3] Xen PCI passthrough fixes

Resend to include xen-de...@lists.xenproject.org to CC Igor Druzhinin (3): OvmfPkg/XenSupport: remove usage of prefetchable PCI host bridge aperture OvmfPkg/XenSupport: use a correct PCI host bridge aperture for BAR64 OvmfPkg/XenSupport: turn off address decoding before BAR sizing

Re: [edk2] Does ARM platform produce MP protocol?

On Wed, Mar 06, 2019 at 10:37:58AM +0100, Ard Biesheuvel wrote: > (adding Achin and Charles) > > On Wed, 6 Mar 2019 at 10:16, Ni, Ray wrote: > > > > > -Original Message- > > > From: edk2-devel On Behalf Of Ard > > > Biesheuvel > > > Sent: Wednesday, March 6, 2019 3:38 PM > > > To: Ni,

Re: [edk2] [PATCH RESEND 3/3] OvmfPkg/XenSupport: turn off address decoding before BAR sizing

On 03/06/19 13:40, Igor Druzhinin wrote: > On Xen, hvmloader firmware leaves address decoding enabled for > enumerated PCI device before jumping into OVMF. OVMF seems to > expect it to be disabled and tries to size PCI BARs in several places > without disabling it which causes BAR64, for example,

Re: [edk2] Does ARM platform produce MP protocol?

On Wed, 6 Mar 2019 at 13:41, Achin Gupta wrote: > > On Wed, Mar 06, 2019 at 10:37:58AM +0100, Ard Biesheuvel wrote: > > (adding Achin and Charles) > > > > On Wed, 6 Mar 2019 at 10:16, Ni, Ray wrote: > > > > > > > -Original Message- > > > > From: edk2-devel On Behalf Of Ard > > > >

[edk2] Any open source EFI app to dump USB descriptors from Shell

Hi All, Am looking for an app in EFI, to dump USB descriptors Any info on such utility, please educate Regards Ranga ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel

[edk2] [PATCH RESEND 2/3] OvmfPkg/XenSupport: use a correct PCI host bridge aperture for BAR64

In case BAR64 is placed below 4G choose the correct aperture. This fixes a failed assertion down the code path. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Igor Druzhinin --- OvmfPkg/Library/PciHostBridgeLib/XenSupport.c | 6 +- 1 file changed, 5 insertions(+), 1

[edk2] [Patch V2 1/1] Document: Update Inf spec to remove EDK and IPF related contents

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1453 Remove EDK and IPF related contents Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Bob Feng Cc: Liming Gao Cc: Jaben Carsey --- 1_introduction/11_overview.md

[edk2] [Patch V2 0/1] Document: Update Inf spec to remove EDK and IPF related contents

V2: Update the table of content and update history. Update commit message and fixed a bug. Feng, Bob C (1): Document: Update Inf spec to remove EDK related contents 1_introduction/11_overview.md | 4 ++--

[edk2] [PATCH RESEND 1/3] OvmfPkg/XenSupport: remove usage of prefetchable PCI host bridge aperture

This aperture doesn't exist in OVMF and trying to use it causes failing assertions later in cases there are prefetchable and non-prefetchable BARs following each other. This configuration is quite likely with some PCI passthrough devices. Contributed-under: TianoCore Contribution Agreement 1.1

Re: [edk2] [Patch] Document: Update FDF spec to remove EDK related contents

1. Update commit message 2. + 2.8 [Rule] Sections, and +## 2.7 [Rule] Sections. They are not consistent. 3. +[Rule.Common.ACPITABLE] Here ACPITABLE is EDK type. Please change it to [Rule.Common.USER_DEFINED.ACPITABLE] > -Original Message- > From: Feng, Bob C > Sent: Monday, March 4,

Re: [edk2] [Patch] Document: Update Inf spec to remove EDK related contents

Hi Liming, I'll update patch for 1) and 2) For 3) This patch removed "and are valid for EDK-II modules only." Because I think there is only EDK-II now, we don't need to point out this section is for EDKII ONLY here. Thanks, Bob -Original Message- From: Gao, Liming Sent: Wednesday,

[edk2] [Patch 1/1] Document: Update FDF spec to remove EDK and IPF related contents

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1453 Remove EDK and IPF related contents inf Fdf spec. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Bob Feng Cc: Liming Gao Cc: Jaben Carsey --- 1_introduction/11_overview.md

[edk2] [Patch V2 0/1] Document: Update FDF spec to remove EDK and IPF related contents

V2: Update the table of content and update history. Update commit message and fixed a bug. Feng, Bob C (1): Document: Update FDF spec to remove EDK and IPF related contents 1_introduction/11_overview.md | 22 +++---

Re: [edk2] Does ARM platform produce MP protocol?

(adding Achin and Charles) On Wed, 6 Mar 2019 at 10:16, Ni, Ray wrote: > > > -Original Message- > > From: edk2-devel On Behalf Of Ard > > Biesheuvel > > Sent: Wednesday, March 6, 2019 3:38 PM > > To: Ni, Ray > > Cc: edk2-devel@lists.01.org > > Subject: Re: [edk2] Does ARM platform

Re: [edk2] [Patch V2 0/1] Document: Update Build spec to remove EDK related

Bob: Please ignore the previous comments. For build spec change, I have only one comment to update the commit message to remove EDK and IPF contents. With this change, Reviewed-by: Liming Gao Thanks Liming > -Original Message- > From: edk2-devel

[edk2] [Patch V2 1/1] Document: Update DSC spec to remove EDK and IPF related contents

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1453 Remove EDK and IPF related contents inf Dsc spec. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Bob Feng Cc: Liming Gao Cc: Jaben Carsey --- 1_introduction/11_overview.md

[edk2] [Patch V2 0/1] Document: Update DSC spec to remove EDK and IPF related contents

V2: Update the table of contents and the update history. Feng, Bob C (1): Document: Update DSC spec to remove EDK and IPF related contents 1_introduction/11_overview.md | 14 --

Re: [edk2] [Patch V2 1/1] Document: Update DEC spec to remove EDK related contents

Update commit message and version info to remove EDK and IFP related contents from DEC spec. With this change, Reviewed-by: Liming Gao > -Original Message- > From: Feng, Bob C > Sent: Tuesday, March 5, 2019 11:50 PM > To: edk2-devel@lists.01.org > Cc: Feng, Bob C ; Gao, Liming ; >

Re: [edk2] [Patch] Document: Add PCD flexible format value EBNF in Fdf.

Reviewed-by: Liming Gao > -Original Message- > From: Feng, Bob C > Sent: Tuesday, March 5, 2019 12:16 AM > To: edk2-devel@lists.01.org > Cc: Feng, Bob C ; Gao, Liming ; > Zhu, Yonghong > Subject: [Patch] Document: Add PCD flexible format value EBNF in Fdf. > > BZ:

Re: [edk2] Does ARM platform produce MP protocol?

> -Original Message- > From: edk2-devel On Behalf Of Ard > Biesheuvel > Sent: Wednesday, March 6, 2019 3:38 PM > To: Ni, Ray > Cc: edk2-devel@lists.01.org > Subject: Re: [edk2] Does ARM platform produce MP protocol? > > On Wed, 6 Mar 2019 at 06:44, Ni, Ray wrote: > > > > Ard, Leif, > >

Re: [edk2] [Patch V2 0/1] Document: Update Build spec to remove EDK related

1. 2.12 [UserExtensions] Section and ## 2.11 [UserExtensions] Section are inconsistent. There are the similar issue in this patch. Please check them to make sure they are same. Thanks Liming > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of

Re: [edk2] [Patch] Document: Update Inf spec to remove EDK related contents

Bob: I have some comments. 1) Please update the commit message. The change is to remove EDK and IPF related contents. 2) The below change should make sure the updated one keep the same alignment. -||- +|| 3) Below content is correct.

Re: [edk2] [Patch] Document: Update DSC spec to remove EDK related contents

1. 2.12 [UserExtensions] Section and ## 2.11 [UserExtensions] Section are inconsistent. There are the similar issue in this patch. Please check them to make sure they are same. 2. Update commit message for EDK and IPF both. > -Original Message- > From: Feng, Bob C > Sent: Monday,

[edk2] [PATCH v2] MdeModulePkg/SdMmcPciHcDxe: Add V3 64b DMA Support

Driver was supporting only 32b DMA support for V3 controllers. Add support for 64b DMA as well for completeness. For V4.0 64b support, driver was looking at incorrect capability register bit. Fix for that is present as well. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1583

Re: [edk2] [PATCH 02/10] StandaloneMmPkg: drop unused PCD PcdStandaloneMmEnable

On Wed, 6 Mar 2019 at 16:16, Achin Gupta wrote: > > Hi Ard, > > On Tue, Mar 05, 2019 at 02:32:40PM +0100, Ard Biesheuvel wrote: > > The PCD PcdStandaloneMmEnable is unused, and shouldn't exist in the > > first place since the value is implied by the context (it is never > > valid to set it to

Re: [edk2] [PATCH 02/10] StandaloneMmPkg: drop unused PCD PcdStandaloneMmEnable

Hi Ard, On Tue, Mar 05, 2019 at 02:32:40PM +0100, Ard Biesheuvel wrote: > The PCD PcdStandaloneMmEnable is unused, and shouldn't exist in the > first place since the value is implied by the context (it is never > valid to set it to FALSE for standalone MM or TRUE for traditional > MM). So drop

Re: [edk2] [PATCH] ShellPkg/UefiShellAcpiViewCommandLib: Change the note in uni

On Wed, 6 Mar 2019 at 15:54, Carsey, Jaben wrote: > Reviewed-by: Jaben Carsey > > > -Original Message- > > From: Gao, Zhichao > > Sent: Tuesday, March 05, 2019 11:05 PM > > To: edk2-devel@lists.01.org > > Cc: Ni, Ray ; Carsey, Jaben ; > > Gao, Liming > > Subject: [PATCH]

Re: [edk2] [PATCH RESEND 3/3] OvmfPkg/XenSupport: turn off address decoding before BAR sizing

On 06/03/2019 13:22, Laszlo Ersek wrote: > On 03/06/19 13:40, Igor Druzhinin wrote: >> On Xen, hvmloader firmware leaves address decoding enabled for >> enumerated PCI device before jumping into OVMF. OVMF seems to >> expect it to be disabled and tries to size PCI BARs in several places >> without

Re: [edk2] [PATCH] ShellPkg/UefiShellAcpiViewCommandLib: Change the note in uni

Reviewed-by: Jaben Carsey > -Original Message- > From: Gao, Zhichao > Sent: Tuesday, March 05, 2019 11:05 PM > To: edk2-devel@lists.01.org > Cc: Ni, Ray ; Carsey, Jaben ; > Gao, Liming > Subject: [PATCH] ShellPkg/UefiShellAcpiViewCommandLib: Change the note > in uni > Importance: High >

Re: [edk2] [PATCH 03/10] StandaloneMmPkg: switch to NULL DebugLib resolution

Reviewed-by: achin.gu...@arm.com On Tue, Mar 05, 2019 at 02:32:41PM +0100, Ard Biesheuvel wrote: > Building StandaloneMmPkg from its .DSC is mainly intended for build > coverage, and so platform specific configuration such as UART addresses > don't belong here. > > Contributed-under: TianoCore

Re: [edk2] [PATCH 02/10] StandaloneMmPkg: drop unused PCD PcdStandaloneMmEnable

On Wed, Mar 06, 2019 at 04:17:51PM +0100, Ard Biesheuvel wrote: > On Wed, 6 Mar 2019 at 16:16, Achin Gupta wrote: > > > > Hi Ard, > > > > On Tue, Mar 05, 2019 at 02:32:40PM +0100, Ard Biesheuvel wrote: > > > The PCD PcdStandaloneMmEnable is unused, and shouldn't exist in the > > > first place

Re: [edk2] [PATCH] ShellPkg/UefiShellAcpiViewCommandLib: Change the note in uni

Good catch. After fixing this typo, my RB stands. Sent from my iPad On Mar 6, 2019, at 7:59 AM, Nariman Poushin mailto:nariman.pous...@linaro.org>> wrote: On Wed, 6 Mar 2019 at 15:54, Carsey, Jaben mailto:jaben.car...@intel.com>> wrote: Reviewed-by: Jaben Carsey

Re: [edk2] [PATCH 05/10] StandaloneMmPkg/StandaloneMmCoreEntryPoint: drop explicit SerialPortLib call

On Wed, 6 Mar 2019 at 17:35, Achin Gupta wrote: > > Hi Ard, > > On Tue, Mar 05, 2019 at 02:32:43PM +0100, Ard Biesheuvel wrote: > > Sending DEBUG output to the serial port should only be done via > > DebugLib calls, which is in charge of initializing the serial > > port when appropriate. So drop

Re: [edk2] [PATCH 05/10] StandaloneMmPkg/StandaloneMmCoreEntryPoint: drop explicit SerialPortLib call

Hi Ard, On Tue, Mar 05, 2019 at 02:32:43PM +0100, Ard Biesheuvel wrote: > Sending DEBUG output to the serial port should only be done via > DebugLib calls, which is in charge of initializing the serial > port when appropriate. So drop the explicit SerialPortInitialize () > invocation, and rely on

Re: [edk2] [PATCH 06/10] StandaloneMmPkg/Core: permit encapsulated firmware volumes

Reviewed-by: achin.gu...@arm.com On Tue, Mar 05, 2019 at 02:32:44PM +0100, Ard Biesheuvel wrote: > Standalone MM requires 4 KB section alignment for all images, so that > strict permissions can be applied. Unfortunately, this results in a > lot of wasted space, which is usually costly in the

[edk2] EDK II Specifications for edk2-stable201903 tag

Hi Liming and Bob, I see several EDK II specification updates. I do not see consistent updates to the Revision History In the README.md with link to the BZ for the document change. Please make sure all revision histories are up to date with BZ links, and as each BZ is closed put the links to

Re: [edk2] [PATCH 09/10] StandaloneMmPkg/Core: remove legacy boot support

Reviewed-by: achin.gu...@arm.com On Tue, Mar 05, 2019 at 02:32:47PM +0100, Ard Biesheuvel wrote: > Remove the support for booting 'legacy' (i.e., non-UEFI boot) OSes. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ard Biesheuvel > --- >

Re: [edk2] Does ARM platform produce MP protocol?

> On Mar 6, 2019, at 5:22 AM, Ard Biesheuvel wrote: > > On Wed, 6 Mar 2019 at 13:41, Achin Gupta > wrote: >> >> On Wed, Mar 06, 2019 at 10:37:58AM +0100, Ard Biesheuvel wrote: >>> (adding Achin and Charles) >>> >>> On Wed, 6 Mar 2019 at 10:16, Ni, Ray wrote:

Re: [edk2] Any open source EFI app to dump USB descriptors from Shell

For UEFI, you may refer to https://github.com/jyao1/EdkiiShellTool/tree/master/EdkiiShellToolPkg/UsbInfo As cross reference, you may use USBView in windows or lsusb in Linux. Thank you Yao Jiewen > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf

Re: [edk2] [PATCH 10/10] ArmPkg/MmCommunicationDxe: signal architected PI events into MM context

Reviewed-by: achin.gu...@arm.com On Tue, Mar 05, 2019 at 02:32:48PM +0100, Ard Biesheuvel wrote: > PI defines a few architected events that have significance in the MM > context as well as in the non-secure DXE context. So register notify > handlers for these events, and relay them into the

Re: [edk2] [PATCH RESEND 3/3] OvmfPkg/XenSupport: turn off address decoding before BAR sizing

On 03/06/19 15:26, Igor Druzhinin wrote: > On 06/03/2019 13:22, Laszlo Ersek wrote: >> On 03/06/19 13:40, Igor Druzhinin wrote: >>> On Xen, hvmloader firmware leaves address decoding enabled for >>> enumerated PCI device before jumping into OVMF. OVMF seems to >>> expect it to be disabled and

Re: [edk2] [PATCH 07/10] StandaloneMmPkg/Core: dispatch all drivers at init time

Reviewed-by: achin.gu...@arm.com On Tue, Mar 05, 2019 at 02:32:45PM +0100, Ard Biesheuvel wrote: > Instead of deferring dispatch of the remaining MM drivers once the > CPU driver has been dispatched, proceed and dispatch all drivers. > This makes sense for standalone MM, since all dispatchable

Re: [edk2] [PATCH 05/10] StandaloneMmPkg/StandaloneMmCoreEntryPoint: drop explicit SerialPortLib call

On Wed, Mar 06, 2019 at 05:41:30PM +0100, Ard Biesheuvel wrote: > On Wed, 6 Mar 2019 at 17:35, Achin Gupta wrote: > > > > Hi Ard, > > > > On Tue, Mar 05, 2019 at 02:32:43PM +0100, Ard Biesheuvel wrote: > > > Sending DEBUG output to the serial port should only be done via > > > DebugLib calls,

Re: [edk2] [PATCH 08/10] StandaloneMmPkg/Core: drop support for dispatching FVs into MM

Reviewed-by: achin.gu...@arm.com On Tue, Mar 05, 2019 at 02:32:46PM +0100, Ard Biesheuvel wrote: > Remove the support that permits calls into the MM context to dispatch > firmware volumes that are not part of the initial standalone MM firmware > volume. > > Contributed-under: TianoCore

Re: [edk2] [PATCH] MdeModulePkg/SdMmcPciHcDxe: Add V3 64b DMA Support

Ø I verified the patch on SDHC version 3.00 with 64-bit System Address Ø Support. Hope more configurations are available for testing on Eugene's Ø side. This patch works for us. Tested that the V3 64-bit DMA works and verified that addresses above 4GB DMA correctly. Thanks for putting

Re: [edk2] [PATCH] MdeModulePkg/SdMmcPciHcDxe: Add V3 64b DMA Support

Hi Eugene, Thanks for confirming. Can you please validate the v2 patch I sent as well for completeness? Thanks Ashish From: Cohen, Eugene Sent: Wednesday, March 6, 2019 4:05 PM To: Wu, Hao A ; Ashish Singhal ; edk2-devel@lists.01.org Subject: RE: [PATCH] MdeModulePkg/SdMmcPciHcDxe: Add V3

Re: [edk2] [Patch v2 2/4] UefiCpuPkg/RegisterCpuFeaturesLib: Optimize PCD PcdCpuFeaturesUserConfiguration.

Hi Star, Thanks for your comments. It's more clear when mine. Will update it in my next version changes. Also I will add this change info in the upgrade notes. Thanks, Eric > -Original Message- > From: Zeng, Star > Sent: Tuesday, March 5, 2019 5:57 PM > To: Dong, Eric ;

Re: [edk2] [Patch] UefiCpuPkg/MpInitLib: Direct allocate buffer for Wake up Buffer.

Hi Star, This logic seems much complicated than mine. Also after CSM retired from EDKII, we will change this code back to only require allocate buffer below 1M. I will add such notes in the code comments. So I prefer to use my change. Thanks, Eric > -Original Message- > From: Zeng,

Re: [edk2] [PATCH 3/3] MdePkg/BaseSynchronizationLib: Remove inline X86 assembly code

Liming, That does not work either because inline assembly uses compiler specific syntax. Please update with the specific list of functions that you think the inline should be removed to improve maintenance with no impacts in size/perf. The issue you pointed to was around SetJump()/LongJump().

Re: [edk2] [PATCH] MdeModulePkg/SdMmcPciHcDxe: Add V3 64b DMA Support

Tested-by: Eugene Cohen Thanks again. From: Ashish Singhal Sent: Wednesday, March 6, 2019 4:07 PM To: Cohen, Eugene ; Wu, Hao A ; edk2-devel@lists.01.org Subject: RE: [PATCH] MdeModulePkg/SdMmcPciHcDxe: Add V3 64b DMA Support Hi Eugene, Thanks for confirming. Can you please validate the v2

Re: [edk2] [PATCH 3/3] MdePkg/BaseSynchronizationLib: Remove inline X86 assembly code

> On Mar 6, 2019, at 4:41 PM, Kinney, Michael D > wrote: > > Liming, > > That does not work either because inline assembly uses compiler specific > syntax. > > Please update with the specific list of functions that you think the inline > should be removed to improve maintenance with no

Re: [edk2] [PATCH v2] MdeModulePkg/SdMmcPciHcDxe: Add V3 64b DMA Support

Ashish, Thanks for the contribution. Reviewed-by: Hao Wu I will push this one after the release tag is created. Best Regards, Hao Wu > -Original Message- > From: Ashish Singhal [mailto:ashishsin...@nvidia.com] > Sent: Wednesday, March 06, 2019 10:05 PM > To: edk2-devel@lists.01.org >

[edk2] [PATCH 06/10] MdePkg/BaseMemoryLibMmx: Remove .S files for IA32 and X64 arch

.nasm file has been added for X86 arch. .S assembly code is not required any more. https://bugzilla.tianocore.org/show_bug.cgi?id=1594 Cc: Michael D Kinney Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Shenglei Zhang ---

[edk2] [PATCH 07/10] MdePkg/BaseMemoryLibOptDxe: Remove .S files for IA32 and X64 arch

.nasm file has been added for X86 arch. .S assembly code is not required any more. https://bugzilla.tianocore.org/show_bug.cgi?id=1594 Cc: Michael D Kinney Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Shenglei Zhang --- .../BaseMemoryLibOptDxe.inf

[edk2] [PATCH 09/10] MdePkg/BaseMemoryLibRepStr: Remove .S files for IA32 and X64 arch

.nasm file has been added for X86 arch. .S assembly code is not required any more. https://bugzilla.tianocore.org/show_bug.cgi?id=1594 Cc: Michael D Kinney Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Shenglei Zhang --- .../BaseMemoryLibRepStr.inf

[edk2] [PATCH 00/10] Remove .S files for IA32 and X64 arch in MdePkg and UefiCpuPkg

.nasm file has been added for X86 arch. .S assembly code is not required any more. https://bugzilla.tianocore.org/show_bug.cgi?id=1594 Cc: Michael D Kinney Cc: Liming Gao Cc: Eric Dong Cc: Ray Ni Cc: Laszlo Ersek Shenglei Zhang (10): UefiCpuPkg/SmmCpuFeaturesLib: Remove .S files for IA32

[edk2] [PATCH 05/10] MdePkg/BaseLib: Remove .S files for IA32 and X64 arch

.nasm file has been added for X86 arch. .S assembly code is not required any more. https://bugzilla.tianocore.org/show_bug.cgi?id=1594 Cc: Michael D Kinney Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Shenglei Zhang ---

[edk2] [PATCH 01/10] UefiCpuPkg/SmmCpuFeaturesLib: Remove .S files for IA32 and X64 arch

.nasm file has been added for X86 arch. .S assembly code is not required any more. https://bugzilla.tianocore.org/show_bug.cgi?id=1594 Cc: Eric Dong Cc: Ray Ni Cc: Laszlo Ersek Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Shenglei Zhang ---

[edk2] [PATCH 10/10] MdePkg/BaseMemoryLibSse2: Remove .S files for IA32 and X64 arch

.nasm file has been added for X86 arch. .S assembly code is not required any more. https://bugzilla.tianocore.org/show_bug.cgi?id=1594 Cc: Michael D Kinney Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Shenglei Zhang ---

[edk2] [PATCH 08/10] MdePkg/BaseMemoryLibOptPei: Remove .S files for IA32 and X64 arch

.nasm file has been added for X86 arch. .S assembly code is not required any more. https://bugzilla.tianocore.org/show_bug.cgi?id=1594 Cc: Michael D Kinney Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Shenglei Zhang --- .../BaseMemoryLibOptPei.inf

[edk2] [PATCH 02/10] UefiCpuPkg/BaseUefiCpuLib: Remove .S files for IA32 and X64 arch

.nasm file has been added for X86 arch. .S assembly code is not required any more. https://bugzilla.tianocore.org/show_bug.cgi?id=1594 Cc: Eric Dong Cc: Ray Ni Cc: Laszlo Ersek Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Shenglei Zhang ---

[edk2] [PATCH 03/10] UefiCpuPkg/CpuExceptionHandlerLib:Remove.S files for IA32 and X64 arch

.nasm file has been added for X86 arch. .S assembly code is not required any more. https://bugzilla.tianocore.org/show_bug.cgi?id=1594 Cc: Eric Dong Cc: Ray Ni Cc: Laszlo Ersek Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Shenglei Zhang ---

[edk2] [PATCH 04/10] MdePkg/BaseCpuLib: Remove .S files for IA32 and X64 arch

.nasm file has been added for X86 arch. .S assembly code is not required any more. https://bugzilla.tianocore.org/show_bug.cgi?id=1594 Cc: Michael D Kinney Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Shenglei Zhang ---

Re: [edk2] [PATCH 3/3] MdePkg/BaseSynchronizationLib: Remove inline X86 assembly code

Andrew: I want to keep only one implementation. If inline assembly c source is preferred, I suggest to remove its nasm implementation. Thanks Liming From: af...@apple.com [mailto:af...@apple.com] Sent: Tuesday, March 5, 2019 2:44 PM To: Gao, Liming Cc: Zhang, Shenglei ; edk2-devel-01 ;

Re: [edk2] [PATCH] ShellPkg/UefiShellAcpiViewCommandLib: Change the note in uni

Thanks for your careful check. I would update it. Thanks, Zhichao From: Carsey, Jaben Sent: Thursday, March 7, 2019 12:47 AM To: Nariman Poushin Cc: Gao, Zhichao ; edk2-devel@lists.01.org; Gao, Liming Subject: Re: [edk2] [PATCH] ShellPkg/UefiShellAcpiViewCommandLib: Change the note in uni

Re: [edk2] EDK II Specifications for edk2-stable201903 tag

Hi Mike, Yes. the Revision history need to update. I have sent the spec patches v2 which update the Revision History in README.md and table of content in SUMMARY.md for INF/FDF/DSC spec. And I added the BZ in the README.md. Thanks, Bob -Original Message- From: Kinney, Michael D Sent:

[edk2] [edk2-test][Patch 1/1] uefi-sct/SctPkg:Fix flaw in BBTestCreateEventEx_Func_Sub3

The intention of test is to validate the signal sequence among three events with gEfiEventMemoryMapChangeGuid and different Tpl. The call of AllocatePages() causes memorymap change and trigger event Notify. But the test has an assumption that CreateEventEx() will not cause memorymap change itself,

Re: [edk2] [PATCH] MdeModulePkg/SdMmcPciHcDxe: Add V3 64b DMA Support

> -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Cohen, Eugene > Sent: Thursday, March 07, 2019 8:54 AM > To: Ashish Singhal; Wu, Hao A; edk2-devel@lists.01.org > Subject: Re: [edk2] [PATCH] MdeModulePkg/SdMmcPciHcDxe: Add V3 64b > DMA Support

Re: [edk2] [PATCH 3/3] MdePkg/BaseSynchronizationLib: Remove inline X86 assembly code

Thanks for your clarification. Now, we will focus on SetJump/LongJump() first. Thanks Liming From: af...@apple.com [mailto:af...@apple.com] Sent: Wednesday, March 6, 2019 10:45 PM To: Yao, Jiewen Cc: Kinney, Michael D ; Gao, Liming ; edk2-devel-01 Subject: Re: [edk2] [PATCH 3/3]

Re: [edk2] [PATCH 3/3] MdePkg/BaseSynchronizationLib: Remove inline X86 assembly code

> On Mar 6, 2019, at 10:09 PM, Yao, Jiewen wrote: > > Thanks Andrew. > Now I 100% agree with you - I think it is fine to restrict new C inline > assembler, or at least have a very high bar to add anything new. Any new > inline assembler *should also be simple and just be a function

[edk2] [edk2-test][Patch 1/1] uefi-sct/SctPkg:update BlueTooth test with LE support

revisit BlueTooth checkpoint for UEFI2.7 spec update with LE support Change original test to classic/low energy checkpoints Add marco MAX_LENGTH for pre-defined string value (yes or no) in EfiCompliant.ini. Cc: Supreeth Venkatesh Contributed-under: TianoCore Contribution Agreement 1.1

Re: [edk2] [PATCH 3/3] MdePkg/BaseSynchronizationLib: Remove inline X86 assembly code

Thanks Andrew. Now I 100% agree with you - I think it is fine to restrict new C inline assembler, or at least have a very high bar to add anything new. Any new inline assembler *should also be simple and just be a function abstracting a CPU op-code* that is not available to C. This is how we

Re: [edk2] [PATCH 3/3] MdePkg/BaseSynchronizationLib: Remove inline X86 assembly code

Thanks. I also recommend to take a look at MdePkg\Library\BaseSynchronizationLib. That is also complicated and not so readable for me. And we have 8 patches to *fix* the real problem in 2018. Thank you Yao Jiewen From: Gao, Liming Sent: Wednesday, March 6, 2019 11:15 PM To: af...@apple.com;

Re: [edk2] [PATCH 3/3] MdePkg/BaseSynchronizationLib: Remove inline X86 assembly code

> On Mar 6, 2019, at 9:06 PM, Yao, Jiewen wrote: > > HI Mike and Andrew > The problem is maintainability. > > If we have multiple copy of implementation, a developer need verify multiple > copy of implementation, if we make update. Before that, a developer has to be > aware that there is

Re: [edk2] [PATCH 3/3] MdePkg/BaseSynchronizationLib: Remove inline X86 assembly code

HI Mike and Andrew The problem is maintainability. If we have multiple copy of implementation, a developer need verify multiple copy of implementation, if we make update. Before that, a developer has to be aware that there is multiple copy of implementation. - That increases the complexity.

[edk2] [Patch V2 1/1] Document: Add PCD flexible format value EBNF in Fdf.

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=541 This patch is to add flexible PCD value format EBNF into Fdf spec. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Bob Feng Cc: Liming Gao Cc: Yonghong Zhu --- 3_edk_ii_fdf_file_format/32_fdf_definition.md | 25

[edk2] [Patch V2 0/1] Document: Add PCD flexible format value EBNF in Fdf.

V2: Update the revision history in README.md This patch is to add flexible PCD value format EBNF into Fdf spec. Feng, Bob C (1): Document: Add PCD flexible format value EBNF in Fdf. 3_edk_ii_fdf_file_format/32_fdf_definition.md | 25 +