it?
Jeff
-Original Message-
From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo Bonzini
Sent: Tuesday, July 28, 2015 2:52 PM
To: Fan, Jeff; Laszlo Ersek; edk2-de...@ml01.01.org
Cc: Chen Fan; Justen, Jordan L
Subject: Re: [edk2] [PATCH 38/58] UefiCpuPkg: CpuDxe: optionally
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Reviewed-by: Jeff Fan jeff@intel.com
-Original Message-
From: Laszlo Ersek [mailto:ler...@redhat.com]
Sent: Friday, July 24, 2015 7:36 AM
To: edk2-de...@ml01.01.org
Cc: Yao, Jiewen; Fan, Jeff
Subject: [PATCH] IntelFrameworkModulePkg: GenericBdsLib: set Status before use
The recent
Reviewed-by: Jeff Fan jeff@intel.com
-Original Message-
From: Qiu, Shumin
Sent: Tuesday, July 21, 2015 8:51 PM
To: edk2-devel@lists.01.org
Cc: Qiu, Shumin
Subject: [PATCH 6/7] UefiCpuPkg: Add missing PCD usage information in UNI files.
Cc Jeff Fan jeff@intel.com
Contributed
This method may cause SMI storm easily.
In case, some processors already entered into SMM but did not set present bit.
SMM BSP will send additional SMI to them and bring them into SMM again after
they exited from SMM.
Then new SMM BSP will send additional SMI to old SMM BSP again.
Jeff
Original Message-
From: Laszlo Ersek [mailto:ler...@redhat.com]
Sent: Tuesday, October 27, 2015 6:31 AM
To: Kinney, Michael D
Cc: Fan, Jeff; edk2-de...@ml01.01.org; Paolo Bonzini
Subject: Re: [Patch 3/3] UefiCpuPkg/CpuDxe: Place APs into protected mode when
ExitBootService
On 10/26/15 22:5
9, 2015 8:46 PM
To: Fan, Jeff; edk2-de...@ml01.01.org
Cc: Kinney, Michael D
Subject: Re: [edk2] [Patch] UefiCpuPkg/PiSmmCpuDxeSmm: Shouldn't use
gSmst->CurrentlyExecutingCpu
On 10/29/15 09:11, Jeff Fan wrote:
> In ConfigSmmCodeAccessCheck(), we used gSmst->CurrentlyExecutingCpu to
>
I agree with this fix.
Reviewed-by: Jeff Fan <jeff@intel.com>
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Michael
Kinney
Sent: Thursday, October 29, 2015 11:19 AM
To: edk2-devel@lists.01.org
Subject: [edk2] [PATCH 0/2] Add API to
Laszlo,
Thanks your suggestion. I will add the code in commit log.
Jeff
-Original Message-
From: Laszlo Ersek [mailto:ler...@redhat.com]
Sent: Thursday, October 29, 2015 10:43 PM
To: Fan, Jeff; edk2-de...@ml01.01.org
Cc: Kinney, Michael D
Subject: Re: [edk2] [Patch] UefiCpuPkg
It's good!
Reviewed-by: Jeff Fan <jeff@intel.com>
-Original Message-
From: Justen, Jordan L
Sent: Thursday, October 29, 2015 9:33 AM
To: edk2-devel@lists.01.org
Cc: Justen, Jordan L; Fan, Jeff; Laszlo Ersek
Subject: [PATCH 1/6] UefiCpuPkg/CpuDxe: Don't use gBS->Stall
T
Justen
Sent: Thursday, October 29, 2015 9:33 AM
To: edk2-devel@lists.01.org
Cc: Justen, Jordan L; Laszlo Ersek; Fan, Jeff
Subject: [edk2] [PATCH 2/6] UefiCpuPkg/CpuDxe: Ignore extra APs in the system
The PcdCpuMaxLogicalProcessorNumber specifies the maximum number of logical
processors which
Jordan,
CPU ID only could get the max logical processor number supported in current
socket. It cannot handle multi-sockets case.
Yes. We could promote PcdCpuMaxLogicalProcessorNumber to dynamic type. But we
need find one reliable way like you said to set it before CPU MP PEI not only
CPU MP
It's good to me!
Reviewed-by: Jeff Fan <jeff@intel.com>
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Michael
Kinney
Sent: Saturday, October 31, 2015 2:03 AM
To: edk2-devel@lists.01.org
Subject: [edk2] [PATCH] UefiCpuPkg: PiSmmCpu
28, 2015 8:16 PM
To: Fan, Jeff; edk2-de...@ml01.01.org
Cc: Kinney, Michael D; Justen, Jordan L; Chen Fan
Subject: Re: [Patch 2/2] UefiCpuPkg/CpuDxe: Fix one dead lock issue in
ProcessorToIdleState()
On 10/28/15 07:42, Jeff Fan wrote:
> There is one dead lock issue between BSP and AP. AP has
This serial of patches s good to me! Thanks!
Reviewed-by: Jeff Fan <jeff@intel.com>
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Michael
Kinney
Sent: Monday, October 19, 2015 3:45 PM
To: edk2-devel@lists.01.org
Subject: [edk2] [PA
Paolo,
Thanks reporting this spec issue. We will forward it to SDM owner to address it.
Thanks!
Jeff
-Original Message-
From: Paolo Bonzini [mailto:pbonz...@redhat.com]
Sent: Friday, October 16, 2015 4:38 PM
To: Yao, Jiewen; Fan, Jeff; Laszlo Ersek; edk2-de...@ml01.01.org
Cc: Kinney
Thanks Laszlo,
If there is some confusion in SDM, we could inform SDM owner to make a update.
Thanks!
Jeff
-Original Message-
From: Laszlo Ersek [mailto:ler...@redhat.com]
Sent: Friday, October 16, 2015 2:25 AM
To: Fan, Jeff; edk2-de...@ml01.01.org
Cc: Kinney, Michael D; Paolo Bonzini
It's good!
Reviewed-by: Jeff Fan <jeff@intel.com>
-Original Message-
From: Kinney, Michael D
Sent: Friday, October 16, 2015 10:54 AM
To: Kinney, Michael D; edk2-devel@lists.01.org; Fan, Jeff
Cc: Paolo Bonzini; Laszlo Ersek
Subject: RE: [edk2] [PATCH v2 00/16] UefiCpuPkg: Add C
Ersek & Bonzini,
>From SDM 34.5.2, SMI Handler Operating Mode Switching.
"Any required change to operating mode is performed by the RSM instruction;
there is no need for the SMI
handler to change modes explicitly prior to executing RSM."
So, I don't think we need to go back to 32-bit PM before
Reviewed-by: Jeff Fan <jeff@intel.com>
-Original Message-
From: Laszlo Ersek [mailto:ler...@redhat.com]
Sent: Saturday, October 10, 2015 5:58 AM
To: edk2-de...@ml01.01.org
Cc: Fan, Jeff; Chen Fan; Justen, Jordan L; Kinney, Michael D
Subject: [PATCH v2 02/41] UefiCpuPkg:
Agree. I will fix them in v3 patches.
-Original Message-
From: Tian, Feng
Sent: Wednesday, November 18, 2015 8:42 AM
To: Fan, Jeff; edk2-devel@lists.01.org
Cc: Tian, Feng
Subject: RE: [edk2] [Patch v2 00/13] UefiCpuPkg/MtrrLib: Add API
MtrrSetMemoryAttributeInMtrrSettings()
I found
Thanks. My compare tool skipped the build directory. I think I need to use git
to sync all patches. :-)
Reviewed-By: Jeff Fan <jeff@intel.com>
-Original Message-
From: Mike Maslenkin [mailto:mike.maslen...@gmail.com]
Sent: Wednesday, December 02, 2015 11:17 PM
To: e
Reviewed-by: Jeff Fan <jeff@intel.com>
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Liming
Gao
Sent: Tuesday, December 15, 2015 1:45 PM
To: edk2-devel@lists.01.org
Subject: [edk2] [Patch 4/4] SourceLevelDebugPkg: Correct gEfiDebugAge
Reviewed-by: Jeff Fan <jeff@intel.com>
-Original Message-
From: Justen, Jordan L
Sent: Saturday, December 05, 2015 4:13 AM
To: edk2-devel@lists.01.org
Cc: Justen, Jordan L; Kinney, Michael D; Fan, Jeff
Subject: [PATCH v2 09/20] IntelFrameworkPkg: Convert all .uni files to
Reviewed-by: Jeff Fan <jeff@intel.com>
-Original Message-
From: Justen, Jordan L
Sent: Saturday, December 05, 2015 4:14 AM
To: edk2-devel@lists.01.org
Cc: Justen, Jordan L; Fan, Jeff
Subject: [PATCH v2 19/20] UefiCpuPkg: Convert all .uni files to utf-8
To convert these files
Mike,
I sent the patch to fix x64 version issue. Please help to review it.
Thanks!
Jeff
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Fan, Jeff
Sent: Thursday, December 17, 2015 8:19 AM
To: Kinney, Michael D; edk2-devel@lists.01.org
Cc: Justen
I agree with 2). New function is better.
Jeff
-Original Message-
From: Yao, Jiewen
Sent: Wednesday, December 16, 2015 8:49 AM
To: Samer El-Haj-Mahmoud; edk2-devel@lists.01.org
Cc: Samer El-Haj-Mahmoud; Fan, Jeff
Subject: RE: [edk2] [PATCH] IntelFrameworkModulePkg : Allow ACPI tables
Reviewed-by: Jeff Fan <jeff@intel.com>
-Original Message-
From: Justen, Jordan L
Sent: Saturday, December 05, 2015 4:13 AM
To: edk2-devel@lists.01.org
Cc: Justen, Jordan L; Fan, Jeff
Subject: [PATCH v2 08/20] IntelFrameworkModulePkg: Convert all .uni files to
utf-8
To c
Reviewed-by: Jeff Fan <jeff@intel.com>
-Original Message-
From: Ni, Ruiyu
Sent: Friday, January 08, 2016 3:14 PM
To: edk2-devel@lists.01.org
Cc: Ni, Ruiyu; Fan, Jeff
Subject: [Patch] MdeModulePkg: Fix GraphicsConsole driver resolution out of
sync issue
When the GOP doesn't s
uptHandler ()
implementation.
Jeff
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Sergey
Tretiyak
Sent: Tuesday, December 29, 2015 4:28 PM
To: Fan, Jeff
Cc: edk2-devel@lists.01.org
Subject: Re: [edk2] Registering custom exception/interrupt handler function.
1.
Could you post the exception message from serial port? Then we could know if
UefiCpuPkg/Library/CpuExceptionHandlerLib is used or not?
Jeff
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Sergey
Tretiyak
Sent: Sunday, December 20, 2015 6:05 PM
Reviewed-by: Jeff Fan <jeff@intel.com>
-Original Message-
From: Kinney, Michael D
Sent: Wednesday, December 23, 2015 7:51 AM
To: edk2-devel@lists.01.org
Cc: Fan, Jeff
Subject: [Patch] UefiCpuPkg/PiSmmCpuDxeSmm: Correct CPUID leaf used to detect
SMM mode
Use Bit 29 of CPUI
Reviewed-by: Jeff Fan <jeff@intel.com>
-Original Message-
From: Kinney, Michael D
Sent: Wednesday, December 23, 2015 7:51 AM
To: edk2-devel@lists.01.org
Cc: Fan, Jeff
Subject: [Patch] UefiCpuPkg/PiSmmCpuDxeSmm: Fix failure when PcdCpuSmmDebug is
TRUE
If PcdCpuSmmDebug
.com]
Sent: Monday, December 21, 2015 8:06 PM
To: Fan, Jeff
Cc: edk2-devel@lists.01.org
Subject: Re: [edk2] Registering custom exception/interrupt handler function.
It is used, I get the message printed from DumpCpuContent() in
ArchExceptionHandler.c, that starts with " X64 Exception Typ
0FFF, TR -
FXSAVE_STATE - 46AD1240
Find PE image (path to pdb file...) (ImageBase=39F36000,
EntryPoint=39F362C0)
On Mon, Dec 28, 2015 at 9:56 AM, Fan, Jeff
<jeff@intel.com<mailto:jeff@intel.com>> wrote:
Sorry. I missed th
Reviewed-by: Jeff Fan <jeff@intel.com>
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Liming
Gao
Sent: Wednesday, December 23, 2015 5:57 PM
To: edk2-devel@lists.01.org
Subject: [edk2] [Patch 8/8] IntelFrameworkModulePkg: Remove the und
Reviewed-by: Jeff Fan <jeff@intel.com>
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Liming
Gao
Sent: Wednesday, December 23, 2015 5:57 PM
To: edk2-devel@lists.01.org
Subject: [edk2] [Patch 6/8] UefiCpuPkg: Add the missing modu
Mike,
Thanks your testing. I will add your comment when check-in the code.
Jeff
-Original Message-
From: Kinney, Michael D
Sent: Friday, December 18, 2015 10:20 AM
To: Fan, Jeff; edk2-devel@lists.01.org; Kinney, Michael D
Cc: Tian, Feng; Justen, Jordan L
Subject: RE: [Patch] UefiCpuPkg
Reviewed-by: Jeff Fan <jeff@intel.com>
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Liming
Gao
Sent: Wednesday, December 16, 2015 6:17 PM
To: edk2-devel@lists.01.org
Subject: [edk2] [Patch 1/3] DuetPkg: Fix GCC error to
Reviewed-by: Jeff Fan <jeff@intel.com>
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Liming
Gao
Sent: Wednesday, December 16, 2015 6:18 PM
To: edk2-devel@lists.01.org
Subject: [edk2] [Patch 2/3] DuetPkg: Fix GCC error to
Reviewed-by: Jeff Fan <jeff@intel.com>
-Original Message-
From: Yao, Jiewen
Sent: Thursday, November 26, 2015 8:34 PM
To: edk2-de...@ml01.01.org
Cc: Yao, Jiewen; Fan, Jeff; Kinney, Michael D
Subject: [patch] UefiCpuPkg/CpuExceptionHandlerLib: Skip CR restore for SMM
handler.
Move IDT table to C code is very good!
I think EFIAPI is no longer required for InitializeIDTSmmStackGuard().
Reviewed-by: Jeff Fan <jeff@intel.com>
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of jiewen
yao
Sent: Thursday, Novem
Reviewed-by: Jeff Fan <jeff@intel.com>
-Original Message-
From: Yao, Jiewen
Sent: Wednesday, November 25, 2015 12:51 PM
To: edk2-de...@ml01.01.org
Cc: Yao, Jiewen; Fan, Jeff; Kinney, Michael D
Subject: [patch] UefiCpuPkg/PiSmmCpu: Move IDT to page aligned memory.
The previo
Jiewen,
Could you combine this patch with [patch] UefiCpuPkg/PiSmmCpu: Eliminate
EFI_IMAGE_MACHINE_TYPE_SUPPORTED(EFI_IMAGE_MACHINE_X64)?
Reviewed-by: Jeff Fan <jeff@intel.com>
Jeff
-Original Message-
From: Yao, Jiewen
Sent: Monday, November 23, 2015 10:15 PM
To: e
Sent: Tuesday, November 24, 2015 3:58 PM
To: Fan, Jeff; edk2-devel@lists.01.org; Kinney, Michael D
Cc: Tian, Feng
Subject: RE: [edk2] [Patch 1/3] UefiCpuPkg/CpuMpPei: Get APIC ID from CPUID if
x2APIC supported
Jeff,
Yes. That is ASSERT() location I was suggesting.
Does is also makes sense
ney, Michael D
Sent: Tuesday, November 24, 2015 3:00 PM
To: Fan, Jeff; edk2-devel@lists.01.org; Kinney, Michael D
Cc: Tian, Feng
Subject: RE: [edk2] [Patch 1/3] UefiCpuPkg/CpuMpPei: Get APIC ID from CPUID if
x2APIC supported
Jeff,
Can you move the ASSERT() for no APIC ID available into GetX2ApicIdFromCp
0B should be
supported because x2APIC ID could be gotten from CPUID.(EAX=0BH, ECX=0H):EDX.
Otherwise, we cannot get x2APIC ID before we enabled x2APIC mode.
Jeff
-Original Message-
From: Kinney, Michael D
Sent: Tuesday, November 24, 2015 3:58 PM
To: Fan, Jeff; edk2-devel@lists.01.org; Kinney
Laszlo,
I agree. Please go ahead to check-in this serial of patches. We may revisit it
if we receive other concern in the future.
Thanks!
Jeff
-Original Message-
From: Laszlo Ersek [mailto:ler...@redhat.com]
Sent: Thursday, June 02, 2016 6:13 PM
To: Fan, Jeff; edk2-devel-01
Cc: Yao
Reviewed-by: Jeff Fan <jeff@intel.com>
Good suggestion to set PcdCpuSmmStackGuard default to TRUE.
But please hold on the check-in in UefiCpuPkg.dec till next week, I want more
platforms to be validated on this change.
-Original Message-
From: Laszlo Ersek [mail
Thanks your comments. I will check-in the patches after updated them per your
comments.
-Original Message-
From: Tian, Feng
Sent: Wednesday, June 01, 2016 1:56 PM
To: Fan, Jeff; edk2-devel@lists.01.org
Cc: Tian, Feng
Subject: RE: [edk2] [Patch 0/9] UefiCpuPkg/PeiCpuExceptionHandlerLib
Laszlo,
Have you any clue on bisect this issue?
SmiDefaultPFHandler() is used to dynamically setup page entry for those address
> 4GBytes.
If your platform is really accessing > 4GBytes address, Page Fault happened
does make sense.
Otherwise, please check PFAddress value to understand why
Reviewed-by: Jeff Fan <jeff@intel.com>
-Original Message-
From: Yao, Jiewen
Sent: Wednesday, June 29, 2016 10:30 AM
To: edk2-devel@lists.01.org
Cc: Fan, Jeff; Kinney, Michael D
Subject: [PATCH] MdeModulePkg/PiSmmCore: Replace BASE_4GB with MAX_ADDRESS
check.
PI specification
Reviewed-by: Jeff Fan <jeff@intel.com>
-Original Message-
From: Kinney, Michael D
Sent: Wednesday, February 24, 2016 2:00 AM
To: edk2-devel@lists.01.org
Cc: Fan, Jeff; Yao, Jiewen
Subject: [Patch v2 2/2] UefiCpuPkg/Cpuid: Add UEFI CPUID application
Add UEFI application to Uefi
Reviewed-by: Jeff Fan <jeff@intel.com>
-Original Message-
From: Kinney, Michael D
Sent: Wednesday, February 24, 2016 2:00 AM
To: edk2-devel@lists.01.org
Cc: Fan, Jeff; Yao, Jiewen
Subject: [Patch v2 1/2] UefiCpuPkg/Cpuid.h: Add CPUID leaf/sub-leaf defines and
structures
Add
It seems missing .uni files for Cpuid App module.
-Original Message-
From: Kinney, Michael D
Sent: Tuesday, February 23, 2016 5:49 AM
To: edk2-devel@lists.01.org
Cc: Fan, Jeff; Yao, Jiewen
Subject: [Patch 0/2] UefiCpuPkg: Update CPUID include file and add CPUID app
This patch series
Reviewed-by: Jeff Fan <jeff@intel.com>
-Original Message-
From: Wu, Hao A
Sent: Tuesday, January 19, 2016 11:44 AM
To: edk2-devel@lists.01.org; Fan, Jeff; Gao, Liming; Tian, Hot
Cc: Wu, Hao A
Subject: [PATCH] Maintainers.txt: Update maintainers for SourceLevelDebugPkg
Contr
Reviewed-by: Jeff Fan <jeff@intel.com>
-Original Message-
From: Wu, Hao A
Sent: Tuesday, February 16, 2016 11:10 AM
To: edk2-devel@lists.01.org; Fan, Jeff; Gao, Liming; Kinney, Michael D
Cc: Wu, Hao A
Subject: [PATCH] MdePkg: Add invocation register support in SMM Communication
Reviewed-by: Jeff Fan <jeff@intel.com>
-Original Message-
From: Kinney, Michael D
Sent: Friday, February 19, 2016 3:42 AM
To: edk2-devel@lists.01.org
Cc: Fan, Jeff; Yao, Jiewen
Subject: [Patch] UefiCpuPkg/PiSmmCpuDxeSmm: Add EFIAPI to
CheckFeatureSupported()
The fu
n used as
> an EFI_AP_SERVICE must use EFIAPI calling convention.
I think "EFI_AP_SERVICE" should be "EFI_AP_PROCEDURE" here.
>
> Cc: Jeff Fan <jeff@intel.com>
> Cc: Jiewen Yao <jiewen@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> S
Reviewed-by: Jeff Fan <jeff@intel.com>
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Michael
Kinney
Sent: Friday, February 19, 2016 10:36 AM
To: edk2-devel@lists.01.org
Cc: Yao, Jiewen; Fan, Jeff
Subject: [edk2] [Patch] Uefi
Reviewed-by: Jeff Fan <jeff@intel.com>
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Michael
Kinney
Sent: Friday, February 19, 2016 9:54 AM
To: edk2-devel@lists.01.org
Cc: Yao, Jiewen; Laszlo Ersek; Fan, Jeff
Subject: [edk2] [Pa
Mike,
One more comment. Please add the @param as blow in CheckFeatureSupported()'s
function header.
@param[in,out] Buffer The pointer to private data buffer.
Thanks!
Jeff
-Original Message-
From: Fan, Jeff
Sent: Friday, February 19, 2016 3:54 PM
To: Michael Kinney; edk2-devel
Reviewed-by: Jeff Fan <jeff@intel.com> for this serial of patches.
-Original Message-
From: Kinney, Michael D
Sent: Saturday, March 12, 2016 8:09 AM
To: edk2-devel@lists.01.org
Cc: Fan, Jeff; Yao, Jiewen
Subject: [Patch v2 00/21] UefiCpuPkg/Include: Add MSR include files
Add i
Reviewed-by: Jeff Fan <jeff@intel.com>
VS2013 build pass.
-Original Message-
From: Laszlo Ersek [mailto:ler...@redhat.com]
Sent: Friday, April 08, 2016 6:22 PM
To: edk2-devel-01
Cc: Justen, Jordan L; Ni, Ruiyu; Fan, Jeff; Mark
Subject: [PATCH 1/1] UefiCpuPkg: CpuIo2Dxe: op
...@lists.01.org] On Behalf Of Laszlo
Ersek
Sent: Friday, April 08, 2016 5:52 AM
To: edk2-devel-01
Cc: Ni, Ruiyu; Justen, Jordan L; Fan, Jeff; Mark
Subject: [edk2] [PATCH] UefiCpuPkg: CpuIo2Dxe: optimize FIFO reads and writes
of IO ports
* Short description:
The CpuIoServiceRead
minimize the bus traffic required to service locks.
Cc: Michael Kinney <michael.d.kin...@intel.com>
Cc: Liming Gao <liming@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jeff Fan <jeff@intel.com>
---
.../BaseSync
Reviewed-by: Jeff Fan <jeff@intel.com>
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo
Ersek
Sent: Thursday, March 24, 2016 6:37 PM
To: edk2-devel-01
Cc: Ni, Ruiyu; Tian, Feng; Ard Biesheuvel; Wu, Hao A; Justen, Jordan L; Andrew
: Feng Tian <feng.t...@intel.com>
Cc: Michael Kinney <michael.d.kin...@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jeff Fan <jeff@intel.com>
---
UefiCpuPkg/CpuMpPei/CpuMpPei.c | 7 +-
UefiCpuPkg/CpuMpPei/CpuMpPei.h | 3 +-
U
Reviewed-off-by: Jeff Fan <jeff@intel.com>
-Original Message-
From: Wu, Hao A
Sent: Tuesday, April 05, 2016 2:55 PM
To: edk2-devel@lists.01.org; Fan, Jeff; Gao, Liming; Kinney, Michael D
Cc: Wu, Hao A
Subject: [PATCH V2] MdePkg Cper.h: Add missing structure for 'Processor
Reviewed-off-by: Jeff Fan <jeff@intel.com>
-Original Message-
From: Ni, Ruiyu
Sent: Wednesday, March 23, 2016 2:16 PM
To: edk2-devel@lists.01.org
Cc: Ni, Ruiyu; Fan, Jeff
Subject: [Patch] MdeModulePkg/PciBus: Should reserve enough bus number for HPC
When there is no bridge
Thanks your report. This is a bug.
We will send the patch to fix it soon. Moreover, PEBS feature is not required
for SmmProfile and only BTS feature support is enough.
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
Shifflett, Joseph
Sent:
Mike,
We could use SmmCpuFeaturesInitializeProcessor ()'s input parameter "IsMonarch"
for BSP identification instead of (ProcessorInfo->StatusFlag &
PROCESSOR_AS_BSP_BIT) to simply the code.
Reviewed-by: Jeff Fan <jeff@intel.com>
Jeff
-Original Message-
:08 AM
To: edk2-devel@lists.01.org
Cc: Fan, Jeff; Yao, Jiewen; Tian, Feng
Subject: [Patch V2 1/2] UefiCpuPkg/SmmCpuFeaturesLib: Add SMRR
PhysBase/PhysMask fields check
SMRR range size and alignment should follow the rules like MTRR:
a. The minimum range size is 4 KBytes and the base address
Reviewed-by: Jeff Fan <jeff@intel.com>
-Original Message-
From: Kinney, Michael D
Sent: Thursday, May 19, 2016 5:19 AM
To: edk2-devel@lists.01.org
Cc: Fan, Jeff; Yao, Jiewen; Tian, Feng
Subject: [Patch V3 2/2] QuarkSocPkg/SmmCpuFeaturesLib: Add SMRR
PhysBase/PhysMask fields
Reviewed-by: Jeff Fan <jeff@intel.com>
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ruiyu Ni
Sent: Tuesday, May 17, 2016 10:04 AM
To: edk2-devel@lists.01.org
Cc: Ni, Ruiyu
Subject: [edk2] [Patch 0/4] MdeModulePkg/PciBus Do not impr
To: Fan, Jeff; edk2-de...@ml01.01.org
Cc: Kinney, Michael D; Tian, Feng
Subject: Re: [edk2] [Patch v3 02/40] UefiCpuPkg/MpInitLib: Add microcode
definitions defined in IA32 SDM
On 07/25/16 04:52, Jeff Fan wrote:
> Add microcode definitions defined in Intel(R) 64 and IA-32
> Architectures So
Laszlo,
I added my comments after [Jeff] for your each comment.
Thanks!
Jeff
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo
Ersek
Sent: Monday, July 25, 2016 10:27 PM
To: Fan, Jeff; edk2-de...@ml01.01.org
Cc: Kinney, Michael D; Tian
Laszlo,
Agree, I will update it in v4.
Jeff
-Original Message-
From: Laszlo Ersek [mailto:ler...@redhat.com]
Sent: Monday, July 25, 2016 9:24 PM
To: Fan, Jeff; edk2-de...@ml01.01.org
Cc: Kinney, Michael D; Tian, Feng
Subject: Re: [edk2] [Patch v3 03/40] UefiCpuPkg/CpuS3DataDxe: Move
-
From: Laszlo Ersek [mailto:ler...@redhat.com]
Sent: Monday, July 25, 2016 11:44 PM
To: Fan, Jeff; edk2-de...@ml01.01.org
Cc: Kinney, Michael D; Justen, Jordan L; Tian, Feng
Subject: Re: [edk2] [Patch v3 34/40] OvmfPkg: Add MpInitLib reference in DSC
files.
On 07/25/16 04:52, Jeff Fan wrote
Laszlo,
I added my comments after [Jeff] for your each comment.
Thanks!
Jeff
-Original Message-
From: Laszlo Ersek [mailto:ler...@redhat.com]
Sent: Monday, July 25, 2016 9:53 PM
To: Fan, Jeff; edk2-de...@ml01.01.org
Cc: Kinney, Michael D; Tian, Feng
Subject: Re: [edk2] [Patch v3 04/40
Laszlo,
I added my comments after [Jeff] for your each comment.
Thanks!
Jeff
-Original Message-
From: Laszlo Ersek [mailto:ler...@redhat.com]
Sent: Monday, July 25, 2016 11:33 PM
To: Fan, Jeff
Cc: edk2-de...@ml01.01.org; Kinney, Michael D; Tian, Feng
Subject: Re: [edk2] [Patch v3 06/40
Laszlo,
-Original Message-
From: Laszlo Ersek [mailto:ler...@redhat.com]
Sent: Tuesday, July 26, 2016 4:31 PM
To: Fan, Jeff; edk2-de...@ml01.01.org
Cc: Kinney, Michael D; Tian, Feng
Subject: Re: [edk2] [Patch v3 04/40] UefiCpuPkg/MpInitLib: Add MP Initialize
library class definition
Laszlo,
Your method works for me. :-)
Thanks!
Jeff
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo
Ersek
Sent: Tuesday, July 26, 2016 5:19 PM
To: Fan, Jeff; edk2-de...@ml01.01.org
Cc: Kinney, Michael D; Justen, Jordan L; Tian, Feng
. But the PiSmmCpuDxeSmm
hardcode it to 0x20.
I will try it fix it tomorrow and feedback to you.
Thanks your support!
Jeff
-Original Message-
From: Laszlo Ersek [mailto:ler...@redhat.com]
Sent: Thursday, July 28, 2016 9:24 PM
To: Fan, Jeff; edk2-de...@ml01.01.org
Subject: Re: [edk2] [Patch v3 00/40] MP
Giri,
I added my feedback in [Jeff] in your last mail body.
And I agree with your current comments on other patches. I will update the code
per your comments in v2 patches list.
Thanks!
Jeff
-Original Message-
From: Mudusuru, Giri P
Sent: Friday, July 22, 2016 12:33 PM
To: Fan, Jeff
Reviewed-by: Jeff Fan <jeff@intel.com>
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Liming
Gao
Sent: Thursday, July 28, 2016 4:46 PM
To: edk2-devel@lists.01.org
Subject: [edk2] [Patch 2/3] MdePkg PeiDxePostCodeLibReportStatusCode: C
-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo
Ersek
Sent: Thursday, July 28, 2016 11:21 PM
To: Fan, Jeff
Cc: edk2-de...@ml01.01.org
Subject: Re: [edk2] [Patch v3 00/40] MP Initialize Library
On 07/28/16 15:55, Fan, Jeff wrote:
> Laszlo,
>
> Ma
and consist with other CpuExceptionHandlerLib instance.
Thanks!
Jeff
-Original Message-
From: Laszlo Ersek [mailto:ler...@redhat.com]
Sent: Wednesday, July 13, 2016 8:18 AM
To: edk2-devel-01
Cc: Fan, Jeff; Justen, Jordan L; Kinney, Michael D
Subject: [PATCH v2 4/5] OvmfPkg: include
Reviewed-by: Jeff Fan <jeff@intel.com>
-Original Message-
From: Laszlo Ersek [mailto:ler...@redhat.com]
Sent: Wednesday, July 13, 2016 8:18 AM
To: edk2-devel-01
Cc: Fan, Jeff; Justen, Jordan L; Kinney, Michael D
Subject: [PATCH v2 3/5] OvmfPkg: remove PcdS3AcpiReservedMemo
Reviewed-by: Jeff Fan <jeff@intel.com>
-Original Message-
From: Laszlo Ersek [mailto:ler...@redhat.com]
Sent: Wednesday, July 13, 2016 8:18 AM
To: edk2-devel-01
Cc: Fan, Jeff; Justen, Jordan L; Kinney, Michael D
Subject: [PATCH v2 2/5] OvmfPkg/PlatformPei: rebase and
Reviewed-by: Jeff Fan <jeff@intel.com>
-Original Message-
From: Laszlo Ersek [mailto:ler...@redhat.com]
Sent: Wednesday, July 13, 2016 10:37 PM
To: edk2-devel-01
Cc: Fan, Jeff; Justen, Jordan L; Kinney, Michael D
Subject: [PATCH v3 0/5] OvmfPkg: program MSR_IA32_FEATURE_CONTRO
display from
MtrrSetAllMtrrs().
Thanks!
Jeff
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Brian J.
Johnson
Sent: Thursday, July 14, 2016 2:36 AM
To: Laszlo Ersek; Kinney, Michael D; Fan, Jeff; edk2-de...@ml01.01.org
Cc: Tian, Feng
Subject: Re
Fixed typo: *add* whitespace. :-)
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Fan, Jeff
Sent: Thursday, July 14, 2016 9:15 AM
To: Mudusuru, Giri P; edk2-de...@ml01.01.org
Cc: Kinney, Michael D; Tian, Feng
Subject: Re: [edk2] [Patch v3 4/7
Thanks! I will add one whitespace before eax in comments when commit.
-Original Message-
From: Mudusuru, Giri P
Sent: Wednesday, July 13, 2016 11:21 PM
To: Fan, Jeff; edk2-de...@ml01.01.org
Cc: Tian, Feng; Kinney, Michael D
Subject: RE: [Patch v3 2/7] UefiCpuPkg/CpuMpPei/Ia32: Use
Reviewed-by: Jeff Fan <jeff@intel.com>
-Original Message-
From: Laszlo Ersek [mailto:ler...@redhat.com]
Sent: Wednesday, July 13, 2016 10:37 PM
To: edk2-devel-01
Cc: Fan, Jeff; Justen, Jordan L; Kinney, Michael D
Subject: [PATCH v3 4/5] OvmfPkg: include UefiCpuPkg/Cp
Thanks! I will remove white space after "," in comments when commit.
-Original Message-
From: Mudusuru, Giri P
Sent: Wednesday, July 13, 2016 11:42 PM
To: Fan, Jeff; edk2-de...@ml01.01.org
Cc: Tian, Feng; Kinney, Michael D
Subject: RE: [Patch v3 4/7] UefiCpuPkg/CpuMpPe
-Original Message-
From: Laszlo Ersek [mailto:ler...@redhat.com]
Sent: Friday, July 08, 2016 5:45 PM
To: Fan, Jeff; edk2-de...@ml01.01.org
Cc: Kinney, Michael D; Tian, Feng
Subject: Re: [Patch] UefiCpuPkg/CpuDxe: StartupAllAPs in parallel mode
On 07/08/16 10:59, Fan, Jeff wrote:
> Las
.
Maybe, we could add this note in UefiCpuPkg/Library/MtrrLib/MtrrLib.c.
How do you think it?
Thanks!
Jeff
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo
Ersek
Sent: Wednesday, July 13, 2016 2:21 PM
To: Fan, Jeff; edk2-de...@ml01.01.org
<michael.d.kin...@intel.com>; edk2-de...@ml01.01.org;
Fan, Jeff <jeff@intel.com>
Cc: Tian, Feng <feng.t...@intel.com>
Subject: Re: [edk2] [Patch] UefiCpuPkg/PiSmmCpuDxeSmm: SMM_CPU_DATA_BLOCK is
not cleared
On 07/19/16 04:58, Michael Kinney wrote:
> From: Jeff Fa
Laszlo,
Good suggestion! I could exchange the commit order of Patch 1/4 and Patch 2/4.
Thanks!
Jeff
-Original Message-
From: Laszlo Ersek [mailto:ler...@redhat.com]
Sent: Tuesday, July 19, 2016 6:48 PM
To: Fan, Jeff <jeff@intel.com>; edk2-de...@ml01.01.org
Cc: Kinney, Mic
1 - 100 of 343 matches
Mail list logo