Re: [edk2] [Patch] BaseTools: Allow decimal values in the EDK II meta-data file.

2015-11-08 Thread Gao, Liming
Reviewed-by: Liming Gao > -Original Message- > From: Zhu, Yonghong > Sent: Tuesday, November 03, 2015 1:01 PM > To: edk2-devel@lists.01.org > Cc: Gao, Liming > Subject: [Patch] BaseTools: Allow decimal values in the EDK II meta-data file. > > Because the EDK II

Re: [edk2] [Patch 0/4] AppPkg/Python: Port Python 2.7.10 to EDK II

2015-11-08 Thread Gao, Liming
Scott > Duplichan > Sent: Friday, November 06, 2015 10:38 PM > To: Gao, Liming; 'Daryl McDaniel' > Cc: edk2-de...@ml01.01.org > Subject: Re: [edk2] [Patch 0/4] AppPkg/Python: Port Python 2.7.10 to EDK II > > Hello Liming, > > I see what you mean. With Microsoft Out

Re: [edk2] [PATCH] BaseTools GCC: move PECOFF_HEADER_SIZE definition before LD script

2015-11-09 Thread Gao, Liming
Reviewed-by: Liming Gao -Original Message- From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] Sent: Monday, November 9, 2015 4:34 PM To: edk2-devel@lists.01.org; Gao, Liming; Zhu, Yonghong Cc: Hao, Xudong; Ard Biesheuvel Subject: [PATCH] BaseTools GCC: move PECOFF_HEADER_SIZE

Re: [edk2] MdeModulePkg: Fix Xcode 6.3.2/clang compilation issues.

2015-11-10 Thread Gao, Liming
Andrew: The patch is missing. From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Andrew Fish Sent: Tuesday, November 10, 2015 3:18 PM To: edk2-devel Cc: Tian, Feng Subject: [edk2] MdeModulePkg: Fix Xcode 6.3.2/clang compilation issues. Please review the following patches as

Re: [edk2] MdePkg: Enable Xcode build of BaseLib without

2015-11-10 Thread Gao, Liming
Reviewed-by: Liming Gao > -Original Message- > From: af...@apple.com [mailto:af...@apple.com] > Sent: Tuesday, November 10, 2015 3:18 PM > To: edk2-devel > Cc: Gao, Liming; Kinney, Michael D > Subject: MdePkg: Enable Xcode build of BaseLib without > > Please re

Re: [edk2] Authentication status for signed FVs extracted in PEI

2015-11-10 Thread Gao, Liming
Eugene: Another idea is to update FV HOB to include authentication status instead of adding FV HOB3. The consumer code can check FV HOB Length to know whether FV HOB includes authentication status. Thanks Liming > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.

Re: [edk2] MdePkg: Enable Xcode build of BaseLib without

2015-11-10 Thread Gao, Liming
This patch is committed at r18766. Thanks Liming From: af...@apple.com [mailto:af...@apple.com] Sent: Tuesday, November 10, 2015 11:31 PM To: Gao, Liming Cc: edk2-devel; Kinney, Michael D Subject: Re: MdePkg: Enable Xcode build of BaseLib without On Nov 10, 2015, at 12:22 AM, Gao, Liming

Re: [edk2] [Patch] BaseTools/GenFw: add new option to not zero PE/COFF optional header fields

2015-11-10 Thread Gao, Liming
Reviewed-by: Liming Gao > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Yonghong Zhu > Sent: Monday, November 09, 2015 3:33 PM > To: edk2-devel@lists.01.org > Cc: Gao, Liming; carl.mil...@pnnl.gov > Subject: [edk2] [P

Re: [edk2] MdePkg: Enable Xcode build of BaseLib without

2015-11-10 Thread Gao, Liming
chain, because nasm compiler has one issue to generate Debug Format. Do you know the latest status for it? Thanks Liming > -Original Message- > From: af...@apple.com [mailto:af...@apple.com] > Sent: Wednesday, November 11, 2015 12:25 PM > To: Justen, Jordan L > Cc: Gao,

Re: [edk2] [patch] MdeModulePkg:Modify the pointer type.

2015-11-11 Thread Gao, Liming
Reviewed-by: Liming Gao > -Original Message- > From: Bi, Dandan > Sent: Monday, November 09, 2015 2:30 PM > To: Gao, Liming; Dong, Eric; edk2-devel@lists.01.org > Subject: [patch] MdeModulePkg:Modify the pointer type. > > Previously the pointer type is EFI_IFR_FORM

Re: [edk2] [PATCH] MdeModulePkg PeiCore: PEI dispatcher need retry to process NOT_DISPATCHED FV

2015-11-12 Thread Gao, Liming
Reviewed-by: Liming Gao > -Original Message- > From: Zeng, Star > Sent: Wednesday, November 11, 2015 6:07 PM > To: edk2-devel@lists.01.org > Cc: Gao, Liming > Subject: [PATCH] MdeModulePkg PeiCore: PEI dispatcher need retry to process > NOT_DISPATCHED FV > &g

Re: [edk2] [Patch] BaseTools/toolsetup.bat: fixed the error when the path contains space

2015-11-16 Thread Gao, Liming
Reviewed-by: Liming Gao -Original Message- From: Zhu, Yonghong Sent: Thursday, November 12, 2015 4:24 PM To: edk2-devel@lists.01.org Cc: Gao, Liming; carl.mil...@pnnl.gov Subject: [Patch] BaseTools/toolsetup.bat: fixed the error when the path contains space when the path contains

Re: [edk2] [Patch] BaseTools: Fix two warning reported in the make phase.

2015-11-16 Thread Gao, Liming
Reviewed-by: Liming Gao -Original Message- From: Zhu, Yonghong Sent: Thursday, November 12, 2015 4:22 PM To: edk2-devel@lists.01.org Cc: Gao, Liming; heyi@linaro.org Subject: [Patch] BaseTools: Fix two warning reported in the make phase. when we make BaseTools, it report warnings

Re: [edk2] [PATCH] MdeModulePkg PeiCore: PeiInstallPeiMemory improper ASSERT test on second call

2015-11-17 Thread Gao, Liming
Reviewed-by: Liming Gao -Original Message- From: Zeng, Star Sent: Tuesday, November 17, 2015 5:47 PM To: edk2-devel@lists.01.org Cc: Gao, Liming Subject: [PATCH] MdeModulePkg PeiCore: PeiInstallPeiMemory improper ASSERT test on second call The ASSERT (PrivateData->PeiMemoryInstal

Re: [edk2] [patch 0/7]MdeModulePkg:UiApp remodeling task

2015-11-18 Thread Gao, Liming
to be specified in UiApp.inf LibraryClass section in Platform DSC file. Please update MdeModulePkg.dsc and Nt32Pkg.dsc. Thanks Liming -Original Message- From: Bi, Dandan Sent: Wednesday, November 11, 2015 4:00 PM To: Dong, Eric; Gao, Liming; edk2-devel@lists.01.org Subject: [patch 0/7

Re: [edk2] [PATCH V2 01/12] MdePkg SerialPortLib: Upstream GetControl/SetControl/SetAttributes interfaces

2015-11-18 Thread Gao, Liming
Reviewed-by: Liming Gao -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Star Zeng Sent: Tuesday, November 17, 2015 7:07 PM To: edk2-devel@lists.01.org Cc: Kinney, Michael D; Gao, Liming Subject: [edk2] [PATCH V2 01/12] MdePkg SerialPortLib

Re: [edk2] [PATCH V2 04/12] MdeModulePkg: Upstream SerialDxe from EmbeddedPkg

2015-11-18 Thread Gao, Liming
Reviewed-by: Liming Gao -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Star Zeng Sent: Tuesday, November 17, 2015 7:07 PM To: edk2-devel@lists.01.org Cc: Kinney, Michael D; Tian, Feng; Gao, Liming Subject: [edk2] [PATCH V2 04/12] MdeModulePkg

Re: [edk2] [PATCH V2 03/12] MdeModulePkg BaseSerialPortLib16550: Add GetControl/SetControl/SetAttributes implementation

2015-11-18 Thread Gao, Liming
Reviewed-by: Liming Gao -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Star Zeng Sent: Tuesday, November 17, 2015 7:07 PM To: edk2-devel@lists.01.org Cc: Kinney, Michael D; Tian, Feng; Gao, Liming Subject: [edk2] [PATCH V2 03/12] MdeModulePkg

Re: [edk2] [PATCH V2 02/12] PcAtChipsetPkg SerialIoLib: Add GetControl/SetControl/SetAttributes implementation

2015-11-18 Thread Gao, Liming
Reviewed-by: Liming Gao -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Star Zeng Sent: Tuesday, November 17, 2015 7:07 PM To: edk2-devel@lists.01.org Cc: Kinney, Michael D; Ni, Ruiyu; Gao, Liming Subject: [edk2] [PATCH V2 02/12] PcAtChipsetPkg

Re: [edk2] [PATCH v2 0/6] UiApp remodeling task

2015-11-19 Thread Gao, Liming
Reviewed-by: Liming Gao for this serials -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Dandan Bi Sent: Friday, November 20, 2015 12:16 PM To: edk2-devel@lists.01.org Subject: [edk2] [PATCH v2 0/6] UiApp remodeling task Our current UiApp code is

Re: [edk2] [Patch] BaseTools/toolsetup.bat: fixed the error when the path contains space

2015-11-20 Thread Gao, Liming
Reviewed-by: Liming Gao -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Yonghong Zhu Sent: Friday, November 20, 2015 5:08 PM To: edk2-devel@lists.01.org Cc: Hauch, Larry; carl.mil...@pnnl.gov Subject: [edk2] [Patch] BaseTools/toolsetup.bat: fixed

Re: [edk2] [Patch] [Patch V3] MdeModulePkg DxeFileExplorerProtocol: Create wrapper file explorer library.

2015-11-22 Thread Gao, Liming
Reviewed-by: Liming Gao -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Eric Dong Sent: Wednesday, November 11, 2015 3:28 PM To: edk2-devel@lists.01.org; cecil.sh...@hpe.com; samer-el-haj-mahm...@hpe.com Cc: Gao, Liming Subject: [edk2] [Patch

Re: [edk2] [Patch 0/2] MdeModulePkg: Create file explorer library and file

2015-11-22 Thread Gao, Liming
Reviewed-by: Liming Gao -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Eric Dong Sent: Wednesday, November 11, 2015 1:35 PM To: edk2-devel@lists.01.org; cecil.sh...@hpe.com; samer.el-haj-mahm...@hpe.com Subject: [edk2] [Patch 0/2] MdeModulePkg: C

Re: [edk2] [PATCH 1/6] BaseTools/GenFw ARM: allow R_ARM_REL32 relocations

2015-11-24 Thread Gao, Liming
Reviewed-by: Liming Gao -Original Message- From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] Sent: Tuesday, November 24, 2015 4:08 PM To: edk2-devel@lists.01.org; Gao, Liming; Zhu, Yonghong Cc: Ian Campbell; Ard Biesheuvel; Stefano Stabellini; Laszlo Ersek; Julien Grall; Leif

Re: [edk2] [Patch] BaseTools: Add a VPD report subsection of FLASH to the Report

2015-11-29 Thread Gao, Liming
Reviewed-by: Liming Gao -Original Message- From: Zhu, Yonghong Sent: Thursday, November 26, 2015 10:10 PM To: edk2-devel@lists.01.org Cc: Gao, Liming Subject: [Patch] BaseTools: Add a VPD report subsection of FLASH to the Report Build Spec already added a VPD report subsection of FLASH

Re: [edk2] [Patch] BaseTools: Add build error detection for Dynamic PCD name conflict

2015-11-29 Thread Gao, Liming
Reviewed-by: Liming Gao -Original Message- From: Zhu, Yonghong Sent: Tuesday, November 24, 2015 2:23 PM To: edk2-devel@lists.01.org Cc: Gao, Liming Subject: [Patch] BaseTools: Add build error detection for Dynamic PCD name conflict when multiple Dynamic PCD have different token space

Re: [edk2] MdePkg: DebugAssert enhancement

2015-12-01 Thread Gao, Liming
: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Anbazhagan, Baraneedharan Sent: Wednesday, December 02, 2015 7:26 AM To: edk2-devel@lists.01.org; Carsey, Jaben; Gao, Liming; Kinney, Michael D Subject: Re: [edk2] MdePkg: DebugAssert enhancement MdePkg: DebugAssert enhancement If

Re: [edk2] [PATCH] BaseTools RVCT: use scatter file to implement minimum section alignment

2015-12-01 Thread Gao, Liming
Reviewed-by: Liming Gao -Original Message- From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] Sent: Tuesday, December 01, 2015 4:59 PM To: edk2-devel@lists.01.org; eug...@hp.com Cc: leif.lindh...@linaro.org; Gao, Liming; Ard Biesheuvel Subject: [PATCH] BaseTools RVCT: use scatter

Re: [edk2] [PATCH 1/1] BaseTools: sync BaseTools from main trunk r18579.

2015-12-02 Thread Gao, Liming
Reviewed-by: Liming Gao -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Mike Maslenkin Sent: Wednesday, December 02, 2015 11:17 PM To: edk2-de...@ml01.01.org Cc: Fan, Jeff Subject: [edk2] [PATCH 1/1] BaseTools: sync BaseTools from main trunk r185

Re: [edk2] [PATCH] BaseTools PatchCheck.py: Support binary diff

2015-12-02 Thread Gao, Liming
Reviewed-by: Liming Gao -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jordan Justen Sent: Wednesday, December 02, 2015 8:24 AM To: edk2-devel@lists.01.org Cc: Justen, Jordan L; Gao, Liming Subject: [edk2] [PATCH] BaseTools PatchCheck.py

Re: [edk2] [PATCH 2/5] MdeModulePkg: remove unreachable code

2015-12-02 Thread Gao, Liming
Reviewed-by: Liming Gao -Original Message- From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] Sent: Thursday, December 03, 2015 1:03 AM To: edk2-devel@lists.01.org; ler...@redhat.com; Gao, Liming; Zhang, Chao B; Carsey, Jaben; Qiu, Shumin; Fan, Jeff; Tian, Feng Cc: Ard Biesheuvel

Re: [edk2] [PATCH 1/5] IntelFrameworkModulePkg: remove unreachable code

2015-12-02 Thread Gao, Liming
Reviewed-by: Liming Gao -Original Message- From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] Sent: Thursday, December 03, 2015 1:03 AM To: edk2-devel@lists.01.org; ler...@redhat.com; Gao, Liming; Zhang, Chao B; Carsey, Jaben; Qiu, Shumin; Fan, Jeff; Tian, Feng Cc: Ard Biesheuvel

Re: [edk2] MdeModulePkg: DebugAssert enhancement

2015-12-02 Thread Gao, Liming
Baranee: Could you use CopyMem() to fill gEfiCallerBaseName instead of AsciiSPrint()? This library instance is for size optimization. So, it uses CopyMem() to fill FileName and Description. Thanks Liming -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Be

Re: [edk2] EDK2 and VS2015

2015-12-02 Thread Gao, Liming
Foster: VS2015 tool chain has been added into BaseTools\Conf\tools_def.template. You can pull the latest EDKII to get it. And, I also send the patch to fix VS2015 warnings in EDKII packages. Please apply them, then do VS2015 build. Thanks Liming -Original Message- From: edk2-devel

Re: [edk2] HOB build/get and size changing

2015-12-03 Thread Gao, Liming
Lee: Per PI spec Volume 3 4.5.2 HOB Construction Rules, all HOBs must be multiples of 8 bytes in length. PEI CreateHob() service will adjust HOB length to meet this requirement. So, you find the hob data size becomes to 8 from 4. Thanks Liming -Original Message- From: edk2-devel [mail

Re: [edk2] [Patch] MdePkg: Add Ipmi2.0 definitions head file.

2015-12-03 Thread Gao, Liming
Daocheng: I try including this header file and compile them, and find the following issues. Pease fix them. 1) IndustryStandard/IpmiNetFnSensorDefinitions.h can't be found 2) There are two IPMI_LAN_DEST_TYPE definitions in MdePkg\Include\IndustryStandard\IpmiNetFnTransportDefinitions.h. Thank

Re: [edk2] [PATCH] BaseTools GCC: avoid the use of COMMON symbols

2015-12-04 Thread Gao, Liming
Good fix. How do you find this issue? Reviewed-by: Liming Gao -Original Message- From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] Sent: Thursday, December 03, 2015 8:54 PM To: edk2-devel@lists.01.org; Justen, Jordan L; Gao, Liming; Zhu, Yonghong Cc: Ard Biesheuvel Subject

Re: [edk2] MdeModulePkg: DebugAssert enhancement

2015-12-04 Thread Gao, Liming
Reviewed-by: Liming Gao I would like to help commit your serial patches if no other comments. Thanks Liming -Original Message- From: Anbazhagan, Baraneedharan [mailto:anbazha...@hp.com] Sent: Friday, December 04, 2015 1:13 AM To: Kinney, Michael D; Gao, Liming; edk2-devel@lists.01.org

Re: [edk2] [PATCH] BaseTools GCC: avoid the use of COMMON symbols

2015-12-04 Thread Gao, Liming
n't report warning for it. Your fix is for GCC tool chain. I will investigate VS solution. Thanks Liming -Original Message- From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] Sent: Friday, December 04, 2015 5:26 PM To: Gao, Liming Cc: edk2-devel@lists.01.org; Justen, Jordan L; Zhu, Y

Re: [edk2] MdeModulePkg: DebugAssert enhancement

2015-12-06 Thread Gao, Liming
Reviewed-by: Liming Gao And, I have committed your serial patches into EDKII project at 19127~19128. Thanks Liming -Original Message- From: Anbazhagan, Baraneedharan [mailto:anbazha...@hp.com] Sent: Saturday, December 05, 2015 4:21 AM To: Gao, Liming; Kinney, Michael D; edk2-devel

Re: [edk2] [Patch] BaseTools: Enhance GenFv Tool to report error message

2015-12-06 Thread Gao, Liming
Reviewed-by: Liming Gao -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Yonghong Zhu Sent: Wednesday, December 02, 2015 4:46 PM To: edk2-devel@lists.01.org Subject: [edk2] [Patch] BaseTools: Enhance GenFv Tool to report error message When two vt

Re: [edk2] [PATCH v3 2/3] BaseTools/GenFw RVCT: fix relocation processing of PT_DYNAMIC sections

2015-12-08 Thread Gao, Liming
Reviewed-by: Liming Gao -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ard Biesheuvel Sent: Monday, December 07, 2015 6:08 PM To: edk2-devel@lists.01.org; Cohen, Eugene Cc: Ard Biesheuvel; Laszlo Ersek; Leif Lindholm; Gao, Liming Subject: Re

Re: [edk2] BUILDRULEORDER Question

2015-12-08 Thread Gao, Liming
Zach: Tool chain family will filter the source files those don't target for it. For your case, EnablePaging32.S will only be selected. Thanks Liming -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Zachary Bobroff Sent: Wednesday, December 09,

Re: [edk2] [Patch] MdePkg/BaseIoLibIntrinsic: Add EBC support

2015-12-13 Thread Gao, Liming
Reviewed-by: Liming Gao -Original Message- From: Kinney, Michael D Sent: Sunday, December 13, 2015 5:37 AM To: edk2-devel@lists.01.org Cc: Gao, Liming; Ni, Ruiyu Subject: [Patch] MdePkg/BaseIoLibIntrinsic: Add EBC support The EBC instruction set supports memory and MMIO access, but not

Re: [edk2] [Patch] MdePkg: backout Ipmi2.0 definitions header file.

2015-12-13 Thread Gao, Liming
Reviewed-by: Liming Gao -Original Message- From: Bu, Daocheng Sent: Friday, December 11, 2015 4:57 PM To: edk2-devel@lists.01.org Cc: Gao, Liming Subject: [Patch] MdePkg: backout Ipmi2.0 definitions header file. The file name is too long and with "Definitions" word that is

Re: [edk2] [Patch] MdePkg: Add Ipmi2.0 definitions head file.

2015-12-13 Thread Gao, Liming
Reviewed-by: Liming Gao -Original Message- From: Bu, Daocheng Sent: Monday, December 14, 2015 11:59 AM To: edk2-devel@lists.01.org Cc: Gao, Liming Subject: [Patch] MdePkg: Add Ipmi2.0 definitions head file. Re-add Ipmi2.0 definitions header files based on Ipmi category: App, Storage

Re: [edk2] [PATCH 5/5] BaseTools ARM: add CLANG35 support

2015-12-14 Thread Gao, Liming
Reviewed-by: Liming Gao -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ard Biesheuvel Sent: Tuesday, December 15, 2015 12:31 AM To: edk2-devel@lists.01.org; Leif Lindholm; Zhu, Yonghong; Gao, Liming Cc: Ard Biesheuvel Subject: Re: [edk2] [PATCH

Re: [edk2] [Patch 2/2] FileExplorerLib: Remove the useless code.

2015-12-14 Thread Gao, Liming
Reviewed-by: Liming Gao -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Eric Dong Sent: Tuesday, December 15, 2015 9:57 AM To: edk2-devel@lists.01.org Subject: [edk2] [Patch 2/2] FileExplorerLib: Remove the useless code. The caller has initial th

Re: [edk2] InsertImageRecord and Section Alignment

2015-12-15 Thread Gao, Liming
Normally, DXE Runtime driver will not be rebased unless you expect it to run as XIP. Is it your expectation? If not, you can configure FvForceRebase=FALSE to disable rebase in FV that includes runtime drivers. [FV.DXEFV] BlockSize = 0x1000 FvForceRebase = FALSE # add this line FvAlign

Re: [edk2] [Patch 1/2] BootManagerLib: Check the pointer to avoid use NULL pointer.

2015-12-15 Thread Gao, Liming
Eric: Could you check its return status first, then check its return value? -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Eric Dong Sent: Tuesday, December 15, 2015 9:57 AM To: edk2-devel@lists.01.org Subject: [edk2] [Patch 1/2] BootManagerLib

Re: [edk2] [Patch] MdeModulePkg: Change file format which the existed folder has mixed file format

2015-12-15 Thread Gao, Liming
Reviewed-by: Liming Gao -Original Message- From: Dong, Eric Sent: Wednesday, December 16, 2015 8:55 AM To: edk2-devel@lists.01.org Cc: Gao, Liming Subject: [edk2] [Patch] MdeModulePkg: Change file format which the existed folder has mixed file format Convert the file format from Unix

Re: [edk2] [Patch v2] BootManagerLib: Check the pointer to avoid use NULL pointer.

2015-12-15 Thread Gao, Liming
Reviewed-by: Liming Gao -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Eric Dong Sent: Wednesday, December 16, 2015 11:01 AM To: edk2-devel@lists.01.org Subject: [edk2] [Patch v2] BootManagerLib: Check the pointer to avoid use NULL pointer. Con

Re: [edk2] trouble building edkii

2015-12-16 Thread Gao, Liming
Hi, To build Nt32Pkg, "edksetup.bat --nt32" can help setup VS env. Could you try it? Thanks Liming -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Guyen Gankhuyag Sent: Thursday, December 17, 2015 3:32 AM To: edk2-devel@lists.01.org Subject: [

Re: [edk2] [Patch] MdeModulePkg: Add PeiIpmiLibIpmiPpi Library Class.

2015-12-16 Thread Gao, Liming
Daocheng: PEI phase global variable can't be used. You need to locate PPI in every function call. Thanks Liming -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Daocheng Bu Sent: Wednesday, December 16, 2015 9:46 PM To: edk2-devel@lists.01.org

Re: [edk2] [Patch] MdeModulePkg: Add SmmIpmiLibSmmIpmiProtocol Library Class.

2015-12-16 Thread Gao, Liming
Daocheng: This is a typo? + &gSmmIpmiProtocolGuidx, Thanks Liming -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Daocheng Bu Sent: Wednesday, December 16, 2015 9:51 PM To: edk2-devel@lists.01.org Cc: Yao, Jiewen Subject: [edk2

Re: [edk2] [Patch] MdeModulePkg: Add DxeIpmiLibIpmiProtocol Library Class.

2015-12-16 Thread Gao, Liming
Does it need to support DXE_CORE, UEFI_DRIVER? -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Daocheng Bu Sent: Wednesday, December 16, 2015 9:44 PM To: edk2-devel@lists.01.org Cc: Yao, Jiewen Subject: [edk2] [Patch] MdeModulePkg: Add DxeIpmiLibI

Re: [edk2] [Patch] MdeModulePkg: Add IpmiLib header file.

2015-12-16 Thread Gao, Liming
Is there only EFI_NOT_FOUND error return status? I see UefiScsiLib ScsiWrite16CommandEx() API has more return status EFI_NOT_READY, EFI_DEVICE_ERROR, EFI_TIMEOUT, EFI_UNSUPPORTED, EFI_OUT_OF_RESOURCES. Could you help confirm it? -Original Message- From: edk2-devel [mailto:edk2-devel-bou

Re: [edk2] [patch] MdeModulePkg:Fix bug that get the password width info incorrectly

2015-12-16 Thread Gao, Liming
Reviewed-by: Liming Gao -Original Message- From: Bi, Dandan Sent: Thursday, December 17, 2015 10:56 AM To: edk2-devel@lists.01.org Cc: Gao, Liming; Dong, Eric Subject: [patch] MdeModulePkg:Fix bug that get the password width info incorrectly Cc: Liming Gao Cc: Eric Dong Contributed

Re: [edk2] [Patch] DxeTpmMeasureBootLib: Change global variable name to avoid name conflict.

2015-12-17 Thread Gao, Liming
Reviewed-by: Liming Gao -Original Message- From: Dong, Eric Sent: Thursday, December 17, 2015 3:55 PM To: edk2-devel@lists.01.org; Gao, Liming Subject: [Patch] DxeTpmMeasureBootLib: Change global variable name to avoid name conflict. Contributed-under: TianoCore Contribution Agreement

Re: [edk2] [PATCH 1/2] BaseTools CLANG35: use -target in PP flags as well

2015-12-17 Thread Gao, Liming
Ard: Do GCC_VFRPP_FLAGS and GCC_ASLPP_FLAGS require this change? -Original Message- From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] Sent: Wednesday, December 16, 2015 6:10 PM To: edk2-devel@lists.01.org; Gao, Liming; Zhu, Yonghong Cc: Ard Biesheuvel Subject: [PATCH 1/2

Re: [edk2] [Patch] BaseTools: Fix one bug in FD region for multiple workspace support

2015-12-17 Thread Gao, Liming
Reviewed-by: Liming Gao -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Yonghong Zhu Sent: Thursday, December 17, 2015 5:05 PM To: edk2-devel@lists.01.org Subject: [edk2] [Patch] BaseTools: Fix one bug in FD region for multiple workspace support

Re: [edk2] [BaseTools] Parallel build question. -

2015-12-17 Thread Gao, Liming
] Sent: Wednesday, December 16, 2015 2:53 AM To: edk2-devel Cc: Zhu, Yonghong; Gao, Liming Subject: [BaseTools] Parallel build question. - Our edk2 tree builds much slower than our previous EDK tree (we added parallel build support to EDK) when we are building multiple targets (all the supported

Re: [edk2] [PATCH] MdePkg/BaseLib: do not rely on undefined behavior in arithmetic shift

2015-12-17 Thread Gao, Liming
Ard: Have you found other similar cases in EDKII project? Or, it this the only one? Thanks Liming -Original Message- From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] Sent: Wednesday, December 16, 2015 6:49 PM To: edk2-devel@lists.01.org; Gao, Liming Cc: dw...@infradead.org; Ard

Re: [edk2] [PATCH 0/8] add IA32 and X64 support to CLANG35 toolchain

2015-12-17 Thread Gao, Liming
Ard: Thanks for your contribution of CLANG X86 tool chain. We will verify X64 arch. Thanks Liming -Original Message- From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] Sent: Thursday, December 17, 2015 6:01 PM To: edk2-devel@lists.01.org; Gao, Liming Cc: Ard Biesheuvel Subject

Re: [edk2] [PATCH 6/8] BaseTools CLANG35: use -target in PP flags as well

2015-12-17 Thread Gao, Liming
Reviewed-by: Liming Gao -Original Message- From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] Sent: Thursday, December 17, 2015 6:01 PM To: edk2-devel@lists.01.org; Gao, Liming Cc: Ard Biesheuvel Subject: [PATCH 6/8] BaseTools CLANG35: use -target in PP flags as well The Clang

Re: [edk2] [PATCH 1/8] MdePkg/BaseLib: do not rely on undefined behavior in arithmetic shift

2015-12-17 Thread Gao, Liming
Reviewed-by: Liming Gao -Original Message- From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] Sent: Thursday, December 17, 2015 6:01 PM To: edk2-devel@lists.01.org; Gao, Liming Cc: Ard Biesheuvel Subject: [PATCH 1/8] MdePkg/BaseLib: do not rely on undefined behavior in arithmetic

Re: [edk2] [patch] MdeModulePkg:Update Boot Manager form when enter it.

2015-12-21 Thread Gao, Liming
Reviewed-by: Liming Gao -Original Message- From: Bi, Dandan Sent: Thursday, December 17, 2015 5:52 PM To: edk2-devel@lists.01.org Cc: Gao, Liming; Dong, Eric Subject: [patch] MdeModulePkg:Update Boot Manager form when enter it. Currently BootManager is an independent library,used by

Re: [edk2] [patch] MdeModulePkg:Clear the screen before booting the boot option

2015-12-21 Thread Gao, Liming
Reviewed-by: Liming Gao -Original Message- From: Bi, Dandan Sent: Friday, December 18, 2015 1:50 PM To: edk2-devel@lists.01.org Cc: Gao, Liming; Dong, Eric Subject: [patch] MdeModulePkg:Clear the screen before booting the boot option When do UiApp remodeling task,miss clearing the

Re: [edk2] [PATCH] MdeModulePkg/XhciPei: Fix VS2015 build warning

2015-12-21 Thread Gao, Liming
Hi, When I build this module with VS2015, no warning message will report. In fact, we disable VS2015 warning C4701 & C4703 in MdePkg/Include/Ia32/ProcessorBind.h and MdePkg/Include/X64/ProcessorBind.h. They should not be reported in build time. So, could you let me know how you meet VS2015 b

Re: [edk2] [Patch] NetworkPkg: Update NetworkPkg.uni to UTF-8 file format

2015-12-21 Thread Gao, Liming
Reviewed-by: Liming Gao -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ye Ting Sent: Tuesday, December 22, 2015 11:02 AM To: edk2-devel@lists.01.org Subject: [edk2] [Patch] NetworkPkg: Update NetworkPkg.uni to UTF-8 file format Patch "NetworkPkg

Re: [edk2] [PATCH v2 2/7] MdeModulePkg: Add IpmiLib and Ppi/Protocol header file.

2015-12-22 Thread Gao, Liming
Daocheng: Please remove the first _ in _IPMI_PROTOCOL_GUID and _SMM_IPMI_PROTOCOL_GUID name. Thanks Liming -Original Message- From: Bu, Daocheng Sent: Tuesday, December 22, 2015 5:27 PM To: edk2-devel@lists.01.org Cc: Gao, Liming Subject: [PATCH v2 2/7] MdeModulePkg: Add IpmiLib and

Re: [edk2] [PATCH v2 3/7] MdeModulePkg: Add BaseIpmiLib Null Library Instance.

2015-12-22 Thread Gao, Liming
The return value should be EFI_STATUS, not 0. Please update. -Original Message- From: Bu, Daocheng Sent: Tuesday, December 22, 2015 5:27 PM To: edk2-devel@lists.01.org Cc: Gao, Liming Subject: [PATCH v2 3/7] MdeModulePkg: Add BaseIpmiLib Null Library Instance. Add BaseIpmiLib Null

Re: [edk2] [PATCH v2 4/7] MdeModulePkg: Add PeiIpmiLibIpmiPpi Library Instance.

2015-12-22 Thread Gao, Liming
mIpmiPpi should be local variable. The static global variable can't be updated in XIP module. Thanks Liming -Original Message- From: Bu, Daocheng Sent: Tuesday, December 22, 2015 5:27 PM To: edk2-devel@lists.01.org Cc: Gao, Liming Subject: [PATCH v2 4/7] MdeModulePkg

Re: [edk2] [PATCH v2 5/7] MdeModulePkg: Add DxeIpmiLibIpmiProtocol Library Instance.

2015-12-22 Thread Gao, Liming
Reviewed-by: Liming Gao -Original Message- From: Bu, Daocheng Sent: Tuesday, December 22, 2015 5:27 PM To: edk2-devel@lists.01.org Cc: Gao, Liming Subject: [PATCH v2 5/7] MdeModulePkg: Add DxeIpmiLibIpmiProtocol Library Instance. Add DxeIpmiLibIpmiProtocol Library Instance based on

Re: [edk2] [PATCH v2 1/7] MdePkg: Update Ipmi2.0 definitions header file.

2015-12-22 Thread Gao, Liming
Reviewed-by: Liming Gao -Original Message- From: Bu, Daocheng Sent: Tuesday, December 22, 2015 5:27 PM To: edk2-devel@lists.01.org Cc: Gao, Liming Subject: [PATCH v2 1/7] MdePkg: Update Ipmi2.0 definitions header file. Update Ipmi2.0 definitions header files for data structure name

Re: [edk2] [PATCH v2 7/7] MdeModulePkg: Update MdeModulePkg.dsc file for IpmiLib.

2015-12-22 Thread Gao, Liming
Reviewed-by: Liming Gao -Original Message- From: Bu, Daocheng Sent: Tuesday, December 22, 2015 5:27 PM To: edk2-devel@lists.01.org Cc: Gao, Liming Subject: [PATCH v2 7/7] MdeModulePkg: Update MdeModulePkg.dsc file for IpmiLib. Update MdeModulePkg.dsc file to include Ipmi Libraries

Re: [edk2] [PATCH v2 6/7] MdeModulePkg: Add SmmIpmiLibSmmIpmiProtocol Library Instance.

2015-12-22 Thread Gao, Liming
Minor comments: 1) UefiBootServicesTableLib is not used. It can be removed. 2) Smm driver should include instead of -Original Message- From: Bu, Daocheng Sent: Tuesday, December 22, 2015 5:27 PM To: edk2-devel@lists.01.org Cc: Gao, Liming Subject: [PATCH v2 6/7] MdeModulePkg: Add

Re: [edk2] [PATCH v3 0/7] Add Ipmi related libraries.

2015-12-22 Thread Gao, Liming
Reviewed-by: Liming Gao -Original Message- From: Bu, Daocheng Sent: Wednesday, December 23, 2015 12:03 AM To: edk2-devel@lists.01.org Cc: Gao, Liming Subject: [PATCH v3 0/7] Add Ipmi related libraries. Update Ipmi2.0 definitions header file and MdeModulePkg.dsc file for Ipmi

Re: [edk2] [PATCH v4 0/3] Add Ipmi related libraries.

2015-12-22 Thread Gao, Liming
Reviewed-by: Liming Gao -Original Message- From: Bu, Daocheng Sent: Wednesday, December 23, 2015 11:59 AM To: edk2-devel@lists.01.org Cc: Gao, Liming Subject: [PATCH v4 0/3] Add Ipmi related libraries. Daocheng Bu (3): MdeModulePkg: Add PeiIpmiLibIpmiPpi Library instance

Re: [edk2] GenFds error to build SMM file in fdf

2015-12-22 Thread Gao, Liming
SMM driver FILE type is SMM per FDF spec. Please try it again. FILE DXE_SMM_DRIVER ==> FILE SMM Thanks Liming From: 王晓峰 [mailto:winggundu...@163.com] Sent: Wednesday, December 23, 2015 1:23 PM To: edk2-devel@lists.01.org; Gao, Liming Subject: [edk2] GenFds error to build SMM file in fdf Hi

Re: [edk2] [PATCH] BaseTools AARCH64: add -mstrict-align to all AARCH64 GCC flavors

2015-12-23 Thread Gao, Liming
Reviewed-by: Liming Gao -Original Message- From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] Sent: Wednesday, December 23, 2015 10:22 PM To: edk2-devel@lists.01.org; Gao, Liming; leif.lindh...@linaro.org Cc: Ard Biesheuvel Subject: [PATCH] BaseTools AARCH64: add -mstrict-align to

Re: [edk2] Nested FD files in one FDF

2015-12-23 Thread Gao, Liming
Eugene: The formal way is to add this support in [FD] section. The workaround way is to create two FDF files, one is for inner FD, another is for out FD. Out FDF will use FILE statement to point to the generated inner FD image. Then, call build -p platform.dsc twice. First, call build -p plat

Re: [edk2] [PATCH 0/6] AARCH64 code model and toolchain updates

2015-12-24 Thread Gao, Liming
Reviews this patch serials. Reviewed-by: Liming Gao -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ard Biesheuvel Sent: Thursday, December 24, 2015 9:03 PM To: edk2-devel@lists.01.org; leif.lindh...@linaro.org; ler...@redhat.com; Gao, Liming

Re: [edk2] [PATCH 0/8] add IA32 and X64 support to CLANG35 toolchain

2015-12-24 Thread Gao, Liming
iming -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Gao, Liming Sent: Friday, December 18, 2015 10:59 AM To: Ard Biesheuvel; edk2-devel@lists.01.org Subject: Re: [edk2] [PATCH 0/8] add IA32 and X64 support to CLANG35 toolchain Ard: Thanks for

Re: [edk2] [PATCH] MdeModulePkg Variable: ###VariableTotalSize need to be initialized to 0 first

2015-12-27 Thread Gao, Liming
Reviewed-by: Liming Gao -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Star Zeng Sent: Monday, December 28, 2015 2:10 PM To: edk2-devel@lists.01.org Cc: Gao, Liming Subject: [edk2] [PATCH] MdeModulePkg Variable: ###VariableTotalSize need to be

Re: [edk2] [PATCH] MdeModulePkg Variable: Add a missing variable info record

2015-12-29 Thread Gao, Liming
Reviewed-by: Liming Gao -Original Message- From: Zeng, Star Sent: Monday, December 28, 2015 2:01 PM To: edk2-devel@lists.01.org Cc: Gao, Liming Subject: [PATCH] MdeModulePkg Variable: Add a missing variable info record Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement

Re: [edk2] [PATCH] MdeModulePkg Variable: Handle ftw driver executes prior to variable driver

2015-12-29 Thread Gao, Liming
Reviewed-by: Liming Gao -Original Message- From: Zeng, Star Sent: Monday, December 28, 2015 1:39 PM To: edk2-devel@lists.01.org Cc: Gao, Liming Subject: [PATCH] MdeModulePkg Variable: Handle ftw driver executes prior to variable driver Variable driver uses gEdkiiFaultTolerantWriteGuid

Re: [edk2] [PATCH] BaseTools: Fix 'caculate' typos

2016-01-04 Thread Gao, Liming
Reviewed-by: Liming Gao -Original Message- From: Wu, Hao A Sent: Tuesday, January 05, 2016 9:24 AM To: edk2-devel@lists.01.org; Zhu, Yonghong; Gao, Liming Cc: Wu, Hao A Subject: [PATCH] BaseTools: Fix 'caculate' typos Contributed-under: TianoCore Contribution Agreement 1.0

Re: [edk2] [patch] MdeModulePkg:Fix the potential memory leak issue in Display Engine

2016-01-04 Thread Gao, Liming
Reviewed-by: Liming Gao -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Dandan Bi Sent: Tuesday, January 05, 2016 9:59 AM To: edk2-devel@lists.01.org Cc: Dong, Eric; Gao, Liming Subject: [edk2] [patch] MdeModulePkg:Fix the potential memory leak

Re: [edk2] [patch] MdeModulePkg:Change the type of BootNext

2016-01-04 Thread Gao, Liming
Reviewed-by: Liming Gao -Original Message- From: Bi, Dandan Sent: Tuesday, January 05, 2016 8:34 AM To: edk2-devel@lists.01.org Cc: Gao, Liming; Dong, Eric Subject: [patch] MdeModulePkg:Change the type of BootNext Currently the invalid boot next set to the number of boot option, when

Re: [edk2] [Patch V2] BaseTools: Support \x####\ in UNI files to specify non-ascii characters

2016-05-03 Thread Gao, Liming
Reviewed-by: Liming Gao > -Original Message- > From: Zhu, Yonghong > Sent: Tuesday, May 03, 2016 3:47 PM > To: edk2-devel@lists.01.org > Cc: Gao, Liming > Subject: [Patch V2] BaseTools: Support \x\ in UNI files to specify non- > ascii characters > > UNI

Re: [edk2] [RFC] EDK2 Platforms Proposal

2016-05-03 Thread Gao, Liming
Mike: I have some comments. 1) If the platforms wants to base on edk2 master, it is not suggested to be placed into edk2-platform repo. Right? 2) On add a new platform to edk2-platforms, who approves the request? Edk2 maintainer? Now, edk2 maintainer are edk2 package owner. So, for new platform

Re: [edk2] [Patch] MdeModulePkg FileExplorerLib: Add UefiHiiServicesLib dependency.

2016-05-04 Thread Gao, Liming
Reviewed-by: Liming Gao > -Original Message- > From: Dong, Eric > Sent: Wednesday, May 04, 2016 2:28 PM > To: edk2-devel@lists.01.org > Cc: Gao, Liming > Subject: [Patch] MdeModulePkg FileExplorerLib: Add UefiHiiServicesLib > dependency. > >

Re: [edk2] [patch] MdeModulePkg/FileExplore: Make LibraryClass & Depex module type consistent

2016-05-05 Thread Gao, Liming
Reviewed-by: Liming Gao > -Original Message- > From: Bi, Dandan > Sent: Thursday, May 05, 2016 11:04 AM > To: edk2-devel@lists.01.org > Cc: Gao, Liming ; Dong, Eric > Subject: [patch] MdeModulePkg/FileExplore: Make LibraryClass & Depex > module type consistent

Re: [edk2] [patch 0/2] MdeModulePkg/SetupBrowser: Fix two issues in submit form/formset

2016-05-05 Thread Gao, Liming
Reviewed-by: Liming Gao > -Original Message- > From: Bi, Dandan > Sent: Wednesday, April 27, 2016 9:25 AM > To: edk2-devel@lists.01.org > Cc: Gao, Liming ; Dong, Eric > Subject: [patch 0/2] MdeModulePkg/SetupBrowser: Fix two issues in submit > form/formset > >

Re: [edk2] BaseTools question about FDF FILE syntax

2016-05-05 Thread Gao, Liming
Andrew: NAME GUID is module INF file GUID. It is used in Rule section in FDF file like below. This is your usage case? [Rule.Common.DXE_CORE] FILE DXE_CORE = $(NAMED_GUID) { COMPRESS PI_STD { PE32 PE32 $(INF_OUTPUT)/$(MODULE_NAME).efi UI STRING="$(MODULE_NAME)"

Re: [edk2] [Patch] BaseTools: fix a bug for uni file \x####\ format handling

2016-05-10 Thread Gao, Liming
Reviewed-by: Liming Gao > -Original Message- > From: Zhu, Yonghong > Sent: Tuesday, May 10, 2016 6:17 PM > To: edk2-devel@lists.01.org > Cc: Gao, Liming > Subject: [Patch] BaseTools: fix a bug for uni file \x\ format handling > > It should start from the l

Re: [edk2] [Patch] BaseTools: Fix bug in GenFds to handle FV image alignment

2016-05-10 Thread Gao, Liming
Reviewed-by: Liming Gao > -Original Message- > From: Zhu, Yonghong > Sent: Friday, May 06, 2016 5:27 PM > To: edk2-devel@lists.01.org > Cc: Gao, Liming > Subject: [Patch] BaseTools: Fix bug in GenFds to handle FV image alignment > > Cover the case that .

Re: [edk2] [PATCH] MdePkg: Add HII definitions from UEFI 2.6

2016-05-11 Thread Gao, Liming
Reviewed-by: Liming Gao > -Original Message- > From: Bi, Dandan > Sent: Thursday, May 12, 2016 10:50 AM > To: Samer El-Haj-Mahmoud ; edk2- > de...@lists.01.org > Cc: Kinney, Michael D ; Samer El-Haj- > Mahmoud ; Gao, Liming > Subject: RE: [edk2] [PATCH] MdePkg:

Re: [edk2] [Patch] BaseTools/GenFw: enhance to use Magic Field to identify the image

2016-05-12 Thread Gao, Liming
Reviewed-by: Liming Gao > -Original Message- > From: Zhu, Yonghong > Sent: Thursday, May 12, 2016 2:32 PM > To: edk2-devel@lists.01.org > Cc: Gao, Liming > Subject: [Patch] BaseTools/GenFw: enhance to use Magic Field to identify > the image > > Original

  1   2   3   4   5   6   7   8   9   10   >