[edk2] BaseTools features: multiple workspaces

2015-08-02 Thread Gao, Liming
Hi, all We will update BaseTools feature to allow more than one workspaces. The detail design in the below. Please help review it. If you have any comments, please let me know. 1. Keep $(WORKSPACE) environment as is a. $(WORKSPACE) determines location of Build and Conf directory.

Re: [edk2] [PATCH v2] BaseTools IA32/X64: prevent .eh_frame sections from being generated

2015-08-12 Thread Gao, Liming
Reviewed-by: Liming Gao liming@intel.com -Original Message- From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] Sent: Thursday, August 13, 2015 1:19 PM To: edk2-devel@lists.01.org; ler...@redhat.com; Liu, Yingke D Cc: Gao, Liming; Ard Biesheuvel Subject: [PATCH v2] BaseTools IA32

Re: [edk2] [RFC PATCH 0/4] unify GCC command line options

2015-08-12 Thread Gao, Liming
I agree to unify GCC option and add -std=gun89 flag. Thanks Liming -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Scott Duplichan Sent: Thursday, August 13, 2015 9:25 AM To: 'Ard Biesheuvel'; edk2-de...@ml01.01.org; Justen, Jordan L; Liu,

Re: [edk2] Section Alignment of elf binaries compiled with GCC(Linux)

2015-08-17 Thread Gao, Liming
Jiewen: The updated message is useful. I suggest to change error level from EFI_D_ERROR to EFI_D_INFO. Thanks Liming -Original Message- From: Yao, Jiewen Sent: Tuesday, August 18, 2015 10:46 AM To: Gao, Liming; Michael Zimmermann; edk2-devel@lists.01.org Subject: RE: [edk2] Section

Re: [edk2] [PATCH v2 16/16] OvmfPkg/X64: enable 4 KB alignment for DXE_RUNTIME modules

2015-08-17 Thread Gao, Liming
, August 17, 2015 10:25 PM To: edk2-devel@lists.01.org; Liu, Yingke D Cc: wp...@windriver.com; sc...@notabs.org; Ard Biesheuvel; Justen, Jordan L; Gao, Liming; dw...@infradead.org Subject: [edk2] [PATCH v2 16/16] OvmfPkg/X64: enable 4 KB alignment for DXE_RUNTIME modules This enables 4 KB section

Re: [edk2] Section Alignment of elf binaries compiled with GCC(Linux)

2015-08-17 Thread Gao, Liming
Hi, This is a warning message that describes the runtime driver alignment is not 4K. UEFI PropertiesTable table feature expects all runtime driver alignment is 4K. When DxeCore loads Runtime driver, it will check its alignment and report such warning message if it doesn't meet with the

Re: [edk2] [patch] IntelFrameworkModulePkg: Update DEC and DSC version from 0.94 to 0.96

2015-08-19 Thread Gao, Liming
Reviewed-by: Liming Gao liming@intel.com -Original Message- From: Tian, Feng Sent: Thursday, August 20, 2015 9:26 AM To: Gao, Liming Cc: edk2-devel@lists.01.org; Tian, Feng Subject: [patch] IntelFrameworkModulePkg: Update DEC and DSC version from 0.94 to 0.96 Update DEC and DSC

Re: [edk2] [patch] IntelFrameworkPkg: Update DEC and DSC version from 0.94 to 0.96

2015-08-19 Thread Gao, Liming
Reviewed-by: Liming Gao liming@intel.com -Original Message- From: Tian, Feng Sent: Thursday, August 20, 2015 9:26 AM To: Gao, Liming Cc: edk2-devel@lists.01.org; Tian, Feng Subject: [patch] IntelFrameworkPkg: Update DEC and DSC version from 0.94 to 0.96 Update DEC and DSC version

Re: [edk2] [PATCH v2 02/16] BaseTools/GenFv: use PE/COFF virtual section size if raw size is larger

2015-08-18 Thread Gao, Liming
I agree this change. Reviewed-by: Liming Gao liming@intel.com -Original Message- From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] Sent: Monday, August 17, 2015 10:25 PM To: edk2-devel@lists.01.org; Liu, Yingke D Cc: Gao, Liming; Justen, Jordan L; wp...@windriver.com; sc

Re: [edk2] [PATCH 2/2] MdePkg: Follow PI spec to update ExtendedSize in EFI_FFS_FILE_HEADER2

2015-08-21 Thread Gao, Liming
Reviewed-by: Liming Gao liming@intel.com -Original Message- From: Zeng, Star Sent: Friday, August 21, 2015 2:19 PM To: edk2-devel@lists.01.org Cc: Gao, Liming Subject: [PATCH 2/2] MdePkg: Follow PI spec to update ExtendedSize in EFI_FFS_FILE_HEADER2 for FFS data above 16 bytes

Re: [edk2] [PATCH 1/2] BaseTools: Follow PI spec to update ExtendedSize in EFI_FFS_FILE_HEADER2

2015-08-21 Thread Gao, Liming
Reviewed-by: Liming Gao liming@intel.com -Original Message- From: Zeng, Star Sent: Friday, August 21, 2015 2:19 PM To: edk2-devel@lists.01.org Cc: Gao, Liming Subject: [PATCH 1/2] BaseTools: Follow PI spec to update ExtendedSize in EFI_FFS_FILE_HEADER2 for FFS data above 16 bytes

Re: [edk2] [Patch] BaseTools/Trim: Fixed a bug that cannot trim long values

2015-07-28 Thread Gao, Liming
Yingke: Could you help update build_rule.txt for *.asm and *.asm16 with trimlong option? Thanks Liming -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Yingke Liu Sent: Wednesday, July 29, 2015 9:06 AM To: edk2-devel@lists.01.org Subject:

Re: [edk2] [PATCH v3 12/12] BaseTools/X86|IA32: move to unified GCC linker script

2015-07-30 Thread Gao, Liming
Yes. -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ard Biesheuvel Sent: Thursday, July 30, 2015 10:26 PM To: Gao, Liming Cc: Justen, Jordan L; edk2-devel@lists.01.org; ler...@redhat.com; Liu, Yingke D; leif.lindh...@linaro.org Subject: Re

Re: [edk2] [PATCH v2 0/4] FFS/FV aligment optimization (was: [RFC] small C model and LLVM/clang support for AARCH64)

2015-07-30 Thread Gao, Liming
] Sent: Monday, July 27, 2015 9:53 PM To: Liu, Yingke D Cc: Gao, Liming; edk2-devel@lists.01.org; leif.lindh...@linaro.org; eugene.co...@hp.com Subject: Re: [PATCH v2 0/4] FFS/FV aligment optimization (was: [RFC] small C model and LLVM/clang support for AARCH64) On 27 July 2015 at 15:34, Liu, Yingke D

Re: [edk2] BaseTools features: multiple workspaces

2015-08-02 Thread Gao, Liming
Ray: Good question. I would like to keep consistent style with OS. ';' in windows, ':' is Linux. Thanks Liming -Original Message- From: Ni, Ruiyu Sent: Monday, August 3, 2015 1:00 PM To: Gao, Liming; edk2-devel@lists.01.org Subject: RE: BaseTools features: multiple workspaces Path

Re: [edk2] BaseTools features: multiple workspaces

2015-08-03 Thread Gao, Liming
, August 03, 2015 4:31 PM To: Gao, Liming; edk2-devel@lists.01.org Subject: Re: [edk2] BaseTools features: multiple workspaces On 03/08/2015 05:56, Gao, Liming wrote: Hi, all We will update BaseTools feature to allow more than one workspaces. The detail design in the below. Please help review

Re: [edk2] [Patch] BaseTools/build_rule: Added --trim-long option.

2015-08-02 Thread Gao, Liming
Reviewed-by: Liming Gao liming@intel.com -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Yingke Liu Sent: Monday, August 03, 2015 10:46 AM To: edk2-devel@lists.01.org Subject: [edk2] [Patch] BaseTools/build_rule: Added --trim-long option

Re: [edk2] [patch] MdeModulePkg:Fix the issue FindQuestionFromProgress in SetupBrowserDxe is broken

2015-08-02 Thread Gao, Liming
Reviewed-by: Liming Gao liming@intel.com -Original Message- From: Bi, Dandan Sent: Friday, July 31, 2015 11:11 AM To: Dong, Eric; Gao, Liming; edk2-devel@lists.01.org Subject: [patch] MdeModulePkg:Fix the issue FindQuestionFromProgress in SetupBrowserDxe is broken If the storage

Re: [edk2] [PATCH] MdeModulePkg DxeCore: Move ProcessLibraryConstructorList()

2015-08-02 Thread Gao, Liming
Reviewed-by: Liming Gao liming@intel.com -Original Message- From: Zeng, Star Sent: Monday, August 03, 2015 10:57 AM To: edk2-devel@lists.01.org Cc: Gao, Liming Subject: [PATCH] MdeModulePkg DxeCore: Move ProcessLibraryConstructorList() to right after CoreInitializeGcdServices

Re: [edk2] [PATCH v3 12/12] BaseTools/X86|IA32: move to unified GCC linker script

2015-07-29 Thread Gao, Liming
Jordan: I have verified 4K aligned image build. Test-by: Liming Gao liming.gao@intel Thanks Liming -Original Message- From: Justen, Jordan L Sent: Thursday, July 30, 2015 5:16 AM To: Ard Biesheuvel; edk2-devel@lists.01.org; Liu, Yingke D; Gao, Liming Cc: ler...@redhat.com; leif.lindh

Re: [edk2] [Patch] Remove the useless code to fix build failure caused by error depend on IntelFrameworkModulePkg.

2015-07-30 Thread Gao, Liming
Reviewed-by: Liming Gao liming@intel.com -Original Message- From: Dong, Eric Sent: Friday, July 31, 2015 9:32 AM To: Ni, Ruiyu; Gao, Liming; edk2-devel@lists.01.org Subject: [Patch] Remove the useless code to fix build failure caused by error depend on IntelFrameworkModulePkg

Re: [edk2] How Can I add Section VERSION in fdf file?

2015-08-06 Thread Gao, Liming
This is a bug in BaseTools. We will root cause it and provide the patch. -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Andrew Fish Sent: Thursday, August 06, 2015 1:58 PM To: 王晓峰 Cc: edk2-devel@lists.01.org Subject: Re: [edk2] How Can I add

Re: [edk2] [PATCH] BaseTools: add ARCH detection for AARCH64 and ARM

2015-08-11 Thread Gao, Liming
Reviewed-by: Liming Gao liming@intel.com -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ard Biesheuvel Sent: Tuesday, August 11, 2015 8:03 PM To: edk2-devel@lists.01.org; Liu, Yingke D Cc: leif.lindh...@linaro.org; Ard Biesheuvel Subject

Re: [edk2] [PATCH v2 0/6] remove ARMGCC and ARMLINUXGCC toolchains

2015-08-11 Thread Gao, Liming
Ard: I have no comments on the change in BaseTools build_rule.template and tools_def.template. Reviewed-by: Liming Gao liming@intel.com Thanks Liming -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ard Biesheuvel Sent: Tuesday, August 11

Re: [edk2] [PATCH] BaseTools/GenFds: Fix 'NoneType' object is not iterable error.

2015-08-09 Thread Gao, Liming
Shumin: Please highlight what problem resolved by this fix. Thanks Liming -Original Message- From: Qiu, Shumin Sent: Monday, August 10, 2015 1:43 PM To: edk2-devel@lists.01.org Cc: Qiu, Shumin; Gao, Liming; winggundu...@163.com Subject: [PATCH] BaseTools/GenFds: Fix 'NoneType' object

Re: [edk2] [RFC PATCH 0/4] unify GCC command line options

2015-08-10 Thread Gao, Liming
Ard: This patch introduces GCC4X_ for common GCC option. It may be common for GCC5, GCC6... So, how about use GCC_ prefix for all GCC common option? Thanks Liming -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ard Biesheuvel Sent: Friday,

Re: [edk2] [PATCH v3 6/7] BaseTools/GenFw: allow AArch64 tiny and small code model relocations

2015-08-10 Thread Gao, Liming
; Liu, Yingke D; leif.lindh...@linaro.org Cc: Gao, Liming; Ard Biesheuvel Subject: [PATCH v3 6/7] BaseTools/GenFw: allow AArch64 tiny and small code model relocations The AArch64 small C model makes extensive use of ADRP/ADD and ADRP/{LDR,STR} pairs to emit PC-relative symbol references

Re: [edk2] [PATCH v4 7/7] BaseTools: add CLANG35 toolchain with AARCH64 support

2015-08-10 Thread Gao, Liming
Reviewed-by: Liming Gao liming@intel.com -Original Message- From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] Sent: Monday, August 10, 2015 3:41 PM To: edk2-devel@lists.01.org; Liu, Yingke D; leif.lindh...@linaro.org Cc: Justen, Jordan L; Gao, Liming; Ard Biesheuvel Subject

Re: [edk2] [RFC PATCH 2/4] BaseTools GCC: unify warning flags for all GCC versions

2015-08-10 Thread Gao, Liming
Reviewed-by: Liming Gao liming@intel.com -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ard Biesheuvel Sent: Friday, August 7, 2015 11:05 PM To: edk2-devel@lists.01.org; Justen, Jordan L; Liu, Yingke D Cc: Ard Biesheuvel Subject: [edk2] [RFC

Re: [edk2] BaseTools features: multiple workspaces

2015-08-06 Thread Gao, Liming
Message- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Thursday, August 06, 2015 4:31 PM To: Justen, Jordan L; Andrew Fish Cc: Gao, Liming; Tim Lewis; Paolo Bonzini; edk2-devel@lists.01.org Subject: Re: [edk2] BaseTools features: multiple workspaces On 08/05/15 23:46, Jordan Justen wrote

Re: [edk2] [PATCH v2 7/7] BaseTools/X86|IA32: move to unified GCC linker script

2015-07-27 Thread Gao, Liming
Ard: The patch is good. Reviewed-by: Liming Gao liming@intel.com Thanks Liming -Original Message- From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] Sent: Friday, July 24, 2015 8:09 PM To: edk2-devel@lists.01.org; Liu, Yingke D; ler...@redhat.com; Justen, Jordan L

Re: [edk2] [PATCH 0/4] FFS/FV aligment optimization (was: [RFC] small C model and LLVM/clang support for AARCH64)

2015-07-27 Thread Gao, Liming
) Optional VERSION STRING=$(INF_VERSION) Optional BUILD_NUM=$(BUILD_NUMBER) } Thanks Liming -Original Message- From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] Sent: Monday, July 27, 2015 7:24 PM To: Gao, Liming Cc: Leif Lindholm; Liu, Yingke D; edk2-devel@lists.01.org; eugene.co

Re: [edk2] [PATCH v2 0/4] FFS/FV aligment optimization (was: [RFC] small C model and LLVM/clang support for AARCH64)

2015-07-27 Thread Gao, Liming
Reviewed-by: Liming Gao liming@intel.com -Original Message- From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] Sent: Monday, July 27, 2015 8:32 PM To: Gao, Liming; Liu, Yingke D; edk2-devel@lists.01.org Cc: leif.lindh...@linaro.org; eugene.co...@hp.com; Ard Biesheuvel Subject

Re: [edk2] [Patch] BaseTools: Add a keyword FvNameString in FDF

2015-07-27 Thread Gao, Liming
Reviewed-by: Liming Gao liming@intel.com -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Yingke Liu Sent: Wednesday, July 22, 2015 3:52 PM To: edk2-devel@lists.01.org Subject: [edk2] [Patch] BaseTools: Add a keyword FvNameString in FDF

Re: [edk2] [PATCH 0/4] FFS/FV aligment optimization (was: [RFC] small C model and LLVM/clang support for AARCH64)

2015-07-26 Thread Gao, Liming
this change, GenFv tool also requires to update FFS HEAD to remove alignment value, because the updated FFS doesn't meet with FFS alignment requirement. Thanks Liming -Original Message- From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] Sent: Monday, July 27, 2015 3:04 AM To: Gao

Re: [edk2] [Patch] Support get string from configuration string packages.

2015-07-27 Thread Gao, Liming
Eric: Reviewed-by: Liming Gao liming@intel.com Thanks Liming -Original Message- From: Dong, Eric Sent: Thursday, July 23, 2015 10:02 AM To: Gao, Liming; edk2-devel@lists.01.org Subject: [Patch] Support get string from configuration string packages. Current implementation avoid

Re: [edk2] [patch] MdeModulePkg:SetupBrowser output debug message when DisplayEngineDxe is not installed

2015-07-27 Thread Gao, Liming
Reviewed-by: Liming Gao liming@intel.com -Original Message- From: Bi, Dandan Sent: Friday, July 24, 2015 2:32 PM To: Dong, Eric; Gao, Liming; edk2-devel@lists.01.org Subject: [patch] MdeModulePkg:SetupBrowser output debug message when DisplayEngineDxe is not installed Enhance

Re: [edk2] [PATCH] BaseTools: Add NOOPT build for all tool chain combinations

2015-07-27 Thread Gao, Liming
Scott: So, DEBUG and NOOPT is the same in GCC tool chain? In VS tool chain, DEBUG turns on optimization, NOOPT turns off optimization, RELEASE disables source level debug. Thanks Liming -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Scott

Re: [edk2] [PATCH v2] MdeModulePkg:Add ESC key support in setup browser pop-up message box

2015-07-27 Thread Gao, Liming
Reviewed-by: Liming Gao liming@intel.com -Original Message- From: Bi, Dandan Sent: Monday, July 27, 2015 2:57 PM To: Justen, Jordan L; Dong, Eric; Gao, Liming; edk2-devel@lists.01.org Subject: RE: [edk2] [PATCH v2] MdeModulePkg:Add ESC key support in setup browser pop-up message box

Re: [edk2] [PATCH 0/4] FFS/FV aligment optimization (was: [RFC] small C model and LLVM/clang support for AARCH64)

2015-07-27 Thread Gao, Liming
[mailto:ard.biesheu...@linaro.org] Sent: Monday, July 27, 2015 5:09 PM To: Gao, Liming Cc: Liu, Yingke D; Leif Lindholm; edk2-devel@lists.01.org; eugene.co...@hp.com Subject: Re: [edk2] [PATCH 0/4] FFS/FV aligment optimization (was: [RFC] small C model and LLVM/clang support for AARCH64) On 27 July 2015

Re: [edk2] [PATCH 0/4] FFS/FV aligment optimization (was: [RFC] small C model and LLVM/clang support for AARCH64)

2015-07-27 Thread Gao, Liming
Sent: Monday, July 27, 2015 4:52 PM To: Ard Biesheuvel Cc: Leif Lindholm; edk2-devel@lists.01.org; eugene.co...@hp.com; Gao, Liming Subject: RE: [edk2] [PATCH 0/4] FFS/FV aligment optimization (was: [RFC] small C model and LLVM/clang support for AARCH64) Hi Ard, Thanks for the details. I think

Re: [edk2] [PATCH 1/7] MdePkg: Add missing PCD usage information in UNI files.

2015-07-21 Thread Gao, Liming
Reviewed-by: Liming Gao liming@intel.com -Original Message- From: Qiu, Shumin Sent: Tuesday, July 21, 2015 8:50 PM To: edk2-devel@lists.01.org Cc: Qiu, Shumin; Gao, Liming Subject: [PATCH 1/7] MdePkg: Add missing PCD usage information in UNI files. Cc: Liming Gao liming

Re: [edk2] [patch] MdeModulePkg:Correct the parameter order in match2 sample opcode

2015-07-20 Thread Gao, Liming
Reviewed-by: Liming Gao liming@intel.com -Original Message- From: Bi, Dandan Sent: Monday, July 20, 2015 5:13 PM To: Dong, Eric; Gao, Liming; edk2-devel@lists.01.org Subject: [patch] MdeModulePkg:Correct the parameter order in match2 sample opcode The first parameter of match2

Re: [edk2] [RFC PATCH 0/8] small C model and LLVM/clang support for AARCH64

2015-07-21 Thread Gao, Liming
.org; olivier.mar...@arm.com; leif.lindh...@linaro.org; Gao, Liming; Liu, Yingke D; Justen, Jordan L; ler...@redhat.com Subject: Re: [edk2] [RFC PATCH 0/8] small C model and LLVM/clang support for AARCH64 On 17 July 2015 at 21:28, Andrew Fish af...@apple.com wrote: On Jul 17, 2015, at 12:07 PM

Re: [edk2] [PATCH] MdeModulePkg PeiCore: Recheck SwitchStackSignal after ProcessNotifyList()

2015-08-24 Thread Gao, Liming
Reviewed-by: Liming Gao liming@intel.com -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Star Zeng Sent: Friday, August 21, 2015 4:10 PM To: edk2-devel@lists.01.org Cc: Yao, Jiewen; Gao, Liming Subject: [edk2] [PATCH] MdeModulePkg PeiCore

Re: [edk2] [patch] MdeModulePkg:Add HiiGetFormSetFromHiiHandle function into UefiHiiLib

2015-10-27 Thread Gao, Liming
Reviewed-by: Liming Gao <liming@intel.com> -Original Message- From: Bi, Dandan Sent: Friday, October 23, 2015 4:05 PM To: Dong, Eric; Gao, Liming; edk2-devel@lists.01.org Subject: [patch] MdeModulePkg:Add HiiGetFormSetFromHiiHandle function into UefiHiiLib This function is

Re: [edk2] Getting "Incompatible Memory Type" in ConvertPages for AllocatePages

2015-10-26 Thread Gao, Liming
Shubha: Yes. If EFI_MEMORY_DESCRIPTOR.Type is EfiConventionalMemory, the range is free to be allocated. Thanks Liming -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Shubha Ramani Sent: Tuesday, October 27, 2015 1:35 AM To:

Re: [edk2] [PATCH] BaseTools/GenFw: add option to retain image version info

2015-10-29 Thread Gao, Liming
Carl: Could you let me how you uses the version information in application .EFI file? Thanks Liming From: Miller, Carl H [mailto:carl.mil...@pnnl.gov] Sent: Wednesday, October 28, 2015 10:32 PM To: edk2-devel@lists.01.org Cc: Zhu, Yonghong; Gao, Liming Subject: [PATCH] BaseTools/GenFw: add

Re: [edk2] [PATCH] MdePkg BaseExtractGuidedSectionLib: R15917 removed useful information wrongly

2015-10-22 Thread Gao, Liming
Reviewed-by: Liming Gao <liming@intel.com> -Original Message- From: Zeng, Star Sent: Friday, October 23, 2015 12:41 PM To: edk2-devel@lists.01.org Cc: Gao, Liming Subject: [PATCH] MdePkg BaseExtractGuidedSectionLib: R15917 removed useful information wrongly As the title, this

Re: [edk2] [PATCH] BaseTools/Scripts: Add PatchCheck.py script

2015-10-21 Thread Gao, Liming
Jordan: I have no other comment. Reviewed-by: Liming Gao <liming@intel.com> Thanks Liming -Original Message- From: Justen, Jordan L Sent: Thursday, October 22, 2015 6:03 AM To: Zhu, Yonghong; Gao, Liming Cc: Bjorge, Erik C; edk2-devel@lists.01.org Subject: Re: [PATCH] Bas

Re: [edk2] [Patch] BaseTools: Allow decimal values in the EDK II meta-data file.

2015-11-08 Thread Gao, Liming
Reviewed-by: Liming Gao <liming@intel.com> > -Original Message- > From: Zhu, Yonghong > Sent: Tuesday, November 03, 2015 1:01 PM > To: edk2-devel@lists.01.org > Cc: Gao, Liming > Subject: [Patch] BaseTools: Allow decimal values in the EDK II meta-data file.

Re: [edk2] MdeModulePkg: Fix Xcode 6.3.2/clang compilation issues.

2015-11-10 Thread Gao, Liming
Andrew: The patch is missing. From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Andrew Fish Sent: Tuesday, November 10, 2015 3:18 PM To: edk2-devel Cc: Tian, Feng Subject: [edk2] MdeModulePkg: Fix Xcode 6.3.2/clang compilation issues. Please review the following patches

Re: [edk2] Authentication status for signed FVs extracted in PEI

2015-11-10 Thread Gao, Liming
Eugene: Another idea is to update FV HOB to include authentication status instead of adding FV HOB3. The consumer code can check FV HOB Length to know whether FV HOB includes authentication status. Thanks Liming > -Original Message- > From: edk2-devel

Re: [edk2] [PATCH] MdeModulePkg PeiCore: PEI dispatcher need retry to process NOT_DISPATCHED FV

2015-11-12 Thread Gao, Liming
Reviewed-by: Liming Gao <liming@intel.com> > -Original Message- > From: Zeng, Star > Sent: Wednesday, November 11, 2015 6:07 PM > To: edk2-devel@lists.01.org > Cc: Gao, Liming > Subject: [PATCH] MdeModulePkg PeiCore: PEI dispatcher need retry to proc

Re: [edk2] [Patch] BaseTools/toolsetup.bat: fixed the error when the path contains space

2015-11-16 Thread Gao, Liming
Reviewed-by: Liming Gao <liming@intel.com> -Original Message- From: Zhu, Yonghong Sent: Thursday, November 12, 2015 4:24 PM To: edk2-devel@lists.01.org Cc: Gao, Liming; carl.mil...@pnnl.gov Subject: [Patch] BaseTools/toolsetup.bat: fixed the error when the path contains space

Re: [edk2] [Patch] BaseTools: Fix two warning reported in the make phase.

2015-11-16 Thread Gao, Liming
Reviewed-by: Liming Gao <liming@intel.com> -Original Message- From: Zhu, Yonghong Sent: Thursday, November 12, 2015 4:22 PM To: edk2-devel@lists.01.org Cc: Gao, Liming; heyi@linaro.org Subject: [Patch] BaseTools: Fix two warning reported in the make phase. when we make Bas

Re: [edk2] MdePkg: Enable Xcode build of BaseLib without

2015-11-10 Thread Gao, Liming
Reviewed-by: Liming Gao <liming@intel.com> > -Original Message- > From: af...@apple.com [mailto:af...@apple.com] > Sent: Tuesday, November 10, 2015 3:18 PM > To: edk2-devel > Cc: Gao, Liming; Kinney, Michael D > Subject: MdePkg: Enable Xcode build of BaseLib wi

Re: [edk2] MdePkg: Enable Xcode build of BaseLib without

2015-11-10 Thread Gao, Liming
This patch is committed at r18766. Thanks Liming From: af...@apple.com [mailto:af...@apple.com] Sent: Tuesday, November 10, 2015 11:31 PM To: Gao, Liming Cc: edk2-devel; Kinney, Michael D Subject: Re: MdePkg: Enable Xcode build of BaseLib without On Nov 10, 2015, at 12:22 AM, Gao, Liming

Re: [edk2] [Patch] BaseTools/GenFw: add new option to not zero PE/COFF optional header fields

2015-11-10 Thread Gao, Liming
Reviewed-by: Liming Gao <liming@intel.com> > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Yonghong Zhu > Sent: Monday, November 09, 2015 3:33 PM > To: edk2-devel@lists.01.org > Cc: Gao, Liming; carl.mil...@p

Re: [edk2] MdePkg: Enable Xcode build of BaseLib without

2015-11-10 Thread Gao, Liming
chain, because nasm compiler has one issue to generate Debug Format. Do you know the latest status for it? Thanks Liming > -Original Message- > From: af...@apple.com [mailto:af...@apple.com] > Sent: Wednesday, November 11, 2015 12:25 PM > To: Justen, Jordan L > Cc: Gao,

Re: [edk2] [Patch 0/4] AppPkg/Python: Port Python 2.7.10 to EDK II

2015-11-08 Thread Gao, Liming
Scott > Duplichan > Sent: Friday, November 06, 2015 10:38 PM > To: Gao, Liming; 'Daryl McDaniel' > Cc: edk2-de...@ml01.01.org > Subject: Re: [edk2] [Patch 0/4] AppPkg/Python: Port Python 2.7.10 to EDK II > > Hello Liming, > > I see what you mean. With Microsoft Outlook Fi

Re: [edk2] [PATCH] BaseTools GCC: move PECOFF_HEADER_SIZE definition before LD script

2015-11-09 Thread Gao, Liming
Reviewed-by: Liming Gao <liming@intel.com> -Original Message- From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] Sent: Monday, November 9, 2015 4:34 PM To: edk2-devel@lists.01.org; Gao, Liming; Zhu, Yonghong Cc: Hao, Xudong; Ard Biesheuvel Subject: [PATCH] BaseTools GCC

Re: [edk2] RELEASE_DDK3790_X64_DLINK_FLAGS has machine:AMD64

2015-11-03 Thread Gao, Liming
Sathya: DDK3790 tool chain matches Microsoft WINDDK version 3790.1830. For this version WINDDK, AMD64 is used for X64 Machine type. Thanks Liming -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Andrew Fish Sent: Wednesday, November 04, 2015

Re: [edk2] RE uses the version information in application .EFI file: edk2-devel Digest, Vol 4, Issue 214

2015-11-02 Thread Gao, Liming
. -- Message: 7 Date: Thu, 29 Oct 2015 09:15:07 + From: "Gao, Liming" <liming@intel.com> To: "Miller, Carl H" <carl.mil...@pnnl.gov>, "edk2-devel@lists.01.org" <edk2-devel@lists.01.org> Subject: Re: [edk2] [PATCH] BaseTools/GenFw: add option t

Re: [edk2] [Patch] BaseTools: Print PACKAGES_PATH build environment if it is set.

2015-11-05 Thread Gao, Liming
", ExtraData=WorkspaceDir) os.environ["WORKSPACE"] = WorkspaceDir Thanks Liming -Original Message- From: Kinney, Michael D Sent: Friday, November 06, 2015 9:14 AM To: Gao, Liming; edk2-devel@lists.01.org; Kinney, Michael D Subject: RE: [edk2]

Re: [edk2] [Patch] BaseTools: Print PACKAGES_PATH build environment if it is set.

2015-11-05 Thread Gao, Liming
--Original Message- From: Kinney, Michael D Sent: Thursday, November 05, 2015 7:46 AM To: Gao, Liming; edk2-devel@lists.01.org; Kinney, Michael D Subject: RE: [edk2] [Patch] BaseTools: Print PACKAGES_PATH build environment if it is set. Liming, Why do you a different method than WORKSPACE

Re: [edk2] [Patch 0/4] AppPkg/Python: Port Python 2.7.10 to EDK II

2015-11-05 Thread Gao, Liming
Scott: When I get the mail in outlook, how I save this mail as Git patch? I try saving the mail by File->Save as->Save as Txt. I find the saved txt file includes Tab in header and the wrapped line. It can't be applied as the git patch. Thanks Liming -Original Message- From:

Re: [edk2] [PATCH] SecurityPkg: Remove temp return solution in PeiRsa2048Sha256 Section Lib

2015-11-02 Thread Gao, Liming
Reviewed-by: Liming Gao <liming@intel.com> -Original Message- From: Zhang, Chao B Sent: Tuesday, November 03, 2015 11:03 AM To: edk2-devel@lists.01.org Cc: eug...@hp.com; Gao, Liming Subject: [PATCH] SecurityPkg: Remove temp return solution in PeiRsa2048Sha256 Section Lib P

Re: [edk2] [Patch V2] Update register hot key logic, return EFI_ALREADY_START status if same hot key already existed.

2015-10-14 Thread Gao, Liming
Reviewed-by: Liming Gao <liming@intel.com> -Original Message- From: Dong, Eric Sent: Wednesday, October 14, 2015 11:29 AM To: edk2-devel@lists.01.org Cc: Gao, Liming; Yao, Jiewen Subject: [Patch V2] Update register hot key logic, return EFI_ALREADY_START status if same h

Re: [edk2] [Patch 0/2] Refine vfr grammar, keep consistent for the same condition opcode.

2015-10-14 Thread Gao, Liming
Reviewed-by: Liming Gao <liming@intel.com> -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Eric Dong Sent: Wednesday, October 14, 2015 4:29 PM To: edk2-devel@lists.01.org Subject: [edk2] [Patch 0/2] Refine vfr grammar, keep cons

Re: [edk2] [Patch] MdeModulePkg SetupBrowserDxe: Save global variable values before nest function called.

2015-10-21 Thread Gao, Liming
Reviewed-by: Liming Gao <liming@intel.com> -Original Message- From: Dong, Eric Sent: Friday, October 16, 2015 9:34 AM To: edk2-devel@lists.01.org Cc: Gao, Liming; Bi, Dandan Subject: [Patch] MdeModulePkg SetupBrowserDxe: Save global variable values before nest function

Re: [edk2] [PATCH 2/2] MdePkg/PeCoffLoader: fix handling of ARM MOVW/MOVT instruction relocs

2015-10-09 Thread Gao, Liming
Reviewed-by: Liming Gao <liming@intel.com> -Original Message- From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] Sent: Friday, October 09, 2015 3:24 AM To: Leif Lindholm Cc: edk2-devel@lists.01.org; Gao, Liming; Zhu, Yonghong; Kinney, Michael D Subject: Re: [PATCH 2/2]

Re: [edk2] [BaseTool][UPT][patch]Fix two wrong import for UPT

2015-10-09 Thread Gao, Liming
Reviewed-by: Liming Gao <liming@intel.com> -Original Message- From: Chen, Hesheng Sent: Saturday, October 10, 2015 1:43 PM To: Gao, Liming; edk2-devel@lists.01.org Subject: [BaseTool][UPT][patch]Fix two wrong import for UPT Hello Liming and all, Could you help review this

Re: [edk2] [PATCH] MdeModulePkg PeiCore: PeiInstallPeiMemory improper ASSERT test on second call

2015-11-17 Thread Gao, Liming
Reviewed-by: Liming Gao <liming@intel.com> -Original Message- From: Zeng, Star Sent: Tuesday, November 17, 2015 5:47 PM To: edk2-devel@lists.01.org Cc: Gao, Liming Subject: [PATCH] MdeModulePkg PeiCore: PeiInstallPeiMemory improper ASSERT test on second call The ASSERT (Priva

Re: [edk2] Question about memory reservation from PrePi to DXE

2015-08-27 Thread Gao, Liming
, August 27, 2015 4:50 AM To: Gao, Liming; Tian, Feng Cc: Kinney, Michael D; edk2-devel@lists.01.org; Laszlo Ersek; Andrew Fish Subject: Re: [edk2] Question about memory reservation from PrePi to DXE On Wed, 2015-08-26 at 15:31 +, Gao, Liming wrote: Ben: CoreInitializeMemoryServices() API tries

Re: [edk2] [Patch] DisplayEngineDxe: Fixed calculate help string page count error.

2015-08-27 Thread Gao, Liming
Reviewed-by: Liming Gao liming@intel.com -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Eric Dong Sent: Friday, August 28, 2015 10:45 AM To: edk2-devel@lists.01.org Cc: Gao, Liming Subject: [edk2] [Patch] DisplayEngineDxe: Fixed calculate

Re: [edk2] [PATCH] MdePkg: Refine the device path text format for Bluetooth to follow spec.

2015-08-27 Thread Gao, Liming
Reviewed-by: Liming Gao liming@intel.com -Original Message- From: Qiu, Shumin Sent: Friday, August 28, 2015 10:35 AM To: edk2-devel@lists.01.org Cc: Qiu, Shumin; Gao, Liming Subject: [PATCH] MdePkg: Refine the device path text format for Bluetooth to follow spec. Cc: Liming Gao

Re: [edk2] [Patch] MdePkg: Change the EFI_ACPI_PNP_HID_END to EFI_PNP_ID (0x0000)

2015-08-27 Thread Gao, Liming
Reviewed-by: Liming Gao liming@intel.com -Original Message- From: Ni, Ruiyu Sent: Thursday, August 27, 2015 4:54 PM To: edk2-devel@lists.01.org Cc: Ni, Ruiyu; Gao, Liming Subject: [Patch] MdePkg: Change the EFI_ACPI_PNP_HID_END to EFI_PNP_ID (0x) The current value doesn't follow

Re: [edk2] PCD error in new BaseTools

2015-08-31 Thread Gao, Liming
Evan: I create this usage with the latest BaseTools. It can work. Build tool version: build.exe Version 0.60 Build 18320. Could you let us know which version BaseTools is used? And, where to get your DSC file? I don't find such usage in EDKII ArmPkg and ArmPlatformPkg. Thanks Liming

Re: [edk2] [PATCH 4/10] MdeModulePkg: Support format string argument checking

2015-08-26 Thread Gao, Liming
Scott: I find this change will impact the check result of ECC tool. This tool is in BaseTools directory that is used to check the coding style in source file. I think we need to investigate how to enhance ECC to support EFIFORMAT. Thanks Liming -Original Message- From: edk2-devel

Re: [edk2] [PATCH] MdeModulePkg FaultTolerantWrite: Error handling for erase operation failure

2015-08-26 Thread Gao, Liming
Reviewed-by: Liming Gao liming@intel.com -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Star Zeng Sent: Wednesday, August 26, 2015 11:36 AM To: edk2-devel@lists.01.org Cc: Gao, Liming Subject: [edk2] [PATCH] MdeModulePkg FaultTolerantWrite

Re: [edk2] Question about memory reservation from PrePi to DXE

2015-08-25 Thread Gao, Liming
Seemly, the patch is ignored. I send patch mail. Please check. -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Gao, Liming Sent: Tuesday, August 25, 2015 2:13 PM To: Benjamin Herrenschmidt; Tian, Feng Cc: Kinney, Michael D; edk2-devel@lists.01

Re: [edk2] Question about memory reservation from PrePi to DXE

2015-08-25 Thread Gao, Liming
Ben: I agree this is an issue. PI spec has no limitation to create memory allocation hob. Memory may be allocated in either the HOB producer phase memory area or other areas of present and initialized system memory. DxeCore shouldn't assume the memory allocation hob are all created by PEI

Re: [edk2] [patch 1/2] BaseTools:To generate string default type correctly in VfrCompiler

2015-08-26 Thread Gao, Liming
Reviewed-by: Liming Gao liming@intel.com -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Dandan Bi Sent: Wednesday, August 26, 2015 4:46 PM To: Dong, Eric; Gao, Liming; edk2-devel@lists.01.org Subject: [edk2] [patch 1/2] BaseTools:To generate

Re: [edk2] [patch 2/2] MdeModulePkg:Set default string value

2015-08-26 Thread Gao, Liming
Reviewed-by: Liming Gao liming@intel.com -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Dandan Bi Sent: Wednesday, August 26, 2015 4:46 PM To: Dong, Eric; Gao, Liming; edk2-devel@lists.01.org Subject: [edk2] [patch 2/2] MdeModulePkg:Set

Re: [edk2] [PATCH 1/10] BaseTools: Add GCC patch for EDK2 format string argument checking

2015-08-26 Thread Gao, Liming
Message- From: Scott Duplichan [mailto:sc...@notabs.org] Sent: Saturday, August 08, 2015 2:08 PM To: edk2-devel@lists.01.org Cc: Liu, Yingke D; Gao, Liming Subject: [PATCH 1/10] BaseTools: Add GCC patch for EDK2 format string argument checking Add patch to extend GCC format string argument

Re: [edk2] Question about memory reservation from PrePi to DXE

2015-08-26 Thread Gao, Liming
. Thanks Liming -Original Message- From: Benjamin Herrenschmidt [mailto:b...@kernel.crashing.org] Sent: Tuesday, August 25, 2015 6:33 PM To: Gao, Liming; Tian, Feng Cc: Kinney, Michael D; edk2-devel@lists.01.org; Laszlo Ersek; Andrew Fish Subject: Re: [edk2] Question about memory reservation

Re: [edk2] [PATCH 03/58] MdePkg: BaseExtractGuidedSectionLib: allow forced reinit of handler table

2015-09-07 Thread Gao, Liming
-Original Message- From: Justen, Jordan L Sent: Monday, September 07, 2015 2:32 AM To: Gao, Liming; Laszlo Ersek; edk2-devel@lists.01.org; Kinney, Michael D Subject: RE: [edk2] [PATCH 03/58] MdePkg: BaseExtractGuidedSectionLib: allow forced reinit of handler table On 2015-09-05 23:43:27, Gao

Re: [edk2] [PATCH] MdePkg: Add UefiDebugLibDebugPortProtocol to output logs via EFI_DEBUGPORT_PROTOCOL.Write.

2015-09-05 Thread Gao, Liming
Masamitsu: Could you attach the patch file to me? I can help you commit it. Reviewed-by: Liming Gao <liming@intel.com> Thanks Liming -Original Message- From: Masamitsu MURASE [mailto:masamitsu.mur...@gmail.com] Sent: Thursday, September 03, 2015 2:09 AM To: Gao, Liming

Re: [edk2] [PATCH] MdePkg: Add UefiDebugLibDebugPortProtocol to output logs via EFI_DEBUGPORT_PROTOCOL.Write.

2015-09-08 Thread Gao, Liming
Commit to EDKII at 18414. And EDKII 18415, I correct protocol usage description in INF. -Original Message- From: Masamitsu MURASE [mailto:masamitsu.mur...@gmail.com] Sent: Thursday, September 03, 2015 2:09 AM To: Gao, Liming; edk2-devel@lists.01.org Subject: [edk2] [PATCH] MdePkg: Add

Re: [edk2] How do I get rid of /ALIGN:32 ?

2015-09-08 Thread Gao, Liming
Shubha: You can override it in [BuildOptions] section of your DSC file. You can see the example in Nt32Pkg\Nt32Pkg.dsc file that overrides its value to 4096. [BuildOptions] DEBUG_*_*_DLINK_FLAGS = /EXPORT:InitializeDriver=$(IMAGE_ENTRY_POINT) /BASE:0x1 /ALIGN:4096 /FILEALIGN:4096

Re: [edk2] [PATCH] MdePkg: Add UefiDebugLibDebugPortProtocol to output logs via EFI_DEBUGPORT_PROTOCOL.Write.

2015-09-02 Thread Gao, Liming
Masamitsu: Thanks for your contribution. UefiDebugLibDebugPortProtocol library is a good solution for your usage model. I agree to add it into MdePkg. For this patch, I have some minor comments. 1) Refer to BaseDebugLibSerialPort instance, DebugPortProtocolWrite() API can have two

Re: [edk2] Can someone please post a working modification to build_rules.txt for yasm ?

2015-09-06 Thread Gao, Liming
Hi, In tools_def.txt, there is no definition YASM_PATH. Please add new line to define YASM PATH. *_VS2010_X64_ASM_PATH = DEF(YASM_BIN)\yasm.exe *_VS2010_X64_YASM_PATH = DEF(YASM_BIN)\yasm.exe #add Thanks Liming -Original Message- From: edk2-devel

Re: [edk2] [PATCH v3 0/4] enable Properties Table mem protection for ARM

2015-09-10 Thread Gao, Liming
Thanks. I am fine to GenFw tool change. Liming -Original Message- From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] Sent: Thursday, September 10, 2015 5:44 PM To: Gao, Liming Cc: edk2-devel@lists.01.org; leif.lindh...@linaro.org; Liu, Yingke D; sigmaepsilo...@gmail.com; ler

Re: [edk2] [PATCH] MdePkg: Refine UefiFileHandleLib to avoid write non-ASCII char into ASCII file.

2015-09-09 Thread Gao, Liming
Reviewed-by: Liming Gao <liming@intel.com> -Original Message- From: Qiu, Shumin Sent: Tuesday, September 08, 2015 3:05 PM To: edk2-devel@lists.01.org Cc: Qiu, Shumin; Carsey, Jaben; Gao, Liming Subject: [PATCH] MdePkg: Refine UefiFileHandleLib to avoid write non-ASCI

Re: [edk2] [PATCH] BaseTools/GenFw: align RVA of debug

2015-09-09 Thread Gao, Liming
: edk2-devel@lists.01.org; Gao, Liming; Liu, Yingke D Cc: leif.lindh...@linaro.org; ler...@redhat.com; Ard Biesheuvel Subject: [PATCH] BaseTools/GenFw: align RVA of debug SVN commit r18077 ("BaseTools/GenFw: move .debug contents to .data to save space") removed the separate .debug sect

Re: [edk2] Section Alignment of elf binaries compiled with GCC(Linux)

2015-09-09 Thread Gao, Liming
Michael: Do you use the linker script BaseTools/Scripts/GccBase.lds and -z common-page-size=4096? Thanks Liming From: Michael Zimmermann [mailto:sigmaepsilo...@gmail.com] Sent: Wednesday, September 9, 2015 3:22 PM To: Yao, Jiewen Cc: Gao, Liming; edk2-devel@lists.01.org Subject: Re: [edk2

Re: [edk2] [PATCH] BaseTools/GenFw: align RVA of debug

2015-09-11 Thread Gao, Liming
Reviewed-by: Liming Gao <liming@intel.com> Besides, Dennis doesn't own BaseTools any longer. Thanks Liming -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ard Biesheuvel Sent: Friday, September 11, 2015 2:53 PM To: edk2-devel@lists.

Re: [edk2] [PATCH] BaseTools/GenFw: align RVA of debug

2015-09-11 Thread Gao, Liming
Yes. I will update Maintainers.txt. -Original Message- From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] Sent: Friday, September 11, 2015 3:05 PM To: Gao, Liming Cc: edk2-devel@lists.01.org; Liu, Yingke D; Laszlo Ersek; Leif Lindholm Subject: Re: [edk2] [PATCH] BaseTools/GenFw

Re: [edk2] [Patch 1/5] MdeModulePkg: Move OEMBadging protocol from IntelFrameworkModulePkg

2015-09-29 Thread Gao, Liming
Jordan: I add my comments. Thanks Liming -Original Message- From: Justen, Jordan L Sent: Tuesday, September 29, 2015 2:40 PM To: Ni, Ruiyu; edk2-devel@lists.01.org Cc: Tian, Feng; Fan, Jeff; Kinney, Michael D; Gao, Liming Subject: RE: [edk2] [Patch 1/5] MdeModulePkg: Move OEMBadging

  1   2   3   4   5   6   7   8   9   10   >