Hello,
Gustav Wikström writes:
> Surely custom code for file links. Haven't dug much deeper since the
> issue is solved by the attached patch.
Certainly, but that means `org-export-link-as-file' is not working at
some level. Since adding a hook is better, and the function was not used
anymore,
Hello,
> -Original Message-
> From: Nicolas Goaziou
> Sent: den 26 februari 2020 16:23
> To: Gustav Wikström
> Cc: Bastien ; emacs-orgmode@gnu.org
> Subject: Re: attachment: link type export to HTML invalid attach dir
>
> Hello,
>
> Gustav Wikström write
Hello,
Gustav Wikström writes:
> Expanding attachment-links in the buffer makes the link type no longer
> be attachment.
What makes you think that? The link type is preserved during the
substitution, according to the (concat "attachment" ...).
> I would prefer if we explicitly set the link
Hi Bastien and Nicolas,
> -Original Message-
> From: Bastien
> Sent: den 22 februari 2020 14:32
> To: Nicolas Goaziou
> Cc: Gustav Wikström ; emacs-orgmode@gnu.org
> Subject: Re: attachment: link type export to HTML invalid attach dir
>
> [...]
>
> Nicol
Hi,
Thanks for your answer.
Nicolas Goaziou writes:
> I'd like to hear from Gustav, too, since this affects the changes he
> introduced. If you are in a hurry, we can also apply it. Up to you.
I just applied it - Gustav let us know if it fits your needs and if it
does not introduce
Hello,
Bastien writes:
> Thanks a lot -- feel free to apply it when you think it's okay.
I'd like to hear from Gustav, too, since this affects the changes he
introduced. If you are in a hurry, we can also apply it. Up to you.
> Also, perhaps can you or Gustav suggest a way to test the new
Hi Nicolas,
Nicolas Goaziou writes:
> This second patch removes most of the "attachment" leakage in the code
> base (mainly "org-element.el" and "ox-*.el"). The features should be the
> same as before. Let me know if there's anything wrong.
Thanks a lot -- feel free to apply it when you think
Following up,
Nicolas Goaziou writes:
> This is the first part of the suggested changes. These do not touch
> attachment modifications, but rather improve the tooling in "ol.el".
This second patch removes most of the "attachment" leakage in the code
base (mainly "org-element.el" and
Hi Nicolas,
Nicolas Goaziou writes:
> Thinking about it, we can stick to a single solution, e.g., the
> `condition-case' workaround. Therefore we do not need to introduce a new
> keyword. However, all "ol-" libraries need to be updated.
I think the release of 9.4 is an important one, so it's
Hello,
Bastien writes:
> I'm not sure why the distinction between :open and :follow is needed
> in the context of the discussion for exporting attachments: is it
> because attachment need to be "open", not just followed?
The motivation is that the new behaviour for `:follow' is not compatible
Nicolas Goaziou writes:
>> FWIW, I'm for delaying the removal for 9.5, not 9.4.
>
> Sure, I added it back.
Thanks!
--
Bastien
Hello,
Bastien writes:
> FWIW, I'm for delaying the removal for 9.5, not 9.4.
Sure, I added it back.
Regards,
--
Nicolas Goaziou
Hi Nicolas,
Nicolas Goaziou writes:
> That is subconscious, actually. I considered removing them,
> then hesitated, and it all ended up in an intermediate state. Removing
> it properly would require to remove :application property in the parser,
> too. At some point, this functionality needs to
Hi Nicolas,
Nicolas Goaziou writes:
> This is the first part of the suggested changes. These do not touch
> attachment modifications, but rather improve the tooling in "ol.el".
Thanks for working on this--and Kyle for the careful review.
> `org-link-parameters' accepts a new property, :open,
Hello,
Kyle Meyer writes:
> It looks like a good direction to go.
Thank you for the feedback!
I fixed the various typos you mentioned.
> As far as I can see (by looking at the diff and quickly testing), the
> file+{sys,emacs} functionality is being removed. That's probably
> okay/intended,
Nicolas Goaziou writes:
> In a nutshell:
>
> `org-link-parameters' accepts a new property, :open, which is
> like :follow, but function installed there is called with a universal
> prefix argument. It could replace :follow altogether, but for
> compatibility reasons, they both live side by side
Hello,
Bastien writes:
>>> Now, I'm not sure who wants to try implementing Nicolas suggestion to
>>> let ox.el expand attachments into file links: since you both know the
>>> issue better than I do, I suggest one of you can try?
>>
>> I will try to propose a patch by tomorrow evening.
>
>
Nicolas Goaziou writes:
>> Now, I'm not sure who wants to try implementing Nicolas suggestion to
>> let ox.el expand attachments into file links: since you both know the
>> issue better than I do, I suggest one of you can try?
>
> I will try to propose a patch by tomorrow evening.
Thanks!
If
Hello,
Bastien writes:
> Now, I'm not sure who wants to try implementing Nicolas suggestion to
> let ox.el expand attachments into file links: since you both know the
> issue better than I do, I suggest one of you can try?
I will try to propose a patch by tomorrow evening.
Regards,
--
Okay, I've done my home work :)
TL;DR: (1) The change is fresh, let's take the time to work together
at making it right before 9.4*; (2) the current state with the line
3216 in org-element.el is not okay; (3) let's try implementing what
Nicolas suggests wrt to attachment=>file link resolution.
*
Hi Nicolas and Gustav,
Nicolas Goaziou writes:
> I'm Cc'ing Bastien because that particular point should be solved before
> any release, IMO.
Thanks for adding me to the loop.
I'll take the time today or tomorrow to understand what is at stake
here and of course, I won't release Org 9.4
tav Wikström ; Nicolas Goaziou
>
> Cc: Bastien Guerry ; emacs-orgmode@gnu.org
> Subject: RE: attachment: link type export to HTML invalid attach dir
>
> Gustav Wikström writes:
>
> >> Gustav Wikström writes:
> >>
> >> > Ah, you mean the reference on
Hi,
> -Original Message-
> From: Kyle Meyer
> Sent: den 14 februari 2020 03:42
> To: Gustav Wikström ; Nicolas Goaziou
>
> Cc: Bastien Guerry ; emacs-orgmode@gnu.org
> Subject: RE: attachment: link type export to HTML invalid attach dir
>
> Gustav Wikst
Hi,
> -Original Message-
> From: Nicolas Goaziou
> Sent: den 14 februari 2020 01:16
> To: Gustav Wikström
> Cc: emacs-orgmode@gnu.org; Bastien Guerry
> Subject: Re: attachment: link type export to HTML invalid attach dir
>
> Gustav Wikström writes:
>
>
Gustav Wikström writes:
>> Gustav Wikström writes:
>>
>> > Ah, you mean the reference on line 3216. No, I don't think it can be
>> > removed. And I honestly don't think it should be either. It's there to
>> > let attachment links mirror the peculiarities of file links. It's
>> > needed for
Gustav Wikström writes:
> What makes attachment links not be a core link type?
1. Org Attach is not loaded by default
2. Implementing Org syntax doesn't require to implement attachments
Attachment links are in the same category as Docview links, for example.
There is no "docview" occurrence
> -Original Message-
> From: Nicolas Goaziou
> Sent: den 13 februari 2020 22:38
> To: Gustav Wikström
> Cc: emacs-orgmode@gnu.org; Bastien Guerry
> Subject: Re: attachment: link type export to HTML invalid attach dir
>
> Gustav Wikström writes:
>
>
Continuation from previous answer,
> -Original Message-
> From: Nicolas Goaziou
> Sent: den 13 februari 2020 21:41
> To: Gustav Wikström
> Cc: emacs-orgmode@gnu.org; Bastien Guerry
> Subject: Re: attachment: link type export to HTML invalid attach dir
>
> [...
Gustav Wikström writes:
> Ah, you mean the reference on line 3216. No, I don't think it can be
> removed. And I honestly don't think it should be either. It's there to
> let attachment links mirror the peculiarities of file links. It's
> needed for feature compatibility. I don't see the issue
Hi,
Partial answer for now;
> -Original Message-
> From: Nicolas Goaziou
> Sent: den 13 februari 2020 21:41
> To: Gustav Wikström
> Cc: emacs-orgmode@gnu.org; Bastien Guerry
> Subject: Re: attachment: link type export to HTML invalid attach dir
>
> [...]
>
Hello,
Gustav Wikström writes:
> Unless search-option applies as a general construct for all link types
> I don't think it should be in the parser. Given the discussion we've
> had about design of the parser from before. I.e. if the parser isn't
> supposed to know anything about the specific
Hi,
> -Original Message-
> From: Nicolas Goaziou
> Sent: den 7 februari 2020 15:28
> To: Gustav Wikström
> Cc: emacs-orgmode@gnu.org
> Subject: Re: attachment: link type export to HTML invalid attach dir
>
> > Hmm, maybe that is so.. Except raw-path
Hello,
Gustav Wikström writes:
> Hmm, maybe that is so.. Except raw-path is called path (not really an
> issue though) and there is another property called raw-link. Not sure
> how to interpret the use of both path and raw-link. And there are
> things happening between parsing the actual buffer
Hi again,
> -Original Message-
> From: Nicolas Goaziou
> Sent: den 5 februari 2020 17:54
> To: Gustav Wikström
> Cc: emacs-orgmode@gnu.org
> Subject: Re: attachment: link type export to HTML invalid attach dir
>
> > That was kind of what I was trying to do
Hello,
Gustav Wikström writes:
> That was kind of what I was trying to do, by allowing subtyping, so
> that the parser would be more knowledgeable about particular types of
> links, by allowing extended attributes. Maybe not implemented in the
> most extensible way though I'll admit.
Just to
Hi again,
> -Original Message-
> From: Nicolas Goaziou
> Sent: den 20 januari 2020 02:25
> To: Gustav Wikström
> Cc: emacs-orgmode@gnu.org
> Subject: Re: attachment: link type export to HTML invalid attach dir
>
> Gustav Wikström writes:
>
> > Ok, no
Gustav Wikström writes:
> Ok, noted. To my defense I was thinking more in the terms of subtyping
> then hardcoding. Because we have multiple link types which try to
> share an interface. But the interface isn't perfect for all different
> kinds of links.
Then, I suggest to improve the
Hi Nicolas,
Thanks for your comments!
> -Original Message-
> From: Nicolas Goaziou
> Sent: den 19 januari 2020 22:12
> To: Gustav Wikström
> Cc: emacs-orgmode@gnu.org
> Subject: Re: attachment: link type export to HTML invalid attach dir
>
> Hello,
>
Hello,
Gustav Wikström writes:
> Functionally it's in a good (and maintainable) state right now, in my
> opinion. But I do understand that the contextual attribute added to
> the parser may require some discussion.
This is not my main gripe here, although I'm not convinced that extra
attribute
Hi,
> -Original Message-
> From: Nicolas Goaziou
> Sent: den 18 januari 2020 12:34
> To: Gustav Wikström
> Cc: emacs-orgmode@gnu.org
> Subject: Re: attachment: link type export to HTML invalid attach dir
>
> Hello,
>
> Gustav Wikström writes:
>
>
Hello,
Gustav Wikström writes:
> Ok, so change pushed...
I'm sorry, but this is going too fast. We're discussing core design here
(the parser), and I couldn't even answer your proposal. Let's at least
reach an agreement on the change to make.
Regards,
--
Nicolas Goaziou
age-
> From: Gustav Wikström
> Sent: den 17 januari 2020 19:36
> To: Nicolas Goaziou
> Cc: emacs-orgmode@gnu.org
> Subject: RE: attachment: link type export to HTML invalid attach dir
>
> Hi again,
>
> > -Original Message-
> > From: Gustav Wikst
Hi again,
> -Original Message-
> From: Gustav Wikström
> Sent: den 17 januari 2020 15:30
> To: 'Nicolas Goaziou'
> Cc: emacs-orgmode@gnu.org
> Subject: RE: attachment: link type export to HTML invalid attach dir
>
> Hi,
>
> [...]
>
> >
> >
Hi,
> -Original Message-
> From: Nicolas Goaziou
> Sent: den 17 januari 2020 01:40
> To: Gustav Wikström
> Cc: emacs-orgmode@gnu.org
> Subject: Re: attachment: link type export to HTML invalid attach dir
>
> Gustav Wikström writes:
>
> > Hardcoding th
Gustav Wikström writes:
> Hardcoding the translation of attachment-links into file-links in an
> in-between layer (ox.el - that is somewhat complicated as well) is not
> transparent and I think best to avoid. Even if an attachment link is
> /very/ similar to a file link it may be best still to
Hi again,
> -Original Message-
> From: Gustav Wikström
> Sent: den 16 januari 2020 22:42
> To: Nicolas Goaziou
> Cc: numbch...@gmail.com; emacs-orgmode@gnu.org
> Subject: RE: attachment: link type export to HTML invalid attach dir
>
> Hi Nicolas,
>
Hi Nicolas,
> -Original Message-
> From: Nicolas Goaziou
> Sent: den 16 januari 2020 14:18
> To: Gustav Wikström
> Cc: numbch...@gmail.com; emacs-orgmode@gnu.org
> Subject: Re: attachment: link type export to HTML invalid attach dir
>
> Hello,
>
> Gust
Hello,
Gustav Wikström writes:
> Ah yes. Found the culprit for this issue. Hopefully the last one. The
> exporter doesn't actually move the point in the buffer during the
> export. So org-attach-expand tried to expand from the first character
> in the buffer. This should be fixed from a few
Gustav Wikström writes:
> Hi,
>
>> -Original Message-
>> From: stardiviner
>> Sent: den 15 januari 2020 06:53
>> To: Gustav Wikström
>> Cc: numbch...@gmail.com; emacs-orgmode@gnu.org
>> Subject: Re: attachment: link type export to HTML inva
Hi,
> -Original Message-
> From: stardiviner
> Sent: den 15 januari 2020 06:53
> To: Gustav Wikström
> Cc: numbch...@gmail.com; emacs-orgmode@gnu.org
> Subject: Re: attachment: link type export to HTML invalid attach dir
>
> [...]
>
> I checked ou
Gustav Wikström writes:
> Hi again,
>
>> -Original Message-
>> From: Emacs-orgmode On
>> Behalf Of stardiviner
>> Sent: den 14 januari 2020 06:04
>> To: Gustav Wikström
>> Cc: emacs-orgmode@gnu.org
>> Subject: Re: attachm
Hi again,
> -Original Message-
> From: Emacs-orgmode On
> Behalf Of stardiviner
> Sent: den 14 januari 2020 06:04
> To: Gustav Wikström
> Cc: emacs-orgmode@gnu.org
> Subject: Re: attachment: link type export to HTML invalid attach dir
>
> [...]
>
> Many
Gustav Wikström writes:
> Hi!
>
> Thanks for reporting this!
>
> The code is updated on the master branch to make the exporters aware of how
> to deal with attachment links. Commit d70db54db for the curious. Basically,
> attachment links are expanded into file-links by the exporters now,
in the respective markup language.
Regards
Gustav
From: Emacs-orgmode on behalf of
stardiviner
Sent: Monday, January 13, 2020 13:24
To: emacs-orgmode@gnu.org
Subject: Re: attachment: link type export to HTML invalid attach dir
When I export with =[C-c C-e h
When I export with =[C-c C-e h o]=, I found attached inline image links are not
displayed in HTML page.
Here is Org content:
#+begin_src org
,** Strings are not Lists, but Anyway…
:PROPERTIES:
:ID: 2fd354f3-ac7a-499d-9fe4-a76626bbdb38
:END:
In Calva Paredit,
55 matches
Mail list logo
