[FFmpeg-devel] [PATCH] avformat/hls: Properly expose intercepted ID3 tags to the API.

From: Richard Shaffer The HLS demuxer will process any ID3 tags at the beginning of a segment in order to obtain timestamp data. However, when this data was parsed on a second or subsequent segment, the updated metadata would be discarded. This change preserves the data and

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/qtrle: Do not output duplicated frames on insufficient input

On Wed, May 16, 2018 at 12:53:46AM +0200, Carl Eugen Hoyos wrote: > 2018-05-16 0:29 GMT+02:00, Hendrik Leppkes : > > > It makes no real difference if its less efficient or whatever - > > if a codec specification asks for this behavior, then our > > decoders should act

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/qtrle: Do not output duplicated frames on insufficient input

On Thu, May 17, 2018 at 11:49 AM, Michael Niedermayer wrote: > On Wed, May 16, 2018 at 12:53:46AM +0200, Carl Eugen Hoyos wrote: >> 2018-05-16 0:29 GMT+02:00, Hendrik Leppkes : >> >> > It makes no real difference if its less efficient or whatever - >>

[FFmpeg-devel] [PATCH] avutil/error: document av_err2str

--- libavutil/error.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavutil/error.h b/libavutil/error.h index 71df4da..b357bfa 100644 --- a/libavutil/error.h +++ b/libavutil/error.h @@ -115,6 +115,9 @@ static inline char *av_make_error_string(char *errbuf, size_t errbuf_size, int e

[FFmpeg-devel] [PATCH] avfilter/vsrc_testsrc: add pal75bars and pal100bars video filter sources

Generates color bar test patterns based on EBU PAL recommendations. Signed-off-by: Tobias Rapp --- Changelog| 1 + doc/filters.texi | 10 +++- libavfilter/Makefile | 2 + libavfilter/allfilters.c | 2 +

Re: [FFmpeg-devel] [PATCH] cmdutils - don't search for option 'default'

On Wed, May 16, 2018 at 09:21:49PM +0530, Gyan Doshi wrote: > > cmdutils.c |2 -- > 1 file changed, 2 deletions(-) > 495ccaae10f8873dc5070858d11c0c3093ce92b4 > 0001-cmdutils-don-t-search-for-option-default.patch > From 20a0544d66b5b3b9ebc3e03049a134d13706bda9 Mon Sep 17 00:00:00 2001 >

Re: [FFmpeg-devel] [PATCH] avutil/error: hidden macro av_err2str for C++

On Thu, 17 May 2018 05:50:55 +0100 Rostislav Pehlivanov wrote: > On 17 May 2018 at 05:46, Zhao Zhili wrote: > > > --- > > libavutil/error.h | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/libavutil/error.h b/libavutil/error.h > >

Re: [FFmpeg-devel] [PATCH]lavc/v210dec: Skip Canopus C210 extradata

2018-05-10 22:50 GMT+02:00, Carl Eugen Hoyos : > Peter Bubestinger provided a C210 file where every frame starts with > 64 bytes of extradata (24 byte "INFO", 16 byte "RDRT", rest "FIEL"). > Piotr confirmed that the Canopus decoder accepts files without the > extradata but

Re: [FFmpeg-devel] [PATCH] avutil/error: hidden macro av_err2str for C++

On 17.05.2018 06:46, Zhao Zhili wrote: > --- > libavutil/error.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/libavutil/error.h b/libavutil/error.h > index 71df4da..8a35fef 100644 > --- a/libavutil/error.h > +++ b/libavutil/error.h > @@ -116,8 +116,10 @@ static inline char

Re: [FFmpeg-devel] [PATCH] avutil/error: document av_err2str

On 17.05.2018 11:24, Zhao Zhili wrote: --- libavutil/error.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavutil/error.h b/libavutil/error.h index 71df4da..b357bfa 100644 --- a/libavutil/error.h +++ b/libavutil/error.h @@ -115,6 +115,9 @@ static inline char

Re: [FFmpeg-devel] compound literal in public header file

On Thu, 17 May 2018 00:41:10 +0200 Carl Eugen Hoyos wrote: > 2018-05-16 11:47 GMT+02:00, Steinar H. Gunderson > : > > On Wed, May 16, 2018 at 11:41:23AM +0200, Tobias Rapp wrote: > >> Yes, I am referring to usage of the libavutil headers in C.

Re: [FFmpeg-devel] [PATCH] avformat/hls: tag as AVFMT_TS_DISCONT

> I think I'm against this. HLS streams do not typically contain > timestamp resets (even if they could). Otherwise you might as well add > this flag to the Matroska demuxer. Besides, it would break some of my > code, which uses this flag as a heuristic to detect mpeg-ts style > non-container

Re: [FFmpeg-devel] [PATCH] avutil/error: document av_err2str

Zhao Zhili (2018-05-17): > --- > libavutil/error.h | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/libavutil/error.h b/libavutil/error.h > index 71df4da..b357bfa 100644 > --- a/libavutil/error.h > +++ b/libavutil/error.h > @@ -115,6 +115,9 @@ static inline char

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/qtrle: Do not output duplicated frames on insufficient input

2018-05-17 12:22 GMT+02:00, Hendrik Leppkes : > On Thu, May 17, 2018 at 11:49 AM, Michael Niedermayer > wrote: >> On Wed, May 16, 2018 at 12:53:46AM +0200, Carl Eugen Hoyos wrote: >>> 2018-05-16 0:29 GMT+02:00, Hendrik Leppkes :

Re: [FFmpeg-devel] [PATCH 1/2] hevcdec: Miss the location of chroma samples when exporting stream parameters

On Thu, May 17, 2018 at 8:08 AM, Xiang, Haihao wrote: > On Wed, 2018-05-16 at 11:27 +0200, Hendrik Leppkes wrote: >> On Wed, May 16, 2018 at 10:49 AM, Xiang, Haihao >> wrote: >> > On Wed, 2018-05-16 at 10:17 +0200, Hendrik Leppkes wrote: >> > > On

Re: [FFmpeg-devel] [RFC][ALT PATCHES] Code of Conduct Enforcement

On Mon, May 14, 2018 at 05:50:25PM +0100, Derek Buitenhuis wrote: [...] > 1. Implement a formal CoC enforcement system. This has been mostly > copypasted >from VideoLAN's, and is meant as more of a blueprint. This will no > doubt >be controversial. So as mentioned already in

Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg: Check AVPacket->duration for being positive not just non zero

On Thu, May 17, 2018 at 1:22 AM, Michael Niedermayer wrote: > Some demuxers (mov, microdvd at least) set duration negative. > > Signed-off-by: Michael Niedermayer > --- > fftools/ffmpeg.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-)

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/qtrle: Do not output duplicated frames on insufficient input

On Thu, May 17, 2018 at 12:22:01PM +0200, Hendrik Leppkes wrote: > On Thu, May 17, 2018 at 11:49 AM, Michael Niedermayer > wrote: > > On Wed, May 16, 2018 at 12:53:46AM +0200, Carl Eugen Hoyos wrote: > >> 2018-05-16 0:29 GMT+02:00, Hendrik Leppkes : >

Re: [FFmpeg-devel] [PATCH] mov: Make sure PTS are both monotonically increasing, and unique

On Tue, May 15, 2018 at 8:44 PM, Derek Buitenhuis wrote: > We already did this for audio, but it should be done for video too. > If we don't, seeking back to the start of the file, for example, can > become quite broken, since the first N packets will have repeating >

Re: [FFmpeg-devel] [PATCH] cmdutils - don't search for option 'default'

On 5/17/2018 2:19 PM, Michael Niedermayer wrote: On Wed, May 16, 2018 at 09:21:49PM +0530, Gyan Doshi wrote: cmdutils.c |2 -- 1 file changed, 2 deletions(-) 495ccaae10f8873dc5070858d11c0c3093ce92b4 0001-cmdutils-don-t-search-for-option-default.patch From

Re: [FFmpeg-devel] [RFC][ALT PATCHES] Code of Conduct Enforcement

On Thu, May 17, 2018 at 1:15 AM, Michael Niedermayer wrote: > I have no magic bullet sadly, which is why i didnt reply. Even lacking a solution, a public agreement that change is needed is a start, isn't it? > But if there is a consensus to enforce some CoC. Then it will

[FFmpeg-devel] [PATCH 2/2] avcodec/mlpdec: Only change noise_type if the related fields are valid

Fixes: inconsistency Fixes:runtime error: index 8 out of bounds for type 'int32_t [8]' Fixes: 6686/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_TRUEHD_fuzzer-5191383498358784 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by:

[FFmpeg-devel] [PATCH 1/2] indeo4: Decode all or nothing of a band header.

This avoids inconsistent value combinations. Alternatively it would be possible to add more checks and careful use of temporary variables, but my try of this quickly seemed to become a rather large change. The disadvantage of this, is that the struct is copied back and forth. Fixes: index 6 out

Re: [FFmpeg-devel] [RFC][ALT PATCHES] Code of Conduct Enforcement

> On May 17, 2018, at 10:22 AM, Clément Bœsch wrote: > > On Mon, May 14, 2018 at 05:50:25PM +0100, Derek Buitenhuis wrote: > [...] >>1. Implement a formal CoC enforcement system. This has been mostly >> copypasted >> from VideoLAN's, and is meant as more of a blueprint.

Re: [FFmpeg-devel] [RFC][ALT PATCHES] Code of Conduct Enforcement

On 17 May 2018 at 15:22, Clément Bœsch wrote: > On Mon, May 14, 2018 at 05:50:25PM +0100, Derek Buitenhuis wrote: > [...] > > 1. Implement a formal CoC enforcement system. This has been mostly > copypasted > >from VideoLAN's, and is meant as more of a blueprint. This

Re: [FFmpeg-devel] [PATCH] add support for parsing pssh box

On Wed, May 16, 2018 at 11:32 PM, Zewu Chen wrote: > Use structure AVEncryptionInitInfo to provide CENC initialization information > for the application. > > Signed-off-by: Chen Zewu > --- > libavformat/isom.h | 1 + > libavformat/mov.c | 64 >

[FFmpeg-devel] [PATCH] avfilter: add declick and declip audio filters

Signed-off-by: Paul B Mahol --- doc/filters.texi | 95 +++ libavfilter/Makefile | 2 + libavfilter/af_declick.c | 699 +++ libavfilter/allfilters.c | 2 + 4 files changed, 798 insertions(+) create mode 100644

Re: [FFmpeg-devel] [RFC][ALT PATCHES] Code of Conduct Enforcement

There are lots of developers that consume FFMPEG and have a vested interest in its development continuing smoothly... I count myself among them. I dont think it would be hard to impanel a group (3-4) of reasonable and dispassionate people to officiate and moderate public communication. As an

Re: [FFmpeg-devel] [PATCH] avfilter: add declick and declip audio filters

On Thu, May 17, 2018 at 19:19:06 +0200, Paul B Mahol wrote: Valuable filters. I had compiled your previous separate patches, but didn't have any samples for testing. > +Setting this to very high value increases impulsive noise removal but makes > whole ^ a very high ...

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/libzvbi-teletextdec: formatted ass output

On Mon, May 7, 2018 at 4:20 PM, Aman Gupta wrote: > > > On Mon, May 7, 2018 at 4:07 PM, Marton Balint wrote: > >> >> >> On Mon, 7 May 2018, Aman Gupta wrote: >> >> >>> >>> On Mon, May 7, 2018 at 12:50 PM, Aman Gupta wrote: >>> >>> >>> On

Re: [FFmpeg-devel] [PATCH v3] configure: error out on unsupported MSVC versions

On 16 May 2018 at 20:52, Rostislav Pehlivanov wrote: > The FATE tests for MSVC versions older than 2013 are untested in FATE > and apparently are no longer supported. > > This commit makes the configure process error out in case an older version > is used, and suggests to

Re: [FFmpeg-devel] [PATCH] doc/developer: update style guidelines to include for loops with declarations

On 8 November 2017 at 21:26, Rostislav Pehlivanov wrote: > Signed-off-by: Rostislav Pehlivanov > --- > doc/developer.texi | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/doc/developer.texi b/doc/developer.texi > index a7b4f1d737..de7d887451

Re: [FFmpeg-devel] [RFC] Proposal for improved remap filter

On 5/17/18, Paul Holland wrote: > The general feature provided by the remap filter is important in a number > of use cases. Lens distortion/correction is one that has been discussed > previously. But it is also a key feature in processing video material > intended for Virtual

[FFmpeg-devel] [PATCH v3 1/3] avformat: update AVProgram to keep track of version and changes

From: Aman Gupta Signed-off-by: Aman Gupta --- doc/APIchanges | 5 + libavformat/avformat.h | 3 ++- libavformat/utils.c| 1 + libavformat/version.h | 2 +- 4 files changed, 9 insertions(+), 2 deletions(-) diff --git a/doc/APIchanges

[FFmpeg-devel] [PATCH v3 2/3] avformat/mpegts: keep track of AVProgram.pmt_version and set AV_PROGRAM_CHANGED on version updates

From: Aman Gupta This can be used to detect changes to the streams in an AVProgram Signed-off-by: Aman Gupta --- libavformat/mpegts.c | 20 1 file changed, 16 insertions(+), 4 deletions(-) diff --git a/libavformat/mpegts.c

[FFmpeg-devel] [PATCH v3 3/3] avformat/mpegts: add merge_pmt_versions option

From: Aman Gupta This new optional flag makes it easier to deal with mpegts samples where the PMT is updated and elementary streams move to different PIDs in the middle of playback. Previously, new AVStreams were created per PID, and it was up to the user to figure out which

[FFmpeg-devel] [FFmpeg-devl][RFC] Proposal for improved remap filter

The general feature provided by the remap filter is important in a number of use cases. Lens distortion/correction is one that has been discussed previously. But it is also a key feature in processing video material intended for Virtual Reality and 360 degree playback. These workflows employ

[FFmpeg-devel] [RFC] Proposal for improved remap filter

The general feature provided by the remap filter is important in a number of use cases. Lens distortion/correction is one that has been discussed previously. But it is also a key feature in processing video material intended for Virtual Reality and 360 degree playback. These workflows employ

Re: [FFmpeg-devel] [RFC] Proposal for improved remap filter

I am sure there are multiple ways to achieve this. My current idea is to teach/enhance swscale to perform the basic logic for it. In that sort of design it would be able to reuse most of the existing, highly optimized filtering functions - as well as all of its to, and from, planar format

[FFmpeg-devel] [PATCH v2] avcodec/videotoolbox: fix decoding of some hevc videos

From: Aman Gupta See https://s3.amazonaws.com/tmm1/videotoolbox/germany-hevc-zdf.ts This moves the hw_frames_ctx reference from the AVFrame to a new VTHWFrame which now holds both the CVPixelBufferRef and the AVBuffer. Previously we would set the hw_frames_context on the AVFrame

Re: [FFmpeg-devel] [PATCH 1/2] hevcdec: Miss the location of chroma samples when exporting stream parameters

On Wed, 2018-05-16 at 11:27 +0200, Hendrik Leppkes wrote: > On Wed, May 16, 2018 at 10:49 AM, Xiang, Haihao > wrote: > > On Wed, 2018-05-16 at 10:17 +0200, Hendrik Leppkes wrote: > > > On Wed, May 16, 2018 at 9:19 AM, Haihao Xiang > > > wrote: > >

[FFmpeg-devel] [PATCH] add support for parsing pssh box

Use structure AVEncryptionInitInfo to provide CENC initialization information for the application. Signed-off-by: Chen Zewu --- libavformat/isom.h | 1 + libavformat/mov.c | 64 ++ 2 files changed, 65 insertions(+) diff

Re: [FFmpeg-devel] [PATCH] avformat/mpegts: add skip_unknown_pmt option

On Thu, May 17, 2018 at 5:04 PM, Aman Gupta wrote: > From: Aman Gupta > > Some filtered mpegts streams may erroneously include PMTs for programs > that are not advertised in the PAT. This confuses ffmpeg and most > players because multiple audio/video streams are

[FFmpeg-devel] [PATCH] avcodec/ac3dec: Use frame_size if superframe_size is 0

Fixes: Infinite loop Fixes: 7669/clusterfuzz-testcase-ffmpeg_AV_CODEC_ID_AC3_FIXED_fuzzer-4689042185650176 Fixes: 7670/clusterfuzz-testcase-ffmpeg_AV_CODEC_ID_AC3_fuzzer-4706306762997760 Fixes: 7672/clusterfuzz-testcase-ffmpeg_AV_CODEC_ID_EAC3_fuzzer-4702108499574784 Found-by: continuous fuzzing

[FFmpeg-devel] [PATCH] avformat/mpegts: add skip_unknown_pmt option

From: Aman Gupta Some filtered mpegts streams may erroneously include PMTs for programs that are not advertised in the PAT. This confuses ffmpeg and most players because multiple audio/video streams are created and it is unclear which ones actually contain data. See for example

[FFmpeg-devel] [PATCH v3] avformat: keep track of PMT details in AVStream

From: Aman Gupta With these fields, the user has enough information to make the same decisions externally that the demuxer does internally when merge_pmt_versions=1. An API user would monitor the AVProgram they're interested in to see if (flags_PROGRAM_CHANGED), and would then

Re: [FFmpeg-devel] [PATCH] avfilter: add declick and declip audio filters

On 5/17/2018 2:19 PM, Paul B Mahol wrote: > +static int config_input(AVFilterLink *inlink) > +{ > +AVFilterContext *ctx = inlink->dst; > +DeclickContext *s = ctx->priv; > +int i; > + > +s->pts = AV_NOPTS_VALUE; > +s->window_size = inlink->sample_rate * s->w / 1000.; > +if

Re: [FFmpeg-devel] [PATCH v3 2/3] avformat/mpegts: keep track of AVProgram.pmt_version and set AV_PROGRAM_CHANGED on version updates

On Thu, May 17, 2018 at 3:49 PM, Aman Gupta wrote: > From: Aman Gupta > > This can be used to detect changes to the streams in an AVProgram > Forgot to add: I have seen two related patches in the wild that attempt to solve this same problem in different ways.