Hi Oleg
Wait a minute! I'm just about to commit a huge bunch of changes which
includes TextInfo/FontState stuff. Not that I changed a lot. I've just
got rid of stuff that wasn't used and I don't want you to have to change
a lot again after my commit.
On your question, I can't answer right away,
Peter B. West wrote:
Jeremias Maerki wrote:
Since I've made the checkstyle.cfg file an integral part of our style
guide I have to bring this up before changing:
I'd like to add a line checkstyle.ignore.braces = yes. This enables
one line ifs like the following:
[..]
if (isEnabled)
Jeremias Maerki wrote:
Wait a minute! I'm just about to commit a huge bunch of changes which
includes TextInfo/FontState stuff. Not that I changed a lot. I've just
got rid of stuff that wasn't used and I don't want you to have to change
a lot again after my commit.
That's fine.
--
Oleg
Christian Geisert wrote:
Peter B. West wrote:
Jeremias Maerki wrote:
Since I've made the checkstyle.cfg file an integral part of our style
guide I have to bring this up before changing:
I'd like to add a line checkstyle.ignore.braces = yes. This enables
one line ifs like the following:
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=15887.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND
INSERTED IN THE BUG DATABASE.
I've got the same problem with that. I've found more than a few
occurences of that last example in FOP. It would be nice to restrict
that rule to one line ifs/fors/whiles. Having more than one line in
total should mean having to use braces. Unfortunately, checkstyle
doesn't support that. Maybe
Hello!
How are we going to process underline/overline etc stuff?
It's a little bit confusing - we've got unused TextState class along with
TextInfo that includes text-decoration info already. Lets get rid of TextState ?
And what about rendering, does pdf support text-decoration directly or
Jeremias Maerki wrote:
Or if checkstyle could also check indentation...
*That* would be extremely useful, and would solve the problem. Maybe a
Python preprocessor Joke, folk.
Peter
--
Peter B. West [EMAIL PROTECTED] http://www.powerup.com.au/~pbwest/
Lord, to whom shall we go?
jeremias2003/01/08 05:51:11
Modified:src/org/apache/fop/area/inline UnresolvedPageNumber.java
Log:
Removed dead code
Revision ChangesPath
1.6 +3 -8 xml-fop/src/org/apache/fop/area/inline/UnresolvedPageNumber.java
Index: UnresolvedPageNumber.java
jeremias2003/01/08 05:52:12
xml-fop/src/org/apache/fop/fonts/truetype - New directory
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
jeremias2003/01/08 05:55:01
Modified:src/org/apache/fop/image ImageFactory.java
Log:
Lots of Javadocs
Fixed Checkstyle errors
Revision ChangesPath
1.13 +110 -104 xml-fop/src/org/apache/fop/image/ImageFactory.java
Index: ImageFactory.java
jeremias2003/01/08 05:56:37
Modified:src/org/apache/fop/layout FontInfo.java FontState.java
Removed: src/org/apache/fop/layout FontDescriptor.java
FontMetric.java
Log:
Adjustments for the font refactoring
Removal/commenting out of some dead code
jeremias2003/01/08 05:57:24
Modified:src/org/apache/fop/pdf PDFCIDFont.java PDFDocument.java
PDFFont.java PDFFontDescriptor.java
PDFFontNonBase14.java PDFFontTrueType.java
PDFFontType0.java PDFFontType1.java
jeremias2003/01/08 05:58:25
Modified:src/org/apache/fop/render/awt AWTFontMetrics.java
FontMetricsMapper.java FontSetup.java
Log:
Adjustments for the font refactoring
Lots of Javadocs
Fixed Checkstyle errors
Revision ChangesPath
1.5 +27
jeremias2003/01/08 06:02:48
Modified:src/org/apache/fop/render/pdf EmbedFontInfo.java
FontReader.java FontSetup.java PDFRenderer.java
Removed: src/org/apache/fop/render/pdf CIDFont.java CMap.java
Font.java
jeremias2003/01/08 06:03:35
Modified:src/org/apache/fop/render/ps PSGraphics2D.java
PSRenderer.java
Log:
Adjustments for font refactoring
Lots of Javadocs
Fixed Checkstyle errors
Revision ChangesPath
1.7 +125 -52
jeremias2003/01/08 06:03:55
Modified:src/org/apache/fop/svg PDFTextPainter.java
PDFGraphics2D.java
Log:
Adjustments for font refactoring
Lots of Javadocs
Fixed Checkstyle errors
Revision ChangesPath
1.15 +17 -15
jeremias2003/01/08 06:04:29
Modified:src/org/apache/fop/tools AreaTreeBuilder.java
Log:
Adjustments for font refactoring
Lots of Javadocs
Fixed Checkstyle errors
Revision ChangesPath
1.15 +101 -55 xml-fop/src/org/apache/fop/tools/AreaTreeBuilder.java
jeremias2003/01/08 06:08:03
Modified:.build.xml
Log:
Base 14 fonts are now generated to org.apache.fop.fonts.base14
CodePointMapping is now generated to org.apache.fop.fonts
Revision ChangesPath
1.70 +27 -38xml-fop/build.xml
Index: build.xml
jeremias2003/01/08 06:08:46
Modified:.checkstyle.header
Log:
Update checkstyle.header for 2003
Revision ChangesPath
1.2 +1 -1 xml-fop/checkstyle.header
Index: checkstyle.header
===
jeremias2003/01/08 06:10:38
Modified:src/org/apache/fop/fo FOUserAgent.java PropertyManager.java
Log:
Adjustments for font refactoring
Lots of Javadocs
Fixed Checkstyle errors
Revision ChangesPath
1.12 +74 -26xml-fop/src/org/apache/fop/fo/FOUserAgent.java
jeremias2003/01/08 06:11:29
Modified:src/codegen font-file.xsl code-point-mapping.xsl
Log:
Adjustments for font refactoring
Revision ChangesPath
1.12 +29 -15xml-fop/src/codegen/font-file.xsl
Index: font-file.xsl
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=15855.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND
INSERTED IN THE BUG DATABASE.
Hi there
I've finally finished a multiday block of refactoring. Well, the
refactoring alone didn't take so long. Javadocs and checkstyle took me
two days. But we're down to a little bit under 4500 errors. :-)
What did I do?
- Moved the TrueType parsing classes to a subpackage
jeremias2003/01/08 06:43:34
Modified:src/org/apache/fop/fo FOUserAgent.java
Log:
Revert a change that caused problems with images.
Revision ChangesPath
1.13 +2 -2 xml-fop/src/org/apache/fop/fo/FOUserAgent.java
Index: FOUserAgent.java
jeremias2003/01/08 06:44:54
Modified:.status.xml
Log:
Add changes
Revision ChangesPath
1.21 +11 -0 xml-fop/status.xml
Index: status.xml
===
RCS file: /home/cvs/xml-fop/status.xml,v
jeremias2003/01/08 06:45:12
Modified:.build.xml
Log:
Update for 2003
Revision ChangesPath
1.71 +1 -1 xml-fop/build.xml
Index: build.xml
===
RCS file: /home/cvs/xml-fop/build.xml,v
jeremias2003/01/08 07:01:43
Modified:src/org/apache/fop/fonts LazyFont.java
Added: src/org/apache/fop/fonts/truetype package.html
Log:
Javadoc fix
package html for new truetype subpackage
Revision ChangesPath
1.2 +2 -2
jeremias2003/01/08 07:02:54
Modified:src/org/apache/fop/render/awt FontMetricsMapper.java
Log:
Javadoc fix (references were wrong)
Revision ChangesPath
1.7 +11 -11xml-fop/src/org/apache/fop/render/awt/FontMetricsMapper.java
Index: FontMetricsMapper.java
jeremias2003/01/08 07:03:09
xml-fop/src/org/apache/fop/fonts/base14 - New directory
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
jeremias2003/01/08 07:03:53
Added: src/org/apache/fop/fonts/base14 package.html
Log:
Package html for base14 subpackage
Revision ChangesPath
1.1 xml-fop/src/org/apache/fop/fonts/base14/package.html
Index: package.html
Peter B. West wrote:
if (isEnabled()) {
return true;
}
is absurd.
Not necessarily. I it *much* easier to add a
System.out.println() to this than to either
if (isEnabled())return true;
or
if (isEnabled())
return true;
If you are debugging code written by someone else,
this
Jeremias Maerki wrote:
I've got the same problem with that. I've found more than a few
occurences of that last example in FOP. It would be nice to restrict
that rule to one line ifs/fors/whiles. Having more than one line in
total should mean having to use braces.
I don't understand this: It has
Hi Oleg
On 08.01.2003 13:11:34 Oleg Tkachenko wrote:
How are we going to process underline/overline etc stuff?
It's a little bit confusing - we've got unused TextState class along with
TextInfo that includes text-decoration info already. Lets get rid of TextState ?
And what about rendering,
Good point.
On 08.01.2003 16:28:21 J.Pietschmann wrote:
Peter B. West wrote:
if (isEnabled()) {
return true;
}
is absurd.
Not necessarily. I it *much* easier to add a
System.out.println() to this than to either
if (isEnabled())return true;
or
if (isEnabled())
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=15887.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND
INSERTED IN THE BUG DATABASE.
J.Pietschmann wrote:
Peter B. West wrote:
if (isEnabled()) {
return true;
}
is absurd.
Not necessarily. I it *much* easier to add a
System.out.println() to this than to either
if (isEnabled())return true;
or
if (isEnabled())
return true;
Agreed.
If you are debugging
J.Pietschmann wrote:
On 08.01.2003 14:23:36 Peter B. West wrote:
And it adds just a spice of danger.
I can live well without this.
Spoilsport.
Peter
--
Peter B. West [EMAIL PROTECTED] http://www.powerup.com.au/~pbwest/
Lord, to whom shall we go?
Jeremias Maerki wrote:
If only everybody would run the formatter...We're facing reality here.
I do.
We could add a Jalopy task to build.xml.
We could refuse checkins which hadn't run checkstyle and
source formatting. :)
J.Pietschmann
Jeremias Maerki wrote:
The following should (sorry, could) be ok:
for (int i = 0; i 5; i++) {
doSomething();
if (amIRight()) cool();
doSomethingElse();
}
One point here:
If it's not amIRight() but
if (amIRight() || ( more stuff follows .) cool();
Arnd Beißner wrote:
Jeremias Maerki wrote:
The following should (sorry, could) be ok:
for (int i = 0; i 5; i++) {
doSomething();
if (amIRight()) cool();
doSomethingElse();
}
One point here:
If it's not amIRight() but
if (amIRight() || ( more stuff follows
Peter B. West wrote:
This man must be one of them there anarchists.
8-)
No, I once had to moderate a team of 15 programmers
trying to agree on formatting. I learned you have
to work with the Carrot-and-stick methodology.
Meaning, in this context, force the few guidelines
that really hurt if
A question for 0.20.5:
The PS renderer currently emits lots of redundant moveto instructions.
By changing the current position logic in the renderer, I reduced file
size to 50% (for my test files, contating few small images and lots of
text
in tables).
I don't have a diff at hand, because I
Jeremias Maerki wrote:
TextInfo looks better but could IMO be merged with FontState which only
hold the font name and size and a link to the FontMetrics. Anyway, I
think this merged class will be a candidate for the Flyweight pattern so
we don't generate so many TextInfo/FontState objects
chrisg 2003/01/08 17:10:48
Modified:docs/examples/fo Tag: fop-0_20_2-maintain images.fo list.fo
docs/examples/svg Tag: fop-0_20_2-maintain external.fo
Log:
corrected relative urls for external-graphic in examples
Revision ChangesPath
No
chrisg 2003/01/08 17:25:41
Modified:src/org/apache/fop/render/pdf Tag: fop-0_20_2-maintain
PDFRenderer.java
Log:
(possible) fix for linux alpha jre (bug #13586)
Revision ChangesPath
No revision
No
To all,
I tried to determine the reason from the archives with clarity... but why
isn't PDF encryption in the core?
Pat Lankswert
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, email: [EMAIL PROTECTED]
Hi Patrick
Because still noone has started working on it? :-) It's one of the most
requested features. On the other side, iText seems to work for those who
want to add encryption.
Would you like to help? We can use all the help we can get.
On 09.01.2003 07:34:09 Patrick C. Lankswert wrote:
I
Hi Arnd
I think so. Just file a patch to BugZilla as soon as possible.
Just keep in mind that the FOP maintenance branch is (from our POV) in
bugfixing-only mode. Additions from developers will probably get
included but it'll be a dead end. We're looking for manpower to get the
redesign to a
49 matches
Mail list logo
