Follow-up Comment #10, bug #15377 (project freeciv):
Actually I came to the exact same conclusion Ulrik: we should simply rewrite
the character functions to work only on ascii (range 0 to 127) characters,
and leave others alone. Using the system-provided functions (such as
tolower) which work
Follow-up Comment #11, bug #15377 (project freeciv):
And, unfortunately limiting the functions to ascii-only is not going to work
very well either for the is_ functions. is_alnum is most likely used for
instance to check for valid ruler/city names and will fail on any non-ascii
names now. Even
Follow-up Comment #12, bug #15377 (project freeciv):
Turning these functions into ASCII only is the only sane thing, but it might
only be the first step.
I don't think we check ruler names or anything against character classes,
that would already today fail often!
Likewise, we don't add new
!
An update of the network capabilities is needed (removal of type CITY_AMP
definition)
(file #8663)
___
Additional Item Attachment:
File name:
20100327-trunk--savegame-format-remove-pcity-city_map-and-save-wor.diff
Size:59 KB
Update of patch #1480 (project freeciv):
Status:None = Duplicate
Open/Closed:Open = Closed
___
Follow-up Comment #1:
included in patch
Follow-up Comment #13, bug #15377 (project freeciv):
We could look eagerly at GLib's support for Unicode/UTF-8, they have every
function we would ever need:
http://library.gnome.org/devel/glib/unstable/glib-Unicode-Manipulation.html
That should already be available to the GTK+ client of
)
___
Additional Item Attachment:
File name: 20100327-experimental.diff Size:236 KB
___
Reply to this item at:
http://gna.org/patch/?1236
___
Nachricht geschickt von/durch
URL:
http://gna.org/patch/?1565
Summary: do not scale units with the tileset
Project: Freeciv
Submitted by: syntron
Submitted on: Samstag 27.03.2010 um 12:07
Category: client-gtk-2.0
Priority: 3 - Low
Update of patch #1234 (project freeciv):
Status:None = Done
Open/Closed:Open = Closed
___
Reply to this item at:
Follow-up Comment #1, patch #1552 (project freeciv):
Is it ok to check this in to 2.2 as a bug fix?
___
Reply to this item at:
http://gna.org/patch/?1552
___
Meddelandet skickades via/av
Update of patch #1553 (project freeciv):
Status:None = Done
Open/Closed:Open = Closed
___
Reply to this item at:
URL:
http://gna.org/bugs/?15705
Summary: API: find.player() returns uninitalized players
Project: Freeciv
Submitted by: englabenny
Submitted on: lördag 2010-03-27 den 12:07
Category: general
Severity: 3 -
URL:
http://gna.org/bugs/?15706
Summary: Scripting: Safer stack value handling
Project: Freeciv
Submitted by: englabenny
Submitted on: lördag 2010-03-27 den 12:10
Category: general
Severity: 2 - Minor
URL:
http://gna.org/bugs/?15707
Summary: Scripting: Handle missing debug.traceback
gracefully
Project: Freeciv
Submitted by: englabenny
Submitted on: lördag 2010-03-27 den 12:13
Category: general
Update of bug #15707 (project freeciv):
Status:None = Ready For Test
___
Reply to this item at:
http://gna.org/bugs/?15707
___
Meddelandet
Update of bug #15705 (project freeciv):
Status:None = Ready For Test
___
Reply to this item at:
http://gna.org/bugs/?15705
___
Meddelandet
Follow-up Comment #7, bug #15644 (project freeciv):
Thanks for the comments. Here is an updated patch.
___
Reply to this item at:
http://gna.org/bugs/?15644
___
Meddelandet skickades
Additional Item Attachment, bug #15644 (project freeciv):
File name: 0001-Add-lua-server-command-to-evaluate-a-line-of-freeciv.patch
Size:4 KB
___
Reply to this item at:
http://gna.org/bugs/?15644
URL:
http://gna.org/bugs/?15708
Summary: API: Fix typo in deprecated method
Project: Freeciv
Submitted by: englabenny
Submitted on: lördag 2010-03-27 den 12:27
Category: general
Severity: 3 - Normal
Update of patch #1561 (project freeciv):
Status:None = Ready For Test
Planned Release: = 2.3
___
Reply to this item at:
for the positive and negative years
___
File Attachments:
---
Date: Samstag 27.03.2010 um 13:30 Name:
20100327-trunk-fix-savegame-naming.diff Size: 2kB By: syntron
http://gna.org/bugs
Update of patch #1562 (project freeciv):
Planned Release: = 2.3.0
Summary: Scripting: Define the equality comparison for API
Types = API: Define convenience functionality for Types
Follow-up Comment #9, patch #1230 (project freeciv):
An update of the network capabilities is needed (removal of type
CITY_AMP definition)
As you didn't change anything linked with network, only removing a unused
type definition, this is really not needed.
Follow-up Comment #2, patch #1552 (project freeciv):
Is it ok to check this in to 2.2 as a bug fix?
Yes, this is a bug.
___
Reply to this item at:
http://gna.org/patch/?1552
___
Message
Update of patch #1487 (project freeciv):
Status: Ready For Test = Done
Open/Closed:Open = Closed
___
Reply to this item at:
URL:
http://gna.org/bugs/?15710
Summary: Lack of generality for specialists in city report /
citizen governor display
Project: Freeciv
Submitted by: jtn
Submitted on: Saturday 03/27/10 at 13:37
Category: client
Update of bug #15695 (project freeciv):
Category:None = general
Status:None = Ready For Test
Assigned to:None = pepeto
Planned Release:
Update of bug #15603 (project freeciv):
Status: Ready For Test = In Progress
___
Reply to this item at:
http://gna.org/bugs/?15603
___
Message sent
Update of bug #15694 (project freeciv):
Category:None = general
Assigned to:None = pepeto
___
Reply to this item at:
Update of bug #15694 (project freeciv):
Planned Release: = 2.3.0
___
Reply to this item at:
http://gna.org/bugs/?15694
___
Message posté
Follow-up Comment #3, bug #15684 (project freeciv):
2. load it (do not start the game!)
Could you attach the diff just after starting it?
___
Reply to this item at:
http://gna.org/bugs/?15684
Update of bug #15603 (project freeciv):
Status: In Progress = Fixed
Open/Closed:Open = Closed
___
Reply to this item at:
Update of bug #15643 (project freeciv):
Category:None = general
Status:None = Ready For Test
Assigned to:None = pepeto
Planned Release:
Follow-up Comment #14, bug #15377 (project freeciv):
It is not a real big deal. It just mean having 2 sets of functions for ASCII
and UTF-8 (maybe with different prefixes). Without big changes, it can be
improved a lot.
e.g., fc_snprintf() just need to cut the string after the last complete
Follow-up Comment #4, bug #15684 (project freeciv):
Could you attach the diff just after starting it?
I think you mean the original savegame files. Both are attached.
I do not have a savefile from the gamestart (turn 0) as this was a autogame
running with 'saveturn 50'. But you can try your
Follow-up Comment #3, bug #15695 (project freeciv):
Thanks, fix works when tested.
It looks like insert_escapes will be much slower than the old version,
looking at the unescaped character case:
fz_fprintf(fp, %c, *str);
instead of a *dest++ = *str++;
This particular case with script.code
Follow-up Comment #5, bug #15684 (project freeciv):
I meant a diff between 2 the auto save and a manual save after the game
started again).
___
Reply to this item at:
http://gna.org/bugs/?15684
Additional Item Attachment, bug #15695 (project freeciv):
File name: trunk_registry_escapes2.diff Size:5 KB
___
Reply to this item at:
http://gna.org/bugs/?15695
___
Message posté
Update of bug #15402 (project freeciv):
Status:None = Duplicate
Assigned to:None = pepeto
Open/Closed:Open = Closed
Depends on:
Update of bug #14204 (project freeciv):
Priority: 5 - Normal = 1 - Later
___
Follow-up Comment #1:
See also #15402.
___
Reply to this
Follow-up Comment #3, patch #1349 (project freeciv):
See also bug #14054.
___
Reply to this item at:
http://gna.org/patch/?1349
___
Message posté via/par Gna!
http://gna.org/
Follow-up Comment #1, bug #14054 (project freeciv):
See also patch #1349.
___
Reply to this item at:
http://gna.org/bugs/?14054
___
Message posté via/par Gna!
http://gna.org/
Follow-up Comment #4, bug #15695 (project freeciv):
Version 3.
(file #8682)
___
Additional Item Attachment:
File name: trunk_registry_escapes3.diff Size:5 KB
___
Reply to this
Update of bug #13701 (project freeciv):
Status:None = Need Info
___
Reply to this item at:
http://gna.org/bugs/?13701
___
Message posté
Update of bug #14082 (project freeciv):
Status:None = Need Info
___
Follow-up Comment #1:
Do you still get this problem? Do you have a savegame?
Additional Item Attachment, bug #15695 (project freeciv):
File name: trunk_registry_escapes4.diff Size:5 KB
___
Reply to this item at:
http://gna.org/bugs/?15695
___
Message posté
Update of bug #14168 (project freeciv):
Status:None = Need Info
___
Reply to this item at:
http://gna.org/bugs/?14168
___
Message posté
Update of bug #14549 (project freeciv):
Category:None = client-gtk-2.0
Status:None = Need Info
___
Reply to this item at:
Follow-up Comment #15, bug #15377 (project freeciv):
See also bug #14205.
___
Reply to this item at:
http://gna.org/bugs/?15377
___
Message posté via/par Gna!
http://gna.org/
Update of bug #14212 (project freeciv):
Status:None = Need Info
___
Reply to this item at:
http://gna.org/bugs/?14212
___
Message posté
Update of bug #14702 (project freeciv):
Category: client-gtk-2.0 = client
___
Follow-up Comment #1:
See also bug #14582.
___
Reply to
Update of bug #14650 (project freeciv):
Status:None = Need Info
___
Follow-up Comment #1:
Do you still get this problem? What is your version of GTK?
Follow-up Comment #6, bug #15684 (project freeciv):
I started a new game for this due to changes in the savegame format (variable
city radii):
1. ./ser -r test.ser
will save 'civgame-T0050-Y-1500BC-auto.sav.bz2'
2. ./ser -f civgame-T0050-Y-1500BC-auto.sav.bz2
save this file
Follow-up Comment #7, bug #15684 (project freeciv):
and the diff between the manual save and the save after the game was started
again (restart). No changes besides the event cache and the timeout setting
are found. So this seems to depend on the timing of the call to the autosave
function?
Follow-up Comment #5, bug #15695 (project freeciv):
Improved comments. Thanks to englabenny for his comments.
(file #8690)
___
Additional Item Attachment:
File name: trunk_registry_escapes5.diff Size:5 KB
Update of bug #14923 (project freeciv):
Status:None = Need Info
___
Reply to this item at:
http://gna.org/bugs/?14923
___
Message posté
Update of bug #15021 (project freeciv):
Status:None = Need Info
___
Reply to this item at:
http://gna.org/bugs/?15021
___
Message posté
Update of bug #14205 (project freeciv):
Category: general = client
___
Follow-up Comment #1:
The problem seems to be truncation of an UTF-8 string, splitting it inside a
multibyte
URL:
http://gna.org/bugs/?15714
Summary: Cient-side connect-with-rail doesn't take into
account railroad length
Project: Freeciv
Submitted by: jtn
Submitted on: Saturday 03/27/10 at 17:41
Category: client
Update of bug #15714 (project freeciv):
Summary: Cient-side connect-with-rail doesn't take into
account railroad length = Client-side connect-with-rail doesn't take into
account railroad length
___
Reply to this item at:
Follow-up Comment #16, bug #15377 (project freeciv):
Having 2 sets of functions is trickier than it sounds. For one, you have to
be extremely careful which you use where. For a second, neither one should
really be using the libc character functions. And for a third, the functions
we're
Follow-up Comment #2, bug #14205 (project freeciv):
How can I reproduce this?
___
Reply to this item at:
http://gna.org/bugs/?14205
___
Message sent via/by Gna!
http://gna.org/
Follow-up Comment #3, bug #14205 (project freeciv):
Pepeto pointed this out in the code for me. You need a long Ai name in UTF-8
(like Easy, Hard, Cheating). Here's a diff where we replace that by a string
of just €-signs, and it breaks the same way.
IMO the truncation is the bug, that it with
Follow-up Comment #4, bug #14205 (project freeciv):
Ah, well that's simple. It's a simple bug in update_conn_dialog that doesn't
check the width of the AI name, probably a remnant from before when they were
given artificial player names. Attached patch will fix this. It is likely
to occur in
URL:
http://gna.org/bugs/?15721
Summary: S2_1 connect (road, irrigation etc) broken: jumbo
callbacks for danger maps are not yet implemented.
Project: Freeciv
Submitted by: jtn
Submitted on: Sunday 03/28/10 at 02:42
URL:
http://gna.org/bugs/?15722
Summary: Client-side goto turn estimation inaccurate with
waypoints
Project: Freeciv
Submitted by: jtn
Submitted on: Sunday 03/28/10 at 02:51
Category: client
Severity: 3 -
URL:
http://gna.org/bugs/?15723
Summary: Server help options response mangled
Project: Freeciv
Submitted by: jtn
Submitted on: Sunday 03/28/10 at 03:01
Category: None
Severity: 3 - Normal
Follow-up Comment #1, bug #15721 (project freeciv):
I wonder if it's trying to use a danger map because of
base_unsafe_terrain_loss_pct() (in pft_fill_unit_parameter()). That would
explain why it doesn't apply to S2_2. Not proven though.
68 matches
Mail list logo
