[Freeciv-Dev] [bug #14650] blank rectangle on screen
Follow-up Comment #2, bug #14650 (project freeciv): I haven't seen this problem in the current release. ___ Reply to this item at: http://gna.org/bugs/?14650 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #14549] Crash - unknown cause
Follow-up Comment #11, bug #14549 (project freeciv): I haven't seen this in the current version yet. ___ Reply to this item at: http://gna.org/bugs/?14549 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #14205] Bug with utf-8
Follow-up Comment #5, bug #14205 (project freeciv): The patch uses tabs and spaces inconsistently. Also, the translated string in this area is just the AI part of the string, that is filled in with the difficulty of the AI, which is translated somewhere else. Which of these parts is the culprit (being long) I don't know, but I suspect the part that we don't have here. ___ Reply to this item at: http://gna.org/bugs/?14205 ___ Meddelandet skickades via/av Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15377] freeciv-gtk2.exe hangs
Follow-up Comment #17, bug #15377 (project freeciv): I have no opinion about what is the best to do... ___ Reply to this item at: http://gna.org/bugs/?15377 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1554] API: Fix government lookup by id
Update of patch #1554 (project freeciv): Status: Ready For Test = Done Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/patch/?1554 ___ Meddelandet skickades via/av Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1552] Load script state last in loading savegame
Update of patch #1552 (project freeciv): Status: Ready For Test = Done Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/patch/?1552 ___ Meddelandet skickades via/av Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15721] S2_1 connect (road, irrigation etc) broken: jumbo callbacks for danger maps are not yet implemented.
Follow-up Comment #2, bug #15721 (project freeciv): I checked the old behaviour: it was ignoring dangers. Is it better? Else, I could implement the missing functions, but it will take time. ___ Reply to this item at: http://gna.org/bugs/?15721 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15725] [Metaticket] Lua script security
URL: http://gna.org/bugs/?15725 Summary: [Metaticket] Lua script security Project: Freeciv Submitted by: englabenny Submitted on: söndag 2010-03-28 den 10:55 Category: general Severity: 3 - Normal Priority: 5 - Normal Status: Need Info Assigned to: None Originator Email: Open/Closed: Open Release: 2.1, 2.2 Discussion Lock: Any Operating System: None Planned Release: ___ Details: I think it is best to be conservative: Security is hard, and we have no reason to believe the script runtime is secure against exploits. ___ Reply to this item at: http://gna.org/bugs/?15725 ___ Meddelandet skickades via/av Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15725] [Metaticket] Lua script security
Update of bug #15725 (project freeciv): Depends on: = bugs #15624 ___ Reply to this item at: http://gna.org/bugs/?15725 ___ Meddelandet skickades via/av Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15377] freeciv-gtk2.exe hangs
Follow-up Comment #18, bug #15377 (project freeciv): The best thing right now would be to check in jason's latest patch, at least for fc_isspace. I bet we can find many more bugs of this type (though not crashing bugs) everywhere where isspace is used right now, and nowhere were the current behavior makes sense. ___ Reply to this item at: http://gna.org/bugs/?15377 ___ Meddelandet skickades via/av Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15377] freeciv-gtk2.exe hangs
Follow-up Comment #19, bug #15377 (project freeciv): I guess a is_utf8_string() and ut8_string_rm_truncated() (which doesn't require any extra lib) should be good to unsure to don't send incomplete strings thought the network, and maybe loading from files. This would also fix the crash described at bug #15658. And also the empty line bug as fixed in warclient at: http://svn.gna.org/viewcvs/freeciv-warclient?rev=1401view=rev ___ Reply to this item at: http://gna.org/bugs/?15377 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15728] Inaccuracy in pathfinding from TM_WORST_TIME (e.g., in client-side connect)
URL: http://gna.org/bugs/?15728 Summary: Inaccuracy in pathfinding from TM_WORST_TIME (e.g., in client-side connect) Project: Freeciv Submitted by: jtn Submitted on: Sunday 03/28/10 at 15:35 Category: None Severity: 3 - Normal Priority: 5 - Normal Status: Need Info Assigned to: None Originator Email: Open/Closed: Open Release: Discussion Lock: Any Operating System: None Planned Release: ___ Details: Even after the fix for bug #15722, the turns report for client-side connect is inaccurate (pessimistic). This inaccuracy stems from emulation of TM_WORST_TIME pathfinding in get_connect_road()/get_connect_irrig(). In TM_WORST_TIME mode, the pathfinding code assumes that any attempted move with fewer movement points than are required will fail (as opposed to TM_BEST_TIME, which assumes success). The comments refer to random rulings. It looks like most random rulings in movement were removed before 2.1 (r10104, 2005-03-24, RT #4387 http://bugs.freeciv.org/Ticket/Display.html?id=4387); since then the actual behaviour has been TM_BEST_TIME. I think the only remaining potentially random element in movement is occupychance, which is a server option (and not random by default). Looking at the standard pathfinding code, I only see the TM_BEST/WORST_TIME distinction having an actual effect on normal_map (pf_normal_map_adjust_cost()) and danger_map (pf_fuel_map_fill_position()); I can't see any effect on fuel_map (maybe I've missed something). Looking at users of pathfinding, I see various attempts to use TM_WORST_TIME: * AI: aiferry.c, ai_avoid_risks(), ai_fill_unit_param() (with comments about triremes) * pft_fill_parameter() for fuel units * pft_fill_amphibious_parameter()) Many of these seem to be concerned about triremes from comments. Presumably the problem was that if a trireme tried to move from deep sea to coast with partial MP, it might fail and then risk sinking. That's doubly irrelevant now, since (a) partial MP always works, (b) triremes cannot occupy unsafe ocean even temporarily from 2.2. Client-side goto always overrides with TM_BEST_TIME, but this is ignored for connect, which is hardcoded. * There's a comment _FIXME: for units traveling across dangerous terrains with partial MP (which is very rare) using TM_BEST_TIME could cause them to die._. I think this is doubly out-of-date; (a) movement follows TM_BEST_TIME (modulo occupychance), (b) unsafe terrain is gone. (If unsafe terrain returns then I suppose this could kill a unit attacking a city from a glacier, but you were already taking a risk there.) Most users get TM_CAPPED by default, I think (pft_fill_default_parameter()). (I haven't worked out exactly how that behaves in practice.) So, as well as the proven issues with connect, I think this might be leading the AI to be excessively cautious (but haven't tested this hypothesis). What can we do about it? Some guesses: * Minimal: leave TM_WORST_TIME code in place, but switch connect and other users over to TM_BEST_TIME. ** Might lead to over-optimism about ability to occupy cities after combat? That could be bad... * As above but bodily remove TM_WORST_TIME code. * Keep TM_WORST_TIME/TM_BEST_TIME but remove the notion that normal moves with partial MP can fail. Instead, teach it about occupychance, including adaptation to the common deterministic cases. Anyone got any other ideas or suggestions? ___ Reply to this item at: http://gna.org/bugs/?15728 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15728] Inaccuracy in pathfinding from TM_WORST_TIME (e.g., in client-side connect)
Follow-up Comment #1, bug #15728 (project freeciv): I am for the full removal of the turn_mode concept that shouldn't slow down the path finding. As you said, only TM_BEST_TIME is right because the randomness of the movements has been removed. PS: There was also a bug report in RT I couldn't find about the connecting code not using the shortest path when connecting road over a river e.g. ___ Reply to this item at: http://gna.org/bugs/?15728 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15728] Inaccuracy in pathfinding from TM_WORST_TIME (e.g., in client-side connect)
Follow-up Comment #2, bug #15728 (project freeciv): Here's a simple patch against S2_2 that restores accuracy to the connect turn reports without addressing any of the other issues. I may apply this soon (under another bug) regardless of the outcome of other discussions, since it makes things better in the meantime. (file #8706) ___ Additional Item Attachment: File name: S2_2-connect-TM_BEST_TIME.diff Size:1 KB ___ Reply to this item at: http://gna.org/bugs/?15728 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15729] [Metaticket] Make Scenario editing work well
URL: http://gna.org/bugs/?15729 Summary: [Metaticket] Make Scenario editing work well Project: Freeciv Submitted by: englabenny Submitted on: söndag 2010-03-28 den 15:13 Category: general Severity: 3 - Normal Priority: 5 - Normal Status: None Assigned to: None Originator Email: Open/Closed: Open Release: Discussion Lock: Any Operating System: None Planned Release: 2.2.x ___ Details: Freeciv 2.2 introduces lots of exciting possibilities for Freeciv content creators, creating maps and scenarios as well as more advanced rulesets. Here we track some of the bugs that make this content creation process harder than it should be, things we should fix in the next bugfix releases. ___ Reply to this item at: http://gna.org/bugs/?15729 ___ Meddelandet skickades via/av Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15729] [Metaticket] Make Scenario editing work well
Update of bug #15729 (project freeciv): Depends on: = bugs #15579 ___ Reply to this item at: http://gna.org/bugs/?15729 ___ Meddelandet skickades via/av Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15721] S2_1 connect (road, irrigation etc) broken: jumbo callbacks for danger maps are not yet implemented.
Follow-up Comment #3, bug #15721 (project freeciv): Attached a fix to get the old behaviour. But keeping ignoring the dangerous position. Note also it prefers pf_fuel_map to pf_danger_map. (file #8707, file #8708, file #8709) ___ Additional Item Attachment: File name: trunk_pf_map_new.diff Size:1 KB File name: S2_2_pf_map_new.diff Size:1 KB File name: S2_1_pf_map_new.diff Size:2 KB ___ Reply to this item at: http://gna.org/bugs/?15721 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15595] Adding new categories
Update of bug #15595 (project freeciv): Severity:1 - Wish = 3 - Normal Priority: 1 - Later = 5 - Normal ___ Follow-up Comment #9: Updated list of requested categories: * common * generator * network * scenario * scripting * server * translation * utility ___ Reply to this item at: http://gna.org/bugs/?15595 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1563] Make improvement upkeep visible in worklist editor
Update of patch #1563 (project freeciv): Status: Ready For Test = In Progress ___ Reply to this item at: http://gna.org/patch/?1563 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1563] Make improvement upkeep visible in worklist editor
Update of patch #1563 (project freeciv): Status: In Progress = Done Open/Closed:Open = Closed Planned Release: = 2.1.12, 2.2.1 ___ Reply to this item at: http://gna.org/patch/?1563 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15728] Inaccuracy in pathfinding from TM_WORST_TIME (e.g., in client-side connect)
Follow-up Comment #3, bug #15728 (project freeciv): Attached a patch that remove the turn mode concept for the trunk branch. Extra note: in ai/aiferry.c::aiferry_find_interested_city() setting parameter.turn_mode after the creation of the pf_map has strictly no effect. (file #8710) ___ Additional Item Attachment: File name: trunk_pf_remove_turn_mode.diff Size:14 KB ___ Reply to this item at: http://gna.org/bugs/?15728 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15730] Pessimistic client-side connect path-finding caused by TM_WORST_TIME emulation
URL: http://gna.org/bugs/?15730 Summary: Pessimistic client-side connect path-finding caused by TM_WORST_TIME emulation Project: Freeciv Submitted by: jtn Submitted on: Sunday 03/28/10 at 17:20 Category: client Severity: 3 - Normal Priority: 5 - Normal Status: Ready For Test Assigned to: jtn Originator Email: Open/Closed: Open Release: Discussion Lock: Any Operating System: None Planned Release: 2.1.12, 2.2.1 ___ Details: Split out from bug #15728 specifically for the issue with client-side connect, which is easy to fix. The reporting of turns to completion is inaccurate in some cases. The cost overestimation could also affect the route chosen. File #8706 attached to that bug fixes it for branches where turn_mode concept will likely continue to exist (S2_1/S2_2). New patch attached here is for trunk, assuming pepeto's patch to abolish turn_mode is applied. (New patch could also be applied as-is to S2_1/S2_2 for the same effect, old patch is only the way it is for consistency / documentation) The fix for bug #15722 is also required for client-side connect turn reporting to be accurate. ___ File Attachments: --- Date: Sunday 03/28/10 at 17:20 Name: trunk-connect-TM_BEST_TIME.diff Size: 1007B By: jtn trunk r17182: version of file #8706 for code without turn_mode concept (also applies cleanly to S2_2/S2_1) http://gna.org/bugs/download.php?file_id=8711 ___ Reply to this item at: http://gna.org/bugs/?15730 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15377] freeciv-gtk2.exe hangs
Follow-up Comment #20, bug #15377 (project freeciv): The patch I sent should fix bug #15658 which appears to be the same as this one. However rather than that patch I think someone should take the time to write proper ascii versions of those functions, just in case we end up with a non-superset-of-ascii locale some day. But I guess that's unlikely so it shouldn't really matter. -jason ___ Reply to this item at: http://gna.org/bugs/?15377 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15728] Inaccuracy in pathfinding from TM_WORST_TIME
Update of bug #15728 (project freeciv): Summary: Inaccuracy in pathfinding from TM_WORST_TIME (e.g., in client-side connect) = Inaccuracy in pathfinding from TM_WORST_TIME ___ Follow-up Comment #4: I've split out my client-side connect change into bug #15730, leaving this one for possible removal of the turn_mode concept. Haven't looked thoroughly at file #8710 yet, but one cosmetic thing: I think the following comment in pf_tools.c should go: /* To ensure triremes behave correctly: FIXME: Probably incorrect now */ ___ Reply to this item at: http://gna.org/bugs/?15728 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15377] freeciv-gtk2.exe hangs
Follow-up Comment #21, bug #15377 (project freeciv): Oh, what a mess this is: the freeciv server of course does not call setlocale anywhere, so it should be running in the C/POSIX locale and these functions should already work with ASCII only on the server side. We missed out on a lot of server bugs here I think (phew!). One argument for not renaming the restricted functions is that we would probably replace every single use of them with the ASCII version. ___ Reply to this item at: http://gna.org/bugs/?15377 ___ Meddelandet skickades via/av Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15731] Trunk GTK client segfault when investigating city
URL:
http://gna.org/bugs/?15731
Summary: Trunk GTK client segfault when investigating city
Project: Freeciv
Submitted by: jtn
Submitted on: Sunday 03/28/10 at 17:57
Category: client-gtk-2.0
Severity: 3 - Normal
Priority: 5 - Normal
Status: None
Assigned to: None
Originator Email:
Open/Closed: Open
Release:
Discussion Lock: Any
Operating System: GNU/Linux
Planned Release: 2.3.0
___
Details:
In attached savegame, use the Spy in Winnipeg to investigate Kompong Speu.
Perhaps a bug in the new city dialog?
#0 0x7f21d707b2fc in g_type_check_instance_cast ()
from /usr/lib/libgobject-2.0.so.0
No symbol table info available.
#1 0x0046a068 in city_dialog_update_citizens (pdialog=0xab84260)
at citydlg.c:1455
citizens = {CITIZEN_HAPPY, CITIZEN_CONTENT, CITIZEN_CONTENT,
CITIZEN_UNHAPPY, CITIZEN_LAST, CITIZEN_HAPPY, 3607578963, 32545, 24, 48,
143602352, 32767, 143602160, 32767, 3602677792, 32545, 3605310976, 32545,
CITIZEN_LAST, CITIZEN_HAPPY, 3598031360, 32545, 38752752, CITIZEN_HAPPY, 8,
CITIZEN_HAPPY, CITIZEN_HAPPY, CITIZEN_HAPPY, 178367504, CITIZEN_HAPPY, 8,
CITIZEN_HAPPY, 16, CITIZEN_HAPPY, 16, CITIZEN_HAPPY, 16, CITIZEN_HAPPY,
3602797273, 32545, 16, CITIZEN_HAPPY, 3602591385, 32545, CITIZEN_HAPPY,
CITIZEN_HAPPY, 3640152005, 32545, 3605310976, 32545, CITIZEN_UNHAPPY,
CITIZEN_HAPPY, 178516400, CITIZEN_HAPPY, 3602561511, 32545, 38752752,
CITIZEN_HAPPY, CITIZEN_UNHAPPY, CITIZEN_HAPPY, 143602416, 32767,
3607499913,
32545, CITIZEN_UNHAPPY, CITIZEN_HAPPY, 143602400, 32767, 178516400,
CITIZEN_HAPPY, 3609806288, 32545, CITIZEN_UNHAPPY, CITIZEN_HAPPY,
3607496349, 32545, 68285680, CITIZEN_HAPPY, 38752752, CITIZEN_HAPPY,
143602480, 32767, 39, CITIZEN_HAPPY, 3598031360, 32545, 143602592, 32767,
178516400, CITIZEN_HAPPY, 16777215, 32545, 143602592, 32767, 179531328,
CITIZEN_HAPPY, CITIZEN_HAPPY, CITIZEN_HAPPY, 179565056, CITIZEN_HAPPY,
38694112, CITIZEN_HAPPY, 178516400, CITIZEN_HAPPY, 143602592, 32767,
63045616, CITIZEN_HAPPY, 178516400, CITIZEN_HAPPY, 170636144,
CITIZEN_HAPPY,
178516400, CITIZEN_HAPPY, 3607490989, 32545, 170636144, CITIZEN_HAPPY,
179847776, CITIZEN_HAPPY, 63045616, CITIZEN_HAPPY, 4628125, CITIZEN_HAPPY,
1262379580, 1869639023, 1394632558, 1014326640, 540959279, 892411949,
808463408, 1768103984, 1702521204, 29550, 179498544, CITIZEN_HAPPY,
CITIZEN_HAPPY, CITIZEN_HAPPY, 3607578963, 32545, 268435457, 48, 143602880,
32767, 143602688, 32767, CITIZEN_HAPPY, CITIZEN_HAPPY, 268435457,
CITIZEN_HAPPY, CITIZEN_HAPPY, CITIZEN_HAPPY, CITIZEN_HAPPY, CITIZEN_HAPPY,
38688928, CITIZEN_HAPPY, 268435457, CITIZEN_HAPPY, CITIZEN_HAPPY,
CITIZEN_HAPPY, 3605310976, 32545, 8, CITIZEN_HAPPY, CITIZEN_CONTENT,
CITIZEN_HAPPY, 16, CITIZEN_HAPPY, 3605310976, CITIZEN_HAPPY, 3602797273,
32545, CITIZEN_CONTENT, CITIZEN_HAPPY, 3602591385, 32545, CITIZEN_HAPPY,
CITIZEN_HAPPY, 3640345867, 32545, CITIZEN_CONTENT, 32545, 3602591263,
32545,
39, CITIZEN_HAPPY, 39, CITIZEN_HAPPY, 3774, CITIZEN_HAPPY, CITIZEN_HAPPY,
CITIZEN_HAPPY, 5658494, CITIZEN_HAPPY, 3607560049, 32545, 24,
CITIZEN_HAPPY,
143602944, 32767...}
i = value optimized out
j = 5
width = 15
pcity = (struct city *) 0xa2bb370
num_citizens = 5
#2 0x0046ae03 in real_city_dialog_refresh (pcity=0xa2bb370)
at citydlg.c:383
pdialog = (struct city_dialog *) 0xab84260
__FUNCTION__ = real_city_dialog_refresh
#3 0x0046c1b1 in create_city_dialog (pcity=0xa2bb370)
at citydlg.c:1369
pdialog = (struct city_dialog *) 0xab84260
close_command = (GtkWidget *) 0xab2ee30
vbox = value optimized out
#4 0x0046c2d0 in real_city_dialog_popup (pcity=0xa2bb370)
at citydlg.c:439
pdialog = (struct city_dialog *) 0x0
#5 0x00461313 in cities_update_callback (data=value optimized
out)
at update_queue.c:337
need_update = CU_NO_UPDATE
myiter = (const struct genlist_link *) 0xa2c2190
pcity = (struct city *) 0xa2bb370
pcity_player = (struct player *) 0x8805f0
MY_i = 4
__FUNCTION__ = cities_update_callback
#6 0x00461733 in update_unqueue (data=value optimized out)
at update_queue.c:185
MY_it_iter = (struct iterator *) 0x7fff088f3720
#7 0x0041345a in idle_callback_wrapper (data=0xa8725b0)
at gui_main.c:2096
No locals.
#8 0x7f21d6bc120a in g_main_context_dispatch ()
from /usr/lib/libglib-2.0.so.0
No symbol table info available.
#9 0x7f21d6bc48e0 in ?? () from /usr/lib/libglib-2.0.so.0
No symbol table info available.
#10 0x7f21d6bc4dad in g_main_loop_run () from /usr/lib/libglib-2.0.so.0
No symbol table info
[Freeciv-Dev] [bug #15731] Trunk GTK client segfault when investigating city
Follow-up Comment #1, bug #15731 (project freeciv): Missed some vital info: this is trunk r17182. ___ Reply to this item at: http://gna.org/bugs/?15731 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1330] update city dialog (gtk-2.0)
Follow-up Comment #14, patch #1330 (project freeciv): Few comments on the new trunk Gtk city dialog layout on trunk (with default rules). Generally, I think I like it. (Any changes from this should probably go in a new ticket) * Overview tab: ** If the dialog is enlarged vertically, the extra space is wasted. It would be good if it were used to show either more improvements (as S2_2) or more units. * Happiness tab: ** Has lost detailed explanations of which buildings/wonders/etc are affecting happiness, but there's plenty of horizontal space to the right of the citizens (and some to the left) even with the minimum dialog size. (Admittedly the available space decreases with increasing city size, which would be a problem for a monster city like file #7251, but for normal cities I think there's plenty of space and in extremis a horizontal scrollbar can be added as for units on the Overview tab.) ** Also seems a bit sparse (Info pane has huge amounts of whitespace), but not a big issue. ___ Reply to this item at: http://gna.org/patch/?1330 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1235] [Metaticket] variable city radii
Follow-up Comment #16, patch #1235 (project freeciv): The SDL client is going to need some work... with the default rules and hence traditional city size, the city map on the city dialog is now unusably small. ___ Reply to this item at: http://gna.org/patch/?1235 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15377] freeciv-gtk2.exe hangs
Update of bug #15377 (project freeciv): Operating System: Microsoft Windows = None ___ Follow-up Comment #22: Please ignore my previous comment. ___ Reply to this item at: http://gna.org/bugs/?15377 ___ Meddelandet skickades via/av Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15663] Custom Scenarios are not show in Start Scenario Game list
Update of bug #15663 (project freeciv): Priority: 1 - Later = 5 - Normal Status:None = Ready For Test Assigned to:None = englabenny Planned Release: = 2.2.1, 2.3.0 ___ Follow-up Comment #4: Patches against 2.2 and trunk. Trunk already shows the scenarios we want to see, so the patch is smaller. We show an information field below the description with the filename (basename) of the scenario, so you can distinguish like-named scenarios (With the expectation that it will occur). Showing the full path would be very ugly and use a lot of space. (file #8713, file #8714) ___ Additional Item Attachment: File name: 0001-Improve-the-GTK-client-Start-Scenario-S2_2.patch Size:6 KB File name: 0001-Improve-the-GTK-client-Start-Scenario-Game-page.patch Size:5 KB ___ Reply to this item at: http://gna.org/bugs/?15663 ___ Meddelandet skickades via/av Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15410] Freeciv does not compile with --enable-debug=yes and GCC 4.2.4
Update of bug #15410 (project freeciv): Summary: Freeciv does not compile with --enable-debug=yes = Freeciv does not compile with --enable-debug=yes and GCC 4.2.4 ___ Reply to this item at: http://gna.org/bugs/?15410 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15377] freeciv-gtk2.exe hangs
Update of bug #15377 (project freeciv): Operating System:None = Microsoft Windows ___ Reply to this item at: http://gna.org/bugs/?15377 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #14205] Bug with utf-8
Follow-up Comment #6, bug #14205 (project freeciv): There is not any culprit other than the too-small buffer. MAX_LEN_NAME+8 is an incorrect byte length since the translated text is not a player name and has no fixed limit; the buffer is just too small. At 40 bytes it is easily enough to fit any real player name but that can be just 10-20 characters in some languages which is not enough. It's a bit of an inconsistency that MAX_LEN_NAME is used in various places as a byte limit (rather than a character limit) on leader/city/ruler names, but this hasn't been a problem so far and is unrelated to this bug report. Do feel free to improve the spacing; using correct spacing leads to a too-long line so I shortened it. From the screenshot, the translated text *is* a bit too long for the column. This isn't a bug but does make for a bad interface, and if the translator can shorten it he should. Hence the TRANS comment. If we really prefer not to use g_strdup_printf we can instead make the buffer really really long. Remember though that utf-8 strings can take up to 4 bytes per character, that here is no fixed limit on how long any translated text may be, and that truncation can potentially cause crashes within gtk2 while making it overlong just makes the interface ugly which the translator can then easily see and fix. I prefer the strdup approach for the client. So in summary, this patch should be all that is needed to fix the problem. I'm preparing a similar patch to fix a lot of other places (several i've noticed will surely trigger this same bug eventually if not fixed). ___ Reply to this item at: http://gna.org/bugs/?14205 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15733] FreeCiv uses wrong folder to store data
URL: http://gna.org/bugs/?15733 Summary: FreeCiv uses wrong folder to store data Project: Freeciv Submitted by: None Submitted on: Sonntag 28.03.2010 um 22:12 CEST Category: client Severity: 3 - Normal Priority: 5 - Normal Status: None Assigned to: None Originator Email: info@gmx.de Open/Closed: Open Release: 2.1.9b1 Discussion Lock: Any Operating System: Mac OS Planned Release: ___ Details: The Document folder on OS X is not for storing program files. To store temporary files there is a folder called ~/Library/Application Support/ Please don't spam the Document folder and use the intended folders. Thanks very much ___ Reply to this item at: http://gna.org/bugs/?15733 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1330] update city dialog (gtk-2.0)
Follow-up Comment #15, patch #1330 (project freeciv): Overview tab: will check; I think more improvements will be easyest Happiness tab: The detailed information can be found as tooltip on top of each of the happiness lines; perhaps add an hint for this? I tried to add the text but it ether increases the dialog horizontal or vertical. ___ Reply to this item at: http://gna.org/patch/?1330 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1235] [Metaticket] variable city radii
Follow-up Comment #17, patch #1235 (project freeciv): you are right; I did not test it I can compile the sdl client but I did not get it to work. I can't start a game as it does not responce to the mouse. I think it is a configuration / library problem. At the moment I don't know how the city dialog looks like for this client ___ Reply to this item at: http://gna.org/patch/?1235 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15734] EFT_MIGRATION_PCT quantised to multiples of 100%
URL: http://gna.org/bugs/?15734 Summary: EFT_MIGRATION_PCT quantised to multiples of 100% Project: Freeciv Submitted by: jtn Submitted on: Sunday 03/28/10 at 21:42 Category: None Severity: 3 - Normal Priority: 5 - Normal Status: Ready For Test Assigned to: jtn Originator Email: Open/Closed: Open Release: 2.2.0 Discussion Lock: Any Operating System: None Planned Release: 2.2.1 ___ Details: Looking at city_migration_score(): score *= (1.0 + get_city_bonus(pcity, EFT_MIGRATION_PCT) / 100); Since get_city_bonus() returns an int, the division will be done in integer arithmetic (and then converted to float for addition to 1.0). This means the sum of EFT_MIGRATION_PCT can't usefully take values other than 0 (normal score), 100 (double score), -100 (zero score regardless of anything), and so on. This doesn't seem very useful. ___ File Attachments: --- Date: Sunday 03/28/10 at 21:42 Name: S2_2-trunk-migration-eft-float.diff Size: 445B By: jtn S2_2/trunk r17182: fix Migration_Pct effect http://gna.org/bugs/download.php?file_id=8715 ___ Reply to this item at: http://gna.org/bugs/?15734 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1235] [Metaticket] variable city radii
Follow-up Comment #18, patch #1235 (project freeciv): Odd, it's working for me. Here's a screenshot FYI. (file #8716) ___ Additional Item Attachment: File name: trunk_r17182_SDL_city.png Size:471 KB ___ Reply to this item at: http://gna.org/patch/?1235 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15735] resize the building info in the gtk city dialog (overview page)
URL: http://gna.org/bugs/?15735 Summary: resize the building info in the gtk city dialog (overview page) Project: Freeciv Submitted by: syntron Submitted on: Sonntag 28.03.2010 um 22:49 Category: client-gtk-2.0 Severity: 3 - Normal Priority: 1 - Later Status: None Assigned to: None Originator Email: Open/Closed: Open Release: Discussion Lock: Any Operating System: None Planned Release: 2.3.0 ___ Details: requested by Jacob Nevinsin patch #1330 ___ File Attachments: --- Date: Sonntag 28.03.2010 um 22:49 Name: 0001-resize-the-building-info-in-the-gtk-city-dialog-over.diff Size: 872B By: syntron http://gna.org/bugs/download.php?file_id=8717 ___ Reply to this item at: http://gna.org/bugs/?15735 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15736] do not scale units with the tileset
URL: http://gna.org/bugs/?15736 Summary: do not scale units with the tileset Project: Freeciv Submitted by: syntron Submitted on: Sonntag 28.03.2010 um 22:50 Category: client-gtk-2.0 Severity: 3 - Normal Priority: 1 - Later Status: None Assigned to: None Originator Email: Open/Closed: Open Release: Discussion Lock: Any Operating System: None Planned Release: 2.3.0 ___ Details: with the variable city radii the city map is scaled for the amplio tileset. This does not mean that a scaling of the present and supported units is needed. ___ File Attachments: --- Date: Sonntag 28.03.2010 um 22:50 Name: 0002-do-not-scale-units-with-the-tileset.diff Size: 2kB By: syntron http://gna.org/bugs/download.php?file_id=8718 ___ Reply to this item at: http://gna.org/bugs/?15736 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1330] update city dialog (gtk-2.0)
Follow-up Comment #16, patch #1330 (project freeciv): The detailed information can be found as tooltip on top of each of the happiness lines (As in, left-click on the citizens.) Excellent, I hadn't spotted that, just the job! It's not very discoverable, but it's consistent with the longstanding Info box in that regard. Perhaps make the labels clickable too (I found I didn't want to click on the citizens, as I'm used to that reassigning specialists, even though that makes no sense here). ___ Reply to this item at: http://gna.org/patch/?1330 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15735] resize the building info in the gtk city dialog (overview page)
Follow-up Comment #1, bug #15735 (project freeciv): Great, thanks! ___ Reply to this item at: http://gna.org/bugs/?15735 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15738] map view not centered at the start
URL: http://gna.org/bugs/?15738 Summary: map view not centered at the start Project: Freeciv Submitted by: syntron Submitted on: Sonntag 28.03.2010 um 23:04 Category: client-gtk-2.0 Severity: 3 - Normal Priority: 1 - Later Status: None Assigned to: None Originator Email: Open/Closed: Open Release: Discussion Lock: Any Operating System: None Planned Release: ___ Details: at the start of the game the map view is not centered on the active unit but the unit is at the top left corner. ___ Reply to this item at: http://gna.org/bugs/?15738 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15739] add text explaining the happiness tooltips
URL: http://gna.org/bugs/?15739 Summary: add text explaining the happiness tooltips Project: Freeciv Submitted by: syntron Submitted on: Sonntag 28.03.2010 um 23:07 Category: None Severity: 3 - Normal Priority: 1 - Later Status: None Assigned to: None Originator Email: Open/Closed: Open Release: Discussion Lock: Any Operating System: None Planned Release: 2.3.0 ___ Details: requested by Jacob Nevins in patch #1330 ___ File Attachments: --- Date: Sonntag 28.03.2010 um 23:07 Name: 0003-add-text-explaining-the-happiness-tooltips.diff Size: 2kB By: syntron http://gna.org/bugs/download.php?file_id=8721 ___ Reply to this item at: http://gna.org/bugs/?15739 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15740] unuseable sdl client
URL: http://gna.org/bugs/?15740 Summary: unuseable sdl client Project: Freeciv Submitted by: syntron Submitted on: Sonntag 28.03.2010 um 23:12 Category: client-sdl Severity: 3 - Normal Priority: 5 - Normal Status: None Assigned to: None Originator Email: Open/Closed: Open Release: svn 16977 Discussion Lock: Any Operating System: None Planned Release: ___ Details: if I start the sdl client only the first menu point is highlighted (startnew game). I can move the mouse over the entire widget but the focus stays there. On a click a new game is started. This way the sdl client is not useable. Info: # sdl-config --version 1.2.14 If additional information are needed please ask ___ Reply to this item at: http://gna.org/bugs/?15740 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15734] EFT_MIGRATION_PCT quantised to multiples of 100%
Follow-up Comment #1, bug #15734 (project freeciv): got catch! It is the second time I did not get a calculation wrong due to integer arithmetic. ___ Reply to this item at: http://gna.org/bugs/?15734 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1235] [Metaticket] variable city radii
Follow-up Comment #19, patch #1235 (project freeciv): too use it some parts have to be moved. One possibility would be to move the units in their own row: [city map ][buildings] [units ] [food][city info][build now] This would change especially the height of the dialog window. I would also switch food / building status. I did found the code in client/gui-sdl/citydlg.c but need (a lot of?) time to understand it ... ___ Reply to this item at: http://gna.org/patch/?1235 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15738] map view not centered at the start
Follow-up Comment #1, bug #15738 (project freeciv): Some digging later: The following is the automatic centering call at game start: 3: In Center on something 3: Center on any unit 3: ptile.x=11, ptile.y=45, gui.x=-1632, gui.y=1344 3: mapwid=1, maphei=1, tilewid=96 3: Enter set_mapview_origin 3: Seeing mapview origin to -1585 x 1367, slide=0 Then a center call I added in the gtk client: 3: ptile.x=11, ptile.y=45, gui.x=-1632, gui.y=1344 3: mapwid=784, maphei=520, tilewid=96 3: Enter set_mapview_origin 3: Seeing mapview origin to 1480 x 1108, slide=1 So the problem seems to be that mapview.width / mapview.height are not initialized yet. The map size is set wheever the GTK+ client's map_canvas sends the configure-event signal, which then happens after game start. The quick workaround is simply a call to center_on_unit() when the game starts / whenever we switch to the GAME page. (file #8722) ___ Additional Item Attachment: File name: center_on_unit_S2_2.diff Size:0 KB ___ Reply to this item at: http://gna.org/bugs/?15738 ___ Meddelandet skickades via/av Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #14205] Bug with utf-8
Follow-up Comment #7, bug #14205 (project freeciv): The attached patch improves buffering in many places using g_strdup_printf instead of fixed-width buffers. In a few locations this was too much work so I just made the buffers bigger instead. As previously mentioned, in several places the current buffers are certainly too small and will trigger bugs if not fixed. (file #8723) ___ Additional Item Attachment: File name: buffers.diff Size:30 KB ___ Reply to this item at: http://gna.org/bugs/?14205 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15741] SDL client crashes in build dialog
URL: http://gna.org/bugs/?15741 Summary: SDL client crashes in build dialog Project: Freeciv Submitted by: jdorje Submitted on: Monday 03/29/2010 at 00:33 Category: client-sdl Severity: 4 - Important Priority: 7 - High Status: Need Info Assigned to: None Originator Email: Open/Closed: Open Release: trunk Discussion Lock: Any Operating System: GNU/Linux Planned Release: ___ Details: Current trunk build. I'm playing a game and in the SDL client shift-click (I think) on colossus. That is to say, within the city dialog I went to change production, and I was playing around with various clickings to try to get the help to come up (which never happened) and after 30 seconds or so it crashed. 1: in copy_chars_to_string16() [gui_string.c::196]: assertion 'pString != ((void *)0)' failed. The above line is output many times, though I'm not sure it's actually related to the crash. Unfortunately I had core files turned off so no backtrace available on this one. ___ Reply to this item at: http://gna.org/bugs/?15741 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15738] map view not centered at the start
Update of bug #15738 (project freeciv): Status:None = Ready For Test Assigned to:None = englabenny Release: = 2.2 Planned Release: = 2.2.1, 2.3.0 ___ Follow-up Comment #2: With this patch, the start units are centered from the first time the map is drawn. Patch for 2.2 and trunk. ___ Reply to this item at: http://gna.org/bugs/?15738 ___ Meddelandet skickades via/av Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15738] map view not centered at the start
Additional Item Attachment, bug #15738 (project freeciv): File name: 0001-Center-map-view-at-start-of-first-game-GTK-client.patch Size:1 KB ___ Reply to this item at: http://gna.org/bugs/?15738 ___ Meddelandet skickades via/av Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15708] API: Fix typo in deprecated method
Update of bug #15708 (project freeciv): Status: Ready For Test = Fixed Open/Closed:Open = Closed ___ Follow-up Comment #1: Fix committed to trunk SVN r17184, it seems I managed to put the wrong bug number in the message. ___ Reply to this item at: http://gna.org/bugs/?15708 ___ Meddelandet skickades via/av Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15742] Client offers pillage select menu even with pillage_select=0 in ruleset
URL: http://gna.org/bugs/?15742 Summary: Client offers pillage select menu even with pillage_select=0 in ruleset Project: Freeciv Submitted by: jtn Submitted on: Monday 03/29/10 at 02:18 Category: client Severity: 3 - Normal Priority: 5 - Normal Status: None Assigned to: None Originator Email: Open/Closed: Open Release: Discussion Lock: Any Operating System: None Planned Release: ___ Details: See attached civ1 savegame. Ask the Settlers to pillage, and a menu will pop up offering Fortress and Railroad; pick the wrong one (Railroad) and you are silently ignored. Not sure what the right fix here is: * if pillage_select=0, call get_preferred_pillage() on the client and ask for that; better for keeping track of which units are doing what on the server, but would be bad if client and server ever got a different answer for get_preferred_pillage() * client asks for special=S_LAST, base=BASE_NONE ___ File Attachments: --- Date: Monday 03/29/10 at 02:18 Name: no-pillage-select.sav.bz2 Size: 11kB By: jtn civ1 savegame from S2_2 (pillage_select=0) http://gna.org/bugs/download.php?file_id=8725 ___ Reply to this item at: http://gna.org/bugs/?15742 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15743] Value of S_LAST is saved in savegame for bases
URL: http://gna.org/bugs/?15743 Summary: Value of S_LAST is saved in savegame for bases Project: Freeciv Submitted by: jtn Submitted on: Monday 03/29/10 at 02:56 Category: general Severity: 3 - Normal Priority: 5 - Normal Status: None Assigned to: None Originator Email: Open/Closed: Open Release: Discussion Lock: Any Operating System: None Planned Release: ___ Details: The comments for enum tile_special_type indicate that S_LAST is an internal value not saved. However, S_LAST is used in the unit structure to indicate that the unit is working on a base (specifically, for ACTIVITY_PILLAGE), so it does get saved. This doesn't break anything now, but if a new special were ever added where S_LAST is now, there would be trouble with old savegames. This needs fixing before that happens. Probably the answer is to allocate something like S_BASE where the current S_LAST is (for use in units only, should never appear on a tile). There'll need to be some careful juggling of the various internal encodings where special/base is encoded into a single value by adding S_LAST to the base ID. ___ Reply to this item at: http://gna.org/bugs/?15743 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15744] Various bugs with pillaging of bases
URL: http://gna.org/bugs/?15744 Summary: Various bugs with pillaging of bases Project: Freeciv Submitted by: jtn Submitted on: Monday 03/29/10 at 03:10 Category: None Severity: 3 - Normal Priority: 5 - Normal Status: None Assigned to: None Originator Email: Open/Closed: Open Release: Discussion Lock: Any Operating System: None Planned Release: ___ Details: Found by code inspection, not all verified to cause visible problems yet. Including: * Pillage select popup includes bases that are already being pillaged. * You can specify a base to pillage, but it gets lost when you save the game, because the unit's activity_base value is only saved if it's doing ACTIVITY_BASE, not ACTIVITY_PILLAGE. Instead you get BASE_NONE (see below). * In the pillage_select=0 case, can_unit_do_activity_targeted_at() checks the value of get_preferred_pillage() without decomposing it into target/base first. (I'd expect this to preventing pillaging fortresses in civ1, but for some reason it doesn't.) * In update_unit_activity(), there seems to be handling for old savegames where base pillaging is indicated by S_LAST+BASE_NONE. This shouldn't happen with current servers, except that the second bug means it will. call_incident() is only called for the targeted case, not the compatibility case. * Again in update_unit_activity() (this time the targeted case), if multiple units are simultaneously pillaging different bases on a tile, when one of them finishes all the rest will be cancelled (bases are treated as the same). Perhaps more to come... ___ Reply to this item at: http://gna.org/bugs/?15744 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15744] Various bugs with pillaging of bases
Follow-up Comment #1, bug #15744 (project freeciv): 4th point: s/base pillaging/untargeted pillaging/ ___ Reply to this item at: http://gna.org/bugs/?15744 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15742] Client offers pillage select menu even with pillage_select=0 in ruleset
Follow-up Comment #1, bug #15742 (project freeciv): Looking at the code, I think S_LAST/BASE_NONE is trouble (see bug #15744). ___ Reply to this item at: http://gna.org/bugs/?15742 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1566] Show pillage activity in middle-click map popup
URL: http://gna.org/patch/?1566 Summary: Show pillage activity in middle-click map popup Project: Freeciv Submitted by: jtn Submitted on: Monday 03/29/10 at 03:22 Category: client Priority: 5 - Normal Status: Ready For Test Privacy: Public Assigned to: jtn Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: ___ Details: Similar to bug #14354 for bases, show pillaging activity in the middle-click map popup. (This will make some of the issues in bug #15744 more obvious.) ___ File Attachments: --- Date: Monday 03/29/10 at 03:22 Name: S2_2-pillage-activity-popup.diff Size: 3kB By: jtn S2_2/trunk r17182: show pillage activity in middle-click popup http://gna.org/patch/download.php?file_id=8727 --- Date: Monday 03/29/10 at 03:22 Name: trunk-pillage-activity-popup.diff Size: 3kB By: jtn S2_2/trunk r17182: show pillage activity in middle-click popup http://gna.org/patch/download.php?file_id=8728 ___ Reply to this item at: http://gna.org/patch/?1566 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
